@atlashub/smartstack-cli 4.48.0 → 4.50.0

package/templates/skills/business-analyse-html/steps/step-02-build-data.md

@@ -89,7 +89,11 @@ modules: master.modules.map(m => ({
   description: m.description || "",
   featureType: m.featureType || "data-centric",
   entities: m.entities || [],
-  anticipatedSections: m.anticipatedSections || [],
+  anticipatedSections: (m.anticipatedSections || []).map(s =>
+    typeof s === 'string'
+      ? { code: s, name: s, description: "", resources: [] }
+      : { code: s.code || s.name || "", name: s.label || s.name || s.code || "", description: s.description || "", resources: s.resources || [], route: s.route || "", permission: s.permission || "" }
+  ),
   dependencies: m.dependencies || [],
   dependents: m.dependents || [],
   estimatedComplexity: m.estimatedComplexity || "medium",
@@ -135,6 +139,50 @@ moduleSpecs[moduleCode] = {
   permissions: buildPermissionKeys(mod.permissions),
   apiEndpoints: mod.usecases?.apiEndpoints || []
 }
+
+// BUILD screens[] for HTML interactive mockups (SmartTable/SmartForm rendering)
+const flatScr = mod.screens?.screens || [];
+let screens = [];
+if (flatScr.length > 0) {
+  const bySec = {};
+  flatScr.forEach(s => {
+    const sec = s.section || "default";
+    if (!bySec[sec]) bySec[sec] = {
+      sectionCode: sec,
+      sectionLabel: s.sectionLabel || s.sectionDescription || sec,
+      resources: []
+    };
+    bySec[sec].resources.push({
+      code: s.screen || s.name || "",
+      label: s.sectionLabel || s.description || s.screen || "",
+      type: s.componentType || "unknown",
+      columns: (s.columns || []).map(c => ({
+        field: c.code || c.field || "", label: c.label || c.code || "",
+        type: c.type || c.dataType || "text", sortable: !!c.sortable
+      })),
+      filters: (s.filters || []).map(f =>
+        typeof f === 'string' ? f : (f.label || f.filterLabel || f.code || f.filterCode || "")),
+      fields: [],
+      tabs: (s.tabs || []).map(t => ({
+        label: t.label || t.tabLabel || t.code || "",
+        fields: (t.fields || []).map(f => ({
+          field: f.code || f.fieldCode || f.field || "",
+          label: f.label || f.code || "",
+          type: f.type || f.dataType || "text",
+          required: !!f.required
+        }))
+      })),
+      actions: (s.actions || []).map(a =>
+        typeof a === 'string' ? a : (a.code || a.label || a.actionCode || "")),
+      kpis: s.kpis || [],
+      options: s.options || [],
+      permission: s.permission || "",
+      notes: s.description || ""
+    });
+  });
+  screens = Object.values(bySec);
+}
+moduleSpecs[moduleCode].screens = screens;
 ```
 
 > See `references/data-mapping.md` for `buildPermissionKeys()` implementation.
@@ -156,6 +204,44 @@ FEATURE_DATA.modules.forEach(m => {
 
 > This step is CRITICAL for the HTML viewer to display UC/BR grouped by section.
 
+### Post-Build Self-Check (MANDATORY — BLOCKING)
+
+After enriching anticipatedSections, run this self-check to detect data loss:
+
+```javascript
+// SELF-CHECK: compare source file counts vs FEATURE_DATA counts
+const errors = [];
+FEATURE_DATA.modules.forEach(m => {
+  const spec = FEATURE_DATA.moduleSpecs[m.code];
+  const source = collected_data.modules[m.code];
+  if (!spec) { errors.push(`MISSING moduleSpecs[${m.code}]`); return; }
+
+  const srcUC = (source?.usecases?.useCases || []).length;
+  const bltUC = (spec.useCases || []).length;
+  if (srcUC > 0 && bltUC === 0)
+    errors.push(`${m.code}: useCases EMPTY but source has ${srcUC}`);
+
+  const srcBR = (source?.rules?.rules || []).length;
+  const bltBR = (spec.businessRules || []).length;
+  if (srcBR > 0 && bltBR === 0)
+    errors.push(`${m.code}: businessRules EMPTY but source has ${srcBR}`);
+
+  const srcEnt = (source?.entities?.entities || []).length;
+  const bltEnt = (spec.entities || []).length;
+  if (srcEnt > 0 && bltEnt === 0)
+    errors.push(`${m.code}: entities EMPTY but source has ${srcEnt}`);
+});
+
+if (errors.length > 0) {
+  Display("⛔ SELF-CHECK FAILED — data loss detected:");
+  errors.forEach(e => Display("  - " + e));
+  // FIX: re-map the failing modules from collected_data before continuing
+}
+```
+
+> If self-check detects errors, you MUST re-read the source data and re-build the failing moduleSpecs entries.
+> Do NOT proceed with empty arrays when source data exists.
+
 **consolidation:**
 ```javascript
 consolidation: {
@@ -223,6 +309,31 @@ for (const section of sections) {
   }
 }
 
+// Source C: screens without mockup → auto-generate text description as wireframe fallback
+const screensWithoutMockup = flatScreens.filter(s => !s.mockup && !s.mockupFormat);
+for (const screen of screensWithoutMockup) {
+  const type = screen.componentType || "";
+  let desc = "";
+  if (type.includes("Table") || type.includes("Grid")) {
+    const cols = screen.columns || [];
+    desc = "Tableau avec " + cols.length + " colonnes : " + cols.map(c => c.label || c.code).join(", ");
+  } else if (type.includes("Form")) {
+    const tabs = screen.tabs || [];
+    desc = "Formulaire " + (tabs.length > 0 ? "avec " + tabs.length + " onglet(s)" : "");
+  } else if (type.includes("Dashboard")) {
+    desc = "Tableau de bord avec KPIs";
+  } else if (type.includes("Kanban")) {
+    desc = "Vue Kanban";
+  }
+  if (desc) {
+    rawWireframes.push({
+      screen: screen.screen || "", section: screen.section || "",
+      mockupFormat: "text", mockup: desc,
+      description: screen.sectionDescription || "", elements: [], componentMapping: []
+    });
+  }
+}
+
 // STEP 2: Map to HTML format (RENAME: mockupFormat → format, mockup → content)
 wireframes: {
   [moduleCode]: rawWireframes.map(wf => ({
@@ -287,6 +398,7 @@ dependencyGraph: {
 - FEATURE_DATA.moduleSpecs must have ONE entry per module
 - cadrage.scope uses HTML keys (inscope/outofscope)
 - Wireframe fields use format/content (NOT mockupFormat/mockup)
+- Per-module: useCases/businessRules/entities count must match source (empty when source has data = BUG)
 
 ## NEXT STEP
 

package/templates/skills/business-analyse-html/steps/step-04-verify.md

@@ -8,7 +8,7 @@ model: opus
 
 ## YOUR TASK
 
-Run 5 blocking validations on the generated HTML file and display the completion summary.
+Run 6 blocking validations on the generated HTML file and display the completion summary.
 
 ---
 
@@ -53,6 +53,22 @@ FOR each module in FEATURE_DATA.modules:
     BLOCKING_ERROR("Module {module.code} not in wireframes")
 ```
 
+**Check 6 — Per-module data completeness (source vs HTML):**
+```
+FOR each module in FEATURE_DATA.modules:
+  Read source: docs/{app}/{module.code}/business-analyse/v{version}/usecases.json
+  sourceUCCount = count of useCases in source file
+  htmlUCCount = count in FEATURE_DATA.moduleSpecs[module.code].useCases
+  IF sourceUCCount > 0 AND htmlUCCount === 0:
+    BLOCKING_ERROR("Module {module.code}: 0 useCases in HTML but {sourceUCCount} in source")
+
+  Read source: docs/{app}/{module.code}/business-analyse/v{version}/rules.json
+  sourceBRCount = count of rules in source file
+  htmlBRCount = count in FEATURE_DATA.moduleSpecs[module.code].businessRules
+  IF sourceBRCount > 0 AND htmlBRCount === 0:
+    BLOCKING_ERROR("Module {module.code}: 0 businessRules in HTML but {sourceBRCount} in source")
+```
+
 > **IF any check fails:** fix the issue and re-run the failing step before completing.
 
 ---

package/templates/skills/controller/references/mcp-scaffold-workflow.md

@@ -220,14 +220,18 @@ console.log(`✅ All checks passed — controller ready for step-04`);
 If MCP doesn't generate [NavRoute] attribute:
 
 ```csharp
-// Manually add if missing:
+// Manually add — REPLACE [Route] with [NavRoute], do NOT keep both (causes 404s):
 [ApiController]
-[Route("api/[controller]")]
-[NavRoute("app.module.resource")]  // <-- Add this line
+[NavRoute("app.module.resource")]
+[Microsoft.AspNetCore.Authorization.Authorize]
+[Produces("application/json")]
+[Tags("{EntityNamePlural}")]
 public class {EntityName}Controller : ControllerBase
 {
   // ...
 }
 ```
 
-But this indicates MCP failure and should not be needed in normal operation.
+**CRITICAL:** Remove `[Route("api/...")]` if present — combining `[Route]` and `[NavRoute]` causes 404 errors.
+
+This indicates MCP failure and should not be needed in normal operation.

package/templates/skills/controller/steps/step-05-validate.md

@@ -40,8 +40,8 @@ mcp__smartstack__validate_conventions:
 
 | Convention | Check | Status |
 |------------|-------|--------|
-| Route attribute | `[Route("api/{area}/[controller]")]` | ✅/❌ |
-| Authorize attribute | `[Authorize]` present | ✅/❌ |
+| NavRoute attribute | `[NavRoute("{app}.{module}")]` present (NOT `[Route]`) | ✅/❌ |
+| Authorize attribute | `[Microsoft.AspNetCore.Authorization.Authorize]` (fully qualified) | ✅/❌ |
 | RequirePermission | Uses `Permissions.*` constants | ✅/❌ |
 | ProducesResponseType | All endpoints documented | ✅/❌ |
 | Logging | All CRUD operations logged | ✅/❌ |

package/templates/skills/controller/templates.md

@@ -30,12 +30,13 @@ using SmartStack.Domain.{DomainNamespace};
 namespace SmartStack.Api.Controllers.{Area};
 
 [ApiController]
-[Route("api/{area-kebab}/{module-kebab}")]
-[Authorize]
+[NavRoute("{area}.{module}")]
+[Microsoft.AspNetCore.Authorization.Authorize]
+[Produces("application/json")]
 [Tags("{Module}")]
 public class {Module}Controller : ControllerBase
 {
-    private readonly IApplicationDbContext _context;
+    private readonly ISender _mediator;  // MediatR — NOT IApplicationDbContext
     private readonly ICurrentUserService _currentUser;
     private readonly ILogger<{Module}Controller> _logger;
 

package/templates/skills/feature-full/steps/step-01-implementation.md

@@ -58,15 +58,28 @@ services.AddScoped<I{Entity}Service, {Entity}Service>();
 ## Phase 5: API
 
 ```csharp
-[ApiController][Route("api/{area}/{module}")][Authorize]
+[ApiController]
+[NavRoute("{area}.{module}")]
+[Microsoft.AspNetCore.Authorization.Authorize]
+[Produces("application/json")]
+[Tags("{EntityPlural}")]
 public class {Entity}Controller : ControllerBase
 {
-    [HttpGet][RequirePermission(Permissions.{Area}.{Module}.View)]
-    [ProducesResponseType(typeof(PaginatedResult<{Entity}Dto>), 200)]
+    private readonly ISender _mediator;
+
+    [HttpGet]
+    [RequirePermission(Permissions.{Area}.{Module}.View)]
+    [ProducesResponseType(typeof(PaginatedResult<{Entity}Dto>), StatusCodes.Status200OK)]
+    [ProducesResponseType(StatusCodes.Status401Unauthorized)]
+    [ProducesResponseType(StatusCodes.Status403Forbidden)]
     public async Task<ActionResult<PaginatedResult<{Entity}Dto>>> GetAll(...);
 
-    [HttpPost][RequirePermission(Permissions.{Area}.{Module}.Create)]
-    [ProducesResponseType(typeof({Entity}Dto), 201)]
+    [HttpPost]
+    [RequirePermission(Permissions.{Area}.{Module}.Create)]
+    [ProducesResponseType(typeof({Entity}Dto), StatusCodes.Status201Created)]
+    [ProducesResponseType(StatusCodes.Status400BadRequest)]
+    [ProducesResponseType(StatusCodes.Status401Unauthorized)]
+    [ProducesResponseType(StatusCodes.Status403Forbidden)]
     public async Task<ActionResult<{Entity}Dto>> Create([FromBody] request, CancellationToken ct);
 }
 ```