@atlashub/smartstack-cli 4.47.0 → 4.49.0

package/templates/skills/business-analyse-html/steps/step-02-build-data.md

@@ -198,13 +198,34 @@ handoff: {
 
 ```javascript
 const mod = collected_data.modules[moduleCode];
-const screens = mod.screens?.screens || [];
 
-// Extract wireframes from screens that have mockup/wireframe data
+// STEP 1: Collect wireframe sources from BOTH flat and nested structures
+// Flat: mod.screens.screens[] with mockupFormat/mockup at top level
+// Nested: mod.screens.sections[].resources[].wireframe (design step output)
+let rawWireframes = [];
+
+// Source A: flat screens[] array (original BA output or manually enriched)
+const flatScreens = mod.screens?.screens || [];
+rawWireframes.push(...flatScreens.filter(s => s.mockup || s.mockupFormat));
+
+// Source B: nested sections[].resources[].wireframe (design step output)
+const sections = mod.screens?.sections || [];
+for (const section of sections) {
+  for (const resource of (section.resources || [])) {
+    if (resource.wireframe) {
+      // Unwrap nested wireframe and add section context
+      rawWireframes.push({
+        ...resource.wireframe,
+        section: resource.wireframe.section || section.sectionCode || "",
+        screen: resource.wireframe.screen || `${section.sectionCode}-${resource.code}` || ""
+      });
+    }
+  }
+}
+
+// STEP 2: Map to HTML format (RENAME: mockupFormat → format, mockup → content)
 wireframes: {
-  [moduleCode]: screens
-    .filter(s => s.wireframe || s.mockup || s.mockupFormat)
-    .map(wf => ({
+  [moduleCode]: rawWireframes.map(wf => ({
       screen: wf.screen || wf.name || wf.title || wf.id || "",
       section: wf.section || "",
       format: wf.mockupFormat || "ascii",                   // RENAME: mockupFormat → format

package/templates/skills/controller/references/mcp-scaffold-workflow.md

@@ -220,14 +220,18 @@ console.log(`✅ All checks passed — controller ready for step-04`);
 If MCP doesn't generate [NavRoute] attribute:
 
 ```csharp
-// Manually add if missing:
+// Manually add — REPLACE [Route] with [NavRoute], do NOT keep both (causes 404s):
 [ApiController]
-[Route("api/[controller]")]
-[NavRoute("app.module.resource")]  // <-- Add this line
+[NavRoute("app.module.resource")]
+[Microsoft.AspNetCore.Authorization.Authorize]
+[Produces("application/json")]
+[Tags("{EntityNamePlural}")]
 public class {EntityName}Controller : ControllerBase
 {
   // ...
 }
 ```
 
-But this indicates MCP failure and should not be needed in normal operation.
+**CRITICAL:** Remove `[Route("api/...")]` if present — combining `[Route]` and `[NavRoute]` causes 404 errors.
+
+This indicates MCP failure and should not be needed in normal operation.

package/templates/skills/controller/steps/step-05-validate.md

@@ -40,8 +40,8 @@ mcp__smartstack__validate_conventions:
 
 | Convention | Check | Status |
 |------------|-------|--------|
-| Route attribute | `[Route("api/{area}/[controller]")]` | ✅/❌ |
-| Authorize attribute | `[Authorize]` present | ✅/❌ |
+| NavRoute attribute | `[NavRoute("{app}.{module}")]` present (NOT `[Route]`) | ✅/❌ |
+| Authorize attribute | `[Microsoft.AspNetCore.Authorization.Authorize]` (fully qualified) | ✅/❌ |
 | RequirePermission | Uses `Permissions.*` constants | ✅/❌ |
 | ProducesResponseType | All endpoints documented | ✅/❌ |
 | Logging | All CRUD operations logged | ✅/❌ |

package/templates/skills/controller/templates.md

@@ -30,12 +30,13 @@ using SmartStack.Domain.{DomainNamespace};
 namespace SmartStack.Api.Controllers.{Area};
 
 [ApiController]
-[Route("api/{area-kebab}/{module-kebab}")]
-[Authorize]
+[NavRoute("{area}.{module}")]
+[Microsoft.AspNetCore.Authorization.Authorize]
+[Produces("application/json")]
 [Tags("{Module}")]
 public class {Module}Controller : ControllerBase
 {
-    private readonly IApplicationDbContext _context;
+    private readonly ISender _mediator;  // MediatR — NOT IApplicationDbContext
     private readonly ICurrentUserService _currentUser;
     private readonly ILogger<{Module}Controller> _logger;
 

package/templates/skills/feature-full/steps/step-01-implementation.md

@@ -58,15 +58,28 @@ services.AddScoped<I{Entity}Service, {Entity}Service>();
 ## Phase 5: API
 
 ```csharp
-[ApiController][Route("api/{area}/{module}")][Authorize]
+[ApiController]
+[NavRoute("{area}.{module}")]
+[Microsoft.AspNetCore.Authorization.Authorize]
+[Produces("application/json")]
+[Tags("{EntityPlural}")]
 public class {Entity}Controller : ControllerBase
 {
-    [HttpGet][RequirePermission(Permissions.{Area}.{Module}.View)]
-    [ProducesResponseType(typeof(PaginatedResult<{Entity}Dto>), 200)]
+    private readonly ISender _mediator;
+
+    [HttpGet]
+    [RequirePermission(Permissions.{Area}.{Module}.View)]
+    [ProducesResponseType(typeof(PaginatedResult<{Entity}Dto>), StatusCodes.Status200OK)]
+    [ProducesResponseType(StatusCodes.Status401Unauthorized)]
+    [ProducesResponseType(StatusCodes.Status403Forbidden)]
     public async Task<ActionResult<PaginatedResult<{Entity}Dto>>> GetAll(...);
 
-    [HttpPost][RequirePermission(Permissions.{Area}.{Module}.Create)]
-    [ProducesResponseType(typeof({Entity}Dto), 201)]
+    [HttpPost]
+    [RequirePermission(Permissions.{Area}.{Module}.Create)]
+    [ProducesResponseType(typeof({Entity}Dto), StatusCodes.Status201Created)]
+    [ProducesResponseType(StatusCodes.Status400BadRequest)]
+    [ProducesResponseType(StatusCodes.Status401Unauthorized)]
+    [ProducesResponseType(StatusCodes.Status403Forbidden)]
     public async Task<ActionResult<{Entity}Dto>> Create([FromBody] request, CancellationToken ct);
 }
 ```