@atlashub/smartstack-cli 4.45.0 → 4.46.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlashub/smartstack-cli",
-  "version": "4.45.0",
+  "version": "4.46.0",
   "description": "SmartStack Claude Code automation toolkit - GitFlow, EF Core migrations, prompts and more",
   "author": {
     "name": "SmartStack",

package/templates/skills/business-analyse-handoff/references/acceptance-criteria.md

@@ -16,8 +16,8 @@
 | `entities.json` | Entity definitions | `entities[]` | — |
 | `rules.json` | Business rules | `rules[]` | `businessRules[]` |
 | `usecases.json` | Use cases | `useCases[]` | `usecases[]` (lowercase) |
-| `permissions.json` | Roles and permission matrix | `permissionPaths[]` | `permissionSet.permissions[]`, `permissions[]`, `actions[]` |
-| `screens.json` | UI screen specifications | `screens[]` | `sections[].resources[]` |
+| `permissions.json` | Roles and permission matrix | `permissionPaths[]` | `permissionSet.permissions[]`, `basePermissions[]`, `actions[]`, `permissions[]` |
+| `screens.json` | UI screen specifications | `screens[]` | `sections[].resources[]`, `sections[]`, `wireframes[]` |
 
 The validation script **assembles** these files before checking.
 
@@ -66,17 +66,30 @@ const fs = require('fs');
 const path = require('path');
 const dir = process.argv[1];
 
-// Load index.json
-const index = JSON.parse(fs.readFileSync(path.join(dir, 'index.json'), 'utf-8'));
+// Load index.json (optional — may not exist at module level)
+let index = {};
+const indexPath = path.join(dir, 'index.json');
+if (fs.existsSync(indexPath)) {
+  index = JSON.parse(fs.readFileSync(indexPath, 'utf-8'));
+}
 const files = index.files || {};
 
-// Load flat files (with fallbacks)
+// Load flat files: try index.json refs first, fallback to direct file load
 function loadFile(key) {
+  // Strategy 1: resolve via index.json > files references
   const ref = files[key];
-  if (!ref || !ref.path) return null;
-  const filePath = path.join(dir, ref.path);
-  if (!fs.existsSync(filePath)) return null;
-  return JSON.parse(fs.readFileSync(filePath, 'utf-8'));
+  if (ref && ref.path) {
+    const filePath = path.join(dir, ref.path);
+    if (fs.existsSync(filePath)) {
+      return JSON.parse(fs.readFileSync(filePath, 'utf-8'));
+    }
+  }
+  // Strategy 2: direct file load (module dirs without index.json)
+  const directPath = path.join(dir, key + '.json');
+  if (fs.existsSync(directPath)) {
+    return JSON.parse(fs.readFileSync(directPath, 'utf-8'));
+  }
+  return null;
 }
 
 const entitiesData = loadFile('entities') || {};
@@ -91,19 +104,40 @@ const hasReferencedEntities = (entitiesData.referencedEntities || []).length > 0
 const useCases = usecasesData.useCases || usecasesData.usecases || [];
 const rules = rulesData.rules || rulesData.businessRules || [];
 
-// Permissions: canonical permissionPaths[] OR extract from nested structures
-const permissions = permissionsData.permissionPaths
-  || (permissionsData.permissionSet && permissionsData.permissionSet.permissions || []).map(function(p) { return p.code || p.path || ''; })
-  || (permissionsData.permissions || []).map(function(p) { return typeof p === 'string' ? p : (p.code || p.path || ''); })
-  || (permissionsData.actions || []).map(function(a) { return a.code || ''; })
-  || [];
-
-// Screens: canonical screens[] OR flatten sections[].resources[]
-const screens = screensData.screens || [];
-const sectionsAsScreens = (screensData.sections || []).reduce(function(acc, s) { return acc.concat(s.resources || []); }, []);
-const allScreens = screens.length > 0 ? screens : sectionsAsScreens;
+// Permissions: try all known variants, extract into flat array
+function extractPermissions(data) {
+  if (data.permissionPaths && data.permissionPaths.length > 0) return data.permissionPaths;
+  if (data.permissionSet && data.permissionSet.permissions && data.permissionSet.permissions.length > 0) {
+    return data.permissionSet.permissions.map(function(p) { return p.code || p.path || ''; });
+  }
+  if (data.basePermissions && data.basePermissions.length > 0) {
+    return data.basePermissions.map(function(p) { return p.code || p.path || ''; });
+  }
+  if (data.actions && data.actions.length > 0) {
+    return data.actions.map(function(a) { return a.code || ''; });
+  }
+  if (data.permissions && data.permissions.length > 0) {
+    return data.permissions.map(function(p) { return typeof p === 'string' ? p : (p.code || p.path || ''); });
+  }
+  return [];
+}
+const permissions = extractPermissions(permissionsData);
+
+// Screens: canonical screens[] OR sections[] (with or without .resources sub-array)
+function extractScreens(data) {
+  if (data.screens && data.screens.length > 0) return data.screens;
+  if (data.sections && data.sections.length > 0) {
+    // sections may contain resources[] or be screens themselves
+    var fromResources = data.sections.reduce(function(acc, s) { return acc.concat(s.resources || []); }, []);
+    return fromResources.length > 0 ? fromResources : data.sections;
+  }
+  if (data.wireframes && data.wireframes.length > 0) return data.wireframes;
+  return [];
+}
+const allScreens = extractScreens(screensData);
 
-const status = index.metadata?.status || 'unknown';
+// Status: from index.json if present, or 'specified' if module has thematic files but no index.json
+const status = (index.metadata && index.metadata.status) || (Object.keys(index).length === 0 ? 'specified' : 'unknown');
 
 const fails = [];
 

package/templates/skills/business-analyse-handoff/steps/step-00-validate.md

@@ -71,32 +71,27 @@ FOR each module:
 
 ### 4. Load Flat Files Per Module
 
-For each module, load the separate JSON files referenced in `index.json > files`:
+For each module, load the separate JSON files directly (index.json may not exist at module level):
 
 ```javascript
-// Module index.json contains file references:
-// { "files": { "entities": { "path": "entities.json" }, "usecases": { "path": "usecases.json" }, ... } }
-
-const entitiesData = READ(moduleDir + '/entities.json');
-const usecasesData = READ(moduleDir + '/usecases.json');
-const rulesData = READ(moduleDir + '/rules.json');
-const permissionsData = READ(moduleDir + '/permissions.json');
-const screensData = READ(moduleDir + '/screens.json');
+// Load thematic files directly from module directory
+const entitiesData = READ(moduleDir + '/entities.json') || {};
+const usecasesData = READ(moduleDir + '/usecases.json') || {};
+const rulesData = READ(moduleDir + '/rules.json') || {};
+const permissionsData = READ(moduleDir + '/permissions.json') || {};
+const screensData = READ(moduleDir + '/screens.json') || {};
 
 // NORMALISATION: tolerate ba-writer + LLM field name variants
+// See acceptance-criteria.md for the full extraction functions
 const moduleData = {
-  index: READ(moduleDir + '/index.json'),
   entities: entitiesData.entities || [],
   hasReferencedEntities: (entitiesData.referencedEntities || []).length > 0,
   useCases: usecasesData.useCases || usecasesData.usecases || [],
   rules: rulesData.rules || rulesData.businessRules || [],
-  permissions: permissionsData.permissionPaths
-    || (permissionsData.permissionSet?.permissions || []).map(p => p.code || p.path)
-    || (permissionsData.permissions || []).map(p => typeof p === 'string' ? p : (p.code || p.path))
-    || [],
-  screens: (screensData.screens || []).length > 0
-    ? screensData.screens
-    : (screensData.sections || []).flatMap(s => s.resources || [])
+  permissions: extractPermissions(permissionsData),
+    // tries: permissionPaths > permissionSet.permissions > basePermissions > actions > permissions
+  screens: extractScreens(screensData),
+    // tries: screens > sections[].resources > sections > wireframes
 };
 ```