@atlashub/smartstack-cli 4.37.0 → 4.39.0

package/templates/skills/efcore/references/shared-init-functions.md

@@ -58,7 +58,7 @@ the .NET SDK may not be found even if `dotnet-ef` is. Use `$USERPROFILE` first o
 ```bash
 detect_efcore_project() {
   # Find project with EF Core reference
-  CSPROJ=$(find . -name "*.csproj" -exec grep -l "Microsoft.EntityFrameworkCore" {} \; | head -1)
+  CSPROJ=$(find src-name "*.csproj" -exec grep -l "Microsoft.EntityFrameworkCore" {} \; | head -1)
 
   if [ -z "$CSPROJ" ]; then
     echo "ERROR: No EF Core project found"
@@ -70,8 +70,8 @@ detect_efcore_project() {
   MIGRATIONS_DIR="$PROJECT_DIR/Persistence/Migrations"
 
   # Find startup and infrastructure projects
-  STARTUP_PROJECT=$(find . -name "*.Api.csproj" -o -name "*Web.csproj" | head -1)
-  INFRA_PROJECT=$(find . -name "*Infrastructure.csproj" | head -1)
+  STARTUP_PROJECT=$(find src-name "*.Api.csproj" -o -name "*Web.csproj" | head -1)
+  INFRA_PROJECT=$(find src-name "*Infrastructure.csproj" | head -1)
   [ -z "$INFRA_PROJECT" ] && INFRA_PROJECT="$CSPROJ"
 
   echo "Project: $PROJECT_NAME"
@@ -84,7 +84,7 @@ detect_efcore_project() {
 ```bash
 detect_dbcontext() {
   # Priority 1: SmartStack.Domain exists → SmartStack source project (Core only)
-  if find . -type d -name "SmartStack.Domain" | grep -q .; then
+  if find src-type d -name "SmartStack.Domain" | grep -q .; then
     DBCONTEXT="CoreDbContext"
     DBCONTEXT_TYPE="core"
     SCHEMA="core"
@@ -94,7 +94,7 @@ detect_dbcontext() {
   fi
 
   # Priority 2: Client project with SmartStack NuGet → BOTH contexts
-  if find . -name "*.csproj" -exec grep -ql "PackageReference.*SmartStack" {} \; 2>/dev/null; then
+  if find src-name "*.csproj" -exec grep -ql "PackageReference.*SmartStack" {} \; 2>/dev/null; then
     DBCONTEXT="CoreDbContext"
     DBCONTEXT_TYPE="both"
     SCHEMA="core"
@@ -105,8 +105,8 @@ detect_dbcontext() {
   fi
 
   # Priority 3: Scan for DbContext in code
-  CORE_CTX=$(find . -name "*.cs" -exec grep -l "CoreDbContext" {} \; 2>/dev/null | head -1)
-  EXT_CTX=$(find . -name "*.cs" -exec grep -l "ExtensionsDbContext" {} \; 2>/dev/null | head -1)
+  CORE_CTX=$(find src-name "*.cs" -exec grep -l "CoreDbContext" {} \; 2>/dev/null | head -1)
+  EXT_CTX=$(find src-name "*.cs" -exec grep -l "ExtensionsDbContext" {} \; 2>/dev/null | head -1)
 
   if [ -n "$CORE_CTX" ] && [ -n "$EXT_CTX" ]; then
     DBCONTEXT="CoreDbContext"
@@ -137,7 +137,7 @@ detect_dbcontext() {
 
 ```bash
 detect_environment() {
-  API_DIR=$(find . -type d -name "*.Api" | head -1)
+  API_DIR=$(find src-type d -name "*.Api" | head -1)
   [ -z "$API_DIR" ] && API_DIR="src/SmartStack.Api"
 
   # Priority: --env flag > appsettings.Local.json > error

package/templates/skills/efcore/references/sql-objects-injection.md

@@ -1,61 +1,19 @@
-# SQL Objects Injection
+# SQL Objects Management
 
-EF Core does NOT generate DDL for TVF, views, and stored procedures.
-SQL source scripts are in `Persistence/SqlObjects/` (Embedded Resources).
-After a migration/squash/rebase, they must be re-injected into the consolidated migration.
+EF Core does NOT generate DDL for TVFs, views, and stored procedures.
+SQL source scripts are in `Persistence/SqlObjects/` (Embedded Resources, `CREATE OR ALTER`).
 
-## Injection Process
+## Automatic Startup Deployment
 
-```bash
-# Check if SqlObjects folder exists with .sql files
-SQL_OBJECTS_DIR="$INFRA_PROJECT_DIR/Persistence/SqlObjects"
-SQL_FILES=$(find "$SQL_OBJECTS_DIR" -name "*.sql" 2>/dev/null | wc -l)
+SQL objects are applied **automatically at application startup** via `SqlObjectHelper.ApplyAllAsync(dbContext)` in `SmartStackExtensions.InitializeSmartStackAsync()`, right after `MigrateAsync()`.
 
-if [ "$SQL_FILES" -gt 0 ]; then
-  echo ""
-  echo "Found $SQL_FILES SQL object(s) in SqlObjects/"
-  echo "Injecting SqlObjectHelper.ApplyAll(migrationBuilder) into migration..."
+**No migration injection is needed.** To add or modify a SQL object:
 
-  # Validate migration file path before sed operations
-  if [ ! -f "$MIGRATION_FILE" ]; then
-    echo "ERROR: Migration file not found: $MIGRATION_FILE"
-    exit 1
-  fi
-  if ! echo "$MIGRATION_FILE" | grep -qE '\.cs$'; then
-    echo "ERROR: Invalid migration file path (not .cs): $MIGRATION_FILE"
-    exit 1
-  fi
+1. Create or edit the `.sql` file in `Persistence/SqlObjects/{Functions,Views,StoredProcedures}/`
+2. Ensure it uses `CREATE OR ALTER` (idempotent)
+3. Ensure `.csproj` has `<EmbeddedResource Include="Persistence\SqlObjects\**\*.sql" />`
+4. Restart the application — the SQL object is deployed automatically
 
-  # Add using directive if not present
-  if ! grep -q "using SmartStack.Infrastructure.Persistence.SqlObjects;" "$MIGRATION_FILE"; then
-    sed -i '1s/^/using SmartStack.Infrastructure.Persistence.SqlObjects;\n/' "$MIGRATION_FILE"
-  fi
+## Legacy Note
 
-  # Add SqlObjectHelper.ApplyAll at the end of Up() method
-  sed -i '/protected override void Up/,/^        }/ {
-    /^        }/ i\
-\            // Apply SQL objects (TVF, Views, SP) from embedded resources\
-\            SqlObjectHelper.ApplyAll(migrationBuilder);
-  }' "$MIGRATION_FILE"
-
-  # Verify injection succeeded (fallback to manual step if sed pattern didn't match)
-  if ! grep -q "SqlObjectHelper.ApplyAll" "$MIGRATION_FILE"; then
-    echo "WARNING: Automatic injection failed (indentation pattern may differ)"
-    echo ""
-    echo "MANUAL STEP REQUIRED: Add these lines inside the Up() method before the closing brace:"
-    echo '    using SmartStack.Infrastructure.Persistence.SqlObjects;'
-    echo '    ...'
-    echo '    SqlObjectHelper.ApplyAll(migrationBuilder);'
-    echo ""
-    echo "File: $MIGRATION_FILE"
-  else
-    echo "  SqlObjectHelper.ApplyAll(migrationBuilder) injected"
-  fi
-  find "$SQL_OBJECTS_DIR" -name "*.sql" -exec basename {} \; | while read f; do
-    echo "  - $f"
-  done
-else
-  echo ""
-  echo "No SQL objects found in SqlObjects/ - skipping injection"
-fi
-```
+Older migrations may still contain `SqlObjectHelper.ApplyAll(migrationBuilder)` calls. These are harmless (idempotent) but no longer required. New migrations should NOT include this call.

package/templates/skills/efcore/references/zero-downtime-patterns.md

@@ -2,6 +2,8 @@
 Zero-downtime migration patterns for EF Core. Use when a migration contains destructive operations (column rename, type change, column drop) that could cause downtime during deployment.
 
 These patterns apply to production deployments where the application runs continuously. For development environments, standard migrations are sufficient.
+
+> **Exception to "no raw SQL" rule:** `migrationBuilder.Sql(...)` is authorized ONLY for data backfill operations within zero-downtime migration patterns (e.g., `UPDATE ... SET NewCol = OldCol`). Never use it for DDL (CREATE/ALTER/DROP) — those must go through EF Core Fluent API or `SqlObjects/`.
 </overview>
 
 <when_to_use>

package/templates/skills/gitflow/phases/cleanup.md

@@ -60,9 +60,21 @@ while read -r line; do
     continue
   fi
 
+  # Skip permanent branches
+  [[ "$WT_BRANCH" == "$GF_MAIN_BRANCH" ]] || [[ "$WT_BRANCH" == "$GF_DEVELOP_BRANCH" ]] && {
+    VALID+=("$WT_PATH:$WT_BRANCH")
+    continue
+  }
+
   # Check if branch still exists on remote
   REMOTE_EXISTS=$(git branch -r --list "origin/$WT_BRANCH" | wc -l)
-  if [ "$REMOTE_EXISTS" -eq 0 ] && [[ "$WT_BRANCH" != "$GF_MAIN_BRANCH" ]] && [[ "$WT_BRANCH" != "$GF_DEVELOP_BRANCH" ]]; then
+
+  # Check if branch is merged into develop or main
+  MERGED_INTO_DEVELOP=$(git branch --merged "$GF_DEVELOP_BRANCH" | grep -c "$WT_BRANCH" 2>/dev/null || echo 0)
+  MERGED_INTO_MAIN=$(git branch --merged "$GF_MAIN_BRANCH" | grep -c "$WT_BRANCH" 2>/dev/null || echo 0)
+
+  # Stale if: no remote OR already merged
+  if [ "$REMOTE_EXISTS" -eq 0 ] || [ "$MERGED_INTO_DEVELOP" -gt 0 ] || [ "$MERGED_INTO_MAIN" -gt 0 ]; then
     STALE+=("$WT_PATH:$WT_BRANCH")
     continue
   fi
@@ -166,10 +178,14 @@ AskUserQuestion:
 # Remove orphaned
 for item in "${ORPHANED[@]}"; do
   WT_PATH=$(echo "$item" | cut -d':' -f1)
+  WT_BRANCH=$(echo "$item" | cut -d':' -f2)
   git worktree remove "$WT_PATH" --force 2>/dev/null || rm -rf "$WT_PATH"
+  # Delete remote branch if exists
+  git push origin --delete "$WT_BRANCH" 2>/dev/null
+  git branch -D "$WT_BRANCH" 2>/dev/null
 done
 
-# Prune
+# Prune stale worktree references
 git worktree prune
 
 # Remove stale
@@ -178,15 +194,29 @@ for item in "${STALE[@]}"; do
   WT_BRANCH=$(echo "$item" | cut -d':' -f2)
 
   git worktree remove "$WT_PATH" --force 2>/dev/null || rm -rf "$WT_PATH"
+  # Delete remote branch if exists
+  git push origin --delete "$WT_BRANCH" 2>/dev/null
   git branch -D "$WT_BRANCH" 2>/dev/null
 done
+
+# Final prune after all removals
+git worktree prune
 ```
 
 **Branches:**
 ```bash
-# Delete merged branches
+# Delete merged branches (local + remote)
 for branch in "${MERGED_BRANCHES[@]}"; do
   git branch -d "$branch"
+  git push origin --delete "$branch" 2>/dev/null
+done
+```
+
+**Empty parent directories:**
+```bash
+# Clean up empty worktree parent directories
+for dir in "$GF_FEATURES_DIR" "$GF_RELEASES_DIR" "$GF_HOTFIXES_DIR"; do
+  [ -d "$dir" ] && [ -z "$(ls -A "$dir" 2>/dev/null)" ] && rm -rf "$dir"
 done
 ```
 

package/templates/skills/gitflow/references/commit-migration-validation.md

@@ -47,3 +47,7 @@ if [ "$HAS_MIGRATIONS" = "true" ]; then
   }
 fi
 ```
+
+## SQL Objects Note
+
+SQL objects (TVFs, views, stored procedures) are applied **automatically at application startup** via `SqlObjectHelper.ApplyAllAsync()`. No injection into migrations is needed. Migrations no longer need to contain `SqlObjectHelper.ApplyAll(migrationBuilder)` calls.