@atlashub/smartstack-cli 4.2.0 → 4.4.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlashub/smartstack-cli",
-  "version": "4.2.0",
+  "version": "4.4.0",
   "description": "SmartStack Claude Code automation toolkit - GitFlow, EF Core migrations, prompts and more",
   "author": {
     "name": "SmartStack",

package/templates/agents/gitflow/init.md

@@ -166,6 +166,22 @@ WAIT for the user's response. Store as `{PROJECT_NAME}`.
 
 Then normalize name into variants (PascalCase.Dot, PascalCase, kebab-case, snake_case, Display Name).
 
+### 2c-bis. Compute Final Project Path
+
+After collecting root folder and project name, compute the actual project base:
+
+```bash
+ROOT_BASENAME=$(basename "{PROJECT_BASE}")
+if [ "$ROOT_BASENAME" != "{PROJECT_NAME}" ]; then
+  PROJECT_BASE="{PROJECT_BASE}/{PROJECT_NAME}"
+  echo "Project path: $PROJECT_BASE (appended project name)"
+else
+  echo "Project path: {PROJECT_BASE} (already includes project name)"
+fi
+```
+
+Update `{PROJECT_BASE}` with the result. This value is what gets passed to `gitflow-init-clone`.
+
 ### 2d. Worktree Mode — CALL AskUserQuestion NOW
 
 DO NOT SKIP THIS. This question has been skipped in past sessions causing incorrect defaults.
@@ -195,7 +211,7 @@ All 4 variables MUST have been confirmed by the user (not auto-derived):
 | Variable | Required | How to verify |
 |----------|----------|---------------|
 | {REPO_URL} | ✅ | From command arg OR user answered question 2a |
-| {PROJECT_BASE} | ✅ | User answered question 2b (NEVER auto-derived) |
+| {PROJECT_BASE} | ✅ | User answered question 2b, then adjusted by 2c-bis if needed |
 | {PROJECT_NAME} | ✅ | User answered question 2c (NEVER auto-derived) |
 | {WORKTREE_MODE} | ✅ | User answered question 2d (NEVER defaulted to "organized") |
 

package/templates/skills/gitflow/steps/step-init.md

@@ -67,6 +67,16 @@ Store as `{PROJECT_NAME}`.
 Then normalize into variants: PascalCase.Dot, PascalCase, kebab-case, snake_case, Display Name.
 See [references/init-name-normalization.md](../references/init-name-normalization.md).
 
+### 5b. Compute Final Project Path
+
+After collecting both root folder and project name, ensure `{PROJECT_BASE}` points to the project-specific directory:
+
+- If `basename({PROJECT_BASE})` already equals `{PROJECT_NAME}` → keep as-is (existing repo case)
+- Otherwise → set `{PROJECT_BASE} = {PROJECT_BASE}/{PROJECT_NAME}` (fresh project case)
+
+> **Example:** Root `D:/01 - projets/` + name `MyApp` → `PROJECT_BASE = D:/01 - projets/MyApp/`
+> **Example:** Root `D:/01 - projets/MyApp/` + name `MyApp` → stays `D:/01 - projets/MyApp/` (no double nesting)
+
 ### 6. Question: Worktree Mode
 
 Call AskUserQuestion:

package/templates/skills/gitflow/steps/step-pr.md

@@ -97,12 +97,60 @@ EXISTING_PR=$(gh pr list --head "$CURRENT" --json number --jq '.[0].number' 2>/d
 }
 ```
 
-### 4. Run Pre-PR Checks
+### 4. Run Pre-PR Checks (BLOCKING)
 
-See [references/pr-build-checks.md](../references/pr-build-checks.md) for:
-- Multi-runtime detection (.NET, npm, Python)
-- Build validation per runtime
-- Migration squash enforcement (feature branches: max 1 migration)
+**4.1 Build validation:**
+```bash
+# Build check (multi-runtime detection)
+echo "Running build check..."
+if [ -f "*.sln" ] || ls *.csproj 2>/dev/null | head -1 > /dev/null; then
+  dotnet build --no-restore 2>&1 || {
+    echo "❌ .NET build failed. Fix before creating PR."
+    STOP
+  }
+elif [ -f "package.json" ]; then
+  npm run build 2>&1 || {
+    echo "❌ npm build failed. Fix before creating PR."
+    STOP
+  }
+fi
+```
+
+**4.2 EF Core Migration Squash Enforcement (BLOCKING):**
+
+> **CRITICAL:** Feature branches MUST have at most 1 migration before creating a PR. This check is MANDATORY when `config.efcore.enabled` is true.
+
+```bash
+# Skip if EF Core is disabled in config
+if [ "$GF_EFCORE_ENABLED" = "true" ]; then
+  if [ "$BRANCH_TYPE" = "feature" ]; then
+    MIGRATION_DIR=$(find . -path "*/Persistence/Migrations" -type d 2>/dev/null | head -1)
+    if [ -n "$MIGRATION_DIR" ]; then
+      NEW_MIGRATIONS=$(git diff --name-only "origin/$TARGET_BRANCH...HEAD" -- "$MIGRATION_DIR" \
+        | grep -E '\.cs$' \
+        | grep -v 'Designer\|ModelSnapshot' \
+        | wc -l)
+
+      if [ "$NEW_MIGRATIONS" -gt 1 ]; then
+        echo ""
+        echo "❌ MULTIPLE MIGRATIONS DETECTED ($NEW_MIGRATIONS migrations)"
+        echo "→ Feature branches must have exactly 1 migration (squashed) before PR"
+        echo "→ Run: /efcore squash"
+        echo ""
+        echo "Migrations found:"
+        git diff --name-only "origin/$TARGET_BRANCH...HEAD" -- "$MIGRATION_DIR" \
+          | grep -E '\.cs$' \
+          | grep -v 'Designer\|ModelSnapshot'
+        STOP
+      elif [ "$NEW_MIGRATIONS" -eq 1 ]; then
+        echo "✓ Single migration detected (squashed)"
+      else
+        echo "✓ No migrations in this feature"
+      fi
+    fi
+  fi
+fi
+```
 
 ### 5. Generate PR Content