@atlashub/smartstack-cli 4.18.0 → 4.19.0

package/templates/skills/apex/steps/step-04-examine.md

@@ -67,80 +67,11 @@ Verify:
 - No orphan routes
 ```
 
-### 3b. Frontend Page Completeness (BLOCKING)
+### 3b. Frontend Page Completeness
 
-> **ROOT CAUSE (test-v4-015):** Frontend generation created List + Detail pages but SKIPPED
-> Create + Edit pages. ListPage buttons navigated to /create and /:id/edit → white screen / 404.
-> Tests were also missing. This section catches that failure mode.
-
-```bash
-PAGE_DIR=$(find . -path "*/src/pages" -not -path "*/node_modules/*" -type d 2>/dev/null | head -1)
-APP_TSX=$(find . -name "App.tsx" -not -path "*/node_modules/*" 2>/dev/null | head -1)
-
-if [ -n "$PAGE_DIR" ]; then
-  # Check each module's ListPage for dead navigation links
-  LIST_PAGES=$(find "$PAGE_DIR" -name "*ListPage.tsx" -o -name "*sPage.tsx" 2>/dev/null | grep -v test | grep -v node_modules)
-  FAIL=false
-  for LIST_PAGE in $LIST_PAGES; do
-    LP_DIR=$(dirname "$LIST_PAGE")
-    MOD=$(basename "$LP_DIR")
-
-    HAS_CREATE_NAV=$(grep -P "navigate\(.*['/]create" "$LIST_PAGE" 2>/dev/null)
-    HAS_EDIT_NAV=$(grep -P "navigate\(.*['/]edit" "$LIST_PAGE" 2>/dev/null)
-
-    CREATE_PAGE=$(find "$LP_DIR" -name "*CreatePage.tsx" 2>/dev/null | head -1)
-    EDIT_PAGE=$(find "$LP_DIR" -name "*EditPage.tsx" 2>/dev/null | head -1)
-
-    if [ -n "$HAS_CREATE_NAV" ] && [ -z "$CREATE_PAGE" ]; then
-      echo "BLOCKING: $MOD ListPage navigates to /create but CreatePage does NOT exist → dead link"
-      FAIL=true
-    fi
-    if [ -n "$HAS_EDIT_NAV" ] && [ -z "$EDIT_PAGE" ]; then
-      echo "BLOCKING: $MOD ListPage navigates to /:id/edit but EditPage does NOT exist → dead link"
-      FAIL=true
-    fi
-  done
-
-  # Check route wiring in App.tsx
-  if [ -n "$APP_TSX" ]; then
-    CREATE_PAGES=$(find "$PAGE_DIR" -name "*CreatePage.tsx" 2>/dev/null | grep -v test)
-    EDIT_PAGES=$(find "$PAGE_DIR" -name "*EditPage.tsx" 2>/dev/null | grep -v test)
-    if [ -n "$CREATE_PAGES" ] && ! grep -qP "path:.*create" "$APP_TSX"; then
-      echo "BLOCKING: CreatePage exists but no 'create' route in App.tsx"
-      FAIL=true
-    fi
-    if [ -n "$EDIT_PAGES" ] && ! grep -qP "path:.*:id/edit" "$APP_TSX"; then
-      echo "BLOCKING: EditPage exists but no ':id/edit' route in App.tsx"
-      FAIL=true
-    fi
-  fi
-
-  # Check test files exist for form pages
-  FORM_PAGES=$(find "$PAGE_DIR" -name "*CreatePage.tsx" -o -name "*EditPage.tsx" 2>/dev/null | grep -v test)
-  if [ -n "$FORM_PAGES" ]; then
-    for FP in $FORM_PAGES; do
-      TF="${FP%.tsx}.test.tsx"
-      if [ ! -f "$TF" ]; then
-        echo "BLOCKING: Form page missing test: $FP → expected $TF"
-        FAIL=true
-      fi
-    done
-  fi
-
-  # Check at least SOME tests exist when pages exist
-  PAGE_COUNT=$(find "$PAGE_DIR" -name "*.tsx" ! -name "*.test.tsx" 2>/dev/null | grep -v node_modules | wc -l)
-  TEST_COUNT=$(find "$PAGE_DIR" -name "*.test.tsx" 2>/dev/null | grep -v node_modules | wc -l)
-  if [ "$PAGE_COUNT" -gt 0 ] && [ "$TEST_COUNT" -eq 0 ]; then
-    echo "BLOCKING: $PAGE_COUNT pages but ZERO test files"
-    FAIL=true
-  fi
-
-  if [ "$FAIL" = true ]; then
-    echo "Fix: Go back to step-03 and generate missing pages/tests/routes"
-    # MUST fix before proceeding
-  fi
-fi
-```
+> POST-CHECKs C4, C5, and C6 in `references/post-checks.md` cover this verification (dead navigation links, missing Create/Edit pages, missing test files). Executed in section 6b below.
+>
+> ROOT CAUSE (test-v4-015): Frontend generation created List + Detail pages but SKIPPED Create + Edit pages → white screen / 404.
 
 **If ANY check fails → return to step-03 to generate the missing pages, tests, or routes.**
 
@@ -157,7 +88,7 @@ dotnet clean && dotnet restore && dotnet build
 npm run typecheck
 ```
 
-**BLOCKING:** Both must pass. If failure, classify error per `references/error-classification.md` (categories A-F).
+Both must pass. If failure, classify error per `references/error-classification.md` (categories A-F).
 
 ---
 
@@ -190,7 +121,7 @@ fi
 sqlcmd -S "(localdb)\MSSQLLocalDB" -Q "IF DB_ID('$DB_NAME') IS NOT NULL BEGIN ALTER DATABASE [$DB_NAME] SET SINGLE_USER WITH ROLLBACK IMMEDIATE; DROP DATABASE [$DB_NAME]; END" 2>/dev/null
 ```
 
-**BLOCKING** if migration fails on SQL Server (common: SQLite-only syntax, column type mismatches, missing FK targets).
+If migration fails on SQL Server (common: SQLite-only syntax, column type mismatches, missing FK targets), fix the DbContext or migration first.
 
 ---
 
@@ -198,9 +129,9 @@ sqlcmd -S "(localdb)\MSSQLLocalDB" -Q "IF DB_ID('$DB_NAME') IS NOT NULL BEGIN AL
 
 | File | Checks |
 |------|--------|
-| NavigationApplicationSeedData | MUST be first, random GUID via Guid.NewGuid() (resolved by Code at runtime), 4 lang translations |
-| ApplicationRolesSeedData | 4 roles (admin, manager, contributor, viewer), random GUIDs, references NavigationApplicationSeedData.ApplicationId |
-| NavigationModuleSeedData | Random GUIDs (`Guid.NewGuid()`), 4 languages (fr, en, it, de), GetModuleEntry + GetTranslationEntries |
+| NavigationApplicationSeedData | MUST be first, 4 lang translations |
+| ApplicationRolesSeedData | 4 roles (admin, manager, contributor, viewer), references NavigationApplicationSeedData.ApplicationId |
+| NavigationModuleSeedData | 4 languages (fr, en, it, de), GetModuleEntry + GetTranslationEntries |
 | ↳ Section methods (same file) | (conditional: if sections exist) GetSectionEntries + GetSectionTranslationEntries, 4 languages, random GUIDs, query actual module from DB for FK |
 | ↳ Resource methods (same file) | (conditional: if resources exist) GetResourceEntries + resource translations, 4 languages, random GUIDs, query actual section from DB for FK |
 | Permissions.cs | Static constants class with `public static class {Module} { Read, Create, Update, Delete }`, paths match PermissionsSeedData |
@@ -211,14 +142,14 @@ sqlcmd -S "(localdb)\MSSQLLocalDB" -Q "IF DB_ID('$DB_NAME') IS NOT NULL BEGIN AL
 
 ---
 
-## 6b. BLOCKING POST-CHECKs
+## 6b. POST-CHECKs
 
 > **MCP FIRST:** Run `validate_conventions`, `validate_security`, and `validate_frontend_routes` before bash checks.
 > These 3 MCP tools cover ~10 additional checks automatically.
 
-Load and execute all checks from `references/post-checks.md` (6 security defense-in-depth + 44 convention checks).
+Load and execute all checks from `references/post-checks.md` (security + convention + architecture checks).
 
-**If ANY POST-CHECK fails → fix in step-03, re-validate.**
+If any POST-CHECK fails, fix in step-03 and re-validate.
 
 ---
 
@@ -259,18 +190,18 @@ AC2: {criterion} → PASS / FAIL (evidence: {file:line or test})
 | Security | TenantId filter, RequirePermission, no Guid.Empty, no !.Value | PASS / N/A |
 | Seed data | completeness, random GUIDs (Guid.NewGuid()), no ContextId/RoleId constants | PASS / N/A |
 | Code quality | PaginatedResult, EntityLookup (no FK select/input), CSS vars, search param | PASS / N/A |
-| Migration completeness | ModelSnapshot covers ALL DbSet entities (POST-CHECK 36, 40) | PASS / N/A |
-| NavRoute kebab-case | NavRoute + permissions use kebab-case (POST-CHECK 32) | PASS / N/A |
-| DateOnly DTOs | Date fields use DateOnly not string (POST-CHECK 39) | PASS / N/A |
-| I18n registration | Namespaces registered in i18n config (POST-CHECK 37) | PASS / N/A |
-| Validators DI | FluentValidation registered in DI (POST-CHECK 38) | PASS / N/A |
-| Route/NavRoute conflict | No [Route] alongside [NavRoute] on controllers (POST-CHECK 41) | PASS / N/A |
-| Role-permission matrix | Admin=wildcard, Manager=CRU, Contributor=CR, Viewer=R (POST-CHECK 42) | PASS / N/A |
-| PermissionAction enum | No Enum.Parse, only typed enum values 0-10 (POST-CHECK 43) | PASS / N/A |
-| Navigation translations | 4 langs per level, section/resource translations present (POST-CHECK 44) | PASS / N/A |
+| Migration completeness | ModelSnapshot covers ALL DbSet entities (POST-CHECK C38, C42) | PASS / N/A |
+| NavRoute kebab-case | NavRoute + permissions use kebab-case (POST-CHECK C34) | PASS / N/A |
+| DateOnly DTOs | Date fields use DateOnly not string (POST-CHECK C41) | PASS / N/A |
+| I18n registration | Namespaces registered in i18n config (POST-CHECK C39) | PASS / N/A |
+| Validators DI | FluentValidation registered in DI (POST-CHECK C40) | PASS / N/A |
+| Route/NavRoute conflict | No [Route] alongside [NavRoute] on controllers (POST-CHECK C43) | PASS / N/A |
+| Role-permission matrix | Admin=wildcard, Manager=CRU, Contributor=CR, Viewer=R (POST-CHECK C44) | PASS / N/A |
+| PermissionAction enum | No Enum.Parse, only typed enum values 0-10 (POST-CHECK C45) | PASS / N/A |
+| Navigation translations | 4 langs per level, section/resource translations present (POST-CHECK C46) | PASS / N/A |
 | Inline tests (Layer 2) | Backend unit + integration tests | PASS / N/A |
 | Inline tests (Layer 3) | Frontend form tests | PASS / N/A |
-| POST-CHECKs | 3 MCP tools + 50 bash checks (6 security + 44 convention) | PASS / N/A |
+| POST-CHECKs | 3 MCP tools + bash checks (security + convention + architecture) | PASS / N/A |
 | Acceptance criteria | AC1..ACn | {X}/{Y} PASS |
 ```
 
@@ -290,14 +221,14 @@ Write to `{output_dir}/04-examine.md` with validation results.
 ```
 IF examine_mode (-x flag):
   → Load steps/step-05-deep-review.md (adversarial review)
-  → Then step-06 (resolve) if BLOCKING findings
+  → Then step-06 (resolve) if findings need fixing
   → Then step-07 (Final Test Sweep) — ALWAYS
 
 ELSE:
   → Load steps/step-07-tests.md — IMMEDIATELY after eXamine completes
 ```
 
-**BLOCKING RULE:** The APEX workflow is NOT complete until steps 07-08 execute.
+**RULE:** The APEX workflow is NOT complete until steps 07-08 execute.
 The success criteria require: "Tests: 100% pass, >= 80% coverage" — step-07 verifies coverage and adds security tests.
 
 ### eXamine Task Lifecycle — Completion

package/templates/skills/apex/steps/step-05-deep-review.md

@@ -50,11 +50,11 @@ Call: mcp__smartstack__analyze_code_quality
 For each changed file, check:
 
 **Security (OWASP):**
-- [ ] `[RequirePermission]` on every endpoint (not `[Authorize]`)
-- [ ] No SQL injection (parameterized queries, EF Core only)
-- [ ] No XSS (React auto-escapes, but check dangerouslySetInnerHTML)
-- [ ] Multi-tenant isolation (IHasData filter applied)
-- [ ] No secrets in code
+- [ ] Require `[RequirePermission]` on every endpoint (not `[Authorize]`)
+- [ ] Verify no SQL injection (parameterized queries, EF Core only)
+- [ ] Check no XSS (React auto-escapes, but verify dangerouslySetInnerHTML)
+- [ ] Confirm multi-tenant isolation (IHasData filter applied)
+- [ ] Ensure no secrets in code
 
 **Architecture:**
 - [ ] Entities in correct Domain folder
@@ -65,19 +65,19 @@ For each changed file, check:
 - [ ] Frontend in correct hierarchy (App/Module)
 
 **SmartStack conventions:**
-- [ ] Random GUIDs in seed data via Guid.NewGuid() (no deterministic/sequential/fixed)
+- [ ] Seed data GUIDs via Guid.NewGuid() (see core-seed-data.md §1b)
 - [ ] 4 languages in translations
-- [ ] CSS variables (not hardcoded colors)
+- [ ] CSS variables only (see smartstack-frontend.md §4)
 - [ ] DataTable (not raw HTML `<table>`) and concrete form markup (not non-existent SmartForm)
 - [ ] Correct Layout wrapper per application
 
 **FK Fields & Forms:**
-- [ ] FK Guid fields use `EntityLookup` component (NEVER `<input>`, NEVER `<select>`)
-- [ ] No `<select>` with `<option>` elements for FK fields (even API-loaded options)
-- [ ] No placeholder text asking user to "Enter ID", "Enter GUID", or "Select {Entity}..."
-- [ ] No inline forms in drawers/slide-overs — Create/Edit forms are full pages with own routes (ZERO modals/dialogs/drawers)
-- [ ] Backend GetAll endpoints support `?search=` param for EntityLookup
-- [ ] Each EntityLookup has `apiEndpoint`, `mapOption`, `label` props
+- [ ] FK Guid fields use `EntityLookup` component (do not use `<input>` or `<select>`) (see smartstack-frontend.md §6)
+- [ ] Verify no `<select>` with `<option>` elements for FK fields (even API-loaded options)
+- [ ] Ensure no placeholder text asking user to "Enter ID", "Enter GUID", or "Select {Entity}..."
+- [ ] Verify no inline forms in drawers/slide-overs; Create/Edit forms are full pages with own routes (zero modals/dialogs/drawers) (see smartstack-frontend.md §3b)
+- [ ] Confirm backend GetAll endpoints support `?search=` param for EntityLookup
+- [ ] Verify each EntityLookup has `apiEndpoint`, `mapOption`, `label` props
 
 ---
 
@@ -130,11 +130,11 @@ Write to `{output_dir}/05-deep-review.md` with all findings.
 
 ```
 IF BLOCKING findings exist:
-  → Load steps/step-06-resolve.md (fix BLOCKING findings first)
-  → Then step-07-tests.md (tests are MANDATORY)
+  → Load steps/step-06-resolve.md (fix findings first)
+  → Then step-07-tests.md (tests are required)
 
 ELSE:
   → Load steps/step-07-tests.md — IMMEDIATELY
 ```
 
-> **REMINDER:** Tests are MANDATORY. Do NOT stop after Deep Review — proceed to step-07.
+Tests are required. Do not stop after Deep Review — proceed to step-07.

package/templates/skills/apex/steps/step-06-resolve.md

@@ -44,10 +44,10 @@ TaskUpdate(taskId: finding_task_id, status: "completed")
 
 **Fixing rules:**
 - Use the SAME skill/MCP that created the original code
-- If the finding is in a controller → use /controller or MCP scaffold_extension
-- If the finding is in seed data → use MCP generate_permissions
-- If the finding is in frontend → use /ui-components or MCP scaffold_routes
-- NEVER fix by writing raw SmartStack code
+- If the finding is in a controller, use /controller or MCP scaffold_extension
+- If the finding is in seed data, use MCP generate_permissions
+- If the finding is in frontend, use /ui-components or MCP scaffold_routes
+- Do not fix by writing raw SmartStack code
 
 ---
 
@@ -66,7 +66,7 @@ For each finding:
 
 ## 3. Re-Validate
 
-After all BLOCKING findings are fixed:
+After all findings are fixed:
 
 ```
 1. MCP validate_conventions → 0 errors
@@ -89,7 +89,7 @@ fix({module}): resolve review findings {F01, F02, ...}
 ```
 **APEX SmartStack - Resolve Complete**
 
-**BLOCKING findings:** {count}
+**Findings:** {count}
 **Resolved:** {count}
 **Remaining:** {count} (should be 0)
 
@@ -110,11 +110,11 @@ Write to `{output_dir}/06-resolve.md` with resolution log.
 ## 7. Route to Next Step
 
 ```
-IF remaining BLOCKING > 0:
+IF remaining findings > 0:
   → Loop: fix remaining, re-validate (max 3 iterations)
   → If stuck, ask user before continuing
 
-→ Load steps/step-07-tests.md — MANDATORY, do NOT skip
+→ Load steps/step-07-tests.md — required, do not skip
 ```
 
-> **REMINDER:** Tests are MANDATORY. After resolving all findings, proceed to step-07 immediately.
+After resolving all findings, proceed to step-07 immediately.

package/templates/skills/apex/steps/step-07-tests.md

@@ -12,7 +12,7 @@ next_step: steps/step-08-run-tests.md
 > Backend and frontend tests were already scaffolded and run inline (Layer 2 and Layer 3).
 > This step focuses on: security tests, coverage gaps, cross-layer scenarios, and remaining failures.
 
-**Goal:** Ensure comprehensive test coverage. Target: >= 80% coverage, 100% pass rate.
+**Goal:** Ensure comprehensive test coverage. Target: >= 80% coverage, 100% pass rate. Acceptable fallback: skip failing tests with TODO comment after 3 fix attempts — escalate to user rather than blocking indefinitely.
 
 ---
 
@@ -29,6 +29,8 @@ TaskUpdate(taskId: progress_tracker_id,
 
 ## 0. Ensure Test Infrastructure Exists
 
+> **Note:** These infrastructure checks are idempotent safety nets. If inline tests (step-03 Layer 2/3) ran successfully, the infrastructure already exists. These checks guard against edge cases where inline test scaffolding was skipped or partially completed.
+
 ### 0a. Frontend Test Tooling (if frontend was generated)
 
 > **Before scaffolding additional frontend tests, the test infrastructure must be in place.**

package/templates/skills/apex/steps/step-08-run-tests.md

@@ -9,7 +9,7 @@ next_step: COMPLETE
 # Step 8: Run Final Test Sweep
 
 **CRITICAL:** Fix the CODE, not the tests. Tests represent expected behavior.
-100% pass required for Sonar quality gate.
+Target 100% pass for Sonar quality gate. If stuck after max retries, skip with TODO and escalate.
 
 ---