@atlashub/smartstack-cli 4.17.1 → 4.18.0

package/templates/skills/business-analyse/steps/step-03c-compile.md

@@ -5,7 +5,7 @@ model: opus
 next_step: steps/step-03d-validate.md
 ---
 
-> **Context files:** `_shared.md` | `_module-loop.md`
+> **Context files:** `_shared.md` | `_module-loop.md` | `_rules.md`
 
 # Step 3c: Specification Compilation
 
@@ -16,27 +16,7 @@ next_step: steps/step-03d-validate.md
 - ALWAYS validate specification completeness before writing
 - ALL communication in `{language}`
 - NEVER skip per-module validation
-- **ID NAMING RULE (MANDATORY, NO EXCEPTION):**
-  All IDs MUST include a module prefix to guarantee application-wide uniqueness.
-  The prefix is derived from the module code initials (2-4 chars):
-    UserManagement → UM | VehicleManagement → VM | PartsInventory → PI
-    RepairManagement → RM | MaintenanceSchedule → MS | DataSync → DS
-    Notifications → NT | Dashboard → DB | Orders → OR | Customers → CU
-
-  Patterns:
-    UC-{PREFIX}-{NNN}        → UC-RM-001, UC-PI-003
-    BR-{CAT}-{PREFIX}-{NNN}  → BR-VAL-RM-001, BR-CALC-PI-002
-    FR-{PREFIX}-{NNN}        → FR-RM-001
-    OBJ-{PREFIX}-{NNN}       → OBJ-RM-001
-    AC-{PREFIX}-{NNN}        → AC-RM-001
-    RISK-{PREFIX}-{NNN}      → RISK-RM-001
-
-  NEVER use bare IDs (UC-001, BR-VAL-001) in multi-module mode.
-- **SCHEMA CONFORMITY RULE:**
-  ALL data MUST fit within the defined feature-schema.json structure.
-  NEVER create custom top-level fields (KPIDefinitions, ChartConfigurations, etc.)
-  Dashboard modules MUST use specification.dashboards[] (it exists in the schema).
-  If truly needed, use specification.extensions: {} (additionalProperties: true).
+- **Rules:** See `_rules.md` § "ID Naming Convention" and § "Schema Conformity" (MANDATORY, NO EXCEPTION)
 
 ## YOUR TASK
 
@@ -195,35 +175,15 @@ Module → Sections → Resources (levels 2-3-4 of the hierarchy).
 
 > **CRITICAL:** `specification.navigation.entries[]` is MANDATORY. If absent, auto-generate from sections.
 
-```javascript
-const nav = specification.navigation;
-if (!nav || !nav.entries || nav.entries.length === 0) {
-  console.warn('AUTO-FIX: navigation.entries is empty — generating from sections');
-  const sections = specification.sections || [];
-  const entries = [
-    { level: "module", code: "{module}", labels: {fr: "{ModuleName}", en: "{ModuleName}", it: "{ModuleName}", de: "{ModuleName}"}, route: "/{app}/{module}", icon: "list" }
-  ];
-  for (const section of sections) {
-    entries.push({
-      level: "section",
-      code: section.code,
-      labels: {fr: section.name || section.code, en: section.name || section.code, it: section.name || section.code, de: section.name || section.code},
-      route: section.route || `/{app}/{module}/${section.code}`,
-      icon: section.icon || "file-text"
-    });
-  }
-  specification.navigation = { entries };
-}
-// Verify ALL entries have 4 languages
-for (const entry of specification.navigation.entries) {
-  for (const lang of ['fr', 'en', 'it', 'de']) {
-    if (!entry.labels[lang]) {
-      entry.labels[lang] = entry.labels['en'] || entry.labels['fr'] || entry.code;
-      console.warn(`AUTO-FIX: navigation entry "${entry.code}" missing ${lang} label — copied from fallback`);
-    }
-  }
-}
-```
+**Auto-generation rule:** If `specification.navigation.entries[]` is empty or absent, generate it from `specification.sections[]`:
+
+1. Create a module-level entry: `level: "module"`, `code: {module}`, labels in 4 languages, `route: /{app}/{module}`, `icon: "list"`
+2. For each section in `specification.sections[]`, create a section-level entry:
+   - `code` = section.code
+   - `labels` = section.name (or section.code) in all 4 languages
+   - `route` = section.route (or `/{app}/{module}/{section.code}`)
+   - `icon` = section.icon (or `"file-text"` default)
+3. **Language completeness:** For every entry, verify all 4 languages (fr, en, it, de) exist in `labels`. If missing, copy from `en` → `fr` → first available value.
 
 #### 8f. SeedData Core
 
@@ -290,31 +250,29 @@ for (const entry of specification.navigation.entries) {
 > **CRITICAL:** `navigationSections` and `navigationResources` must be generated from `specification.sections[]`.
 > This ensures the navigation hierarchy (Module → Section → Resource) is complete in the database.
 
-**Transform algorithm:**
-
-```javascript
-// 1. Transform specification.sections[] into navigationSections
-const navigationSections = specification.sections.map((section, index) => ({
-  code: section.code,                    // e.g., "list", "detail", "dashboard"
-  label: section.labels.fr,              // Default language (fr)
-  icon: section.icon,                    // Lucide icon name
-  route: section.route,                  // Full route path
-  parentCode: metadata.module,           // Module code (parent)
-  permission: section.permission,        // Required permission
-  sort: index + 1                        // Display order (1-based)
-}));
-
-// 2. Transform specification.sections[].resources[] into navigationResources
-const navigationResources = specification.sections.flatMap(section =>
-  section.resources.map(resource => ({
-    code: resource.code,                 // e.g., "employees-grid"
-    type: resource.type,                 // e.g., "SmartTable", "SmartForm"
-    entity: resource.entity,             // e.g., "Employee"
-    parentCode: section.code,            // Section code (parent)
-    permission: resource.permission      // Optional (can inherit from section)
-  }))
-);
-```
+**Transform algorithm (2 steps):**
+
+**Step 1 — Sections → navigationSections:** For each section in `specification.sections[]` (indexed from 0), create one entry:
+
+| Field | Source |
+|---|---|
+| `code` | `section.code` (e.g., "list", "detail", "dashboard") |
+| `label` | `section.labels.fr` (default language) |
+| `icon` | `section.icon` (Lucide icon name) |
+| `route` | `section.route` (full route path) |
+| `parentCode` | `metadata.module` (module code) |
+| `permission` | `section.permission` |
+| `sort` | index + 1 (1-based display order) |
+
+**Step 2 — Resources → navigationResources:** For each resource in each section's `resources[]`, create one entry:
+
+| Field | Source |
+|---|---|
+| `code` | `resource.code` (e.g., "employees-grid") |
+| `type` | `resource.type` (e.g., "SmartTable", "SmartForm") |
+| `entity` | `resource.entity` (e.g., "Employee") |
+| `parentCode` | `section.code` (parent section code) |
+| `permission` | `resource.permission` (optional, can inherit from section) |
 
 **Write seedDataCore to specification:**
 
@@ -489,35 +447,12 @@ Translation keys for all UI text (4 languages: fr, en, it, de).
 > **CRITICAL:** i18n keys with missing IT/DE translations are a recurring issue.
 > This POST-CHECK walks ALL leaf keys and auto-fills missing translations.
 
-```javascript
-const i18n = specification.i18nKeys || {};
-const REQUIRED_LANGS = ['fr', 'en', 'it', 'de'];
-let missingCount = 0;
-
-function walkI18n(obj, path) {
-  if (typeof obj !== 'object' || obj === null) return;
-  // Leaf node: has at least 'fr' or 'en' as direct string properties
-  const hasLangKey = REQUIRED_LANGS.some(l => typeof obj[l] === 'string');
-  if (hasLangKey) {
-    for (const lang of REQUIRED_LANGS) {
-      if (!obj[lang] || typeof obj[lang] !== 'string') {
-        // Fallback: copy from en > fr > first available
-        obj[lang] = obj['en'] || obj['fr'] || Object.values(obj).find(v => typeof v === 'string') || path;
-        missingCount++;
-      }
-    }
-  } else {
-    // Branch node: recurse
-    for (const key of Object.keys(obj)) {
-      walkI18n(obj[key], `${path}.${key}`);
-    }
-  }
-}
-walkI18n(i18n, 'i18nKeys');
-if (missingCount > 0) {
-  console.warn(`AUTO-FIX: filled ${missingCount} missing i18n translations (IT/DE fallbacks from EN/FR)`);
-}
-```
+**Auto-fill rule:** Traverse all nodes in `specification.i18nKeys` recursively.
+
+- A **leaf node** is any object that has at least one key among `fr`, `en`, `it`, `de` whose value is a string.
+- For each leaf node, ensure all 4 language keys exist as strings.
+- **Fallback order** for missing languages: copy from `en` → `fr` → first available string value in the node.
+- Log the count of auto-filled translations as a warning.
 
 ---
 
@@ -530,7 +465,7 @@ Before loading step-03d-validate, verify all 12 subsections (8a-8l) are populate
 3. **8c. Functional Requirements** - At least 4 FRs with linked UCs and BRs
 4. **8d. Permission Matrix** - Resources and role assignments defined
 5. **8e. Navigation** - Module, sections, and resource routes specified
-6. **8f. SeedData Core** - All 7 arrays populated with structured objects (navigationModules, navigationSections, navigationResources, navigationTranslations, permissions, rolePermissions, permissionConstants)
+6. **8f. SeedData Core** - All 9 arrays populated with structured objects (navigationApplications, applicationRoles, navigationModules, navigationSections, navigationResources, navigationTranslations, permissions, rolePermissions, permissionConstants)
 7. **8g. Gherkin Scenarios** - BDD scenarios for each major UC
 8. **8h. Validations** - Field rules with error message keys
 9. **8i. Business Messages** - Minimum 4 messages (success, error CRUD, validation, permission)
@@ -558,39 +493,9 @@ Before loading step-03d-validate, verify all 12 subsections (8a-8l) are populate
 > They run BEFORE the SCHEMA UNIFORMITY comparative check, ensuring the first module has the
 > correct format before being used as baseline for subsequent modules.
 
-```javascript
-// Gherkin MUST be array (not single object)
-if (!Array.isArray(specification.gherkinScenarios)) {
-  console.warn('AUTO-FIX: gherkinScenarios is object, wrapping in array');
-  specification.gherkinScenarios = [specification.gherkinScenarios];
-}
-
-// Validations[].rules MUST be array (not singular rule string)
-for (const v of specification.validations || []) {
-  if (typeof v.rules === 'string') { v.rules = [v.rules]; }
-  if (v.rule && !v.rules) {
-    v.rules = Array.isArray(v.rule) ? v.rule : [v.rule];
-    delete v.rule;
-  }
-}
-
-// Messages MUST have "message" field (not only "description")
-for (const m of specification.messages || []) {
-  if (!m.message && m.description) { m.message = m.description; }
-}
-
-// Wireframes MUST use canonical field names
-const wireframes = specification.uiWireframes || specification.wireframes || [];
-for (const wf of wireframes) {
-  if (wf.title && !wf.screen) { wf.screen = wf.title; delete wf.title; }
-  if (wf.ascii && !wf.mockup) { wf.mockup = wf.ascii; delete wf.ascii; }
-  if (wf.content && !wf.mockup) { wf.mockup = wf.content; delete wf.content; }
-  if (wf.name && !wf.screen) { wf.screen = wf.name; delete wf.name; }
-}
-specification.uiWireframes = wireframes;
-
-// Entity attributes MUST have "type" field (already checked in ENTITY ATTRIBUTE FORMAT POST-CHECK above)
-```
+> **Rules:** Apply `_rules.md` § "Format Checks" and § "Auto-Fix: Wireframe Field Names" to all specification data before proceeding.
+>
+> Specifically: wrap gherkin in array if needed, normalize validation rules to arrays, ensure messages have `message` field, normalize wireframe field names, verify entity attribute types.
 
 **SCHEMA UNIFORMITY CHECK (multi-module mode):**
 IF this is NOT the first module in moduleOrder: