@atlashub/smartstack-cli 4.16.1 → 4.17.0

package/dist/mcp-entry.mjs

@@ -58448,6 +58448,8 @@ async function discoverPageFiles(webPath, routes) {
           const entry = { importPath, componentName };
           if (componentName.endsWith("CreatePage")) {
             discovery.create = entry;
+          } else if (componentName.startsWith("Create") && componentName.endsWith("Page")) {
+            discovery.create = entry;
           } else if (componentName.endsWith("EditPage")) {
             discovery.edit = entry;
           } else if (componentName.endsWith("DetailPage")) {
@@ -58505,17 +58507,29 @@ function generateApplicationRoutesConfig(routes, pageFiles, includeGuards) {
   for (const route of routes) {
     const discovery = pageFiles.get(route.navRoute);
     const { entityPlural, entitySingular, basePath } = deriveEntityNames(route.navRoute);
-    if (!discovery?.list) {
-      lines.push(`// TODO: const ${entityPlural}Page = lazy(() => import('${basePath}/${entityPlural}Page').then(m => ({ default: m.${entityPlural}Page })));`);
-    }
-    if (!discovery?.create) {
-      lines.push(`// TODO: const ${entitySingular}CreatePage = lazy(() => import('${basePath}/${entitySingular}CreatePage').then(m => ({ default: m.${entitySingular}CreatePage })));`);
-    }
-    if (!discovery?.detail) {
-      lines.push(`// TODO: const ${entitySingular}DetailPage = lazy(() => import('${basePath}/${entitySingular}DetailPage').then(m => ({ default: m.${entitySingular}DetailPage })));`);
-    }
-    if (!discovery?.edit) {
-      lines.push(`// TODO: const ${entitySingular}EditPage = lazy(() => import('${basePath}/${entitySingular}EditPage').then(m => ({ default: m.${entitySingular}EditPage })));`);
+    if (!discovery?.list && !importedComponents.has(`${entityPlural}Page`)) {
+      importedComponents.add(`${entityPlural}Page`);
+      lines.push(`const ${entityPlural}Page = lazy(() =>`);
+      lines.push(`  import('${basePath}/${entityPlural}Page').then(m => ({ default: m.${entityPlural}Page }))`);
+      lines.push(");");
+    }
+    if (!discovery?.create && !importedComponents.has(`${entitySingular}CreatePage`)) {
+      importedComponents.add(`${entitySingular}CreatePage`);
+      lines.push(`const ${entitySingular}CreatePage = lazy(() =>`);
+      lines.push(`  import('${basePath}/${entitySingular}CreatePage').then(m => ({ default: m.${entitySingular}CreatePage }))`);
+      lines.push(");");
+    }
+    if (!discovery?.detail && !importedComponents.has(`${entitySingular}DetailPage`)) {
+      importedComponents.add(`${entitySingular}DetailPage`);
+      lines.push(`const ${entitySingular}DetailPage = lazy(() =>`);
+      lines.push(`  import('${basePath}/${entitySingular}DetailPage').then(m => ({ default: m.${entitySingular}DetailPage }))`);
+      lines.push(");");
+    }
+    if (!discovery?.edit && !importedComponents.has(`${entitySingular}EditPage`)) {
+      importedComponents.add(`${entitySingular}EditPage`);
+      lines.push(`const ${entitySingular}EditPage = lazy(() =>`);
+      lines.push(`  import('${basePath}/${entitySingular}EditPage').then(m => ({ default: m.${entitySingular}EditPage }))`);
+      lines.push(");");
     }
   }
   lines.push("");
@@ -58538,33 +58552,17 @@ function generateApplicationRoutesConfig(routes, pageFiles, includeGuards) {
         const permGuardClose = permGuardOpen ? "</PermissionGuard>" : "";
         lines.push(`  // === ${entityPlural.toLowerCase()} (NavRoute: ${route.navRoute}) ===`);
         const listComp = discovery?.list?.componentName || `${entityPlural}Page`;
-        const listElement = discovery?.list ? `<Suspense fallback={<PageLoader />}>${permGuardOpen}<${listComp} />${permGuardClose}</Suspense>` : void 0;
-        if (listElement) {
-          lines.push(`  { path: '${modulePath}', element: ${listElement} },`);
-        } else {
-          lines.push(`  // TODO: { path: '${modulePath}', element: <${listComp} /> },`);
-        }
+        const listElement = `<Suspense fallback={<PageLoader />}>${permGuardOpen}<${listComp} />${permGuardClose}</Suspense>`;
+        lines.push(`  { path: '${modulePath}', element: ${listElement} },`);
         const createComp = discovery?.create?.componentName || `${entitySingular}CreatePage`;
-        const createElement = discovery?.create ? `<Suspense fallback={<PageLoader />}>${permGuardOpen}<${createComp} />${permGuardClose}</Suspense>` : void 0;
-        if (createElement) {
-          lines.push(`  { path: '${modulePath}/create', element: ${createElement} },`);
-        } else {
-          lines.push(`  // TODO: { path: '${modulePath}/create', element: <${createComp} /> },`);
-        }
+        const createElement = `<Suspense fallback={<PageLoader />}>${permGuardOpen}<${createComp} />${permGuardClose}</Suspense>`;
+        lines.push(`  { path: '${modulePath}/create', element: ${createElement} },`);
         const detailComp = discovery?.detail?.componentName || `${entitySingular}DetailPage`;
-        const detailElement = discovery?.detail ? `<Suspense fallback={<PageLoader />}>${permGuardOpen}<${detailComp} />${permGuardClose}</Suspense>` : void 0;
-        if (detailElement) {
-          lines.push(`  { path: '${modulePath}/:id', element: ${detailElement} },`);
-        } else {
-          lines.push(`  // TODO: { path: '${modulePath}/:id', element: <${detailComp} /> },`);
-        }
+        const detailElement = `<Suspense fallback={<PageLoader />}>${permGuardOpen}<${detailComp} />${permGuardClose}</Suspense>`;
+        lines.push(`  { path: '${modulePath}/:id', element: ${detailElement} },`);
         const editComp = discovery?.edit?.componentName || `${entitySingular}EditPage`;
-        const editElement = discovery?.edit ? `<Suspense fallback={<PageLoader />}>${permGuardOpen}<${editComp} />${permGuardClose}</Suspense>` : void 0;
-        if (editElement) {
-          lines.push(`  { path: '${modulePath}/:id/edit', element: ${editElement} },`);
-        } else {
-          lines.push(`  // TODO: { path: '${modulePath}/:id/edit', element: <${editComp} /> },`);
-        }
+        const editElement = `<Suspense fallback={<PageLoader />}>${permGuardOpen}<${editComp} />${permGuardClose}</Suspense>`;
+        lines.push(`  { path: '${modulePath}/:id/edit', element: ${editElement} },`);
       }
     }
     lines.push("");
@@ -58795,6 +58793,9 @@ async function validateFrontendRoutes2(input, config2) {
   if (scope === "all" || scope === "routes") {
     await validateAppWiring(webPath, backendRoutes, result);
   }
+  if (scope === "all" || scope === "routes") {
+    await validateCrudRoutes(webPath, backendRoutes, result);
+  }
   generateRecommendations2(result);
   result.valid = result.apiClients.issues.filter((i) => i.severity === "error").length === 0 && result.routes.missing.length === 0 && result.registry.exists && result.appWiring.issues.length === 0;
   return result;
@@ -59094,6 +59095,52 @@ async function validateAppWiring(webPath, backendRoutes, result) {
     }
   }
 }
+async function validateCrudRoutes(webPath, backendRoutes, result) {
+  const routeCandidates = ["applicationRoutes.generated.tsx", "clientRoutes.generated.tsx"];
+  let routesContent = "";
+  for (const candidate of routeCandidates) {
+    const candidatePath = path20.join(webPath, "src", "routes", candidate);
+    if (await fileExists(candidatePath)) {
+      try {
+        routesContent = await readText(candidatePath);
+      } catch {
+        logger.debug(`Failed to read ${candidatePath}`);
+      }
+      break;
+    }
+  }
+  if (!routesContent) {
+    return;
+  }
+  for (const route of backendRoutes) {
+    const modulePath = route.navRoute.split(".").slice(1).map(toKebabCase).join("/");
+    if (modulePath.length === 0) continue;
+    const crudSuffixes = [
+      { suffix: "/create", label: "create" },
+      { suffix: "/:id", label: "detail" },
+      { suffix: "/:id/edit", label: "edit" }
+    ];
+    for (const { suffix, label } of crudSuffixes) {
+      const fullPath = `${modulePath}${suffix}`;
+      const todoPattern = `// TODO:.*path:\\s*'${fullPath.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}'`;
+      if (new RegExp(todoPattern).test(routesContent)) {
+        result.appWiring.issues.push(
+          `Route "${route.navRoute}" ${label} route is commented out (// TODO:). Run \`scaffold_routes\` to regenerate active routes.`
+        );
+      }
+      if (label === "create") {
+        const newPath = `${modulePath}/new`;
+        const hasNewRoute = routesContent.includes(`path: '${newPath}'`) || routesContent.includes(`path="${newPath}"`);
+        const hasCreateRoute = routesContent.includes(`path: '${modulePath}/create'`) || routesContent.includes(`path="${modulePath}/create"`);
+        if (hasNewRoute && !hasCreateRoute) {
+          result.appWiring.issues.push(
+            `Route "${route.navRoute}" uses /new instead of /create. SmartStack convention is /create. Run \`scaffold_routes\` to fix.`
+          );
+        }
+      }
+    }
+  }
+}
 function generateRecommendations2(result) {
   if (!result.registry.exists) {
     result.recommendations.push('Run `scaffold_routes source="controllers"` to generate route registry');