@atlashub/smartstack-cli 3.8.0 → 3.9.0

package/templates/skills/application/steps/step-07-tests.md

@@ -47,78 +47,11 @@ From previous steps:
 
 ## PRE-REQUISITES
 
-### 1. Verify Test Project Exists
-
-Check that the solution contains a test project:
-
-```bash
-# Look for existing test project
-ls *Tests*/*.csproj 2>/dev/null || ls tests/*/*.csproj 2>/dev/null
-```
-
-If NO test project exists, create one:
-
-```bash
-dotnet new xunit -n {SolutionName}.Tests -o tests/{SolutionName}.Tests
-dotnet sln add tests/{SolutionName}.Tests/{SolutionName}.Tests.csproj
-```
-
-### 2. Verify Required NuGet Packages
-
-The test project MUST have these packages:
-
-| Package | Purpose |
-|---------|---------|
-| `xunit` | Test framework |
-| `FluentAssertions` | Assertion library |
-| `Moq` | Mocking framework |
-| `Microsoft.AspNetCore.Mvc.Testing` | Integration test support |
-| `Microsoft.EntityFrameworkCore.Sqlite` | SQLite in-memory for REAL integration tests |
-| `Microsoft.Data.Sqlite` | SQLite connection support |
-| `Microsoft.EntityFrameworkCore.InMemory` | In-memory DB for repository tests |
-| `FluentValidation.TestHelper` | Validator testing support |
-
-```bash
-cd tests/{SolutionName}.Tests
-dotnet add package FluentAssertions
-dotnet add package Moq
-dotnet add package Microsoft.AspNetCore.Mvc.Testing
-dotnet add package Microsoft.EntityFrameworkCore.Sqlite
-dotnet add package Microsoft.Data.Sqlite
-dotnet add package Microsoft.EntityFrameworkCore.InMemory
-dotnet add package FluentValidation.TestHelper
-```
-
-### 3. Add Project References
-
-The test project MUST reference the API project (for WebApplicationFactory):
-
-```bash
-cd tests/{SolutionName}.Tests
-dotnet add reference ../../src/{SolutionName}.Api/{SolutionName}.Api.csproj
-dotnet add reference ../../src/{SolutionName}.Application/{SolutionName}.Application.csproj
-dotnet add reference ../../src/{SolutionName}.Domain/{SolutionName}.Domain.csproj
-dotnet add reference ../../src/{SolutionName}.Infrastructure/{SolutionName}.Infrastructure.csproj
-```
-
-### 4. Ensure Program.cs is Accessible (BLOCKING)
-
-The API project's `Program` class must be accessible for `WebApplicationFactory<Program>`.
-
-Check if `Program.cs` ends with `public partial class Program { }`. If not, add it:
-
-```csharp
-// At the very end of Program.cs
-public partial class Program { }
-```
-
-**Alternatively**, add to the API `.csproj`:
-
-```xml
-<ItemGroup>
-  <InternalsVisibleTo Include="{SolutionName}.Tests" />
-</ItemGroup>
-```
+See [references/test-prerequisites.md](../references/test-prerequisites.md) for the complete setup:
+1. Verify test project exists (create xunit project if missing)
+2. Install required NuGet packages (xunit, FluentAssertions, Moq, Mvc.Testing, EF Sqlite, etc.)
+3. Add project references (API, Application, Domain, Infrastructure)
+4. Ensure Program.cs is accessible for WebApplicationFactory (BLOCKING)
 
 ---
 
@@ -343,62 +276,13 @@ dotnet test tests/{SolutionName}.Tests/{SolutionName}.Tests.csproj --no-build --
 
 ## FRONTEND TESTS (React Components)
 
-### 7. Check Frontend Test Infrastructure
+See [references/test-frontend.md](../references/test-frontend.md) for the complete frontend test setup:
 
-Verify that the frontend project has Vitest + Testing Library configured:
-
-```bash
-# Check if vitest.config.ts exists in the web/frontend project
-ls {WebProjectPath}/vitest.config.ts 2>/dev/null
-```
-
-If NOT found, deploy the test infrastructure:
-
-1. **Install packages:**
-
-```bash
-cd {WebProjectPath}
-npm install -D vitest @testing-library/react @testing-library/jest-dom @testing-library/user-event jsdom msw
-```
-
-2. **Copy infrastructure files** from SmartStack templates:
-
-| Template Source | Destination |
-|----------------|-------------|
-| `templates/project/test-frontend/vitest.config.ts` | `{WebProjectPath}/vitest.config.ts` |
-| `templates/project/test-frontend/setup.ts` | `{WebProjectPath}/src/test/setup.ts` |
-| `templates/project/test-frontend/test-utils.tsx` | `{WebProjectPath}/src/test/test-utils.tsx` |
-| `templates/project/test-frontend/msw/server.ts` | `{WebProjectPath}/src/test/msw/server.ts` |
-| `templates/project/test-frontend/msw/handlers.ts` | `{WebProjectPath}/src/test/msw/handlers.ts` |
-
-3. **Add test script** to `package.json` (if missing):
-
-```json
-{
-  "scripts": {
-    "test": "vitest run",
-    "test:watch": "vitest",
-    "test:coverage": "vitest run --coverage"
-  }
-}
-```
-
-### 8. Generate Frontend Tests
-
-```
-Tool: mcp__smartstack__scaffold_frontend_tests
-Args:
-  name: "{entity_name}"
-  components: ["all"]
-  apiRoute: "/api/{entity_code}"
-```
-
-This generates:
-- `src/pages/{context}/{application}/__tests__/{EntityName}Page.test.tsx` - Page rendering, loading, error states
-- `src/pages/{context}/{application}/__tests__/{EntityName}ListView.test.tsx` - List display, pagination, view toggle
-- `src/pages/{context}/{application}/__tests__/{EntityName}DetailPage.test.tsx` - Detail view, tabs, back navigation
-- `src/hooks/__tests__/use{EntityName}Preferences.test.ts` - Preference get/set
-- `src/services/api/__tests__/{entityName}Api.test.ts` - API client calls with MSW
+### 7-8. Infrastructure & Test Generation
+- Check Vitest + Testing Library + MSW configuration
+- Install packages if missing (`vitest`, `@testing-library/react`, `msw`, etc.)
+- Copy infrastructure templates (vitest.config.ts, setup.ts, test-utils.tsx, MSW handlers)
+- Generate tests via `mcp__smartstack__scaffold_frontend_tests` (Page, ListView, DetailPage, Hooks, API)
 
 ### 9. Run Frontend Tests (BLOCKING)
 
@@ -407,11 +291,7 @@ cd {WebProjectPath}
 npx vitest run --reporter=default
 ```
 
-**ALL frontend tests MUST pass.** If tests fail:
-1. Read the failure output carefully
-2. Fix the failing tests or the components they test
-3. Re-run until all tests pass
-4. Do NOT proceed to the next step until all tests are green
+**ALL frontend tests MUST pass.** Fix failures before proceeding.
 
 ---
 

package/templates/skills/business-analyse/SKILL.md

@@ -35,12 +35,16 @@ The skill auto-detects which use case applies by scanning existing features in `
 
 <parameters>
 
-No flags. The entire input is the `{feature_description}`.
+| Flag | Description |
+|------|-------------|
+| (aucun) | Mode standard — analyse complete ou mise a jour |
+| `-review` | Mode review — lit `ba-review.json`, cree une nouvelle version avec les corrections appliquees |
 
-Step-00 handles all detection automatically:
+Step-00 handles detection automatically:
 - **New vs Update**: scans `docs/business/` for existing applications
 - **Single vs Multi-module**: determined during step-02 decomposition
 - **Language**: detected from config or asked once
+- **Review mode**: if `-review` flag, routes directly to step-06
 
 </parameters>
 
@@ -108,6 +112,10 @@ When step-00 detects that the description matches an existing application:
 - **Step 00:** Detection, locate existing feature, create version N+1
 - **Step 01:** Cadrage delta: what changes, impact on existing
 - **Step 02-05:** Same flow as new, with existing context loaded
+
+**Review workflow (`-review` flag):**
+- **Step 00:** Detection, scan for latest application, locate `ba-review.json`
+- **Step 06:** Apply corrections, create new version, reverse-map data, regenerate all artifacts
 </workflow>
 
 <state_variables>
@@ -149,6 +157,7 @@ When step-00 detects that the description matches an existing application:
 | 04   | `steps/step-04-consolidation.md`  | Opus   | Cross-module validation, E2E flows, permissions coherence |
 | 05a  | `steps/step-05a-handoff.md`       | Sonnet | Handoff: file mapping (7 categories), BR-to-code mapping, API summary, write handoff |
 | 05b  | `steps/step-05b-deploy.md`        | Sonnet | Deploy: prd.json, progress.txt, manifest, ba-interactive.html, auto-launch ralph-loop |
+| 06   | `steps/step-06-review.md`         | Opus   | Apply review corrections, create new version, regenerate all artifacts |
 
 </step_files>
 

package/templates/skills/business-analyse/html/ba-interactive.html

@@ -1380,6 +1380,18 @@ body {
     font-size: 0.65rem;
 }
 
+/* Review save button */
+.btn-review {
+    background: var(--success);
+    color: #fff;
+    border-color: var(--success);
+    font-weight: 600;
+}
+.btn-review:hover {
+    background: #16a34a;
+    border-color: #16a34a;
+}
+
 @media (max-width: 768px) {
     .body.review-open {
         grid-template-columns: 1fr;
@@ -1408,6 +1420,7 @@ body {
             <div class="header-spacer"></div>
             <div class="header-actions">
                 <button class="btn btn-sm" onclick="saveToLocalStorage()" title="Sauvegarder les modifications dans le navigateur">Sauvegarder</button>
+                <button class="btn btn-sm btn-review" onclick="saveReviewJSON()" title="Sauvegarder les corrections pour creer une nouvelle version">Sauvegarder corrections</button>
                 <button class="btn btn-sm btn-primary" onclick="exportJSON()" title="Exporter les donnees au format JSON pour l'extraction">Exporter JSON</button>
                 <button class="btn btn-sm review-toggle-btn" id="reviewToggleBtn" onclick="toggleReviewPanel()" title="Ouvrir/fermer le panneau de review">
                     Review
@@ -2009,6 +2022,7 @@ body {
    ============================================ */
 const APP_KEY = 'ba-{{APPLICATION_ID}}';
 let data = {{FEATURE_DATA}};
+const ORIGINAL_DATA = JSON.parse(JSON.stringify(data));
 const EMBEDDED_ARTIFACTS = {{EMBEDDED_ARTIFACTS}};
 
 // Initialize optional data structures
@@ -2605,6 +2619,8 @@ function renderAllModuleSpecs() {
     });
     // Restore currently visible section after re-render
     restoreCurrentSection();
+    // Re-initialize inline comment buttons on module spec cards
+    if (typeof initInlineComments === 'function') initInlineComments();
 }
 
 function renderModuleSpecSection(mod) {
@@ -3007,6 +3023,17 @@ function renderModuleMockups(code) {
 }
 
 function getPermRoles() {
+    // Extract roles from actual permission data (handles English role names from feature.json)
+    const rolesFromPerms = [];
+    const seen = new Set();
+    data.modules.forEach(m => {
+        (data.moduleSpecs[m.code]?.permissions || []).forEach(p => {
+            const role = p.split('|')[0];
+            if (role && !seen.has(role)) { seen.add(role); rolesFromPerms.push(role); }
+        });
+    });
+    if (rolesFromPerms.length > 0) return [...rolesFromPerms, ...(data.customRoles || [])];
+    // Fallback: use stakeholder names if no permission data exists
     const baseRoles = data.cadrage.stakeholders.length > 0
         ? data.cadrage.stakeholders.map(s => s.role)
         : ['Administrateur', 'Responsable', 'Contributeur', 'Lecteur'];
@@ -3021,9 +3048,7 @@ function getPermActions() {
 function renderPermissionGrid(code) {
     const roles = getPermRoles();
     const actions = getPermActions();
-    const baseRolesCount = data.cadrage.stakeholders.length > 0
-        ? data.cadrage.stakeholders.length
-        : 4;
+    const baseRolesCount = roles.length - (data.customRoles || []).length;
     const baseActionsCount = 6;
 
     const perms = data.moduleSpecs[code]?.permissions || [];
@@ -3040,7 +3065,8 @@ function renderPermissionGrid(code) {
                         <td style="font-weight:500;color:var(--text-bright);">${role}${ri >= baseRolesCount ? ' <span onclick="removeCustomRole('+`'${code}','${role}'`+')" style="cursor:pointer;color:var(--danger);font-size:0.7rem;" title="Supprimer ce role">&#10005;</span>' : ''}</td>
                         ${actions.map(action => {
                             const key = role + '|' + action;
-                            const checked = perms.includes(key);
+                            const wildcardKey = role + '|*';
+                            const checked = perms.includes(key) || perms.includes(wildcardKey);
                             return `<td style="text-align:center;"><input type="checkbox" ${checked ? 'checked' : ''} onchange="togglePermission('${code}','${key}',this.checked)" style="cursor:pointer;width:16px;height:16px;"></td>`;
                         }).join('')}
                     </tr>
@@ -3171,10 +3197,15 @@ function renderConsolPermissions() {
     roles.forEach(role => {
         html += `<tr><td style="font-weight:500;color:var(--text-bright);">${role}</td>`;
         data.modules.forEach(m => {
-            const perms = (data.moduleSpecs[m.code]?.permissions || []).filter(p => p.startsWith(role + '|'));
+            const allPerms = data.moduleSpecs[m.code]?.permissions || [];
+            const hasWildcard = allPerms.includes(role + '|*');
+            const perms = hasWildcard
+                ? getPermActions()
+                : allPerms.filter(p => p.startsWith(role + '|'));
             const count = perms.length;
             const color = count > 4 ? 'var(--success)' : count > 2 ? 'var(--warning)' : count > 0 ? 'var(--text-muted)' : 'var(--border)';
-            html += `<td style="text-align:center;color:${color};font-weight:600;">${count > 0 ? count + ' droits' : 'Aucun'}</td>`;
+            const label = hasWildcard ? 'Tous' : (count > 0 ? count + ' droits' : 'Aucun');
+            html += `<td style="text-align:center;color:${color};font-weight:600;">${label}</td>`;
         });
         html += '</tr>';
     });
@@ -3446,6 +3477,109 @@ function exportJSON() {
     showNotification('Export JSON telecharge');
 }
 
+/* ============================================
+   SAVE REVIEW JSON (corrections for new version)
+   ============================================ */
+function detectChanges(original, current) {
+    const changes = { cadrage: false, modulesAdded: [], modulesRemoved: [], modulesModified: [], commentsCount: 0 };
+
+    // Cadrage changes
+    if (JSON.stringify(original.cadrage) !== JSON.stringify(current.cadrage)) {
+        changes.cadrage = true;
+    }
+
+    // Module changes
+    const origCodes = (original.modules || []).map(m => m.code);
+    const currCodes = (current.modules || []).map(m => m.code);
+    changes.modulesAdded = currCodes.filter(c => !origCodes.includes(c));
+    changes.modulesRemoved = origCodes.filter(c => !currCodes.includes(c));
+    currCodes.filter(c => origCodes.includes(c)).forEach(code => {
+        const origSpec = JSON.stringify(original.moduleSpecs?.[code] || {});
+        const currSpec = JSON.stringify(current.moduleSpecs?.[code] || {});
+        if (origSpec !== currSpec) changes.modulesModified.push(code);
+    });
+
+    // Comments count
+    changes.commentsCount = (current.comments || []).length;
+
+    return changes;
+}
+
+function saveReviewJSON() {
+    // Collect all editable fields (same as exportJSON)
+    document.querySelectorAll('.editable[data-field]').forEach(el => {
+        setNestedValue(data, 'cadrage.' + el.dataset.field, el.textContent.trim());
+    });
+    document.querySelectorAll('.editable[data-module-field]').forEach(el => {
+        const code = el.dataset.moduleCode;
+        const field = el.dataset.moduleField;
+        if (data.moduleSpecs[code]) {
+            data.moduleSpecs[code][field] = el.textContent.trim();
+        }
+    });
+
+    const changes = detectChanges(ORIGINAL_DATA, data);
+    const hasChanges = changes.cadrage || changes.modulesAdded.length > 0
+        || changes.modulesRemoved.length > 0 || changes.modulesModified.length > 0
+        || changes.commentsCount > 0;
+
+    // Build review export with metadata envelope
+    const reviewData = {
+        _reviewMeta: {
+            sourceVersion: data.metadata.version || '1.0',
+            sourceApplicationId: data.metadata.applicationId || '',
+            exportedAt: new Date().toISOString(),
+            hasChanges: hasChanges,
+            changeSummary: {
+                cadrageModified: changes.cadrage,
+                modulesAdded: changes.modulesAdded,
+                modulesRemoved: changes.modulesRemoved,
+                modulesModified: changes.modulesModified,
+                commentsCount: changes.commentsCount
+            }
+        },
+        metadata: data.metadata,
+        cadrage: data.cadrage,
+        modules: data.modules,
+        dependencies: data.dependencies,
+        moduleSpecifications: {},
+        consolidation: data.consolidation,
+        wireframeComments: data.wireframeComments,
+        specComments: data.specComments,
+        customRoles: data.customRoles,
+        customActions: data.customActions,
+        comments: data.comments
+    };
+
+    // Structure module specs (same logic as exportJSON)
+    data.modules.forEach(m => {
+        const spec = data.moduleSpecs[m.code] || {};
+        reviewData.moduleSpecifications[m.code] = {
+            module: m,
+            useCases: (spec.useCases || []).map((uc, i) => ({
+                id: 'UC-' + String(i + 1).padStart(3, '0'),
+                ...uc
+            })),
+            businessRules: (spec.businessRules || []).map((br, i) => ({
+                id: 'BR-' + br.category.toUpperCase().substring(0, 4) + '-' + String(i + 1).padStart(3, '0'),
+                ...br
+            })),
+            entities: spec.entities || [],
+            permissions: spec.permissions || [],
+            notes: spec.notes || ''
+        };
+    });
+
+    const blob = new Blob([JSON.stringify(reviewData, null, 2)], { type: 'application/json' });
+    const url = URL.createObjectURL(blob);
+    const a = document.createElement('a');
+    a.href = url;
+    a.download = 'ba-review.json';
+    a.click();
+    URL.revokeObjectURL(url);
+    showNotification('ba-review.json telecharge — sauvegardez-le a cote du HTML');
+}
+
 
 /* --- 10-comments.js --- */
 /* ============================================
@@ -3463,14 +3597,20 @@ function exportJSON() {
  */
 
 function initInlineComments() {
-    // Add comment buttons under each card and uc-item
+    // Add comment buttons under each card and uc-item (direct children of sections)
     document.querySelectorAll('.section').forEach(section => {
         const sectionId = section.id;
-        const cards = section.querySelectorAll(':scope > .card, :scope > .uc-item');
-        cards.forEach((card, index) => {
-            if (card.querySelector('.comment-btn-container')) return; // already initialized
-            const container = createCommentUI(sectionId, index);
-            card.appendChild(container);
+        section.querySelectorAll(':scope > .card, :scope > .uc-item').forEach((card, index) => {
+            if (card.querySelector('.comment-btn-container')) return;
+            card.appendChild(createCommentUI(sectionId, index));
+        });
+    });
+    // Second pass: nested list containers in module specs (ucList-*, brList-*, entList-*)
+    document.querySelectorAll('[id^="ucList-"], [id^="brList-"], [id^="entList-"]').forEach(list => {
+        const listId = list.id;
+        list.querySelectorAll(':scope > .uc-item, :scope > .entity-block, :scope > div').forEach((item, index) => {
+            if (item.querySelector('.comment-btn-container')) return;
+            item.appendChild(createCommentUI(listId, index));
         });
     });
 }
@@ -3738,12 +3878,34 @@ function getSectionLabel(sectionId) {
         const mod = data.modules.find(m => m.code === code);
         return mod ? mod.name : code;
     }
+    // Handle list-based sectionIds (ucList-*, brList-*, entList-*)
+    const listMatch = sectionId.match(/^(uc|br|ent)List-(.+)$/);
+    if (listMatch) {
+        const tabLabels = { uc: 'Cas d\'utilisation', br: 'Regles metier', ent: 'Donnees' };
+        const mod = data.modules.find(m => m.code === listMatch[2]);
+        const modName = mod ? mod.name : listMatch[2];
+        return modName + ' > ' + (tabLabels[listMatch[1]] || listMatch[1]);
+    }
     return sectionId;
 }
 
 function navigateToComment(sectionId, cardIndex) {
-    showSection(sectionId);
-    // Scroll to the card and open its comment thread
+    // Handle list-based sectionIds (ucList-*, brList-*, entList-*) → navigate to module + tab
+    const listMatch = sectionId.match(/^(uc|br|ent)List-(.+)$/);
+    if (listMatch) {
+        const [, tabType, moduleCode] = listMatch;
+        showSection('module-spec-' + moduleCode);
+        setTimeout(() => {
+            switchTab(moduleCode, tabType);
+            scrollToCommentThread(sectionId, cardIndex);
+        }, 150);
+    } else {
+        showSection(sectionId);
+        scrollToCommentThread(sectionId, cardIndex);
+    }
+}
+
+function scrollToCommentThread(sectionId, cardIndex) {
     setTimeout(() => {
         const thread = document.getElementById('comment-thread-' + sectionId + '-' + cardIndex);
         if (thread && !thread.classList.contains('visible')) {

package/templates/skills/business-analyse/html/src/scripts/01-data-init.js

@@ -3,6 +3,7 @@
    ============================================ */
 const APP_KEY = 'ba-{{APPLICATION_ID}}';
 let data = {{FEATURE_DATA}};
+const ORIGINAL_DATA = JSON.parse(JSON.stringify(data));
 const EMBEDDED_ARTIFACTS = {{EMBEDDED_ARTIFACTS}};
 
 // Initialize optional data structures

package/templates/skills/business-analyse/html/src/scripts/05-render-specs.js

@@ -17,6 +17,8 @@ function renderAllModuleSpecs() {
     });
     // Restore currently visible section after re-render
     restoreCurrentSection();
+    // Re-initialize inline comment buttons on module spec cards
+    if (typeof initInlineComments === 'function') initInlineComments();
 }
 
 function renderModuleSpecSection(mod) {
@@ -419,6 +421,17 @@ function renderModuleMockups(code) {
 }
 
 function getPermRoles() {
+    // Extract roles from actual permission data (handles English role names from feature.json)
+    const rolesFromPerms = [];
+    const seen = new Set();
+    data.modules.forEach(m => {
+        (data.moduleSpecs[m.code]?.permissions || []).forEach(p => {
+            const role = p.split('|')[0];
+            if (role && !seen.has(role)) { seen.add(role); rolesFromPerms.push(role); }
+        });
+    });
+    if (rolesFromPerms.length > 0) return [...rolesFromPerms, ...(data.customRoles || [])];
+    // Fallback: use stakeholder names if no permission data exists
     const baseRoles = data.cadrage.stakeholders.length > 0
         ? data.cadrage.stakeholders.map(s => s.role)
         : ['Administrateur', 'Responsable', 'Contributeur', 'Lecteur'];
@@ -433,9 +446,7 @@ function getPermActions() {
 function renderPermissionGrid(code) {
     const roles = getPermRoles();
     const actions = getPermActions();
-    const baseRolesCount = data.cadrage.stakeholders.length > 0
-        ? data.cadrage.stakeholders.length
-        : 4;
+    const baseRolesCount = roles.length - (data.customRoles || []).length;
     const baseActionsCount = 6;
 
     const perms = data.moduleSpecs[code]?.permissions || [];
@@ -452,7 +463,8 @@ function renderPermissionGrid(code) {
                         <td style="font-weight:500;color:var(--text-bright);">${role}${ri >= baseRolesCount ? ' <span onclick="removeCustomRole('+`'${code}','${role}'`+')" style="cursor:pointer;color:var(--danger);font-size:0.7rem;" title="Supprimer ce role">&#10005;</span>' : ''}</td>
                         ${actions.map(action => {
                             const key = role + '|' + action;
-                            const checked = perms.includes(key);
+                            const wildcardKey = role + '|*';
+                            const checked = perms.includes(key) || perms.includes(wildcardKey);
                             return `<td style="text-align:center;"><input type="checkbox" ${checked ? 'checked' : ''} onchange="togglePermission('${code}','${key}',this.checked)" style="cursor:pointer;width:16px;height:16px;"></td>`;
                         }).join('')}
                     </tr>

package/templates/skills/business-analyse/html/src/scripts/06-render-consolidation.js

@@ -38,10 +38,15 @@ function renderConsolPermissions() {
     roles.forEach(role => {
         html += `<tr><td style="font-weight:500;color:var(--text-bright);">${role}</td>`;
         data.modules.forEach(m => {
-            const perms = (data.moduleSpecs[m.code]?.permissions || []).filter(p => p.startsWith(role + '|'));
+            const allPerms = data.moduleSpecs[m.code]?.permissions || [];
+            const hasWildcard = allPerms.includes(role + '|*');
+            const perms = hasWildcard
+                ? getPermActions()
+                : allPerms.filter(p => p.startsWith(role + '|'));
             const count = perms.length;
             const color = count > 4 ? 'var(--success)' : count > 2 ? 'var(--warning)' : count > 0 ? 'var(--text-muted)' : 'var(--border)';
-            html += `<td style="text-align:center;color:${color};font-weight:600;">${count > 0 ? count + ' droits' : 'Aucun'}</td>`;
+            const label = hasWildcard ? 'Tous' : (count > 0 ? count + ' droits' : 'Aucun');
+            html += `<td style="text-align:center;color:${color};font-weight:600;">${label}</td>`;
         });
         html += '</tr>';
     });

package/templates/skills/business-analyse/html/src/scripts/09-export.js

@@ -63,3 +63,106 @@ function exportJSON() {
     URL.revokeObjectURL(url);
     showNotification('Export JSON telecharge');
 }
+
+/* ============================================
+   SAVE REVIEW JSON (corrections for new version)
+   ============================================ */
+function detectChanges(original, current) {
+    const changes = { cadrage: false, modulesAdded: [], modulesRemoved: [], modulesModified: [], commentsCount: 0 };
+
+    // Cadrage changes
+    if (JSON.stringify(original.cadrage) !== JSON.stringify(current.cadrage)) {
+        changes.cadrage = true;
+    }
+
+    // Module changes
+    const origCodes = (original.modules || []).map(m => m.code);
+    const currCodes = (current.modules || []).map(m => m.code);
+    changes.modulesAdded = currCodes.filter(c => !origCodes.includes(c));
+    changes.modulesRemoved = origCodes.filter(c => !currCodes.includes(c));
+    currCodes.filter(c => origCodes.includes(c)).forEach(code => {
+        const origSpec = JSON.stringify(original.moduleSpecs?.[code] || {});
+        const currSpec = JSON.stringify(current.moduleSpecs?.[code] || {});
+        if (origSpec !== currSpec) changes.modulesModified.push(code);
+    });
+
+    // Comments count
+    changes.commentsCount = (current.comments || []).length;
+
+    return changes;
+}
+
+function saveReviewJSON() {
+    // Collect all editable fields (same as exportJSON)
+    document.querySelectorAll('.editable[data-field]').forEach(el => {
+        setNestedValue(data, 'cadrage.' + el.dataset.field, el.textContent.trim());
+    });
+    document.querySelectorAll('.editable[data-module-field]').forEach(el => {
+        const code = el.dataset.moduleCode;
+        const field = el.dataset.moduleField;
+        if (data.moduleSpecs[code]) {
+            data.moduleSpecs[code][field] = el.textContent.trim();
+        }
+    });
+
+    const changes = detectChanges(ORIGINAL_DATA, data);
+    const hasChanges = changes.cadrage || changes.modulesAdded.length > 0
+        || changes.modulesRemoved.length > 0 || changes.modulesModified.length > 0
+        || changes.commentsCount > 0;
+
+    // Build review export with metadata envelope
+    const reviewData = {
+        _reviewMeta: {
+            sourceVersion: data.metadata.version || '1.0',
+            sourceApplicationId: data.metadata.applicationId || '',
+            exportedAt: new Date().toISOString(),
+            hasChanges: hasChanges,
+            changeSummary: {
+                cadrageModified: changes.cadrage,
+                modulesAdded: changes.modulesAdded,
+                modulesRemoved: changes.modulesRemoved,
+                modulesModified: changes.modulesModified,
+                commentsCount: changes.commentsCount
+            }
+        },
+        metadata: data.metadata,
+        cadrage: data.cadrage,
+        modules: data.modules,
+        dependencies: data.dependencies,
+        moduleSpecifications: {},
+        consolidation: data.consolidation,
+        wireframeComments: data.wireframeComments,
+        specComments: data.specComments,
+        customRoles: data.customRoles,
+        customActions: data.customActions,
+        comments: data.comments
+    };
+
+    // Structure module specs (same logic as exportJSON)
+    data.modules.forEach(m => {
+        const spec = data.moduleSpecs[m.code] || {};
+        reviewData.moduleSpecifications[m.code] = {
+            module: m,
+            useCases: (spec.useCases || []).map((uc, i) => ({
+                id: 'UC-' + String(i + 1).padStart(3, '0'),
+                ...uc
+            })),
+            businessRules: (spec.businessRules || []).map((br, i) => ({
+                id: 'BR-' + br.category.toUpperCase().substring(0, 4) + '-' + String(i + 1).padStart(3, '0'),
+                ...br
+            })),
+            entities: spec.entities || [],
+            permissions: spec.permissions || [],
+            notes: spec.notes || ''
+        };
+    });
+
+    const blob = new Blob([JSON.stringify(reviewData, null, 2)], { type: 'application/json' });
+    const url = URL.createObjectURL(blob);
+    const a = document.createElement('a');
+    a.href = url;
+    a.download = 'ba-review.json';
+    a.click();
+    URL.revokeObjectURL(url);
+    showNotification('ba-review.json telecharge — sauvegardez-le a cote du HTML');
+}