@atlashub/smartstack-cli 3.7.0 → 3.9.0

package/templates/skills/application/steps/step-07-tests.md

@@ -47,78 +47,11 @@ From previous steps:
 
 ## PRE-REQUISITES
 
-### 1. Verify Test Project Exists
-
-Check that the solution contains a test project:
-
-```bash
-# Look for existing test project
-ls *Tests*/*.csproj 2>/dev/null || ls tests/*/*.csproj 2>/dev/null
-```
-
-If NO test project exists, create one:
-
-```bash
-dotnet new xunit -n {SolutionName}.Tests -o tests/{SolutionName}.Tests
-dotnet sln add tests/{SolutionName}.Tests/{SolutionName}.Tests.csproj
-```
-
-### 2. Verify Required NuGet Packages
-
-The test project MUST have these packages:
-
-| Package | Purpose |
-|---------|---------|
-| `xunit` | Test framework |
-| `FluentAssertions` | Assertion library |
-| `Moq` | Mocking framework |
-| `Microsoft.AspNetCore.Mvc.Testing` | Integration test support |
-| `Microsoft.EntityFrameworkCore.Sqlite` | SQLite in-memory for REAL integration tests |
-| `Microsoft.Data.Sqlite` | SQLite connection support |
-| `Microsoft.EntityFrameworkCore.InMemory` | In-memory DB for repository tests |
-| `FluentValidation.TestHelper` | Validator testing support |
-
-```bash
-cd tests/{SolutionName}.Tests
-dotnet add package FluentAssertions
-dotnet add package Moq
-dotnet add package Microsoft.AspNetCore.Mvc.Testing
-dotnet add package Microsoft.EntityFrameworkCore.Sqlite
-dotnet add package Microsoft.Data.Sqlite
-dotnet add package Microsoft.EntityFrameworkCore.InMemory
-dotnet add package FluentValidation.TestHelper
-```
-
-### 3. Add Project References
-
-The test project MUST reference the API project (for WebApplicationFactory):
-
-```bash
-cd tests/{SolutionName}.Tests
-dotnet add reference ../../src/{SolutionName}.Api/{SolutionName}.Api.csproj
-dotnet add reference ../../src/{SolutionName}.Application/{SolutionName}.Application.csproj
-dotnet add reference ../../src/{SolutionName}.Domain/{SolutionName}.Domain.csproj
-dotnet add reference ../../src/{SolutionName}.Infrastructure/{SolutionName}.Infrastructure.csproj
-```
-
-### 4. Ensure Program.cs is Accessible (BLOCKING)
-
-The API project's `Program` class must be accessible for `WebApplicationFactory<Program>`.
-
-Check if `Program.cs` ends with `public partial class Program { }`. If not, add it:
-
-```csharp
-// At the very end of Program.cs
-public partial class Program { }
-```
-
-**Alternatively**, add to the API `.csproj`:
-
-```xml
-<ItemGroup>
-  <InternalsVisibleTo Include="{SolutionName}.Tests" />
-</ItemGroup>
-```
+See [references/test-prerequisites.md](../references/test-prerequisites.md) for the complete setup:
+1. Verify test project exists (create xunit project if missing)
+2. Install required NuGet packages (xunit, FluentAssertions, Moq, Mvc.Testing, EF Sqlite, etc.)
+3. Add project references (API, Application, Domain, Infrastructure)
+4. Ensure Program.cs is accessible for WebApplicationFactory (BLOCKING)
 
 ---
 
@@ -343,62 +276,13 @@ dotnet test tests/{SolutionName}.Tests/{SolutionName}.Tests.csproj --no-build --
 
 ## FRONTEND TESTS (React Components)
 
-### 7. Check Frontend Test Infrastructure
+See [references/test-frontend.md](../references/test-frontend.md) for the complete frontend test setup:
 
-Verify that the frontend project has Vitest + Testing Library configured:
-
-```bash
-# Check if vitest.config.ts exists in the web/frontend project
-ls {WebProjectPath}/vitest.config.ts 2>/dev/null
-```
-
-If NOT found, deploy the test infrastructure:
-
-1. **Install packages:**
-
-```bash
-cd {WebProjectPath}
-npm install -D vitest @testing-library/react @testing-library/jest-dom @testing-library/user-event jsdom msw
-```
-
-2. **Copy infrastructure files** from SmartStack templates:
-
-| Template Source | Destination |
-|----------------|-------------|
-| `templates/project/test-frontend/vitest.config.ts` | `{WebProjectPath}/vitest.config.ts` |
-| `templates/project/test-frontend/setup.ts` | `{WebProjectPath}/src/test/setup.ts` |
-| `templates/project/test-frontend/test-utils.tsx` | `{WebProjectPath}/src/test/test-utils.tsx` |
-| `templates/project/test-frontend/msw/server.ts` | `{WebProjectPath}/src/test/msw/server.ts` |
-| `templates/project/test-frontend/msw/handlers.ts` | `{WebProjectPath}/src/test/msw/handlers.ts` |
-
-3. **Add test script** to `package.json` (if missing):
-
-```json
-{
-  "scripts": {
-    "test": "vitest run",
-    "test:watch": "vitest",
-    "test:coverage": "vitest run --coverage"
-  }
-}
-```
-
-### 8. Generate Frontend Tests
-
-```
-Tool: mcp__smartstack__scaffold_frontend_tests
-Args:
-  name: "{entity_name}"
-  components: ["all"]
-  apiRoute: "/api/{entity_code}"
-```
-
-This generates:
-- `src/pages/{context}/{application}/__tests__/{EntityName}Page.test.tsx` - Page rendering, loading, error states
-- `src/pages/{context}/{application}/__tests__/{EntityName}ListView.test.tsx` - List display, pagination, view toggle
-- `src/pages/{context}/{application}/__tests__/{EntityName}DetailPage.test.tsx` - Detail view, tabs, back navigation
-- `src/hooks/__tests__/use{EntityName}Preferences.test.ts` - Preference get/set
-- `src/services/api/__tests__/{entityName}Api.test.ts` - API client calls with MSW
+### 7-8. Infrastructure & Test Generation
+- Check Vitest + Testing Library + MSW configuration
+- Install packages if missing (`vitest`, `@testing-library/react`, `msw`, etc.)
+- Copy infrastructure templates (vitest.config.ts, setup.ts, test-utils.tsx, MSW handlers)
+- Generate tests via `mcp__smartstack__scaffold_frontend_tests` (Page, ListView, DetailPage, Hooks, API)
 
 ### 9. Run Frontend Tests (BLOCKING)
 
@@ -407,11 +291,7 @@ cd {WebProjectPath}
 npx vitest run --reporter=default
 ```
 
-**ALL frontend tests MUST pass.** If tests fail:
-1. Read the failure output carefully
-2. Fix the failing tests or the components they test
-3. Re-run until all tests pass
-4. Do NOT proceed to the next step until all tests are green
+**ALL frontend tests MUST pass.** Fix failures before proceeding.
 
 ---
 

package/templates/skills/business-analyse/SKILL.md

@@ -35,12 +35,16 @@ The skill auto-detects which use case applies by scanning existing features in `
 
 <parameters>
 
-No flags. The entire input is the `{feature_description}`.
+| Flag | Description |
+|------|-------------|
+| (aucun) | Mode standard — analyse complete ou mise a jour |
+| `-review` | Mode review — lit `ba-review.json`, cree une nouvelle version avec les corrections appliquees |
 
-Step-00 handles all detection automatically:
+Step-00 handles detection automatically:
 - **New vs Update**: scans `docs/business/` for existing applications
 - **Single vs Multi-module**: determined during step-02 decomposition
 - **Language**: detected from config or asked once
+- **Review mode**: if `-review` flag, routes directly to step-06
 
 </parameters>
 
@@ -108,6 +112,10 @@ When step-00 detects that the description matches an existing application:
 - **Step 00:** Detection, locate existing feature, create version N+1
 - **Step 01:** Cadrage delta: what changes, impact on existing
 - **Step 02-05:** Same flow as new, with existing context loaded
+
+**Review workflow (`-review` flag):**
+- **Step 00:** Detection, scan for latest application, locate `ba-review.json`
+- **Step 06:** Apply corrections, create new version, reverse-map data, regenerate all artifacts
 </workflow>
 
 <state_variables>
@@ -149,6 +157,7 @@ When step-00 detects that the description matches an existing application:
 | 04   | `steps/step-04-consolidation.md`  | Opus   | Cross-module validation, E2E flows, permissions coherence |
 | 05a  | `steps/step-05a-handoff.md`       | Sonnet | Handoff: file mapping (7 categories), BR-to-code mapping, API summary, write handoff |
 | 05b  | `steps/step-05b-deploy.md`        | Sonnet | Deploy: prd.json, progress.txt, manifest, ba-interactive.html, auto-launch ralph-loop |
+| 06   | `steps/step-06-review.md`         | Opus   | Apply review corrections, create new version, regenerate all artifacts |
 
 </step_files>