@atlashub/smartstack-cli 3.54.0 → 4.1.0

package/templates/skills/apex/steps/step-07-tests.md

@@ -1,23 +1,26 @@
 ---
 name: step-07-tests
-description: Scaffold tests via MCP for all modified layers
+description: Final Test Sweep — security tests, coverage analysis, remaining failures
 model: opus
 prev_step: steps/step-06-resolve.md
 next_step: steps/step-08-run-tests.md
 ---
 
-# Step 7: Tests
+# Step 7: Final Test Sweep
 
-> **MANDATORY STEP — This is NOT optional.** APEX requires tests for completion.
-> If you reached this step, you MUST scaffold and run tests before finishing.
+> **MANDATORY STEP — This is NOT optional.** APEX requires a final test sweep for completion.
+> Backend and frontend tests were already scaffolded and run inline (Layer 2 and Layer 3).
+> This step focuses on: security tests, coverage gaps, cross-layer scenarios, and remaining failures.
 
-**Goal:** Scaffold comprehensive tests using MCP tools. Target: >= 80% coverage.
+**Goal:** Ensure comprehensive test coverage. Target: >= 80% coverage, 100% pass rate.
 
 ---
 
-## 0. Ensure Frontend Test Tooling Exists (if frontend was generated)
+## 0. Ensure Test Infrastructure Exists
 
-> **Before scaffolding frontend tests, the test infrastructure must be in place.**
+### 0a. Frontend Test Tooling (if frontend was generated)
+
+> **Before scaffolding additional frontend tests, the test infrastructure must be in place.**
 
 ```bash
 # Check if Vitest is installed
@@ -75,11 +78,7 @@ SETUP_EOF
 fi
 ```
 
----
-
-## 1. Ensure Test Projects Exist
-
-### 1a. Unit Test Project
+### 0b. Backend Test Projects
 
 ```bash
 # Check for existing unit test project
@@ -97,7 +96,7 @@ if [ -z "$UNIT_PROJECT" ]; then
 fi
 ```
 
-### 1b. Integration Test Project (for step-04 DB validation)
+### 0c. Integration Test Project (for DB validation)
 
 ```bash
 # Check for existing integration test project
@@ -122,11 +121,41 @@ fi
 
 ---
 
-## 2. Scaffold Tests via MCP
+## 1. Conditional Skip — Inline Tests Already Scaffolded
 
-For each layer that was modified:
+> **Backend and frontend tests were already scaffolded inline in step-03 (Layer 2 and Layer 3).**
+> Do NOT re-scaffold tests that already exist. Only scaffold NEW test types here.
+
+```
+Check existing tests:
+  → If domain tests exist (from Layer 2 inline): SKIP domain scaffold
+  → If application tests exist (from Layer 2 inline): SKIP application scaffold
+  → If API integration tests exist (from Layer 2 inline): SKIP API scaffold
+  → If frontend form tests exist (from Layer 3 inline): SKIP frontend form scaffold
+```
+
+---
+
+## 2. Security Tests (PRIMARY focus of this step)
 
-### Domain Tests
+```
+Call: mcp__smartstack__scaffold_tests
+  module: "{module_code}"
+  test_type: "security"
+
+Tests: RequirePermission enforcement, multi-tenant isolation, tenant boundary violations
+```
+
+> **Security tests are the main value-add of step-07.** Inline tests cover CRUD functionality;
+> security tests verify authorization and isolation — these require cross-layer awareness.
+
+---
+
+## 3. Scaffold Missing Tests (if any layers skipped inline)
+
+For each layer that was NOT tested inline:
+
+### Domain Tests (if not already scaffolded)
 ```
 Call: mcp__smartstack__scaffold_tests
   target_layer: "domain"
@@ -136,7 +165,7 @@ Call: mcp__smartstack__scaffold_tests
 Tests: entity creation, validation, domain events, value objects
 ```
 
-### Application Tests
+### Application Tests (if not already scaffolded)
 ```
 Call: mcp__smartstack__scaffold_tests
   target_layer: "application"
@@ -146,7 +175,7 @@ Call: mcp__smartstack__scaffold_tests
 Tests: service logic, CQRS handlers, FluentValidation
 ```
 
-### API Tests
+### API Tests (if not already scaffolded)
 ```
 Call: mcp__smartstack__scaffold_tests
   target_layer: "api"
@@ -156,16 +185,7 @@ Call: mcp__smartstack__scaffold_tests
 Tests: controller endpoints, authorization, response DTOs
 ```
 
-### Security Tests
-```
-Call: mcp__smartstack__scaffold_tests
-  module: "{module_code}"
-  test_type: "security"
-
-Tests: RequirePermission enforcement, multi-tenant isolation
-```
-
-### Frontend Form Tests
+### Frontend Form Tests (if not already scaffolded)
 ```
 For each module with create/edit pages:
   → Generate EntityCreatePage.test.tsx and EntityEditPage.test.tsx
@@ -185,7 +205,7 @@ Mock API: vi.mock() or MSW — NEVER real API calls
 
 ---
 
-## 3. Suggest Additional Scenarios
+## 4. Suggest Additional Scenarios
 
 ```
 Call: mcp__smartstack__suggest_test_scenarios
@@ -196,7 +216,7 @@ Review suggestions and add relevant test cases.
 
 ---
 
-## 4. Analyze Coverage
+## 5. Analyze Coverage
 
 ```
 Call: mcp__smartstack__analyze_test_coverage
@@ -208,18 +228,18 @@ If under 80%: identify uncovered paths, scaffold additional tests
 
 ---
 
-## 5. Test Summary
+## 6. Test Summary
 
 ```
-**APEX SmartStack - Tests Scaffolded**
+**APEX SmartStack - Final Test Sweep**
 
-| Layer | Tests Created | Coverage |
-|-------|--------------|----------|
-| Domain | {count} | {%} |
-| Application | {count} | {%} |
-| API | {count} | {%} |
-| Security | {count} | {%} |
-| Frontend Forms | {count} | {%} |
+| Layer | Inline Tests | Final Sweep | Total |
+|-------|-------------|-------------|-------|
+| Domain | {count} (Layer 2) | {count} | {total} |
+| Application | {count} (Layer 2) | {count} | {total} |
+| API | {count} (Layer 2) | {count} | {total} |
+| Security | — | {count} | {count} |
+| Frontend Forms | {count} (Layer 3) | {count} | {total} |
 
 **Total tests:** {count}
 **Estimated coverage:** {%}
@@ -227,7 +247,7 @@ If under 80%: identify uncovered paths, scaffold additional tests
 
 ---
 
-## 6. Save Output (if save_mode)
+## 7. Save Output (if save_mode)
 
 Write to `{output_dir}/07-tests.md` with test scaffolding results.
 

package/templates/skills/apex/steps/step-08-run-tests.md

@@ -1,12 +1,12 @@
 ---
 name: step-08-run-tests
-description: Run tests until 100% pass — fix CODE not tests
+description: Run Final Test Sweep until 100% pass — fix CODE not tests
 model: opus
 prev_step: steps/step-07-tests.md
 next_step: COMPLETE
 ---
 
-# Step 8: Run Tests
+# Step 8: Run Final Test Sweep
 
 **CRITICAL:** Fix the CODE, not the tests. Tests represent expected behavior.
 100% pass required for Sonar quality gate.
@@ -68,6 +68,8 @@ fi
 
 ## 4. Fix Loop (max 5 iterations)
 
+> **Max 5 iterations (vs max 3 inline).** This catches cross-layer problems that inline tests missed.
+
 ```
 WHILE tests failing AND iteration < 5:
   1. Identify root cause (ALWAYS code bug, not test bug)
@@ -116,7 +118,7 @@ npm run typecheck
 ## 6. Commit Tests
 
 ```
-test({module}): add unit and integration tests
+test({module}): security tests and coverage sweep
 ```
 
 ---