@atlashub/smartstack-cli 3.43.0 → 3.45.0

package/templates/skills/application/templates-seed.md

@@ -7,17 +7,15 @@
 ## GUID GENERATION RULES
 
 ```csharp
-// NEVER generate sequential GUIDs with NewGuid()
-// ALWAYS use the deterministic method
+// ALWAYS use Guid.NewGuid() for ALL seed data IDs
+// This avoids conflicts between different projects/tenants/environments
+// Idempotence is handled by Code-based lookups, NOT by fixed IDs
 
-private static Guid GenerateGuid(int index)
-{
-    // Format: 11111111-1111-1111-1111-{index:D12}
-    return Guid.Parse($"11111111-1111-1111-1111-{index:D12}");
-}
+// For HasData() in Configuration files:
+Id = Guid.NewGuid()
 
-// For existing seeds, continue the sequence
-// Check the last index used in NavigationTranslationConfiguration.cs
+// For SeedData classes:
+public static readonly Guid Sample1Id = Guid.NewGuid();
 ```
 
 ---
@@ -49,7 +47,7 @@ new {
 ```csharp
 // Application translations
 translations.Add(new {
-    Id = GenerateGuid(index++),
+    Id = Guid.NewGuid(),
     EntityType = NavigationEntityType.Application,
     EntityId = $APP_GUID,
     LanguageCode = "fr",
@@ -58,7 +56,7 @@ translations.Add(new {
     CreatedAt = seedDate
 });
 translations.Add(new {
-    Id = GenerateGuid(index++),
+    Id = Guid.NewGuid(),
     EntityType = NavigationEntityType.Application,
     EntityId = $APP_GUID,
     LanguageCode = "en",
@@ -67,7 +65,7 @@ translations.Add(new {
     CreatedAt = seedDate
 });
 translations.Add(new {
-    Id = GenerateGuid(index++),
+    Id = Guid.NewGuid(),
     EntityType = NavigationEntityType.Application,
     EntityId = $APP_GUID,
     LanguageCode = "it",
@@ -76,7 +74,7 @@ translations.Add(new {
     CreatedAt = seedDate
 });
 translations.Add(new {
-    Id = GenerateGuid(index++),
+    Id = Guid.NewGuid(),
     EntityType = NavigationEntityType.Application,
     EntityId = $APP_GUID,
     LanguageCode = "de",
@@ -114,7 +112,7 @@ new {
 ```csharp
 // Module translations
 translations.Add(new {
-    Id = GenerateGuid(index++),
+    Id = Guid.NewGuid(),
     EntityType = NavigationEntityType.Module,
     EntityId = $MODULE_GUID,
     LanguageCode = "fr",
@@ -123,7 +121,7 @@ translations.Add(new {
     CreatedAt = seedDate
 });
 translations.Add(new {
-    Id = GenerateGuid(index++),
+    Id = Guid.NewGuid(),
     EntityType = NavigationEntityType.Module,
     EntityId = $MODULE_GUID,
     LanguageCode = "en",
@@ -132,7 +130,7 @@ translations.Add(new {
     CreatedAt = seedDate
 });
 translations.Add(new {
-    Id = GenerateGuid(index++),
+    Id = Guid.NewGuid(),
     EntityType = NavigationEntityType.Module,
     EntityId = $MODULE_GUID,
     LanguageCode = "it",
@@ -141,7 +139,7 @@ translations.Add(new {
     CreatedAt = seedDate
 });
 translations.Add(new {
-    Id = GenerateGuid(index++),
+    Id = Guid.NewGuid(),
     EntityType = NavigationEntityType.Module,
     EntityId = $MODULE_GUID,
     LanguageCode = "de",
@@ -179,7 +177,7 @@ new {
 ```csharp
 // Section translations
 translations.Add(new {
-    Id = GenerateGuid(index++),
+    Id = Guid.NewGuid(),
     EntityType = NavigationEntityType.Section,
     EntityId = $SECTION_GUID,
     LanguageCode = "fr",
@@ -188,7 +186,7 @@ translations.Add(new {
     CreatedAt = seedDate
 });
 translations.Add(new {
-    Id = GenerateGuid(index++),
+    Id = Guid.NewGuid(),
     EntityType = NavigationEntityType.Section,
     EntityId = $SECTION_GUID,
     LanguageCode = "en",
@@ -197,7 +195,7 @@ translations.Add(new {
     CreatedAt = seedDate
 });
 translations.Add(new {
-    Id = GenerateGuid(index++),
+    Id = Guid.NewGuid(),
     EntityType = NavigationEntityType.Section,
     EntityId = $SECTION_GUID,
     LanguageCode = "it",
@@ -206,7 +204,7 @@ translations.Add(new {
     CreatedAt = seedDate
 });
 translations.Add(new {
-    Id = GenerateGuid(index++),
+    Id = Guid.NewGuid(),
     EntityType = NavigationEntityType.Section,
     EntityId = $SECTION_GUID,
     LanguageCode = "de",
@@ -510,9 +508,9 @@ new {
 
 ```
 $APP = sales
-$APP_GUID = e2e2e2e2-2222-2222-2222-222222222222
+$APP_GUID = (generated via Guid.NewGuid() at seed time)
 $MODULE = products
-$MODULE_GUID = e3e3e3e3-3333-3333-3333-333333333333
+$MODULE_GUID = (generated via Guid.NewGuid() at seed time)
 
 $LABEL_FR = Produits
 $LABEL_EN = Products
@@ -570,12 +568,13 @@ namespace SmartStack.Infrastructure.Persistence.Seeding.Data.{Domain};
 public static class {EntityName}SeedData
 {
     // ============================================================
-    // DETERMINISTIC IDs - for referencing in other seed data
+    // RANDOM IDs - generated at class load, unique per deployment
+    // Idempotence is handled by AnyAsync() checks, NOT by fixed IDs
     // ============================================================
 
-    public static readonly Guid Sample1Id = Guid.Parse("$SEED_GUID_1");
-    public static readonly Guid Sample2Id = Guid.Parse("$SEED_GUID_2");
-    public static readonly Guid Sample3Id = Guid.Parse("$SEED_GUID_3");
+    public static readonly Guid Sample1Id = Guid.NewGuid();
+    public static readonly Guid Sample2Id = Guid.NewGuid();
+    public static readonly Guid Sample3Id = Guid.NewGuid();
 
     /// <summary>
     /// Returns all demo {EntityName} entities.
@@ -641,7 +640,7 @@ private static IEnumerable<{EntityName}SeedItem> GetTenant1{EntityName}s()
     {
         new {EntityName}SeedItem
         {
-            Id = Guid.Parse("$GUID"),
+            Id = Guid.NewGuid(),
             TenantId = tenantId,
             CreatedByUserId = userId,
             // ... properties
@@ -688,8 +687,8 @@ private async Task Seed{EntityName}sAsync(CancellationToken cancellationToken)
             // Map seedItem properties to factory method parameters
         );
 
-        // Set deterministic ID (factory generates random GUID)
-        typeof({EntityName}).GetProperty("Id")?.SetValue(entity, seedItem.Id);
+        // Factory method already generates a random GUID via Guid.NewGuid()
+        // No need to override — each seed run creates fresh unique IDs
 
         _context.{EntityName}s.Add(entity);
         createdCount++;
@@ -707,30 +706,25 @@ private async Task Seed{EntityName}sAsync(CancellationToken cancellationToken)
 ### Seed Data GUID Generation
 
 ```csharp
-// Option 1: Hardcoded descriptive GUIDs (preferred for small sets)
-public static readonly Guid ProductAlphaId = Guid.Parse("aa000001-0000-0000-0000-000000000001");
-public static readonly Guid ProductBetaId  = Guid.Parse("aa000001-0000-0000-0000-000000000002");
+// ALWAYS use Guid.NewGuid() — avoids conflicts between projects/tenants/environments
+public static readonly Guid ProductAlphaId = Guid.NewGuid();
+public static readonly Guid ProductBetaId  = Guid.NewGuid();
 
-// Option 2: SHA256-based for larger sets
-private static Guid GenerateEntityGuid(string uniqueKey)
-{
-    using var sha256 = System.Security.Cryptography.SHA256.Create();
-    var hash = sha256.ComputeHash(System.Text.Encoding.UTF8.GetBytes($"{EntityName}-{uniqueKey}"));
-    return new Guid(hash.Take(16).ToArray());
-}
+// FORBIDDEN: Deterministic GUIDs (SHA256, sequential, hardcoded)
+// These create conflicts when multiple projects seed into the same database
 ```
 
 ### Best Practices
 
 | Practice | Description |
 |----------|-------------|
-| Deterministic IDs | NEVER use `Guid.NewGuid()` - seeds must be idempotent |
-| Idempotent | Always check `if exists` before creating |
+| Random IDs | ALWAYS use `Guid.NewGuid()` — avoids cross-project/tenant conflicts |
+| Idempotent | Always check `if exists` before creating (by Code, not by ID) |
 | Use factory methods | Call `Entity.Create(...)` not `new Entity()` |
-| Set ID via reflection | Factory methods generate random IDs; override after creation |
+| FK by Code lookup | Resolve foreign keys by Code at runtime, not by hardcoded GUID |
 | Realistic data | Use plausible names, descriptions, amounts |
 | Cover all states | Include entities in different statuses (active, closed, etc.) |
-| Reference existing seeds | Use IDs from TenantSeedData, UserSeedData for foreign keys |
+| Reference existing seeds | Resolve FKs via Code/Name lookups, not static GUIDs |
 | SaveChanges per batch | Call SaveChanges after each entity group |
 
 ---
@@ -895,7 +889,7 @@ public class {AppPascalName}SeedDataProvider : IClientSeedDataProvider
 | Factory methods | `NavigationModule.Create(...)`, `NavigationSection.Create(...)`, `NavigationResource.Create(...)`, `Permission.CreateForModule(...)` - NEVER `new Entity()` |
 | Idempotence | Each Seed method checks existence before inserting |
 | SaveChanges per group | Navigation -> save -> Roles -> save -> Permissions -> save -> RolePermissions -> save |
-| Deterministic GUIDs | Use IDs from SeedData classes (not `Guid.NewGuid()`) |
+| Random GUIDs | ALWAYS use `Guid.NewGuid()` — resolve FKs by Code lookup |
 | FK resolution by Code | Parent modules found by `Code`, not hardcoded GUID |
 | Section/Resource conditionality | Only generate if `seedDataCore.navigationSections` / `seedDataCore.navigationResources` exist in feature.json |
 
@@ -905,9 +899,9 @@ public class {AppPascalName}SeedDataProvider : IClientSeedDataProvider
 
 | Check | Status |
 |-------|--------|
-| ☐ Deterministic GUID (not NewGuid) | |
+| ☐ Random GUIDs via Guid.NewGuid() (no deterministic/sequential/fixed) | |
 | ☐ 4 languages for each navigation entity (modules, sections, resources) | |
-| ☐ Index translations continue existing sequence | |
+| ☐ Translation IDs use Guid.NewGuid() | |
 | ☐ Route aligned with permission path | |
 | ☐ DisplayOrder consistent | |
 | ☐ CRUD permissions created (Level 2 - Module) | |

package/templates/skills/business-analyse/references/team-orchestration.md

@@ -512,8 +512,8 @@ IF layer.modules.length >= 2 AND all modules approved:
   3. i18n keys: Do keys follow consistent patterns? No collisions?
      → {module1}.labels.name vs {module2}.labels.name (OK — namespaced)
 
-  4. Seed data IDs: Are deterministic GUIDs unique across modules?
-     → Check DeterministicGuid inputs don't collide
+  4. Seed data IDs: All GUIDs use Guid.NewGuid() (no deterministic/fixed values)
+     → Verify no hardcoded or deterministic GUID patterns
 
   5. Entity attribute types: Are shared concepts typed consistently?
      → If both modules define "Status", is it the same enum type?

package/templates/skills/controller/steps/step-04-perms.md

@@ -20,7 +20,7 @@ Add permissions to both Permissions.cs (constants) and PermissionConfiguration.c
 
 See [references/permission-sync-templates.md](../references/permission-sync-templates.md) for the C# templates:
 - **Permissions.cs**: Nested class with 4 constants (View, Create, Update, Delete) + path-to-class mapping
-- **PermissionConfiguration.cs**: 4 HasData Permission entries with deterministic GUIDs
+- **PermissionConfiguration.cs**: 4 HasData Permission entries with Guid.NewGuid()
 
 ### 3. Generate Migration (Required)
 

package/templates/skills/efcore/references/troubleshooting.md

@@ -41,7 +41,7 @@ Option 1: HasData() in Configuration (RECOMMENDED)
 --------------------------------------------------
 // In UserConfiguration.cs
 builder.HasData(new User {
-    Id = Guid.Parse("7f3c9a2e-8d1b-4e5f-a6c8-9b4d2f7e1a3c"),
+    Id = Guid.NewGuid(),
     Name = "Admin",
     Email = "admin@example.com"
 });
@@ -74,7 +74,7 @@ INSERT INTO Users (Id, Name) VALUES (1, 'Admin');
 
 // AFTER (CORRECT): UserConfiguration.cs
 builder.HasData(new User {
-    Id = Guid.Parse("7f3c9a2e-8d1b-4e5f-a6c8-9b4d2f7e1a3c"),
+    Id = Guid.NewGuid(),
     Name = "Admin"
 });
 // Then: dotnet ef migrations add SeedData

package/templates/skills/efcore/steps/rebase-snapshot/step-00-init.md

@@ -80,10 +80,10 @@ PARENT_MIGRATIONS=$(git ls-tree -r --name-only "origin/$BASE_BRANCH" -- "$MIGRAT
 # Get local migrations
 LOCAL_MIGRATIONS=$(find "$MIGRATIONS_DIR" -name "*.cs" 2>/dev/null | grep -v "Designer\|Snapshot" | xargs -I{} basename {} 2>/dev/null || echo "")
 
-# Find branch-only migrations
+# Find branch-only migrations (exact match, not substring)
 BRANCH_MIGRATIONS=()
 for mig in $LOCAL_MIGRATIONS; do
-  if ! echo "$PARENT_MIGRATIONS" | grep -q "$(basename "$mig")"; then
+  if ! echo "$PARENT_MIGRATIONS" | grep -qx "$(basename "$mig")"; then
     BRANCH_MIGRATIONS+=("$mig")
   fi
 done

package/templates/skills/efcore/steps/squash/step-00-init.md

@@ -38,10 +38,10 @@ BASE_MIGRATIONS=$(git ls-tree -r --name-only "origin/$BASE_BRANCH" -- "$MIGRATIO
 # Get local migrations
 LOCAL_MIGRATIONS=$(find "$MIGRATIONS_DIR" -name "*.cs" 2>/dev/null | grep -v "Designer\|Snapshot" | xargs -I{} basename {} 2>/dev/null || echo "")
 
-# Find migrations unique to this branch
+# Find migrations unique to this branch (exact match, not substring)
 BRANCH_ONLY_MIGRATIONS=()
 for mig in $LOCAL_MIGRATIONS; do
-  if ! echo "$BASE_MIGRATIONS" | grep -q "$(basename "$mig")"; then
+  if ! echo "$BASE_MIGRATIONS" | grep -qx "$(basename "$mig")"; then
     BRANCH_ONLY_MIGRATIONS+=("$mig")
   fi
 done

package/templates/skills/apex/references/examine-build-validation.md

@@ -1,82 +0,0 @@
-# Examine Build & Migration Validation
-
-> **Loaded by:** step-04-examine.md (sections 4-5)
-> **Purpose:** Build verification, migration validation, database testing procedures.
-
----
-
-## Build Verification
-
-```bash
-# Backend
-dotnet clean && dotnet restore && dotnet build
-# Note: WSL bin\Debug cleanup handled by PostToolUse hook (wsl-dotnet-cleanup.sh)
-
-# Frontend (if applicable)
-npm run typecheck
-```
-
-**BLOCKING:** Both must pass. If failure, classify error per `references/error-classification.md`:
-- Category A (missing package) → `dotnet add package` → rebuild
-- Category B (assembly conflict) → resolve version → rebuild
-- Category C (DI missing) → fix DI registration → rebuild
-- Category D (migration broken) → fix migration → rebuild
-- Category E (config) → fix config → rebuild
-- Category F (source code) → fix code → rebuild
-
----
-
-## Migration Validation (if needs_migration)
-
-### Pending Model Changes Check
-
-```bash
-INFRA_PROJECT=$(ls src/*Infrastructure*/*.csproj 2>/dev/null | head -1)
-API_PROJECT=$(ls src/*Api*/*.csproj 2>/dev/null | head -1)
-
-dotnet ef migrations has-pending-model-changes \
-  --project "$INFRA_PROJECT" \
-  --startup-project "$API_PROJECT"
-```
-
-**BLOCKING** if pending changes detected → migration is missing.
-
-### Migration Application Test (SQL Server LocalDB)
-
-```bash
-DB_NAME="SmartStack_Apex_Examine_$(date +%s)"
-CONN_STRING="Server=(localdb)\\MSSQLLocalDB;Database=$DB_NAME;Integrated Security=true;TrustServerCertificate=true;Connect Timeout=120;"
-
-dotnet ef database update \
-  --connection "$CONN_STRING" \
-  --project "$INFRA_PROJECT" \
-  --startup-project "$API_PROJECT"
-```
-
-**BLOCKING** if migration fails on SQL Server. Common issues:
-- SQLite-only syntax in migrations (fix: regenerate migration)
-- Column type mismatches (fix: update EF configuration)
-- Missing foreign key targets (fix: reorder migrations)
-
-### Integration Tests on Real SQL Server
-
-```bash
-# Integration tests use DatabaseFixture → real SQL Server LocalDB
-# This validates: LINQ→SQL, multi-tenant isolation, soft delete, EF configs
-INT_TEST_PROJECT=$(ls tests/*Tests.Integration*/*.csproj 2>/dev/null | head -1)
-if [ -n "$INT_TEST_PROJECT" ]; then
-  dotnet test "$INT_TEST_PROJECT" --no-build --verbosity normal
-fi
-```
-
-Tests running against SQL Server catch issues that SQLite misses:
-- Case sensitivity in string comparisons
-- Date/time function differences
-- IDENTITY vs AUTOINCREMENT behavior
-- Global query filter translation to T-SQL
-
-### Cleanup
-
-```bash
-sqlcmd -S "(localdb)\MSSQLLocalDB" -Q "IF DB_ID('$DB_NAME') IS NOT NULL BEGIN ALTER DATABASE [$DB_NAME] SET SINGLE_USER WITH ROLLBACK IMMEDIATE; DROP DATABASE [$DB_NAME]; END" 2>/dev/null
-```

package/templates/skills/apex/references/execution-frontend-gates.md

@@ -1,177 +0,0 @@
-# Frontend Compliance Gate — 5 Mandatory Checks
-
-> **Loaded by:** step-03-execute.md (FRONTEND COMPLIANCE GATE section)
-> **Condition:** MANDATORY before any frontend commit
-> **Purpose:** Automated checks that catch the most common failures in generated code.
-
----
-
-## Gate 1: CSS Variables (Theme System)
-
-Check for hardcoded Tailwind colors — MUST use CSS variables.
-
-```bash
-ALL_PAGES=$(find src/pages/ src/components/ -name "*.tsx" 2>/dev/null | grep -v node_modules | grep -v "\.test\.")
-if [ -n "$ALL_PAGES" ]; then
-  HARDCODED=$(grep -Pn '(bg|text|border)-(?!\[)(red|blue|green|gray|white|black|slate|zinc|neutral|stone)-' $ALL_PAGES 2>/dev/null)
-  if [ -n "$HARDCODED" ]; then
-    echo "FAIL: Hardcoded Tailwind colors found — must use CSS variables"
-    echo "$HARDCODED"
-  else
-    echo "PASS: CSS variables"
-  fi
-fi
-```
-
-**If hardcoded colors found, replace BEFORE committing:**
-
-| Old | New |
-|-----|-----|
-| `bg-white` | `bg-[var(--bg-card)]` |
-| `bg-gray-50` | `bg-[var(--bg-primary)]` |
-| `text-gray-900` | `text-[var(--text-primary)]` |
-| `text-gray-500/600` | `text-[var(--text-secondary)]` |
-| `border-gray-200` | `border-[var(--border-color)]` |
-| `bg-blue-600` / `text-blue-600` | `bg-[var(--color-accent-500)]` / `text-[var(--color-accent-500)]` |
-| `hover:bg-blue-700` | `hover:bg-[var(--color-accent-600)]` |
-| `text-red-500` | `text-[var(--error-text)]` |
-| `bg-green-500` | `bg-[var(--success-bg)]` |
-
----
-
-## Gate 2: Forms as Pages (ZERO Modals/Drawers/Slide-overs)
-
-Check for modal/dialog/drawer/slide-over imports and inline form patterns — FORBIDDEN.
-
-```bash
-PAGE_FILES=$(find src/pages/ -name "*.tsx" 2>/dev/null)
-if [ -n "$PAGE_FILES" ]; then
-  FAIL=false
-
-  # 2a. Component imports
-  MODAL_IMPORTS=$(grep -Pn "import.*(?:Modal|Dialog|Drawer|Popup|Sheet|SlideOver|Overlay)" $PAGE_FILES 2>/dev/null)
-  if [ -n "$MODAL_IMPORTS" ]; then
-    echo "FAIL: Modal/Dialog/Drawer component imports — forms MUST be full pages"
-    echo "$MODAL_IMPORTS"
-    FAIL=true
-  fi
-
-  # 2b. State variables for inline forms (catches drawers/slide-overs without imports)
-  MODAL_STATE=$(grep -Pn "useState.*(?:isOpen|showModal|showDialog|showCreate|showEdit|showForm|isCreating|isEditing|showDrawer|showPanel|showSlideOver|selectedEntity|editingEntity)" $PAGE_FILES 2>/dev/null)
-  if [ -n "$MODAL_STATE" ]; then
-    echo "FAIL: Inline form state detected — forms MUST be separate page components with own routes"
-    echo "$MODAL_STATE"
-    FAIL=true
-  fi
-
-  if [ "$FAIL" = true ]; then
-    echo "Fix: Create EntityCreatePage.tsx (route: /create) and EntityEditPage.tsx (route: /:id/edit)"
-    echo "See smartstack-frontend.md section 3b"
-  else
-    echo "PASS: No modals/drawers"
-  fi
-fi
-```
-
-**If modals/drawers found:** Replace with separate `EntityCreatePage.tsx` (route: `/{module}/create`) and `EntityEditPage.tsx` (route: `/{module}/:id/edit`). See `smartstack-frontend.md` section 3b.
-
----
-
-## Gate 3: I18n File Structure
-
-Verify translation files exist as separate JSON per language.
-
-```bash
-if [ ! -d "src/i18n/locales" ]; then
-  echo "FAIL: Missing src/i18n/locales/ directory — create it with 4 languages"
-else
-  for LANG in fr en it de; do
-    JSON_FILES=$(find "src/i18n/locales/$LANG" -name "*.json" 2>/dev/null | wc -l)
-    if [ "$JSON_FILES" -eq 0 ]; then
-      echo "FAIL: No JSON files in src/i18n/locales/$LANG/"
-    else
-      echo "PASS: $LANG ($JSON_FILES files)"
-    fi
-  done
-fi
-```
-
-**If i18n structure wrong:** Create `src/i18n/locales/{fr,en,it,de}/{module}.json` following the template in `smartstack-frontend.md` section 2. NEVER embed translations in a single `.ts` file.
-
-**Correct structure:**
-```
-src/i18n/locales/
-├── fr/{module}.json    ← French (primary)
-├── en/{module}.json    ← English
-├── it/{module}.json    ← Italian
-└── de/{module}.json    ← German
-```
-
-Each file MUST contain: `title`, `description`, `actions`, `labels`, `columns`, `form`, `errors`, `validation`, `messages`, `empty`.
-
----
-
-## Gate 4: Lazy Loading
-
-Check for static page imports in route/App files.
-
-```bash
-APP_TSX=$(find src/ -name "App.tsx" -not -path "*/node_modules/*" 2>/dev/null | head -1)
-ROUTE_FILES=$(find src/routes/ -name "*.tsx" -o -name "*.ts" 2>/dev/null)
-if [ -n "$APP_TSX" ]; then
-  STATIC_IMPORTS=$(grep -Pn "^import .+ from '@/pages/" "$APP_TSX" $ROUTE_FILES 2>/dev/null)
-  if [ -n "$STATIC_IMPORTS" ]; then
-    echo "FAIL: Static page imports in App.tsx/routes — MUST use React.lazy()"
-    echo "$STATIC_IMPORTS"
-  else
-    echo "PASS: Lazy loading"
-  fi
-fi
-```
-
----
-
-## Gate 5: useTranslation in Pages
-
-Verify pages use i18n.
-
-```bash
-PAGE_FILES=$(find src/pages/ -name "*.tsx" 2>/dev/null | grep -v "\.test\." | grep -v node_modules)
-if [ -n "$PAGE_FILES" ]; then
-  TOTAL=$(echo "$PAGE_FILES" | wc -l)
-  WITH_I18N=$(grep -l "useTranslation" $PAGE_FILES 2>/dev/null | wc -l)
-  if [ "$WITH_I18N" -eq 0 ]; then
-    echo "FAIL: No pages use useTranslation — all text must be translated"
-  else
-    echo "PASS: $WITH_I18N/$TOTAL pages use useTranslation"
-  fi
-fi
-```
-
----
-
-## Explicit I18n File Creation
-
-When creating i18n files, generate EXACTLY this structure:
-
-```
-src/i18n/locales/
-├── fr/{module}.json    ← French (primary)
-├── en/{module}.json    ← English
-├── it/{module}.json    ← Italian
-└── de/{module}.json    ← German
-```
-
-Each file MUST contain these keys: `title`, `description`, `actions`, `labels`, `columns`, `form`, `errors`, `validation`, `messages`, `empty`. See `smartstack-frontend.md` section 2 for the complete JSON template.
-
----
-
-## ALL 5 Gates MUST PASS
-
-**Before creating the frontend commit:**
-1. Do NOT commit frontend changes until ALL checks pass
-2. If ANY gate fails, fix the issues first
-3. When delegating to `/ui-components` skill, include explicit instructions:
-   - "CSS: Use CSS variables ONLY — `bg-[var(--bg-card)]`, `text-[var(--text-primary)]`. NEVER use hardcoded Tailwind colors."
-   - "Forms: Create/Edit forms are FULL PAGES with own routes (e.g., `/create`, `/:id/edit`). NEVER use modals/dialogs."
-   - "I18n: ALL text must use `t('namespace:key', 'Fallback')`. Generate JSON files in `src/i18n/locales/`."

package/templates/skills/apex/references/execution-frontend-patterns.md

@@ -1,105 +0,0 @@
-# Frontend Patterns — Economy Mode Guidelines
-
-> **Loaded by:** step-03-execute.md (Layer 1 section: economy_mode frontend tasks)
-> **Purpose:** Quick reference for frontend creation in sequential (economy) mode.
-> **Detailed patterns:** See `smartstack-frontend.md` (referenced from smartstack-layers.md)
-
----
-
-## Frontend Tasks — Sequential Execution (economy_mode)
-
-For each frontend task in the plan (Layer 1):
-
-1. **API Client:** `MCP scaffold_api_client` → API client + types + React Query hook
-2. **Routes:** `MCP scaffold_routes` with `outputFormat: 'clientRoutes'` for lazy imports
-3. **Pages:** **INVOKE `/ui-components` skill** (read SKILL.md + ALL patterns) — MANDATORY for ALL page types
-
----
-
-## Required Page Types Per Module
-
-Create ALL 4 page types per module:
-- `ListPage.tsx` — entity list with SmartTable/EntityCard
-- `DetailPage.tsx` — entity detail view
-- `EntityCreatePage.tsx` (route: `/create`) — FULL PAGE form, NEVER modal
-- `EntityEditPage.tsx` (route: `/:id/edit`) — FULL PAGE form, NEVER modal
-
-**Wire ALL routes in App.tsx:** `index` (ListPage), `:id` (DetailPage), `create` (CreatePage), `:id/edit` (EditPage)
-
----
-
-## Foreign Key (FK) Fields — CRITICAL
-
-Any Guid FK property (e.g., EmployeeId, DepartmentId) MUST use `EntityLookup` component:
-- **NEVER** a `<select>` dropdown
-- **NEVER** a `<input type="text">`
-- **A `<select>` loaded from API state is NOT a substitute for EntityLookup**
-
-See `smartstack-frontend.md` section 6 for the full EntityLookup pattern. Backend GetAll endpoints MUST support `?search=` parameter (enables EntityLookup on frontend).
-
----
-
-## Forms: ZERO Modals/Popups/Drawers/Slide-overs
-
-**ALL forms are full pages with their own URL:**
-- Create forms: route `/{module}/create`
-- Edit forms: route `/{module}/:id/edit`
-- NEVER embed forms as drawers, panels, or slide-overs
-- Back button with `navigate(-1)` on every form page
-
----
-
-## Detail Pages: Tab Behavior (CRITICAL)
-
-**Tabs MUST switch content LOCALLY via `setActiveTab()` — NEVER `navigate()` to another page.**
-
-Sub-resource data (e.g., employee's leaves) loads inline via API call filtered by parent entity ID. See `smartstack-frontend.md` section 3 "Tab Behavior Rules".
-
----
-
-## Tests (MANDATORY)
-
-Generate form tests as co-located files:
-- `EntityCreatePage.test.tsx` (next to CreatePage.tsx)
-- `EntityEditPage.test.tsx` (next to EditPage.tsx)
-
-Cover: rendering, validation, submit, pre-fill, navigation, errors. See `smartstack-frontend.md` section 8 for test templates.
-
----
-
-## Section-Level Routes (if sections exist)
-
-**SECTION PERMISSIONS:** After calling `MCP generate_permissions` for the module navRoute (2 segments: `{app}.{module}`), also call it for EACH section navRoute (3 segments: `{app}.{module}.{section}`)
-
-**SECTION ROUTES:** After generating module routes, add section child routes to the module's `children` array. Wire `PermissionGuard` for section routes with section-level permissions.
-
----
-
-## Sub-Resource Handling
-
-If a section controller has sub-resource endpoints (e.g., `[HttpGet("types")]` for LeaveTypes inside LeavesController), you MUST EITHER:
-1. Create dedicated frontend pages for the sub-resource (ListPage, CreatePage, EditPage) with routes wired in App.tsx, OR
-2. NOT include any `navigate()` button that links to those sub-resource pages
-
-**Prefer separate controllers** with `[NavRoute(..., Suffix = "types")]` — see `smartstack-api.md` Sub-Resource Pattern. A dead link (navigate to a route with no page) is a BLOCKING issue (POST-CHECK 42).
-
----
-
-## I18n (Translations)
-
-Generate i18n JSON files for all 4 languages (fr, en, it, de):
-- Location: `src/i18n/locales/{lang}/{module}.json`
-- Keys: `actions`, `labels`, `errors`, `validation`, `columns`, `form`, `messages`, `empty`
-- ALL `t()` calls MUST use namespace prefix + fallback: `t('ns:key', 'Default text')`
-
-**CRITICAL:** After creating i18n JSON files, register EACH new namespace in the i18n config file (config.ts/index.ts/i18n.ts). Unregistered namespaces → `useTranslation(['module'])` returns empty strings at runtime. POST-CHECK 45 validates this.
-
----
-
-## Folder Structure
-
-MUST use: `src/pages/{App}/{Module}/` hierarchy (NOT flat).
-
-All pages must follow: **hooks → useEffect(load) → loading state → error state → content**
-
-Use **CSS variables ONLY** for styling — hardcoded Tailwind colors are BLOCKING (POST-CHECK 13).