@atlashub/smartstack-cli 3.31.0 → 3.32.0

package/templates/skills/ralph-loop/references/compact-loop.md

@@ -264,6 +264,43 @@ Batch: {batch.length} [{firstCategory}] → {batch.map(t => `[${t.id}] ${t.descr
      done
    fi
    ```
+   # BLOCKING: No custom entity hooks wrapping services (test-v4-014 root cause)
+   if [ -n "$HOOK_DIR" ]; then
+     CUSTOM_HOOKS=$(find "$HOOK_DIR" -name "use*.ts" -o -name "use*.tsx" 2>/dev/null | grep -iv "Preferences" | grep -v "node_modules")
+     if [ -n "$CUSTOM_HOOKS" ]; then
+       echo "BLOCKING: Custom entity hooks detected — pages MUST call services directly"
+       echo "$CUSTOM_HOOKS"
+       echo "Pattern: page useCallback → service.getAll() → setData(result.items)"
+       echo "FORBIDDEN: useEmployees(), useProjects() etc. wrapping services with useState/useEffect"
+       # FIX REQUIRED: delete custom hooks, move API calls into page components
+     fi
+   fi
+
+   # BLOCKING: No direct array types in services — MUST use PaginatedResult<T>
+   if [ -n "$WEB_SRC" ]; then
+     SVC_DIR=$(find "$WEB_SRC" -path "*/services" -not -path "*/node_modules/*" -type d 2>/dev/null | head -1)
+     if [ -n "$SVC_DIR" ]; then
+       DIRECT_ARRAYS=$(grep -rPn 'api\.get<[A-Z]\w+\[\]>' "$SVC_DIR" --include="*.ts" 2>/dev/null)
+       if [ -n "$DIRECT_ARRAYS" ]; then
+         echo "BLOCKING: Direct array response types — MUST use PaginatedResult<T>"
+         echo "$DIRECT_ARRAYS"
+         echo "Pattern: api.get<PaginatedResult<Employee>>(url) then .items in page"
+         # FIX REQUIRED before commit
+       fi
+     fi
+   fi
+
+   # BLOCKING: lazy() imports MUST have Suspense boundary in App.tsx
+   if [ -n "$APP_TSX" ]; then
+     HAS_LAZY=$(grep -c 'lazy(' "$APP_TSX" 2>/dev/null)
+     HAS_SUSPENSE=$(grep -c 'Suspense' "$APP_TSX" 2>/dev/null)
+     if [ "$HAS_LAZY" -gt 0 ] && [ "$HAS_SUSPENSE" -eq 0 ]; then
+       echo "BLOCKING: lazy() imports without <Suspense> boundary in App.tsx"
+       echo "Every lazy() page MUST be wrapped: <Suspense fallback={<PageLoader />}>"
+       # FIX REQUIRED before commit
+     fi
+   fi
+
    If ANY POST-CHECK fails → fix the code → re-run ALL checks → loop until ALL pass.
    **NEVER commit with failing POST-CHECKs.**
 

package/templates/skills/ralph-loop/references/core-seed-data.md

@@ -1104,47 +1104,78 @@ public class {AppPascalName}SeedDataProvider : IClientSeedDataProvider
             .FirstAsync(m => m.Code == "{module1Code}" && m.ApplicationId == app.Id, ct);
         // Repeat for each module...
 
-        // --- Module translations ---
-        foreach (var t in {Module1Pascal}NavigationSeedData.GetTranslationEntries())
+        // --- Module translations (idempotent — unique index IX_nav_Translations_EntityType_EntityId_LanguageCode) ---
+        // CRITICAL: Always check existence before inserting translations to avoid duplicate key errors
+        // on re-runs, partial failures, or DB reset scenarios.
+        if (!await context.NavigationTranslations.AnyAsync(
+            t => t.EntityId == {Module1Pascal}NavigationSeedData.{Module1Pascal}ModuleId
+                 && t.EntityType == NavigationEntityType.Module, ct))
         {
-            context.NavigationTranslations.Add(
-                NavigationTranslation.Create(t.EntityType, t.EntityId, t.LanguageCode, t.Label, t.Description));
+            foreach (var t in {Module1Pascal}NavigationSeedData.GetTranslationEntries())
+            {
+                context.NavigationTranslations.Add(
+                    NavigationTranslation.Create(t.EntityType, t.EntityId, t.LanguageCode, t.Label, t.Description));
+            }
         }
         // Repeat for each module...
         await ((DbContext)context).SaveChangesAsync(ct);
 
-        // --- Sections (if seedDataCore.navigationSections exists) ---
+        // --- Sections (idempotent — check each section before inserting) ---
         // Module 1 sections
         foreach (var secEntry in {Module1Pascal}NavigationSeedData.GetSectionEntries(mod1Entity.Id))
         {
-            var sec = NavigationSection.Create(
-                secEntry.ModuleId, secEntry.Code, secEntry.Label,
-                secEntry.Description, secEntry.Icon, secEntry.IconType,
-                secEntry.Route, secEntry.DisplayOrder);
-            context.NavigationSections.Add(sec);
+            var secExists = await context.NavigationSections
+                .AnyAsync(s => s.Code == secEntry.Code && s.ModuleId == mod1Entity.Id, ct);
+            if (!secExists)
+            {
+                var sec = NavigationSection.Create(
+                    secEntry.ModuleId, secEntry.Code, secEntry.Label,
+                    secEntry.Description, secEntry.Icon, secEntry.IconType,
+                    secEntry.Route, secEntry.DisplayOrder);
+                context.NavigationSections.Add(sec);
+            }
         }
         // Repeat for each module that has sections...
         await ((DbContext)context).SaveChangesAsync(ct);
 
-        // --- Section translations ---
-        foreach (var t in {Module1Pascal}NavigationSeedData.GetSectionTranslationEntries())
+        // --- Section translations (idempotent — check before inserting) ---
+        foreach (var secEntry in {Module1Pascal}NavigationSeedData.GetSectionEntries(mod1Entity.Id))
         {
-            context.NavigationTranslations.Add(
-                NavigationTranslation.Create(t.EntityType, t.EntityId, t.LanguageCode, t.Label, t.Description));
+            if (!await context.NavigationTranslations.AnyAsync(
+                t => t.EntityId == secEntry.Id && t.EntityType == NavigationEntityType.Section, ct))
+            {
+                foreach (var t in {Module1Pascal}NavigationSeedData.GetSectionTranslationEntries()
+                    .Where(st => st.EntityId == secEntry.Id))
+                {
+                    context.NavigationTranslations.Add(
+                        NavigationTranslation.Create(t.EntityType, t.EntityId, t.LanguageCode, t.Label, t.Description));
+                }
+            }
         }
         // Repeat for each module that has sections...
         await ((DbContext)context).SaveChangesAsync(ct);
 
-        // --- Resources (if seedDataCore.navigationResources exists) ---
-        // Module 1 resources (resolved per section)
+        // --- Resources (idempotent — use ACTUAL section IDs from DB, not deterministic seed IDs) ---
+        // CRITICAL: NavigationSection.Create() generates its own ID in DB.
+        // The deterministic GUID from GetSectionEntries() is NOT the actual SectionId.
+        // We MUST query the real section by Code+ModuleId to get the actual DB ID,
+        // otherwise FK_nav_Resources_nav_Sections_SectionId will fail.
         foreach (var secEntry in {Module1Pascal}NavigationSeedData.GetSectionEntries(mod1Entity.Id))
         {
+            var actualSection = await context.NavigationSections
+                .FirstAsync(s => s.Code == secEntry.Code && s.ModuleId == mod1Entity.Id, ct);
+
             foreach (var resEntry in {Module1Pascal}NavigationSeedData.GetResourceEntries(secEntry.Id))
             {
-                var res = NavigationResource.Create(
-                    resEntry.SectionId, resEntry.Code, resEntry.Label,
-                    resEntry.EntityType, resEntry.Route, resEntry.DisplayOrder);
-                context.NavigationResources.Add(res);
+                var resExists = await context.NavigationResources
+                    .AnyAsync(r => r.Code == resEntry.Code && r.SectionId == actualSection.Id, ct);
+                if (!resExists)
+                {
+                    var res = NavigationResource.Create(
+                        actualSection.Id, resEntry.Code, resEntry.Label,
+                        resEntry.EntityType, resEntry.Route, resEntry.DisplayOrder);
+                    context.NavigationResources.Add(res);
+                }
             }
         }
         // Repeat for each module that has resources...

package/templates/skills/review-code/references/owasp-api-top10.md

@@ -101,7 +101,7 @@ public async Task<ActionResult<List<OrderDto>>> GetAll([FromQuery] int pageSize
 
 // GOOD: Enforced max page size
 [HttpGet]
-public async Task<ActionResult<PagedResult<OrderDto>>> GetAll(
+public async Task<ActionResult<PaginatedResult<OrderDto>>> GetAll(
     [FromQuery] int page = 1,
     [FromQuery] int pageSize = 20)
 {