@atlashub/smartstack-cli 3.24.0 → 3.26.0

package/templates/skills/apex/steps/step-04-validate.md

@@ -1,448 +0,0 @@
----
-name: step-04-validate
-description: MCP validation, build verification, seed data check, acceptance criteria
-model: opus
-prev_step: steps/step-03-execute.md
-next_step: steps/step-05-examine.md
----
-
-# Step 4: Validate
-
-**Goal:** Verify everything works. MCP conventions, build, seed data, acceptance criteria.
-
----
-
-## 1. MCP Convention Validation
-
-```
-Call: mcp__smartstack__validate_conventions
-
-Expected: 0 errors
-If errors found:
-  → Fix each error (use appropriate skill/MCP)
-  → Re-validate until 0 errors
-```
-
----
-
-## 2. EF Core Migration Check (if needs_migration)
-
-```
-Call: mcp__smartstack__check_migrations
-
-Verify:
-- Migration exists and is applied
-- No pending model changes
-- ModelSnapshot matches
-```
-
----
-
-## 3. Frontend Route Validation (if frontend modified)
-
-```
-Call: mcp__smartstack__validate_frontend_routes
-
-Verify:
-- Routes nested inside correct Layout wrapper
-- Route paths match controller patterns
-- No orphan routes
-```
-
----
-
-## 4. Build Verification
-
-```bash
-# Backend
-dotnet clean && dotnet restore && dotnet build
-
-# Frontend (if applicable)
-npm run typecheck
-```
-
-**BLOCKING:** Both must pass. If failure, fix and retry.
-
----
-
-## 5. Database & Migration Validation (if needs_migration)
-
-### 5a. Pending Model Changes Check
-
-```bash
-INFRA_PROJECT=$(ls src/*Infrastructure*/*.csproj 2>/dev/null | head -1)
-API_PROJECT=$(ls src/*Api*/*.csproj 2>/dev/null | head -1)
-
-dotnet ef migrations has-pending-model-changes \
-  --project "$INFRA_PROJECT" \
-  --startup-project "$API_PROJECT"
-```
-
-**BLOCKING** if pending changes detected → migration is missing.
-
-### 5b. Migration Application Test (SQL Server LocalDB)
-
-```bash
-DB_NAME="SmartStack_Apex_Validate_$(date +%s)"
-CONN_STRING="Server=(localdb)\\MSSQLLocalDB;Database=$DB_NAME;Integrated Security=true;TrustServerCertificate=true;Connect Timeout=120;"
-
-dotnet ef database update \
-  --connection "$CONN_STRING" \
-  --project "$INFRA_PROJECT" \
-  --startup-project "$API_PROJECT"
-```
-
-**BLOCKING** if migration fails on SQL Server. Common issues:
-- SQLite-only syntax in migrations (fix: regenerate migration)
-- Column type mismatches (fix: update EF configuration)
-- Missing foreign key targets (fix: reorder migrations)
-
-### 5c. Integration Tests on Real SQL Server
-
-```bash
-# Integration tests use DatabaseFixture → real SQL Server LocalDB
-# This validates: LINQ→SQL, multi-tenant isolation, soft delete, EF configs
-INT_TEST_PROJECT=$(ls tests/*Tests.Integration*/*.csproj 2>/dev/null | head -1)
-if [ -n "$INT_TEST_PROJECT" ]; then
-  dotnet test "$INT_TEST_PROJECT" --no-build --verbosity normal
-fi
-```
-
-Tests running against SQL Server catch issues that SQLite misses:
-- Case sensitivity in string comparisons
-- Date/time function differences
-- IDENTITY vs AUTOINCREMENT behavior
-- Global query filter translation to T-SQL
-
-### 5d. Cleanup
-
-```bash
-sqlcmd -S "(localdb)\MSSQLLocalDB" -Q "IF DB_ID('$DB_NAME') IS NOT NULL BEGIN ALTER DATABASE [$DB_NAME] SET SINGLE_USER WITH ROLLBACK IMMEDIATE; DROP DATABASE [$DB_NAME]; END" 2>/dev/null
-```
-
----
-
-## 6. Seed Data Completeness Check (if needs_seed_data)
-
-| File | Checks |
-|------|--------|
-| NavigationApplicationSeedData | MUST be first, deterministic GUID, 4 lang translations |
-| NavigationModuleSeedData | Deterministic GUIDs (SHA256), 4 languages, GetModuleEntry + GetTranslationEntries |
-| PermissionsSeedData | MCP generate_permissions used, paths match Permissions.cs, wildcard + CRUD |
-| RolesSeedData | Admin=wildcard, Manager=CRU, Contributor=CR, Viewer=R |
-| IClientSeedDataProvider | 3 Seed methods, idempotent, factory methods, SaveChanges per group |
-| DI Registration | `services.AddScoped<IClientSeedDataProvider, {App}SeedDataProvider>()` |
-
----
-
-## 6b. BLOCKING POST-CHECKs (bash verification on real files)
-
-> These checks run on the actual generated files. Model-interpreted checks are unreliable.
-
-### POST-CHECK 1: Navigation routes must be full paths starting with /
-
-```bash
-# Find all seed data files and check route values
-SEED_FILES=$(find src/ -path "*/Seeding/Data/*" -name "*.cs" 2>/dev/null)
-if [ -n "$SEED_FILES" ]; then
-  # Check for short routes (no leading /) in Create() calls for navigation entities
-  BAD_ROUTES=$(grep -Pn 'NavigationApplication\.Create\(|NavigationModule\.Create\(|NavigationSection\.Create\(|NavigationResource\.Create\(' $SEED_FILES | grep -v '"/[a-z]')
-  if [ -n "$BAD_ROUTES" ]; then
-    echo "BLOCKING: Navigation routes must be full paths starting with /"
-    echo "$BAD_ROUTES"
-    echo "Expected: \"/business/human-resources\" NOT \"humanresources\""
-    exit 1
-  fi
-fi
-```
-
-### POST-CHECK 2: All services must filter by TenantId (OWASP A01)
-
-```bash
-# Find all service implementation files
-SERVICE_FILES=$(find src/ -path "*/Services/*" -name "*Service.cs" ! -name "I*Service.cs" 2>/dev/null)
-if [ -n "$SERVICE_FILES" ]; then
-  # Check each service file has TenantId reference (either _currentUser.TenantId or TenantId filter)
-  for f in $SERVICE_FILES; do
-    if ! grep -q "TenantId" "$f"; then
-      echo "BLOCKING (OWASP A01): Service missing TenantId filter: $f"
-      echo "Every service query MUST filter by _currentUser.TenantId"
-      exit 1
-    fi
-    if grep -q "Guid.Empty" "$f"; then
-      echo "BLOCKING (OWASP A01): Service uses Guid.Empty instead of _currentUser.TenantId: $f"
-      exit 1
-    fi
-  done
-fi
-```
-
-### POST-CHECK 3: Controllers must use [RequirePermission], not just [Authorize]
-
-```bash
-# Find all controller files
-CTRL_FILES=$(find src/ -path "*/Controllers/*" -name "*Controller.cs" 2>/dev/null)
-if [ -n "$CTRL_FILES" ]; then
-  for f in $CTRL_FILES; do
-    # Check controller has at least one RequirePermission attribute
-    if grep -q "\[Authorize\]" "$f" && ! grep -q "\[RequirePermission" "$f"; then
-      echo "WARNING: Controller uses [Authorize] without [RequirePermission]: $f"
-      echo "Use [RequirePermission(Permissions.{Module}.{Action})] on each endpoint"
-    fi
-  done
-fi
-```
-
-### POST-CHECK 4: Seed data must not use Guid.NewGuid()
-
-```bash
-SEED_FILES=$(find src/ -path "*/Seeding/Data/*" -name "*.cs" 2>/dev/null)
-if [ -n "$SEED_FILES" ]; then
-  BAD_GUIDS=$(grep -n "Guid.NewGuid()" $SEED_FILES 2>/dev/null)
-  if [ -n "$BAD_GUIDS" ]; then
-    echo "BLOCKING: Seed data must use deterministic GUIDs (SHA256), not Guid.NewGuid()"
-    echo "$BAD_GUIDS"
-    exit 1
-  fi
-fi
-```
-
-### POST-CHECK 5: Services must inject ICurrentUser
-
-```bash
-SERVICE_FILES=$(find src/ -path "*/Services/*" -name "*Service.cs" ! -name "I*Service.cs" 2>/dev/null)
-if [ -n "$SERVICE_FILES" ]; then
-  for f in $SERVICE_FILES; do
-    if ! grep -q "ICurrentUser" "$f"; then
-      echo "BLOCKING: Service missing ICurrentUser injection: $f"
-      echo "All services MUST inject ICurrentUser for tenant isolation"
-      exit 1
-    fi
-  done
-fi
-```
-
-### POST-CHECK 6: Translation files must exist for all 4 languages (if frontend)
-
-```bash
-# Find all i18n namespaces used in tsx files
-TSX_FILES=$(find src/pages/ -name "*.tsx" 2>/dev/null)
-if [ -n "$TSX_FILES" ]; then
-  NAMESPACES=$(grep -ohP "useTranslation\(\[?'([^']+)" $TSX_FILES | sed "s/.*'//" | sort -u)
-  for NS in $NAMESPACES; do
-    for LANG in fr en it de; do
-      if [ ! -f "src/i18n/locales/$LANG/$NS.json" ]; then
-        echo "BLOCKING: Missing translation file: src/i18n/locales/$LANG/$NS.json"
-        exit 1
-      fi
-    done
-  done
-fi
-```
-
-### POST-CHECK 7: Pages must use lazy loading (no static page imports in routes)
-
-```bash
-ROUTE_FILES=$(find src/routes/ -name "*.tsx" -o -name "*.ts" 2>/dev/null)
-if [ -n "$ROUTE_FILES" ]; then
-  STATIC_PAGE_IMPORTS=$(grep -Pn "^import .+ from '@/pages/" $ROUTE_FILES 2>/dev/null)
-  if [ -n "$STATIC_PAGE_IMPORTS" ]; then
-    echo "BLOCKING: Route files must use React.lazy() for page imports, not static imports"
-    echo "$STATIC_PAGE_IMPORTS"
-    echo "Fix: const Page = lazy(() => import('@/pages/...').then(m => ({ default: m.Page })));"
-    exit 1
-  fi
-fi
-```
-
-### POST-CHECK 8: Forms must be full pages with routes — ZERO modals/popups/drawers
-
-```bash
-# Check for modal/dialog/drawer imports in page files (create/edit forms)
-PAGE_FILES=$(find src/pages/ -name "*.tsx" 2>/dev/null)
-if [ -n "$PAGE_FILES" ]; then
-  MODAL_IMPORTS=$(grep -Pn "import.*(?:Modal|Dialog|Drawer|Popup|Sheet)" $PAGE_FILES 2>/dev/null)
-  if [ -n "$MODAL_IMPORTS" ]; then
-    echo "BLOCKING: Form pages must NOT use Modal/Dialog/Drawer/Popup components"
-    echo "Create/Edit forms MUST be full pages with their own URL routes"
-    echo "Found modal imports in page files:"
-    echo "$MODAL_IMPORTS"
-    echo "Fix: Create EntityCreatePage.tsx with route /create and EntityEditPage.tsx with route /:id/edit"
-    exit 1
-  fi
-fi
-```
-
-### POST-CHECK 9: Create/Edit pages must exist as separate route pages
-
-```bash
-# For each module with a list page, verify create and edit pages exist
-LIST_PAGES=$(find src/pages/ -name "*ListPage.tsx" -o -name "*sPage.tsx" 2>/dev/null | grep -v test)
-if [ -n "$LIST_PAGES" ]; then
-  for LIST_PAGE in $LIST_PAGES; do
-    PAGE_DIR=$(dirname "$LIST_PAGE")
-    MODULE_NAME=$(basename "$PAGE_DIR")
-    # Check for create page
-    CREATE_PAGE=$(find "$PAGE_DIR" -name "*CreatePage.tsx" 2>/dev/null)
-    if [ -z "$CREATE_PAGE" ]; then
-      echo "WARNING: Module $MODULE_NAME has a list page but no CreatePage — expected EntityCreatePage.tsx"
-    fi
-    # Check for edit page
-    EDIT_PAGE=$(find "$PAGE_DIR" -name "*EditPage.tsx" 2>/dev/null)
-    if [ -z "$EDIT_PAGE" ]; then
-      echo "WARNING: Module $MODULE_NAME has a list page but no EditPage — expected EntityEditPage.tsx"
-    fi
-  done
-fi
-```
-
-### POST-CHECK 10: Form pages must have companion test files
-
-```bash
-# Every CreatePage and EditPage must have a .test.tsx file
-FORM_PAGES=$(find src/pages/ -name "*CreatePage.tsx" -o -name "*EditPage.tsx" 2>/dev/null | grep -v test)
-if [ -n "$FORM_PAGES" ]; then
-  for FORM_PAGE in $FORM_PAGES; do
-    TEST_FILE="${FORM_PAGE%.tsx}.test.tsx"
-    if [ ! -f "$TEST_FILE" ]; then
-      echo "BLOCKING: Form page missing test file: $FORM_PAGE"
-      echo "Expected: $TEST_FILE"
-      echo "All form pages MUST have companion test files (rendering, validation, submit, navigation)"
-      exit 1
-    fi
-  done
-fi
-```
-
-### POST-CHECK 11: FK fields must NOT be plain text inputs (EntityLookup required)
-
-```bash
-# Check for FK fields rendered as plain text inputs in form pages
-FORM_PAGES=$(find src/pages/ -name "*CreatePage.tsx" -o -name "*EditPage.tsx" 2>/dev/null | grep -v test | grep -v node_modules)
-if [ -n "$FORM_PAGES" ]; then
-  # Detect pattern: input with value containing "Id" (e.g., employeeId, departmentId)
-  FK_TEXT_INPUTS=$(grep -Pn 'type=["\x27]text["\x27].*[a-z]+Id|value=\{[^}]*\.[a-z]+Id\}.*type=["\x27]text["\x27]' $FORM_PAGES 2>/dev/null)
-  if [ -n "$FK_TEXT_INPUTS" ]; then
-    echo "BLOCKING: FK fields rendered as plain text inputs — MUST use EntityLookup component"
-    echo "Users cannot type GUIDs manually. Use <EntityLookup /> from @/components/ui/EntityLookup"
-    echo "See smartstack-frontend.md section 6 for the EntityLookup pattern"
-    echo "$FK_TEXT_INPUTS"
-    exit 1
-  fi
-
-  # Check for input placeholders mentioning "ID" or "id" or "Enter...Id"
-  FK_PLACEHOLDER=$(grep -Pn 'placeholder=["\x27].*[Ee]nter.*[Ii][Dd]|placeholder=["\x27].*[Gg][Uu][Ii][Dd]' $FORM_PAGES 2>/dev/null)
-  if [ -n "$FK_PLACEHOLDER" ]; then
-    echo "BLOCKING: Form has placeholder asking user to enter an ID/GUID — use EntityLookup instead"
-    echo "$FK_PLACEHOLDER"
-    exit 1
-  fi
-fi
-```
-
-### POST-CHECK 12: Backend APIs must support search parameter for EntityLookup
-
-```bash
-# Check that controller GetAll methods accept search parameter
-CTRL_FILES=$(find src/ -path "*/Controllers/*" -name "*Controller.cs" 2>/dev/null)
-if [ -n "$CTRL_FILES" ]; then
-  for f in $CTRL_FILES; do
-    # Check if controller has GetAll but no search parameter
-    if grep -q "\[HttpGet\]" "$f" && grep -q "GetAll" "$f"; then
-      if ! grep -q "search" "$f"; then
-        echo "WARNING: Controller missing search parameter on GetAll: $f"
-        echo "GetAll endpoints MUST accept ?search= to enable EntityLookup on frontend"
-        echo "Fix: Add [FromQuery] string? search parameter to GetAll action"
-      fi
-    fi
-  done
-fi
-```
-
-### POST-CHECK 13: No hardcoded Tailwind colors in generated pages
-
-```bash
-NEW_PAGES=$(git diff --name-only HEAD 2>/dev/null | grep "src/pages/.*\.tsx$")
-if [ -n "$NEW_PAGES" ]; then
-  HARDCODED=$(grep -Pn '(bg|text|border)-(?!\[)(red|blue|green|gray|white|black|slate|zinc|neutral|stone)-' $NEW_PAGES 2>/dev/null)
-  if [ -n "$HARDCODED" ]; then
-    echo "WARNING: Pages should use CSS variables instead of hardcoded Tailwind colors"
-    echo "Fix: bg-[var(--bg-card)] instead of bg-white, text-[var(--text-primary)] instead of text-gray-900"
-    echo "$HARDCODED"
-  fi
-fi
-```
-
-**If ANY POST-CHECK fails → fix in step-03, re-validate.**
-
----
-
-## 7. Acceptance Criteria POST-CHECK
-
-For each AC inferred in step-01:
-
-```
-AC1: {criterion} → PASS / FAIL (evidence: {file:line or test})
-AC2: {criterion} → PASS / FAIL (evidence: {file:line or test})
-...
-```
-
-**All ACs must PASS. If any FAIL, go back to step-03 to fix.**
-
----
-
-## 8. Validation Summary
-
-```
-**APEX SmartStack - Validation Complete**
-
-| Check | Status |
-|-------|--------|
-| MCP validate_conventions | PASS (0 errors) |
-| EF Core migrations | PASS / N/A |
-| DB: Migrations apply (SQL Server) | PASS / N/A |
-| DB: Integration tests (SQL Server) | PASS / N/A |
-| Frontend routes | PASS / N/A |
-| dotnet build | PASS |
-| npm typecheck | PASS / N/A |
-| Seed data | PASS / N/A |
-| I18n: 4 languages per namespace | PASS / N/A |
-| Lazy loading: no static page imports | PASS / N/A |
-| Forms: full pages, zero modals | PASS / N/A |
-| Forms: create/edit pages exist | PASS / N/A |
-| Forms: test files exist | PASS / N/A |
-| FK fields: EntityLookup, no plain text | PASS / N/A |
-| APIs: search parameter on GetAll | PASS / N/A |
-| CSS variables: no hardcoded colors | PASS / N/A |
-| Acceptance criteria | {X}/{Y} PASS |
-```
-
----
-
-## 9. Save Output (if save_mode)
-
-Write to `{output_dir}/04-validate.md` with validation results.
-
----
-
-## 10. Route to Next Step
-
-```
-IF examine_mode = true:
-  → Load steps/step-05-examine.md
-
-ELSE IF test_mode = true:
-  → Load steps/step-07-tests.md
-
-ELSE IF pr_mode = true:
-  → Create PR and show final summary
-
-ELSE:
-  → Show final summary and exit
-```
-
----
-
-## FINAL SUMMARY (if no more steps)
-
-Display: task, context, files created/modified, validation status, commits count, next steps (git diff, dotnet test, deploy).