@atlashub/smartstack-cli 3.23.0 → 3.25.0

package/templates/skills/ralph-loop/steps/step-02-execute.md

@@ -63,7 +63,7 @@ Key category triggers:
 |----------|---------------|
 | `infrastructure` with `_migrationMeta` | Migration sequence: MCP suggest → add → update → build |
 | `infrastructure` with seed data keywords | **MANDATORY**: Read `references/core-seed-data.md` |
-| `frontend` | MCP-first: scaffold_api_client → scaffold_routes → pages |
+| `frontend` | MCP-first: scaffold_api_client → scaffold_routes → `/ui-components` skill (pages) → form pages (create/edit = full pages, ZERO modals) → form tests → i18n (4 langues) |
 | `test` | Generate via MCP → run → fix loop → 100% pass required |
 | `validation` | Clean build → full test suite → MCP validate |
 
@@ -164,6 +164,43 @@ fi
 - If `auth_Permissions` is empty → all authorization checks reject → 403 on every endpoint
 - These are **foundational** — without them, ALL subsequent features (frontend, API, tests) are useless
 
+**POST-CHECK: DefaultTenantId cross-schema FK validation (WARNING)**
+
+After generating SeedConstants.cs and DevDataSeeder, verify that `DefaultTenantId` is not a phantom GUID that doesn't exist in `core.tenant_Tenants`:
+
+```bash
+# Find SeedConstants.cs
+SEED_CONSTANTS=$(find . -path "*/SeedConstants.cs" 2>/dev/null | head -1)
+if [ -n "$SEED_CONSTANTS" ]; then
+  # Extract the DefaultTenantId GUID value
+  TENANT_GUID=$(grep -oP 'DefaultTenantId\s*=\s*Guid\.Parse\("([^"]+)"\)' "$SEED_CONSTANTS" | grep -oP '"[^"]+"' | tr -d '"')
+
+  if [ -z "$TENANT_GUID" ]; then
+    echo "⚠️ WARNING: SeedConstants.cs found but DefaultTenantId not defined"
+    echo "DevDataSeeder requires SeedConstants.DefaultTenantId for business seed data"
+    echo "Fix: Add 'public static readonly Guid DefaultTenantId = Guid.Parse(\"...\");' to SeedConstants.cs"
+  else
+    # Verify the GUID is referenced somewhere in platform config (not an invented value)
+    GUID_FOUND=$(grep -r "$TENANT_GUID" appsettings*.json src/ 2>/dev/null | grep -v SeedConstants)
+
+    if [ -z "$GUID_FOUND" ]; then
+      echo "⚠️ WARNING: SeedConstants.DefaultTenantId ($TENANT_GUID) not found in platform config"
+      echo "This GUID must exist in core.tenant_Tenants at runtime"
+      echo "Verify: The SmartStack platform seeds this tenant during InitializeSmartStackAsync()"
+      echo "If using a custom TenantId, ensure it's created before DevDataSeeder runs (Order >= 200)"
+      echo "validate-feature step-05 will verify this FK exists in real database"
+    else
+      echo "✓ SeedConstants.DefaultTenantId ($TENANT_GUID) found in platform config"
+    fi
+  fi
+fi
+```
+
+**Why this matters:**
+- If `DefaultTenantId` references a GUID not in `core.tenant_Tenants`, DevDataSeeder inserts orphan rows
+- Business entities with invalid `TenantId` FK cause runtime 500 errors
+- The tenant must be seeded by `InitializeSmartStackAsync()` BEFORE DevDataSeeder (Order >= 200) runs
+
 ### 6. Validate with MCP
 
 ```
@@ -206,6 +243,158 @@ npm run lint         # ESLint — MUST exit 0
 ```
 If FAIL → read errors → fix TSX/TS files → re-run → loop until pass.
 
+**Frontend POST-CHECKs (BLOCKING for frontend category):**
+```bash
+# POST-CHECK: Forms must be full pages — ZERO modals/popups/drawers
+PAGE_FILES=$(find src/pages/ -name "*.tsx" 2>/dev/null)
+if [ -n "$PAGE_FILES" ]; then
+  MODAL_IMPORTS=$(grep -Pn "import.*(?:Modal|Dialog|Drawer|Popup|Sheet)" $PAGE_FILES 2>/dev/null)
+  if [ -n "$MODAL_IMPORTS" ]; then
+    echo "BLOCKING: Form pages must NOT use Modal/Dialog/Drawer/Popup components"
+    echo "Create/Edit forms MUST be full pages with own URL routes (/create, /:id/edit)"
+    echo "$MODAL_IMPORTS"
+    exit 1
+  fi
+fi
+
+# POST-CHECK: Create/Edit pages must exist for each module with a list page
+LIST_PAGES=$(find src/pages/ -name "*ListPage.tsx" -o -name "*sPage.tsx" 2>/dev/null | grep -v test)
+if [ -n "$LIST_PAGES" ]; then
+  for LP in $LIST_PAGES; do
+    DIR=$(dirname "$LP"); MOD=$(basename "$DIR")
+    if [ -z "$(find "$DIR" -name "*CreatePage.tsx" 2>/dev/null)" ]; then
+      echo "WARNING: Module $MOD has list page but no CreatePage"
+    fi
+    if [ -z "$(find "$DIR" -name "*EditPage.tsx" 2>/dev/null)" ]; then
+      echo "WARNING: Module $MOD has list page but no EditPage"
+    fi
+  done
+fi
+
+# First check: at least one test file must exist in pages/
+PAGE_FILES=$(find src/pages/ -name "*.tsx" ! -name "*.test.tsx" 2>/dev/null)
+if [ -n "$PAGE_FILES" ]; then
+  TEST_FILES=$(find src/pages/ -name "*.test.tsx" 2>/dev/null)
+  if [ -z "$TEST_FILES" ]; then
+    echo "BLOCKING: No frontend test files found in src/pages/"
+    echo "Every module with pages MUST have at least one .test.tsx file"
+    exit 1
+  fi
+fi
+
+# POST-CHECK: Form pages must have companion test files
+FORM_PAGES=$(find src/pages/ -name "*CreatePage.tsx" -o -name "*EditPage.tsx" 2>/dev/null | grep -v test)
+if [ -n "$FORM_PAGES" ]; then
+  for FP in $FORM_PAGES; do
+    TEST="${FP%.tsx}.test.tsx"
+    if [ ! -f "$TEST" ]; then
+      echo "BLOCKING: Form page missing test file: $FP → expected $TEST"
+      exit 1
+    fi
+  done
+fi
+
+# POST-CHECK: FK fields must NOT be plain text inputs — use EntityLookup
+FORM_PAGES=$(find src/pages/ -name "*CreatePage.tsx" -o -name "*EditPage.tsx" 2>/dev/null | grep -v test | grep -v node_modules)
+if [ -n "$FORM_PAGES" ]; then
+  # Match any input with name ending in "Id" (except hidden inputs)
+  FK_TEXT_INPUTS=$(grep -Pn '<input[^>]*name=["\x27][a-zA-Z]*Id["\x27]' $FORM_PAGES 2>/dev/null | grep -v 'type=["\x27]hidden["\x27]')
+  if [ -n "$FK_TEXT_INPUTS" ]; then
+    echo "BLOCKING: FK Guid fields rendered as plain text inputs — MUST use EntityLookup"
+    echo "See smartstack-frontend.md section 6 for the EntityLookup pattern"
+    echo "$FK_TEXT_INPUTS"
+    exit 1
+  fi
+  FK_PLACEHOLDER=$(grep -Pn 'placeholder=["\x27].*[Ee]nter.*[Ii][Dd]|placeholder=["\x27].*[Gg][Uu][Ii][Dd]' $FORM_PAGES 2>/dev/null)
+  if [ -n "$FK_PLACEHOLDER" ]; then
+    echo "BLOCKING: Form placeholder asks user to enter ID/GUID — use EntityLookup instead"
+    echo "$FK_PLACEHOLDER"
+    exit 1
+  fi
+fi
+
+# POST-CHECK: Backend GetAll endpoints must support ?search= for EntityLookup
+CTRL_FILES=$(find src/ -path "*/Controllers/*" -name "*Controller.cs" 2>/dev/null)
+if [ -n "$CTRL_FILES" ]; then
+  for f in $CTRL_FILES; do
+    if grep -q "\[HttpGet\]" "$f" && grep -q "GetAll" "$f"; then
+      if ! grep -q "search" "$f"; then
+        echo "WARNING: Controller missing search parameter on GetAll: $f"
+        echo "GetAll MUST accept ?search= to enable EntityLookup on frontend"
+      fi
+    fi
+  done
+fi
+
+# POST-CHECK: Route seed data vs frontend cross-validation
+SEED_NAV_FILES=$(find src/ -path "*/Seeding/Data/*" -name "*NavigationSeedData.cs" 2>/dev/null)
+APP_TSX=$(find src/ -name "App.tsx" -not -path "*/node_modules/*" 2>/dev/null | head -1)
+if [ -n "$SEED_NAV_FILES" ] && [ -n "$APP_TSX" ]; then
+  SEED_ROUTES=$(grep -ohP 'Route\s*=\s*"([^"]+)"' $SEED_NAV_FILES | sed 's/Route\s*=\s*"//' | sed 's/"//' | sort -u)
+  CLIENT_PATHS=$(grep -ohP "path:\s*['\"]([^'\"]+)['\"]" "$APP_TSX" | sed "s/path:\s*['\"]//;s/['\"]//" | sort -u)
+  if [ -n "$SEED_ROUTES" ] && [ -z "$CLIENT_PATHS" ]; then
+    echo "WARNING: Seed data has navigation routes but App.tsx has no client routes defined"
+  fi
+fi
+
+# POST-CHECK: HasQueryFilter anti-pattern
+CONFIG_FILES=$(find src/ -path "*/Configurations/*" -name "*Configuration.cs" 2>/dev/null)
+if [ -n "$CONFIG_FILES" ]; then
+  BAD_FILTER=$(grep -Pn 'HasQueryFilter.*Guid\.Empty' $CONFIG_FILES 2>/dev/null)
+  if [ -n "$BAD_FILTER" ]; then
+    echo "BLOCKING: HasQueryFilter uses Guid.Empty — must use runtime tenant filter"
+    echo "$BAD_FILTER"
+    exit 1
+  fi
+fi
+
+# POST-CHECK: PaginatedResult<T> for GetAll
+SERVICE_FILES=$(find src/ -path "*/Services/*" -name "*Service.cs" ! -name "I*Service.cs" 2>/dev/null)
+if [ -n "$SERVICE_FILES" ]; then
+  BAD_GETALL=$(grep -Pn 'Task<(List|IEnumerable|IList|ICollection)<' $SERVICE_FILES 2>/dev/null | grep -i "getall")
+  if [ -n "$BAD_GETALL" ]; then
+    echo "BLOCKING: GetAll methods must return PaginatedResult<T>, not List/IEnumerable"
+    echo "$BAD_GETALL"
+    exit 1
+  fi
+fi
+
+# POST-CHECK: i18n required key structure
+FR_I18N_FILES=$(find src/i18n/locales/fr/ -name "*.json" 2>/dev/null)
+if [ -n "$FR_I18N_FILES" ]; then
+  for f in $FR_I18N_FILES; do
+    BASENAME=$(basename "$f")
+    case "$BASENAME" in common.json|navigation.json) continue;; esac
+    for KEY in "actions" "labels" "errors"; do
+      if ! grep -q "\"$KEY\"" "$f"; then
+        echo "WARNING: i18n file missing required key '$KEY': $f"
+      fi
+    done
+  done
+fi
+
+# POST-CHECK: IAuditableEntity + Validator pairing
+ENTITY_FILES=$(find src/ -path "*/Domain/Entities/Business/*" -name "*.cs" 2>/dev/null)
+if [ -n "$ENTITY_FILES" ]; then
+  for f in $ENTITY_FILES; do
+    if grep -q "ITenantEntity" "$f" && ! grep -q "IAuditableEntity" "$f"; then
+      echo "WARNING: Entity has ITenantEntity but missing IAuditableEntity: $f"
+    fi
+  done
+fi
+CREATE_VALIDATORS=$(find src/ -path "*/Validators/*" -name "Create*Validator.cs" 2>/dev/null)
+if [ -n "$CREATE_VALIDATORS" ]; then
+  for CV in $CREATE_VALIDATORS; do
+    UV=$(echo "$CV" | sed 's/Create/Update/')
+    if [ ! -f "$UV" ]; then
+      echo "BLOCKING: CreateValidator without matching UpdateValidator: $CV"
+      echo "Expected: $UV"
+      exit 1
+    fi
+  done
+fi
+```
+
 **Error resolution cycle (ALL categories):**
 1. Read the FULL error output (not just first line)
 2. Identify root cause: file path + line number

package/templates/skills/validate-feature/steps/step-01-compile.md

@@ -15,9 +15,12 @@ next_step: steps/step-02-unit-tests.md
 ls *.sln 2>/dev/null || find . -maxdepth 2 -name "*.sln" -type f
 ```
 
-### 2. Build the entire solution
+### 2. Cleanup & Build
 
 ```bash
+# Cleanup corrupted EF Core design-time artifacts (Roslyn BuildHost bug on Windows)
+for d in src/*/bin?Debug; do [ -d "$d" ] && echo "Removing corrupted artifact: $d" && rm -rf "$d"; done
+
 dotnet build {SolutionFile} --verbosity minimal
 ```
 

package/templates/skills/validate-feature/steps/step-05-db-validation.md

@@ -132,6 +132,65 @@ fi
 
 ---
 
+## 5b. Verify Dev Seeding Configuration
+
+Before checking seed data, verify that dev seeding is actually enabled:
+
+```bash
+# Check 1: EnableDevSeeding in appsettings
+APPSETTINGS_DEV=$(ls appsettings.Development.json 2>/dev/null || ls src/*Api*/appsettings.Development.json 2>/dev/null)
+APPSETTINGS_BASE=$(ls appsettings.json 2>/dev/null || ls src/*Api*/appsettings.json 2>/dev/null)
+
+SEEDING_EXPLICIT_TRUE=false
+SEEDING_EXPLICIT_FALSE=false
+
+# Check Development appsettings first (overrides base)
+if [ -n "$APPSETTINGS_DEV" ]; then
+  if grep -q '"EnableDevSeeding".*true' "$APPSETTINGS_DEV" 2>/dev/null; then
+    SEEDING_EXPLICIT_TRUE=true
+  fi
+fi
+
+# Check base appsettings
+if [ -n "$APPSETTINGS_BASE" ] && [ "$SEEDING_EXPLICIT_TRUE" = "false" ]; then
+  if grep -q '"EnableDevSeeding".*false' "$APPSETTINGS_BASE" 2>/dev/null; then
+    SEEDING_EXPLICIT_FALSE=true
+  fi
+fi
+
+# Check 2: Program.cs override pattern
+PROGRAM_CS=$(find . -name "Program.cs" -path "*/Api/*" 2>/dev/null | head -1)
+PROGRAM_OVERRIDE=false
+if [ -n "$PROGRAM_CS" ]; then
+  if grep -q 'EnableDevSeeding.*IsDevelopment\|IsDevelopment.*EnableDevSeeding' "$PROGRAM_CS" 2>/dev/null; then
+    PROGRAM_OVERRIDE=true
+  fi
+fi
+
+# Evaluate
+if [ "$SEEDING_EXPLICIT_FALSE" = "true" ] && [ "$PROGRAM_OVERRIDE" = "false" ]; then
+  echo "⚠️ WARNING: EnableDevSeeding is FALSE in appsettings.json and NO Program.cs override detected"
+  echo "DevDataSeeder will NOT execute — test data will be empty"
+  echo "Fix option 1: Add to appsettings.Development.json: \"EnableDevSeeding\": true"
+  echo "Fix option 2: Add to Program.cs: options.EnableDevSeeding = builder.Environment.IsDevelopment();"
+  SEEDING_ENABLED=false
+elif [ "$PROGRAM_OVERRIDE" = "true" ]; then
+  echo "✓ EnableDevSeeding: Program.cs overrides to IsDevelopment() — active in Development"
+  SEEDING_ENABLED=true
+else
+  echo "✓ EnableDevSeeding: explicitly enabled"
+  SEEDING_ENABLED=true
+fi
+```
+
+| Result | Meaning | Action |
+|--------|---------|--------|
+| Program.cs override detected | PASS | Dev seeding active in Development environment |
+| Explicitly enabled | PASS | Dev seeding active |
+| FALSE + no override | **WARNING** | DevDataSeeder won't run — seed data checks in section 6 will likely fail |
+
+---
+
 ## 6. Verify Seed Data Execution
 
 ```bash
@@ -182,6 +241,28 @@ if [ "$STARTED" = "true" ]; then
   fi
 fi
 
+# --- DefaultTenantId cross-schema FK validation ---
+# Verify that SeedConstants.DefaultTenantId exists in core.tenant_Tenants
+SEED_CONSTANTS=$(find . -path "*/SeedConstants.cs" 2>/dev/null | head -1)
+if [ -n "$SEED_CONSTANTS" ]; then
+  TENANT_GUID=$(grep -oP 'DefaultTenantId\s*=\s*Guid\.Parse\("([^"]+)"\)' "$SEED_CONSTANTS" | grep -oP '"[^"]+"' | tr -d '"')
+
+  if [ -n "$TENANT_GUID" ] && [ -n "$DB_NAME" ]; then
+    TENANT_EXISTS=$(sqlcmd -S "(localdb)\MSSQLLocalDB" -d "$DB_NAME" -Q "
+      SET NOCOUNT ON;
+      SELECT COUNT(*) FROM core.tenant_Tenants WHERE Id = '$TENANT_GUID'
+    " -h -1 2>/dev/null | tr -d ' ')
+
+    if [ "$TENANT_EXISTS" = "0" ]; then
+      echo "❌ FAIL: SeedConstants.DefaultTenantId ($TENANT_GUID) does NOT exist in core.tenant_Tenants"
+      echo "DevDataSeeder inserts rows with an invalid FK — causes runtime 500 errors"
+      echo "Fix: Use a TenantId that is seeded by InitializeSmartStackAsync()"
+    else
+      echo "✓ DefaultTenantId ($TENANT_GUID) exists in core.tenant_Tenants"
+    fi
+  fi
+fi
+
 # Cleanup
 kill $SEED_PID 2>/dev/null
 wait $SEED_PID 2>/dev/null
@@ -224,6 +305,8 @@ fi
 | Pending model changes          | PASS/FAIL | dotnet ef migrations has-pending           |
 | Migrations apply cleanly       | PASS/FAIL | dotnet ef database update on temp DB       |
 | Integration tests (SQL Server) | PASS/FAIL | dotnet test --filter Integration           |
+| EnableDevSeeding active        | PASS/WARN | Program.cs override or appsettings check   |
+| DefaultTenantId FK valid       | PASS/FAIL | SeedConstants GUID exists in tenant_Tenants|
 | Seed data accessible           | PASS/WARN | API endpoints return seeded data           |
 | Temp DB cleanup                | PASS/WARN | Database dropped                           |
 
@@ -231,7 +314,7 @@ DB Validation Result: {PASS / FAIL / SKIPPED}
 ```
 
 **Interpretation:**
-- **PASS**: All 6 gaps covered — migrations, SQL Server, LINQ→SQL, isolation, seed data verified
+- **PASS**: All 8 checks covered — migrations, SQL Server, LINQ→SQL, isolation, seeding config, tenant FK, seed data verified
 - **FAIL**: One or more checks failed — fix before committing
 - **SKIPPED**: LocalDB not available — tests ran on SQLite only (partial coverage)
 
@@ -248,3 +331,5 @@ DB Validation Result: {PASS / FAIL / SKIPPED}
 | `Cannot insert the value NULL into column` | Missing NOT NULL | Add default value or make column nullable |
 | `Login failed for user` | LocalDB auth | Run `sqllocaldb start MSSQLLocalDB` |
 | `A network-related or instance-specific error` | LocalDB not running | Run `sqllocaldb start MSSQLLocalDB` |
+| `DefaultTenantId does NOT exist in core.tenant_Tenants` | Phantom FK | Use a TenantId seeded by `InitializeSmartStackAsync()` |
+| `EnableDevSeeding is FALSE` + empty tables | Seeding disabled | Add `options.EnableDevSeeding = builder.Environment.IsDevelopment()` in Program.cs |