@atlashub/smartstack-cli 3.22.0 → 3.24.0

package/templates/skills/apex/steps/step-04-validate.md

@@ -126,6 +126,7 @@ sqlcmd -S "(localdb)\MSSQLLocalDB" -Q "IF DB_ID('$DB_NAME') IS NOT NULL BEGIN AL
 
 | File | Checks |
 |------|--------|
+| NavigationApplicationSeedData | MUST be first, deterministic GUID, 4 lang translations |
 | NavigationModuleSeedData | Deterministic GUIDs (SHA256), 4 languages, GetModuleEntry + GetTranslationEntries |
 | PermissionsSeedData | MCP generate_permissions used, paths match Permissions.cs, wildcard + CRUD |
 | RolesSeedData | Admin=wildcard, Manager=CRU, Contributor=CR, Viewer=R |
@@ -134,6 +135,248 @@ sqlcmd -S "(localdb)\MSSQLLocalDB" -Q "IF DB_ID('$DB_NAME') IS NOT NULL BEGIN AL
 
 ---
 
+## 6b. BLOCKING POST-CHECKs (bash verification on real files)
+
+> These checks run on the actual generated files. Model-interpreted checks are unreliable.
+
+### POST-CHECK 1: Navigation routes must be full paths starting with /
+
+```bash
+# Find all seed data files and check route values
+SEED_FILES=$(find src/ -path "*/Seeding/Data/*" -name "*.cs" 2>/dev/null)
+if [ -n "$SEED_FILES" ]; then
+  # Check for short routes (no leading /) in Create() calls for navigation entities
+  BAD_ROUTES=$(grep -Pn 'NavigationApplication\.Create\(|NavigationModule\.Create\(|NavigationSection\.Create\(|NavigationResource\.Create\(' $SEED_FILES | grep -v '"/[a-z]')
+  if [ -n "$BAD_ROUTES" ]; then
+    echo "BLOCKING: Navigation routes must be full paths starting with /"
+    echo "$BAD_ROUTES"
+    echo "Expected: \"/business/human-resources\" NOT \"humanresources\""
+    exit 1
+  fi
+fi
+```
+
+### POST-CHECK 2: All services must filter by TenantId (OWASP A01)
+
+```bash
+# Find all service implementation files
+SERVICE_FILES=$(find src/ -path "*/Services/*" -name "*Service.cs" ! -name "I*Service.cs" 2>/dev/null)
+if [ -n "$SERVICE_FILES" ]; then
+  # Check each service file has TenantId reference (either _currentUser.TenantId or TenantId filter)
+  for f in $SERVICE_FILES; do
+    if ! grep -q "TenantId" "$f"; then
+      echo "BLOCKING (OWASP A01): Service missing TenantId filter: $f"
+      echo "Every service query MUST filter by _currentUser.TenantId"
+      exit 1
+    fi
+    if grep -q "Guid.Empty" "$f"; then
+      echo "BLOCKING (OWASP A01): Service uses Guid.Empty instead of _currentUser.TenantId: $f"
+      exit 1
+    fi
+  done
+fi
+```
+
+### POST-CHECK 3: Controllers must use [RequirePermission], not just [Authorize]
+
+```bash
+# Find all controller files
+CTRL_FILES=$(find src/ -path "*/Controllers/*" -name "*Controller.cs" 2>/dev/null)
+if [ -n "$CTRL_FILES" ]; then
+  for f in $CTRL_FILES; do
+    # Check controller has at least one RequirePermission attribute
+    if grep -q "\[Authorize\]" "$f" && ! grep -q "\[RequirePermission" "$f"; then
+      echo "WARNING: Controller uses [Authorize] without [RequirePermission]: $f"
+      echo "Use [RequirePermission(Permissions.{Module}.{Action})] on each endpoint"
+    fi
+  done
+fi
+```
+
+### POST-CHECK 4: Seed data must not use Guid.NewGuid()
+
+```bash
+SEED_FILES=$(find src/ -path "*/Seeding/Data/*" -name "*.cs" 2>/dev/null)
+if [ -n "$SEED_FILES" ]; then
+  BAD_GUIDS=$(grep -n "Guid.NewGuid()" $SEED_FILES 2>/dev/null)
+  if [ -n "$BAD_GUIDS" ]; then
+    echo "BLOCKING: Seed data must use deterministic GUIDs (SHA256), not Guid.NewGuid()"
+    echo "$BAD_GUIDS"
+    exit 1
+  fi
+fi
+```
+
+### POST-CHECK 5: Services must inject ICurrentUser
+
+```bash
+SERVICE_FILES=$(find src/ -path "*/Services/*" -name "*Service.cs" ! -name "I*Service.cs" 2>/dev/null)
+if [ -n "$SERVICE_FILES" ]; then
+  for f in $SERVICE_FILES; do
+    if ! grep -q "ICurrentUser" "$f"; then
+      echo "BLOCKING: Service missing ICurrentUser injection: $f"
+      echo "All services MUST inject ICurrentUser for tenant isolation"
+      exit 1
+    fi
+  done
+fi
+```
+
+### POST-CHECK 6: Translation files must exist for all 4 languages (if frontend)
+
+```bash
+# Find all i18n namespaces used in tsx files
+TSX_FILES=$(find src/pages/ -name "*.tsx" 2>/dev/null)
+if [ -n "$TSX_FILES" ]; then
+  NAMESPACES=$(grep -ohP "useTranslation\(\[?'([^']+)" $TSX_FILES | sed "s/.*'//" | sort -u)
+  for NS in $NAMESPACES; do
+    for LANG in fr en it de; do
+      if [ ! -f "src/i18n/locales/$LANG/$NS.json" ]; then
+        echo "BLOCKING: Missing translation file: src/i18n/locales/$LANG/$NS.json"
+        exit 1
+      fi
+    done
+  done
+fi
+```
+
+### POST-CHECK 7: Pages must use lazy loading (no static page imports in routes)
+
+```bash
+ROUTE_FILES=$(find src/routes/ -name "*.tsx" -o -name "*.ts" 2>/dev/null)
+if [ -n "$ROUTE_FILES" ]; then
+  STATIC_PAGE_IMPORTS=$(grep -Pn "^import .+ from '@/pages/" $ROUTE_FILES 2>/dev/null)
+  if [ -n "$STATIC_PAGE_IMPORTS" ]; then
+    echo "BLOCKING: Route files must use React.lazy() for page imports, not static imports"
+    echo "$STATIC_PAGE_IMPORTS"
+    echo "Fix: const Page = lazy(() => import('@/pages/...').then(m => ({ default: m.Page })));"
+    exit 1
+  fi
+fi
+```
+
+### POST-CHECK 8: Forms must be full pages with routes — ZERO modals/popups/drawers
+
+```bash
+# Check for modal/dialog/drawer imports in page files (create/edit forms)
+PAGE_FILES=$(find src/pages/ -name "*.tsx" 2>/dev/null)
+if [ -n "$PAGE_FILES" ]; then
+  MODAL_IMPORTS=$(grep -Pn "import.*(?:Modal|Dialog|Drawer|Popup|Sheet)" $PAGE_FILES 2>/dev/null)
+  if [ -n "$MODAL_IMPORTS" ]; then
+    echo "BLOCKING: Form pages must NOT use Modal/Dialog/Drawer/Popup components"
+    echo "Create/Edit forms MUST be full pages with their own URL routes"
+    echo "Found modal imports in page files:"
+    echo "$MODAL_IMPORTS"
+    echo "Fix: Create EntityCreatePage.tsx with route /create and EntityEditPage.tsx with route /:id/edit"
+    exit 1
+  fi
+fi
+```
+
+### POST-CHECK 9: Create/Edit pages must exist as separate route pages
+
+```bash
+# For each module with a list page, verify create and edit pages exist
+LIST_PAGES=$(find src/pages/ -name "*ListPage.tsx" -o -name "*sPage.tsx" 2>/dev/null | grep -v test)
+if [ -n "$LIST_PAGES" ]; then
+  for LIST_PAGE in $LIST_PAGES; do
+    PAGE_DIR=$(dirname "$LIST_PAGE")
+    MODULE_NAME=$(basename "$PAGE_DIR")
+    # Check for create page
+    CREATE_PAGE=$(find "$PAGE_DIR" -name "*CreatePage.tsx" 2>/dev/null)
+    if [ -z "$CREATE_PAGE" ]; then
+      echo "WARNING: Module $MODULE_NAME has a list page but no CreatePage — expected EntityCreatePage.tsx"
+    fi
+    # Check for edit page
+    EDIT_PAGE=$(find "$PAGE_DIR" -name "*EditPage.tsx" 2>/dev/null)
+    if [ -z "$EDIT_PAGE" ]; then
+      echo "WARNING: Module $MODULE_NAME has a list page but no EditPage — expected EntityEditPage.tsx"
+    fi
+  done
+fi
+```
+
+### POST-CHECK 10: Form pages must have companion test files
+
+```bash
+# Every CreatePage and EditPage must have a .test.tsx file
+FORM_PAGES=$(find src/pages/ -name "*CreatePage.tsx" -o -name "*EditPage.tsx" 2>/dev/null | grep -v test)
+if [ -n "$FORM_PAGES" ]; then
+  for FORM_PAGE in $FORM_PAGES; do
+    TEST_FILE="${FORM_PAGE%.tsx}.test.tsx"
+    if [ ! -f "$TEST_FILE" ]; then
+      echo "BLOCKING: Form page missing test file: $FORM_PAGE"
+      echo "Expected: $TEST_FILE"
+      echo "All form pages MUST have companion test files (rendering, validation, submit, navigation)"
+      exit 1
+    fi
+  done
+fi
+```
+
+### POST-CHECK 11: FK fields must NOT be plain text inputs (EntityLookup required)
+
+```bash
+# Check for FK fields rendered as plain text inputs in form pages
+FORM_PAGES=$(find src/pages/ -name "*CreatePage.tsx" -o -name "*EditPage.tsx" 2>/dev/null | grep -v test | grep -v node_modules)
+if [ -n "$FORM_PAGES" ]; then
+  # Detect pattern: input with value containing "Id" (e.g., employeeId, departmentId)
+  FK_TEXT_INPUTS=$(grep -Pn 'type=["\x27]text["\x27].*[a-z]+Id|value=\{[^}]*\.[a-z]+Id\}.*type=["\x27]text["\x27]' $FORM_PAGES 2>/dev/null)
+  if [ -n "$FK_TEXT_INPUTS" ]; then
+    echo "BLOCKING: FK fields rendered as plain text inputs — MUST use EntityLookup component"
+    echo "Users cannot type GUIDs manually. Use <EntityLookup /> from @/components/ui/EntityLookup"
+    echo "See smartstack-frontend.md section 6 for the EntityLookup pattern"
+    echo "$FK_TEXT_INPUTS"
+    exit 1
+  fi
+
+  # Check for input placeholders mentioning "ID" or "id" or "Enter...Id"
+  FK_PLACEHOLDER=$(grep -Pn 'placeholder=["\x27].*[Ee]nter.*[Ii][Dd]|placeholder=["\x27].*[Gg][Uu][Ii][Dd]' $FORM_PAGES 2>/dev/null)
+  if [ -n "$FK_PLACEHOLDER" ]; then
+    echo "BLOCKING: Form has placeholder asking user to enter an ID/GUID — use EntityLookup instead"
+    echo "$FK_PLACEHOLDER"
+    exit 1
+  fi
+fi
+```
+
+### POST-CHECK 12: Backend APIs must support search parameter for EntityLookup
+
+```bash
+# Check that controller GetAll methods accept search parameter
+CTRL_FILES=$(find src/ -path "*/Controllers/*" -name "*Controller.cs" 2>/dev/null)
+if [ -n "$CTRL_FILES" ]; then
+  for f in $CTRL_FILES; do
+    # Check if controller has GetAll but no search parameter
+    if grep -q "\[HttpGet\]" "$f" && grep -q "GetAll" "$f"; then
+      if ! grep -q "search" "$f"; then
+        echo "WARNING: Controller missing search parameter on GetAll: $f"
+        echo "GetAll endpoints MUST accept ?search= to enable EntityLookup on frontend"
+        echo "Fix: Add [FromQuery] string? search parameter to GetAll action"
+      fi
+    fi
+  done
+fi
+```
+
+### POST-CHECK 13: No hardcoded Tailwind colors in generated pages
+
+```bash
+NEW_PAGES=$(git diff --name-only HEAD 2>/dev/null | grep "src/pages/.*\.tsx$")
+if [ -n "$NEW_PAGES" ]; then
+  HARDCODED=$(grep -Pn '(bg|text|border)-(?!\[)(red|blue|green|gray|white|black|slate|zinc|neutral|stone)-' $NEW_PAGES 2>/dev/null)
+  if [ -n "$HARDCODED" ]; then
+    echo "WARNING: Pages should use CSS variables instead of hardcoded Tailwind colors"
+    echo "Fix: bg-[var(--bg-card)] instead of bg-white, text-[var(--text-primary)] instead of text-gray-900"
+    echo "$HARDCODED"
+  fi
+fi
+```
+
+**If ANY POST-CHECK fails → fix in step-03, re-validate.**
+
+---
+
 ## 7. Acceptance Criteria POST-CHECK
 
 For each AC inferred in step-01:
@@ -163,6 +406,14 @@ AC2: {criterion} → PASS / FAIL (evidence: {file:line or test})
 | dotnet build | PASS |
 | npm typecheck | PASS / N/A |
 | Seed data | PASS / N/A |
+| I18n: 4 languages per namespace | PASS / N/A |
+| Lazy loading: no static page imports | PASS / N/A |
+| Forms: full pages, zero modals | PASS / N/A |
+| Forms: create/edit pages exist | PASS / N/A |
+| Forms: test files exist | PASS / N/A |
+| FK fields: EntityLookup, no plain text | PASS / N/A |
+| APIs: search parameter on GetAll | PASS / N/A |
+| CSS variables: no hardcoded colors | PASS / N/A |
 | Acceptance criteria | {X}/{Y} PASS |
 ```
 

package/templates/skills/apex/steps/step-05-examine.md

@@ -60,6 +60,13 @@ For each changed file, check:
 - [ ] SmartTable/SmartForm (not raw HTML tables/forms)
 - [ ] Correct Layout wrapper per context
 
+**FK Fields & Forms:**
+- [ ] FK Guid fields use `EntityLookup` component (NEVER plain text `<input>`)
+- [ ] No placeholder text asking user to "Enter ID" or "Enter GUID"
+- [ ] Create/Edit forms are full pages with own routes (ZERO modals/dialogs)
+- [ ] Backend GetAll endpoints support `?search=` param for EntityLookup
+- [ ] Each EntityLookup has `apiEndpoint`, `mapOption`, `label` props
+
 ---
 
 ## 4. Produce Findings

package/templates/skills/apex/steps/step-07-tests.md

@@ -12,14 +12,15 @@ next_step: steps/step-08-run-tests.md
 
 ---
 
-## 1. Ensure Test Project Exists
+## 1. Ensure Test Projects Exist
+
+### 1a. Unit Test Project
 
 ```bash
-# Check for existing test project
-TEST_PROJECT=$(find tests/ -name "*.Tests.Unit.csproj" 2>/dev/null | head -1)
+# Check for existing unit test project
+UNIT_PROJECT=$(find tests/ -name "*.Tests.Unit.csproj" 2>/dev/null | head -1)
 
-if [ -z "$TEST_PROJECT" ]; then
-  # Create test project
+if [ -z "$UNIT_PROJECT" ]; then
   PROJECT_NAME=$(basename *.sln .sln)
   dotnet new xunit -n "${PROJECT_NAME}.Tests.Unit" -o "tests/${PROJECT_NAME}.Tests.Unit"
   dotnet add "tests/${PROJECT_NAME}.Tests.Unit" package Moq
@@ -31,6 +32,29 @@ if [ -z "$TEST_PROJECT" ]; then
 fi
 ```
 
+### 1b. Integration Test Project (for step-04 DB validation)
+
+```bash
+# Check for existing integration test project
+INT_PROJECT=$(find tests/ -name "*.Tests.Integration.csproj" 2>/dev/null | head -1)
+
+if [ -z "$INT_PROJECT" ]; then
+  PROJECT_NAME=$(basename *.sln .sln)
+  dotnet new xunit -n "${PROJECT_NAME}.Tests.Integration" -o "tests/${PROJECT_NAME}.Tests.Integration"
+  dotnet add "tests/${PROJECT_NAME}.Tests.Integration" package Moq
+  dotnet add "tests/${PROJECT_NAME}.Tests.Integration" package FluentAssertions
+  dotnet add "tests/${PROJECT_NAME}.Tests.Integration" package Respawn
+  dotnet add "tests/${PROJECT_NAME}.Tests.Integration" package Microsoft.EntityFrameworkCore.SqlServer
+  for proj in src/*/*.csproj; do
+    dotnet add "tests/${PROJECT_NAME}.Tests.Integration" reference "$proj"
+  done
+  dotnet sln add "tests/${PROJECT_NAME}.Tests.Integration/${PROJECT_NAME}.Tests.Integration.csproj"
+fi
+```
+
+> **Note:** Integration tests use `DatabaseFixture` + `Respawn` with SQL Server LocalDB.
+> See step-04 section 5c for details.
+
 ---
 
 ## 2. Scaffold Tests via MCP
@@ -76,6 +100,24 @@ Call: mcp__smartstack__scaffold_tests
 Tests: RequirePermission enforcement, multi-tenant isolation
 ```
 
+### Frontend Form Tests
+```
+For each module with create/edit pages:
+  → Generate EntityCreatePage.test.tsx and EntityEditPage.test.tsx
+  → Co-located next to the page component (NOT in __tests__/ folder)
+
+Required test coverage:
+  - Rendering: form renders with all expected fields
+  - Validation: required fields show errors on empty submit
+  - Submission: successful submit calls API and navigates back
+  - Pre-fill (edit only): entity data loaded into fields
+  - Navigation: back/cancel button calls navigate(-1)
+  - Error handling: API error displays error message
+
+Tools: Vitest + React Testing Library + @testing-library/user-event
+Mock API: vi.mock() or MSW — NEVER real API calls
+```
+
 ---
 
 ## 3. Suggest Additional Scenarios
@@ -112,6 +154,7 @@ If under 80%: identify uncovered paths, scaffold additional tests
 | Application | {count} | {%} |
 | API | {count} | {%} |
 | Security | {count} | {%} |
+| Frontend Forms | {count} | {%} |
 
 **Total tests:** {count}
 **Estimated coverage:** {%}

package/templates/skills/business-analyse/_shared.md

@@ -98,13 +98,13 @@ Level 1: Context (business)
 ### Standard Sections per Module
 
 > **RULE: Sections are functional zones, NOT CRUD operations.**
-> `create` and `edit` are ACTIONS within the `list` page (modal/drawer).
+> `create` and `edit` are SEPARATE PAGES with their own URL routes (`/create` and `/:id/edit`).
 > `detail` is a page with tabs accessible by clicking a row in `list` (not a standalone nav section).
 
 | Section | Purpose | Typical Components |
 |---------|---------|-------------------|
-| `list` | **Main page**: entity grid + create action (modal/drawer) + click to detail | DataGrid, FilterBar, Pagination, CreateForm |
-| `detail` | **Reached from list** (hidden nav, route `:id`): tabbed view of entity details + edit capability | BackButton, DetailHeader, StatusBadge, TabPanel, DetailCard, SmartForm (edit), SmartTable (relations), Timeline (history) |
+| `list` | **Main page**: entity grid + create button (navigates to `/create` page) + click to detail | DataGrid, FilterBar, Pagination, CreateButton |
+| `detail` | **Reached from list** (hidden nav, route `:id`): tabbed view of entity details + edit button (navigates to `/:id/edit` page) | BackButton, DetailHeader, StatusBadge, TabPanel, DetailCard, SmartTable (relations), Timeline (history) |
 | `dashboard` | Module overview/KPIs (if analytics needed) | Charts, StatCards, RecentActivity |
 | `approve` | Approval workflow queue (if validation workflow) | ApprovalPanel, StatusTimeline |
 | `import` | Bulk data import (if volume > 100) | FileUpload, MappingTable, Preview |
@@ -115,9 +115,9 @@ Level 1: Context (business)
 
 | NOT a sidebar section | What it really is |
 |---------------|-------------------|
-| `create` | Action button in `list` page → opens Form in modal/drawer |
-| `edit` | Action in detail page → switches fields to edit mode |
-| `delete` | Action with confirmation dialog in `list` or detail |
+| `create` | Action button in `list` page → navigates to `/create` page with form |
+| `edit` | Action in list/detail page → navigates to `/:id/edit` page with pre-filled form |
+| `delete` | Action with inline confirmation in `list` or detail |
 | `search` | FilterBar component integrated in the `list` section |
 
 > **Note on `detail`:** The detail page IS a `specification.sections[]` entry (with `navigation: "hidden"`) so it gets a wireframe, resources, and route. But it is NOT shown in the sidebar — it is reached by clicking a row in `list`. Every module with a `list` section MUST have a companion `detail` section.

package/templates/skills/business-analyse/patterns/suggestion-catalog.md

@@ -489,7 +489,7 @@ Auto-added:
 | Produits/Products | Commerce, Inventaire | Catalogue avec variantes, tarification, stock |
 
 **Section pattern for module dedie:**
-- Section `list` (TOUJOURS) : grille + create en modale + clic vers detail
+- Section `list` (TOUJOURS) : grille + bouton create (navigue vers page `/create`) + clic vers detail
 - Page detail avec onglets : Infos + onglets relationnels
 - Sections additionnelles UNIQUEMENT si : dashboard, approve, import, rapport
 

package/templates/skills/business-analyse/questionnaire/07-ui.md

@@ -39,8 +39,8 @@
 | Need | Component | Détail |
 |------|-----------|--------|
 | List with pagination | DataTable | Tri, pagination, sélection, actions inline |
-| Creation form | Form + Modal | Validation FluentValidation, i18n des erreurs |
-| Edit form | Form + Modal | Pré-remplissage, dirty check, optimistic locking |
+| Creation form | Form page (`/create` route) | Validation FluentValidation, i18n des erreurs |
+| Edit form | Form page (`/:id/edit` route) | Pré-remplissage, dirty check, optimistic locking |
 | Filters | FilterBar | Filtres combinables, persistance URL params |
 | Export | ExportButton | CSV/Excel, respecte les filtres actifs |
 | Cards/Grid | CardGrid | Affichage visuel alternatif au tableau |
@@ -58,7 +58,7 @@
 | Question | If answer is vague/insufficient | Probe |
 |----------|-------------------------------|-------|
 | Q7.1 (devices) | "Desktop uniquement" | "Aucun accès mobile ? Même pas en consultation ? Tablette en atelier/terrain ?" |
-| Q7.5 (screens) | "Un écran de liste" | "Avec création/édition inline ou en modal ? Détail en side panel ou page séparée ?" |
+| Q7.5 (screens) | "Un écran de liste" | "Avec pages dédiées pour création et édition ? Détail en page avec onglets ?" |
 | Q7.5 (screens) | Pas de mention dashboard | "L'utilisateur a-t-il besoin d'un tableau de bord avec des KPIs avant de plonger dans les données ?" |
 | Q7.7 (key info) | "Toutes les colonnes" | "Sur mobile/petit écran, quelles 3-4 colonnes sont indispensables ? Le reste = détail secondaire" |
 | Q7.8 (actions) | "CRUD classique" | "Actions métier spécifiques ? (valider, dupliquer, archiver, changer statut, assigner)" |

package/templates/skills/business-analyse/references/cadrage-pre-analysis.md

@@ -84,7 +84,7 @@ For each detected module, anticipate sections (Level 4) and resources (Level 5)
 | integration | list | sync-status-grid, config-form, log-viewer | Infos, Config, Logs |
 
 > **RULE:** Sections = functional zones only (`list`, `dashboard`, `approve`, `import`, `rapport`, `planning`).
-> `create`/`edit` = actions (modal/drawer) within the `list` page. `detail` = tabbed page reached by clicking a row in `list`.
+> `create`/`edit` = separate pages with own URL routes (`/create` and `/:id/edit`). `detail` = tabbed page reached by clicking a row in `list`.
 
 **Always check:** Does the user's description imply additional functional sections? (e.g., "reports" → `dashboard`, "calendar view" → `planning`, "approval workflow" → `approve`)
 

package/templates/skills/business-analyse/references/entity-architecture-decision.md

@@ -121,7 +121,7 @@ L'entite {E} est-elle CORE pour cette application ?
 Module
 ├── Section: list
 │   └── Page principale avec grille/table
-│   └── Action "Creer" (ouvre formulaire en modale/drawer DANS cette page)
+│   └── Action "Creer" (navigue vers la page /create avec formulaire)
 │   └── Clic sur une ligne → navigation vers la page detail
 │   └── Resources : {entity}-grid, {entity}-filters, {entity}-form
 │
@@ -152,8 +152,8 @@ Module
 
 | PAS une section | C'est quoi en realite |
 |-----------------|----------------------|
-| `create` | Action (bouton) dans la page `list`, ouvre un formulaire en modale/drawer |
-| `edit` | Action dans la page detail, bascule les champs en mode edition |
+| `create` | Action (bouton) dans la page `list`, navigue vers la page `/create` avec formulaire |
+| `edit` | Action dans la page list/detail, navigue vers la page `/:id/edit` avec formulaire pre-rempli |
 | `detail` | Page de detail accessible par navigation depuis `list` (pas une section menu) |
 | `delete` | Action avec confirmation dans la page `list` ou `detail` |
 | `search` | Composant de filtrage integre dans la section `list` |

package/templates/skills/business-analyse/references/handoff-file-templates.md

@@ -70,14 +70,22 @@ From `specification.uiWireframes[]`, `specification.dashboards[]` and `analysis.
 
 ```json
 "frontend": [
-  { "path": "src/pages/{ModuleName}/{PageName}Page.tsx", "type": "Page", "linkedUCs": [], "linkedWireframes": ["{module}-list"], "module": "{moduleCode}", "wireframeAcceptanceCriteria": "Layout MUST match wireframe..." },
-  { "path": "src/pages/{ModuleName}/{PageName}DetailPage.tsx", "type": "Page", "linkedUCs": [], "linkedWireframes": ["{module}-detail"], "module": "{moduleCode}" },
-  { "path": "src/pages/{ModuleName}/{DashboardName}DashboardPage.tsx", "type": "DashboardPage", "linkedUCs": [], "linkedWireframes": ["{module}-dashboard"], "module": "{moduleCode}", "dashboardRef": "{module}-dashboard", "instructions": "Use Recharts library..." },
-  { "path": "src/components/{ModuleName}/{ComponentName}.tsx", "type": "Component", "linkedUCs": [], "linkedWireframes": [], "module": "{moduleCode}" },
-  { "path": "src/hooks/use{ModuleName}{Hook}.ts", "type": "Hook", "linkedUCs": [], "module": "{moduleCode}" }
+  { "path": "src/pages/{ContextPascal}/{ApplicationName}/{ModuleName}/{PageName}Page.tsx", "type": "Page", "linkedUCs": [], "linkedWireframes": ["{module}-list"], "module": "{moduleCode}", "wireframeAcceptanceCriteria": "Layout MUST match wireframe...", "skill": "/ui-components" },
+  { "path": "src/pages/{ContextPascal}/{ApplicationName}/{ModuleName}/{PageName}DetailPage.tsx", "type": "Page", "linkedUCs": [], "linkedWireframes": ["{module}-detail"], "module": "{moduleCode}", "skill": "/ui-components" },
+  { "path": "src/pages/{ContextPascal}/{ApplicationName}/{ModuleName}/{DashboardName}DashboardPage.tsx", "type": "DashboardPage", "linkedUCs": [], "linkedWireframes": ["{module}-dashboard"], "module": "{moduleCode}", "dashboardRef": "{module}-dashboard", "instructions": "Use Recharts library...", "skill": "/ui-components" },
+  { "path": "src/components/{ModuleName}/{ComponentName}.tsx", "type": "Component", "linkedUCs": [], "linkedWireframes": [], "module": "{moduleCode}", "skill": "/ui-components" },
+  { "path": "src/hooks/use{ModuleName}{Hook}.ts", "type": "Hook", "linkedUCs": [], "module": "{moduleCode}" },
+  { "path": "src/i18n/locales/fr/{moduleLower}.json", "type": "I18n", "language": "fr", "module": "{moduleCode}" },
+  { "path": "src/i18n/locales/en/{moduleLower}.json", "type": "I18n", "language": "en", "module": "{moduleCode}" },
+  { "path": "src/i18n/locales/it/{moduleLower}.json", "type": "I18n", "language": "it", "module": "{moduleCode}" },
+  { "path": "src/i18n/locales/de/{moduleLower}.json", "type": "I18n", "language": "de", "module": "{moduleCode}" }
 ]
 ```
 
+**Page generation:** ALL pages and components MUST be generated via `/ui-components` skill (entity lists, grids, tables, dashboards, charts). The `"skill"` field indicates which skill to invoke.
+
+**I18n generation:** 4 JSON files per module (fr, en, it, de) with identical key structures. `{moduleLower}` = lowercase module code. See `smartstack-frontend.md` for JSON template (keys: actions, labels, columns, form, errors, validation, messages, empty).
+
 **Dashboard acceptance criteria:** Chart library (Recharts), chart types matching spec, KPI cards, filters, CSS variables, responsive layout, wireframe-matching positions.
 
 ## 4.6 SeedData Files

package/templates/skills/business-analyse/references/spec-auto-inference.md

@@ -9,7 +9,7 @@
 | string + unique | text | yes | yes | clickAction: navigate:detail |
 | string | text | yes | yes | — |
 | enum / status | badge | yes | yes (multi-select) | colorMap from lifeCycles if exists |
-| FK:Entity | text (join .name) | yes | yes (entity-select) | Display related entity name |
+| FK:Entity | text (join .name) | yes | yes (EntityLookup) | Display related entity name, filter via searchable EntityLookup |
 | decimal | currency | yes | no | — |
 | int | number | yes | no | — |
 | datetime | date-relative | yes | yes (date-range) | — |
@@ -23,7 +23,7 @@
 | string | Input | entity.required | — |
 | string (multiline) | TextArea | entity.required | rows: 4 |
 | enum | Select | entity.required | source: enum name |
-| FK:Entity | EntitySelect | entity.required | source: target entity, searchable |
+| FK:Entity | EntityLookup | entity.required | source: target entity, searchable. Component: `@/components/ui/EntityLookup`. NEVER plain text input for FK Guid fields. Backend API MUST support `?search=` param. See `smartstack-frontend.md` section 6. |
 | decimal | NumberInput | entity.required | — |
 | int | NumberInput | entity.required | — |
 | datetime | DatePicker | entity.required | — |
@@ -31,22 +31,22 @@
 
 ## Auto-Generated UI Components by featureType
 
-> **RULE:** Sections = functional zones only. `create`/`edit` are actions within `list`. `detail` is a tabbed page reached from `list`.
+> **RULE:** Sections = functional zones only. `create`/`edit` are separate pages with own URL routes (`/create` and `/:id/edit`). `detail` is a tabbed page reached from `list`.
 
-| featureType | Sections (functional zones) | List page includes | Detail page tabs |
-|---|---|---|---|
-| data-centric | list | grid, filters, create form (modal) | Infos, {relations} |
-| workflow | list, approve | grid, filters, create form (modal) | Infos, {relations}, Historique |
-| integration | list | grid, filters, config form | Infos, Config, Logs |
-| reporting | dashboard | — | — |
-| full-module | list, dashboard | grid, filters, create form (modal) | Infos, {relations}, Historique |
+| featureType | Sections (functional zones) | List page includes | Form pages | Detail page tabs |
+|---|---|---|---|---|
+| data-centric | list | grid, filters, create button | `/create` page, `/:id/edit` page | Infos, {relations} |
+| workflow | list, approve | grid, filters, create button | `/create` page, `/:id/edit` page | Infos, {relations}, Historique |
+| integration | list | grid, filters, config button | `/create` page, `/:id/edit` page | Infos, Config, Logs |
+| reporting | dashboard | — | — | — |
+| full-module | list, dashboard | grid, filters, create button | `/create` page, `/:id/edit` page | Infos, {relations}, Historique |
 
 ## Component Generation Rules
 
-1. **list section:** SmartTable with all non-long-text attributes as columns, actions = [view, edit, delete], defaultSort = { createdAt, desc }. Create action opens SmartForm in modal/drawer.
-2. **create form (in list):** SmartForm with all writable attributes as fields, component inferred from type. Opens as modal/drawer from the list page.
-3. **detail page (from list click):** TabPanel with: Info tab (all attributes), relation tabs (child SmartTable for each 1:N relationship), History tab (if auditable). See "Detail Page Tab Auto-Inference" below for exact rules.
-4. **edit (in detail):** Same form as create but pre-filled (mode: edit). Inline in the detail page Info tab.
+1. **list section:** SmartTable with all non-long-text attributes as columns, actions = [view, edit, delete], defaultSort = { createdAt, desc }. Create button navigates to `/create` page. Edit action navigates to `/:id/edit` page.
+2. **create page (`/create` route):** SmartForm (full page) with all writable attributes as fields, component inferred from type. Back button + form + submit. NEVER a modal.
+3. **edit page (`/:id/edit` route):** Same form as create but pre-filled with entity data. Full page with back button. NEVER a modal or inline toggle.
+4. **detail page (from list click):** TabPanel with: Info tab (all attributes read-only + edit button navigating to `/:id/edit`), relation tabs (child SmartTable for each 1:N relationship), History tab (if auditable). See "Detail Page Tab Auto-Inference" below for exact rules.
 5. **dashboard section:** Trigger 3d (dashboard specification)
 
 ## Detail Page Tab Auto-Inference

package/templates/skills/business-analyse/steps/step-01-cadrage.md

@@ -136,7 +136,7 @@ pre_analysis:
 
 **Modules identifiés :**
 - **{Module 1}** : {functional description}
-  - Section **list** : {entity}-grid, {entity}-filters, {entity}-form (création en modale)
+  - Section **list** : {entity}-grid, {entity}-filters + pages `/create` et `/:id/edit`
   - Page détail (onglets) : {Infos, {relation_tabs}...}
   - {IF dashboard needed:} Section **dashboard** : {kpi-cards, charts...}
 - **{Module 2}** : {functional description}
@@ -601,7 +601,7 @@ BEFORE transitioning to step-02:
    f. **List detail page tabs** — for entities accessible via click from `list`
 
 > **SECTION RULE:** Sections are functional zones (list, dashboard, approve, import, rapport...).
-> `create` and `edit` are ACTIONS within the `list` page (modal/drawer).
+> `create` and `edit` are SEPARATE PAGES with their own URL routes (`/create` and `/:id/edit`).
 > `detail` is a page with tabs accessible by clicking a row in `list`, NOT a standalone section.
 
 4. **OUTPUT the matrix as text** (do NOT put it inside AskUserQuestion — it won't render):

package/templates/skills/business-analyse/steps/step-02-decomposition.md

@@ -73,7 +73,7 @@ For each mustHave/shouldHave scope item:
 >   "entities": ["Anticipated entity names"],
 >   "estimatedComplexity": "simple|medium|complex",
 >   "anticipatedSections": [
->     { "code": "list", "description": "Main page: grid, create action (modal), click to detail", "resources": ["entity-grid", "entity-filters", "entity-form"] },
+>     { "code": "list", "description": "Main page: grid, create button (navigates to /create page), click to detail", "resources": ["entity-grid", "entity-filters", "entity-create-page", "entity-edit-page"] },
 >     { "code": "dashboard", "description": "Module KPIs and overview (if needed)", "resources": ["entity-kpi-cards", "entity-charts"] }
 >   ],
 >   "detailTabs": ["Informations", "RelatedEntity1", "Historique"]

package/templates/skills/business-analyse/steps/step-03a1-setup.md

@@ -200,7 +200,7 @@ Total: {N} requirements mapped to this module
 For each module, propose standard sections based on module type:
 
 > **RULE:** Sections = functional zones only. `list` is ALWAYS present (default).
-> `create`/`edit` = actions within the `list` page (modal/drawer). `detail` = tabbed page from list click.
+> `create`/`edit` = separate pages with own URL routes (`/create` and `/:id/edit`). `detail` = tabbed page from list click.
 
 | Module Type | Sections (functional zones) | Detail page tabs (from list click) |
 |-------------|---------------------------|-----------------------------------|
@@ -291,7 +291,7 @@ See [references/spec-auto-inference.md](../references/spec-auto-inference.md) fo
 - Entity attribute → SmartTable column mapping (9 type rules)
 - Entity attribute → SmartForm field mapping (8 type rules)
 - Auto-generated sections per featureType (5 types)
-- Component generation rules (list section, create form in modal, detail page with tabs, dashboard section)
+- Component generation rules (list section, create/edit form pages with own routes, detail page with tabs, dashboard section)
 - Status/lifecycle enhancement rules
 
 Write auto-generated sections to `specification.sections[]` via ba-writer.enrichSection()

package/templates/skills/business-analyse/steps/step-03b-ui.md

@@ -319,7 +319,8 @@ For each section, identify what resources/components are needed:
 
 - List section → DataGrid, FilterBar, SearchInput, ExportButton, CreateButton
 - Detail page (from list click) → BackButton, DetailHeader, StatusBadge, TabPanel, DetailCard, SmartForm (edit mode), SmartTable (relation tabs), Timeline (history tab)
-- Create (in list) → SmartForm (modal/drawer), ValidationMessages, SubmitButton
+- Create page (`/create` route) → SmartForm (full page), ValidationMessages, SubmitButton, BackButton
+- Edit page (`/:id/edit` route) → SmartForm (full page, pre-filled), ValidationMessages, SubmitButton, BackButton
 - Approve section → StatusTransitionPanel, CommentBox, ApproveRejectButtons
 - Dashboard section → StatCard, RechartsChart (Bar/Line/Pie/Area), DashboardGrid, FilterBar