@atlashub/smartstack-cli 3.20.0 → 3.21.0

package/templates/skills/business-analyse/steps/step-05a-handoff.md

@@ -194,7 +194,7 @@ See [references/handoff-file-templates.md](../references/handoff-file-templates.
 |----------|--------|-----------|
 | **4.1 Domain** | `analysis.entities[]` | Entities, ValueObjects, Enums, Exceptions |
 | **4.2 Application** | `analysis.useCases[]` | Services, DTOs, Validators |
-| **4.3 Infrastructure** | `analysis.entities[]` | EF Configurations, DbSet, DI |
+| **4.3 Infrastructure** | `analysis.entities[]` | EF Configurations, DbSet, DI. **DEPENDENCY:** Each EF config task MUST `dependsOn` its corresponding domain entity task. |
 | **4.4 API** | `specification.apiEndpoints[]` | Controllers with `{ContextShort}` mapping |
 | **4.5 Frontend** | `specification.uiWireframes[]` | Pages, Components, Hooks + wireframe traceability |
 | **4.6 SeedData** | `specification.seedDataCore` | 5 CORE + business + IClientSeedDataProvider |
@@ -204,6 +204,7 @@ See [references/handoff-file-templates.md](../references/handoff-file-templates.
 - All backend paths include `{ContextPascal}/{ApplicationName}/` hierarchy
 - Frontend pages MUST have `linkedWireframes[]` + `wireframeAcceptanceCriteria`
 - SeedData: 5 CORE entries ALWAYS + IClientSeedDataProvider for client projects
+- **Acceptance Criteria Mapping:** Each task's `acceptanceCriteria` MUST be derived from its own `linkedFRs[]` entries (lookup FR → `acceptanceCriteria`). NEVER map by sequential FR index — use the task's explicit linkedFRs to resolve the correct criteria.
 - Path convention: `Persistence/Seeding/Data/` (NEVER `Data/SeedData/`)
 
 ---
@@ -228,6 +229,52 @@ For each endpoint: operation, method, route, linkedUC, linkedFR, permissions, re
 
 Total endpoints = count of specification.apiEndpoints[] across all modules.
 
+### 6b. Frontend Task Splitting (MANDATORY)
+
+> **CRITICAL:** Frontend MUST be split into discrete tasks, NOT bundled as a single mega-task.
+> A single mega-task covering 5-8 files prevents granular error recovery in ralph-loop.
+
+For each module, generate these SEPARATE frontend file entries (not one monolithic entry):
+
+```json
+"frontend": [
+  { "path": "src/pages/{Mod}/{ListPage}Page.tsx", "type": "Page", "linkedWireframes": ["{module}-list"], "module": "{moduleCode}" },
+  { "path": "src/pages/{Mod}/{DetailPage}Page.tsx", "type": "Page", "linkedWireframes": ["{module}-detail"], "module": "{moduleCode}" },
+  { "path": "src/hooks/use{Module}.ts", "type": "Hook", "module": "{moduleCode}" },
+  { "path": "src/i18n/{module}.json", "type": "I18n", "module": "{moduleCode}" }
+]
+```
+
+Additional per-section pages (dashboard, import, etc.) are separate entries.
+
+**Route wiring task (MANDATORY — separate entry):**
+```json
+{ "path": "src/App.tsx", "type": "RouteWiring", "module": "{moduleCode}", "description": "Wire {module} routes into App.tsx Layout wrappers (standard + tenant-prefixed blocks). BLOCKING: pages without route wiring = blank pages." }
+```
+
+### 6c. Cross-Module PRD (MANDATORY for multi-module features)
+
+> **CRITICAL:** Cross-module integration tasks MUST exist in a dedicated PRD file.
+> Without this, ralph-loop will NOT execute E2E tests or FK validation.
+
+Generate `.ralph/prd-CrossModule.json` with:
+```json
+{
+  "$version": "3.0.0",
+  "implementation": {
+    "filesToCreate": {
+      "tests": [
+        { "path": "src/Tests/Integration/CrossModule/ForeignKeyValidationTests.cs", "type": "IntegrationTests", "module": "CrossModule" },
+        { "path": "src/Tests/Integration/CrossModule/PermissionMatrixTests.cs", "type": "SecurityTests", "module": "CrossModule" },
+        { "path": "src/Tests/Integration/CrossModule/E2EFlowTests.cs", "type": "E2ETests", "module": "CrossModule" }
+      ]
+    }
+  }
+}
+```
+
+Add to progress.txt after all module tasks.
+
 ---
 
 ### 7. Write Handoff to Feature.json
@@ -317,7 +364,7 @@ const seedDataCore = {
     code: m.code,
     label: m.name || m.code,
     description: m.description,
-    icon: null,  // set by ralph-loop
+    icon: inferIconFromModule(m) || "folder",  // MUST be non-null — use sensible default
     iconType: "lucide",
     route: `/business/${master.metadata.application.toLowerCase()}/${m.code.toLowerCase()}`,
     displayOrder: (i + 1) * 10
@@ -386,6 +433,28 @@ const seedDataCore = {
   )
 };
 
+// Icon inference from module context (NEVER leave as null)
+function inferIconFromModule(module) {
+  const codeLC = module.code.toLowerCase();
+  const iconMap = {
+    'employee': 'users', 'staff': 'users', 'personnel': 'users', 'user': 'users',
+    'project': 'folder-kanban', 'task': 'check-square', 'work': 'briefcase',
+    'time': 'clock', 'schedule': 'calendar', 'planning': 'calendar-days',
+    'absence': 'calendar-off', 'leave': 'calendar-off', 'vacation': 'palm-tree',
+    'finance': 'wallet', 'billing': 'receipt', 'invoice': 'file-text',
+    'inventory': 'warehouse', 'stock': 'package', 'product': 'shopping-bag',
+    'customer': 'building', 'client': 'building-2', 'contact': 'contact',
+    'report': 'bar-chart', 'dashboard': 'layout-dashboard', 'analytics': 'trending-up',
+    'document': 'file-text', 'notification': 'bell', 'setting': 'settings',
+    'order': 'shopping-cart', 'vehicle': 'car', 'maintenance': 'wrench',
+    'audit': 'shield-check', 'workflow': 'git-branch', 'approval': 'check-circle'
+  };
+  for (const [keyword, icon] of Object.entries(iconMap)) {
+    if (codeLC.includes(keyword)) return icon;
+  }
+  return "folder";  // fallback — NEVER null
+}
+
 ba-writer.enrichSection({
   featureId: {feature_id},
   section: "seedDataCore",
@@ -393,12 +462,17 @@ ba-writer.enrichSection({
 })
 ```
 
-**POST-CHECK (non-blocking):**
+**POST-CHECK (BLOCKING for icons, warning for counts):**
 ```
 IF seedDataCore.navigationModules.length !== master.modules.length:
   WARNING: seedDataCore has ${seedDataCore.navigationModules.length} nav modules but ${master.modules.length} modules exist
 IF seedDataCore.permissions.length === 0:
   WARNING: seedDataCore has 0 permissions — applicationRoles may be missing
+IF seedDataCore.navigationModules.some(m => !m.icon || m.icon === null):
+  BLOCKING ERROR: "Navigation modules with null icons detected — ralph-loop will render empty navigation"
+  → Fix: Re-run inferIconFromModule() for modules with null icons
+IF seedDataCore.navigationSections.length === 0:
+  WARNING: "0 navigation sections — every module should have at least 1 section (e.g., 'list')"
 ```
 
 #### 7c. Master Handoff (after ALL modules written + seedDataCore generated)

package/templates/skills/business-analyse/steps/step-05b-deploy.md

@@ -357,6 +357,33 @@ After writing the HTML file, verify:
      BLOCKING_ERROR("Module mismatch: expected [${expectedModules}] but wireframes has [${wireframeModules}]")
    ```
 
+9. **MODULE DATA COMPLETENESS** — every module in FEATURE_DATA.modules[] must carry ALL fields from feature.json
+   ```
+   FOR each htmlModule in FEATURE_DATA.modules[]:
+     masterModule = master.modules.find(m => m.code === htmlModule.code)
+
+     // name MUST be display name, NOT code
+     IF htmlModule.name === htmlModule.code AND masterModule.name !== masterModule.code:
+       BLOCKING_ERROR("Module '${htmlModule.code}' has name === code. Expected: '${masterModule.name}'")
+
+     // anticipatedSections MUST be present (drives Structure tab + navigation tree)
+     IF masterModule.anticipatedSections?.length > 0 AND (!htmlModule.anticipatedSections OR htmlModule.anticipatedSections.length === 0):
+       BLOCKING_ERROR("Module '${htmlModule.code}' lost anticipatedSections: master has ${masterModule.anticipatedSections.length}, HTML has 0")
+       → FIX: Copy anticipatedSections from master.modules[].anticipatedSections
+
+     // dependencies/dependents MUST be present (drives dependency graph)
+     IF masterModule.dependencies?.length > 0 AND (!htmlModule.dependencies OR htmlModule.dependencies.length === 0):
+       BLOCKING_ERROR("Module '${htmlModule.code}' lost dependencies array")
+   ```
+
+   Display verification table:
+   ```
+   POST-CHECK: Module data completeness
+   | Module         | name    | sections | deps | wireframes | specs | Match |
+   |----------------|---------|----------|------|------------|-------|-------|
+   | {code}         | {name}  | {n}      | {n}  | {n}        | OK    | OK/FAIL |
+   ```
+
 **IF ANY CHECK FAILS → DO NOT PROCEED. Fix the data mapping and regenerate.**
 
 ---