@atlashub/smartstack-cli 3.10.0 → 3.12.0

package/templates/skills/business-analyse/steps/step-03d-validate.md

@@ -46,7 +46,7 @@ Validate the module specification for completeness and consistency, write to fea
 | validations | 1 | PASS/FAIL |
 | messages | 4 | PASS/FAIL |
 | lifeCycles | 1 (if entity has status) | PASS/FAIL |
-| seedDataCore | 5 sections present | PASS/FAIL (BLOCKING) |
+| seedDataCore | 7 sections present | PASS/FAIL (BLOCKING) |
 
 #### 9b. Consistency Checks
 
@@ -98,7 +98,7 @@ ba-writer.enrichSection({
       { "section": "useCases", "count": {count}, "minimum": 2, "status": "PASS|FAIL" },
       { "section": "functionalRequirements", "count": {count}, "minimum": 4, "status": "PASS|FAIL" },
       { "section": "wireframes", "count": {count}, "minimum": {section_count}, "status": "PASS|FAIL" },
-      { "section": "seedDataCore", "count": 5, "minimum": 5, "status": "PASS|FAIL" }
+      { "section": "seedDataCore", "count": 7, "minimum": 7, "status": "PASS|FAIL" }
     ],
     consistencyChecks: [
       { "check": "UC-FR linkage", "passed": {n}, "warnings": {n}, "errors": {n}, "status": "PASS|FAIL" },
@@ -129,276 +129,35 @@ ba-writer.enrichSection({
 #### 9f. Module Specification Checklist (BLOCKING)
 
 > **CRITICAL:** This checklist MUST be FULLY COMPLETED before marking module status = "specified".
-> **Rationale:** Prevents incomplete modules from reaching handoff, reduces ralph-loop failures.
 
-**Execute BEFORE updating module status to "specified":**
+**Execute the comprehensive validation checklist:**
 
-```javascript
-const checklist = {
-  // SECTION 1: DATA MODEL (BLOCKING)
-  entities: {
-    minimum: 2,
-    actual: specification.entities.length,
-    status: actual >= minimum ? "PASS" : "FAIL",
-    blocking: true,
-    details: "At least 2 entities required for a meaningful module"
-  },
-
-  entityAttributes: {
-    check: "All entities have ≥3 attributes",
-    status: validateAllEntities(e => e.attributes.length >= 3) ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Entities with <3 attributes are likely incomplete"
-  },
-
-  entityRelationships: {
-    check: "All entities have relationships defined (or explicitly marked as standalone)",
-    status: validateEntityRelationships() ? "PASS" : "FAIL",
-    blocking: false,  // WARNING only
-    details: "Standalone entities should be rare in business modules"
-  },
-
-  // SECTION 2: BUSINESS RULES (BLOCKING)
-  businessRules: {
-    minimum: 4,
-    actual: analysis.businessRules.length,
-    status: actual >= minimum ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Minimum 4 BRs (mix of VAL/CALC/WF/SEC/DATA)"
-  },
-
-  businessRuleCategories: {
-    check: "BRs cover ≥2 categories (VAL, CALC, WF, SEC, DATA)",
-    status: countUniqueCategories(analysis.businessRules) >= 2 ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Single-category modules are likely incomplete"
-  },
-
-  businessRulePrefixes: {
-    check: "All BR IDs use module prefix (e.g., BR-VAL-{PREFIX}-NNN)",
-    status: validateBRPrefixes() ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Missing prefixes cause ID collisions in multi-module apps"
-  },
-
-  // SECTION 3: USE CASES & REQUIREMENTS (BLOCKING)
-  useCases: {
-    minimum: 6,
-    actual: specification.useCases.length,
-    status: actual >= minimum ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Minimum 6 UCs (CRUD + 2 business-specific)"
-  },
-
-  useCasePrefixes: {
-    check: "All UC IDs use module prefix (UC-{PREFIX}-NNN)",
-    status: validateUCPrefixes() ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Missing prefixes cause ID collisions"
-  },
-
-  functionalRequirements: {
-    minimum: 4,
-    actual: specification.functionalRequirements.length,
-    status: actual >= minimum ? "PASS" : "FAIL",
-    blocking: true,
-    details: "FRs must cover key functionality"
-  },
-
-  ucFrLinkage: {
-    check: "Every UC has ≥1 linked FR",
-    status: validateUCtoFRLinkage() ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Orphan UCs indicate incomplete requirements"
-  },
-
-  frBrLinkage: {
-    check: "Every FR has ≥1 linked BR",
-    status: validateFRtoBRLinkage() ? "PASS" : "FAIL",
-    blocking: false,  // WARNING only
-    details: "FRs without BRs may lack validation/calculation logic"
-  },
-
-  // SECTION 4: PERMISSIONS (BLOCKING)
-  permissions: {
-    minimum: 5,
-    actual: specification.permissionMatrix.permissions.length,
-    status: actual >= minimum ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Minimum 5 permissions (CRUD + 1 business action)"
-  },
-
-  permissionFormat: {
-    check: "All permissions use full format: business.{app}.{module}.{resource}.{action}",
-    status: validatePermissionFormat() ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Wrong format breaks RBAC system"
-  },
-
-  rolePermissions: {
-    check: "All application roles have ≥1 permission assigned",
-    status: validateRoleAssignments() ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Roles without permissions are useless"
-  },
-
-  // SECTION 5: UI & NAVIGATION (BLOCKING)
-  sections: {
-    minimum: 2,
-    actual: specification.sections.length,
-    status: actual >= minimum ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Modules need ≥2 sections (list + form minimum)"
-  },
-
-  wireframes: {
-    minimum: specification.sections.length,  // 1 wireframe PER section
-    actual: specification.uiWireframes.length,
-    status: actual >= minimum ? "PASS" : "FAIL",
-    blocking: true,
-    details: "EVERY section MUST have a wireframe (ASCII/SVG)"
-  },
-
-  navigation: {
-    check: "Module has ≥1 navigation entry",
-    status: specification.navigation.entries.length >= 1 ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Module must be accessible in menu"
-  },
-
-  // SECTION 6: I18N & MESSAGES (BLOCKING)
-  i18nKeys: {
-    minimum: 42,  // Realistic minimum for a module
-    actual: specification.i18nKeys.length,
-    status: actual >= minimum ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Keys needed: entities (×2), fields, messages, validation, navigation"
-  },
-
-  i18nLanguages: {
-    check: "All i18n keys have 4 languages (fr, en, nl, de)",
-    status: validateI18nCompleteness() ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Missing translations break multi-language support"
-  },
-
-  messages: {
-    minimum: 4,
-    actual: specification.messages.length,
-    status: actual >= minimum ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Minimum: 1 success, 1 error, 1 warning, 1 info"
-  },
-
-  // SECTION 7: SEED DATA (BLOCKING)
-  seedDataCore: {
-    check: "All 5 CORE seed data sections present",
-    requiredSections: [
-      "navigationModules",
-      "navigationTranslations",
-      "permissions",
-      "rolePermissions",
-      "permissionConstants"
-    ],
-    status: validateSeedDataCore() ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Missing CORE seed data breaks module deployment"
-  },
-
-  seedDataBusiness: {
-    check: "Business seed data template defined (even if empty)",
-    status: specification.seedDataBusiness !== undefined ? "PASS" : "FAIL",
-    blocking: false,  // WARNING only
-    details: "Business seed data helps with testing"
-  },
-
-  // SECTION 8: API ENDPOINTS (BLOCKING)
-  apiEndpoints: {
-    minimum: 5,
-    actual: specification.apiEndpoints.length,
-    status: actual >= minimum ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Minimum 5 endpoints (CRUD + 1 business action)"
-  },
-
-  apiPermissions: {
-    check: "Every API endpoint has permission defined",
-    status: validateAPIPermissions() ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Endpoints without permissions are security holes"
-  },
-
-  // SECTION 9: VALIDATIONS (BLOCKING)
-  validations: {
-    minimum: 1,
-    actual: specification.validations.length,
-    status: actual >= minimum ? "PASS" : "FAIL",
-    blocking: true,
-    details: "Modules need field validation rules"
-  },
-
-  // SECTION 10: GHERKIN SCENARIOS (WARNING)
-  gherkinScenarios: {
-    minimum: 2,
-    actual: specification.gherkinScenarios.scenarios.length,
-    status: actual >= minimum ? "PASS" : "FAIL",
-    blocking: false,  // WARNING only
-    details: "Gherkin scenarios enable automated testing"
-  }
-};
+Run the 25-check validation process across 10 categories:
+- Data Model (3 checks) | Business Rules (3 checks) | Use Cases & FRs (4 checks)
+- Permissions (3 checks) | UI & Navigation (3 checks) | I18N & Messages (3 checks)
+- Seed Data (2 checks) | API Endpoints (2 checks) | Validations (1 check) | Gherkin (1 check)
 
-// BLOCKING CHECK: Count failures in BLOCKING items
-const blockingFailures = Object.entries(checklist)
-  .filter(([key, check]) => check.blocking === true && check.status === "FAIL")
-  .map(([key, check]) => ({ section: key, ...check }));
+```javascript
+const blockingFailures = checks.filter(c => c.blocking && c.status === "FAIL");
 
 IF blockingFailures.length > 0:
-  **BLOCKING ERROR:** Module specification incomplete
-
-  Display table:
-  | Section | Required | Actual | Status | Details |
-  |---------|----------|--------|--------|---------|
-  {for each blocking failure}
+  // CONDITIONAL LOAD: Only load detailed checklist on validation failure
+  Read references/validation-checklist.md
+  Display:
+    - Full validation logic for FAILED checks
+    - Exact requirements (minimums, patterns, formats)
+    - Fix recommendations for each failure
 
-  ACTIONS REQUIRED:
-  1. Fix ALL blocking failures listed above
-  2. Re-run step-03d validation
-  3. DO NOT mark module as "specified" until ALL blocking checks pass
+  BLOCKING ERROR: Module specification incomplete
+  → Fix all failures before proceeding
 
-  STOP - DO NOT PROCEED TO UPDATE STATUS
 ELSE:
   All blocking checks passed ✓
-  {count} warnings (non-blocking)
-  Proceed to mark module as "specified"
-```
-
-**Display Checklist Summary:**
-
-```
-═══════════════════════════════════════════════════════════════
-  MODULE SPECIFICATION CHECKLIST - {currentModule}
-═══════════════════════════════════════════════════════════════
-
-| Category | Checks | Passed | Failed | Warnings |
-|----------|--------|--------|--------|----------|
-| Data Model | 3 | {n} | {n} | {n} |
-| Business Rules | 3 | {n} | {n} | {n} |
-| Use Cases & FRs | 4 | {n} | {n} | {n} |
-| Permissions | 3 | {n} | {n} | {n} |
-| UI & Navigation | 3 | {n} | {n} | {n} |
-| I18N & Messages | 3 | {n} | {n} | {n} |
-| Seed Data | 2 | {n} | {n} | {n} |
-| API Endpoints | 2 | {n} | {n} | {n} |
-| Validations | 1 | {n} | {n} | {n} |
-| Gherkin | 1 | {n} | {n} | {n} |
-
-TOTAL: {total_checks} checks | {passed} ✓ | {failed} ✗ | {warnings} ⚠
-
-STATUS: {failed === 0 ? "READY FOR SPECIFIED" : "INCOMPLETE - FIX REQUIRED"}
-═══════════════════════════════════════════════════════════════
+  Display: "{warnings_count} warnings (non-blocking)"
+  → Proceed to mark module as "specified"
 ```
 
-**IF ALL BLOCKING CHECKS PASS → Proceed to update module status to "specified"**
+**Optimization:** The detailed 280-line validation-checklist.md is loaded **only when validation fails** (saves ~10,000 tokens on success path).
 
 ---
 
@@ -475,7 +234,7 @@ ba-writer.enrichSection({
     functionalRequirements: [{id, statement, priority, linkedRules, linkedUseCases, acceptanceCriteria}],  // 8c
     permissionMatrix: {permissions: [], roleAssignments: []},     // 8d
     navigation: {entries: []},                                    // 8e
-    seedDataCore: {navigationModules, navigationTranslations, permissions, rolePermissions, permissionConstants},  // 8f
+    seedDataCore: {navigationModules, navigationSections, navigationResources, navigationTranslations, permissions, rolePermissions, permissionConstants},  // 8f (7 arrays)
     gherkinScenarios: [{feature, scenarios: [{name, tags, given, when, then}]}],  // 8g
     validations: [{entity, field, rules, errorMessageKey}],       // 8h
     messages: [{code, type, title, message, i18nKey}],            // 8i