@atlashub/smartstack-cli 2.7.0 → 2.7.2

package/templates/skills/business-analyse/steps/step-04-consolidation.md

@@ -208,6 +208,115 @@ Store results in consolidation.semanticChecks[]:
 - ≥1 ERROR → BLOCK (fix before handoff, ask user for each)
 - WARNING only → PASS with user notification
 
+### 4-bis. Structural Schema Conformity Check (MANDATORY)
+
+> **Post-generation validation.** After semantic checks, verify that ALL module feature.json files conform to the JSON schema structure. This catches field name mismatches, missing sections, and wrong nesting.
+
+For EACH module feature.json, run these structural checks:
+
+**A. Required Sections Presence**
+
+| Section | Required | Check |
+|---------|----------|-------|
+| `metadata` | YES | Must have: app, module, language, featureDescription, featureType |
+| `discovery` | YES | Must exist (even if minimal) |
+| `analysis.entities[]` | YES | Must have ≥1 entity |
+| `analysis.businessRules[]` | YES | Must have ≥1 BR |
+| `analysis.objectives[]` | YES | Must have ≥1 objective |
+| `analysis.processFlow` | YES | Must have entryPoints, mainFlow, decisionPoints |
+| `analysis.dataLifecycle` | YES | Must have retention, archival, deletion, gdprRelevant |
+| `specification.useCases[]` | YES | Must have ≥1 UC |
+| `specification.functionalRequirements[]` | YES | Must have ≥1 FR |
+| `specification.permissionMatrix` | YES | Must be `{permissions[], roleAssignments[]}` (NOT flat array) |
+| `specification.sections[]` | YES | Must have ≥1 section with resources |
+| `specification.uiWireframes[]` | YES | Must have ≥1 wireframe with `layout` object |
+| `specification.lifeCycles[]` | IF entities have status | States must be objects (NOT strings) |
+| `specification.seedDataCore` | YES | Must have 5 arrays: navigationModules, navigationTranslations, permissions, rolePermissions, permissionConstants |
+| `specification.gherkinScenarios` | YES | Must be `{feature, scenarios[]}` (NOT flat array) |
+| `specification.navigation` | YES | Must have entries[] |
+| `specification.i18nKeys[]` | YES | Must have ≥1 key with fr, en, nl, de |
+| `validation` | YES | Must have completenessChecks, consistencyChecks, semanticChecks, decision |
+| `handoff` | Written by step-05 | Checked post-handoff |
+
+**B. Field Name Conformity**
+
+For each section, verify NO FORBIDDEN field names are used:
+
+| Section | FORBIDDEN fields | Correct fields |
+|---------|-----------------|----------------|
+| `entities[].attributes[]` | `type`, `values`, `rules` | `description`, `unique`, `validation` |
+| `businessRules[]` | `rule`, `condition` (singular), `action` | `name`, `statement`, `conditions[]` |
+| `useCases[]` | `actor`, `linkedBRs`, `linkedFRs` | `primaryActor`, `linkedRules` |
+| `functionalRequirements[]` | `name`, `description`, `linkedUCs`, `linkedBRs` | `statement`, `linkedUseCases`, `linkedRules` |
+| `permissionMatrix` | flat array with `resource`/`roles` | `{permissions[], roleAssignments[]}` |
+| `lifeCycles[].states[]` | string values like `"Active"` | objects with `{id, displayName, color, isTerminal}` |
+| `seedDataCore` | flat object, string values | 5 typed arrays |
+| `gherkinScenarios` | flat scenario array | `{feature, scenarios[]}` nested |
+
+**C. ID Pattern Conformity**
+
+| ID Type | Pattern | Example |
+|---------|---------|---------|
+| BR | `BR-(VAL\|CALC\|WF\|SEC\|DATA)-{PREFIX}-\d{3}` | BR-VAL-RM-001 |
+| UC | `UC-{PREFIX}-\d{3}` | UC-RM-001 |
+| FR | `FR-{PREFIX}-\d{3}` | FR-RM-001 |
+| Permissions | `business.{app}.{module}.{resource}.{action}` | business.freebike.repairs.create |
+
+Verify all IDs use the correct module prefix (2-4 uppercase letters).
+
+**D. Cross-Module ID Uniqueness**
+
+Verify no ID collision across modules:
+```
+SET all_ids = {}
+FOR each module:
+  FOR each BR, UC, FR id:
+    IF id IN all_ids → ERROR: "Duplicate {id} in {module1} and {module2}"
+    ADD id to all_ids
+```
+
+**E. Wireframe Layout Completeness**
+
+For each `uiWireframes[]`:
+```
+IF missing componentMapping[] → ERROR
+IF missing layout object → ERROR
+IF missing layout.regions[] → ERROR
+FOR each region in layout.regions[]:
+  IF missing position → ERROR
+  IF missing components[] → ERROR
+```
+
+**F. SeedDataCore Translation Coverage**
+
+```
+FOR each navigationModules[].code:
+  FOR each language in [fr, en, nl, de]:
+    IF NOT EXISTS navigationTranslations[] with moduleCode AND language → ERROR
+```
+
+**Result aggregation:**
+```json
+{
+  "structuralChecks": [
+    { "check": "required-sections", "module": "...", "status": "PASS|ERROR", "details": "Missing: analysis.objectives" },
+    { "check": "field-names", "module": "...", "status": "PASS|ERROR", "details": "businessRules[0] uses 'rule' instead of 'name'+'statement'" },
+    { "check": "id-patterns", "module": "...", "status": "PASS|ERROR", "details": "BR-001 missing category segment" },
+    { "check": "id-uniqueness", "module": "...", "status": "PASS|ERROR", "details": "UC-RM-003 duplicated in Vehicles and Repairs" },
+    { "check": "wireframe-layout", "module": "...", "status": "PASS|ERROR", "details": "Wireframe repairs-list missing layout object" },
+    { "check": "seeddata-translations", "module": "...", "status": "PASS|ERROR", "details": "Missing nl translation for NavigationModuleRepairs" }
+  ]
+}
+```
+
+**Blocking rule:**
+- 0 ERROR → PASS (merge structuralChecks into consolidation.semanticChecks[])
+- ≥1 ERROR → BLOCK. For each ERROR:
+  1. Attempt AUTO-FIX (rename fields, restructure)
+  2. Re-write the module feature.json with fixes
+  3. Re-check
+  4. If still ERROR → ask user
+
 ### 5. End-to-End Flows
 
 Identify business processes that span multiple modules:
@@ -308,21 +417,77 @@ IF "Modifier les interactions":
 
 ### 9. Write Consolidation
 
+> **STRUCTURE CARD: consolidation** — Must match `application-schema.json`. Follow this structure exactly.
+
 ```
 ba-writer.enrichSection({
   featureId: {feature_id},
   section: "consolidation",
   data: {
-    crossModuleInteractions: { fkReferences, sharedEntities, events, sharedReferenceData },
-    permissionCoherence: { roleConsistency, pathFormat, hierarchy, conflicts, resolved },
-    e2eFlows: [...],
-    globalRiskAssessment: {...}
+    crossModuleInteractions: [
+      {
+        "fromModule": "Orders",
+        "toModule": "Customers",
+        "interactionType": "FK-reference|event-publish|event-subscribe|shared-lookup|cascade-delete|cascade-update",
+        "description": "Order references customer via FK",
+        "entities": ["Order→Customer"]
+      }
+    ],
+    sharedEntities: [
+      {
+        "entity": "Customer",
+        "ownerModule": "Customers",
+        "referencedBy": ["Orders", "Invoices"],
+        "sharedFields": ["code", "name"]
+      }
+    ],
+    permissionCoherence: {
+      "rolesConsistent": true,
+      "pathFormatConsistent": true,
+      "hierarchyRespected": true,
+      "conflicts": [],
+      "warnings": []
+    },
+    e2eFlows: [
+      {
+        "name": "Order to Invoice",
+        "modules": ["Customers", "Orders", "Invoices"],
+        "steps": [
+          { "module": "Orders", "action": "Create order", "permission": "business.sales.orders.create", "dataFlow": "Customer → Order" }
+        ]
+      }
+    ],
+    globalRiskAssessment: [
+      {
+        "risk": "Cross-module coupling complexity",
+        "category": "coupling|complexity|dependency-chain|security|scope",
+        "severity": "critical|high|medium|low",
+        "mitigation": "Event-driven communication instead of direct FK"
+      }
+    ],
+    semanticChecks: [
+      { "check": "permission-orpheline", "status": "PASS|WARNING|ERROR", "details": "..." },
+      { "check": "uc-sans-fr", "status": "PASS|WARNING|ERROR", "details": "..." },
+      { "check": "wireframe-coverage", "status": "PASS|WARNING|ERROR", "details": "..." }
+    ],
+    decision: {
+      "approved": true,
+      "reason": "All cross-module validations passed",
+      "approvedBy": "Client",
+      "approvedAt": "{ISO timestamp}"
+    }
   }
 })
 
 ba-writer.updateStatus({feature_id}, "consolidated")
 ```
 
+> **STRUCTURE DIFFERENCES FROM OLD FORMAT:**
+> - `crossModuleInteractions` is a FLAT ARRAY (not `{fkReferences, sharedEntities, events}` nested object)
+> - `sharedEntities` is TOP-LEVEL (not nested inside crossModuleInteractions)
+> - `decision` is an OBJECT with `approved`, `reason`, `approvedBy`, `approvedAt` (not `clientApproval` string)
+> - `globalRiskAssessment` is an ARRAY of risk objects (not `{totalEntities: {value, threshold}}`)
+
 Add changelog entry:
 ```json
 {

package/templates/skills/business-analyse/steps/step-05-handoff.md

@@ -759,6 +759,30 @@ COLORS:
 
 #### 9a. Module Handoff Loop (MANDATORY)
 
+> **STRUCTURE CARD: handoff** — Field names are EXACT. Include ALL fields below.
+> ```json
+> {
+>   "complexity": "simple|medium|complex",
+>   "filesToCreate": {
+>     "domain": [{"path": "...", "type": "Entity|ValueObject|Enum", "linkedFRs": [], "linkedUCs": [], "module": "..."}],
+>     "application": [{"path": "...", "type": "Service|Dto|Validator", "linkedFRs": [], "linkedUCs": [], "module": "..."}],
+>     "infrastructure": [{"path": "...", "type": "Repository|DbContext", "linkedFRs": [], "module": "..."}],
+>     "api": [{"path": "...", "type": "ApiController", "linkedUCs": [], "linkedFRs": [], "module": "..."}],
+>     "frontend": [{"path": "...", "type": "Page|Component|Hook|DashboardPage", "linkedUCs": [], "linkedWireframes": [], "module": "..."}],
+>     "seedData": [{"path": "...", "type": "HasData", "category": "core|business", "source": "...", "module": "..."}],
+>     "tests": [{"path": "...", "type": "UnitTests|IntegrationTests|SecurityTests", "linkedFRs": [], "linkedUCs": [], "module": "..."}]
+>   },
+>   "brToCodeMapping": [{"ruleId": "BR-...", "files": ["path1", "path2"], "implementation": "description"}],
+>   "apiEndpointSummary": [{"method": "GET|POST|PUT|DELETE", "path": "/api/...", "permission": "business.{app}.{module}.{action}", "linkedUC": "UC-..."}],
+>   "prdFile": ".ralph/prd-{module}.json",
+>   "totalFiles": 0,
+>   "totalTasks": 0,
+>   "handedOffAt": "{ISO timestamp}"
+> }
+> ```
+> **MANDATORY fields:** ALL of the above. `filesToCreate` MUST have all 7 categories (even if empty arrays).
+> **FORBIDDEN:** `handoff: {}` (empty object is a CRITICAL BUG). Missing `brToCodeMapping` or `apiEndpointSummary`.
+
 **For i = 0; i < modules.length; i++:**
 
 ```