@atlashub/smartstack-cli 1.16.0 → 1.17.0

package/templates/commands/efcore/squash.md

@@ -103,24 +103,50 @@ echo "Backup: $BACKUP_DIR"
 
 ---
 
-## STEP 4: Récupérer ModelSnapshot de la Branche Parente (CRUCIAL)
+## STEP 4: Récupérer Migrations ET Snapshot de la Branche Parente (CRUCIAL)
 
 ```bash
 # Sauvegarder snapshot actuel
 cp "$MIGRATIONS_DIR"/*ModelSnapshot.cs "$BACKUP_DIR/"
 
-# Récupérer le snapshot de la branche parente
+# Récupérer TOUTES les migrations de la branche parente
 git fetch origin "$BASE_BRANCH" --quiet
+
+# 1. Récupérer le ModelSnapshot
 git checkout "origin/$BASE_BRANCH" -- "$MIGRATIONS_DIR"/*ModelSnapshot.cs
 
-echo "ModelSnapshot récupéré depuis: origin/$BASE_BRANCH"
+# 2. Récupérer les fichiers de migration de la branche parente
+# (pour ne pas perdre les migrations déjà présentes sur develop/main)
+for base_mig in $BASE_MIGRATIONS; do
+  base_file=$(basename "$base_mig")
+  base_name="${base_file%.cs}"
+
+  # Récupérer le fichier migration ET son Designer
+  git checkout "origin/$BASE_BRANCH" -- "$MIGRATIONS_DIR/${base_name}.cs" 2>/dev/null || true
+  git checkout "origin/$BASE_BRANCH" -- "$MIGRATIONS_DIR/${base_name}.Designer.cs" 2>/dev/null || true
+done
+
+echo "Récupéré depuis origin/$BASE_BRANCH:"
+echo "  - ModelSnapshot"
+echo "  - $(echo "$BASE_MIGRATIONS" | wc -l) migrations"
 ```
 
 **Pourquoi c'est crucial:**
 - Le snapshot de `$BASE_BRANCH` contient l'état VALIDÉ et COMPLET
+- Les **migrations existantes** de `$BASE_BRANCH` doivent être conservées
 - Les migrations parallèles sur d'autres branches sont incluses
 - Évite la perte d'information de schéma (cf. [Bokio best practices](https://www.bokio.se/engineering-blog/how-to-squash-ef-core-migrations/))
 
+**Résultat attendu:**
+```
+feature/* après squash:
+├── Core_v1_9_0_001_InitialSchema.cs       ← De develop (conservé)
+├── Core_v1_9_0_001_InitialSchema.Designer.cs
+├── core_v1.0.0_001_FeatureConsolidated.cs ← Squash de la feature
+├── core_v1.0.0_001_FeatureConsolidated.Designer.cs
+└── CoreDbContextModelSnapshot.cs          ← De develop
+```
+
 ---
 
 ## STEP 5: Supprimer Migrations de la Branche (pas celles héritées)
@@ -139,29 +165,48 @@ echo "Supprimé: ${#BRANCH_ONLY_MIGRATIONS[@]} migrations"
 
 ## STEP 6: Créer Migration Consolidée
 
+**OBLIGATOIRE: Utiliser le MCP pour le nommage conforme**
+
 ```bash
-# Nommage selon contexte
+# Construire la description selon le contexte
 case "$BRANCH_TYPE" in
   feature)
-    BRANCH_NAME=$(echo "$CURRENT_BRANCH" | sed 's|feature/||')
-    MIGRATION_NAME="Feature_${BRANCH_NAME}_Consolidated"
+    BRANCH_NAME=$(echo "$CURRENT_BRANCH" | sed 's|feature/||' | sed 's/-/ /g')
+    DESCRIPTION="${BRANCH_NAME} Consolidated"
     ;;
   release)
-    VERSION=$(echo "$CURRENT_BRANCH" | sed 's|release/||' | tr '.' '_')
-    MIGRATION_NAME="Release_${VERSION}_Initial"
+    VERSION=$(echo "$CURRENT_BRANCH" | sed 's|release/||')
+    DESCRIPTION="Release ${VERSION} Initial"
     ;;
   hotfix)
-    VERSION=$(echo "$CURRENT_BRANCH" | sed 's|hotfix/||' | tr '.' '_')
-    MIGRATION_NAME="Hotfix_${VERSION}_Fix"
+    VERSION=$(echo "$CURRENT_BRANCH" | sed 's|hotfix/||')
+    DESCRIPTION="Hotfix ${VERSION} Fix"
     ;;
   develop)
-    MIGRATION_NAME="Develop_Consolidated_$(date +%Y%m%d)"
+    DESCRIPTION="Develop Consolidated"
     ;;
   *)
-    MIGRATION_NAME="Consolidated_$(date +%Y%m%d_%H%M%S)"
+    DESCRIPTION="Consolidated"
     ;;
 esac
+```
 
+**Appel MCP OBLIGATOIRE:**
+
+```javascript
+// Utiliser le MCP pour obtenir le nom conforme
+mcp__smartstack__suggest_migration({
+  description: DESCRIPTION,  // Ex: "multitenant Consolidated"
+  context: "core"            // ou "extensions" selon le projet
+})
+
+// Résultat: core_v1.0.0_001_MultitenantConsolidated
+```
+
+**Puis créer la migration:**
+
+```bash
+# MIGRATION_NAME = résultat du MCP (ex: core_v1.0.0_001_MultitenantConsolidated)
 dotnet ef migrations add "$MIGRATION_NAME" \
   --project "$INFRA_PROJECT" \
   --startup-project "$STARTUP_PROJECT" \
@@ -169,6 +214,8 @@ dotnet ef migrations add "$MIGRATION_NAME" \
   --verbose
 ```
 
+> **Convention:** `{context}_v{version}_{sequence}_{Description}` - Jamais de nom hardcodé
+
 ---
 
 ## STEP 7: Validation
@@ -192,11 +239,19 @@ dotnet ef migrations script --no-build --idempotent > /dev/null
 
 ```
 SQUASH - {CURRENT_BRANCH}
-  Base:       {BASE_BRANCH} (snapshot récupéré)
-  Backup:     {BACKUP_DIR}
-  Avant:      {MIGRATION_COUNT} migrations
-  Apres:      1 migration ({MIGRATION_NAME})
-  Conformite: EF Core CLI, Pas de .sql, Snapshot parent
+  Base:         {BASE_BRANCH}
+  Backup:       {BACKUP_DIR}
+
+  Récupéré de {BASE_BRANCH}:
+    - ModelSnapshot
+    - {BASE_MIGRATION_COUNT} migrations (conservées)
+
+  Consolidé:
+    - Avant:  {MIGRATION_COUNT} migrations (propres à la branche)
+    - Après:  1 migration ({MIGRATION_NAME})
+
+  Total final: {BASE_MIGRATION_COUNT + 1} migrations
+  Conformité:  MCP suggest_migration, EF Core CLI, Snapshot parent
 
 Prochains: /efcore:db-reset, /efcore:db-deploy, /gitflow:3-commit
 ```

package/templates/skills/gitflow/steps/step-commit.md

@@ -188,27 +188,32 @@ EOF
 COMMIT_HASH=$(git rev-parse --short HEAD)
 ```
 
-### 7. Auto-Push (based on config)
+### 7. Push to Remote (ALWAYS ASK USER)
+
+**MANDATORY: Always ask user before pushing commits:**
+
+```yaml
+AskUserQuestion:
+  header: "Push"
+  question: "Push commit to origin/$CURRENT?"
+  options:
+    - label: "Yes, push now"
+      description: "git push origin $CURRENT"
+    - label: "No, later"
+      description: "Keep commit local for now"
+```
 
+**If user chooses "Yes":**
 ```bash
-PUSH_MODE=$(grep -oP '"afterCommit":\s*"\K[^"]+' .claude/gitflow/config.json 2>/dev/null || echo "ask")
-
-case "$PUSH_MODE" in
-  always)
-    git push origin $CURRENT
-    PUSHED="yes"
-    ;;
-  worktree)
-    # Push if in worktree
-    [ -n "$(git worktree list | grep $(pwd))" ] && git push origin $CURRENT && PUSHED="yes"
-    ;;
-  ask)
-    # Ask user
-    ;;
-  never)
-    PUSHED="no"
-    ;;
-esac
+git push origin $CURRENT
+PUSHED="yes"
+echo "✅ Pushed to origin/$CURRENT"
+```
+
+**If user chooses "No":**
+```bash
+PUSHED="no"
+echo "⏸️ Commit kept local. Push later with: git push origin $CURRENT"
 ```
 
 ### 8. Summary
@@ -248,7 +253,7 @@ esac
 - Migrations validated (if present)
 - Destructive operations confirmed
 - Commit created with proper message
-- Pushed (if configured)
+- **Push: ALWAYS ask user (never automatic)**
 
 ## NEXT STEP:
 

package/templates/skills/gitflow/steps/step-start.md

@@ -152,6 +152,14 @@ git checkout "$BASE_BRANCH" && git pull origin "$BASE_BRANCH"
 git checkout -b "$FULL_BRANCH"
 ```
 
+### 6b. Push Branch to Remote (AUTOMATIC)
+
+**ALWAYS push immediately after branch creation:**
+```bash
+git push -u origin "$FULL_BRANCH"
+echo "✅ Branch pushed to origin/$FULL_BRANCH"
+```
+
 ### 7. Create Local Environment Config (Backend + Frontend)
 
 **Detect project structure:**
@@ -323,6 +331,7 @@ EOF
 ## SUCCESS CRITERIA:
 
 - Branch created from correct base
+- **Branch pushed to remote (AUTOMATIC)**
 - Worktree set up (if enabled)
 - Backend local config created: `appsettings.Local.json` (if .NET API detected)
 - Frontend local config created: `.env.local` + `npm run local` script (if web project detected)

package/templates/skills/review-code/SKILL.md

@@ -7,8 +7,83 @@ description: This skill should be used when the user asks to "review code", "rev
 Provide expert-level code review guidance that focuses on high-impact issues: security vulnerabilities, logic errors, maintainability problems, and architectural concerns. Skip nitpicks and style issues that should be automated.
 
 Based on research from Google, Microsoft, OWASP, and academic studies on code review effectiveness.
+
+**For SmartStack projects**: Automatically validates SmartStack-specific conventions via MCP.
 </objective>
 
+<smartstack_integration>
+## SmartStack Project Detection & MCP Validation
+
+**CRITICAL**: Before starting any code review, detect if this is a SmartStack project and run MCP validation.
+
+<detection>
+**Detect SmartStack project by checking for ANY of these:**
+- `.claude/mcp-status.json` exists
+- `SmartStack.Domain/` or `SmartStack.Application/` directories
+- `*.sln` file containing "SmartStack"
+- `package.json` with `@smartstack/` dependencies
+</detection>
+
+<mcp_validation>
+**If SmartStack detected, run MCP validation FIRST:**
+
+1. **Validate conventions** (BLOCKING issues):
+   ```
+   mcp__smartstack__validate_conventions
+   checks: ["all"]
+   ```
+
+2. **Validate security** (when available):
+   ```
+   mcp__smartstack__validate_security
+   checks: ["all"]
+   ```
+
+3. **Analyze code quality** (when available):
+   ```
+   mcp__smartstack__analyze_code_quality
+   metrics: ["all"]
+   ```
+
+4. **Validate test conventions**:
+   ```
+   mcp__smartstack__validate_test_conventions
+   checks: ["all"]
+   ```
+</mcp_validation>
+
+<mcp_checks>
+**SmartStack-specific checks via MCP:**
+
+| Category | MCP Tool | What it validates |
+|----------|----------|-------------------|
+| **Tables** | `validate_conventions` | Préfixes (auth_, nav_, cfg_), schemas (core/extensions) |
+| **Migrations** | `validate_conventions` | Nommage `{context}_v{version}_{sequence}_{Description}` |
+| **Services** | `validate_conventions` | Interfaces I*Service |
+| **Entities** | `validate_conventions` | ITenantEntity, factory methods, private constructors |
+| **Controllers** | `validate_conventions` | [NavRoute] attributes, route format |
+| **Multi-tenant** | `validate_conventions` | TenantId isolation, no cross-tenant access |
+| **Tests** | `validate_test_conventions` | Naming, structure, patterns AAA |
+</mcp_checks>
+
+<output_integration>
+**Merge MCP results into review output:**
+
+```markdown
+## SmartStack Conventions (via MCP)
+
+| Severity | Issue | Location | Fix |
+|----------|-------|----------|-----|
+| BLOCKING | {MCP error} | `file:line` | {MCP suggestion} |
+| WARNING | {MCP warning} | `file:line` | {MCP suggestion} |
+```
+
+**Priority mapping:**
+- MCP errors → `[BLOCKING]`
+- MCP warnings → `[SUGGESTION]`
+</output_integration>
+</smartstack_integration>
+
 <quick_start>
 <review_priority>
 **Priority order**: Security > Correctness > Maintainability > Performance
@@ -207,6 +282,7 @@ A good code review:
 - Avoids nitpicks on style/formatting
 - Completes in reasonable time (<4 hours for small PRs)
 - **[React/Next.js]** Includes Vercel best practices review when applicable
+- **[SmartStack]** Runs MCP validation and integrates results into review output
 </success_criteria>
 
 <reference_guides>
@@ -216,4 +292,5 @@ For detailed guidance and patterns:
 - **`references/clean-code-principles.md`** - SOLID principles, naming conventions, function design, code smell detection
 - **`references/feedback-patterns.md`** - Valuable vs wasteful feedback patterns, communication strategies, priority labeling
 - **`references/code-quality-metrics.md`** - Complexity calculations, maintainability index, measurement techniques
+- **`references/smartstack-conventions.md`** - SmartStack-specific conventions, MCP integration, multi-tenant patterns
 </reference_guides>

package/templates/skills/review-code/references/smartstack-conventions.md

@@ -0,0 +1,302 @@
+<overview>
+SmartStack-specific conventions and patterns. This reference is used when reviewing SmartStack projects to ensure compliance with the architecture and security standards.
+
+**IMPORTANT**: All convention validation MUST be delegated to the MCP SmartStack tools. This file documents what to look for; the MCP validates automatically.
+</overview>
+
+<mcp_tools>
+## MCP SmartStack Tools for Code Review
+
+| Tool | Purpose | When to use |
+|------|---------|-------------|
+| `mcp__smartstack__validate_conventions` | Validate all SmartStack conventions | Always run first |
+| `mcp__smartstack__validate_test_conventions` | Validate test patterns | When tests are in scope |
+| `mcp__smartstack__validate_security` | Security-specific checks | Security-focused reviews |
+| `mcp__smartstack__analyze_code_quality` | Code metrics analysis | Quality-focused reviews |
+| `mcp__smartstack__check_migrations` | EF Core migration conflicts | When migrations are modified |
+</mcp_tools>
+
+<architecture>
+## SmartStack Architecture (Clean Architecture)
+
+```
+SmartStack/
+├── SmartStack.Domain/           # Entities, Value Objects, Domain Events
+├── SmartStack.Application/      # Services, DTOs, Commands/Queries
+├── SmartStack.Infrastructure/   # EF Core, External services
+├── SmartStack.Api/              # Controllers, Middleware
+└── SmartStack.Web/              # React frontend
+```
+
+**Dependency rule**: Dependencies point inward only (Api → Application → Domain).
+</architecture>
+
+<entities>
+## Entity Conventions
+
+<tenant_aware>
+**Tenant-aware entities** (most business entities):
+```csharp
+public class Order : BaseEntity, ITenantEntity
+{
+    public Guid TenantId { get; private set; }
+
+    private Order() { } // EF Core constructor
+
+    public static Order Create(Guid tenantId, ...)
+    {
+        return new Order { TenantId = tenantId, ... };
+    }
+}
+```
+
+**Requirements:**
+- [ ] Implements `ITenantEntity`
+- [ ] Has `TenantId` property
+- [ ] Private parameterless constructor
+- [ ] Static `Create()` factory method with `tenantId` as first parameter
+</tenant_aware>
+
+<system_entity>
+**System entities** (platform-level, no tenant):
+```csharp
+public class Permission : SystemEntity
+{
+    private Permission() { }
+
+    public static Permission Create(...)
+    {
+        return new Permission { ... };
+    }
+}
+```
+
+**Requirements:**
+- [ ] Inherits from `SystemEntity`
+- [ ] NO `TenantId` property
+- [ ] Private parameterless constructor
+- [ ] Static `Create()` factory method
+</system_entity>
+</entities>
+
+<tables>
+## Table Naming Conventions
+
+**Schema**: All tables MUST specify schema explicitly.
+```csharp
+builder.ToTable("auth_users", SchemaConstants.Core);
+```
+
+**Prefixes by domain:**
+| Prefix | Domain | Examples |
+|--------|--------|----------|
+| `auth_` | Authentication | auth_users, auth_roles |
+| `nav_` | Navigation | nav_menus, nav_routes |
+| `cfg_` | Configuration | cfg_settings, cfg_features |
+| `ai_` | AI/Prompts | ai_prompts, ai_models |
+| `ntf_` | Notifications | ntf_templates, ntf_logs |
+| `wkf_` | Workflows | wkf_definitions, wkf_instances |
+| `doc_` | Documents | doc_files, doc_versions |
+| `tkt_` | Tickets/Support | tkt_tickets, tkt_comments |
+
+**Schemas:**
+- `core` (SchemaConstants.Core): SmartStack platform tables
+- `extensions` (SchemaConstants.Extensions): Client-specific tables
+</tables>
+
+<migrations>
+## Migration Naming
+
+**Format**: `{context}_v{version}_{sequence}_{Description}.cs`
+
+**Examples:**
+- `core_v1.0.0_001_CreateAuthUsers.cs`
+- `core_v1.2.0_001_AddUserProfiles.cs`
+- `extensions_v1.0.0_001_CreateClientOrders.cs`
+
+**Rules:**
+- [ ] Context: `core` or `extensions`
+- [ ] Version: semver format (1.0.0)
+- [ ] Sequence: 3-digit padded (001, 002)
+- [ ] Description: PascalCase, descriptive
+</migrations>
+
+<controllers>
+## Controller Conventions
+
+**NavRoute attribute** (preferred):
+```csharp
+[ApiController]
+[NavRoute("platform.administration.users")]
+public class UsersController : ControllerBase
+{
+    // Routes generated from NavRoute: /api/platform/administration/users
+}
+```
+
+**NavRoute format:**
+- Lowercase only
+- Dot-separated hierarchy
+- Minimum 2 levels: `context.application`
+- Full path: `context.application.module`
+
+**Examples:**
+- `platform.administration.users`
+- `platform.administration.roles`
+- `business.crm.contacts`
+- `personal.myspace.dashboard`
+</controllers>
+
+<services>
+## Service Conventions
+
+**Interface pattern:**
+```csharp
+// Interface
+public interface IUserService
+{
+    Task<UserDto> GetByIdAsync(Guid id, CancellationToken ct);
+    Task<UserDto> CreateAsync(CreateUserDto dto, CancellationToken ct);
+}
+
+// Implementation
+public class UserService : IUserService
+{
+    // ...
+}
+```
+
+**Requirements:**
+- [ ] Interface named `I{Name}Service`
+- [ ] Implementation named `{Name}Service`
+- [ ] All methods async with CancellationToken
+- [ ] Return DTOs, not entities
+</services>
+
+<security>
+## SmartStack Security Patterns
+
+<multi_tenant>
+**Multi-tenant isolation:**
+- ALL queries MUST filter by TenantId (automatic via EF Core global filters)
+- NEVER expose TenantId in URLs
+- NEVER allow cross-tenant data access
+- Create methods MUST require tenantId parameter
+
+**Check for violations:**
+```csharp
+// BAD: No tenant filter
+var users = await _context.Users.ToListAsync();
+
+// GOOD: Tenant filter applied (via global filter or explicit)
+var users = await _context.Users
+    .Where(u => u.TenantId == _tenantId)
+    .ToListAsync();
+```
+</multi_tenant>
+
+<authorization>
+**RBAC with NavRoute:**
+- Controllers use `[NavRoute]` for automatic permission mapping
+- Permissions follow NavRoute pattern: `{navroute}.{action}`
+- Actions: `read`, `create`, `update`, `delete`, `*` (wildcard)
+
+**Example permissions:**
+- `platform.administration.users.read`
+- `platform.administration.users.create`
+- `platform.administration.users.*` (all actions)
+</authorization>
+
+<input_validation>
+**FluentValidation:**
+```csharp
+public class CreateUserDtoValidator : AbstractValidator<CreateUserDto>
+{
+    public CreateUserDtoValidator()
+    {
+        RuleFor(x => x.Email)
+            .NotEmpty()
+            .EmailAddress()
+            .MaximumLength(256);
+    }
+}
+```
+</input_validation>
+</security>
+
+<tests>
+## Test Conventions
+
+**Naming pattern:** `{Method}_When{Condition}_Should{Result}`
+```csharp
+public class UserServiceTests
+{
+    [Fact]
+    public async Task GetById_WhenUserExists_ShouldReturnUser() { }
+
+    [Fact]
+    public async Task GetById_WhenUserNotFound_ShouldThrowNotFoundException() { }
+
+    [Fact]
+    public async Task Create_WhenValidDto_ShouldCreateAndReturnUser() { }
+}
+```
+
+**Structure:**
+```
+Tests/
+├── Unit/
+│   ├── Services/
+│   └── Validators/
+└── Integration/
+    └── Controllers/
+```
+
+**Patterns:**
+- [ ] AAA pattern (Arrange, Act, Assert)
+- [ ] FluentAssertions for assertions
+- [ ] Moq for mocking
+- [ ] Tenant isolation tests for all tenant-aware services
+</tests>
+
+<review_checklist>
+## SmartStack Code Review Checklist
+
+**Run MCP validation first:**
+```
+mcp__smartstack__validate_conventions checks: ["all"]
+```
+
+**Then verify manually:**
+
+<security_checks>
+### Security (BLOCKING)
+- [ ] No hardcoded credentials or secrets
+- [ ] TenantId isolation enforced
+- [ ] Authorization on all endpoints
+- [ ] Input validation present
+- [ ] No SQL injection risks (use EF Core properly)
+</security_checks>
+
+<architecture_checks>
+### Architecture (BLOCKING)
+- [ ] Entities use correct base class (BaseEntity/SystemEntity)
+- [ ] Services have interfaces
+- [ ] Controllers use [NavRoute]
+- [ ] Migrations follow naming convention
+</architecture_checks>
+
+<quality_checks>
+### Quality (SUGGESTION)
+- [ ] Tests exist for new functionality
+- [ ] Factory methods used for entity creation
+- [ ] DTOs used for API boundaries
+- [ ] Async methods have CancellationToken
+</quality_checks>
+</review_checklist>
+
+<sources>
+- SmartStack Architecture Documentation
+- SmartStack.mcp validation tools
+- Clean Architecture by Robert C. Martin
+</sources>