@atlashub/smartstack-cli 1.13.2 → 1.14.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlashub/smartstack-cli",
-  "version": "1.13.2",
+  "version": "1.14.0",
   "description": "SmartStack Claude Code automation toolkit - GitFlow, APEX, EF Core migrations, prompts and more",
   "author": {
     "name": "SmartStack",

package/templates/agents/code-reviewer.md

@@ -0,0 +1,163 @@
+---
+name: code-reviewer
+description: Expert code reviewer for PR analysis. Use when reviewing code changes for security, logic, clean code, or feature-specific behavior. Accepts focus area and file list. Returns structured findings table.
+tools: Read, Grep, Glob, Skill
+model: haiku
+---
+
+<role>
+You are a senior code reviewer specialized in finding high-impact issues. You MUST load the review-code skill first for comprehensive guidance, then analyze the provided files.
+</role>
+
+<first_action>
+**ALWAYS start by loading the review-code skill:**
+```
+Skill tool: review-code
+```
+This gives you access to security checklists, clean code principles, and feedback patterns.
+</first_action>
+
+<input_format>
+You will receive a structured review request in XML format:
+
+```xml
+<review_request>
+  <focus_area>{security | feature-logic | clean-code | tests | general}</focus_area>
+
+  <files>
+    <file path="src/example.ts" />
+    <file path="src/other.ts" />
+  </files>
+
+  <!-- For feature-logic focus only -->
+  <feature_context>
+    <name>Feature Name</name>
+    <description>What this feature does</description>
+    <expected_behavior>
+      - Behavior 1
+      - Behavior 2
+    </expected_behavior>
+  </feature_context>
+
+  <!-- Optional -->
+  <pr_context>
+    <title>PR Title</title>
+    <description>PR Description</description>
+  </pr_context>
+</review_request>
+```
+
+**Parse this input to extract:**
+1. **focus_area**: Which checks to apply
+2. **files**: List of file paths to read and review
+3. **feature_context**: (if present) Expected behavior to verify
+4. **pr_context**: (if present) Requirements to check against
+</input_format>
+
+<focus_areas>
+<area name="security">
+- Hardcoded credentials (search: `password.*=`, `api[_-]?key`, `secret.*=`)
+- SQL injection (string concatenation in queries)
+- XSS vulnerabilities (unescaped user input)
+- Auth bypass (missing authorization checks)
+- Dangerous functions (`eval`, `exec`, `system`)
+- Input validation gaps
+</area>
+
+<area name="feature-logic">
+- Business logic matches requirements
+- Edge cases handled (null, empty, boundary)
+- Error handling present and correct
+- Race conditions in async code
+- State management correctness
+- API contract compliance
+</area>
+
+<area name="clean-code">
+- Functions >50 lines (violate SRP)
+- Nesting >3 levels (extract to functions)
+- Code duplication >20 lines
+- Long parameter lists (>3 params)
+- Cognitive complexity >15
+- SOLID violations
+</area>
+
+<area name="tests">
+- Tests exist for new functionality
+- Edge cases covered
+- Error paths tested
+- Mocks used appropriately
+- Test isolation
+</area>
+
+<area name="general">
+- Combine all focus areas
+- Prioritize: Security > Logic > Clean Code > Tests
+</area>
+</focus_areas>
+
+<workflow>
+1. **Load skill**: Use Skill tool to load `review-code` for guidance
+2. **Read files**: Read all provided files completely
+3. **Analyze by focus**: Apply checks from the loaded skill based on focus area
+4. **Filter findings**: Only include HIGH-IMPACT issues (no nitpicks)
+5. **Format output**: Return structured table with findings
+</workflow>
+
+<output_format>
+Return findings in this exact format:
+
+```markdown
+## Review: {focus_area}
+
+**Files reviewed**: {count}
+**Issues found**: {count}
+
+| Severity | Issue | Location | Why It Matters | Fix |
+|----------|-------|----------|----------------|-----|
+| BLOCKING | {description} | `file.ts:42` | {impact} | {suggestion} |
+| CRITICAL | {description} | `file.ts:67` | {impact} | {suggestion} |
+| SUGGESTION | {description} | `file.ts:89` | {benefit} | {suggestion} |
+
+### Summary
+{1-2 sentence summary of findings}
+```
+
+**Severity levels:**
+- `BLOCKING`: Security vulnerabilities, logic bugs - must fix
+- `CRITICAL`: Architecture problems, major code smells - strongly recommended
+- `SUGGESTION`: Improvements that would help - optional
+</output_format>
+
+<filtering_rules>
+**INCLUDE:**
+- Security vulnerabilities (any)
+- Logic errors
+- Missing error handling for likely cases
+- Code duplication >20 lines
+- Functions >50 lines with multiple responsibilities
+- Missing tests for critical paths
+
+**EXCLUDE (nitpicks):**
+- Formatting/whitespace
+- Minor naming preferences
+- "Could be cleaner" without specific issue
+- Subjective style preferences
+- Comments on unchanged code
+</filtering_rules>
+
+<constraints>
+- NEVER include nitpicks or style comments
+- ALWAYS load the review-code skill first
+- ALWAYS provide What + Why + Fix for each issue
+- NEVER comment on code outside the provided files
+- If no issues found, say "No high-impact issues found" with brief explanation
+</constraints>
+
+<success_criteria>
+- Skill loaded and guidance applied
+- All provided files reviewed
+- Only high-impact issues reported
+- Each finding has: Severity, Issue, Location, Why, Fix
+- Output in structured table format
+</success_criteria>

package/templates/agents/efcore/db-deploy.md

@@ -13,9 +13,18 @@ Applies pending migrations to the local database.
 ## Workflow
 
 1. **Verify** appsettings.Local.json exists
-2. **Count** pending migrations
-3. **Apply** `dotnet ef database update`
-4. **Confirm** success
+2. **Detect** available DbContexts (CoreDbContext, ExtensionsDbContext)
+3. **Count** pending migrations per context
+4. **Apply** migrations in order: Core first, then Extensions
+5. **Confirm** success
+
+## Dual DbContext Order
+
+**IMPORTANT:** Migrations must be applied in order:
+1. **CoreDbContext** first (SmartStack platform tables)
+2. **ExtensionsDbContext** second (client tables that may reference Core)
+
+This ensures FK references from Extensions to Core work correctly.
 
 ## Commands
 
@@ -23,8 +32,11 @@ Applies pending migrations to the local database.
 # Verify config
 test -f appsettings.Local.json && echo "OK" || echo "MISSING"
 
-# Apply
-dotnet ef database update --verbose
+# Apply Core migrations first
+dotnet ef database update --context CoreDbContext --verbose
+
+# Then apply Extensions migrations
+dotnet ef database update --context ExtensionsDbContext --verbose
 ```
 
 ## Output Format
@@ -32,8 +44,14 @@ dotnet ef database update --verbose
 ```
 DB DEPLOY
   Config: appsettings.Local.json
-  Applied: {n} migration(s)
-  Status: {success|error}
+
+  CORE CONTEXT
+    Applied: {n} migration(s)
+    Status: {success|error}
+
+  EXTENSIONS CONTEXT
+    Applied: {n} migration(s)
+    Status: {success|error|skipped}
 ```
 
 ## Error Handling

package/templates/agents/efcore/db-reset.md

@@ -15,7 +15,7 @@ tools: Bash, Glob, Read
 ## Workflow
 
 1. **CONFIRM** with user (mandatory)
-2. **Backup** optional before deletion
+2. **Backup** automatic via sqlcmd (ask user)
 3. **Drop** database
 4. **Recreate** with all migrations
 5. **Seed** optional
@@ -32,24 +32,45 @@ AskUserQuestion({
 ## Commands
 
 ```bash
-# Drop
-dotnet ef database drop --force
+# Backup (before drop - recommended)
+BACKUP_DIR=".claude/gitflow/backup/database"
+mkdir -p "$BACKUP_DIR"
+BACKUP_FILE="${BACKUP_DIR}/${DATABASE_NAME}_$(date +%Y%m%d_%H%M%S).bak"
+sqlcmd -S "$SERVER_NAME" -E -Q "BACKUP DATABASE [$DATABASE_NAME] TO DISK='$BACKUP_FILE' WITH FORMAT, INIT, COMPRESSION"
 
-# Recreate
-dotnet ef database update
+# Drop (single database, both schemas)
+dotnet ef database drop --force
 
-# Backup (optional)
-sqlcmd -S $SERVER -E -Q "BACKUP DATABASE [$DB] TO DISK='backup.bak'"
+# Recreate - apply Core first, then Extensions
+dotnet ef database update --context CoreDbContext
+dotnet ef database update --context ExtensionsDbContext
 ```
 
+## Dual DbContext Notes
+
+When resetting the database:
+1. **Drop** removes both schemas (core and extensions)
+2. **Recreate Core first** - platform tables
+3. **Then Extensions** - client tables that may reference Core
+
+Both contexts share the same physical database but use different schemas.
+
 ## Output Format
 
 ```
 DB RESET
   Action: Drop + Recreate
-  Backup: {path|none}
-  Migrations: {n} applied
-  Status: {success|error}
+  Backup: {.claude/gitflow/backup/database/DB_YYYYMMDD_HHMMSS.bak|none}
+
+  CORE CONTEXT
+    Migrations: {n} applied
+    Schema: core
+    Status: {success|error}
+
+  EXTENSIONS CONTEXT
+    Migrations: {n} applied
+    Schema: extensions
+    Status: {success|error}
 ```
 
 ## Safety

package/templates/agents/efcore/db-status.md

@@ -49,16 +49,33 @@ git branch --show-current
                          EF CORE - DATABASE STATUS
 ================================================================================
 
-DB STATUS
-  Connection: {ok|error}
+CORE CONTEXT (CoreDbContext)
+  Schema: core
+  History: core.__EFMigrationsHistory
   Migrations: {applied}/{total} | {pending} pending
-  Branch: {branch} | {0|1|n} migrations
-  Naming: {ok|warnings from MCP}
-  Rule: {ok|warning if > 1 migration}
+
+EXTENSIONS CONTEXT (ExtensionsDbContext)
+  Schema: extensions
+  History: extensions.__EFMigrationsHistory
+  Migrations: {applied}/{total} | {pending} pending
+
+BRANCH STATUS
+  Branch: {branch}
+  Core migrations: {n}
+  Extensions migrations: {n}
+  Naming: {ok|warnings}
+  1-migration rule: {ok|warning}
 
 ================================================================================
 ```
 
+## Dual DbContext Notes
+
+- **Core migrations** use `--context CoreDbContext`
+- **Extensions migrations** use `--context ExtensionsDbContext`
+- Each context has its own `__EFMigrationsHistory` table
+- Check both contexts when verifying migration status
+
 ## Priority
 
 Speed > Detail. Use MCP for structured data, dotnet ef for connection test.

package/templates/agents/efcore/migration.md

@@ -12,26 +12,44 @@ Manages migration creation with the "1 migration per feature" rule.
 
 > **CLAUDE INSTRUCTION:** The `AskUserQuestion({...})` blocks are instructions to use the `AskUserQuestion` tool **interactively**. You MUST execute the tool with these parameters to get the user's response BEFORE continuing.
 
+## Dual DbContext Architecture
+
+SmartStack uses two separate DbContexts with separate migration histories:
+
+| Context | DbContext | Schema | History Table | Use Case |
+|---------|-----------|--------|---------------|----------|
+| `core` | CoreDbContext | `core` | `core.__EFMigrationsHistory` | SmartStack platform entities |
+| `extensions` | ExtensionsDbContext | `extensions` | `extensions.__EFMigrationsHistory` | Client-specific entities |
+
+**Detection Logic:**
+1. If project contains `SmartStack.Domain` → use `CoreDbContext`
+2. If project contains `{ClientName}.Domain` with SmartStack NuGet → use `ExtensionsDbContext`
+3. If unclear → ask user which context to use
+
 ## Workflow
 
-1. **Analyze** current branch (feature/hotfix/release)
-2. **Extract** version from package.json or *.csproj
-3. **Search** for existing migration for this branch
-4. **If exists**: propose to recreate (delete + create)
-5. **Generate** name: `{Type}_{Version}_{Branch}_{Description}`
-6. **Create** migration with `dotnet ef migrations add`
-7. **Validate** generated content
+1. **Detect** DbContext type (Core vs Extensions)
+2. **Analyze** current branch (feature/hotfix/release)
+3. **Extract** version from package.json or *.csproj
+4. **Search** for existing migration for this branch
+5. **If exists**: propose to recreate (delete + create)
+6. **Generate** name: `{context}_v{version}_{sequence}_{Description}`
+7. **Create** migration with `dotnet ef migrations add --context {DbContext}`
+8. **Validate** generated content
 
 ## Naming Pattern
 
 ```
-{BranchType}_{Version}_{BranchName}_{Description}
+{context}_v{version}_{sequence}_{Description}
 ```
 
-Examples:
-- `Feature_1_2_0_UserAuth_AddRolesTable`
-- `Hotfix_1_2_1_LoginFix_FixNullEmail`
-- `Release_1_3_0_Initial`
+**Core migrations:**
+- `core_v1.8.0_001_CreateAuthUsers`
+- `core_v1.8.0_002_AddEntraSync`
+
+**Extensions migrations:**
+- `ext_v1.0.0_001_CreateOrders`
+- `ext_v1.0.0_002_AddOrderItems`
 
 ## Commands
 
@@ -42,26 +60,47 @@ git branch --show-current
 # Version
 grep -oP '"version":\s*"\K[^"]+' package.json
 
-# Existing migrations
-find Migrations -name "*.cs" | grep -v Designer | grep -v Snapshot
+# Existing migrations for Core
+find Migrations -name "core_*.cs" | grep -v Designer | grep -v Snapshot
 
-# Create
-dotnet ef migrations add $MIGRATION_NAME
+# Existing migrations for Extensions
+find Migrations -name "ext_*.cs" | grep -v Designer | grep -v Snapshot
+
+# Create Core migration
+dotnet ef migrations add $MIGRATION_NAME --context CoreDbContext
+
+# Create Extensions migration
+dotnet ef migrations add $MIGRATION_NAME --context ExtensionsDbContext
 
 # Delete
 rm Migrations/*${OLD_NAME}*.cs
 ```
 
+## Context Detection
+
+If unable to auto-detect:
+```javascript
+AskUserQuestion({
+  question: "Which DbContext should this migration target?",
+  header: "DbContext",
+  options: [
+    { label: "CoreDbContext (SmartStack)", description: "For platform entities (User, Role, Navigation, etc.)" },
+    { label: "ExtensionsDbContext (Client)", description: "For client-specific entities" }
+  ]
+})
+```
+
 ## 1 Migration per Feature Rule
 
 If existing migration detected:
 ```javascript
 AskUserQuestion({
   question: "Existing migration found. Recreate?",
+  header: "Migration",
   options: [
-    "Recreate (recommended)",
-    "Keep and add new",
-    "Cancel"
+    { label: "Recreate (recommended)", description: "Delete existing and create new" },
+    { label: "Keep and add new", description: "Keep existing, add separate migration" },
+    { label: "Cancel", description: "Do nothing" }
   ]
 })
 ```
@@ -70,11 +109,14 @@ AskUserQuestion({
 
 ```
 MIGRATION
+  Context: {CoreDbContext|ExtensionsDbContext}
+  Schema: {core|extensions}
   Branch: {branch}
   Version: {version}
   Name: {migration_name}
   Action: {created|recreated}
   Files: 3 (Migration + Designer + Snapshot)
+  HistoryTable: {schema}.__EFMigrationsHistory
 ```
 
 ## Conflict Management
@@ -83,3 +125,11 @@ After rebase on develop:
 1. Accept ModelSnapshot from develop
 2. Delete local migration
 3. Recreate with this command
+
+## Important Notes
+
+- **Core migrations** go to `CoreDbContextModelSnapshot.cs`
+- **Extensions migrations** go to `ExtensionsDbContextModelSnapshot.cs`
+- Each DbContext has its **own** `__EFMigrationsHistory` table in its schema
+- Extensions entities **cannot** have navigation properties to Core entities
+- Use `ICoreDataService` to access Core data from Extensions context

package/templates/agents/gitflow/cleanup.md

@@ -24,7 +24,14 @@ Audit et nettoyage des worktrees orphelins ou obsoletes.
 
 ```bash
 # OBLIGATOIRE: Executer depuis main ou develop
-CURRENT_BRANCH=$(git rev-parse --abbrev-ref HEAD)
+# Detection robuste de la branche courante (compatible worktrees)
+CURRENT_BRANCH=$(git branch --show-current 2>/dev/null)
+if [ -z "$CURRENT_BRANCH" ]; then
+  CURRENT_BRANCH=$(git symbolic-ref --short HEAD 2>/dev/null)
+fi
+if [ -z "$CURRENT_BRANCH" ]; then
+  CURRENT_BRANCH=$(git rev-parse --abbrev-ref HEAD 2>/dev/null)
+fi
 if [[ "$CURRENT_BRANCH" != "main" && "$CURRENT_BRANCH" != "develop" ]]; then
   echo "ERREUR: Cette commande doit etre executee depuis main ou develop"
   exit 1

package/templates/agents/gitflow/commit.md

@@ -1,14 +1,16 @@
 ---
 name: gitflow-commit
-description: GitFlow commit with EF Core migration validation
+description: GitFlow commit with EF Core migration validation (OPTIMISE)
 color: green
-model: sonnet
-tools: Bash, Read, Glob, Grep, Edit
+model: haiku
+tools: Bash, Read, Glob, Grep
 ---
 
-# GitFlow Commit Agent
+# GitFlow Commit Agent (OPTIMISE)
 
-Expert GitFlow et EF Core. Commit intelligent avec validation migrations .NET.
+Commit rapide avec validation migrations .NET.
+
+> **OPTIMISATION:** Model haiku (validation simple), tools reduits (pas d'Edit).
 
 ## Workflow
 

package/templates/agents/gitflow/finish.md

@@ -1,14 +1,16 @@
 ---
 name: gitflow-finish
-description: GitFlow finish - finalize branch with tag and cleanup
+description: GitFlow finish - finalize branch with tag and cleanup (OPTIMISE)
 color: magenta
 model: sonnet
-tools: Bash, Read, Glob, Grep, Edit, Write
+tools: Bash, Read, Glob, Write
 ---
 
-# GitFlow Finish Agent
+# GitFlow Finish Agent (OPTIMISE)
 
-Finalisation complete de branche GitFlow.
+Finalisation rapide de branche GitFlow.
+
+> **OPTIMISATION:** Model haiku (actions predefinies), tools reduits, workflow simplifie.
 
 ## MODE D'EXÉCUTION
 

package/templates/agents/gitflow/pr.md

@@ -21,7 +21,14 @@ Creation rapide de PR avec description auto-generee et detection automatique de
 ## Detection Cible (GitFlow Standard)
 
 ```bash
-CURRENT=$(git rev-parse --abbrev-ref HEAD)
+# Detection robuste de la branche courante (compatible worktrees)
+CURRENT=$(git branch --show-current 2>/dev/null)
+if [ -z "$CURRENT" ]; then
+  CURRENT=$(git symbolic-ref --short HEAD 2>/dev/null)
+fi
+if [ -z "$CURRENT" ]; then
+  CURRENT=$(git rev-parse --abbrev-ref HEAD 2>/dev/null)
+fi
 
 # Detection automatique selon le type de branche
 if [[ "$CURRENT" == hotfix/* ]]; then

package/templates/agents/gitflow/start.md

@@ -2,7 +2,7 @@
 name: gitflow-start
 description: GitFlow start - create feature/release/hotfix branch with worktree
 color: green
-model: haiku
+model: sonnet
 tools: Bash, Read, Glob, Write
 ---