@atlashub/smartstack-cli 1.1.0

package/templates/commands/gitflow/8-review.md

@@ -0,0 +1,176 @@
+---
+description: Phase 8 - Review Pull Request with checklist and suggestions
+agent: gitflow-review
+model: haiku
+---
+
+# Phase 8: REVIEW - Review PR avec checklist
+
+Tu es expert code review .NET/EF Core. Analyse la PR et fournis feedback structure.
+
+**Argument:** `$ARGUMENTS` = numero PR ou URL (requis)
+
+---
+
+## Chargement PR
+
+```bash
+# Recuperer infos PR
+gh pr view {number} --json title,body,files,commits,reviews,checks
+
+# Recuperer diff
+gh pr diff {number}
+```
+
+---
+
+## Checklist Review
+
+### 1. Code Quality
+
+| Check | Critere | Poids |
+|-------|---------|-------|
+| Lisibilite | Noms clairs, structure logique | HIGH |
+| DRY | Pas de duplication | MEDIUM |
+| SOLID | Principes respectes | MEDIUM |
+| Complexite | Methodes < 20 lignes, cyclomatic < 10 | LOW |
+
+### 2. Patterns .NET
+
+| Check | Validation |
+|-------|------------|
+| Async/Await | Pas de `.Result` ou `.Wait()` |
+| Dependency Injection | Pas de `new Service()` |
+| Null handling | `?.` ou `??` ou `required` |
+| Exceptions | Specifiques, pas `catch (Exception)` |
+
+### 3. EF Core (si migrations)
+
+| Check | Validation | Severite |
+|-------|------------|----------|
+| 3 fichiers | Migration + Designer + ModelSnapshot | BLOQUANT |
+| Naming | Convention `{Date}_{Description}` | WARNING |
+| Down() | Methode Down implementee | WARNING |
+| Indexes | Sur colonnes FK et filtres frequents | INFO |
+| Data loss | Pas de DropColumn sans backup | BLOQUANT |
+
+### 4. Tests
+
+| Check | Critere |
+|-------|---------|
+| Coverage | Nouveau code couvert |
+| Naming | `{Method}_Should_{Behavior}_When_{Condition}` |
+| Arrange/Act/Assert | Structure claire |
+| Mocks | Pas de dependances reelles |
+
+### 5. Security
+
+| Check | Pattern a detecter | Severite |
+|-------|-------------------|----------|
+| Secrets | `password`, `apikey`, `secret` hardcodes | BLOQUANT |
+| SQL Injection | String concat dans queries | BLOQUANT |
+| XSS | `@Html.Raw()` sans sanitization | HIGH |
+| Auth | `[AllowAnonymous]` sur endpoints sensibles | HIGH |
+
+---
+
+## Analyse automatique
+
+### Fichiers a examiner en priorite
+
+| Priorite | Type | Raison |
+|----------|------|--------|
+| 1 | `*Migration*.cs` | Impact base de donnees |
+| 2 | `*Controller*.cs` | Surface d'attaque |
+| 3 | `*Service*.cs` | Logique metier |
+| 4 | `*.razor` | UI et securite XSS |
+| 5 | Tests | Qualite couverture |
+
+### Metriques
+
+```
+METRIQUES PR
+────────────────────────────────
+Fichiers:    {count} (+{added}/-{removed})
+Commits:     {count}
+Insertions:  +{lines}
+Deletions:   -{lines}
+
+Ratio tests: {test_files}/{total_files}
+────────────────────────────────
+```
+
+---
+
+## Output Review
+
+### Format
+
+```
+CODE REVIEW - PR #{number}
+════════════════════════════════════════
+
+RESUME: {APPROVE | CHANGES_REQUESTED | COMMENT}
+
+BLOQUANTS ({count}):
+🔴 [{file}:{line}] {description}
+   Suggestion: {fix}
+
+WARNINGS ({count}):
+🟡 [{file}:{line}] {description}
+   Suggestion: {fix}
+
+SUGGESTIONS ({count}):
+🟢 [{file}:{line}] {description}
+
+POINTS POSITIFS:
+✨ {ce qui est bien fait}
+
+════════════════════════════════════════
+```
+
+### Soumission review
+
+```bash
+# Approve
+gh pr review {number} --approve --body "{comments}"
+
+# Request changes
+gh pr review {number} --request-changes --body "{comments}"
+
+# Comment only
+gh pr review {number} --comment --body "{comments}"
+```
+
+---
+
+## Resume
+
+```
+REVIEW COMPLETE
+────────────────────────────────
+PR:       #{number}
+Status:   {APPROVED|CHANGES_REQUESTED|COMMENTED}
+
+Issues:
+  Bloquants:   {count}
+  Warnings:    {count}
+  Suggestions: {count}
+
+EF Core: {OK|ISSUES|N/A}
+Tests:   {COVERED|MISSING|N/A}
+Security: {OK|ISSUES}
+────────────────────────────────
+Prochain: /gitflow:9-merge #{number}
+```
+
+---
+
+## Modes
+
+| Commande | Action |
+|----------|--------|
+| `/gitflow:8-review 123` | Review PR #123 |
+| `/gitflow:8-review --security` | Focus securite |
+| `/gitflow:8-review --ef-core` | Focus migrations |
+| `/gitflow:8-review --quick` | Checklist rapide |

package/templates/commands/gitflow/9-merge.md

@@ -0,0 +1,224 @@
+---
+description: Phase 9 - Merge Pull Request with all checks validated
+agent: gitflow-merge
+model: sonnet
+---
+
+# Phase 9: MERGE - Merge PR avec validation complete
+
+Tu es expert GitFlow. Execute le merge avec tous les checks de securite.
+
+**Argument:** `$ARGUMENTS` = numero PR (requis)
+
+---
+
+## Pre-merge checks
+
+### 1. Status PR
+
+```bash
+gh pr view {number} --json state,mergeable,mergeStateStatus,reviews,checks
+```
+
+| Check | Requis | Action si echec |
+|-------|--------|-----------------|
+| State = OPEN | OUI | "PR deja mergee ou fermee" |
+| Mergeable = true | OUI | "Resoudre conflits d'abord" |
+| MergeStateStatus = CLEAN | OUI | Attendre CI ou resoudre |
+
+### 2. Reviews
+
+| Check | Condition | Action |
+|-------|-----------|--------|
+| Min approvals | Config: `minReviewers` | Attendre reviews |
+| No changes requested | Aucun "Request changes" actif | Resoudre feedback |
+| Required reviewers | Si configure | Verifier presence |
+
+```bash
+# Verifier reviews
+gh pr view {number} --json reviews --jq '.reviews[] | select(.state=="APPROVED")'
+```
+
+### 3. CI/CD Checks
+
+```bash
+gh pr checks {number}
+```
+
+| Status | Action |
+|--------|--------|
+| Tous ✓ | Continuer |
+| En cours | Attendre |
+| Echec | BLOQUER - afficher details |
+
+### 4. Branch Protection
+
+| Rule | Verification |
+|------|--------------|
+| Up-to-date | `git rev-list --count HEAD..origin/{base}` = 0 |
+| Linear history | Si requis, rebase avant merge |
+| Signed commits | Si requis, verifier signatures |
+
+---
+
+## EF Core Pre-merge (si applicable)
+
+### Validation migrations
+
+```bash
+# Lister migrations dans la PR
+git diff origin/{base}...HEAD --name-only | grep -E "Migrations/.*\.cs$"
+```
+
+| Check | Validation | Bloquant |
+|-------|------------|----------|
+| Sync ModelSnapshot | Pas de conflit avec develop | OUI |
+| Build migrations | `dotnet ef migrations script` OK | OUI |
+| Pas de data loss | Scan DropTable/DropColumn | WARNING |
+
+### Si conflit ModelSnapshot detecte
+
+```
+⚠️ CONFLIT MODELSNAPSHOT DETECTE
+────────────────────────────────
+Le ModelSnapshot a diverge de develop.
+
+Options:
+1. Rebase + recreer migration (recommande)
+2. Merge manuel (risque)
+
+Commande recommandee:
+  git rebase origin/develop
+  dotnet ef migrations remove
+  dotnet ef migrations add {MigrationName}
+────────────────────────────────
+```
+
+---
+
+## Execution Merge
+
+### Strategie selon type
+
+| Type branche | Merge strategy | Options |
+|--------------|----------------|---------|
+| `feature/*` | Squash | `--squash` |
+| `hotfix/*` | Merge commit | `--merge` |
+| `release/*` | Merge commit | `--merge` |
+
+### Commande
+
+```bash
+# Squash (feature)
+gh pr merge {number} --squash --delete-branch
+
+# Merge commit (hotfix/release)
+gh pr merge {number} --merge --delete-branch
+```
+
+### Options supplementaires
+
+| Option | Condition | Action |
+|--------|-----------|--------|
+| `--auto` | CI en cours | Merge auto quand vert |
+| `--delete-branch` | Config autoDeleteBranch | Supprimer branche source |
+| `--admin` | Override protections | DANGEREUX - confirmation requise |
+
+---
+
+## Post-merge actions
+
+### 1. Versioning (si release/hotfix)
+
+```bash
+# Lire version actuelle
+VERSION=$(cat package.json | jq -r '.version')
+
+# Creer tag
+git tag -a "v$VERSION" -m "Release v$VERSION"
+git push origin "v$VERSION"
+```
+
+### 2. Changelog (optionnel)
+
+```bash
+# Ajouter entree CHANGELOG
+echo "## v$VERSION - $(date +%Y-%m-%d)" >> CHANGELOG.md
+gh pr view {number} --json title,body >> CHANGELOG.md
+```
+
+### 3. Notifications (si configure)
+
+| Canal | Message |
+|-------|---------|
+| Slack | "PR #{number} merged to {base}" |
+| Teams | Idem |
+| Email | Idem |
+
+### 4. Cleanup
+
+```bash
+# Supprimer branche locale
+git branch -d {branch}
+
+# Fetch et prune
+git fetch --prune
+```
+
+---
+
+## Resume
+
+```
+MERGE COMPLETE
+════════════════════════════════════════
+PR:       #{number}
+Titre:    {title}
+Base:     {base}
+Strategy: {squash|merge}
+
+Checks passes:
+  ✓ Reviews:     {count} approvals
+  ✓ CI:          All green
+  ✓ Conflicts:   None
+  ✓ EF Core:     {OK|N/A}
+
+Post-merge:
+  ✓ Branch deleted: {branch}
+  ✓ Tag created:    {tag|N/A}
+
+════════════════════════════════════════
+```
+
+---
+
+## Erreurs et recovery
+
+| Erreur | Cause | Solution |
+|--------|-------|----------|
+| "Not mergeable" | Conflits | `git rebase origin/{base}` |
+| "Checks failing" | CI rouge | Corriger et re-push |
+| "Review required" | Pas d'approval | Demander review |
+| "Branch protected" | Rules non respectees | Verifier requirements |
+
+### Rollback si probleme post-merge
+
+```bash
+# Identifier commit merge
+MERGE_COMMIT=$(git log --merges -1 --format="%H")
+
+# Revert
+git revert -m 1 $MERGE_COMMIT
+git push origin {base}
+```
+
+---
+
+## Modes
+
+| Commande | Action |
+|----------|--------|
+| `/gitflow:9-merge 123` | Merge PR #123 |
+| `/gitflow:9-merge 123 --auto` | Merge auto quand CI vert |
+| `/gitflow:9-merge 123 --dry-run` | Simulation |
+| `/gitflow:9-merge 123 --admin` | Override protections (danger) |

package/templates/commands/gitflow.md

@@ -0,0 +1,128 @@
+---
+description: GitFlow workflow with versioning and EF Core migration management
+---
+
+# GitFlow Workflow
+
+You are a GitFlow and EF Core expert. Manage branch workflow and migrations for .NET projects.
+
+**ULTRA THINK before each phase.** Display the heading: `# 1. INIT`, `# 2. STATUS`, etc.
+
+---
+
+## Overview
+
+```
+                    ┌─────────────────────────────────────────┐
+                    │           GITFLOW WORKFLOW              │
+                    └─────────────────────────────────────────┘
+
+10. START ──────────────────────────────────────────────────────┐
+     │                                                          │
+     ▼                                                          │
+feature/* ──3.COMMIT──► 13.SYNC ──► 14.REBASE ──► 7.PR ──► develop
+     │                     │            │                       │
+     │                     │            │                       │
+10. START (release) ───────┼────────────┼───────────────────────┤
+     │                     │            │                       │
+     ▼                     ▼            ▼                       │
+release/* ──3.COMMIT──► 13.SYNC ──► 7.PR(main) ──► 11.FINISH ──► main + tag
+     │                                               │
+     └───────────────── merge back ◄─────────────────┘
+                                                          │
+10. START (hotfix) ──────────────────────────────────────┤
+     │                                                    │
+     ▼                                                    │
+hotfix/* ──3.COMMIT──► 13.SYNC ──► 7.PR(main) ──► 11.FINISH ──► main + tag
+     │                                               │
+     └───────────────── merge back ◄─────────────────┘
+
+                    6. ABORT ◄── (rollback if problem)
+
+                   12. CLEANUP ◄── (audit worktrees from main/develop)
+```
+
+## Phases
+
+| # | Command | When | Action |
+|---|---------|------|--------|
+| 1 | `/gitflow:1-init` | Initial setup | Config + Branches + Versioning |
+| 2 | `/gitflow:2-status` | Before action | Complete state + remote sync |
+| 3 | `/gitflow:3-commit` | After changes | EF Core validation |
+| 4 | `/gitflow:4-plan` | Before merge | Detailed plan |
+| 5 | `/gitflow:5-exec` | Execute | Merge + Tag + Version |
+| 6 | `/gitflow:6-abort` | Problem | Rollback + cleanup worktree |
+| 7 | `/gitflow:7-pull-request` | Feature ready | Create PR + checks |
+| 8 | `/gitflow:8-review` | Review PR | Checklist + feedback |
+| 9 | `/gitflow:9-merge` | PR approved | Merge + post-actions |
+| 10 | `/gitflow:10-start` | New branch | Create feature/release/hotfix |
+| 11 | `/gitflow:11-finish` | After merge | Tag + merge back + cleanup worktree |
+| 12 | `/gitflow:12-cleanup` | Maintenance | Audit + cleanup worktrees |
+| 13 | `/gitflow:13-sync` | Desync detected | Push/Pull with remote |
+| 14 | `/gitflow:14-rebase` | Behind develop | Rebase on base branch |
+
+## Typical Workflow
+
+```bash
+# 1. Start a feature
+/gitflow:10-start feature my-feature
+
+# 2. Develop + commit
+/gitflow:3-commit
+
+# 3. Sync with remote (push/pull)
+/gitflow:13-sync
+
+# 4. Rebase on develop (if behind)
+/gitflow:14-rebase
+
+# 5. Create PR to develop
+/gitflow:7-pull-request
+
+# 6. Review and merge
+/gitflow:8-review {PR}
+/gitflow:9-merge {PR}
+
+# 7. For release: finalize (tag + merge back + auto cleanup)
+/gitflow:11-finish
+
+# 8. Maintenance: audit and cleanup (from main or develop)
+/gitflow:12-cleanup
+```
+
+## Worktree Cleanup
+
+Worktree cleanup is handled automatically and manually:
+
+| Mode | Trigger | Scope |
+|------|---------|-------|
+| **Automatic** | `/gitflow:11-finish` | Worktree of finalized branch |
+| **Automatic** | `/gitflow:6-abort --branch` | Worktree of abandoned branch |
+| **Manual** | `/gitflow:12-cleanup` | Complete audit (orphaned + stale) |
+
+**Note:** `/gitflow:12-cleanup` must be executed from `main` or `develop` only.
+
+## Versioning (.NET)
+
+**Sources (priority):** csproj → Directory.Build.props → AssemblyInfo → VERSION → git-tag
+
+**Auto-increment:**
+- feature → minor (1.2.0 → 1.3.0)
+- hotfix → patch (1.2.0 → 1.2.1)
+- release → confirmation
+
+## EF Core Rules
+
+1. **1 migration/feature** - Recreate, don't accumulate
+2. **3 required files** - Migration + Designer + ModelSnapshot
+3. **Sync before merge** - Rebase on develop
+4. **ModelSnapshot conflict** - Accept theirs + Recreate
+5. **Release** - Idempotent SQL script
+
+## Priority
+
+**Safety > Correctness > Speed**
+
+---
+
+User: $ARGUMENTS