@atelier-ui/create-workspace 0.3.15 → 0.4.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +16 -0
- package/package.json +1 -1
- package/src/generators/preset/files/storybook/angular/atl-button.stories.ts.template +2 -2
- package/src/generators/preset/files/testing/angular/atl-button.spec.ts.template +2 -2
- package/src/generators/preset/files/tools/eslint-rules/atl-button-icon-only-needs-name.js +12 -7
- package/src/generators/preset/preset.js +2 -2
package/CHANGELOG.md
CHANGED
|
@@ -1,3 +1,19 @@
|
|
|
1
|
+
## 0.4.0 (2026-10-09)
|
|
2
|
+
|
|
3
|
+
### 🚀 Features
|
|
4
|
+
|
|
5
|
+
- ⚠️ **angular:** AtlButton is a native button, button[atl-button] (ADR-0163) ([a9c3d2b5](https://github.com/DominikPieper/atelier-ui/commit/a9c3d2b5))
|
|
6
|
+
|
|
7
|
+
### ⚠️ Breaking Changes
|
|
8
|
+
|
|
9
|
+
- **angular:** AtlButton is a native button, button[atl-button] (ADR-0163) ([a9c3d2b5](https://github.com/DominikPieper/atelier-ui/commit/a9c3d2b5))
|
|
10
|
+
write <button atl-button> instead of <atl-button>.
|
|
11
|
+
|
|
12
|
+
### ❤️ Thank You
|
|
13
|
+
|
|
14
|
+
- Claude Opus 5.5
|
|
15
|
+
- Dominik Pieper @DominikPieper
|
|
16
|
+
|
|
1
17
|
## 0.3.15 (2026-10-09)
|
|
2
18
|
|
|
3
19
|
### 🚀 Features
|
package/package.json
CHANGED
|
@@ -15,7 +15,7 @@ const meta: Meta<AtlButton> = {
|
|
|
15
15
|
tags: ['autodocs'],
|
|
16
16
|
render: (args) => ({
|
|
17
17
|
props: args,
|
|
18
|
-
template: `<atl-button ${argsToTemplate(args)}>Button</
|
|
18
|
+
template: `<button atl-button ${argsToTemplate(args)}>Button</button>`,
|
|
19
19
|
}),
|
|
20
20
|
argTypes: {
|
|
21
21
|
variant: {
|
|
@@ -51,7 +51,7 @@ export const Primary: Story = {
|
|
|
51
51
|
props: { ...args, clicked: false },
|
|
52
52
|
template: `
|
|
53
53
|
<div style="display:flex;flex-direction:column;gap:0.5rem;align-items:flex-start">
|
|
54
|
-
<atl-button ${argsToTemplate(args)} (click)="clicked = true">Button</
|
|
54
|
+
<button atl-button ${argsToTemplate(args)} (click)="clicked = true">Button</button>
|
|
55
55
|
<span>{{ clicked ? 'clicked' : 'not clicked' }}</span>
|
|
56
56
|
</div>
|
|
57
57
|
`,
|
|
@@ -7,7 +7,7 @@ import { AtlButton } from '@atelier-ui/angular';
|
|
|
7
7
|
// story: a service, a directive, a form-validation rule.
|
|
8
8
|
describe('AtlButton', () => {
|
|
9
9
|
it('renders with its accessible name', async () => {
|
|
10
|
-
await render('<atl-button>Click me</
|
|
10
|
+
await render('<button atl-button>Click me</button>', {
|
|
11
11
|
imports: [AtlButton],
|
|
12
12
|
});
|
|
13
13
|
expect(
|
|
@@ -17,7 +17,7 @@ describe('AtlButton', () => {
|
|
|
17
17
|
|
|
18
18
|
it('emits a click event when clicked', async () => {
|
|
19
19
|
const onClick = vi.fn();
|
|
20
|
-
await render('<atl-button (click)="onClick()">Click me</
|
|
20
|
+
await render('<button atl-button (click)="onClick()">Click me</button>', {
|
|
21
21
|
imports: [AtlButton],
|
|
22
22
|
componentProperties: { onClick },
|
|
23
23
|
});
|
|
@@ -3,12 +3,12 @@
|
|
|
3
3
|
/**
|
|
4
4
|
* atl-button-icon-only-needs-name
|
|
5
5
|
*
|
|
6
|
-
* An `@angular-eslint/template` rule (ADR-0152). Flags
|
|
6
|
+
* An `@angular-eslint/template` rule (ADR-0152). Flags a `<button atl-button>` that has
|
|
7
7
|
* no text content and no accessible-name attribute: an icon-only button a screen
|
|
8
8
|
* reader announces as just "button".
|
|
9
9
|
*
|
|
10
|
-
* <atl-button><atl-icon name="close" /></
|
|
11
|
-
* <atl-button aria-label="Close"><atl-icon name="close" /></
|
|
10
|
+
* <button atl-button><atl-icon name="close" /></button> // flagged
|
|
11
|
+
* <button atl-button aria-label="Close"><atl-icon name="close" /></button> // ok
|
|
12
12
|
*
|
|
13
13
|
* Named by any of: `aria-label`, `[aria-label]`, `[attr.aria-label]`,
|
|
14
14
|
* `aria-labelledby` (and its bound forms). Named by content when the button holds
|
|
@@ -18,7 +18,7 @@
|
|
|
18
18
|
* `@switch`, `@defer` and `*ngIf` wrappers: `@if (x) { <atl-icon /> }` is still
|
|
19
19
|
* icon-only, while `@if (x) { text }` is not.
|
|
20
20
|
*
|
|
21
|
-
* Why the type-check cannot:
|
|
21
|
+
* Why the type-check cannot: `button[atl-button]` projects its content with
|
|
22
22
|
* `<ng-content>`, so `strictTemplates` sees an element with arbitrary children and
|
|
23
23
|
* an unconstrained attribute set. Whether those children add up to an accessible
|
|
24
24
|
* name is a fact about the rendered DOM. The component warns at runtime in dev mode
|
|
@@ -55,6 +55,11 @@ const kind = (node) => String(node.type).replace(/\$\d+$/, '');
|
|
|
55
55
|
*/
|
|
56
56
|
const attrsOf = (el) => [...(el.attributes ?? []), ...(el.inputs ?? [])];
|
|
57
57
|
|
|
58
|
+
// `button[atl-button]` — the selector of AtlButton: a native button carrying the
|
|
59
|
+
// static `atl-button` attribute.
|
|
60
|
+
const isAtlButton = (el) =>
|
|
61
|
+
(el.attributes ?? []).some((a) => a.name === 'atl-button');
|
|
62
|
+
|
|
58
63
|
const hasNameAttr = (el) => attrsOf(el).some((a) => NAME_ATTRS.has(a.name));
|
|
59
64
|
|
|
60
65
|
const hasContentBinding = (el) =>
|
|
@@ -123,18 +128,18 @@ module.exports = {
|
|
|
123
128
|
type: 'problem',
|
|
124
129
|
docs: {
|
|
125
130
|
description:
|
|
126
|
-
'<atl-button> with no text content needs aria-label or aria-labelledby',
|
|
131
|
+
'<button atl-button> with no text content needs aria-label or aria-labelledby',
|
|
127
132
|
},
|
|
128
133
|
messages: {
|
|
129
134
|
missing:
|
|
130
|
-
'<atl-button> has no text content and no accessible name. Add aria-label (or aria-labelledby), or visible text.',
|
|
135
|
+
'<button atl-button> has no text content and no accessible name. Add aria-label (or aria-labelledby), or visible text.',
|
|
131
136
|
},
|
|
132
137
|
schema: [],
|
|
133
138
|
},
|
|
134
139
|
create(context) {
|
|
135
140
|
return {
|
|
136
141
|
Element(node) {
|
|
137
|
-
if (node.name !== '
|
|
142
|
+
if (node.name !== 'button' || !isAtlButton(node)) return;
|
|
138
143
|
if (hasNameAttr(node) || hasContentBinding(node)) return;
|
|
139
144
|
const kinds = (node.children ?? [])
|
|
140
145
|
.flatMap(contributions)
|
|
@@ -718,7 +718,7 @@ function presetGenerator(tree, options) {
|
|
|
718
718
|
},
|
|
719
719
|
{
|
|
720
720
|
// How the components are USED, which \`strictTemplates\` cannot see (ADR-0152):
|
|
721
|
-
// an icon-only <atl-button> with no accessible name, and a sub-component
|
|
721
|
+
// an icon-only <button atl-button> with no accessible name, and a sub-component
|
|
722
722
|
// outside its required parent. Vendored from the parent Atelier monorepo's
|
|
723
723
|
// tools/eslint-rules/ (see the copy loop below); it reads every \`.html\`
|
|
724
724
|
// template and the inline \`@Component\` templates the processor extracts.
|
|
@@ -1329,7 +1329,7 @@ function presetGenerator(tree, options) {
|
|
|
1329
1329
|
let frameworkSection = '';
|
|
1330
1330
|
if (framework === 'angular') {
|
|
1331
1331
|
frameworkSection = `### Angular (\`@atelier-ui/angular\`)
|
|
1332
|
-
- Selectors: \`atl-button\`, \`atl-input\`, \`atl-dialog\`, …
|
|
1332
|
+
- Selectors: \`button[atl-button]\`, \`atl-input\`, \`atl-dialog\`, …
|
|
1333
1333
|
- Import: \`import { AtlButton } from '@atelier-ui/angular';\`
|
|
1334
1334
|
- Add to \`@Component({ imports: [AtlButton] })\`
|
|
1335
1335
|
- Form controls implement Signal Forms (\`FormValueControl\` / \`FormCheckboxControl\`)`;
|