@ateam-ai/mcp 0.4.93 → 0.4.94

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ateam-ai/mcp",
-  "version": "0.4.93",
+  "version": "0.4.94",
   "mcpName": "io.github.ariekogan/ateam-mcp",
   "description": "A-Team MCP Server — build, validate, and deploy multi-agent solutions from any AI environment",
   "type": "module",

package/src/tools.js

@@ -1051,9 +1051,14 @@ export const tools = [
     name: "ateam_delete_solution",
     core: true,
     description:
-      "⚠️ IRREVERSIBLE — kills Mongo state, running MCP processes, and Builder FS for the whole solution and every skill. " +
+      "⚠️ IRREVERSIBLE — THIS CLEARS THE WHOLE TENANT, not just the named solution. " +
+      "TENANT === SOLUTION, so it wipes EVERY skill and connector in the tenant's Core registry, the solution record, " +
+      "and Builder FS — INCLUDING any orphaned skill that no longer belongs to a solution. The name says 'solution'; the " +
+      "blast radius is the tenant. Read the tenant's skill list first (ateam_get_solution view:'skills' or Core's registry) " +
+      "and know what you are destroying — an orphan from an earlier solution is still in there and still goes. " +
       "REQUIRES `confirm:true` AND `confirm_solution_id` echoing the solution id you're destroying (defeats typos and hallucinated ids). " +
-      "RECOVERY: the GitHub repo is untouched; `ateam_github_pull` rebuilds the solution from `main`. Prefer that over re-deploying from memory.",
+      "RECOVERY: only what GitHub holds. `ateam_github_pull` rebuilds from `main` — anything never pushed there is GONE. " +
+      "A skill authored FS-only, or orphaned before its solution was pushed, has no copy anywhere.",
     inputSchema: {
       type: "object",
       properties: {
@@ -1067,10 +1072,17 @@ export const tools = [
         },
         confirm_solution_id: {
           type: "string",
-          description: "REQUIRED. Must exactly equal `solution_id`. This defeats typos and hallucinated ids — you can't wipe a solution you couldn't spell.",
+          description: "Required with force:true. Must exactly equal `solution_id`. This defeats typos and hallucinated ids — you can't wipe a solution you couldn't spell.",
+        },
+        force: {
+          type: "boolean",
+          description:
+            "Omit (DEFAULT) to PREVIEW: returns will_clear — every skill and connector that would be destroyed, with " +
+            "orphan_skills called out separately — and clears NOTHING. Pass true only after reading that list. The " +
+            "preview exists because a description cannot name the orphan you did not know was in the registry.",
         },
       },
-      required: ["solution_id", "confirm", "confirm_solution_id"],
+      required: ["solution_id"],
     },
   },
   {
@@ -4693,8 +4705,36 @@ export const handlers = {
       ? ` ⚠️ Skill "${skill_id}" is INVALID (${validation.error_count ?? "?"} error(s)) — see validation (non-blocking; build_and_run will refuse until fixed).`
       : "";
 
+    // A PATCH THAT DID NOT REBUILD IS NOT A SUCCESSFUL PATCH.
+    //
+    // This returned ok:true whenever the write landed, even if the redeploy
+    // failed or timed out, on the reasoning that the edit "is not lost". The
+    // edit genuinely is not lost — but ok:true is not where that belongs.
+    //
+    // Changing skill.connectors[] makes the connector-derived half of tools[]
+    // STALE, and only the redeploy rebuilds it. So a green patch with a failed
+    // redeploy hands back exactly the state this whole fix exists to prevent: a
+    // skill whose declarations say one thing and whose generated tools still
+    // say another, reported as done. The caller stops, because it was told it
+    // succeeded.
+    //
+    // ok now reflects the LIFECYCLE — update, rebuild, validate, redeploy —
+    // and `patch_persisted` carries the "nothing was lost" fact as a field,
+    // where a caller can act on it, instead of as a lie in the status.
+    const lifecycleOk = redeployResult === undefined ? true : redeployOk;
+
     return {
-      ok: true,
+      ok: lifecycleOk,
+      ...(!lifecycleOk && {
+        patch_persisted: true,
+        phase: "redeploy",
+        error:
+          `The edit was saved to ${store} but the redeploy did not complete, so the skill's ` +
+          `connector-derived tools were NOT rebuilt. Nothing is lost and nothing needs re-patching — ` +
+          `the definition is stored. Finish it with ateam_redeploy(solution_id` +
+          (skill_id ? `, skill_id: "${skill_id}"` : "") + `). Until then Builder and Core disagree ` +
+          `about this skill's tools.`,
+      }),
       solution_id,
       source: isLocal ? "local" : "github",
       ...(degradedToLocal && {
@@ -4729,7 +4769,7 @@ export const handlers = {
         ? (widget_health && !widget_health.ok
             ? `✅ Patched on ${store} + redeployed. ⚠️ ${widget_health.issues?.length || 0} widget(s) not rendering — see widget_health.`
             : `✅ Patched on ${store} + redeployed.`)
-        : `⚠️ Patched on ${store} ✅ but redeploy timed out. Run: ateam_redeploy(solution_id` + (skill_id ? `, skill_id: "${skill_id}"` : '') + ')') + validationStatus,
+        : `⚠️ Patched on ${store} ✅ but the redeploy did NOT complete, so connector-derived tools were not rebuilt — Builder and Core disagree until you run: ateam_redeploy(solution_id` + (skill_id ? `, skill_id: "${skill_id}"` : '') + ')') + validationStatus,
       _next: isLocal
         ? 'Local edit saved + redeployed. When the tenant connects a GitHub repo, the local state is pushed → GitHub (which then becomes master).'
         : 'Create a checkpoint before making more changes: ateam_github_promote(solution_id)',
@@ -5889,23 +5929,61 @@ export const handlers = {
   ateam_github_list_versions: async ({ solution_id }, sid) =>
     get(`/deploy/solutions/${solution_id}/versions/dev`, sid),
 
-  ateam_delete_solution: async ({ solution_id, confirm, confirm_solution_id }, sid) => {
+  // SHOW BEFORE YOU DESTROY.
+  //
+  // Without force:true this RETURNS THE INVENTORY — every skill and connector
+  // the clear would take — and touches nothing. Only force:true clears.
+  //
+  // A warning in a description is a claim the caller must take on trust, and it
+  // cannot mention the ORPHAN nobody knew was in the registry. The inventory is
+  // evidence: the caller reads the actual names first. On 2026-09-11 the absence
+  // of that step cost `walk-guide` — destroyed while clearing an unrelated test
+  // fixture, present in no GitHub branch, unrecoverable.
+  //
+  // confirm/confirm_solution_id still guard typos and hallucinated ids. They
+  // answer "did you mean THIS tenant"; force answers "have you read what is in
+  // it". Both are needed, and neither substitutes for the other.
+  ateam_delete_solution: async ({ solution_id, confirm, confirm_solution_id, force }, sid) => {
+    if (confirm_solution_id !== undefined && confirm_solution_id !== solution_id) {
+      return {
+        ok: false,
+        error: `⚠️ REFUSED: confirm_solution_id must exactly equal solution_id. Got confirm_solution_id="${confirm_solution_id}" but solution_id="${solution_id}". This check defeats typos and hallucinated ids — you should not be able to wipe a solution whose id you can't spell correctly.`,
+        expected: solution_id,
+        received: confirm_solution_id,
+      };
+    }
+
+    // Preview: no confirm needed to LOOK, and looking is the default.
+    if (force !== true) {
+      const preview = await del(`/deploy/solutions/${solution_id}`, sid);
+      return {
+        ...preview,
+        _next:
+          "Nothing was cleared. Read will_clear above — especially orphan_skills, which belong to no solution and " +
+          "are the ones most likely to be unrecoverable. To proceed: ateam_delete_solution(solution_id, " +
+          `confirm:true, confirm_solution_id:"${solution_id}", force:true)`,
+      };
+    }
+
     if (confirm !== true) {
       return {
         ok: false,
-        error: "⚠️ REFUSED: ateam_delete_solution requires confirm:true. This is irreversible in Core + Builder FS. GitHub source is preserved — ateam_github_pull rebuilds from `main` if you already deleted by mistake.",
-        recovery: "ateam_github_pull(solution_id, ref:'main')",
+        error:
+          "⚠️ REFUSED: force:true also requires confirm:true. THIS CLEARS THE WHOLE TENANT — TENANT === SOLUTION, so " +
+          "every skill and connector in the tenant's Core registry goes, including any ORPHAN that no longer belongs " +
+          "to a solution. Recovery reaches only as far as GitHub: anything never pushed is unrecoverable.",
+        recovery: "ateam_github_pull(solution_id, ref:'main') — restores ONLY what `main` holds",
       };
     }
     if (confirm_solution_id !== solution_id) {
       return {
         ok: false,
-        error: `⚠️ REFUSED: confirm_solution_id must exactly equal solution_id. Got confirm_solution_id="${confirm_solution_id}" but solution_id="${solution_id}". This check defeats typos and hallucinated ids — you should not be able to wipe a solution whose id you can't spell correctly.`,
+        error: `⚠️ REFUSED: force:true requires confirm_solution_id to exactly equal solution_id.`,
         expected: solution_id,
         received: confirm_solution_id,
       };
     }
-    return del(`/deploy/solutions/${solution_id}`, sid);
+    return del(`/deploy/solutions/${solution_id}?force=true`, sid);
   },
 
   ateam_delete_skill: async ({ solution_id, skill_id, confirm }, sid) => {