@ateam-ai/mcp 0.4.76 → 0.4.78

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ateam-ai/mcp",
-  "version": "0.4.76",
+  "version": "0.4.78",
   "mcpName": "io.github.ariekogan/ateam-mcp",
   "description": "A-Team MCP Server — build, validate, and deploy multi-agent solutions from any AI environment",
   "type": "module",

package/src/api.js

@@ -487,6 +487,30 @@ function formatError(method, path, status, body, baseUrl) {
     503: "A-Team API is temporarily unavailable. Try again in a minute.",
   };
 
+  // A 401 IS NOT ALWAYS AN AUTH PROBLEM, AND SAYING SO COSTS A RUN.
+  //
+  // The table below attaches "your API key may be invalid or expired — get a
+  // new key and call ateam_auth" to EVERY 401, by status code, never by cause.
+  // Core also returns 401 for `Actor "X" not found`, where the key is perfectly
+  // valid and the actor is the problem. A PROD agent believed that hint this
+  // morning, stopped, and asked the admin to paste an API key — for an error
+  // that had nothing to do with keys. An error naming the wrong remedy does not
+  // just fail; it sends someone competent in the wrong direction.
+  if (status === 401) {
+    const t = typeof body === "string"
+      ? body
+      : (() => { try { return JSON.stringify(body || ""); } catch { return ""; } })();
+    const m = /Actor\s+\\?"([^"\\]+)\\?"\s+not found|unknown actor\s+\\?"?([^"\\,}]+)/i.exec(t);
+    if (m) {
+      const who = (m[1] || m[2] || "").trim();
+      hints[401] =
+        `NOT an auth problem — your key is fine. Core does not recognise the ACTOR "${who}" in this tenant. ` +
+        `Re-authenticating will not help. Either pass a real actor id (the one ateam_conversation returned for the thread), ` +
+        `or omit the actor entirely to act as the tenant. If you never sent an actor, the session is bound to a stale one: ` +
+        `call ateam_auth again to reset the session binding.`;
+    }
+  }
+
   // A 500 THAT NAMES A MISSING CONFIGURATION IS NOT "TRY AGAIN IN A MINUTE".
   //
   // /chat answered 500 {"message":"OPENAI_API_KEY is not set"} and this table

package/src/tools.js

@@ -19,6 +19,17 @@ import {
 // (tenant + the app URL to view the change). ateam-mcp is a PUBLIC MCP used
 // from non-desktop clients too, so the location must live IN the tool result
 // — not only in a desktop plugin's SKILL.md. Read-only/global tools skip it.
+// Tools that START a run and therefore MINT the actor that ran it. Only these
+// may rebind the session's actor — see the call site for what accepting it from
+// any result cost.
+const ACTOR_MINTING_TOOLS = new Set([
+  "ateam_conversation",
+  "ateam_test_skill",
+  "ateam_solution_chat",
+  "ateam_test_pipeline",
+  "ateam_test_voice",
+]);
+
 const STAMP_WHERE_TOOLS = new Set([
   "ateam_build_and_run", "ateam_patch", "ateam_upload_connector", "ateam_redeploy",
   "ateam_create_skill", "ateam_create_connector", "ateam_create_plugin",
@@ -5347,10 +5358,78 @@ const handlers = {
       gaps.push(`solution health unavailable: ${e.message}`);
     }
 
+    // 4. SMOKE CALL — actually invoke a tool the SOLUTION depends on.
+    //
+    // Everything above is tools/list-level: `connected`, `tools > 0`, "renders",
+    // "deployed". All of it stayed green on a clinic connector that answered
+    // tools/list correctly and returned 401 on EVERY storage call, because its
+    // generated client put a PAT in the shared-secret header. The build shipped,
+    // reported healthy, and failed the first time a user touched it. The only
+    // check that could have caught it is calling something.
+    //
+    // Tool names come from the SKILLS, not the connector: the connector
+    // endpoints expose a count and a description but no name (verified live —
+    // /connectors/<id>/tools returns 7 objects that are all {description:""}),
+    // and the tools a skill declares are the ones that actually have to work.
+    // Testing those is a better question than testing an arbitrary one.
+    out.smoke = [];
+    try {
+      const wanted = new Map();   // toolName -> connectorId (first skill that declares it)
+      for (const sk of Array.isArray(out.skills) ? out.skills : []) {
+        if (!sk?.id) continue;
+        const def = await get(`/deploy/solutions/${solution_id}/skills/${sk.id}`, sid).catch(() => null);
+        for (const t of (def?.skill?.tools || def?.tools || [])) {
+          const name = typeof t === "string" ? t : t?.name;
+          if (!name || wanted.has(name)) continue;
+          const conn = (typeof t === "object" && (t?.source?.connector || t?.source?.id)) || null;
+          wanted.set(name, conn);
+        }
+      }
+
+      // READ-SHAPED ONLY. A smoke test must never book an appointment or delete a
+      // row to prove a connector is alive, so a write-shaped name is skipped and
+      // SAID to be skipped rather than quietly passed over.
+      const readish = [...wanted.keys()].filter((n) => /(^|[._])(list|get|today|available|health|status|ping|info|search)([._]|$)/i.test(n));
+      const perConnector = new Map();
+      for (const name of readish) {
+        const conn = wanted.get(name) || (Array.isArray(out.connectors) && out.connectors[0]?.id) || null;
+        if (!conn || perConnector.has(conn)) continue;
+        perConnector.set(conn, name);
+      }
+
+      for (const c of Array.isArray(out.connectors) ? out.connectors : []) {
+        // DELIBERATELY NOT GATED ON c.connected. Connectors are LAZY — one idles
+        // back to sleep between step 1 and here, and the /call endpoint wakes it
+        // on demand. Skipping a sleeping connector would make this check silently
+        // untestable exactly when it is most needed, and "asleep" is not an
+        // answer to "do its calls work?". The call itself is the verdict.
+        const pick = perConnector.get(c.id);
+        if (!pick) {
+          out.smoke.push({ connector: c.id, called: null, note: "no read-shaped tool declared by any skill — NOT smoke-tested" });
+          gaps.push(`connector '${c.id}' was not smoke-tested (no read-shaped tool declared by a skill); tools/list working does NOT prove its calls succeed`);
+          continue;
+        }
+        try {
+          const r = await post(`/deploy/solutions/${solution_id}/connectors/${c.id}/call`, { tool: pick, args: {} }, sid);
+          const failed = r?.ok === false;
+          out.smoke.push({ connector: c.id, called: pick, ok: !failed, ...(failed && { error: String(r?.error || "").slice(0, 200) }) });
+          if (failed) {
+            gaps.push(`connector '${c.id}' lists ${c.tools} tool(s) but CALLING ${pick} failed: ${String(r?.error || "").slice(0, 160)} — tools/list works and real calls do not`);
+          }
+        } catch (e) {
+          out.smoke.push({ connector: c.id, called: pick, ok: false, error: e.message.slice(0, 200) });
+          gaps.push(`connector '${c.id}' smoke call ${pick} errored: ${e.message.slice(0, 160)}`);
+        }
+      }
+    } catch (e) {
+      out.smoke = { error: e.message };
+      gaps.push(`smoke check could not run: ${e.message}`);
+    }
+
     out.gaps = gaps;
     out.ok = gaps.length === 0;
     out._status = out.ok
-      ? "✅ Verified live — connectors connected, widgets render, skills deployed."
+      ? "✅ Verified live — connectors connected AND answering real calls, widgets render, skills deployed."
       : `⚠️ ${gaps.length} gap(s): ${gaps.slice(0, 5).join("; ")}${gaps.length > 5 ? " …" : ""}`;
     return out;
   },
@@ -6061,7 +6140,19 @@ export async function handleToolCall(name, args, sessionId) {
     // it on the way out so the follow-up ateam_get_execution_logs /
     // ateam_get_metrics on that very job is not refused for not knowing who ran
     // it — the single most common dead end when debugging a run.
-    if (result && typeof result === "object" && result.actor_id) {
+    //
+    // ONLY FROM TOOLS THAT ACTUALLY MINT ONE. This used to accept `actor_id` off
+    // ANY tool's result, so a single unrelated payload carrying that field
+    // silently repointed the whole session — observed on a clean e2e where every
+    // later call 401'd with `Actor "dev" not found`, from an agent that had
+    // never sent an actor at all. A session that binds to a non-existent actor
+    // never recovers on its own, because nothing ever unbinds it.
+    //
+    // The generated-thread-key filter in api.js does not help here: it rejects
+    // test_<ts>_<rand>, and a short literal like "dev" walks straight past it.
+    // An allow-list of minting tools is the honest boundary — "who ran this job"
+    // is knowledge only the tools that START a job possess.
+    if (result && typeof result === "object" && result.actor_id && ACTOR_MINTING_TOOLS.has(name)) {
       touchSession(sessionId, { actorId: result.actor_id });
     }