npm - @ateam-ai/mcp - Versions diffs - 0.4.3 → 0.4.5 - Mend

@ateam-ai/mcp 0.4.3 → 0.4.5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (5) hide show

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@ateam-ai/mcp",
-  "version": "0.4.3",
+  "version": "0.4.5",
   "mcpName": "io.github.ariekogan/ateam-mcp",
   "description": "A-Team MCP Server — build, validate, and deploy multi-agent solutions from any AI environment",
   "type": "module",

package/src/api.js CHANGED Viewed

@@ -378,10 +378,10 @@ function formatError(method, path, status, body) {
       "Versioned connector-code changes (edit, push, promote, deploy-from-repo) need a",
       "GitHub repo, and this tenant hasn't connected one yet.",
       "",
-      "Connect it once (takes ~30s):",
-      "  1. Open Tenant Admin → GitHub (https://app.ateam-ai.com → pick your tenant → GitHub).",
-      "  2. Click \"Connect GitHub\" and approve the A-Team GitHub App.",
-      "  3. Retry this step — the repo is auto-created on the next deploy.",
+      "→ Open this guide and follow the 3 steps: https://mcp.ateam-ai.com/connect-github",
+      "",
+      "In short: Tenant Admin → GitHub → \"Connect GitHub\", approve the App, then retry.",
+      "The repo is auto-created on the next deploy.",
       "",
       "No GitHub yet? Skill/solution DEFINITION edits still work without a repo via",
       "ateam_patch(..., source:\"local\"). Only connector CODE iteration needs GitHub.",

package/src/http.js CHANGED Viewed

@@ -29,6 +29,7 @@ import {
   bindSessionBearer, getAuthOverride,
 } from "./api.js";
 import { mountOAuth } from "./oauth.js";
+import { connectGithubPage } from "./pages.js";
 // Active sessions
 const transports = {};
@@ -226,6 +227,12 @@ export function startHttpServer(port = 3100) {
     res.redirect("https://app.ateam-ai.com/builder/?show=api-key");
   });
+  // ─── Connect GitHub — user-facing guide an agent links to on
+  //     github_not_connected (see formatError in api.js). ──
+  app.get("/connect-github", (_req, res) => {
+    res.type("html").send(connectGithubPage());
+  });
   // ─── MCP POST — handle tool calls + initialize ───────────────
   // Mounted at both "/" and "/mcp" for Claude.ai compatibility
   const mcpPost = async (req, res) => {

package/src/pages.js ADDED Viewed

@@ -0,0 +1,82 @@
+/**
+ * Static help pages served by the ateam-mcp HTTP server.
+ *
+ * These are user-facing landing pages an agent can link to from a tool result
+ * (e.g. the github_not_connected guide). Self-contained HTML, no external
+ * assets — matches the dark card style of the OAuth authorize page.
+ */
+const APP_URL = process.env.ATEAM_APP_URL || "https://app.ateam-ai.com";
+function shell(title, body) {
+  return `<!DOCTYPE html>
+<html lang="en">
+<head>
+  <meta charset="utf-8">
+  <meta name="viewport" content="width=device-width, initial-scale=1">
+  <title>${title} — A-Team</title>
+  <style>
+    * { box-sizing: border-box; margin: 0; padding: 0; }
+    body {
+      font-family: system-ui, -apple-system, sans-serif;
+      background: #0a0a0a; color: #e5e5e5;
+      display: flex; align-items: center; justify-content: center;
+      min-height: 100vh; padding: 20px; line-height: 1.55;
+    }
+    .card {
+      background: #171717; border: 1px solid #262626;
+      border-radius: 14px; padding: 34px; max-width: 560px; width: 100%;
+    }
+    .logo { font-size: 22px; font-weight: 700; margin-bottom: 4px; }
+    h1 { font-size: 21px; font-weight: 650; margin: 14px 0 6px; }
+    .lead { color: #a3a3a3; font-size: 15px; margin-bottom: 22px; }
+    ol { margin: 0 0 22px; padding-left: 0; list-style: none; counter-reset: step; }
+    li { position: relative; padding: 12px 0 12px 44px; border-top: 1px solid #222; counter-increment: step; }
+    li:first-child { border-top: none; }
+    li::before {
+      content: counter(step); position: absolute; left: 0; top: 12px;
+      width: 28px; height: 28px; border-radius: 50%;
+      background: #1e3a5f; color: #93c5fd; font-weight: 700; font-size: 14px;
+      display: flex; align-items: center; justify-content: center;
+    }
+    li b { color: #fff; font-weight: 600; }
+    code { font-family: ui-monospace, SFMono-Regular, Menlo, monospace;
+      background: #0a0a0a; border: 1px solid #333; border-radius: 5px;
+      padding: 1px 6px; font-size: 13px; color: #c4b5fd; }
+    .btn {
+      display: inline-block; background: #2563eb; color: #fff;
+      padding: 11px 20px; border-radius: 9px; font-size: 15px; font-weight: 600;
+      text-decoration: none;
+    }
+    .btn:hover { background: #1d4ed8; }
+    .note { margin-top: 20px; font-size: 13px; color: #737373; }
+    .note code { color: #9ca3af; }
+    a { color: #60a5fa; }
+  </style>
+</head>
+<body><div class="card">${body}</div></body>
+</html>`;
+}
+export function connectGithubPage() {
+  return shell("Connect GitHub", `
+    <div class="logo">A-Team</div>
+    <h1>Connect GitHub to keep iterating</h1>
+    <div class="lead">
+      Editing, versioning, or promoting <b>connector code</b> needs a Git repo.
+      Connect your GitHub once — A-Team creates and manages the repo for you, and
+      every deploy is versioned from then on.
+    </div>
+    <ol>
+      <li>Open <b>Tenant Admin → GitHub</b> in the A-Team app (pick your tenant, then the GitHub tab).</li>
+      <li>Click <b>Connect GitHub</b> and approve the A-Team GitHub App for your account.</li>
+      <li>Go back to your agent and <b>retry</b> — the repo is auto-created on the next deploy.</li>
+    </ol>
+    <a class="btn" href="${APP_URL}" target="_blank" rel="noopener">Open the A-Team app →</a>
+    <div class="note">
+      Not ready for GitHub? Skill and solution <b>definition</b> edits still work
+      without a repo via <code>ateam_patch(..., source:"local")</code>. Only
+      connector <b>code</b> iteration needs GitHub.
+    </div>
+  `);
+}

package/src/tools.js CHANGED Viewed

@@ -2847,7 +2847,17 @@ const handlers = {
     // Dry-run: return diff + would-be after-state without writing to GitHub
     // or redeploying. Lets an agent preview any destructive-looking edit.
+    // would_write mirrors the EXACT persistence request the real run makes
+    // (method/endpoint/body key) so create-vs-update routing bugs surface in
+    // dry-run instead of only on the real write.
     if (dry_run) {
+      const would_write = isLocal
+        ? (target === "skill" && skill_id && isNewSkill
+            ? { method: "POST", endpoint: `/deploy/solutions/${solution_id}/skills`, body_key: "skill", creates: true }
+            : target === "skill" && skill_id
+              ? { method: "PATCH", endpoint: `/deploy/solutions/${solution_id}/skills/${encodeURIComponent(skill_id)}`, body_key: "updates" }
+              : { method: "PATCH", endpoint: `/deploy/solutions/${solution_id}`, body_key: "state_update" })
+        : { method: "POST", endpoint: `/deploy/solutions/${solution_id}/github/patch`, body_key: "content" };
       return {
         ok: true,
         dry_run: true,
@@ -2857,6 +2867,7 @@ const handlers = {
         phases,
         _diff,
         after_state: patched,
+        would_write,
         would_write_bytes: JSON.stringify(patched, null, 2).length,
         hint: "No changes applied. Remove dry_run:true to commit + redeploy.",
       };
@@ -2867,14 +2878,27 @@ const handlers = {
       const patchKeys = Object.keys(updates || {});
       const message = `Patch: ${target}${skill_id ? ` ${skill_id}` : ""} — ${patchKeys.join(", ")}`;
       if (isLocal) {
-        // Write the FULL patched object to the Builder store. Top-level keys are
-        // replaced (removals honored) — the client-side merge above already
-        // resolved _push/_delete/_update, so we send the resolved object.
-        const endpoint = (target === "skill" && skill_id)
-          ? `/deploy/solutions/${solution_id}/skills/${encodeURIComponent(skill_id)}`
-          : `/deploy/solutions/${solution_id}`;
-        await patch(endpoint, { state_update: patched }, sid, { timeoutMs: 30_000 });
-        phases.push({ phase: "local_write", status: "done" });
+        // Write the FULL patched object to the Builder store. The client-side
+        // merge above already resolved _push/_delete/_update, so we send the
+        // resolved object. THREE distinct Builder routes, each with its own
+        // body contract (mismatching them 400s):
+        //   • NEW skill    → POST /deploy/solutions/:id/skills   { skill }
+        //     (creates via the Builder, applies the full definition, and
+        //      pushes the topology skills[] entry — the PATCH route can't
+        //      create: it 404s on resolveSkillId / 400s "Updates object is
+        //      required". This was the japanese-tutor repo-less bug.)
+        //   • EXISTING skill → PATCH …/skills/:skillId           { updates }
+        //   • Solution       → PATCH /deploy/solutions/:id       { state_update }
+        if (target === "skill" && skill_id && isNewSkill) {
+          await post(`/deploy/solutions/${solution_id}/skills`, { skill: patched }, sid, { timeoutMs: 30_000 });
+          phases.push({ phase: "local_write", status: "done", created: true });
+        } else if (target === "skill" && skill_id) {
+          await patch(`/deploy/solutions/${solution_id}/skills/${encodeURIComponent(skill_id)}`, { updates: patched }, sid, { timeoutMs: 30_000 });
+          phases.push({ phase: "local_write", status: "done" });
+        } else {
+          await patch(`/deploy/solutions/${solution_id}`, { state_update: patched }, sid, { timeoutMs: 30_000 });
+          phases.push({ phase: "local_write", status: "done" });
+        }
       } else {
         await post(`/deploy/solutions/${solution_id}/github/patch`, {
           path: filePath,