@ateam-ai/mcp 0.3.35 → 0.3.37

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ateam-ai/mcp",
-  "version": "0.3.35",
+  "version": "0.3.37",
   "mcpName": "io.github.ariekogan/ateam-mcp",
   "description": "A-Team MCP Server — build, validate, and deploy multi-agent solutions from any AI environment",
   "type": "module",

package/src/api.js

@@ -384,7 +384,13 @@ function formatError(method, path, status, body) {
  */
 async function request(method, path, body, sessionId, opts = {}) {
   const timeoutMs = opts.timeoutMs || REQUEST_TIMEOUT_MS;
-  const maxRetries = opts.retries ?? 0;
+  // Default to 2 retries on transient proxy errors (502/504). Existing
+  // gate further down only retries on those status codes — real errors
+  // (4xx, 5xx other than 502/504) still fail fast on attempt 0. Bumping
+  // the default from 0 → 2 protects every wrapper call against a
+  // skill-builder mid-restart 502 (bug #6 in parallel-agent feedback)
+  // without callers having to remember to pass retries everywhere.
+  const maxRetries = opts.retries ?? 2;
   const baseUrl = getBaseUrl(sessionId);
 
   for (let attempt = 0; attempt <= maxRetries; attempt++) {

package/src/tools.js

@@ -54,6 +54,28 @@ async function pollDeployJob(jobId, sid, { label = 'deploy', maxMs = 15 * 60_000
   };
 }
 
+// ─── Dotted-field resolver ─────────────────────────────────────────
+//
+// Given an object and a dotted field name, walk down the path creating
+// missing intermediate objects, and return { parent, leaf } so the caller
+// can mutate parent[leaf] directly. Used by ateam_patch's _push / _delete /
+// _update mutators so they correctly traverse "intents.supported" instead
+// of creating a top-level key with a literal dot in its name. (That bug
+// silently corrupted skill.json with three different copies of the same
+// field — see the bug report from the parallel agent.)
+function _resolveDottedField(obj, dottedPath) {
+  const parts = dottedPath.split('.');
+  let parent = obj;
+  for (let i = 0; i < parts.length - 1; i++) {
+    const k = parts[i];
+    if (!parent[k] || typeof parent[k] !== 'object' || Array.isArray(parent[k])) {
+      parent[k] = {};
+    }
+    parent = parent[k];
+  }
+  return { parent, leaf: parts[parts.length - 1] };
+}
+
 // ─── Tool definitions ───────────────────────────────────────────────
 
 export const tools = [
@@ -1897,24 +1919,40 @@ const handlers = {
           const existing = typeof patched.role.persona === "string" ? patched.role.persona : "";
           const sep = (!existing || /\s$/.test(existing)) ? "" : "\n\n";
           patched.role.persona = existing + sep + value;
-        } else if (key.endsWith("_push") && Array.isArray(value)) {
-          // Array push: tools_push, intents_push, etc.
+        } else if (key.endsWith("_push")) {
+          // Array push: tools_push, intents.supported_push, etc.
+          // BUG FIX: previously did `patched[field] = ...` which created a
+          // top-level key with a literal dot (e.g. patched["intents.supported"])
+          // instead of pushing into patched.intents.supported. Traverse the
+          // dotted path correctly. Also enforce array-only values — was silently
+          // falling through to the dot-notation branch when given a single
+          // object, leaving a stray "<field>_push" sibling key behind.
+          if (!Array.isArray(value)) {
+            return { ok: false, phase: "patch", error: `${key} requires an array value (got ${typeof value}). Wrap the item in [] — e.g. {"${key}": [{...}]}.` };
+          }
           const field = key.replace(/_push$/, "");
-          patched[field] = [...(patched[field] || []), ...value];
-        } else if (key.endsWith("_delete") && Array.isArray(value)) {
-          // Array delete by name
+          const { parent, leaf } = _resolveDottedField(patched, field);
+          parent[leaf] = [...(Array.isArray(parent[leaf]) ? parent[leaf] : []), ...value];
+        } else if (key.endsWith("_delete")) {
+          if (!Array.isArray(value)) {
+            return { ok: false, phase: "patch", error: `${key} requires an array of names/ids (got ${typeof value}). Pass {"${key}": ["name1", "name2"]}.` };
+          }
           const field = key.replace(/_delete$/, "");
-          patched[field] = (patched[field] || []).filter(item => !value.includes(item.name || item.id || item));
-        } else if (key.endsWith("_update") && Array.isArray(value)) {
-          // Array update by name/id
+          const { parent, leaf } = _resolveDottedField(patched, field);
+          parent[leaf] = (Array.isArray(parent[leaf]) ? parent[leaf] : []).filter(item => !value.includes(item?.name || item?.id || item));
+        } else if (key.endsWith("_update")) {
+          if (!Array.isArray(value)) {
+            return { ok: false, phase: "patch", error: `${key} requires an array of update objects (got ${typeof value}). Pass {"${key}": [{name: "x", description: "..."}]}.` };
+          }
           const field = key.replace(/_update$/, "");
-          const arr = patched[field] || [];
+          const { parent, leaf } = _resolveDottedField(patched, field);
+          const arr = Array.isArray(parent[leaf]) ? parent[leaf] : [];
           for (const upd of value) {
             const idx = arr.findIndex(item => (item.name || item.id) === (upd.name || upd.id));
             if (idx >= 0) arr[idx] = { ...arr[idx], ...upd };
             else arr.push(upd);
           }
-          patched[field] = arr;
+          parent[leaf] = arr;
         } else if (key.includes(".")) {
           // Dot notation: "role.persona", "intents.thresholds.accept"
           const parts = key.split(".");