@astryxdesign/core 0.7.7-canary.fc68123 → 0.7.7

package/src/HoverCard/useHoverCard.tsx

@@ -16,11 +16,9 @@ import {
   useCallback,
   useEffect,
   useRef,
-  useState,
   type ReactNode,
   type RefCallback,
 } from 'react';
-import {createTriggerFocusGate} from '../utils/triggerFocus';
 import * as stylex from '@stylexjs/stylex';
 import {
   useLayer,
@@ -62,7 +60,7 @@ const styles = stylex.create({
 });
 
 /**
- * When focus on the trigger opens the hover card
+ * Focus trigger behavior for hover cards
  */
 export type HoverCardFocusTrigger = 'auto' | 'always' | 'never';
 
@@ -98,10 +96,9 @@ export interface HoverCardOptions {
 
   /**
    * When to trigger on focus:
-   * - `auto`: focus on the trigger itself, or within a trigger that is
-   *   focusable when focus arrives
-   * - `always`: focus on the trigger or anything inside it
-   * - `never`: never on focus (for composite widgets)
+   * - `auto`: Only if element is naturally focusable
+   * - `always`: Always attach focus listeners
+   * - `never`: Never attach focus listeners (for composite widgets)
    *
    * @default 'auto'
    */
@@ -238,6 +235,29 @@ export interface HoverCardReturn {
   hide: () => void;
 }
 
+/**
+ * Check if an element is naturally focusable
+ */
+function isFocusable(element: HTMLElement): boolean {
+  // Elements with explicit tabindex
+  if (element.hasAttribute('tabindex')) {
+    return element.tabIndex >= 0;
+  }
+
+  // Naturally focusable elements
+  const focusableTags = ['A', 'BUTTON', 'INPUT', 'SELECT', 'TEXTAREA'];
+  if (focusableTags.includes(element.tagName)) {
+    return !(element as HTMLButtonElement).disabled;
+  }
+
+  // Elements with contenteditable
+  if (element.isContentEditable) {
+    return true;
+  }
+
+  return false;
+}
+
 /**
  * Hook for hover card behavior with hover/focus triggers.
  *
@@ -406,44 +426,27 @@ export function useHoverCard(options: HoverCardOptions = {}): HoverCardReturn {
     [handleTouchPointerDown],
   );
 
-  // Under `auto`, whether focus counts is decided when it arrives, and a
-  // focus that counted still hides on blur (utils/triggerFocus.ts).
-  const [focusGate] = useState(createTriggerFocusGate);
-
-  const handleFocusIn = useCallback(
-    (e: Event) => {
-      if (!focusGate.focusIn(e, focusTrigger) || !isEnabled) {
-        return;
-      }
-      // A tap focuses the trigger it activates. Opening on that focus would
-      // reinstate exactly the behavior the touch path just decided against —
-      // and on an action trigger it covers the thing the user tapped.
-      if (isTouchInteraction()) {
-        return;
-      }
-      // Skip showing if we're in the middle of an Escape dismiss
-      if (isEscapeDismissingRef.current) {
-        isEscapeDismissingRef.current = false;
-        return;
-      }
-      clearTimeouts();
-      showLayer();
-    },
-    [
-      focusGate,
-      focusTrigger,
-      isEnabled,
-      isTouchInteraction,
-      clearTimeouts,
-      showLayer,
-    ],
-  );
+  const handleFocusIn = useCallback(() => {
+    if (!isEnabled) {
+      return;
+    }
+    // A tap focuses the trigger it activates. Opening on that focus would
+    // reinstate exactly the behavior the touch path just decided against —
+    // and on an action trigger it covers the thing the user tapped.
+    if (isTouchInteraction()) {
+      return;
+    }
+    // Skip showing if we're in the middle of an Escape dismiss
+    if (isEscapeDismissingRef.current) {
+      isEscapeDismissingRef.current = false;
+      return;
+    }
+    clearTimeouts();
+    showLayer();
+  }, [isEnabled, isTouchInteraction, clearTimeouts, showLayer]);
 
   const handleFocusOut = useCallback(
     (e: FocusEvent) => {
-      if (!focusGate.focusOut(e, focusTrigger)) {
-        return;
-      }
       // Check if focus is moving to the hover card content
       const relatedTarget = e.relatedTarget as HTMLElement | null;
       const popoverElement = document.getElementById(layerId);
@@ -455,7 +458,7 @@ export function useHoverCard(options: HoverCardOptions = {}): HoverCardReturn {
 
       scheduleHide();
     },
-    [focusGate, focusTrigger, layerId, scheduleHide],
+    [layerId, scheduleHide],
   );
 
   // Escape dismissal (WCAG 1.4.13) goes through the shared layer stack: a
@@ -555,9 +558,12 @@ export function useHoverCard(options: HoverCardOptions = {}): HoverCardReturn {
         el.addEventListener('mouseleave', handleMouseLeave);
         el.addEventListener('pointerdown', handlePointerDown);
 
-        // Focus listeners unless focus never opens the card; `auto` decides
-        // per event (utils/triggerFocus.ts).
-        if (focusTrigger !== 'never') {
+        // Attach focus listeners based on focusTrigger option
+        const shouldAttachFocus =
+          focusTrigger === 'always' ||
+          (focusTrigger === 'auto' && isFocusable(el));
+
+        if (shouldAttachFocus) {
           el.addEventListener('focusin', handleFocusIn);
           el.addEventListener('focusout', handleFocusOut as EventListener);
         }

package/src/Icon/Icon.doc.mjs

@@ -71,16 +71,15 @@ export const docs = {
   props: [
     {
       name: 'icon',
-      type: 'IconName | NamespacedIconName | ComponentType<SVGProps>',
+      type: 'IconName | ComponentType<SVGProps>',
       description:
-        'Semantic icon name or SVG component. Valid semantic names: close, chevronDown, chevronLeft, chevronRight, chevronsLeft, chevronsRight, check, success, error, warning, info, calendar, clock, externalLink, menu, moreHorizontal, search, upload, arrowUp, arrowDown, arrowsUpDown, funnel, eyeSlash, viewColumns, copy, checkDouble, wrench, stop, microphone. A namespaced key such as `richtext:bold` names a glyph that one component or library registers, and a theme can replace it by key; a namespaced key that nothing registers renders nothing. For any icon not in this list, pass an SVG component directly (e.g. import from lucide-react or @heroicons/react). Note: this prop is called `icon`, not `name`.',
+        'Semantic icon name or SVG component. Valid semantic names: close, chevronDown, chevronLeft, chevronRight, chevronsLeft, chevronsRight, check, success, error, warning, info, calendar, clock, externalLink, menu, moreHorizontal, search, upload, arrowUp, arrowDown, arrowsUpDown, funnel, eyeSlash, viewColumns, copy, checkDouble, wrench, stop, microphone. For any icon not in this list, pass an SVG component directly (e.g. import from lucide-react or @heroicons/react). Note: this prop is called `icon`, not `name`.',
       required: true,
     },
     {
       name: 'color',
       type: "'primary' | 'secondary' | 'tertiary' | 'disabled' | 'accent' | 'info' | 'success' | 'error' | 'warning' | 'inherit'",
-      description:
-        'Color variant mapped to Astryx icon color tokens. Semantic values (primary through warning) follow the role, and inherit uses the surrounding text color. On the web, Icon also accepts the palette values blue, red, green, gray, cyan, teal, yellow, orange, pink, and purple, which pick a non-semantic hue.',
+      description: 'Color variant mapped to Astryx icon color tokens.',
       default: "'inherit'",
     },
     {
@@ -108,24 +107,6 @@ export const docs = {
       description:
         "StyleX styles for customization (color, size, opacity). Folded into the icon's own stylex.props() call so it composes with the base color/size styles. Must be a stylex.create() value, not an inline style object like style={{}}.",
     },
-    {
-      name: 'className',
-      type: 'string',
-      description:
-        'Class name added to the rendered glyph, beside the astryx-icon target class.',
-    },
-    {
-      name: 'style',
-      type: 'CSSProperties',
-      description:
-        "Inline styles merged onto the rendered glyph after Icon's own size and color styles.",
-    },
-    {
-      name: 'ref',
-      type: 'Ref<SVGSVGElement>',
-      description:
-        'Ref to the rendered SVG element when icon is an icon component. A semantic or namespaced name renders inside an internal wrapper, and the ref is not attached.',
-    },
   ],
   theming: {
     targets: [{className: 'astryx-icon', visualProps: ['color', 'size']}],
@@ -226,16 +207,15 @@ export const docsZh = {
   props: [
     {
       name: 'icon',
-      type: 'IconName | NamespacedIconName | ComponentType<SVGProps>',
+      type: 'IconName | ComponentType<SVGProps>',
       description:
-        '语义图标名称或 SVG 组件。有效语义名称：close, chevronDown, chevronLeft, chevronRight, chevronsLeft, chevronsRight, check, success, error, warning, info, calendar, clock, externalLink, menu, moreHorizontal, search, upload, arrowUp, arrowDown, arrowsUpDown, funnel, eyeSlash, viewColumns, copy, checkDouble, wrench, stop, microphone。命名空间键（如 `richtext:bold`）指向某个组件或库注册的图标，主题可以按键替换它；没有注册的命名空间键不渲染任何内容。列表之外的图标请直接传入 SVG 组件。',
+        '语义图标名称或 SVG 组件。有效语义名称：close, chevronDown, chevronLeft, chevronRight, chevronsLeft, chevronsRight, check, success, error, warning, info, calendar, clock, externalLink, menu, moreHorizontal, search, upload, arrowUp, arrowDown, arrowsUpDown, funnel, eyeSlash, viewColumns, copy, checkDouble, wrench, stop, microphone。列表之外的图标请直接传入 SVG 组件。',
       required: true,
     },
     {
       name: 'color',
       type: "'primary' | 'secondary' | 'tertiary' | 'disabled' | 'accent' | 'info' | 'success' | 'error' | 'warning' | 'inherit'",
-      description:
-        '映射到 Astryx 图标颜色令牌的颜色变体。语义值（primary 到 warning）跟随角色，inherit 使用周围文字的颜色。在 Web 上，Icon 还接受调色板值 blue、red、green、gray、cyan、teal、yellow、orange、pink 和 purple，它们选择非语义色相。',
+      description: '映射到 Astryx 图标颜色令牌的颜色变体。',
       default: "'inherit'",
     },
     {
@@ -263,23 +243,6 @@ export const docsZh = {
       description:
         '用于自定义的 StyleX 样式（颜色、尺寸、不透明度）。会并入图标自身的 stylex.props() 调用，从而与基础的颜色/尺寸样式组合。必须是 stylex.create() 的值，而不是像 style={{}} 这样的内联样式对象。',
     },
-    {
-      name: 'className',
-      type: 'string',
-      description: '添加到渲染图标上的类名，与 astryx-icon 目标类名并列。',
-    },
-    {
-      name: 'style',
-      type: 'CSSProperties',
-      description:
-        '合并到渲染图标上的内联样式，位于 Icon 自身的尺寸和颜色样式之后。',
-    },
-    {
-      name: 'ref',
-      type: 'Ref<SVGSVGElement>',
-      description:
-        'icon 为图标组件时，指向渲染的 SVG 元素的 ref。语义名称或命名空间名称在内部包装元素中渲染，不会附加 ref。',
-    },
   ],
   theming: {
     targets: [{className: 'astryx-icon', visualProps: ['color', 'size']}],
@@ -427,9 +390,8 @@ export const docsDense = {
     ],
   },
   propDescriptions: {
-    icon: 'Semantic icon name or SVG component. Valid names: close, chevronDown, chevronLeft, chevronRight, chevronsLeft, chevronsRight, check, success, error, warning, info, calendar, clock, externalLink, menu, moreHorizontal, search, upload, arrowUp, arrowDown, arrowsUpDown, funnel, eyeSlash, viewColumns, copy, checkDouble, wrench, stop, microphone. A namespaced key (`richtext:bold`) names a glyph a component or library registers; an unregistered one renders nothing. For others, pass an SVG component.',
-    color:
-      'Color variant mapped to Astryx icon color tokens; inherit = surrounding text color. Web also accepts the non-semantic palette: blue, red, green, gray, cyan, teal, yellow, orange, pink, purple.',
+    icon: 'Semantic icon name or SVG component. Valid names: close, chevronDown, chevronLeft, chevronRight, chevronsLeft, chevronsRight, check, success, error, warning, info, calendar, clock, externalLink, menu, moreHorizontal, search, upload, arrowUp, arrowDown, arrowsUpDown, funnel, eyeSlash, viewColumns, copy, checkDouble, wrench, stop, microphone. For others, pass an SVG component.',
+    color: 'Color variant mapped to Astryx icon color tokens.',
     size: "xsm/sm/md/lg = 12/16/20/24px at a 16px root, scale w/ root font size; theme sets a size's glyph dimension via width + height (px or rem) on components.icon['size:sm'] etc. Explicit Icon size; otherwise nearest owning-component default, then 'md' when no contextual default exists",
     variant:
       "Requests the active theme's alternate artwork (e.g. 'filled'); names from augmentable IconVariantMap. Reaches the entry only if the active theme's iconVariants lists it (and an inherited entry's defining theme does too); else normal artwork. Ignored by a directly passed component; never in the DOM; no theming selector.",
@@ -437,8 +399,5 @@ export const docsDense = {
       'Accessible name for a meaningful, standalone icon. Sets role="img" + aria-label and drops the default aria-hidden. Omit (default) for decorative icons (stays aria-hidden). Empty string = decorative. The accessible-name/alt-text prop for icons.',
     xstyle:
       'StyleX styles (color, size, opacity) via stylex.create(); composes with the base color/size styles.',
-    className: 'Class added to the rendered glyph beside astryx-icon.',
-    style: "Inline styles merged after Icon's size and color styles.",
-    ref: 'Reaches the SVG only when icon is a component; a semantic or namespaced name renders in a wrapper and gets no ref.',
   },
 };

package/src/Icon/Icon.tsx

@@ -176,11 +176,7 @@ export interface IconProps extends Omit<
   SVGProps<SVGSVGElement>,
   'ref' | 'color'
 > {
-  /**
-   * Ref to the rendered SVG element when `icon` is an icon component. A
-   * semantic or namespaced name renders inside an internal wrapper, and the
-   * ref is not attached.
-   */
+  /** Ref forwarded to the root element */
   ref?: React.Ref<SVGSVGElement>;
   /**
    * Icon to render. Can be:
@@ -271,26 +267,22 @@ export interface IconProps extends Omit<
   xstyle?: StyleXStyles;
 }
 
-type IconA11yProps =
-  | {role: 'img'; 'aria-label': string; 'aria-hidden': undefined}
-  | {'aria-hidden': 'true'};
-
 /**
  * Derives the ARIA attributes for an icon from its `label` prop.
  *
  * - Non-empty `label` → meaningful image: `role="img"` + `aria-label`, and no
  *   `aria-hidden` (an `aria-hidden` element is removed from the accessibility
- *   tree, so its accessible name would be ignored). Icon passes
- *   `aria-hidden: undefined`. Many icon components, such as Heroicons, write
- *   `aria-hidden="true"` unless a prop replaces it.
+ *   tree, so its accessible name would be ignored).
  * - Omitted or empty `label` → decorative default: `aria-hidden="true"`.
  *
  * The result is spread BEFORE `{...props}` in both render modes so an explicit
  * `aria-hidden` / `role` / `aria-label` from the consumer always wins.
  */
-function getIconA11yProps(label: string | undefined): IconA11yProps {
+function getIconA11yProps(
+  label: string | undefined,
+): {role: 'img'; 'aria-label': string} | {'aria-hidden': 'true'} {
   return label != null && label !== ''
-    ? {role: 'img', 'aria-label': label, 'aria-hidden': undefined}
+    ? {role: 'img', 'aria-label': label}
     : {'aria-hidden': 'true'};
 }
 
@@ -400,7 +392,7 @@ function IconFromRegistry({
   color: IconColor;
   size: IconSize;
   variant: IconVariant | undefined;
-  a11yProps: IconA11yProps;
+  a11yProps: {role: 'img'; 'aria-label': string} | {'aria-hidden': 'true'};
   className?: string;
   style?: React.CSSProperties;
   xstyle?: StyleXStyles;

package/src/Layer/usePressPin.ts

@@ -6,9 +6,8 @@
  * @file usePressPin.ts
  * @input A hover layer's trigger, open state, show and hide, and its
  *   `triggerBehavior` and `touchTrigger` options
- * @output usePressPin, the press toggle that pins a hover layer open, and
- *   the app hold behind useTooltip's show() and hide(); isPressPinTrigger;
- *   stopPressPinClick; the LayerTriggerBehavior type
+ * @output usePressPin, the press toggle that pins a hover layer open;
+ *   isPressPinTrigger; stopPressPinClick; the LayerTriggerBehavior type
  * @position Core-internal: one call per hover layer, useTooltip's. It owns
  *   the layer's touch trigger, so the host makes no second touch-trigger call.
  *
@@ -104,18 +103,8 @@ export interface UsePressPinReturn {
   isHeldOpen: () => boolean;
   /** Wires the trigger element, or unwires it with `null`. */
   attach: (element: HTMLElement | null) => void;
-  /** Drops the pin and the app hold: Escape, or a hide from elsewhere. */
+  /** Drops the pin: Escape, or a hide that came from elsewhere. */
   unpin: () => void;
-  /**
-   * The app's `show()`: shows the layer and holds it open, as a pin does,
-   * until `release`, Escape, a press outside, or focus leaving the trigger
-   * and the layer. A controlled layer reports the request instead.
-   */
-  hold: () => void;
-  /** The app's `hide()`: drops the hold and hides the layer. */
-  release: () => void;
-  /** Whether the app's `show()` holds the layer open now. */
-  isAppHeld: () => boolean;
   /**
    * While pinned, focus moving onto an element outside the trigger and the
    * layer closes it. Returns whether the pin decided. The pin calls it for its
@@ -123,9 +112,8 @@ export interface UsePressPinReturn {
    */
   handleFocusLeave: (event: FocusEvent) => boolean;
   /**
-   * Whether the layer shows pinned on a wired trigger, or held by the app's
-   * `show()`. The host then announces its rendered text, unless the layer has
-   * a `label`.
+   * Whether the layer shows pinned on a wired trigger. The host then announces
+   * its rendered text, unless the layer has a `label`.
    */
   isPinShown: boolean;
   /** The layer's touch trigger (useTouchTriggerInternal), wired to the pin. */
@@ -187,19 +175,8 @@ export function usePressPin(options: UsePressPinOptions): UsePressPinReturn {
     setIsPinnedState(next);
   }, []);
 
-  // The app's show() holds the layer on any trigger, in any mode.
-  const isAppHeldRef = useRef(false);
-  const [isAppHeldState, setIsAppHeldState] = useState(false);
-  const setAppHeld = useCallback((next: boolean) => {
-    isAppHeldRef.current = next;
-    setIsAppHeldState(next);
-  }, []);
-
   // The last offered element lets a `triggerBehavior` change rewire it.
   const triggerRef = useRef<HTMLElement | null>(null);
-  // Every offered trigger, in any mode, so focus leaving ends a pin or an
-  // app hold.
-  const focusTargetRef = useRef<HTMLElement | null>(null);
   const offeredRef = useRef<HTMLElement | null>(null);
   // A primitive: re-attaching the same trigger renders nothing.
   const [offeredKind, setOfferedKind] = useState<'none' | 'other' | 'button'>(
@@ -215,13 +192,6 @@ export function usePressPin(options: UsePressPinOptions): UsePressPinReturn {
   // a pinned layer through the pin, so the pin drops with it.
   const hideFromTouch = useCallback(() => {
     const current = optionsRef.current;
-    if (isAppHeldRef.current) {
-      setAppHeld(false);
-      if (current.isOpen !== undefined) {
-        current.report(false);
-        return;
-      }
-    }
     if (current.triggerBehavior === 'toggle' && triggerRef.current != null) {
       if (current.isOpen !== undefined) {
         current.report(false);
@@ -232,7 +202,7 @@ export function usePressPin(options: UsePressPinOptions): UsePressPinReturn {
       }
     }
     current.hide();
-  }, [setPinned, setAppHeld]);
+  }, [setPinned]);
 
   const {
     isTouchPointerRef,
@@ -263,14 +233,13 @@ export function usePressPin(options: UsePressPinOptions): UsePressPinReturn {
   const close = useCallback(() => {
     const current = optionsRef.current;
     clearTapOpen();
-    setAppHeld(false);
     if (current.isOpen !== undefined) {
       current.report(false);
       return;
     }
     setPinned(false);
     current.hide();
-  }, [setPinned, setAppHeld, clearTapOpen]);
+  }, [setPinned, clearTapOpen]);
 
   const announceName = useCallback(() => {
     const current = optionsRef.current;
@@ -379,9 +348,6 @@ export function usePressPin(options: UsePressPinOptions): UsePressPinReturn {
 
   const isHeldOpen = useCallback(() => {
     const current = optionsRef.current;
-    if (isAppHeldRef.current && current.isLayerOpen) {
-      return current.isOpen !== false;
-    }
     if (current.triggerBehavior !== 'toggle' || triggerRef.current == null) {
       return false;
     }
@@ -398,7 +364,7 @@ export function usePressPin(options: UsePressPinOptions): UsePressPinReturn {
         return false;
       }
       const next = event.relatedTarget;
-      const trigger = focusTargetRef.current;
+      const trigger = triggerRef.current;
       // Focus that leaves for no element is a press's to decide. The trigger
       // can sit in another document, so the check uses its own window.
       const view = trigger?.ownerDocument.defaultView;
@@ -421,8 +387,6 @@ export function usePressPin(options: UsePressPinOptions): UsePressPinReturn {
   );
 
   const unwire = useCallback(() => {
-    focusTargetRef.current?.removeEventListener('focusout', handleFocusLeave);
-    focusTargetRef.current = null;
     const previous = triggerRef.current;
     if (previous == null) {
       return;
@@ -430,6 +394,7 @@ export function usePressPin(options: UsePressPinOptions): UsePressPinReturn {
     previous.removeEventListener('click', handlePress);
     previous.removeEventListener('keydown', handleKeyDown);
     previous.removeEventListener('keyup', handleKeyUp);
+    previous.removeEventListener('focusout', handleFocusLeave);
     const own = ownStateRef.current;
     if (own != null) {
       restoreAttribute(previous, 'aria-expanded', own.expanded);
@@ -458,14 +423,10 @@ export function usePressPin(options: UsePressPinOptions): UsePressPinReturn {
       }
       settledRef.current = {element, mode: current.triggerBehavior};
       unwire();
-      if (element == null) {
+      if (element == null || current.triggerBehavior !== 'toggle') {
         return;
       }
-      // Its own focus-leave listener, in any mode: `focusTrigger="never"`
-      // attaches none, and an app hold needs it on any trigger.
-      element.addEventListener('focusout', handleFocusLeave);
-      focusTargetRef.current = element;
-      if (current.triggerBehavior !== 'toggle' || !isPressPinTrigger(element)) {
+      if (!isPressPinTrigger(element)) {
         return;
       }
       element.addEventListener('click', handlePress);
@@ -473,6 +434,8 @@ export function usePressPin(options: UsePressPinOptions): UsePressPinReturn {
         element.addEventListener('keydown', handleKeyDown);
         element.addEventListener('keyup', handleKeyUp);
       }
+      // Its own focus-leave listener: `focusTrigger="never"` attaches none.
+      element.addEventListener('focusout', handleFocusLeave);
       ownStateRef.current = {
         expanded: element.getAttribute('aria-expanded'),
         controls: element.getAttribute('aria-controls'),
@@ -510,31 +473,7 @@ export function usePressPin(options: UsePressPinOptions): UsePressPinReturn {
     if (isPinnedRef.current) {
       setPinned(false);
     }
-    if (isAppHeldRef.current) {
-      setAppHeld(false);
-    }
-  }, [setPinned, setAppHeld]);
-
-  const hold = useCallback(() => {
-    const current = optionsRef.current;
-    if (!current.isEnabled) {
-      return;
-    }
-    setAppHeld(true);
-    armOutsideDismiss();
-    announceName();
-    if (current.isOpen !== undefined) {
-      current.report(true);
-      return;
-    }
-    current.show();
-  }, [setAppHeld, armOutsideDismiss, announceName]);
-
-  const release = useCallback(() => {
-    close();
-  }, [close]);
-
-  const isAppHeld = useCallback(() => isAppHeldRef.current, []);
+  }, [setPinned]);
 
   // Each path that hides a pinned layer drops the pin itself, so a layer that
   // does not show is never reported expanded.
@@ -551,18 +490,13 @@ export function usePressPin(options: UsePressPinOptions): UsePressPinReturn {
     writeAttribute(trigger, 'aria-controls', isLayerOpen ? layerId : null);
   });
 
-  const isPinShown =
-    (isToggleMode && isWired && isExpanded) ||
-    (isAppHeldState && isLayerOpen && isOpen !== false);
+  const isPinShown = isToggleMode && isWired && isExpanded;
 
   return {
     isToggleTrigger,
     isHeldOpen,
     attach,
     unpin,
-    hold,
-    release,
-    isAppHeld,
     handleFocusLeave,
     isPinShown,
     touch: {

package/src/Lightbox/Lightbox.tsx

@@ -55,7 +55,6 @@ import {
 } from '../i18n/useComponentTranslator';
 import english from '../i18n/generated-english/Lightbox/Lightbox.generated';
 import {isRenderable} from '../utils/isRenderable';
-import {prepareFocusReturnOnRemoval} from '../utils/focusReturn';
 
 registerEnglishFallback(english);
 /**
@@ -446,23 +445,6 @@ export function Lightbox({
     }
   }, [isOpen, hasItem]);
 
-  // A viewer that unmounts while open (rendered only while open, or removed
-  // with the rest of a view) never runs the close branch above. Focus the
-  // removal lost goes back to the opener while the opener is still on the
-  // page.
-  useEffect(() => {
-    const dialog = dialogRef.current;
-    if (dialog == null) {
-      return;
-    }
-    const returnFocusOnRemoval = prepareFocusReturnOnRemoval(dialog);
-    return () => {
-      if (dialog.open) {
-        returnFocusOnRemoval(triggerElementRef.current);
-      }
-    };
-  }, [hasItem]);
-
   const handleClose = useCallback(() => {
     onOpenChange(false);
   }, [onOpenChange]);