@astryxdesign/core 0.7.5 → 0.7.6-canary.0d71e8d

package/src/NumberInput/NumberInput.spec.md

@@ -6,8 +6,8 @@ id: component:NumberInput
 authority: current
 archive_reason: null
 superseded_by: null
-approved_by: cixzhang
-approved_at: 2026-10-26
+approved_by: imdreamrunner
+approved_at: 2026-10-29
 owners: [cixzhang]
 review_triggers: [public-api, behavior, layout, theming, accessibility]
 verified_by:
@@ -19,6 +19,7 @@ verified_by:
     packages/core/src/NumberInput/numberParser.docblock.test.ts,
     packages/core/src/NumberInput/__tests__/NumberInput.a11y.test.tsx,
     packages/core/src/NumberInput/__tests__/NumberInput.a11y.chromium.spec.ts,
+    packages/core/src/NumberInput/__tests__/NumberInput.coarse-pointer.a11y.chromium.spec.ts,
     packages/core/src/InputGroup/InputGroup.test.tsx,
   ]
 modules: []
@@ -40,15 +41,15 @@ system_specs: [spec:AST-085, spec:AST-086, spec:AST-102]
 
 ## Contract at a glance
 
-| Area                    | Contract                                                                                                                                                                                                                                                |
-| ----------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| Public contract         | None changes. NumberInput is a controlled numeric field with Field props, size, status, `min`, `max`, `step`, `isIntegerOnly`, `formatValue`, `units`, steppers, wheel stepping, clear, disabled and read-only states, and the input-family part props. |
-| Behavior                | A text-backed `spinbutton`. Typing edits a draft that commits only on blur or Enter, parsed for the locale and clamped to the range. Arrow keys, the wheel, and the steppers step on a grid and commit at once.                                         |
-| End-user impact         | People can type or paste numbers the way their locale and spreadsheets write them, and get told at once when an entry is invalid. Keyboard and screen-reader users can reach a disabled field. Read-only is not announced.                              |
-| Builder impact          | None.                                                                                                                                                                                                                                                   |
-| Compatibility/readiness | Records shipped behavior; no API, default, or DOM change. The read-only state is not exposed to assistive technology, and the clear button scales under reduced motion; both are listed under Current-state impact.                                     |
-| Review checks           | Reject an `onChange` for every keystroke, a commit of an unparsable draft, a step off the grid or past a bound, a disabled field that leaves the tab order or submits, or arrows that step during IME composition.                                      |
-| Governing rules         | `family:input-fields` FR3, FR4, FR8–FR11; `spec:AST-085` FR1–FR3, FR6; `spec:AST-086` FR3, FR4; `architecture:internationalization`; `design:reduced-motion` DR1.                                                                                       |
+| Area                    | Contract                                                                                                                                                                                                                                                         |
+| ----------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| Public contract         | NumberInput is a controlled numeric field with Field props, size, status, `min`, `max`, `step`, `isIntegerOnly`, `formatValue`, `units`, steppers, wheel stepping, clear, disabled and read-only states, and input-family part props.                            |
+| Behavior                | A text-backed `spinbutton`; a typed draft commits on blur or Enter, parsed for the locale and clamped to the range. Arrow keys, the wheel, and available non-coarse-pointer steppers step on a grid and commit at once.                                          |
+| End-user impact         | Coarse-pointer users enter numbers directly instead of using compact steppers. Keyboard stepping remains available. Invalid entries are announced; disabled fields remain reachable; read-only is not announced.                                                 |
+| Builder impact          | Public prop types and numeric callbacks remain unchanged; existing NumberInput calls need no source or configuration migration.                                                                                                                                  |
+| Compatibility/readiness | Coarse-pointer adaptation is non-breaking: numeric values, validation, direct entry, and keyboard stepping remain supported. The read-only exposure and reduced-motion clear-button gaps remain listed under Current-state impact.                               |
+| Review checks           | Reject coarse-pointer steppers, loss of non-coarse-pointer steppers when requested, per-keystroke `onChange`, an unparsable commit, an off-grid or out-of-range step, a disabled field that leaves the tab order or submits, or stepping during IME composition. |
+| Governing rules         | FR5 and AR4 own pointer-conditioned stepper availability; `family:input-fields` FR3, FR4, FR8–FR11; `spec:AST-085` FR1–FR3, FR6; `spec:AST-086` FR3, FR4; `spec:AST-017` FR1, FR3, FR7; `architecture:internationalization`; `design:reduced-motion` DR1.        |
 
 This table is a review projection; the body below is authoritative.
 
@@ -63,12 +64,16 @@ Consumer usage lives in `NumberInput.doc.mjs`.
 
 - Released default preserved: `yes`; `step={1}`, wheel stepping on, no
   steppers, no clear, `size="md"`, `statusVariant="attached"`
-- Compatibility class: records shipped behavior; no public prop, default,
-  export, or DOM change
+- Compatibility class: non-breaking presentation adaptation; public prop
+  names, types, exports, numeric values and callbacks, validation, direct entry,
+  and keyboard stepping remain unchanged under `spec:AST-017` FR3's numeric-stepper
+  presentation rule
 - Controlled/uncontrolled behavior: controlled only; `value` (`number`, `null`,
   or `undefined`) is the committed value, and NumberInput keeps only an
   uncommitted text draft of its own
-- Migration decision: none
+- Migration decision: no caller source or configuration migration; numeric
+  input functionality remains available through direct entry and keyboard
+  stepping while compact visual stepper aids adapt to pointer precision
 
 Consumer migration instructions belong in consumer docs and release notes.
 
@@ -118,7 +123,7 @@ Consumer migration instructions belong in consumer docs and release notes.
 | FR2  | Typing changes only a draft; `onChange` is not called while typing. A draft is valid when it parses for the active locale (grouping, decimal separator, digit script, and sign) and, for validity display, lies within the range and meets integer-only. An invalid draft colors the text secondary, sets `aria-invalid`, and fills a persistent assertive region with the localized invalid-number message.                                                                                                                                                                                                                                                                                                                                                                                      | `spec:AST-086` FR3; `architecture:internationalization`; current tests |
 | FR3  | On blur the draft resolves once and ends: an empty draft clears (`onChange(null)` when clearable and a value exists) or reverts; an unparsable or wrong-kind draft reverts; otherwise the number clamps to the range and commits with `onChange(number)` when it differs from `value`. Enter resolves a valid draft the same way and clears an empty draft when clearable. Enter commits nothing for an empty draft without `hasClear`, which stays in the field and is not marked invalid, or for an unparsable or wrong-kind draft, which stays in the field and stays invalid. Enter ends the draft only when its commit clamped. In a field that is not disabled, every Enter outside composition then calls `onEnter`, whatever it committed.                                                | Current tests                                                          |
 | FR4  | ArrowUp and ArrowDown without modifiers, the wheel over the focused input (when `isWheelEnabled`), and the steppers step by one grid position and commit at once. The grid starts at `min` (when it suits integer-only) or 0. From an empty field or an emptied draft, up goes to `min` or 0 and down to `max` or 0. Results round to the finer of the step's and the grid start's precision (at most 12 decimal places), clamp to the range, and never leave integer-only; a stepper that cannot move does nothing, while an arrow or wheel step that cannot move still ends the draft, committing a valid draft's number and dropping an unparsable one. A caller `onKeyDown` that prevents an arrow cancels that step. A wheel step stops the page from scrolling; otherwise the page scrolls. | Current tests                                                          |
-| FR5  | With `hasNumberSteppers`, increment and decrement buttons render at the end of the control. They are outside the tab order, are named with the localized increment and decrement phrases and the label, keep focus on the input when pressed, and expose `aria-disabled` when stepping that way cannot move or the field is disabled or read-only.                                                                                                                                                                                                                                                                                                                                                                                                                                                | `spec:AST-085` FR1, FR2; current tests                                 |
+| FR5  | With `hasNumberSteppers`, increment and decrement buttons render at the end of the control unless the primary pointer is coarse. On coarse primary pointers the buttons are hidden from layout and the accessibility tree at every viewport width, with no opt-out; the control restores its normal themed end padding. Direct numeric entry and keyboard stepping remain available. When shown, the buttons are outside the tab order, are named with the localized increment and decrement phrases and the label, keep focus on the input when pressed, and expose `aria-disabled` when stepping that way cannot move or the field is disabled or read-only.                                                                                                                                    | `spec:AST-085` FR1, FR2; current tests                                 |
 | FR6  | With `formatValue`, the input shows the formatted committed value at rest and the plain locale-formatted number while focused. The form value is then submitted from a hidden input carrying the raw number, and the visible input has no `name`; without `formatValue` the visible input carries `name`.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         | Current tests                                                          |
 | FR7  | `units` renders as secondary text after the input and is part of the input's description.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         | Current tests                                                          |
 | FR8  | With `hasClear`, a clear button shows while `value` is not `null` and the field is editable. Activating it calls `onChange(null)`, drops the draft, and focuses the input as TextInput's clear does. The clear button is a ghost small `component:Button`, so its press scale MUST NOT apply under reduced motion (`design:reduced-motion` DR1). Implementation gap: it still scales under reduced motion.                                                                                                                                                                                                                                                                                                                                                                                        | `family:input-fields` FR11; current tests                              |
@@ -168,19 +173,20 @@ Consumer migration instructions belong in consumer docs and release notes.
 - **AR2 — Invalid entry.** FR2's assertive region announces an invalid draft,
   since an invalid draft reverts silently on blur (WCAG 3.3.1).
 - **AR3 — Disabled.** FR9 satisfies `spec:AST-085` FR1, FR5, and FR6.
-- **AR4 — Steppers.** Pointer-only aids; the arrow keys give keyboard users the
-  same stepping (FR4, FR5).
+- **AR4 — Steppers.** Compact pointer-only aids are hidden on coarse primary
+  pointers at every viewport width. Direct numeric entry remains available, and
+  arrow keys provide keyboard stepping on every pointer type (FR4, FR5).
 - **AR5 — Read-only exposure.** A read-only NumberInput MUST expose its
   read-only state to assistive technology (WCAG 2.2 4.1.2). Implementation gap:
   the spinbutton exposes no read-only state.
 
 ## Design relationships
 
-| Anatomy or state | Design requirement                                        | Representation authority | Hierarchy role | Component contract |
-| ---------------- | --------------------------------------------------------- | ------------------------ | -------------- | ------------------ |
-| Input            | Numeric text; secondary color while the draft is invalid. | Current source and tests | Prominent      | FR2                |
-| Units            | Secondary text after the number.                          | Current source and tests | Supporting     | FR7                |
-| Steppers         | Stacked increment and decrement at the end.               | Current source and tests | Supporting     | FR5, FR13          |
+| Anatomy or state | Design requirement                                                                                            | Representation authority | Hierarchy role | Component contract |
+| ---------------- | ------------------------------------------------------------------------------------------------------------- | ------------------------ | -------------- | ------------------ |
+| Input            | Numeric text; secondary color while the draft is invalid.                                                     | Current source and tests | Prominent      | FR2                |
+| Units            | Secondary text after the number.                                                                              | Current source and tests | Supporting     | FR7                |
+| Steppers         | Stacked at the end on non-coarse pointers; hidden on coarse primary pointers, with normal themed end padding. | FR5; DEC-1               | Supporting     | FR5, FR13          |
 
 `design:reduced-motion` governs the clear button's press scale (FR8); no other
 design record governs NumberInput. The control box carries `number-input`;
@@ -201,19 +207,20 @@ anatomy-theming map.
 
 ## Verification map
 
-| Contract                 | Verification                                                                                                                              | Representative states                           | Mutation or failure expectation                                                                                             | Audit section                     |
-| ------------------------ | ----------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------- | --------------------------------- |
-| FR1, AR1                 | `NumberInput.test.tsx` spinbutton-attribute suite; `NumberInput.a11y.chromium.spec.ts`                                                    | Bounded, unbounded, formatted                   | A missing role or ARIA value fails.                                                                                         | `audit:NumberInput/accessibility` |
-| FR2, AR2                 | `numberParser.test.ts`; `numberParser.docblock.test.ts`; `NumberInput.test.tsx` invalid-feedback suite                                    | Locales, grouping, invalid text                 | A misparse, a commit of a guess, or a missing announcement fails.                                                           | `audit:NumberInput/behavior`      |
-| FR3, ORD1                | `numberInputCommit.test.ts`; `NumberInput.test.tsx` validation, commit-policy, clamping, keyboard-clearing suites                         | Blur, Enter, empty, clamp, inverted range       | A per-keystroke `onChange`, an unclamped commit, or a wrong clear fails.                                                    | `audit:NumberInput/behavior`      |
-| FR4, FR5, ORD2, AR4, PR1 | `NumberInput.test.tsx` stepping and steppers suites; wheel-listener cases                                                                 | Keys, wheel, steppers; bounds; empty; precision | A step off the grid, past a bound, or with modifiers fails. Evidence gap: no test steps from an emptied draft over a value. | `audit:NumberInput/behavior`      |
-| FR6, FR7                 | `NumberInput.test.tsx` formatted-display, form, and units suites                                                                          | Rest and focus; form submission                 | A formatted value submitted, or units not described, fails.                                                                 | `audit:NumberInput/behavior`      |
-| FR8                      | `NumberInput.test.tsx` hasClear suite                                                                                                     | Clear; disabled; read-only                      | A clear on a disabled field, or no `null`, fails. Evidence gap: no test presses the clear button under reduced motion.      | `audit:NumberInput/behavior`      |
-| FR9, FR10, ORD3, AR3     | `NumberInput.test.tsx` disabled, disabledMessage, read-only, and form suites; `InputGroup.test.tsx` disabled-propagation cases            | Disabled, reason, read-only                     | A lost tab stop, a submitted disabled value, or stepping while read-only fails.                                             | `audit:NumberInput/accessibility` |
-| FR12                     | `NumberInput.fr10.test.tsx`; `NumberInput.test.tsx` status and click-to-focus suites                                                      | Standalone and grouped                          | A base prop off the input, or styling on the wrong part, fails.                                                             | `audit:NumberInput/api`           |
-| FR13                     | `NumberInput.test.tsx` theme-state and stepper-padding suites                                                                             | Each padding spelling                           | Steppers that ignore the theme padding fail.                                                                                | `audit:NumberInput/theming`       |
-| AR5                      | `NumberInput.a11y.chromium.spec.ts` with its recorded known failure                                                                       | Read-only                                       | The known failure stops matching when the gap closes.                                                                       | `audit:NumberInput/accessibility` |
-| FR11                     | `NumberInput.test.tsx` "does not step or commit on a composing keydown (IME)" and "waits for IME composition to finish before committing" | Composing arrows and Enter                      | A step or commit during composition fails.                                                                                  | `audit:NumberInput/behavior`      |
+| Contract                 | Verification                                                                                                                              | Representative states                                                                  | Mutation or failure expectation                                                                                             | Audit section                     |
+| ------------------------ | ----------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------- | --------------------------------- |
+| FR1, AR1                 | `NumberInput.test.tsx` spinbutton-attribute suite; `NumberInput.a11y.chromium.spec.ts`                                                    | Bounded, unbounded, formatted                                                          | A missing role or ARIA value fails.                                                                                         | `audit:NumberInput/accessibility` |
+| FR2, AR2                 | `numberParser.test.ts`; `numberParser.docblock.test.ts`; `NumberInput.test.tsx` invalid-feedback suite                                    | Locales, grouping, invalid text                                                        | A misparse, a commit of a guess, or a missing announcement fails.                                                           | `audit:NumberInput/behavior`      |
+| FR3, ORD1                | `numberInputCommit.test.ts`; `NumberInput.test.tsx` validation, commit-policy, clamping, keyboard-clearing suites                         | Blur, Enter, empty, clamp, inverted range                                              | A per-keystroke `onChange`, an unclamped commit, or a wrong clear fails.                                                    | `audit:NumberInput/behavior`      |
+| FR4, FR5, ORD2, AR4, PR1 | `NumberInput.test.tsx` stepping and steppers suites; wheel-listener cases                                                                 | Keys, wheel, steppers; bounds; empty; precision                                        | A step off the grid, past a bound, or with modifiers fails. Evidence gap: no test steps from an emptied draft over a value. | `audit:NumberInput/behavior`      |
+| FR6, FR7                 | `NumberInput.test.tsx` formatted-display, form, and units suites                                                                          | Rest and focus; form submission                                                        | A formatted value submitted, or units not described, fails.                                                                 | `audit:NumberInput/behavior`      |
+| FR8                      | `NumberInput.test.tsx` hasClear suite                                                                                                     | Clear; disabled; read-only                                                             | A clear on a disabled field, or no `null`, fails. Evidence gap: no test presses the clear button under reduced motion.      | `audit:NumberInput/behavior`      |
+| FR9, FR10, ORD3, AR3     | `NumberInput.test.tsx` disabled, disabledMessage, read-only, and form suites; `InputGroup.test.tsx` disabled-propagation cases            | Disabled, reason, read-only                                                            | A lost tab stop, a submitted disabled value, or stepping while read-only fails.                                             | `audit:NumberInput/accessibility` |
+| FR12                     | `NumberInput.fr10.test.tsx`; `NumberInput.test.tsx` status and click-to-focus suites                                                      | Standalone and grouped                                                                 | A base prop off the input, or styling on the wrong part, fails.                                                             | `audit:NumberInput/api`           |
+| FR13                     | `NumberInput.test.tsx` theme-state and stepper-padding suites                                                                             | Each padding spelling                                                                  | Steppers that ignore the theme padding fail.                                                                                | `audit:NumberInput/theming`       |
+| AR5                      | `NumberInput.a11y.chromium.spec.ts` with its recorded known failure                                                                       | Read-only                                                                              | The known failure stops matching when the gap closes.                                                                       | `audit:NumberInput/accessibility` |
+| FR11                     | `NumberInput.test.tsx` "does not step or commit on a composing keydown (IME)" and "waits for IME composition to finish before committing" | Composing arrows and Enter                                                             | A step or commit during composition fails.                                                                                  | `audit:NumberInput/behavior`      |
+| FR5, FR13, AR4           | `NumberInput.coarse-pointer.a11y.chromium.spec.ts`                                                                                        | Coarse/non-coarse pointers at 390 and 1280 px, LTR/RTL, non-default themed end padding | Visible coarse-pointer steppers, hidden fine-pointer steppers, wrong end padding, or lost direct/keyboard entry fail.       | `audit:NumberInput/behavior`      |
 
 ## Current-state impact
 
@@ -235,8 +242,23 @@ anatomy-theming map.
 
 ## Decision log
 
-No component-local decision. NumberInput applies `family:input-fields` and
-`spec:AST-085`.
+NumberInput applies `family:input-fields` and `spec:AST-085`.
+
+### DEC-1 — Compact steppers follow primary-pointer precision
+
+**Reference:** `component:NumberInput/DEC-1`
+**Decider:** `imdreamrunner`, `2026-10-29`
+
+Coarse-primary-pointer presentation uses direct numeric entry rather than
+compact steppers, independently of viewport width and without an opt-out.
+Non-coarse-pointer steppers and keyboard stepping retain their contracts.
+The compact buttons are presentation aids: the numeric value, validation,
+callback, direct-entry, and keyboard-stepping contracts do not depend on their
+visibility. Adapting those aids requires no caller source or configuration
+migration.
+
+Rejected: width-based activation, because pointer precision governs this
+control affordance rather than the available layout width.
 
 ## Open questions
 

package/src/NumberInput/NumberInput.test.tsx

@@ -358,6 +358,67 @@ describe('NumberInput', () => {
       expect(input).toHaveAttribute('aria-valuenow', '1234');
     });
 
+    it('keeps the whole text selected when focus arrives with it selected, as Tab does', () => {
+      render(
+        <NumberInput
+          label="Amount"
+          value={1500000}
+          onChange={() => {}}
+          formatValue={number => number.toLocaleString('en-US')}
+        />,
+      );
+      const input = screen.getByRole<HTMLInputElement>('spinbutton');
+      expect(input).toHaveValue('1,500,000');
+
+      // Tab into a text field selects its text before the focus event.
+      input.focus();
+      input.setSelectionRange(0, input.value.length);
+      fireEvent.focus(input);
+
+      // The editable text replaces the formatted text, and stays selected.
+      expect(input).toHaveValue('1500000');
+      expect(input.selectionStart).toBe(0);
+      expect(input.selectionEnd).toBe('1500000'.length);
+    });
+
+    it('does not swallow keystrokes when focus swaps no text', async () => {
+      const user = userEvent.setup();
+      function Controlled() {
+        const [value, setValue] = useState<number | null>(1);
+        return <NumberInput label="Amount" value={value} onChange={setValue} />;
+      }
+      render(
+        <>
+          <button type="button">Before</button>
+          <Controlled />
+        </>,
+      );
+      const input = screen.getByRole<HTMLInputElement>('spinbutton');
+      // Tab into the field with its text selected, as a browser does. The
+      // text is the same at rest and focused, so nothing is swapped.
+      input.focus();
+      input.setSelectionRange(0, input.value.length);
+      fireEvent.focus(input);
+      await user.keyboard('75');
+      expect(input).toHaveValue('75');
+    });
+
+    it('leaves the caret where a click put it', () => {
+      render(
+        <NumberInput
+          label="Amount"
+          value={1500000}
+          onChange={() => {}}
+          formatValue={number => number.toLocaleString('en-US')}
+        />,
+      );
+      const input = screen.getByRole<HTMLInputElement>('spinbutton');
+      input.focus();
+      input.setSelectionRange(3, 3);
+      fireEvent.focus(input);
+      expect(input.selectionStart).toBe(input.selectionEnd);
+    });
+
     it('keeps ARIA value text on the committed value while an edit is pending', () => {
       function ControlledNumberInput() {
         const [controlledValue, setControlledValue] = useState(1234);
@@ -1505,7 +1566,7 @@ describe('NumberInput', () => {
           isReadOnly
         />,
       );
-      const input = screen.getByRole('spinbutton');
+      const input = screen.getByRole<HTMLInputElement>('spinbutton');
       input.focus();
       await user.keyboard('{ArrowUp}{ArrowDown}');
       expect(handleChange).not.toHaveBeenCalled();
@@ -1525,7 +1586,7 @@ describe('NumberInput', () => {
           />
         </div>,
       );
-      const input = screen.getByRole('spinbutton');
+      const input = screen.getByRole<HTMLInputElement>('spinbutton');
       input.focus();
       const event = new WheelEvent('wheel', {
         bubbles: true,
@@ -2174,7 +2235,7 @@ describe('NumberInput stepping', () => {
         <NumberInput label="Amount" value={5} onChange={onChange} />
       </div>,
     );
-    const input = screen.getByRole('spinbutton');
+    const input = screen.getByRole<HTMLInputElement>('spinbutton');
     input.focus();
     const event = new WheelEvent('wheel', {
       bubbles: true,
@@ -2201,7 +2262,7 @@ describe('NumberInput stepping', () => {
         />
       </div>,
     );
-    const input = screen.getByRole('spinbutton');
+    const input = screen.getByRole<HTMLInputElement>('spinbutton');
     input.focus();
     const event = new WheelEvent('wheel', {
       bubbles: true,
@@ -2228,7 +2289,7 @@ describe('NumberInput stepping', () => {
         />
       </div>,
     );
-    const input = screen.getByRole('spinbutton');
+    const input = screen.getByRole<HTMLInputElement>('spinbutton');
     input.focus();
 
     rerender(
@@ -2290,7 +2351,7 @@ describe('NumberInput stepping', () => {
         <NumberInput label="Amount" value={5} onChange={onChange} />
       </div>,
     );
-    const input = screen.getByRole('spinbutton');
+    const input = screen.getByRole<HTMLInputElement>('spinbutton');
     input.focus();
     fireEvent.wheel(input, {deltaY: -100, ctrlKey: true});
 
@@ -2312,7 +2373,7 @@ describe('NumberInput stepping', () => {
         />
       </div>,
     );
-    const input = screen.getByRole('spinbutton');
+    const input = screen.getByRole<HTMLInputElement>('spinbutton');
     input.focus();
     fireEvent.wheel(input, {deltaY: -100});
 

package/src/NumberInput/NumberInput.tsx

@@ -5,7 +5,7 @@
 /**
  * @file NumberInput.tsx
  * @input Uses React, useId, useState, useMemo, useCallback, Field, Icon, InputGroupContext
- * @output Exports NumberInput component, NumberInputProps
+ * @output Exports NumberInput component, NumberInputProps; optional steppers are hidden on coarse pointers
  * @position Core implementation; consumed by index.ts, tested by NumberInput.test.tsx
  *
  * SYNC: When modified, update these files to stay in sync:
@@ -24,6 +24,7 @@ import {
   useState,
   useMemo,
   useCallback,
+  useLayoutEffect,
   useRef,
   type FocusEvent,
   type KeyboardEvent,
@@ -100,7 +101,10 @@ const styles = stylex.create({
     paddingInlineEnd: padInlineEnd,
   },
   wrapperWithNumberSteppers: {
-    paddingInlineEnd: 0,
+    paddingInlineEnd: {
+      default: 0,
+      '@media (pointer: coarse)': padInlineEnd,
+    },
   },
   input: {
     display: 'block',
@@ -142,7 +146,12 @@ const styles = stylex.create({
   },
   numberSteppers: {
     alignSelf: 'stretch',
-    display: 'flex',
+    // These compact buttons are a fine-pointer affordance. Touch users can
+    // enter a value directly; keyboard stepping remains available.
+    display: {
+      default: 'flex',
+      '@media (pointer: coarse)': 'none',
+    },
     flexDirection: 'column',
     flexShrink: 0,
     width: spacingVars['--spacing-4'],
@@ -385,6 +394,8 @@ interface NumberInputPropsBase extends Omit<
   isWheelEnabled?: boolean;
   /**
    * Whether to show increment and decrement buttons at the end of the input.
+   * The buttons are hidden on coarse pointers (such as touch screens).
+   * Direct text entry and keyboard stepping remain available.
    * @default false
    */
   hasNumberSteppers?: boolean;
@@ -708,14 +719,43 @@ export function NumberInput({
   );
 
   // Handle focus
+  // Tab into the field selects its text so typing replaces it. With
+  // `formatValue` the text at rest differs from the editable text, and putting
+  // the editable text in the input after focus collapses that selection to the
+  // end, so typing would append. When focus arrives with the text selected,
+  // select the swapped-in text too.
+  const reselectOnFocusRef = useRef(false);
+
   const handleFocus = useCallback(
     (e: FocusEvent<HTMLInputElement>) => {
+      const input = e.currentTarget;
+      // Only when focusing swaps the text: otherwise no render follows to
+      // consume the flag, and the first keystroke would.
+      const editableText =
+        pendingInput ??
+        (value == null ? '' : formatEditableNumber(value, locale));
+      reselectOnFocusRef.current =
+        input.value.length > 0 &&
+        input.value !== editableText &&
+        input.selectionStart === 0 &&
+        input.selectionEnd === input.value.length;
       setIsFocused(true);
       onFocus?.(e);
     },
-    [onFocus],
+    [onFocus, pendingInput, value, locale],
   );
 
+  useLayoutEffect(() => {
+    if (!reselectOnFocusRef.current) {
+      return;
+    }
+    reselectOnFocusRef.current = false;
+    const input = inputRef.current;
+    if (input != null && input === document.activeElement) {
+      input.setSelectionRange(0, input.value.length);
+    }
+  }, [displayValue]);
+
   const commitPendingInput = useCallback(
     (trigger: 'blur' | 'Enter') => {
       if (pendingInput === null) {

package/src/NumberInput/__tests__/NumberInput.coarse-pointer.a11y.chromium.spec.ts

@@ -0,0 +1,102 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+
+/** Real-browser proof of NumberInput's coarse-pointer stepper presentation. */
+
+import {expect, test} from '@playwright/test';
+import {holdMotionStill} from '@astryxdesign/a11y-spec/chromium';
+import {
+  DEFAULT_STORYBOOK_DIR,
+  serveStorybook,
+  type StaticServer,
+} from '@astryxdesign/a11y-spec/storybook';
+
+let storybook: StaticServer;
+
+test.beforeAll(async () => {
+  storybook = await serveStorybook(
+    process.env.ASTRYX_STORYBOOK_DIR ?? DEFAULT_STORYBOOK_DIR,
+  );
+});
+
+test.afterAll(async () => storybook?.close());
+
+for (const width of [390, 1280]) {
+  for (const hasTouch of [false, true]) {
+    test(`${hasTouch ? 'coarse' : 'fine'} pointer at ${width}px preserves entry and the appropriate end padding`, async ({
+      browser,
+    }) => {
+      const context = await browser.newContext({
+        viewport: {width, height: 800},
+        hasTouch,
+      });
+      try {
+        const page = await context.newPage();
+        await page.goto(
+          `${storybook.origin}/iframe.html?id=core-numberinput--with-number-steppers&viewMode=story`,
+        );
+        await holdMotionStill(page);
+        const input = page.getByRole('spinbutton', {name: 'Quantity'});
+        const increment = page.locator(
+          'button[aria-label="Increment Quantity"]',
+        );
+        const decrement = page.locator(
+          'button[aria-label="Decrement Quantity"]',
+        );
+        const control = page.locator('.astryx-number-input');
+        await expect(input).toBeVisible();
+        expect(
+          await page.evaluate(() => matchMedia('(pointer: coarse)').matches),
+        ).toBe(hasTouch);
+
+        // Public padding tokens still apply when the compact stepper lane is
+        // hidden. Use a non-default value to catch a hardcoded restoration.
+        await control.evaluate(element => {
+          element.style.setProperty(
+            '--astryx-number-input-padding-inline-end',
+            '20px',
+          );
+        });
+        for (const direction of ['ltr', 'rtl']) {
+          await control.evaluate((element, dir) => {
+            element.setAttribute('dir', dir);
+          }, direction);
+          await expect(control).toHaveCSS('direction', direction);
+          await expect(control).toHaveCSS(
+            'padding-inline-end',
+            hasTouch ? '20px' : '0px',
+          );
+          if (hasTouch) {
+            await expect(increment).toBeHidden();
+            await expect(decrement).toBeHidden();
+            await expect(
+              page.getByRole('button', {
+                name: /^(Increment|Decrement) Quantity$/,
+              }),
+            ).toHaveCount(0);
+          } else {
+            await expect(increment).toBeVisible();
+            await expect(decrement).toBeVisible();
+          }
+        }
+
+        if (!hasTouch) {
+          await increment.click();
+          await expect(input).toHaveValue('3');
+          await decrement.click();
+          await expect(input).toHaveValue('2');
+        }
+        await input.focus();
+        await input.press('ArrowUp');
+        await expect(input).toHaveValue('3');
+        await input.press('ArrowDown');
+        await expect(input).toHaveValue('2');
+        await input.fill('7');
+        await input.press('Enter');
+        await expect(input).toHaveAttribute('aria-valuenow', '7');
+        await expect(input).toHaveAttribute('inputmode', 'decimal');
+      } finally {
+        await context.close();
+      }
+    });
+  }
+}

package/src/NumberInput/numberParser.ts

@@ -29,6 +29,9 @@
  * read off the input: SEPARATOR_CHARS below is a bounded alphabet, the same
  * shape utils/dateParser.ts uses for its `[-/.]` date separators.
  *
+ * Digit-script folding is shared with utils/timeFormat.ts through
+ * utils/unicodeDigits.ts.
+ *
  * SYNC: When modified, update these files to stay in sync:
  * - /packages/core/src/NumberInput/NumberInput.tsx
  * - /packages/core/src/NumberInput/numberParser.test.ts
@@ -36,6 +39,7 @@
  */
 
 import type {Locale} from '../i18n';
+import {INVISIBLE_CHARS, toAsciiDigits} from '../utils/unicodeDigits';
 
 interface LocaleNumberSymbols {
   group: string;
@@ -80,15 +84,9 @@ function getLocaleNumberSymbols(locale: Locale | undefined) {
   return symbols;
 }
 
-// Built at runtime rather than written as literals: Babel's
-// transform-unicode-property-regex rewrites a `\p{...}` regex LITERAL into an
-// enumerated character class, and the copy bundled with Next rejects the
-// General_Category short names, failing the sandbox build. Property escapes are
-// ES2018 and need no transform in any browser this package supports.
-const DECIMAL_DIGIT = new RegExp('\\p{Nd}', 'u');
+// Built at runtime rather than written as a literal: see
+// utils/unicodeDigits.ts (Babel's property-escape transform).
 const CURRENCY = new RegExp('\\p{Sc}', 'u');
-// Zero-width joiners, bidi isolates and the BOM Excel prepends.
-const INVISIBLES = /[\u200B-\u200D\u200E\u200F\u061C\u2066-\u2069\uFEFF]/g;
 // Hyphen last: inside the character class this builds, a leading one would
 // open a range.
 const MINUS_SIGNS = '\u2212\u2012\u2013-';
@@ -111,42 +109,6 @@ const NUMBER_BODY = new RegExp(`^[0-9${SEPARATOR_CHARS}]+$`);
 /** No grouping and at most one full stop: the format `Number()` reads. */
 const MACHINE_NUMBER = /^(?:\d+\.?\d*|\.\d+)$/;
 
-/**
- * Value of any Unicode decimal digit. Each digit script lays its ten digits
- * out consecutively, so walking back to the script's zero derives the value
- * for Arabic-Indic, Devanagari, full-width and the rest without shipping a
- * table of them. Returns null in the one shape the walk cannot resolve: two
- * digit blocks adjacent in code space (the mathematical alphanumerics).
- */
-function digitValue(char: string): number | null {
-  const codePoint = char.codePointAt(0);
-  if (codePoint == null) {
-    return null;
-  }
-  for (let zero = codePoint; codePoint - zero < 10; zero--) {
-    if (!DECIMAL_DIGIT.test(String.fromCodePoint(zero - 1))) {
-      return codePoint - zero;
-    }
-  }
-  return null;
-}
-
-function toAsciiDigits(text: string): string | null {
-  let out = '';
-  for (const char of text) {
-    if (!DECIMAL_DIGIT.test(char)) {
-      out += char;
-      continue;
-    }
-    const value = digitValue(char);
-    if (value == null) {
-      return null;
-    }
-    out += String(value);
-  }
-  return out;
-}
-
 /**
  * Reduce a digits-and-separators string to a plain machine number under one
  * candidate reading, or null when it is not well formed under that reading.
@@ -302,7 +264,7 @@ export function parseLocaleNumber(
   locale?: Locale,
 ): number | null {
   const normalized = toAsciiDigits(
-    text.normalize('NFKC').replace(INVISIBLES, ''),
+    text.normalize('NFKC').replace(INVISIBLE_CHARS, ''),
   );
   if (normalized == null) {
     return null;