@astryxdesign/core 0.7.1-canary.ff40b78 → 0.7.1

package/src/Dialog/Dialog.test.tsx

@@ -9,7 +9,7 @@
  * SYNC: When Dialog.tsx changes, update tests to match new behavior
  */
 
-import {useState} from 'react';
+import {useState, type SyntheticEvent} from 'react';
 import {readFileSync} from 'node:fs';
 import {describe, it, expect, vi, beforeEach, afterEach} from 'vitest';
 import type {MockInstance} from 'vitest';
@@ -1030,6 +1030,32 @@ describe('Dialog', () => {
     expect(screen.getByTestId('custom-dialog')).toBeInTheDocument();
   });
 
+  it('runs backdrop dismissal before a consumer onClick', () => {
+    const callOrder: string[] = [];
+    const onClick = vi.fn((event: SyntheticEvent) => {
+      event.preventDefault();
+      callOrder.push('consumer');
+    });
+    const onOpenChange = vi.fn(() => {
+      callOrder.push('dialog');
+    });
+    render(
+      <Dialog
+        isOpen={true}
+        onOpenChange={onOpenChange}
+        onClick={onClick}
+        data-testid="click-dialog">
+        Content
+      </Dialog>,
+    );
+
+    fireEvent.click(screen.getByTestId('click-dialog'));
+
+    expect(onClick).toHaveBeenCalledTimes(1);
+    expect(onOpenChange).toHaveBeenCalledWith(false);
+    expect(callOrder).toEqual(['dialog', 'consumer']);
+  });
+
   it('does not forward native open prop to dialog element', () => {
     render(
       <Dialog

package/src/Dialog/Dialog.tsx

@@ -5,7 +5,7 @@
 /**
  * @file Dialog.tsx
  * @input Uses React, DialogHTMLAttributes, ReactNode, container (Layout), DialogContext, layerTextReset,
- *   layerStructureReset, modalOutlet, interactionModality
+ *   layerStructureReset, modalOutlet, interactionModality, chainEventHandlers
  * @output Exports Dialog component, DialogProps, DialogVariant, DialogPurpose types
  * @position Core implementation; consumed by index.ts, tested by Dialog.test.tsx
  *
@@ -65,6 +65,7 @@ import {
 } from '../Layout/padding.stylex';
 import type {SpacingStep} from '../utils/types';
 import {mergeProps} from '../utils';
+import {chainEventHandlers} from '../utils/chainEventHandlers';
 import {devWarn} from '../utils/devWarning';
 import {DialogContext} from './DialogContext';
 import {themeProps} from '../utils/themeProps';
@@ -679,9 +680,19 @@ export function Dialog({
     </div>
   );
 
-  // Filter out native open to prevent InvalidStateError when accidentally passed
+  // Filter out native open to prevent InvalidStateError when accidentally passed.
+  // Keep the consumer click handler separate so the modal path can compose it
+  // with Dialog-owned behavior without changing the inline preview path.
   const hasPosition = position != null && !isFullscreen;
-  const {open: _open, ...safeProps} = props as Record<string, unknown>;
+  const {onClick: onClickProp, ...propsWithoutClick} = props;
+  const {open: _open, ...safeProps} = propsWithoutClick as Record<
+    string,
+    unknown
+  >;
+  const inlineSafeProps: Record<string, unknown> = {
+    ...safeProps,
+    onClick: onClickProp,
+  };
 
   // --- Inline rendering path (for documentation previews) ---
   if (isInline) {
@@ -691,7 +702,7 @@ export function Dialog({
 
     return (
       <div
-        {...safeProps}
+        {...inlineSafeProps}
         {...mergeProps(
           themeProps('dialog', {variant}),
           stylex.props(
@@ -760,7 +771,7 @@ export function Dialog({
         className,
         style,
       )}
-      onClick={handleClick}
+      onClick={chainEventHandlers(handleClick, onClickProp)}
       onCancel={handleCancel}
       aria-modal="true"
       // The default aria-labelledby (from a DialogHeader title) is set

package/src/Dialog/DialogHeader.test.tsx

@@ -260,6 +260,19 @@ describe('DialogHeader', () => {
     expect(closeIcon).toHaveClass('astryx-icon');
   });
 
+  it('renders numeric zero in both content slots', () => {
+    const {container} = render(
+      <DialogHeader title="Title" startContent={0} endContent={0} />,
+    );
+
+    expect(
+      container.querySelector('.astryx-dialog-header-start-content'),
+    ).toHaveTextContent(/^0$/);
+    expect(
+      container.querySelector('.astryx-dialog-header-end-content'),
+    ).toHaveTextContent(/^0$/);
+  });
+
   it('exposes the start-content target when startContent renders', () => {
     const {container} = render(
       <DialogHeader
@@ -292,8 +305,20 @@ describe('DialogHeader', () => {
     ).toHaveLength(1);
   });
 
-  it('omits the content-slot targets when their content does not render', () => {
-    const {container} = render(<DialogHeader title="Title" />);
+  it.each([
+    ['empty string', ''],
+    ['false', false],
+    ['true', true],
+    ['null', null],
+    ['undefined', undefined],
+  ])('omits both content-slot targets for %s', (_, content) => {
+    const {container} = render(
+      <DialogHeader
+        title="Title"
+        startContent={content}
+        endContent={content}
+      />,
+    );
 
     expect(
       container.querySelector('.astryx-dialog-header-start-content'),

package/src/Dialog/DialogHeader.tsx

@@ -4,7 +4,7 @@
 
 /**
  * @file DialogHeader.tsx
- * @input Uses React, StyleX, LayoutHeader, Button, Icon, Heading, Text, DialogContext, mergeProps, themeProps
+ * @input Uses React, StyleX, LayoutHeader, Button, Icon, Heading, Text, DialogContext, isRenderable, mergeProps, themeProps
  * @output Exports DialogHeader component and DialogHeaderProps
  * @position Dialog header component; used with Dialog and Layout
  *
@@ -25,7 +25,7 @@ import {Icon} from '../Icon';
 import {Heading} from '../Heading/Heading';
 import {Text} from '../Text/Text';
 import type {BaseProps} from '../BaseProps';
-import {mergeProps} from '../utils';
+import {isRenderable, mergeProps} from '../utils';
 import {themeProps} from '../utils/themeProps';
 import {useDialogContext} from './DialogContext';
 import {useTranslator} from '../i18n';
@@ -164,10 +164,9 @@ export function DialogHeader({
   const dialogContext = useDialogContext();
   const shouldAutoFocus = dialogContext?.isInline !== true;
   const titleId = dialogContext?.titleId;
-  // A node subtitle may be `0`: render it inside Text instead of letting a
-  // truthiness check leak a bare text node, and skip only empty values.
-  const hasSubtitle =
-    subtitle != null && typeof subtitle !== 'boolean' && subtitle !== '';
+  const hasSubtitle = isRenderable(subtitle);
+  const hasStartContent = isRenderable(startContent);
+  const hasEndContent = isRenderable(endContent);
   const shouldCompensateEndBlock =
     endContentEdgeCompensation == null
       ? onOpenChange != null
@@ -203,7 +202,7 @@ export function DialogHeader({
           themeProps('dialog-header'),
           stylex.props(styles.container),
         )}>
-        {startContent && (
+        {hasStartContent && (
           <div
             {...mergeProps(
               themeProps('dialog-header-start-content'),
@@ -231,7 +230,7 @@ export function DialogHeader({
             </Text>
           )}
         </div>
-        {(endContent || onOpenChange) && (
+        {(hasEndContent || onOpenChange != null) && (
           <div
             {...mergeProps(
               themeProps('dialog-header-end-content'),

package/src/Dialog/__tests__/Dialog.a11y.chromium.spec.ts

@@ -180,25 +180,17 @@ async function runState(
   });
 }
 
-test('every expectation is exercised and every known failure matches once', async ({
-  page,
-}) => {
-  test.setTimeout(5 * 60 * 1000);
-  const cdp = await page.context().newCDPSession(page);
-  const results: BindingResult[] = [];
-  for (const state of DIALOG_MODAL_BINDING_STATES) {
-    results.push(await runState(page, cdp, state));
-  }
-  expect(neverExercised(results)).toEqual([]);
-  expect(unmatchedKnownFailures(DIALOG_MODAL_KNOWN_FAILURES, results)).toEqual(
-    [],
-  );
-});
+// Each state's result, recorded by its own test below so the whole-suite check
+// at the end reads it instead of measuring every state a second time. A state
+// whose test did not run in this worker (a filtered run, or a worker restarted
+// after a failure) is measured by the whole-suite check itself.
+const recorded = new Map<string, BindingResult>();
 
 for (const state of DIALOG_MODAL_BINDING_STATES) {
   test(`Dialog [${state.id}] — ${state.summary}`, async ({page}) => {
     const cdp = await page.context().newCDPSession(page);
     const result = await runState(page, cdp, state);
+    recorded.set(state.id, result);
     const report = summarize(MODAL_DIALOG_PATTERN, [result]);
     // eslint-disable-next-line no-console -- the report is this run's artifact
     console.log(formatReport(report));
@@ -208,3 +200,18 @@ for (const state of DIALOG_MODAL_BINDING_STATES) {
     expect(report.counts.unexpectedPass).toBe(0);
   });
 }
+
+test('every expectation is exercised and every known failure matches once', async ({
+  page,
+}) => {
+  test.setTimeout(5 * 60 * 1000);
+  const cdp = await page.context().newCDPSession(page);
+  const results: BindingResult[] = [];
+  for (const state of DIALOG_MODAL_BINDING_STATES) {
+    results.push(recorded.get(state.id) ?? (await runState(page, cdp, state)));
+  }
+  expect(neverExercised(results)).toEqual([]);
+  expect(unmatchedKnownFailures(DIALOG_MODAL_KNOWN_FAILURES, results)).toEqual(
+    [],
+  );
+});

package/src/Divider/Divider.doc.mjs

@@ -40,7 +40,8 @@ export const docs = {
     {
       name: 'label',
       type: 'ReactNode',
-      description: 'Optional label centered on the divider.',
+      description:
+        'Optional label centered on the divider. Numeric zero is preserved; null, booleans, and empty strings render no label.',
     },
     {
       name: 'variant',
@@ -92,7 +93,8 @@ export const docsZh = {
     {
       name: 'label',
       type: 'ReactNode',
-      description: '居中显示在分隔线上的可选标签。',
+      description:
+        '居中显示在分隔线上的可选标签。数字 0 会保留；null、布尔值和空字符串不渲染标签。',
     },
     {
       name: 'variant',
@@ -143,7 +145,7 @@ export const docsDense = {
   },
   propDescriptions: {
     orientation: 'divider orientation',
-    label: 'optional centered label on divider',
+    label: 'optional centered label; preserves 0; null/boolean/"" omit it',
     variant: 'visual weight of divider line',
     isFullBleed: 'extend to container edges w/ negative margins',
     xstyle: 'StyleX styles for layout; must be stylex.create() value',

package/src/Divider/Divider.spec.md

@@ -1,6 +1,6 @@
 ---
 schema_version: 3
-template_version: 3
+template_version: 7
 kind: component
 id: component:Divider
 authority: draft
@@ -9,33 +9,61 @@ superseded_by: null
 approved_by: null
 approved_at: null
 owners: [cixzhang]
-review_triggers: [theming]
+review_triggers: [public-api, behavior, layout, theming, accessibility, testing]
 verified_by:
-  [packages/core/src/Divider/Divider.test.tsx, scripts/check-knowledge.mjs]
+  [
+    packages/core/src/Divider/Divider.test.tsx,
+    packages/core/src/theme/themingTargets.test.ts,
+    apps/storybook/stories/Divider.stories.tsx,
+  ]
 modules: []
 families: []
 design_specs: []
 architecture:
-  [architecture:component-theming-surface, architecture:container-padding]
+  [
+    architecture:public-component-api,
+    architecture:component-theming-surface,
+    architecture:container-padding,
+    architecture:component-test-sufficiency,
+  ]
 contributing: []
-system_specs: []
+system_specs: [spec:AST-020, spec:AST-029]
 ---
 
 # Divider component contract
 
+## Contract at a glance
+
+| Area                    | Contract                                                                                                                                                                                                                      |
+| ----------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| Public contract         | `orientation`, `label`, theme-extensible `variant`, `isFullBleed`, `BaseProps<HTMLDivElement>`, and a root `ref`.                                                                                                             |
+| Behavior                | The separator renders one rule without a label and two rules around a renderable label; full bleed consumes inherited logical container inset. The theme-extensible variant axis has no settled no-match line-paint fallback. |
+| End-user impact         | People can perceive a named separator across horizontal, vertical, labelled, full-bleed, narrow, and RTL compositions. A custom theme variant can still lose its line paint; OQ2 records that retained gap.                   |
+| Builder impact          | No new caller choice. Numeric zero remains a valid label; booleans and empty strings leave one continuous unnamed rule.                                                                                                       |
+| Compatibility/readiness | Patch-compatible observational contract. Public props, defaults, target names, and built-in appearances remain unchanged; authority stays `draft` until exact-head owner approval.                                            |
+| Review checks           | Reject missing numeric labels, physical-edge bleed, dropped root inputs, or a target/axis that disagrees with the rendered separator. Keep the custom-variant paint gap unresolved until OQ2 is settled.                      |
+| Governing rules         | `architecture:public-component-api/INV1,INV5–INV9`; `architecture:component-theming-surface/INV3–INV7,INV14`; `architecture:container-padding/INV1,INV3,INV7–INV10`; WCAG 2.2 SC 1.3.1 and 4.1.2 through `spec:AST-020/FR1`.  |
+
+This table is a review projection; the body below is authoritative.
+
 ## Intent
 
-Divider presents a separator group as one rule, or as two rules around an
-optional label. This draft records current consumer anatomy and theming
-reachability without changing runtime behavior, styling, targets, or public API.
+Divider provides a programmatic and visual separator between caller-owned content
+regions. It owns orientation, line weight, optional label placement and naming,
+logical full-bleed geometry, and the aggregate `divider` theme target. The caller
+owns the meaning of the surrounding regions.
+
+Consumer syntax and examples belong in `Divider.doc.mjs`.
 
 ## Compatibility and migration
 
-- Released default preserved: `yes`
-- Compatibility class: additive documentation only; runtime, DOM, styling,
-  targets, aliases, and public API remain unchanged
-- Controlled/uncontrolled behavior: not applicable
-- Migration decision: none
+- Released default preserved: yes — horizontal, subtle, unlabelled, and not full
+  bleed.
+- Compatibility class: patch fix. ReactNode values that React renders, including
+  numeric zero, stay inside the label wrapper; skipped scalar labels leave one
+  continuous unnamed rule.
+- Controlled/uncontrolled behavior: not applicable.
+- Migration decision: none.
 
 Consumer migration instructions belong in consumer docs and release notes.
 
@@ -43,61 +71,104 @@ Consumer migration instructions belong in consumer docs and release notes.
 
 **Owns**
 
-- The separator group, its current `divider` target, the painted rule segments,
-  and the optional label placement.
+- One semantic separator root and its public ref, DOM, data, ARIA, class, style,
+  event, and `xstyle` composition.
+- Horizontal and vertical rule geometry.
+- Optional label placement and the separator naming relationship.
+- Built-in subtle and strong line weights.
+- The current reflected custom-variant state, including the missing deterministic
+  line-paint fallback recorded by OQ2.
+- Logical full-bleed consumption of inherited container inset.
+- The aggregate `divider` target with reflected orientation and variant axes.
 
 **Does not own / non-goals**
 
-- The meaning of the content regions separated by the divider, which is owned by
-  the product callsite.
-- Container inset publication or structural page regions. Divider only reads
-  inherited container geometry when `isFullBleed` is enabled.
-- Whether Rule or Label should gain public targets, which is unresolved by this
-  factual backfill.
+- The meaning or heading structure of surrounding content regions — owned by the
+  product callsite.
+- Container inset publication — owned by `architecture:container-padding`.
+- A separate public target for Rule or Label — unresolved under OQ1.
+- Theme-authored custom variant paint and the public part that should own it —
+  unresolved under OQ2.
 
 ## Public concepts
 
-No new public concept is introduced. Consumer props and usage remain documented
-in `Divider.doc.mjs`.
+| Concept      | Closed values or states                       | Meaning                                                                                       | Availability by variant/orientation/state | Default      | Owner                        | Stability                               | Invalid-value behavior                                                             |
+| ------------ | --------------------------------------------- | --------------------------------------------------------------------------------------------- | ----------------------------------------- | ------------ | ---------------------------- | --------------------------------------- | ---------------------------------------------------------------------------------- |
+| Orientation  | `horizontal`; `vertical`                      | Selects the separator axis, rule geometry, and `aria-orientation`.                            | Every divider                             | `horizontal` | component                    | stable                                  | Closed union; rejected by types                                                    |
+| Label        | renderable ReactNode; omitted/skipped scalar  | Inserts one label between two rules and names the separator unless explicit ARIA naming wins. | Every orientation and variant             | omitted      | caller/component             | stable                                  | `null`, booleans, and empty strings render no label; numeric zero remains visible  |
+| Variant      | `subtle`; `strong`; theme-added visual values | Selects line paint and reflects the requested value on the target.                            | Every orientation and label state         | `subtle`     | component/theme              | stable built-ins; theme-extensible axis | An unmatched custom value has no deterministic line-paint baseline; see OQ2        |
+| Full bleed   | false; true                                   | Consumes inherited logical container inset on the divider axis.                               | Every orientation                         | false        | component/container protocol | stable                                  | Missing variables resolve to zero                                                  |
+| Root surface | ref; DOM/data/ARIA; class/style/xstyle/events | Extends the semantic separator root.                                                          | Every divider                             | omitted      | public component API         | stable                                  | Accepted inputs compose; component-owned role and orientation remain authoritative |
 
 ## Behavioral and layout contract
 
-| ID  | Candidate invariant                                                                                      | Basis                           | Draft review state                                  |
-| --- | -------------------------------------------------------------------------------------------------------- | ------------------------------- | --------------------------------------------------- |
-| FR1 | The current render contains one rule without a label and two rules with the optional label between them. | Current source, docs, and tests | Verified current behavior; no new behavior decided  |
-| FR2 | The divider group carries the current `divider` target; Rule and Label currently carry no public target. | Current source, docs, and tests | Verified current behavior; theming intent unsettled |
+Draft requirements identify their basis so observed code is not mistaken for an
+intentional decision.
+
+| ID  | Candidate invariant                                                                                                                                                                                                              | Basis                                                                                  | Draft review state              |
+| --- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------- | ------------------------------- |
+| FR1 | The divider MUST render one rule without a renderable label and two rules with the label between them. Numeric zero MUST remain a renderable label.                                                                              | Released ReactNode API; current source/docs; `architecture:public-component-api/INV9`  | verify                          |
+| FR2 | The root MUST expose `role="separator"` and the selected `aria-orientation`. A renderable label MUST name it through `aria-labelledby` unless an explicit caller `aria-label` or `aria-labelledby` wins.                         | WCAG 2.2 SC 1.3.1 and 4.1.2; current source/tests                                      | verify                          |
+| FR3 | Built-in variants MUST paint subtle or strong lines. The exported map accepts theme-added values, but an unmatched value currently leaves the inner rule without line paint; the correct fallback/target ownership requires OQ2. | `architecture:component-theming-surface/INV4,INV6,INV14`; exported `DividerVariantMap` | human decision; open BLOCK      |
+| FR4 | Full bleed MUST consume inherited logical inline inset for horizontal dividers and logical block inset for vertical dividers; absent inset MUST resolve to zero.                                                                 | `architecture:container-padding/INV1,INV3,INV7–INV10`                                  | verify                          |
+| FR5 | The root MUST carry the `divider` target and reflect orientation and requested variant. Rule and Label currently carry no public target.                                                                                         | `architecture:component-theming-surface/INV3–INV6`; current metadata                   | verify; part exposure unsettled |
+| FR6 | Accepted ref, DOM/data/ARIA, class, style, events, and `xstyle` MUST reach or compose on the separator root without replacing component-owned role or orientation.                                                               | `architecture:public-component-api/INV5–INV8`                                          | verify                          |
 
 ### Allowed variation
 
-- Orientation, visual weight, full-bleed layout, and label content may vary
-  without changing the three-part anatomy recorded here.
+- **AV1 — Label content.** Any caller-owned ReactNode that React renders may fill
+  the label wrapper.
+- **AV2 — Theme paint.** An active theme may restyle the aggregate target and its
+  variant axis. OQ2 owns the unresolved inner-rule paint and fallback boundary.
+- **AV3 — Container geometry.** Full bleed follows the inherited per-edge inset,
+  including asymmetric and zero values.
 
 ### Representative states
 
-- Unlabelled horizontal and vertical dividers render one Rule.
-- Labelled horizontal and vertical dividers render Label between two instances
-  of Rule.
+| State                               | Required invariant                                                                      | Allowed variation                          |
+| ----------------------------------- | --------------------------------------------------------------------------------------- | ------------------------------------------ |
+| Unlabelled horizontal               | One subtle or strong inline rule; horizontal separator semantics                        | Container width and theme paint            |
+| Labelled horizontal                 | Two rules around one visible, naming label                                              | Any renderable label content               |
+| Numeric zero label                  | One visible `0` inside the label wrapper; separator name `0`                            | Any orientation or variant                 |
+| Vertical labelled/unlabelled        | Block-axis rules and vertical separator semantics                                       | Container height and label content         |
+| Theme-added variant without a match | Requested variant reflected; inner rule has no component-owned paint (open BLOCK)       | Custom variant name                        |
+| Full bleed                          | Logical-axis inset consumed without physical-direction assumptions                      | Uniform, asymmetric, zero, or absent inset |
+| RTL                                 | Horizontal geometry remains logical; full bleed consumes inline start/end independently | Surrounding content and label language     |
 
 ### Transformation and precedence order
 
-- No new layout or styling precedence rule is introduced.
+- **ORD1 — Label presence.** Apply the shared renderable-value predicate; when a
+  label remains, render and reference one wrapper between two rules.
+- **ORD2 — Accessible name.** Explicit `aria-labelledby` wins, then explicit
+  `aria-label`, then the rendered label wrapper; an unlabelled separator stays
+  unnamed.
+- **ORD3 — Variant paint.** Reflect the requested value on the root target. Built-in
+  values select subtle or strong inner-rule paint; unmatched custom values select no
+  inner-rule paint pending OQ2.
 
 ### Performance and resources
 
-- No new performance or resource rule is introduced.
+- **PR1 — No external lifecycle.** Divider installs no listener, observer, timer,
+  request, state machine, or Effect.
 
 ## Accessibility contract
 
-This draft does not change or extend Divider's existing separator naming or
-orientation behavior.
+- **AR1 — Programmatic separator.** The root exposes separator role and the exact
+  visual orientation.
+- **AR2 — Label relationship.** A rendered label names the separator unless the
+  caller supplies an explicit accessible name relationship.
+- **AR3 — Decorative rule segments.** Internal rule elements add no separate role,
+  name, focus target, or interaction.
 
 ## Design relationships
 
-| Anatomy or state | Design requirement                                                | Representation authority       | Hierarchy role | Component contract |
-| ---------------- | ----------------------------------------------------------------- | ------------------------------ | -------------- | ------------------ |
-| Divider group    | Arranges the separator's rule segments and optional label.        | Current source and public docs | Supporting     | FR1, FR2           |
-| Rule             | Paints the separator line in the selected orientation and weight. | Current source and public docs | Supporting     | FR1, FR2           |
-| Label            | Presents optional content between two rule segments.              | Current source and public docs | Prominent      | FR1, FR2           |
+| Anatomy or state | Design requirement                                                                            | Representation authority                                     | Hierarchy role | Component contract |
+| ---------------- | --------------------------------------------------------------------------------------------- | ------------------------------------------------------------ | -------------- | ------------------ |
+| Divider group    | Arrange rule segments and the optional label on one logical axis.                             | observed; container geometry settled by current architecture | supporting     | FR1, FR4           |
+| Rule             | Paint a visible subtle or strong separation line; theme-added values lack a settled fallback. | built-ins observed; custom fallback unsettled                | supporting     | FR3                |
+| Label            | Present optional content between two rules using supporting text tokens.                      | observed; separate target exposure unsettled                 | prominent      | FR1–FR2            |
+
+No component-local visual decision is settled by this draft.
 
 ### Theming anatomy
 
@@ -125,20 +196,27 @@ public targets.
 
 ## Family and system relationships
 
-`family:layout-regions` does not own Divider: separating content is not a
-structural page-region contract. `architecture:container-padding` owns the
-inherited inset geometry that Divider reads only when `isFullBleed` is enabled.
-`architecture:component-theming-surface` owns anatomy qualification, target
-mapping, and the difference between factual reachability and intended public
-theming API.
+- `architecture:container-padding` owns the inherited internal inset protocol;
+  Divider consumes it only through `isFullBleed`.
+- `architecture:component-theming-surface` owns the aggregate target, reflected
+  axes, anatomy qualification, and the requirement that an open visual axis have
+  a deterministic fallback. Divider's current custom-value path does not satisfy
+  that requirement; OQ2 keeps remediation out of this objective audit patch.
+- `architecture:public-component-api` owns root composition, ref behavior, and
+  compatibility of the released ReactNode label surface.
+- There is no current Divider family or design record.
+- `spec:AST-029` keeps this observational draft separate from the audit receipt.
 
 ## Verification map
 
-| Contract            | Verification                                     | Representative states                | Mutation or failure expectation                                                                   | Audit section           |
-| ------------------- | ------------------------------------------------ | ------------------------------------ | ------------------------------------------------------------------------------------------------- | ----------------------- |
-| FR1                 | `Divider.test.tsx` structure and label suites    | Labelled and unlabelled; both axes   | Removing or reordering Rule or Label instances fails existing child-count and content assertions. | `audit:Divider/anatomy` |
-| FR2                 | Source inspection and current target inventories | Group, Rule, and Label               | Adding or documenting a current target without updating the anatomy map fails repository checks.  | `audit:Divider/theming` |
-| Theming anatomy map | `scripts/check-knowledge.mjs`                    | Canonical anatomy and current target | Missing, extra, prefixed, stale, or alias-backed mappings fail repository validation.             | `audit:Divider/theming` |
+| Contract         | Verification                                                     | Representative states                                                | Mutation or failure expectation                                                                             | Audit section             |
+| ---------------- | ---------------------------------------------------------------- | -------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------- | ------------------------- |
+| FR1–FR2, AR1–AR3 | `Divider.test.tsx`; component-owned Storybook states; scoped axe | labelled/unlabelled, numeric zero, explicit names, both orientations | Truthiness renders zero outside wrappers or leaves the separator unnamed; role/orientation/name drift fails | `audit:Divider/§1,§4`     |
+| FR3              | Source review; global extensible-axis structural guard           | subtle, strong, unmatched theme-added value                          | The current unmatched path leaves the rule unpainted; no Divider-specific browser fallback proof exists     | `audit:Divider/§2`        |
+| FR4              | Source review; horizontal and vertical full-bleed stories        | inline/block, LTR/RTL logical properties, absent inset               | A physical property or wrong axis consumes unrelated container geometry                                     | `audit:Divider/§5,§9,§10` |
+| FR5              | `themingTargets.test.ts`; component metadata; spec anatomy map   | both orientations and variants                                       | Target/axis/anatomy metadata disagrees with runtime reflection                                              | `audit:Divider/§2`        |
+| FR6              | `Divider.test.tsx`; lint, typecheck, and source review           | ref, DOM/data/ARIA, class/style/xstyle/events                        | An accepted input is dropped or component-owned semantics are overwritten                                   | `audit:Divider/§3`        |
+| PR1              | Source review                                                    | every state                                                          | A lifecycle mechanism appears without a resource contract                                                   | `audit:Divider/§7`        |
 
 ## Decision log
 
@@ -150,8 +228,16 @@ or theming decision.
 - **OQ1 — Should Rule or Label gain stable public theming targets?** (`human-api`)
   Their target exposure is unsettled; the current lack of reachability does not
   decide the answer.
+- **OQ2 — Should the open `variant` axis close, or which painting part owns its
+  deterministic custom-value fallback?** (`human-api`) The root target can carry
+  theme paint while the inner rule carries built-in paint. Applying a subtle inner
+  fallback can cover an existing root background; keeping the current path can make
+  the rule disappear. Current authority requires a safe fallback but does not choose
+  between closing the axis, moving target ownership, or routing paint through a
+  reviewed public property.
 
 ## Content boundary
 
-This file does not duplicate consumer prop tables/examples, current audit
-results, implementation steps, or system rules. It links to their owners.
+This file does not duplicate consumer prop tables/examples, current audit scores,
+screenshot matrices, implementation steps, or system rules. The audit pull request
+owns the closed run evidence required by `spec:AST-029/FR5`.

package/src/Divider/Divider.test.tsx

@@ -128,6 +128,21 @@ describe('Divider', () => {
     expect(divider).not.toHaveAttribute('aria-labelledby');
   });
 
+  it.each([false, true, ''])('omits a label wrapper for %j', label => {
+    render(<Divider label={label} data-testid="divider" />);
+    const divider = screen.getByTestId('divider');
+    expect(divider).not.toHaveAttribute('aria-labelledby');
+    expect(divider.children).toHaveLength(1);
+  });
+
+  it('preserves a numeric zero label and uses it as the accessible name', () => {
+    render(<Divider label={0} data-testid="divider" />);
+    const divider = screen.getByTestId('divider');
+    expect(screen.getByText('0')).toBeInTheDocument();
+    expect(divider).toHaveAccessibleName('0');
+    expect(divider.children).toHaveLength(3);
+  });
+
   it('renders astryx-* class names for theme targeting', () => {
     render(
       <Divider variant="strong" orientation="vertical" data-testid="divider" />,

package/src/Divider/Divider.tsx

@@ -25,7 +25,7 @@ import {
   typeScaleVars,
   borderVars,
 } from '../theme/tokens.stylex';
-import {mergeProps} from '../utils';
+import {isRenderable, mergeProps} from '../utils';
 import {themeProps} from '../utils/themeProps';
 import type {DividerVariantMap} from './index';
 
@@ -45,6 +45,7 @@ export interface DividerProps extends BaseProps<HTMLDivElement> {
 
   /**
    * Optional label to display centered on the divider.
+   * Numeric zero is preserved; null, booleans, and empty strings render no label.
    * Rendered with small, secondary text styling.
    */
   label?: ReactNode;
@@ -153,6 +154,7 @@ export function Divider({
   ...props
 }: DividerProps) {
   const isHorizontal = orientation === 'horizontal';
+  const hasLabel = isRenderable(label);
   const labelId = useId();
 
   // A separator does not derive its accessible name from its content, so the
@@ -160,7 +162,7 @@ export function Divider({
   // exposed as the separator's name (WCAG 1.3.1). An explicit aria-label or
   // aria-labelledby from the consumer takes precedence.
   const resolvedLabelledBy =
-    ariaLabelledBy ?? (label && ariaLabel == null ? labelId : undefined);
+    ariaLabelledBy ?? (hasLabel && ariaLabel == null ? labelId : undefined);
 
   return (
     <div
@@ -189,7 +191,7 @@ export function Divider({
           lineStyles[variant],
         )}
       />
-      {label && (
+      {hasLabel && (
         <div
           id={labelId}
           {...stylex.props(
@@ -199,7 +201,7 @@ export function Divider({
           {label}
         </div>
       )}
-      {label && (
+      {hasLabel && (
         <div
           {...stylex.props(
             isHorizontal ? lineStyles.horizontalLine : lineStyles.verticalLine,