@astryxdesign/core 0.7.0-canary.fe57f54 → 0.7.0

package/src/Tokenizer/Tokenizer.test.tsx

@@ -1762,9 +1762,9 @@ describe('Tokenizer end-lane reserve', () => {
 });
 
 // `emptySearchResultsText` was renamed to `emptySearchText` and widened from
-// `string` to `ReactNode` (`spec:AST-056` FR1). It is a released prop with a
-// victim, so the replacement ships first and the old name keeps working
-// through the overlap (`spec:AST-017` FR28, FR29).
+// `string` to `ReactNode` (`spec:AST-056` FR1). The overlap ended in a minor
+// release (`CLN-0001`–`CLN-0004`, `spec:AST-017` FR31): the old name is no
+// longer part of the type and is no longer read.
 describe('Tokenizer emptySearchText', () => {
   async function searchForNothing() {
     const input = screen.getByRole('combobox');
@@ -1847,33 +1847,6 @@ describe('Tokenizer emptySearchText', () => {
     ).not.toContain('→');
   });
 
-  it('treats an explicit null as not given, falling through to the old name', async () => {
-    const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
-    render(
-      <Tokenizer
-        label="People"
-        searchSource={userSource}
-        value={[]}
-        onChange={() => {}}
-        debounceMs={0}
-        emptySearchResultsText="Nobody found"
-        emptySearchText={null}
-      />,
-    );
-    await searchForNothing();
-
-    // `null` is what this prop's own `??` default already treats as absent,
-    // so the released name still supplies the message and the warning says
-    // only that it is deprecated.
-    await waitFor(() => {
-      expect(screen.getByText('Nobody found')).toBeInTheDocument();
-    });
-    expect(warn).not.toHaveBeenCalledWith(
-      expect.stringContaining('are both set'),
-    );
-    warn.mockRestore();
-  });
-
   it('falls through to the default when null is the only value given', async () => {
     render(
       <Tokenizer
@@ -1892,8 +1865,10 @@ describe('Tokenizer emptySearchText', () => {
     });
   });
 
-  it('keeps the deprecated name working, and says it is deprecated', async () => {
+  it('no longer reads the removed emptySearchResultsText (CLN-0001)', async () => {
     const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
+    // The unknown prop reaches the root element, which React reports.
+    const error = vi.spyOn(console, 'error').mockImplementation(() => {});
     render(
       <Tokenizer
         label="People"
@@ -1901,47 +1876,21 @@ describe('Tokenizer emptySearchText', () => {
         value={[]}
         onChange={() => {}}
         debounceMs={0}
+        // @ts-expect-error -- removed in the minor release (CLN-0001)
         emptySearchResultsText="Nobody found"
       />,
     );
     await searchForNothing();
 
     await waitFor(() => {
-      expect(screen.getByText('Nobody found')).toBeInTheDocument();
-    });
-    expect(warn).toHaveBeenCalledWith(
-      expect.stringContaining(
-        'Tokenizer: `emptySearchResultsText` is deprecated; use `emptySearchText`',
-      ),
-    );
-    warn.mockRestore();
-  });
-
-  it('lets the new name win when both are set, and warns', async () => {
-    const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
-    render(
-      <Tokenizer
-        label="People"
-        searchSource={userSource}
-        value={[]}
-        onChange={() => {}}
-        debounceMs={0}
-        emptySearchResultsText="Old copy"
-        emptySearchText="New copy"
-      />,
-    );
-    await searchForNothing();
-
-    await waitFor(() => {
-      expect(screen.getByText('New copy')).toBeInTheDocument();
+      expect(screen.getByText('No results found')).toBeInTheDocument();
     });
-    expect(screen.queryByText('Old copy')).not.toBeInTheDocument();
-    expect(warn).toHaveBeenCalledWith(
-      expect.stringContaining(
-        'Tokenizer: `emptySearchResultsText` and `emptySearchText` are both set',
-      ),
+    expect(screen.queryByText('Nobody found')).not.toBeInTheDocument();
+    expect(warn).not.toHaveBeenCalledWith(
+      expect.stringContaining('is deprecated'),
     );
     warn.mockRestore();
+    error.mockRestore();
   });
 });
 

package/src/Tokenizer/Tokenizer.tsx

@@ -68,7 +68,6 @@ import type {SearchableItem, SearchSource} from '../Typeahead/types';
 import {mergeProps} from '../utils';
 import {themeProps} from '../utils/themeProps';
 import {useTranslator} from '../i18n';
-import {useRenamedProp} from '../hooks/useRenamedProp';
 
 // Re-export status types for convenience
 export type {
@@ -206,18 +205,6 @@ export interface TokenizerProps<T extends SearchableItem> extends Omit<
    * @default 'No results found'
    */
   emptySearchText?: ReactNode;
-
-  /**
-   * Text shown when no results found.
-   * @default 'No results found'
-   * @deprecated `DEP-0001`. Renamed to `emptySearchText`, which takes a
-   * `ReactNode` rather than a `string` — every existing value stays valid
-   * (`spec:AST-056` FR1, FR7). Still works exactly as released;
-   * `emptySearchText` wins when both are set. Removal is `CLN-0001`, in a
-   * later minor whose frozen manifest carries both ids (`spec:AST-017`
-   * FR31).
-   */
-  emptySearchResultsText?: string;
   /** Whether the input is disabled. @default false */
   isDisabled?: boolean;
   /**
@@ -577,8 +564,7 @@ export function Tokenizer<T extends SearchableItem>({
   maxMenuItems,
   menuWidth,
   minQueryLength,
-  emptySearchResultsText,
-  emptySearchText: emptySearchTextFromProps,
+  emptySearchText,
   isDisabled = false,
   htmlName,
   disabledMessage,
@@ -633,16 +619,6 @@ export function Tokenizer<T extends SearchableItem>({
     isEnabled: showsDisabledMessage,
   });
 
-  // The replacement wins, the released name keeps working, and development
-  // says which one was read (`spec:AST-056` FR7, `spec:AST-017` FR28).
-  const emptySearchText = useRenamedProp<ReactNode>({
-    component: 'Tokenizer',
-    deprecated: 'emptySearchResultsText',
-    deprecatedValue: emptySearchResultsText,
-    replacement: 'emptySearchText',
-    value: emptySearchTextFromProps,
-  });
-
   useImperativeHandle(handleRef, () => ({
     focus() {
       inputRef.current?.focus();

package/src/Toolbar/Toolbar.test.tsx

@@ -12,7 +12,12 @@
 import {describe, it, expect, vi} from 'vitest';
 import {render, screen} from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
+import * as stylex from '@stylexjs/stylex';
 import {Toolbar} from './Toolbar';
+import {
+  paddingBlockStyles,
+  paddingInlineStyles,
+} from '../Layout/padding.stylex';
 
 describe('Toolbar', () => {
   it('renders with toolbar role', () => {
@@ -148,6 +153,30 @@ describe('Toolbar', () => {
     expect(toolbar).toHaveAttribute('data-size', 'sm');
   });
 
+  it.each([
+    ['sm', 2],
+    ['md', 2],
+  ] as const)(
+    'uses the %s block inset without overriding container inline padding',
+    (size, blockPadding) => {
+      const {container} = render(<Toolbar label="Actions" size={size} />);
+      const sectionInner = container.querySelector('.astryx-section');
+      const expectedBlockClasses = stylex
+        .props(paddingBlockStyles[blockPadding])
+        .className?.split(' ')
+        .filter(Boolean);
+      const compactInlineClasses = stylex
+        .props(paddingInlineStyles[1])
+        .className?.split(' ')
+        .filter(Boolean);
+
+      expect(sectionInner).toBeInTheDocument();
+      expect(expectedBlockClasses).not.toHaveLength(0);
+      expect(sectionInner).toHaveClass(...(expectedBlockClasses ?? []));
+      expect(sectionInner).not.toHaveClass(...(compactInlineClasses ?? []));
+    },
+  );
+
   it('defaults to md size', () => {
     render(<Toolbar label="Actions" />);
     const toolbar = screen.getByRole('toolbar');

package/src/Typeahead/BaseTypeahead.doc.mjs

@@ -165,13 +165,6 @@ export const docs = {
         'Content shown when the query matched nothing. Takes a ReactNode, so the dead end can carry a link or a create row. Announced in a polite live region as the text it renders, read from the DOM; aria-hidden parts stay out of both, and content that renders no text announces nothing. null counts as not given, like undefined, and falls through to the default; pass an empty string to render nothing.',
       default: "'No results found'",
     },
-    {
-      name: 'emptySearchResultsText',
-      type: 'string',
-      description:
-        'Deprecated: renamed to emptySearchText, which takes a ReactNode rather than a string, so every existing value stays valid. Still works exactly as released; emptySearchText wins when both are set.',
-      default: "'No results found'",
-    },
     {
       name: 'isDisabled',
       type: 'boolean',
@@ -331,13 +324,6 @@ export const docsZh = {
         '查询无匹配结果时显示的内容。接受 ReactNode，因此可在无结果处放置链接或创建入口。会从 DOM 读取其渲染出的文本在礼貌性实时区域中播报；aria-hidden 的部分两处都不包含，不渲染任何文本的内容则不会播报。null 与 undefined 同样视为未提供，将回退到默认值；若要不渲染任何内容，请传入空字符串。',
       default: "'No results found'",
     },
-    {
-      name: 'emptySearchResultsText',
-      type: 'string',
-      description:
-        '已弃用：改名为 emptySearchText，其类型由 string 放宽为 ReactNode，原有取值全部仍然有效。仍按已发布行为工作；两者同时设置时以 emptySearchText 为准。',
-      default: "'No results found'",
-    },
     {
       name: 'isDisabled',
       type: 'boolean',
@@ -479,8 +465,6 @@ export const docsDense = {
     minQueryLength:
       'Min query length before searching. Menu stays closed below it.',
     emptySearchText: 'Content when the query matched nothing. ReactNode.',
-    emptySearchResultsText:
-      'deprecated, use emptySearchText (ReactNode). still works as released; emptySearchText wins if both set.',
     isDisabled: 'Whether input disabled.',
     isFocusableDisabled:
       'Keeps disabled input focusable and blocks text entry; an already-open highlight can still be selected with Enter.',

package/src/Typeahead/BaseTypeahead.test.tsx

@@ -238,7 +238,7 @@ describe('BaseTypeahead', () => {
         value={null}
         onChange={() => {}}
         debounceMs={0}
-        emptySearchResultsText="No matching frameworks"
+        emptySearchText="No matching frameworks"
       />,
     );
 

package/src/Typeahead/BaseTypeahead.tsx

@@ -33,7 +33,6 @@ import type {StyleXStyles} from '@stylexjs/stylex';
 import {usePopover} from '../Popover/usePopover';
 import {useAnnounce} from '../hooks/useAnnounce';
 import {useAnnounceRenderedText} from '../hooks/useAnnounceRenderedText';
-import {useRenamedProp} from '../hooks/useRenamedProp';
 import {useHighlightedOptionScroll} from '../hooks/useHighlightedOptionScroll';
 import {useIsomorphicLayoutEffect} from '../hooks/useIsomorphicLayoutEffect';
 import {isImeKeyEvent} from '../utils/ime';
@@ -143,18 +142,6 @@ export interface BaseTypeaheadProps<T extends SearchableItem> extends Omit<
    */
   emptySearchText?: ReactNode;
 
-  /**
-   * Text shown when no results found.
-   * @default 'No results found'
-   * @deprecated `DEP-0003`. Renamed to `emptySearchText`, which takes a
-   * `ReactNode` rather than a `string` — every existing value stays valid
-   * (`spec:AST-056` FR1, FR7). Still works exactly as released;
-   * `emptySearchText` wins when both are set. Removal is `CLN-0003`, in a
-   * later minor whose frozen manifest carries both ids (`spec:AST-017`
-   * FR31).
-   */
-  emptySearchResultsText?: string;
-
   /**
    * Whether the input is disabled.
    * @default false
@@ -465,7 +452,6 @@ export const BaseTypeahead = function BaseTypeahead<T extends SearchableItem>({
   maxMenuItems = 10,
   menuWidth,
   minQueryLength = 1,
-  emptySearchResultsText: deprecatedEmptySearchResultsText,
   emptySearchText: emptySearchTextFromProps,
   isDisabled = false,
   isFocusableDisabled = false,
@@ -500,13 +486,7 @@ export const BaseTypeahead = function BaseTypeahead<T extends SearchableItem>({
   const placeholder =
     placeholderFromProps ?? t('@astryx.typeahead.searchPlaceholder');
   const emptySearchText =
-    useRenamedProp<ReactNode>({
-      component: 'BaseTypeahead',
-      deprecated: 'emptySearchResultsText',
-      deprecatedValue: deprecatedEmptySearchResultsText,
-      replacement: 'emptySearchText',
-      value: emptySearchTextFromProps,
-    }) ?? t('@astryx.typeahead.emptySearchResults');
+    emptySearchTextFromProps ?? t('@astryx.typeahead.emptySearchResults');
   // The empty-state row carries the message visually, and the live region has
   // to speak the same words. `emptySearchText` takes a ReactNode, so they are
   // read off the rendered row after it renders rather than guessed from the

package/src/Typeahead/Typeahead.doc.mjs

@@ -230,13 +230,6 @@ export const docs = {
         'Content shown when the query matched nothing. Takes a ReactNode, so the dead end can carry a link or a create row. Announced in a polite live region as the text it renders, read from the DOM; aria-hidden parts stay out of both, and content that renders no text announces nothing. null counts as not given, like undefined, and falls through to the default; pass an empty string to render nothing.',
       default: "'No results found'",
     },
-    {
-      name: 'emptySearchResultsText',
-      type: 'string',
-      description:
-        'Deprecated: renamed to emptySearchText, which takes a ReactNode rather than a string, so every existing value stays valid. Still works exactly as released; emptySearchText wins when both are set.',
-      default: "'No results found'",
-    },
     {
       name: 'hasAutoFocus',
       type: 'boolean',

package/src/Typeahead/Typeahead.test.tsx

@@ -239,7 +239,7 @@ describe('BaseTypeahead', () => {
         value={null}
         onChange={() => {}}
         debounceMs={0}
-        emptySearchResultsText="No results found"
+        emptySearchText="No results found"
       />,
     );
     const input = screen.getByRole('combobox');
@@ -260,7 +260,7 @@ describe('BaseTypeahead', () => {
         value={null}
         onChange={() => {}}
         debounceMs={0}
-        emptySearchResultsText="No results found"
+        emptySearchText="No results found"
       />,
     );
     const input = screen.getByRole('combobox');
@@ -2189,9 +2189,9 @@ describe('the value is bounded by the content lane', () => {
 });
 
 // `emptySearchResultsText` was renamed to `emptySearchText` and widened from
-// `string` to `ReactNode` (`spec:AST-056` FR1). It is a released prop with a
-// victim, so the replacement ships first and the old name keeps working
-// through the overlap (`spec:AST-017` FR28, FR29).
+// `string` to `ReactNode` (`spec:AST-056` FR1). The overlap ended in a minor
+// release (`CLN-0001`–`CLN-0004`, `spec:AST-017` FR31): the old name is no
+// longer part of the type and is no longer read.
 describe('emptySearchText rename', () => {
   function searchForNothing() {
     fireEvent.change(screen.getByRole('combobox'), {
@@ -2222,8 +2222,10 @@ describe('emptySearchText rename', () => {
       });
     });
 
-    it('keeps the deprecated name working, and says it is deprecated', async () => {
+    it('no longer reads the removed emptySearchResultsText (CLN-0002)', async () => {
       const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
+      // The unknown prop reaches the root element, which React reports.
+      const error = vi.spyOn(console, 'error').mockImplementation(() => {});
       render(
         <Typeahead
           label="Fruit"
@@ -2231,47 +2233,21 @@ describe('emptySearchText rename', () => {
           value={null}
           onChange={() => {}}
           debounceMs={0}
+          // @ts-expect-error -- removed in the minor release (CLN-0002)
           emptySearchResultsText="Nothing ripe"
         />,
       );
       searchForNothing();
 
       await waitFor(() => {
-        expect(screen.getByText('Nothing ripe')).toBeInTheDocument();
+        expect(screen.getByText('No results found')).toBeInTheDocument();
       });
-      expect(warn).toHaveBeenCalledWith(
-        expect.stringContaining(
-          'Typeahead: `emptySearchResultsText` is deprecated; use `emptySearchText`',
-        ),
-      );
-      warn.mockRestore();
-    });
-
-    it('lets the new name win when both are set, and warns', async () => {
-      const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
-      render(
-        <Typeahead
-          label="Fruit"
-          searchSource={fruitSource}
-          value={null}
-          onChange={() => {}}
-          debounceMs={0}
-          emptySearchResultsText="Old copy"
-          emptySearchText="New copy"
-        />,
-      );
-      searchForNothing();
-
-      await waitFor(() => {
-        expect(screen.getByText('New copy')).toBeInTheDocument();
-      });
-      expect(screen.queryByText('Old copy')).not.toBeInTheDocument();
-      expect(warn).toHaveBeenCalledWith(
-        expect.stringContaining(
-          'Typeahead: `emptySearchResultsText` and `emptySearchText` are both set',
-        ),
+      expect(screen.queryByText('Nothing ripe')).not.toBeInTheDocument();
+      expect(warn).not.toHaveBeenCalledWith(
+        expect.stringContaining('is deprecated'),
       );
       warn.mockRestore();
+      error.mockRestore();
     });
   });
 
@@ -2301,14 +2277,16 @@ describe('emptySearchText rename', () => {
       });
     });
 
-    it('announces the deprecated name unchanged', async () => {
-      const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
+    it('no longer announces the removed emptySearchResultsText (CLN-0003)', async () => {
+      // The unknown prop reaches the root element, which React reports.
+      const error = vi.spyOn(console, 'error').mockImplementation(() => {});
       render(
         <BaseTypeahead
           searchSource={fruitSource}
           value={null}
           onChange={() => {}}
           debounceMs={0}
+          // @ts-expect-error -- removed in the minor release (CLN-0003)
           emptySearchResultsText="Nothing ripe"
         />,
       );
@@ -2317,9 +2295,13 @@ describe('emptySearchText rename', () => {
       await waitFor(() => {
         expect(
           document.querySelector('[data-astryx-live-region="polite"]'),
-        ).toHaveTextContent('Nothing ripe');
+        ).toHaveTextContent('No results found');
       });
-      warn.mockRestore();
+      expect(
+        document.querySelector('[data-astryx-live-region="polite"]')
+          ?.textContent,
+      ).not.toContain('Nothing ripe');
+      error.mockRestore();
     });
   });
 });

package/src/Typeahead/Typeahead.tsx

@@ -70,7 +70,6 @@ import {themeProps} from '../utils/themeProps';
 import {useTranslator} from '../i18n';
 
 import {useMergedRefs} from '../hooks/useMergedRefs';
-import {useRenamedProp} from '../hooks/useRenamedProp';
 export type {
   InputStatus as TypeaheadStatus,
   InputStatusType as TypeaheadStatusType,
@@ -160,18 +159,6 @@ export interface TypeaheadProps<T extends SearchableItem> extends Omit<
    * @default 'No results found'
    */
   emptySearchText?: ReactNode;
-
-  /**
-   * Text shown when no results found.
-   * @default 'No results found'
-   * @deprecated `DEP-0002`. Renamed to `emptySearchText`, which takes a
-   * `ReactNode` rather than a `string` — every existing value stays valid
-   * (`spec:AST-056` FR1, FR7). Still works exactly as released;
-   * `emptySearchText` wins when both are set. Removal is `CLN-0002`, in a
-   * later minor whose frozen manifest carries both ids (`spec:AST-017`
-   * FR31).
-   */
-  emptySearchResultsText?: string;
   /** Whether the input is disabled. @default false */
   isDisabled?: boolean;
   /**
@@ -399,8 +386,7 @@ export function Typeahead<T extends SearchableItem>({
   hasEntriesOnFocus,
   maxMenuItems,
   minQueryLength,
-  emptySearchResultsText,
-  emptySearchText: emptySearchTextFromProps,
+  emptySearchText,
   isDisabled = false,
   disabledMessage,
   hasClear = true,
@@ -435,16 +421,6 @@ export function Typeahead<T extends SearchableItem>({
   const statusMessageId = useId();
   const inputGroup = useInputGroup();
 
-  // The replacement wins, the released name keeps working, and development
-  // says which one was read (`spec:AST-056` FR7, `spec:AST-017` FR28).
-  const emptySearchText = useRenamedProp<ReactNode>({
-    component: 'Typeahead',
-    deprecated: 'emptySearchResultsText',
-    deprecatedValue: emptySearchResultsText,
-    replacement: 'emptySearchText',
-    value: emptySearchTextFromProps,
-  });
-
   const wrapperRef = useRef<HTMLDivElement>(null);
   const inputRef = useRef<HTMLInputElement>(null);
   const tokenRef = useRef<HTMLElement>(null);

package/src/hooks/useFocusTrap.ts

@@ -91,8 +91,12 @@ function isVisiblyFocusable(el: HTMLElement): boolean {
 
 /**
  * Get all focusable elements within a container.
+ *
+ * Exported for menus that place their own Tab stops inside a trapped layer
+ * (DropdownMenu's header and footer), so they judge reachability exactly as
+ * the trap does. Not re-exported from the package's `hooks` entry.
  */
-function getFocusableElements(container: HTMLElement): HTMLElement[] {
+export function getFocusableElements(container: HTMLElement): HTMLElement[] {
   return Array.from(
     container.querySelectorAll<HTMLElement>(FOCUSABLE_SELECTOR),
   ).filter(isVisiblyFocusable);

package/src/hooks/useRenamedProp.ts

@@ -56,12 +56,12 @@ export interface RenamedPropOptions<T> {
  *
  * @example
  * ```
- * const emptySearchText = useRenamedProp({
- *   component: 'Tokenizer',
- *   deprecated: 'emptySearchResultsText',
- *   deprecatedValue: emptySearchResultsText,
- *   replacement: 'emptySearchText',
- *   value: emptySearchTextFromProps,
+ * const label = useRenamedProp({
+ *   component: 'Example',
+ *   deprecated: 'oldLabel',
+ *   deprecatedValue: oldLabel,
+ *   replacement: 'label',
+ *   value: labelFromProps,
  * });
  * ```
  */