@astryxdesign/core 0.7.0-canary.f3a2181 → 0.7.0

package/src/Typeahead/Typeahead.test.tsx

@@ -239,7 +239,7 @@ describe('BaseTypeahead', () => {
         value={null}
         onChange={() => {}}
         debounceMs={0}
-        emptySearchResultsText="No results found"
+        emptySearchText="No results found"
       />,
     );
     const input = screen.getByRole('combobox');
@@ -260,7 +260,7 @@ describe('BaseTypeahead', () => {
         value={null}
         onChange={() => {}}
         debounceMs={0}
-        emptySearchResultsText="No results found"
+        emptySearchText="No results found"
       />,
     );
     const input = screen.getByRole('combobox');
@@ -2189,9 +2189,9 @@ describe('the value is bounded by the content lane', () => {
 });
 
 // `emptySearchResultsText` was renamed to `emptySearchText` and widened from
-// `string` to `ReactNode` (`spec:AST-056` FR1). It is a released prop with a
-// victim, so the replacement ships first and the old name keeps working
-// through the overlap (`spec:AST-017` FR28, FR29).
+// `string` to `ReactNode` (`spec:AST-056` FR1). The overlap ended in a minor
+// release (`CLN-0001`–`CLN-0004`, `spec:AST-017` FR31): the old name is no
+// longer part of the type and is no longer read.
 describe('emptySearchText rename', () => {
   function searchForNothing() {
     fireEvent.change(screen.getByRole('combobox'), {
@@ -2222,8 +2222,10 @@ describe('emptySearchText rename', () => {
       });
     });
 
-    it('keeps the deprecated name working, and says it is deprecated', async () => {
+    it('no longer reads the removed emptySearchResultsText (CLN-0002)', async () => {
       const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
+      // The unknown prop reaches the root element, which React reports.
+      const error = vi.spyOn(console, 'error').mockImplementation(() => {});
       render(
         <Typeahead
           label="Fruit"
@@ -2231,47 +2233,21 @@ describe('emptySearchText rename', () => {
           value={null}
           onChange={() => {}}
           debounceMs={0}
+          // @ts-expect-error -- removed in the minor release (CLN-0002)
           emptySearchResultsText="Nothing ripe"
         />,
       );
       searchForNothing();
 
       await waitFor(() => {
-        expect(screen.getByText('Nothing ripe')).toBeInTheDocument();
+        expect(screen.getByText('No results found')).toBeInTheDocument();
       });
-      expect(warn).toHaveBeenCalledWith(
-        expect.stringContaining(
-          'Typeahead: `emptySearchResultsText` is deprecated; use `emptySearchText`',
-        ),
-      );
-      warn.mockRestore();
-    });
-
-    it('lets the new name win when both are set, and warns', async () => {
-      const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
-      render(
-        <Typeahead
-          label="Fruit"
-          searchSource={fruitSource}
-          value={null}
-          onChange={() => {}}
-          debounceMs={0}
-          emptySearchResultsText="Old copy"
-          emptySearchText="New copy"
-        />,
-      );
-      searchForNothing();
-
-      await waitFor(() => {
-        expect(screen.getByText('New copy')).toBeInTheDocument();
-      });
-      expect(screen.queryByText('Old copy')).not.toBeInTheDocument();
-      expect(warn).toHaveBeenCalledWith(
-        expect.stringContaining(
-          'Typeahead: `emptySearchResultsText` and `emptySearchText` are both set',
-        ),
+      expect(screen.queryByText('Nothing ripe')).not.toBeInTheDocument();
+      expect(warn).not.toHaveBeenCalledWith(
+        expect.stringContaining('is deprecated'),
       );
       warn.mockRestore();
+      error.mockRestore();
     });
   });
 
@@ -2301,14 +2277,16 @@ describe('emptySearchText rename', () => {
       });
     });
 
-    it('announces the deprecated name unchanged', async () => {
-      const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
+    it('no longer announces the removed emptySearchResultsText (CLN-0003)', async () => {
+      // The unknown prop reaches the root element, which React reports.
+      const error = vi.spyOn(console, 'error').mockImplementation(() => {});
       render(
         <BaseTypeahead
           searchSource={fruitSource}
           value={null}
           onChange={() => {}}
           debounceMs={0}
+          // @ts-expect-error -- removed in the minor release (CLN-0003)
           emptySearchResultsText="Nothing ripe"
         />,
       );
@@ -2317,9 +2295,13 @@ describe('emptySearchText rename', () => {
       await waitFor(() => {
         expect(
           document.querySelector('[data-astryx-live-region="polite"]'),
-        ).toHaveTextContent('Nothing ripe');
+        ).toHaveTextContent('No results found');
       });
-      warn.mockRestore();
+      expect(
+        document.querySelector('[data-astryx-live-region="polite"]')
+          ?.textContent,
+      ).not.toContain('Nothing ripe');
+      error.mockRestore();
     });
   });
 });

package/src/Typeahead/Typeahead.tsx

@@ -70,7 +70,6 @@ import {themeProps} from '../utils/themeProps';
 import {useTranslator} from '../i18n';
 
 import {useMergedRefs} from '../hooks/useMergedRefs';
-import {useRenamedProp} from '../hooks/useRenamedProp';
 export type {
   InputStatus as TypeaheadStatus,
   InputStatusType as TypeaheadStatusType,
@@ -160,18 +159,6 @@ export interface TypeaheadProps<T extends SearchableItem> extends Omit<
    * @default 'No results found'
    */
   emptySearchText?: ReactNode;
-
-  /**
-   * Text shown when no results found.
-   * @default 'No results found'
-   * @deprecated `DEP-0002`. Renamed to `emptySearchText`, which takes a
-   * `ReactNode` rather than a `string` — every existing value stays valid
-   * (`spec:AST-056` FR1, FR7). Still works exactly as released;
-   * `emptySearchText` wins when both are set. Removal is `CLN-0002`, in a
-   * later minor whose frozen manifest carries both ids (`spec:AST-017`
-   * FR31).
-   */
-  emptySearchResultsText?: string;
   /** Whether the input is disabled. @default false */
   isDisabled?: boolean;
   /**
@@ -399,8 +386,7 @@ export function Typeahead<T extends SearchableItem>({
   hasEntriesOnFocus,
   maxMenuItems,
   minQueryLength,
-  emptySearchResultsText,
-  emptySearchText: emptySearchTextFromProps,
+  emptySearchText,
   isDisabled = false,
   disabledMessage,
   hasClear = true,
@@ -435,16 +421,6 @@ export function Typeahead<T extends SearchableItem>({
   const statusMessageId = useId();
   const inputGroup = useInputGroup();
 
-  // The replacement wins, the released name keeps working, and development
-  // says which one was read (`spec:AST-056` FR7, `spec:AST-017` FR28).
-  const emptySearchText = useRenamedProp<ReactNode>({
-    component: 'Typeahead',
-    deprecated: 'emptySearchResultsText',
-    deprecatedValue: emptySearchResultsText,
-    replacement: 'emptySearchText',
-    value: emptySearchTextFromProps,
-  });
-
   const wrapperRef = useRef<HTMLDivElement>(null);
   const inputRef = useRef<HTMLInputElement>(null);
   const tokenRef = useRef<HTMLElement>(null);

package/src/hooks/useRenamedProp.ts

@@ -56,12 +56,12 @@ export interface RenamedPropOptions<T> {
  *
  * @example
  * ```
- * const emptySearchText = useRenamedProp({
- *   component: 'Tokenizer',
- *   deprecated: 'emptySearchResultsText',
- *   deprecatedValue: emptySearchResultsText,
- *   replacement: 'emptySearchText',
- *   value: emptySearchTextFromProps,
+ * const label = useRenamedProp({
+ *   component: 'Example',
+ *   deprecated: 'oldLabel',
+ *   deprecatedValue: oldLabel,
+ *   replacement: 'label',
+ *   value: labelFromProps,
  * });
  * ```
  */