@astryxdesign/core 0.4.7 → 0.5.0-canary.32a62fd

package/src/DateInput/NativeDateField.test.tsx

@@ -0,0 +1,565 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+
+/**
+ * @file NativeDateField.test.tsx
+ * @input Uses vitest, @testing-library/react, DateInput
+ * @output Unit tests for the OS-picker surface (`nativePicker`)
+ * @position Testing; validates NativeDateField.tsx
+ *
+ * Every test renders through `DateInput` with a pointer stubbed, so the
+ * surface selection in DateInput.tsx is exercised too. `nativePicker`
+ * defaults to `'touch'`, so a coarse pointer alone gets the native control.
+ *
+ * The iOS behaviours these pin — the picker detaching from the field on a
+ * programmatic write, React's synthetic change not firing for the picker's
+ * edits, `text-overflow` being inert on a flex box — were all measured on a
+ * real device and none reproduce in jsdom. Where a test asserts a CSS rule
+ * rather than a behaviour, that is why.
+ *
+ * SYNC: When NativeDateField.tsx changes, update tests to match new behavior
+ */
+
+import {describe, it, expect, vi, beforeEach, afterEach} from 'vitest';
+import {render, screen, fireEvent} from '@testing-library/react';
+import {DateInput} from './DateInput';
+import {InternationalizationProvider} from '../i18n';
+
+const HOVER_CAPABLE = /\(\s*hover\s*:\s*hover\s*\)/;
+
+/**
+ * Astryx's touch picker mounts a month scroller that observes its own size;
+ * jsdom ships no ResizeObserver. Only the `nativePicker="never"` test reaches
+ * it, but stubbing it for the file keeps that test honest about which surface
+ * it got.
+ */
+class MockResizeObserver {
+  observe() {}
+  unobserve() {}
+  disconnect() {}
+}
+
+/** Point `(pointer: coarse)` at a touch or mouse device. */
+function stubPointer(isCoarse: boolean): void {
+  vi.stubGlobal('matchMedia', (query: string) => ({
+    matches: /pointer:\s*coarse/.test(query)
+      ? isCoarse
+      : /pointer:\s*fine/.test(query)
+        ? !isCoarse
+        : HOVER_CAPABLE.test(query),
+    media: query,
+    onchange: null,
+    addListener: () => {},
+    removeListener: () => {},
+    addEventListener: () => {},
+    removeEventListener: () => {},
+    dispatchEvent: () => false,
+  }));
+}
+
+function getInput(): HTMLInputElement {
+  const input = document.querySelector('input');
+  if (!input) {
+    throw new Error('DateInput rendered no input element');
+  }
+  return input;
+}
+
+/** The CSS rules that apply to an element, for the paint-level assertions. */
+function rulesFor(el: Element): string {
+  const classes = new Set(el.className.split(/\s+/).filter(Boolean));
+  return Array.from(document.styleSheets)
+    .flatMap(sheet => {
+      try {
+        return Array.from(sheet.cssRules);
+      } catch {
+        return [];
+      }
+    })
+    .map(rule => rule.cssText)
+    .filter(text => [...classes].some(cls => text.includes(`.${cls}`)))
+    .join(' ');
+}
+
+beforeEach(() => {
+  vi.stubGlobal('ResizeObserver', MockResizeObserver);
+});
+
+afterEach(() => {
+  vi.unstubAllGlobals();
+  vi.restoreAllMocks();
+});
+
+describe('DateInput nativePicker', () => {
+  // ===========================================================================
+  // Which surface renders
+  // ===========================================================================
+
+  it('renders the native control on touch by default', () => {
+    stubPointer(true);
+    render(<DateInput label="Date" onChange={() => {}} />);
+
+    expect(getInput()).toHaveAttribute('type', 'date');
+  });
+
+  it('keeps the calendar popover on a mouse-driven device', () => {
+    stubPointer(false);
+    render(<DateInput label="Date" onChange={() => {}} />);
+
+    const input = getInput();
+    expect(input).toHaveAttribute('type', 'text');
+    expect(input).toHaveAttribute('role', 'combobox');
+  });
+
+  it('falls back to Astryx\u2019s touch picker when told never', () => {
+    stubPointer(true);
+    render(<DateInput label="Date" nativePicker="never" onChange={() => {}} />);
+
+    const input = getInput();
+    expect(input).toHaveAttribute('type', 'text');
+    expect(input).toHaveAttribute('role', 'combobox');
+  });
+
+  it('uses the native control on a mouse device when told always', () => {
+    stubPointer(false);
+    render(
+      <DateInput label="Date" nativePicker="always" onChange={() => {}} />,
+    );
+
+    expect(getInput()).toHaveAttribute('type', 'date');
+  });
+
+  it('drops the popup ARIA the other surfaces carry', () => {
+    // There is no in-page popup to describe: the OS draws the picker.
+    stubPointer(true);
+    render(<DateInput label="Date" onChange={() => {}} />);
+
+    const input = getInput();
+    expect(input).not.toHaveAttribute('role', 'combobox');
+    expect(input).not.toHaveAttribute('aria-expanded');
+    expect(input).not.toHaveAttribute('aria-haspopup');
+  });
+
+  // ===========================================================================
+  // Value round-trip
+  // ===========================================================================
+
+  it('keeps the control\u2019s own value ISO', () => {
+    stubPointer(true);
+    render(
+      <DateInput
+        label="Date"
+        value="2026-01-25"
+        format="date_long"
+        onChange={() => {}}
+      />,
+    );
+
+    // ISO is the only form the control accepts, and what the picker reads and
+    // writes; `format` rides on the overlay instead.
+    expect(getInput()).toHaveValue('2026-01-25');
+    expect(screen.getByText('January 25, 2026')).toBeInTheDocument();
+  });
+
+  it('fires onChange with the ISO date the control reports', () => {
+    stubPointer(true);
+    const onChange = vi.fn();
+    render(<DateInput label="Date" onChange={onChange} />);
+
+    fireEvent.change(getInput(), {target: {value: '2026-03-21'}});
+
+    expect(onChange).toHaveBeenCalledExactlyOnceWith('2026-03-21');
+  });
+
+  it('fires onChange with undefined when the control is emptied', () => {
+    stubPointer(true);
+    const onChange = vi.fn();
+    render(
+      <DateInput label="Date" value="2026-03-21" onChange={onChange} />,
+    );
+
+    fireEvent.change(getInput(), {target: {value: ''}});
+
+    expect(onChange).toHaveBeenCalledWith(undefined);
+  });
+
+  it('commits an edit React\u2019s synthetic change does not see', () => {
+    // The iOS failure, reproduced: the picker edits the field and a native
+    // `input` event fires, but React's synthetic `onChange` never runs — so
+    // React re-renders and writes its stale value back over the picker's.
+    // Assigning `.value` first updates React's internal value tracker, which
+    // is what makes React skip the synthetic event; the native listener still
+    // sees the real one.
+    stubPointer(true);
+    const onChange = vi.fn();
+    render(
+      <DateInput label="Date" value="2026-03-21" onChange={onChange} />,
+    );
+
+    const input = getInput();
+    input.value = '2026-03-09';
+    input.dispatchEvent(new Event('input', {bubbles: true}));
+
+    expect(onChange).toHaveBeenCalledExactlyOnceWith('2026-03-09');
+  });
+
+  it('fires one change when both commit paths see the same edit', () => {
+    stubPointer(true);
+    const onChange = vi.fn();
+    render(
+      <DateInput label="Date" value="2026-03-21" onChange={onChange} />,
+    );
+
+    fireEvent.change(getInput(), {target: {value: '2026-03-09'}});
+
+    expect(onChange).toHaveBeenCalledExactlyOnceWith('2026-03-09');
+  });
+
+  it('does not write to the control while it has focus', () => {
+    // The iOS bug this guards: while the picker sheet is open, ANY
+    // programmatic write to the field detaches the sheet from it, and the
+    // user's pick silently stops reaching the input.
+    stubPointer(true);
+    const {rerender} = render(
+      <DateInput label="Date" value="2026-03-21" onChange={() => {}} />,
+    );
+    const input = getInput();
+
+    fireEvent.focus(input);
+    rerender(
+      <DateInput label="Date" value="2026-12-25" onChange={() => {}} />,
+    );
+
+    expect(input).toHaveValue('2026-03-21');
+  });
+
+  it('applies an external value once the control loses focus', () => {
+    stubPointer(true);
+    const {rerender} = render(
+      <DateInput label="Date" value="2026-03-21" onChange={() => {}} />,
+    );
+    const input = getInput();
+
+    fireEvent.focus(input);
+    rerender(
+      <DateInput label="Date" value="2026-12-25" onChange={() => {}} />,
+    );
+    fireEvent.blur(input);
+
+    expect(input).toHaveValue('2026-12-25');
+  });
+
+  // ===========================================================================
+  // Constraints
+  // ===========================================================================
+
+  it('forwards min and max to the native control', () => {
+    stubPointer(true);
+    render(
+      <DateInput
+        label="Date"
+        min="2026-01-01"
+        max="2026-12-31"
+        onChange={() => {}}
+      />,
+    );
+
+    const input = getInput();
+    expect(input).toHaveAttribute('min', '2026-01-01');
+    expect(input).toHaveAttribute('max', '2026-12-31');
+  });
+
+  it('refuses an out-of-range date and announces it', () => {
+    // iOS does not enforce min/max in its picker — it lets the user land on
+    // any date — so the refusal has to happen here.
+    stubPointer(true);
+    const onChange = vi.fn();
+    render(
+      <DateInput
+        label="Date"
+        min="2026-03-10"
+        max="2026-03-20"
+        value="2026-03-15"
+        onChange={onChange}
+      />,
+    );
+
+    fireEvent.change(getInput(), {target: {value: '2026-03-25'}});
+
+    expect(onChange).not.toHaveBeenCalled();
+    expect(screen.getByRole('alert')).toHaveTextContent('Invalid date');
+    expect(getInput()).toHaveAttribute('aria-invalid', 'true');
+  });
+
+  it('refuses a date dateConstraints rejects', () => {
+    stubPointer(true);
+    const onChange = vi.fn();
+    render(
+      <DateInput
+        label="Date"
+        // 2026-03-22 is a Sunday.
+        dateConstraints={[date => date.getDay() !== 0]}
+        value="2026-03-23"
+        onChange={onChange}
+      />,
+    );
+
+    fireEvent.change(getInput(), {target: {value: '2026-03-22'}});
+
+    expect(onChange).not.toHaveBeenCalled();
+    expect(screen.getByRole('alert')).toHaveTextContent('Invalid date');
+  });
+
+  it('drops the rejection once the field reverts', () => {
+    // The refused date is reverted the moment focus leaves, so the field is
+    // showing a valid date again. Marking that date invalid would be a lie
+    // about data the user never chose.
+    stubPointer(true);
+    render(
+      <DateInput
+        label="Date"
+        dateConstraints={[date => date.getDay() !== 0]}
+        value="2026-03-23"
+        onChange={() => {}}
+      />,
+    );
+
+    const input = getInput();
+    fireEvent.focus(input);
+    fireEvent.change(input, {target: {value: '2026-03-22'}});
+    expect(input).toHaveAttribute('aria-invalid', 'true');
+
+    fireEvent.blur(input);
+
+    expect(input).toHaveValue('2026-03-23');
+    expect(input).not.toHaveAttribute('aria-invalid');
+    expect(screen.getByRole('alert')).toHaveTextContent('');
+  });
+
+  // ===========================================================================
+  // The text overlay: format, placeholder, paint
+  // ===========================================================================
+
+  it('honours every named format', () => {
+    stubPointer(true);
+    const {rerender} = render(
+      <DateInput
+        label="Date"
+        value="2026-01-25"
+        format="date"
+        onChange={() => {}}
+      />,
+    );
+    expect(screen.getByText('Jan 25, 2026')).toBeInTheDocument();
+
+    rerender(
+      <DateInput
+        label="Date"
+        value="2026-01-25"
+        format="date_weekday"
+        onChange={() => {}}
+      />,
+    );
+    expect(screen.getByText('Sun, Jan 25, 2026')).toBeInTheDocument();
+  });
+
+  it('honours a function format', () => {
+    stubPointer(true);
+    render(
+      <DateInput
+        label="Date"
+        value="2026-01-25"
+        format={iso => `ships ${iso}`}
+        onChange={() => {}}
+      />,
+    );
+
+    expect(screen.getByText('ships 2026-01-25')).toBeInTheDocument();
+  });
+
+  it('formats in the provider locale', () => {
+    stubPointer(true);
+    render(
+      <InternationalizationProvider locale="de-DE">
+        <DateInput label="Date" value="2026-03-21" onChange={() => {}} />
+      </InternationalizationProvider>,
+    );
+
+    expect(screen.getByText('21. März 2026')).toBeInTheDocument();
+    expect(getInput()).toHaveValue('2026-03-21');
+  });
+
+  it('keeps painting the value while the picker is open', () => {
+    // The OS picker has no segments to reveal, so `format` holds throughout.
+    stubPointer(true);
+    render(
+      <DateInput label="Date" value="2026-01-25" onChange={() => {}} />,
+    );
+
+    fireEvent.focus(getInput());
+
+    expect(screen.getByText('January 25, 2026')).toBeInTheDocument();
+  });
+
+  it('shows the placeholder when empty, and drops it when filled', () => {
+    stubPointer(true);
+    const {rerender} = render(
+      <DateInput label="Date" onChange={() => {}} />,
+    );
+    expect(screen.getByText('Select a date')).toBeInTheDocument();
+
+    rerender(
+      <DateInput label="Date" value="2026-01-25" onChange={() => {}} />,
+    );
+
+    expect(screen.queryByText('Select a date')).toBeNull();
+  });
+
+  it('keeps the overlay out of the accessibility tree', () => {
+    // The input still holds the value and carries the label, so announcing
+    // the overlay too would double-speak.
+    stubPointer(true);
+    render(
+      <DateInput label="Date" value="2026-01-25" onChange={() => {}} />,
+    );
+
+    expect(screen.getByText('January 25, 2026')).toHaveAttribute(
+      'aria-hidden',
+      'true',
+    );
+  });
+
+  it('hides the engine\u2019s own text under the overlay', () => {
+    stubPointer(true);
+    render(
+      <DateInput label="Date" value="2026-01-25" onChange={() => {}} />,
+    );
+
+    const rules = rulesFor(getInput());
+    // One transparent colour covers Chromium's `::-webkit-datetime-edit` and
+    // Firefox's plain text; `-webkit-text-fill-color` is what wins in WebKit.
+    expect(rules).toContain('color: transparent');
+    expect(rules).toContain('-webkit-text-fill-color: transparent');
+  });
+
+  it('bounds the overlay so a long date cannot paint past it', () => {
+    stubPointer(true);
+    render(
+      <DateInput
+        label="Date"
+        value="2026-09-30"
+        hasClear
+        onChange={() => {}}
+      />,
+    );
+
+    const rules = rulesFor(screen.getByText('September 30, 2026'));
+    // Without the end inset the overlay is shrink-to-fit and a long date runs
+    // over the clear button — measured 24px across it on an iPhone.
+    expect(rules).toContain('inset-inline-end: 0');
+    // `text-overflow` only applies to a BLOCK container: on a flex one a
+    // too-long date hard-clips mid-glyph instead (measured identical to
+    // `text-overflow: clip` in WebKit and Chromium). Centring then comes from
+    // the line box, so the overlay must carry the input's own leading.
+    expect(rules).toContain('display: block');
+    expect(rules).toContain('text-overflow: ellipsis');
+    expect(rules).toContain('line-height: var(--text-body-leading)');
+  });
+
+  // ===========================================================================
+  // Toggle, clear, disabled
+  // ===========================================================================
+
+  it('asks the browser for its picker from the toggle button', () => {
+    stubPointer(true);
+    render(<DateInput label="Date" onChange={() => {}} />);
+
+    const input = getInput();
+    const showPicker = vi.fn();
+    // jsdom implements no picker; attach one so the call is observable.
+    (input as HTMLInputElement & {showPicker: () => void}).showPicker =
+      showPicker;
+
+    fireEvent.click(screen.getByLabelText('Open calendar'));
+
+    expect(showPicker).toHaveBeenCalledTimes(1);
+    expect(input).toHaveFocus();
+  });
+
+  it('survives a browser that refuses showPicker', () => {
+    // Chrome throws NotAllowedError without transient user activation, and
+    // iOS implements no showPicker for type=date at all. Focus is the
+    // fallback, and on iOS it is the whole mechanism.
+    stubPointer(true);
+    render(<DateInput label="Date" onChange={() => {}} />);
+
+    const input = getInput();
+    (input as HTMLInputElement & {showPicker: () => void}).showPicker = () => {
+      throw new DOMException('not allowed', 'NotAllowedError');
+    };
+
+    expect(() =>
+      fireEvent.click(screen.getByLabelText('Open calendar')),
+    ).not.toThrow();
+    expect(input).toHaveFocus();
+  });
+
+  it('clears the value without taking focus back', () => {
+    // Focusing a date control is what raises the OS picker, so reclaiming
+    // focus would pop the wheel the clear tap just dismissed.
+    stubPointer(true);
+    const onChange = vi.fn();
+    render(
+      <DateInput
+        label="Date"
+        value="2026-03-21"
+        hasClear
+        onChange={onChange}
+      />,
+    );
+
+    fireEvent.click(screen.getByLabelText('Clear Date'));
+
+    expect(onChange).toHaveBeenCalledWith(undefined);
+    expect(getInput()).not.toHaveFocus();
+  });
+
+  it('disables the control and its toggle when isDisabled', () => {
+    stubPointer(true);
+    render(<DateInput label="Date" isDisabled onChange={() => {}} />);
+
+    expect(getInput()).toBeDisabled();
+    expect(screen.getByLabelText('Open calendar')).toBeDisabled();
+  });
+
+  it('ignores a change while disabled', () => {
+    stubPointer(true);
+    const onChange = vi.fn();
+    render(
+      <DateInput
+        label="Date"
+        isDisabled
+        disabledMessage="Ask an editor"
+        onChange={onChange}
+      />,
+    );
+
+    // With a disabledMessage the field stays focusable via aria-disabled, so
+    // the mutation guard is what has to hold.
+    fireEvent.change(getInput(), {target: {value: '2026-03-21'}});
+
+    expect(onChange).not.toHaveBeenCalled();
+  });
+
+  it('keeps the field labelled, required-marked, and ref-forwarded', () => {
+    stubPointer(true);
+    const ref = vi.fn();
+    render(
+      <DateInput ref={ref} label="Event date" isRequired onChange={() => {}} />,
+    );
+
+    const input = screen.getByLabelText(/Event date/);
+    expect(input).toHaveAttribute('type', 'date');
+    expect(input).toHaveAttribute('aria-required', 'true');
+    expect(ref).toHaveBeenCalledWith(expect.any(HTMLInputElement));
+  });
+});