@astryxdesign/core 0.4.6 → 0.4.7-canary.29be96d

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (197) hide show
  1. package/CHANGELOG.md +35 -0
  2. package/dist/BottomSheet/BottomSheet.d.ts +1 -0
  3. package/dist/BottomSheet/BottomSheet.d.ts.map +1 -1
  4. package/dist/BottomSheet/BottomSheet.js +54 -15
  5. package/dist/BottomSheet/BottomSheetEdgeTint.d.ts +6 -0
  6. package/dist/BottomSheet/BottomSheetEdgeTint.d.ts.map +1 -0
  7. package/dist/BottomSheet/BottomSheetEdgeTint.js +62 -0
  8. package/dist/BottomSheet/BottomSheetPanel.d.ts.map +1 -1
  9. package/dist/BottomSheet/BottomSheetPanel.js +1 -0
  10. package/dist/BottomSheet/BottomSheetSwitcher.d.ts +1 -0
  11. package/dist/BottomSheet/BottomSheetSwitcher.d.ts.map +1 -1
  12. package/dist/BottomSheet/BottomSheetSwitcher.js +10 -4
  13. package/dist/BottomSheet/useSheetGestures.d.ts.map +1 -1
  14. package/dist/BottomSheet/useSheetGestures.js +23 -5
  15. package/dist/Breadcrumbs/BreadcrumbItem.d.ts.map +1 -1
  16. package/dist/Breadcrumbs/BreadcrumbItem.js +5 -5
  17. package/dist/Calendar/Calendar.d.ts +3 -1
  18. package/dist/Calendar/Calendar.d.ts.map +1 -1
  19. package/dist/Calendar/Calendar.js +13 -14
  20. package/dist/Calendar/getInitialFocusDate.d.ts +46 -0
  21. package/dist/Calendar/getInitialFocusDate.d.ts.map +1 -0
  22. package/dist/Calendar/getInitialFocusDate.js +62 -0
  23. package/dist/Chat/ChatMessageList.d.ts +22 -3
  24. package/dist/Chat/ChatMessageList.d.ts.map +1 -1
  25. package/dist/Chat/ChatMessageList.js +6 -3
  26. package/dist/DateInput/TouchDateField.d.ts.map +1 -1
  27. package/dist/DateInput/TouchDateField.js +34 -1
  28. package/dist/Dialog/Dialog.d.ts +7 -1
  29. package/dist/Dialog/Dialog.d.ts.map +1 -1
  30. package/dist/Dialog/Dialog.js +48 -22
  31. package/dist/Heading/Heading.d.ts.map +1 -1
  32. package/dist/Heading/Heading.js +6 -2
  33. package/dist/Kbd/Kbd.d.ts.map +1 -1
  34. package/dist/Kbd/Kbd.js +10 -3
  35. package/dist/Markdown/index.d.ts +1 -1
  36. package/dist/Markdown/index.d.ts.map +1 -1
  37. package/dist/Markdown/parser.d.ts +38 -1
  38. package/dist/Markdown/parser.d.ts.map +1 -1
  39. package/dist/Markdown/parser.js +149 -23
  40. package/dist/MultiSelector/MultiSelector.d.ts +15 -1
  41. package/dist/MultiSelector/MultiSelector.d.ts.map +1 -1
  42. package/dist/MultiSelector/MultiSelector.js +17 -6
  43. package/dist/MultiSelector/index.d.ts +1 -1
  44. package/dist/MultiSelector/index.d.ts.map +1 -1
  45. package/dist/Selector/Selector.d.ts.map +1 -1
  46. package/dist/Selector/Selector.js +5 -0
  47. package/dist/Stepper/Step.d.ts +140 -0
  48. package/dist/Stepper/Step.d.ts.map +1 -0
  49. package/dist/Stepper/Step.js +1045 -0
  50. package/dist/Stepper/StepStatus.d.ts +24 -0
  51. package/dist/Stepper/StepStatus.d.ts.map +1 -0
  52. package/dist/Stepper/StepStatus.js +1 -0
  53. package/dist/Stepper/Stepper.d.ts +93 -0
  54. package/dist/Stepper/Stepper.d.ts.map +1 -0
  55. package/dist/Stepper/Stepper.js +184 -0
  56. package/dist/Stepper/StepperContext.d.ts +41 -0
  57. package/dist/Stepper/StepperContext.d.ts.map +1 -0
  58. package/dist/Stepper/StepperContext.js +34 -0
  59. package/dist/Stepper/index.d.ts +8 -0
  60. package/dist/Stepper/index.d.ts.map +1 -0
  61. package/dist/Stepper/index.js +7 -0
  62. package/dist/Stepper/stepper.stylex.d.ts +15 -0
  63. package/dist/Stepper/stepper.stylex.d.ts.map +1 -0
  64. package/dist/Stepper/stepper.stylex.js +20 -0
  65. package/dist/TabList/Tab.d.ts.map +1 -1
  66. package/dist/TabList/Tab.js +5 -1
  67. package/dist/Table/BaseTable.d.ts.map +1 -1
  68. package/dist/Table/BaseTable.js +4 -1
  69. package/dist/Table/plugins/groupedRows/useTableGroupedRows.d.ts.map +1 -1
  70. package/dist/Table/plugins/groupedRows/useTableGroupedRows.js +20 -8
  71. package/dist/Table/plugins/rowStatus/useTableRowStatus.d.ts.map +1 -1
  72. package/dist/Table/plugins/rowStatus/useTableRowStatus.js +10 -3
  73. package/dist/Table/plugins/selection/useTableSelection.d.ts +16 -0
  74. package/dist/Table/plugins/selection/useTableSelection.d.ts.map +1 -1
  75. package/dist/Table/plugins/selection/useTableSelection.js +19 -5
  76. package/dist/Table/types.d.ts +22 -4
  77. package/dist/Table/types.d.ts.map +1 -1
  78. package/dist/Table/useBaseTablePlugins.d.ts.map +1 -1
  79. package/dist/Table/useBaseTablePlugins.js +5 -0
  80. package/dist/Text/Text.d.ts.map +1 -1
  81. package/dist/Text/Text.js +6 -2
  82. package/dist/astryx.css +41 -1
  83. package/dist/hooks/index.d.ts +1 -0
  84. package/dist/hooks/index.d.ts.map +1 -1
  85. package/dist/hooks/index.js +1 -0
  86. package/dist/hooks/useHotkeys.d.ts.map +1 -1
  87. package/dist/hooks/useHotkeys.js +10 -3
  88. package/dist/hooks/useListFocus.d.ts +5 -2
  89. package/dist/hooks/useListFocus.d.ts.map +1 -1
  90. package/dist/hooks/useListFocus.js +12 -6
  91. package/dist/hooks/useMergedRefs.d.ts +18 -0
  92. package/dist/hooks/useMergedRefs.d.ts.map +1 -0
  93. package/dist/hooks/useMergedRefs.js +25 -0
  94. package/dist/index.d.ts +1 -0
  95. package/dist/index.d.ts.map +1 -1
  96. package/dist/index.js +1 -0
  97. package/dist/utils/timeParser.d.ts +1 -1
  98. package/dist/utils/timeParser.d.ts.map +1 -1
  99. package/dist/utils/timeParser.js +26 -12
  100. package/locales/en.json +14 -6
  101. package/locales/pseudo.json +6 -0
  102. package/package.json +8 -3
  103. package/src/Avatar/Avatar.doc.mjs +2 -1
  104. package/src/BottomSheet/BottomSheet.test.tsx +123 -0
  105. package/src/BottomSheet/BottomSheet.tsx +36 -4
  106. package/src/BottomSheet/BottomSheetEdgeTint.test.tsx +225 -0
  107. package/src/BottomSheet/BottomSheetEdgeTint.tsx +82 -0
  108. package/src/BottomSheet/BottomSheetPanel.test.tsx +66 -0
  109. package/src/BottomSheet/BottomSheetPanel.tsx +19 -0
  110. package/src/BottomSheet/BottomSheetSwitcher.tsx +13 -0
  111. package/src/BottomSheet/useSheetGestures.test.ts +27 -0
  112. package/src/BottomSheet/useSheetGestures.ts +25 -5
  113. package/src/Breadcrumbs/BreadcrumbItem.tsx +2 -1
  114. package/src/Button/Button.doc.mjs +22 -0
  115. package/src/Calendar/Calendar.doc.mjs +4 -3
  116. package/src/Calendar/Calendar.test.tsx +52 -0
  117. package/src/Calendar/Calendar.tsx +18 -15
  118. package/src/Calendar/getInitialFocusDate.test.ts +94 -0
  119. package/src/Calendar/getInitialFocusDate.ts +93 -0
  120. package/src/Chat/ChatMessageList.doc.mjs +9 -1
  121. package/src/Chat/ChatMessageList.test.tsx +46 -0
  122. package/src/Chat/ChatMessageList.tsx +28 -4
  123. package/src/CodeBlock/CodeBlock.doc.mjs +6 -0
  124. package/src/ContextMenu/ContextMenu.doc.mjs +5 -0
  125. package/src/DateInput/DateInputTouch.test.tsx +36 -0
  126. package/src/DateInput/TouchDateField.tsx +35 -1
  127. package/src/Dialog/Dialog.doc.mjs +8 -3
  128. package/src/Dialog/Dialog.test.tsx +71 -0
  129. package/src/Dialog/Dialog.tsx +72 -20
  130. package/src/Field/Field.doc.mjs +11 -0
  131. package/src/Heading/Heading.test.tsx +23 -1
  132. package/src/Heading/Heading.tsx +6 -2
  133. package/src/Kbd/Kbd.test.tsx +17 -0
  134. package/src/Kbd/Kbd.tsx +10 -3
  135. package/src/Link/Link.doc.mjs +11 -0
  136. package/src/Markdown/index.ts +1 -0
  137. package/src/Markdown/parser.perf.test.ts +71 -1
  138. package/src/Markdown/parser.test.ts +145 -2
  139. package/src/Markdown/parser.ts +208 -22
  140. package/src/MoreMenu/MoreMenu.doc.mjs +7 -1
  141. package/src/MultiSelector/MultiSelector.doc.mjs +10 -0
  142. package/src/MultiSelector/MultiSelector.test.tsx +105 -0
  143. package/src/MultiSelector/MultiSelector.tsx +50 -6
  144. package/src/MultiSelector/index.ts +1 -0
  145. package/src/NumberInput/NumberInput.doc.mjs +5 -0
  146. package/src/Popover/Popover.test.tsx +27 -1
  147. package/src/PowerSearch/PowerSearch.doc.mjs +10 -0
  148. package/src/Selector/Selector.doc.mjs +11 -0
  149. package/src/Selector/Selector.test.tsx +21 -0
  150. package/src/Selector/Selector.tsx +11 -1
  151. package/src/Stepper/Step.doc.mjs +98 -0
  152. package/src/Stepper/Step.tsx +1638 -0
  153. package/src/Stepper/StepStatus.ts +26 -0
  154. package/src/Stepper/Stepper.doc.mjs +370 -0
  155. package/src/Stepper/Stepper.test.tsx +1024 -0
  156. package/src/Stepper/Stepper.tsx +258 -0
  157. package/src/Stepper/StepperContext.ts +71 -0
  158. package/src/Stepper/index.ts +18 -0
  159. package/src/Stepper/stepper.stylex.ts +19 -0
  160. package/src/TabList/Tab.tsx +5 -1
  161. package/src/TabList/TabList.test.tsx +21 -4
  162. package/src/Table/BaseTable.tsx +6 -3
  163. package/src/Table/Table.test.tsx +35 -0
  164. package/src/Table/plugins/groupedRows/useTableGroupedRows-perf.test.tsx +112 -0
  165. package/src/Table/plugins/groupedRows/useTableGroupedRows.test.tsx +100 -0
  166. package/src/Table/plugins/groupedRows/useTableGroupedRows.tsx +17 -8
  167. package/src/Table/plugins/rowStatus/useTableRowStatus.test.tsx +13 -7
  168. package/src/Table/plugins/rowStatus/useTableRowStatus.tsx +12 -3
  169. package/src/Table/plugins/selection/useTableSelection.test.tsx +76 -0
  170. package/src/Table/plugins/selection/useTableSelection.tsx +40 -7
  171. package/src/Table/types.ts +22 -4
  172. package/src/Table/useBaseTablePlugins.ts +5 -0
  173. package/src/Table/useTableGroupedRows.doc.mjs +5 -4
  174. package/src/Table/useTableRowStatus.doc.mjs +1 -1
  175. package/src/Table/useTableSelection.doc.mjs +31 -0
  176. package/src/Text/Text.test.tsx +23 -1
  177. package/src/Text/Text.tsx +6 -2
  178. package/src/TextInput/TextInput.doc.mjs +10 -0
  179. package/src/Toast/Toast.doc.mjs +6 -0
  180. package/src/Tokenizer/Tokenizer.doc.mjs +10 -0
  181. package/src/Toolbar/Toolbar.doc.mjs +5 -0
  182. package/src/__tests__/apiContractDrift.test.tsx +80 -0
  183. package/src/__tests__/fieldContract.test.tsx +24 -0
  184. package/src/__tests__/structuralComponentContract.test.tsx +39 -0
  185. package/src/hooks/index.ts +2 -0
  186. package/src/hooks/useHotkeys.test.ts +18 -0
  187. package/src/hooks/useHotkeys.ts +10 -3
  188. package/src/hooks/useListFocus.doc.mjs +2 -2
  189. package/src/hooks/useListFocus.test.tsx +65 -3
  190. package/src/hooks/useListFocus.ts +15 -7
  191. package/src/hooks/useMergedRefs.doc.mjs +79 -0
  192. package/src/hooks/useMergedRefs.test.tsx +62 -0
  193. package/src/hooks/useMergedRefs.ts +36 -0
  194. package/src/index.ts +1 -0
  195. package/src/theme/MediaTheme.doc.mjs +5 -5
  196. package/src/utils/timeParser.test.ts +6 -1
  197. package/src/utils/timeParser.ts +35 -13
@@ -0,0 +1,225 @@
1
+ // Copyright (c) Meta Platforms, Inc. and affiliates.
2
+
3
+ /**
4
+ * @file BottomSheetEdgeTint.test.tsx
5
+ * @input Uses vitest, @testing-library/react, BottomSheet, BottomSheetSwitcher
6
+ * @output Tests which sheets carry the iOS Safari bottom edge tint, and pins
7
+ * the declarations WebKit's edge sampler reads
8
+ * @position Core testing; validates BottomSheetEdgeTint.tsx and its two hosts
9
+ *
10
+ * SYNC: When modified, update these files to stay in sync:
11
+ * - /packages/core/src/BottomSheet/BottomSheetEdgeTint.tsx
12
+ */
13
+
14
+ import {describe, it, expect, vi, beforeEach, afterEach} from 'vitest';
15
+ import {render} from '@testing-library/react';
16
+ import {BottomSheet} from './BottomSheet';
17
+ import {BottomSheetSwitcher} from './BottomSheetSwitcher';
18
+
19
+ // jsdom doesn't implement <dialog> open/close or pointer capture; stub them.
20
+ beforeEach(() => {
21
+ HTMLDialogElement.prototype.showModal = vi.fn(function (
22
+ this: HTMLDialogElement,
23
+ ) {
24
+ this.setAttribute('open', '');
25
+ });
26
+ HTMLDialogElement.prototype.show = vi.fn(function (this: HTMLDialogElement) {
27
+ this.setAttribute('open', '');
28
+ });
29
+ HTMLDialogElement.prototype.close = vi.fn(function (this: HTMLDialogElement) {
30
+ this.removeAttribute('open');
31
+ });
32
+ if (!Element.prototype.setPointerCapture) {
33
+ Element.prototype.setPointerCapture = vi.fn();
34
+ Element.prototype.releasePointerCapture = vi.fn();
35
+ }
36
+ vi.stubGlobal(
37
+ 'matchMedia',
38
+ vi.fn().mockReturnValue({
39
+ matches: false,
40
+ media: '',
41
+ onchange: null,
42
+ addEventListener: vi.fn(),
43
+ removeEventListener: vi.fn(),
44
+ addListener: vi.fn(),
45
+ removeListener: vi.fn(),
46
+ dispatchEvent: vi.fn(),
47
+ }),
48
+ );
49
+ vi.stubGlobal(
50
+ 'requestAnimationFrame',
51
+ vi.fn((callback: FrameRequestCallback) => {
52
+ callback(0);
53
+ return 1;
54
+ }),
55
+ );
56
+ vi.stubGlobal('cancelAnimationFrame', vi.fn());
57
+ });
58
+
59
+ afterEach(() => {
60
+ vi.unstubAllGlobals();
61
+ });
62
+
63
+ function tints(): ReadonlyArray<Element> {
64
+ return Array.from(document.querySelectorAll('[data-sheet-edge-tint]'));
65
+ }
66
+
67
+ async function edgeTintSource(): Promise<string> {
68
+ const tint = (await fullSource()).match(/\n {2}tint: \{([\s\S]*?)\n {2}\},/);
69
+ expect(tint).not.toBeNull();
70
+ return tint![1];
71
+ }
72
+
73
+ /** The tint's declarations with its explanatory comments stripped out. */
74
+ async function edgeTintDeclarations(): Promise<string> {
75
+ return (await edgeTintSource())
76
+ .split('\n')
77
+ .filter(line => !line.trim().startsWith('//'))
78
+ .join('\n');
79
+ }
80
+
81
+ async function fullSource(): Promise<string> {
82
+ const fs = await import('fs');
83
+ const path = await import('path');
84
+ return fs.readFileSync(
85
+ path.resolve(__dirname, './BottomSheetEdgeTint.tsx'),
86
+ 'utf-8',
87
+ );
88
+ }
89
+
90
+ describe('BottomSheetEdgeTint', () => {
91
+ it('gives a non-modal sheet an edge tint to colour the iOS toolbar strip', () => {
92
+ render(
93
+ <BottomSheet
94
+ isOpen
95
+ onOpenChange={() => {}}
96
+ hasScrim={false}
97
+ label="Place details">
98
+ Content
99
+ </BottomSheet>,
100
+ );
101
+ expect(tints()).toHaveLength(1);
102
+ });
103
+
104
+ // A modal sheet's ::backdrop is a case WebKit's sampler handles on its own,
105
+ // so a second sampling target there would only fight it.
106
+ it('leaves a modal sheet to its ::backdrop', () => {
107
+ render(
108
+ <BottomSheet isOpen onOpenChange={() => {}} label="Place details">
109
+ Content
110
+ </BottomSheet>,
111
+ );
112
+ expect(tints()).toHaveLength(0);
113
+ });
114
+
115
+ it('renders the tint inside the dialog, so it unmounts with the sheet', () => {
116
+ const {rerender} = render(
117
+ <BottomSheet
118
+ isOpen
119
+ onOpenChange={() => {}}
120
+ hasScrim={false}
121
+ label="Place details">
122
+ Content
123
+ </BottomSheet>,
124
+ );
125
+ const [tint] = tints();
126
+ expect(tint?.closest('dialog')).not.toBeNull();
127
+
128
+ rerender(<div />);
129
+ expect(tints()).toHaveLength(0);
130
+ });
131
+
132
+ // The switcher owns one shared dialog for the whole flow, so the tint
133
+ // belongs to that dialog and must not be minted per child sheet.
134
+ it('gives a non-modal switcher flow exactly one tint', () => {
135
+ render(
136
+ <BottomSheetSwitcher
137
+ activeSheet="comment"
138
+ hasScrim={false}
139
+ onActiveSheetChange={() => {}}>
140
+ <BottomSheet sheetId="comment" label="Add a comment">
141
+ Comment
142
+ </BottomSheet>
143
+ <BottomSheet sheetId="confirmation" label="Confirmation">
144
+ Confirmation
145
+ </BottomSheet>
146
+ </BottomSheetSwitcher>,
147
+ );
148
+ expect(tints()).toHaveLength(1);
149
+ });
150
+
151
+ it('leaves a modal switcher flow to its ::backdrop', () => {
152
+ render(
153
+ <BottomSheetSwitcher activeSheet="comment" onActiveSheetChange={() => {}}>
154
+ <BottomSheet sheetId="comment" label="Add a comment">
155
+ Comment
156
+ </BottomSheet>
157
+ </BottomSheetSwitcher>,
158
+ );
159
+ expect(tints()).toHaveLength(0);
160
+ });
161
+
162
+ it('keeps the tint out of the accessibility tree and out of hit testing', async () => {
163
+ render(
164
+ <BottomSheet
165
+ isOpen
166
+ onOpenChange={() => {}}
167
+ hasScrim={false}
168
+ label="Place details">
169
+ Content
170
+ </BottomSheet>,
171
+ );
172
+ const [tint] = tints();
173
+ expect(tint?.getAttribute('aria-hidden')).toBe('true');
174
+ expect(tint?.textContent).toBe('');
175
+ expect(await edgeTintSource()).toContain("pointerEvents: 'none'");
176
+ });
177
+
178
+ // Every declaration below is load-bearing for a heuristic that lives in
179
+ // WebKit, not in this repo, and none of it is observable in jsdom or in any
180
+ // engine without retractable browser chrome — so it is asserted on the style
181
+ // definition, the way BottomSheetPanel pins its handle gradient.
182
+ describe('the declarations WebKit samples', () => {
183
+ it('is fixed and flush with the bottom edge of the viewport', async () => {
184
+ const tint = await edgeTintSource();
185
+ // Only a fixed or sticky box is a candidate, and only a box flush with
186
+ // the edge is the one Safari hit tests.
187
+ expect(tint).toContain("position: 'fixed'");
188
+ expect(tint).toContain('insetBlockEnd: 0');
189
+ expect(tint).toContain('insetInline: 0');
190
+ });
191
+
192
+ it('clears the 10px floor below which WebKit ignores the declared colour', async () => {
193
+ const height = (await fullSource()).match(
194
+ /const SAMPLE_HEIGHT_PX = (\d+);/,
195
+ );
196
+ expect(height).not.toBeNull();
197
+ expect(Number(height![1])).toBeGreaterThan(10);
198
+ expect(await edgeTintSource()).toContain(
199
+ 'height: `${SAMPLE_HEIGHT_PX}px`',
200
+ );
201
+ });
202
+
203
+ it('declares the sheet surface colour, so the strip matches the sheet', async () => {
204
+ expect(await edgeTintSource()).toContain(
205
+ "backgroundColor: colorVars['--color-background-surface']",
206
+ );
207
+ });
208
+
209
+ // visibility: hidden, display: none and a low opacity all disqualify the
210
+ // element from sampling. A mask does not, which is the only reason the
211
+ // strip can be both readable by Safari and invisible to the user.
212
+ it('hides itself with a mask rather than with visibility or opacity', async () => {
213
+ const tint = await edgeTintDeclarations();
214
+ expect(tint).toContain(
215
+ "maskImage: 'linear-gradient(transparent, transparent)'",
216
+ );
217
+ expect(tint).toContain(
218
+ "WebkitMaskImage: 'linear-gradient(transparent, transparent)'",
219
+ );
220
+ expect(tint).not.toContain('visibility');
221
+ expect(tint).not.toContain('opacity');
222
+ expect(tint).not.toContain("display: 'none'");
223
+ });
224
+ });
225
+ });
@@ -0,0 +1,82 @@
1
+ // Copyright (c) Meta Platforms, Inc. and affiliates.
2
+
3
+ 'use client';
4
+
5
+ /**
6
+ * @file BottomSheetEdgeTint.tsx
7
+ * @input Uses StyleX and core color tokens
8
+ * @output Exports BottomSheetEdgeTint, an internal decorative element
9
+ * @position Private helper rendered inside a non-modal BottomSheet dialog
10
+ *
11
+ * iOS 26 Safari dropped `<meta name="theme-color">` and instead derives the
12
+ * colour it paints behind its translucent toolbars by sampling the page: it
13
+ * hit tests a point just inside each viewport edge, walks up to the nearest
14
+ * `fixed`/`sticky` ancestor, and extends that element's declared
15
+ * `background-color` into the browser chrome.
16
+ *
17
+ * A modal sheet is served by that heuristic already — WebKit has a dedicated
18
+ * branch for a dialog's `::backdrop`. A non-modal sheet is not: the nearest
19
+ * fixed ancestor of the panel is the sheet's own full-viewport `<dialog>`,
20
+ * which is transparent and viewport-sized, and WebKit answers a viewport-sized
21
+ * candidate by *keeping the colour it already had* — the host page's. The page
22
+ * then shows through behind the address bar while the sheet covers the screen
23
+ * above it.
24
+ *
25
+ * This element gives the heuristic something unambiguous to sample: fixed,
26
+ * full width, flush with the bottom edge, taller than WebKit's 10px minimum
27
+ * for reading a declared colour, and painted in the sheet's own surface
28
+ * colour. It is masked out so it never renders for the user; Safari reads the
29
+ * computed style, not the painted pixels.
30
+ *
31
+ * Everywhere else it is inert decoration.
32
+ *
33
+ * SYNC: When modified, update these files to stay in sync:
34
+ * - /packages/core/src/BottomSheet/BottomSheet.tsx
35
+ * - /packages/core/src/BottomSheet/BottomSheetSwitcher.tsx
36
+ * - /packages/core/src/BottomSheet/BottomSheetEdgeTint.test.tsx
37
+ */
38
+
39
+ import * as stylex from '@stylexjs/stylex';
40
+ import {colorVars} from '../theme/tokens.stylex';
41
+
42
+ /**
43
+ * WebKit ignores the declared `background-color` of a sampled box thinner than
44
+ * 10px and falls back to sampling painted pixels, which a masked element has
45
+ * none of. 12px clears that floor with room to spare and is still far below
46
+ * the ~40px of chrome it colours.
47
+ */
48
+ const SAMPLE_HEIGHT_PX = 12;
49
+
50
+ const styles = stylex.create({
51
+ tint: {
52
+ position: 'fixed',
53
+ insetInline: 0,
54
+ insetBlockEnd: 0,
55
+ height: `${SAMPLE_HEIGHT_PX}px`,
56
+ backgroundColor: colorVars['--color-background-surface'],
57
+ // Above the panel so the edge hit test lands here, and never in the way of
58
+ // a touch that was meant for the sheet.
59
+ zIndex: 2,
60
+ pointerEvents: 'none',
61
+ // Invisible to the user. WebKit's sampler checks `visibility` and
62
+ // `opacity` — either would disqualify the element — but not `mask`, so
63
+ // this hides the strip while leaving the colour readable. Without it the
64
+ // strip would show as a hairline under the panel as the sheet slides out.
65
+ maskImage: 'linear-gradient(transparent, transparent)',
66
+ WebkitMaskImage: 'linear-gradient(transparent, transparent)',
67
+ },
68
+ });
69
+
70
+ /**
71
+ * Colours the iOS Safari toolbar strip below a non-modal sheet. Renders
72
+ * nothing visible; see the file header for why it exists.
73
+ */
74
+ export function BottomSheetEdgeTint() {
75
+ return (
76
+ <div
77
+ {...stylex.props(styles.tint)}
78
+ data-sheet-edge-tint=""
79
+ aria-hidden="true"
80
+ />
81
+ );
82
+ }
@@ -328,4 +328,70 @@ describe('BottomSheetPanel', () => {
328
328
  "backgroundColor: colorVars['--color-background-surface']",
329
329
  );
330
330
  });
331
+
332
+ /**
333
+ * The exit is not the entrance played backwards.
334
+ *
335
+ * `--ease-standard` is a decelerate curve: on it the sheet was half gone in
336
+ * 59ms of a 410ms transition and 90% gone in 163ms, so the close was over
337
+ * before it could be seen. The closing state therefore carries its own
338
+ * accelerating curve, and only the closing state does.
339
+ */
340
+ it('closes on an accelerating curve of its own, not the entrance timing', () => {
341
+ const declarationsFor = (element: HTMLElement) => {
342
+ const classes = new Set(element.className.split(/\s+/));
343
+ const out: string[] = [];
344
+ for (const styleSheet of Array.from(document.styleSheets)) {
345
+ let rules: CSSRuleList;
346
+ try {
347
+ rules = styleSheet.cssRules;
348
+ } catch {
349
+ continue;
350
+ }
351
+ for (const rule of Array.from(rules)) {
352
+ const selector = (rule as CSSStyleRule).selectorText;
353
+ const owner = selector?.match(/^\.([\w-]+)/)?.[1];
354
+ if (owner != null && classes.has(owner)) {
355
+ out.push(rule.cssText);
356
+ }
357
+ }
358
+ }
359
+ return out.join('\n');
360
+ };
361
+
362
+ const {container: closing} = render(
363
+ <BottomSheetPanel
364
+ state={{kind: 'exiting'}}
365
+ height="hug"
366
+ onDismiss={() => {}}
367
+ onScrimOpacity={() => {}}>
368
+ Panel content
369
+ </BottomSheetPanel>,
370
+ );
371
+ const closingRules = declarationsFor(
372
+ closing.querySelector('.astryx-bottom-sheet') as HTMLElement,
373
+ );
374
+ // An accelerating curve: no vertical rise at the start (y1 = 0), so the
375
+ // travel lands inside the duration instead of ahead of it.
376
+ expect(closingRules).toContain(
377
+ 'transition-timing-function: cubic-bezier(.3,0,.6,.6)',
378
+ );
379
+
380
+ const {container: resting} = render(
381
+ <BottomSheetPanel
382
+ state={{kind: 'open', entering: false}}
383
+ height="hug"
384
+ onDismiss={() => {}}
385
+ onScrimOpacity={() => {}}>
386
+ Panel content
387
+ </BottomSheetPanel>,
388
+ );
389
+ const restingRules = declarationsFor(
390
+ resting.querySelector('.astryx-bottom-sheet') as HTMLElement,
391
+ );
392
+ expect(restingRules).toContain(
393
+ 'transition-timing-function: var(--ease-standard)',
394
+ );
395
+ expect(restingRules).not.toContain('cubic-bezier(.3,0,.6,.6)');
396
+ });
331
397
  });
@@ -149,8 +149,27 @@ const styles = stylex.create({
149
149
  transitionDuration: '0.01s',
150
150
  },
151
151
  },
152
+ /**
153
+ * The exit is its own motion, not the entrance played backwards.
154
+ *
155
+ * `--ease-standard` is `cubic-bezier(0.24, 1, 0.4, 1)`, a decelerate curve:
156
+ * it spends its speed immediately and coasts. That is right for an entrance,
157
+ * where the sheet arrives fast and settles, and wrong for an exit. Measured
158
+ * on device, it put the sheet half off-screen in 59ms of a 410ms close and
159
+ * 90% off in 163ms -- the travel is over before the eye has followed it, and
160
+ * the rest of the duration moves pixels already below the fold.
161
+ *
162
+ * An exit accelerates instead: away from rest, gathering speed, quickest as
163
+ * it leaves the screen. The curve is deliberately gentle rather than a hard
164
+ * `ease-in` -- it is moving within ~50ms, so the close reads as one
165
+ * departure rather than a hesitation and a snap. The duration is the
166
+ * entrance's own band, so only the curve differs between the two
167
+ * directions; a shorter band leaves too little visible travel once a theme
168
+ * scales the motion scale down (neutral's medium is 300ms against 410ms).
169
+ */
152
170
  sheetClosing: {
153
171
  transform: 'translateY(100%)',
172
+ transitionTimingFunction: 'cubic-bezier(0.3, 0, 0.6, 0.6)',
154
173
  },
155
174
  sheetFading: {
156
175
  opacity: 0,
@@ -22,6 +22,7 @@
22
22
  *
23
23
  * SYNC: When modified, update these files to stay in sync:
24
24
  * - /packages/core/src/BottomSheet/BottomSheet.tsx
25
+ * - /packages/core/src/BottomSheet/BottomSheetEdgeTint.tsx
25
26
  * - /packages/core/src/BottomSheet/BottomSheetSwitcher.doc.mjs
26
27
  * - /packages/core/src/BottomSheet/BottomSheetSwitcher.test.tsx
27
28
  * - /packages/core/src/BottomSheet/index.ts
@@ -51,6 +52,7 @@ import {
51
52
  useScrollLock,
52
53
  } from '../hooks';
53
54
  import {composeEventHandlers, mergeProps, mergeRefs} from '../utils';
55
+ import {BottomSheetEdgeTint} from './BottomSheetEdgeTint';
54
56
  import {
55
57
  BottomSheetSwitcherContext,
56
58
  type BottomSheetSwitcherContextValue,
@@ -103,6 +105,14 @@ const styles = stylex.create({
103
105
  },
104
106
  },
105
107
  },
108
+ // The flow's dim leaves with its last panel. Same rule, same reasoning, as
109
+ // a standalone sheet's -- see `scrimClosing` in BottomSheet.tsx. A handoff
110
+ // between two sheets is not a close, and keeps the entrance curve.
111
+ scrimClosing: {
112
+ '::backdrop': {
113
+ transitionTimingFunction: 'linear',
114
+ },
115
+ },
106
116
  });
107
117
 
108
118
  type RetainedSheetPhase = 'covered' | 'aligning' | 'fading' | 'exiting';
@@ -593,6 +603,7 @@ export function BottomSheetSwitcher({
593
603
  styles.dialog,
594
604
  isFlowVisible && styles.dialogOpen,
595
605
  hasScrim && styles.scrim,
606
+ hasScrim && isFlowVisible && activeSheet == null && styles.scrimClosing,
596
607
  !hasScrim && styles.dialogNonModal,
597
608
  xstyle,
598
609
  );
@@ -620,6 +631,8 @@ export function BottomSheetSwitcher({
620
631
  ? {role: 'alertdialog'}
621
632
  : undefined)}>
622
633
  {children}
634
+ {/* A modal flow's ::backdrop already answers Safari's edge sampler. */}
635
+ {hasScrim ? null : <BottomSheetEdgeTint />}
623
636
  </dialog>
624
637
  </BottomSheetSwitcherContext>
625
638
  );
@@ -530,6 +530,33 @@ describe('useSheetGestures', () => {
530
530
  expect(hook.result.current.dragOffset).toBe(40);
531
531
  });
532
532
 
533
+ /**
534
+ * A finger is never still. Tapping a control inside the sheet drifts a
535
+ * pixel or two, and with no slop that drift promoted to a sheet drag —
536
+ * which wrote `transition: none` onto the panel across the release, so the
537
+ * close the tap triggered cut instead of animating. That is the "the sheet
538
+ * closes with no animation" report: only on a tap, and only on a tap
539
+ * inside the sheet (the scrim never arms a drag).
540
+ */
541
+ it('treats a few pixels of finger drift as a tap, not a drag', () => {
542
+ const {hook} = setup({snapHeights: () => [200]});
543
+ const body = makeBody(0); // at the top, where a pull-down would promote
544
+ bodyDown(hook, 0, 0, body);
545
+ bodyMove(hook, 3, 40, body); // the drift of a finger tapping a button
546
+ expect(hook.result.current.isDragging).toBe(false);
547
+ // and nothing suppressed the panel's transition, so a close that lands
548
+ // now still animates
549
+ expect(hook.result.current.contentProps.style.transition).toBeUndefined();
550
+ });
551
+
552
+ it('still promotes once the pull passes the tap slop', () => {
553
+ const {hook} = setup({snapHeights: () => [200]});
554
+ const body = makeBody(0);
555
+ bodyDown(hook, 0, 0, body);
556
+ bodyMove(hook, 9, 40, body); // just past the 8px slop
557
+ expect(hook.result.current.isDragging).toBe(true);
558
+ });
559
+
533
560
  it('does not hijack scrolling when the body is scrolled down', () => {
534
561
  const {hook} = setup({snapHeights: () => [200]});
535
562
  const body = makeBody(120); // scrolled, not at the top
@@ -118,6 +118,20 @@ const OVERSCROLL_MAX = 48;
118
118
  // the scroll, large enough that a swipe merely coming to rest on the last pixel
119
119
  // doesn't start a drag on jitter.
120
120
  const CONTENT_END_HANDOFF_SLOP = 4;
121
+ // How far a finger resting on the body must travel before the pull becomes a
122
+ // sheet drag rather than a tap.
123
+ //
124
+ // This used to be zero: any downward movement promoted. A finger is never
125
+ // still, so tapping a control inside the sheet drifted a pixel or two and
126
+ // started a drag -- which suppresses the panel's transition, correctly, for as
127
+ // long as the sheet is tracking the finger. The close that the tap triggered
128
+ // then landed inside that window and cut instead of animating. A deliberate
129
+ // pull was unaffected; only a tap, and only a tap inside the sheet, since the
130
+ // scrim is outside the body and arms nothing.
131
+ //
132
+ // 8px is the conventional tap slop, a shade over iOS's own recognizer, and
133
+ // well under what a real pull covers in its first frames.
134
+ const DRAG_PROMOTION_SLOP = 8;
121
135
 
122
136
  // Short haptic tick on detent settle where supported. iOS Safari doesn't
123
137
  // expose navigator.vibrate, so this is a no-op there; skipped under
@@ -1140,7 +1154,7 @@ export function useSheetGestures({
1140
1154
  return;
1141
1155
  }
1142
1156
  const delta = event.clientY - armed.startCoord;
1143
- if (delta > 0 && armed.scroller.scrollTop <= 0) {
1157
+ if (delta > DRAG_PROMOTION_SLOP && armed.scroller.scrollTop <= 0) {
1144
1158
  // Downward pull at the top: promote to a sheet drag, anchored at the
1145
1159
  // original pointer-down position so the pull distance carries over.
1146
1160
  armedBodyRef.current = null;
@@ -1302,8 +1316,10 @@ export function useSheetGestures({
1302
1316
  // no longer scroll that way: at the top, a downward pull (delta > 0)
1303
1317
  // collapses; at the bottom, an upward pull (delta < 0) expands. The
1304
1318
  // opposite direction is a real scroll, so disarm and let it through.
1305
- const pullDownAtTop = armed.top && delta > 0 && atTop(scroller);
1306
- const pullUpAtBottom = armed.bottom && delta < 0 && atBottom(scroller);
1319
+ const pullDownAtTop =
1320
+ armed.top && delta > DRAG_PROMOTION_SLOP && atTop(scroller);
1321
+ const pullUpAtBottom =
1322
+ armed.bottom && delta < -DRAG_PROMOTION_SLOP && atBottom(scroller);
1307
1323
  if (pullDownAtTop || pullUpAtBottom) {
1308
1324
  event.preventDefault();
1309
1325
  touchDragRef.current = null;
@@ -1433,15 +1449,19 @@ export function useSheetGestures({
1433
1449
  style: {
1434
1450
  transform:
1435
1451
  activeOffset !== 0 ? `translateY(${activeOffset}px)` : undefined,
1452
+ // Gated on the sheet being up: suppression must not outlive the sheet
1453
+ // it was suppressing for. The host swaps the panel to its closing
1454
+ // state in whatever frame the dismissal lands, and a stale `none`
1455
+ // would apply to that transform too, cutting the exit.
1436
1456
  transition:
1437
- isDragging || isScrollAreaReconciling || reducedMotion
1457
+ isOpen && (isDragging || isScrollAreaReconciling || reducedMotion)
1438
1458
  ? 'none'
1439
1459
  : undefined,
1440
1460
  touchAction: 'none',
1441
1461
  overscrollBehavior: 'contain',
1442
1462
  },
1443
1463
  }),
1444
- [activeOffset, isDragging, isScrollAreaReconciling, reducedMotion],
1464
+ [activeOffset, isDragging, isOpen, isScrollAreaReconciling, reducedMotion],
1445
1465
  );
1446
1466
 
1447
1467
  const handleProps = useMemo<SheetHandleProps>(
@@ -38,6 +38,7 @@ import {
38
38
  spacingVars,
39
39
  typeScaleVars,
40
40
  radiusVars,
41
+ fontWeightVars,
41
42
  } from '../theme/tokens.stylex';
42
43
  import {BreadcrumbContext, type BreadcrumbsVariant} from './Breadcrumbs';
43
44
  import {useLinkComponent} from '../Link/useLinkComponent';
@@ -186,7 +187,7 @@ const itemStyles = stylex.create({
186
187
  color: colorVars['--color-text-secondary'],
187
188
  },
188
189
  current: {
189
- fontWeight: 'inherit',
190
+ fontWeight: fontWeightVars['--font-weight-semibold'],
190
191
  },
191
192
  defaultCurrent: {
192
193
  color: colorVars['--color-text-primary'],
@@ -150,6 +150,28 @@ export const docs = {
150
150
  description:
151
151
  'Async click handler. Shows loading state while the returned promise is pending.',
152
152
  },
153
+ {
154
+ name: 'href',
155
+ type: 'string',
156
+ description:
157
+ 'When provided, renders the button as a link element (<a> or custom link component).',
158
+ },
159
+ {
160
+ name: 'as',
161
+ type: 'ComponentType',
162
+ description:
163
+ 'Custom link component to use when href is provided (e.g. Next.js Link).',
164
+ },
165
+ {
166
+ name: 'target',
167
+ type: 'string',
168
+ description: 'HTML target attribute when rendered as a link (e.g. "_blank").',
169
+ },
170
+ {
171
+ name: 'rel',
172
+ type: 'string',
173
+ description: 'HTML rel attribute when rendered as a link (e.g. "noopener noreferrer").',
174
+ },
153
175
  ],
154
176
  playground: {
155
177
  defaults: {
@@ -83,7 +83,8 @@ export const docs = {
83
83
  {
84
84
  name: 'focusDate',
85
85
  type: 'ISODateString',
86
- description: 'Controlled visible month.',
86
+ description:
87
+ 'Controlled visible month. Unset, the calendar opens on the selected date, else on today clamped into the min/max window.',
87
88
  },
88
89
  {
89
90
  name: 'onFocusDateChange',
@@ -156,7 +157,7 @@ export const docsZh = {
156
157
  {name: 'dateConstraints', type: 'Array<(date: Date) => boolean>', description: '自定义约束函数。'},
157
158
  {name: 'maxRangeSpan', type: 'number', description: '范围模式:范围最多可跨越的天数,含首尾两端(7 = 7 天窗口)。选定起始日后限制窗口大小。'},
158
159
  {name: 'minRangeSpan', type: 'number', description: '范围模式:范围最少需跨越的天数,含首尾两端(2 表示禁止单日范围)。默认为 1。'},
159
- {name: 'focusDate', type: 'ISODateString', description: '受控可见月份。'},
160
+ {name: 'focusDate', type: 'ISODateString', description: '受控可见月份。未设置时,日历打开时显示已选日期所在月份;若无选中值,则显示今天,并将其限制在 min/max 范围内。'},
160
161
  {name: 'onFocusDateChange', type: '(focusDate: ISODateString) => void', description: '导航回调函数。'},
161
162
  {name: 'handleRef', type: 'React.Ref<CalendarHandle>', description: '日历导航的命令式句柄,包括 navigateTo()。'},
162
163
  {name: 'hasOutsideDays', type: 'boolean', description: '显示相邻月份的日期。', default: 'true'},
@@ -221,7 +222,7 @@ export const docsDense = {
221
222
  dateConstraints: 'custom constraint fns',
222
223
  maxRangeSpan: 'range mode: max days a range may span, both ends counted (7 = 7-day window)',
223
224
  minRangeSpan: 'range mode: min days a range must span, both ends counted (default 1)',
224
- focusDate: 'controlled visible month',
225
+ focusDate: 'controlled visible month (default: selected date, else today clamped into min/max)',
225
226
  onFocusDateChange: 'navigation callback',
226
227
  handleRef: 'imperative navigation handle',
227
228
  hasOutsideDays: 'show days from adjacent months',