@astryxdesign/core 0.1.8 → 0.1.9-canary.09e9ddd

package/src/Breadcrumbs/BreadcrumbItem.tsx

@@ -4,10 +4,16 @@
 
 /**
  * @file BreadcrumbItem.tsx
- * @input Uses React use/useRef/useEffect, stylex, theme tokens, BreadcrumbContext
+ * @input Uses React use/useRef/useEffect, stylex, theme tokens, BreadcrumbContext,
+ *   and (for the menu trigger) usePopover + the shared DropdownMenu item API
+ *   (renderDropdownItems, DropdownMenuContext, MENU_ITEM_SELECTOR, useListFocus)
  * @output Exports BreadcrumbItem component and BreadcrumbItemProps
  * @position Individual breadcrumb item; used inside Breadcrumbs
  *
+ * A `menu` prop turns the item's link-styled button into a menu trigger whose
+ * popover reuses DropdownMenu's item pipeline — the same wiring ContextMenu
+ * uses — so menu-item definitions are portable across the menu family.
+ *
  * SYNC: When modified, update these files to stay in sync:
  * - /packages/core/src/Breadcrumbs/Breadcrumbs.doc.mjs
  * - /packages/core/src/Breadcrumbs/Breadcrumbs.test.tsx
@@ -18,19 +24,43 @@
 
 import React, {
   use,
+  useCallback,
+  useId,
+  useMemo,
   useRef,
   useEffect,
   type ReactNode,
   type MouseEvent,
 } from 'react';
 import * as stylex from '@stylexjs/stylex';
-import {colorVars, spacingVars, typeScaleVars} from '../theme/tokens.stylex';
+import {
+  colorVars,
+  spacingVars,
+  typeScaleVars,
+  radiusVars,
+} from '../theme/tokens.stylex';
 import {BreadcrumbContext} from './Breadcrumbs';
 import {useLinkComponent} from '../Link/useLinkComponent';
 import type {LinkComponentType} from '../Link/types';
 import {mergeProps, mergeRefs} from '../utils';
 import type {BaseProps} from '../BaseProps';
 import {themeProps} from '../utils/themeProps';
+import {getIcon} from '../Icon/globalIconRegistry';
+import {usePopover} from '../Popover/usePopover';
+import {useListFocus} from '../hooks/useListFocus';
+import {useTypeahead} from '../hooks/useTypeahead';
+import {layerAnimations} from '../Layer/layerAnimations.stylex';
+import {renderDropdownItems} from '../DropdownMenu/renderDropdownItems';
+import {
+  DropdownMenuContext,
+  type DropdownMenuContextValue,
+  type DropdownMenuSize,
+} from '../DropdownMenu/DropdownMenuContext';
+import {
+  MENU_ITEM_ROLES,
+  MENU_ITEM_SELECTOR,
+} from '../DropdownMenu/menuItemRoles';
+import type {DropdownMenuOption} from '../DropdownMenu/DropdownMenu';
 
 // =============================================================================
 // Props
@@ -69,6 +99,27 @@ export interface BreadcrumbItemProps extends Omit<
    * Optional icon rendered before the label.
    */
   startIcon?: ReactNode;
+  /**
+   * Menu opened when the item is activated. Accepts the SAME item API as
+   * DropdownMenu / MoreMenu / ContextMenu, so a consumer's existing menu-item
+   * definitions are portable into a breadcrumb with no rewrite:
+   * - a `DropdownMenuOption[]` data array (items, sections, dividers), or
+   * - composed `DropdownMenuItem` / `DropdownMenuCheckboxItem` /
+   *   `DropdownMenuRadioGroup` children.
+   *
+   * When set, the item renders as a link-styled menu trigger (button + a
+   * trailing chevron, `aria-haspopup="menu"` / `aria-expanded`) whose popover
+   * is a `role="menu"` container that provides `DropdownMenuContext` and runs
+   * `useListFocus`. Takes precedence over `href` / `onClick` (which are
+   * ignored when `menu` is set — a dev-time warning is logged).
+   */
+  menu?: DropdownMenuOption[] | ReactNode;
+  /**
+   * Size passed to the menu items via `DropdownMenuContext` (item
+   * padding/typography). Defaults from the breadcrumb variant:
+   * `'supporting'` → `'sm'`, otherwise `'md'`.
+   */
+  menuSize?: DropdownMenuSize;
 }
 
 // =============================================================================
@@ -140,6 +191,12 @@ const itemStyles = stylex.create({
     alignItems: 'center',
     flexShrink: 0,
   },
+  chevron: {
+    display: 'flex',
+    alignItems: 'center',
+    flexShrink: 0,
+    fontSize: typeScaleVars['--text-supporting-size'],
+  },
   separator: {
     display: 'var(--separator-display)',
     alignItems: 'center',
@@ -149,6 +206,26 @@ const itemStyles = stylex.create({
   },
 });
 
+const menuStyles = stylex.create({
+  menu: {
+    boxSizing: 'border-box',
+    display: 'flex',
+    flexDirection: 'column',
+    gap: spacingVars['--spacing-0-5'],
+    maxHeight: '300px',
+    overflowY: 'auto',
+    '--_dropdown-menu-radius': radiusVars['--radius-container'],
+    '--_dropdown-menu-padding': spacingVars['--spacing-1'],
+    padding: spacingVars['--spacing-1'],
+    borderRadius: 'var(--_dropdown-menu-radius)',
+    userSelect: 'none',
+  },
+  popover: {
+    minWidth: '160px',
+    marginBlock: spacingVars['--spacing-1'],
+  },
+});
+
 // =============================================================================
 // Component
 // =============================================================================
@@ -175,6 +252,8 @@ export function BreadcrumbItem({
   onClick,
   isCurrent: isCurrentProp,
   startIcon,
+  menu,
+  menuSize,
   xstyle,
   className,
   style,
@@ -192,6 +271,28 @@ export function BreadcrumbItem({
 
   const isCurrent = isCurrentProp === true;
   const isAutoCandidate = isCurrentProp == null;
+  const hasMenu = menu != null;
+  const resolvedMenuSize: DropdownMenuSize =
+    menuSize ?? (isSupporting ? 'sm' : 'md');
+
+  // `menu` owns the click interaction; a label can't both navigate/act and
+  // open a menu on the same activation. Warn once so the (ignored) href/onClick
+  // don't silently disappear on the consumer.
+  useEffect(() => {
+    if (process.env.NODE_ENV !== 'production' && hasMenu) {
+      if (href != null) {
+        console.warn(
+          'BreadcrumbItem: `menu` and `href` are mutually exclusive; `menu` ' +
+            'takes precedence and `href` is ignored.',
+        );
+      } else if (onClick != null) {
+        console.warn(
+          'BreadcrumbItem: `menu` and `onClick` are mutually exclusive; ' +
+            '`menu` takes precedence and `onClick` is ignored.',
+        );
+      }
+    }
+  }, [hasMenu, href, onClick]);
 
   // Auto-detect: if no sibling has aria-current="page" and this is the last
   // non-separator item, set aria-current on our content element.
@@ -258,17 +359,31 @@ export function BreadcrumbItem({
         <span aria-hidden="true" {...stylex.props(itemStyles.separator)}>
           {ctx.separator}
         </span>
-        <span
-          {...stylex.props(
-            itemStyles.contentWrapper,
-            itemStyles.current,
-            isSupporting
-              ? itemStyles.supportingCurrent
-              : itemStyles.defaultCurrent,
-          )}
-          aria-current="page">
-          {content}
-        </span>
+        {hasMenu ? (
+          // A current crumb can also open a sibling menu — the trigger keeps
+          // both aria-current="page" and aria-haspopup="menu".
+          <BreadcrumbMenuTrigger
+            ref={contentRef}
+            menu={menu}
+            menuSize={resolvedMenuSize}
+            isSupporting={isSupporting}
+            isCurrent
+            label={children}>
+            {content}
+          </BreadcrumbMenuTrigger>
+        ) : (
+          <span
+            {...stylex.props(
+              itemStyles.contentWrapper,
+              itemStyles.current,
+              isSupporting
+                ? itemStyles.supportingCurrent
+                : itemStyles.defaultCurrent,
+            )}
+            aria-current="page">
+            {content}
+          </span>
+        )}
       </li>
     );
   }
@@ -293,7 +408,16 @@ export function BreadcrumbItem({
       <span aria-hidden="true" {...stylex.props(itemStyles.separator)}>
         {ctx.separator}
       </span>
-      {href != null ? (
+      {hasMenu ? (
+        <BreadcrumbMenuTrigger
+          ref={contentRef}
+          menu={menu}
+          menuSize={resolvedMenuSize}
+          isSupporting={isSupporting}
+          label={children}>
+          {content}
+        </BreadcrumbMenuTrigger>
+      ) : href != null ? (
         <LinkComponent
           ref={contentRef}
           href={href}
@@ -334,3 +458,198 @@ export function BreadcrumbItem({
 }
 
 BreadcrumbItem.displayName = 'BreadcrumbItem';
+
+// =============================================================================
+// Menu trigger
+// =============================================================================
+
+interface BreadcrumbMenuTriggerProps {
+  ref: React.Ref<HTMLElement>;
+  /** The link-styled label content rendered inside the trigger button. */
+  children: ReactNode;
+  /** Accessible name for the menu surface (the crumb's label). */
+  label: ReactNode;
+  menu: DropdownMenuOption[] | ReactNode;
+  menuSize: DropdownMenuSize;
+  isSupporting: boolean;
+  isCurrent?: boolean;
+}
+
+/**
+ * The link-styled `<button>` trigger + its `role="menu"` popover. Reuses the
+ * DropdownMenu item pipeline (`renderDropdownItems` for arrays, the item
+ * components for children) inside a `useListFocus` container that provides
+ * `DropdownMenuContext` — the same wiring ContextMenu uses — so menu-item
+ * definitions are portable into a breadcrumb with no rewrite.
+ */
+function BreadcrumbMenuTrigger({
+  ref,
+  children,
+  label,
+  menu,
+  menuSize,
+  isSupporting,
+  isCurrent = false,
+}: BreadcrumbMenuTriggerProps) {
+  const menuId = useId();
+  const buttonRef = useRef<HTMLButtonElement>(null);
+
+  const popover = usePopover({
+    onHide: useCallback(() => {
+      buttonRef.current?.focus();
+    }, []),
+    hasLightDismiss: true,
+    hasCloseButton: false,
+    hasAutoFocus: false,
+    // The popup's own role="menu" is the exposed semantics; a modal dialog
+    // wrapper would announce an unnamed dialog around the menu.
+    role: 'none',
+  });
+
+  const closeMenu = useCallback(() => {
+    popover.hide();
+  }, [popover]);
+
+  const {
+    listRef,
+    handleKeyDown: listNavKeyDown,
+    focusFirst,
+    focusItem,
+  } = useListFocus<HTMLDivElement>({
+    itemSelector: MENU_ITEM_SELECTOR,
+    wrap: false,
+    onEscape: closeMenu,
+  });
+
+  const getMenuItems = useCallback(
+    (): HTMLElement[] =>
+      listRef.current
+        ? Array.from(
+            listRef.current.querySelectorAll<HTMLElement>(MENU_ITEM_SELECTOR),
+          )
+        : [],
+    [listRef],
+  );
+  const typeahead = useTypeahead({
+    getItemLabels: () => getMenuItems().map(el => el.textContent),
+    onMatch: focusItem,
+    getCurrentIndex: () =>
+      getMenuItems().findIndex(
+        el =>
+          el === document.activeElement || el.contains(document.activeElement),
+      ),
+  });
+
+  const listKeyDown = useCallback(
+    (e: React.KeyboardEvent) => {
+      if (e.key === 'Enter' || e.key === ' ') {
+        e.preventDefault();
+        const focused = document.activeElement as HTMLElement | null;
+        if (
+          focused &&
+          MENU_ITEM_ROLES.has(focused.getAttribute('role') ?? '')
+        ) {
+          focused.click();
+        }
+        return;
+      }
+      // APG menu-button pattern: Tab closes the menu (items are tabIndex={-1}).
+      if (e.key === 'Tab') {
+        closeMenu();
+        return;
+      }
+      if (typeahead.onKeyDown(e)) {
+        e.preventDefault();
+        return;
+      }
+      listNavKeyDown(e);
+    },
+    [listNavKeyDown, closeMenu, typeahead],
+  );
+
+  const openAndFocus = useCallback(() => {
+    popover.show();
+    requestAnimationFrame(() => focusFirst());
+  }, [popover, focusFirst]);
+
+  const handleClick = useCallback(() => {
+    if (popover.isOpen) {
+      popover.hide();
+    } else {
+      openAndFocus();
+    }
+  }, [popover, openAndFocus]);
+
+  const handleKeyDown = useCallback(
+    (e: React.KeyboardEvent) => {
+      if (!popover.isOpen) {
+        if (e.key === 'ArrowDown' || e.key === 'Enter' || e.key === ' ') {
+          e.preventDefault();
+          openAndFocus();
+        }
+      }
+    },
+    [popover.isOpen, openAndFocus],
+  );
+
+  const contextValue = useMemo<DropdownMenuContextValue>(
+    () => ({closeMenu, menuSize}),
+    [closeMenu, menuSize],
+  );
+
+  const menuContent = Array.isArray(menu) ? renderDropdownItems(menu) : menu;
+
+  return (
+    <>
+      <button
+        ref={mergeRefs(
+          ref as React.Ref<HTMLButtonElement>,
+          buttonRef,
+          popover.triggerRef,
+        )}
+        type="button"
+        onClick={handleClick}
+        onKeyDown={handleKeyDown}
+        {...mergeProps(themeProps('breadcrumb-item-menu-trigger'), {
+          ...popover.triggerProps,
+          'aria-haspopup': 'menu' as const,
+          'aria-controls': menuId,
+          'aria-current': isCurrent ? ('page' as const) : undefined,
+        })}
+        {...stylex.props(
+          itemStyles.link,
+          itemStyles.buttonReset,
+          isSupporting ? itemStyles.supportingLink : itemStyles.defaultLink,
+        )}>
+        {children}
+        <span aria-hidden="true" {...stylex.props(itemStyles.chevron)}>
+          {getIcon('chevronDown')}
+        </span>
+      </button>
+
+      {popover.render(
+        <div
+          ref={listRef}
+          id={menuId}
+          role="menu"
+          aria-label={typeof label === 'string' ? label : undefined}
+          onKeyDown={listKeyDown}
+          {...mergeProps(
+            themeProps('breadcrumb-menu'),
+            stylex.props(menuStyles.menu),
+          )}>
+          <DropdownMenuContext value={contextValue}>
+            {menuContent}
+          </DropdownMenuContext>
+        </div>,
+        {
+          placement: 'below',
+          alignment: 'start',
+          xstyle: [menuStyles.popover, layerAnimations.below],
+        },
+      )}
+    </>
+  );
+}
+
+BreadcrumbMenuTrigger.displayName = 'BreadcrumbMenuTrigger';

package/src/Breadcrumbs/Breadcrumbs.doc.mjs

@@ -30,6 +30,8 @@ export const docs = {
   theming: {
     targets: [
       {className: 'astryx-breadcrumb-item'},
+      {className: 'astryx-breadcrumb-item-menu-trigger'},
+      {className: 'astryx-breadcrumb-menu'},
       {className: 'astryx-breadcrumbs', visualProps: ['variant']},
     ],
   },