@astryxdesign/core 0.1.6-canary.fd658d7 → 0.1.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@astryxdesign/core",
-  "version": "0.1.6-canary.fd658d7",
+  "version": "0.1.6",
   "displayName": "Astryx Core",
   "description": "The component library. Accessible, themeable React components with built-in spacing, dark mode, and StyleX styling.",
   "author": "Meta Open Source",

package/src/Link/Link.test.tsx

@@ -10,7 +10,7 @@
  */
 
 import {describe, it, expect, vi} from 'vitest';
-import {fireEvent, render, screen} from '@testing-library/react';
+import {render, screen} from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import {Link} from './Link';
 import {LinkProvider} from './LinkProvider';
@@ -153,81 +153,9 @@ describe('Link', () => {
         Disabled Link
       </Link>,
     );
-    // An href-less anchor has no implicit `link` role, so query by text.
-    const link = screen.getByText('Disabled Link').closest('a');
-    expect(link).not.toBeNull();
+    const link = screen.getByRole('link');
     expect(link).toHaveAttribute('aria-disabled', 'true');
     expect(link).toHaveAttribute('tabIndex', '-1');
-    // Visual classes are preserved in the disabled state.
-    expect(link?.className).toContain('astryx-link');
-  });
-
-  it('disabled link has no href attribute', () => {
-    render(
-      <Link href="/test" isDisabled>
-        Disabled Link
-      </Link>,
-    );
-    const link = screen.getByText('Disabled Link').closest('a');
-    expect(link).not.toBeNull();
-    expect(link).not.toHaveAttribute('href');
-  });
-
-  it('clicking a disabled link cancels default navigation', () => {
-    render(
-      <Link href="/test" isDisabled>
-        Disabled Link
-      </Link>,
-    );
-    const link = screen.getByText('Disabled Link').closest('a');
-    expect(link).not.toBeNull();
-    // fireEvent bypasses pointer-events, simulating programmatic/AT
-    // activation. It returns false when preventDefault was called, i.e.
-    // any default navigation behavior is cancelled.
-    const notCancelled = fireEvent.click(link as HTMLAnchorElement);
-    expect(notCancelled).toBe(false);
-  });
-
-  it('disabled link with onClick fires neither navigation nor the consumer onClick', () => {
-    const handleClick = vi.fn();
-    const {container} = render(
-      <Link href="/test" isDisabled onClick={handleClick}>
-        Disabled Link
-      </Link>,
-    );
-    // With onClick present, a disabled Link renders as a disabled <button>
-    // (useInteractiveRole excludes a disabled href). Either way the rendered
-    // root must carry no live href and never invoke the consumer handler.
-    const el = container.firstElementChild as HTMLElement;
-    expect(el).not.toHaveAttribute('href');
-    fireEvent.click(el);
-    expect(handleClick).not.toHaveBeenCalled();
-  });
-
-  it('disabled link omits target and rel', () => {
-    render(
-      <Link href="https://example.com" isDisabled isExternalLink>
-        Disabled External
-      </Link>,
-    );
-    const link = screen.getByText('Disabled External').closest('a');
-    expect(link).not.toBeNull();
-    expect(link).not.toHaveAttribute('target');
-    expect(link).not.toHaveAttribute('rel');
-  });
-
-  it('disabled link renders a plain anchor, not the custom LinkComponent', () => {
-    render(
-      <LinkProvider component={CustomLink}>
-        <Link href="/custom" as={CustomLink} isDisabled>
-          Disabled Custom
-        </Link>
-      </LinkProvider>,
-    );
-    const link = screen.getByText('Disabled Custom').closest('a');
-    expect(link).not.toBeNull();
-    expect(link).not.toHaveAttribute('data-custom-link');
-    expect(link).not.toHaveAttribute('href');
   });
 
   it('renders external link with icon and target="_blank"', () => {

package/src/Link/Link.tsx

@@ -174,10 +174,6 @@ export interface LinkProps extends BaseProps<
   hasUnderline?: boolean;
   /**
    * Whether the link is disabled.
-   * A disabled link renders as a plain anchor without an href (and without
-   * target/rel/onClick), so it cannot be focused or activated — no
-   * navigation and no onClick, even via programmatic focus or assistive
-   * technology activation.
    * @default false
    */
   isDisabled?: boolean;
@@ -265,15 +261,6 @@ export interface LinkProps extends BaseProps<
   children: ReactNode;
 }
 
-/**
- * Click handler for disabled links. The disabled anchor renders without an
- * href, so there is no navigation to block in practice; preventDefault is a
- * defensive guard against synthetic/programmatic clicks.
- */
-function preventDefaultClick(event: React.MouseEvent<HTMLAnchorElement>): void {
-  event.preventDefault();
-}
-
 /**
  * A styled anchor link component.
  *
@@ -381,37 +368,6 @@ export function Link({
         {sharedContent}
       </button>
     );
-  } else if (isDisabled) {
-    // A disabled link renders as a plain <a> with no href: an href-less
-    // anchor is not focusable and exposes no link affordance, so programmatic
-    // focus + Enter, AT activation commands, and middle-click cannot navigate
-    // or fire the consumer onClick. The router LinkComponent is deliberately
-    // skipped — a disabled link performs no navigation, and custom router
-    // links may require a live href. target/rel are omitted with the href.
-    linkElement = (
-      <a
-        ref={ref as React.Ref<HTMLAnchorElement>}
-        onClick={preventDefaultClick}
-        aria-label={label || undefined}
-        aria-disabled={true}
-        tabIndex={-1}
-        {...mergeProps(
-          themeProps('link', {color}),
-          stylex.props(
-            styles.base,
-            linkColorStyles[color],
-            hasUnderline && styles.hasUnderline,
-            isStandalone && styles.standalone,
-            styles.disabled,
-            xstyle,
-          ),
-          className,
-          style,
-        )}
-        {...props}>
-        {sharedContent}
-      </a>
-    );
   } else {
     linkElement = (
       <LinkComponent

package/src/TopNav/TopNav.doc.mjs

@@ -109,7 +109,6 @@ export const docs = {
       name: 'label',
       type: 'string',
       description: 'Accessible label for the navigation landmark, applied as aria-label on the <nav> element.',
-      default: "'Top navigation'",
     },
     {
       name: 'xstyle',

package/src/TopNav/TopNav.test.tsx

@@ -13,7 +13,6 @@ import {describe, it, expect, vi} from 'vitest';
 import {render, screen} from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import {TopNav} from './TopNav';
-import {TopNavRenderContext} from './TopNavRenderContext';
 import {TopNavHeading} from './TopNavHeading';
 import {NavIcon} from '../NavIcon';
 import {TopNavItem} from './TopNavItem';
@@ -46,35 +45,6 @@ describe('TopNav', () => {
     );
   });
 
-  it('defaults the landmark label to "Top navigation" when label is omitted', () => {
-    render(<TopNav />);
-    expect(
-      screen.getByRole('navigation', {name: 'Top navigation'}),
-    ).toBeInTheDocument();
-  });
-
-  it('defaults the landmark label in mobile-bar mode', () => {
-    render(
-      <TopNavRenderContext value="mobile-bar">
-        <TopNav heading={<span>Logo</span>} />
-      </TopNavRenderContext>,
-    );
-    expect(
-      screen.getByRole('navigation', {name: 'Top navigation'}),
-    ).toBeInTheDocument();
-  });
-
-  it('custom label overrides the default in mobile-bar mode', () => {
-    render(
-      <TopNavRenderContext value="mobile-bar">
-        <TopNav label="Utility navigation" />
-      </TopNavRenderContext>,
-    );
-    expect(
-      screen.getByRole('navigation', {name: 'Utility navigation'}),
-    ).toBeInTheDocument();
-  });
-
   it('renders heading slot content', () => {
     render(<TopNav heading={<span data-testid="title-content">Logo</span>} />);
     expect(screen.getByTestId('title-content')).toBeInTheDocument();

package/src/TopNav/TopNav.tsx

@@ -147,7 +147,6 @@ export interface TopNavProps extends BaseProps<HTMLElement> {
   /**
    * Accessible label for the navigation landmark.
    * Helps screen readers identify the navigation area.
-   * @default 'Top navigation'
    */
   label?: string;
 }
@@ -177,7 +176,7 @@ export function TopNav({
   children,
   centerContent,
   endContent,
-  label = 'Top navigation',
+  label,
   xstyle,
   className,
   style,
@@ -295,7 +294,9 @@ export function TopNav({
       ) : (
         endContent && (
           <div {...stylex.props(styles.endContent)}>
-            <TopNavSlotContext value="end">{endContent}</TopNavSlotContext>
+            <TopNavSlotContext value="end">
+              {endContent}
+            </TopNavSlotContext>
           </div>
         )
       )}