@astryxdesign/core 0.1.2-canary.eeff948 → 0.1.2-canary.f03e2cc

package/dist/utils/index.d.ts

@@ -14,8 +14,6 @@ export { parseStyleKey } from './parseStyleKey';
 export { getKey, type Key, type KeyFallback } from './getKey';
 export { mergeProps } from './mergeProps';
 export { mergeRefs } from './mergeRefs';
-export { themeProps, themeDataAttributes } from './themeProps';
-export type { ClassValue, ClassProps, ThemeDataAttributes, ThemeProps, } from './themeProps';
 export { groupItems, getItemGroup } from './groupItems';
 export type { ItemGroup } from './groupItems';
 export { observeResize, unobserveResize } from './sharedResizeObserver';

package/dist/utils/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/utils/index.ts"],"names":[],"mappings":"AAEA;;;;;GAKG;AAEH,YAAY,EAAC,SAAS,EAAC,MAAM,SAAS,CAAC;AAEvC,YAAY,EAAC,aAAa,EAAE,SAAS,EAAE,SAAS,EAAE,SAAS,EAAC,MAAM,aAAa,CAAC;AAEhF,OAAO,EACL,cAAc,EACd,SAAS,EACT,QAAQ,EACR,gBAAgB,GACjB,MAAM,cAAc,CAAC;AAEtB,OAAO,EACL,eAAe,EACf,gBAAgB,EAChB,cAAc,EACd,eAAe,EACf,iBAAiB,EACjB,cAAc,EACd,cAAc,EACd,kBAAkB,EAClB,kBAAkB,EAClB,gBAAgB,EAChB,kBAAkB,EAClB,oBAAoB,EACpB,iBAAiB,EACjB,gBAAgB,EAChB,gBAAgB,EAChB,YAAY,EACZ,YAAY,EACZ,kBAAkB,EAClB,wBAAwB,EACxB,uBAAuB,EACvB,8BAA8B,EAC9B,sBAAsB,EACtB,eAAe,EACf,wBAAwB,EACxB,gBAAgB,EAChB,sBAAsB,EACtB,iBAAiB,EACjB,2BAA2B,GAC5B,MAAM,aAAa,CAAC;AAErB,OAAO,EACL,YAAY,EACZ,aAAa,EACb,oBAAoB,EACpB,oBAAoB,EACpB,cAAc,EACd,WAAW,EACX,aAAa,EACb,SAAS,EACT,UAAU,EACV,mBAAmB,GACpB,MAAM,cAAc,CAAC;AACtB,YAAY,EAAC,aAAa,EAAE,UAAU,EAAC,MAAM,cAAc,CAAC;AAE5D,OAAO,EAAC,aAAa,EAAC,MAAM,iBAAiB,CAAC;AAC9C,OAAO,EAAC,MAAM,EAAE,KAAK,GAAG,EAAE,KAAK,WAAW,EAAC,MAAM,UAAU,CAAC;AAE5D,OAAO,EAAC,UAAU,EAAC,MAAM,cAAc,CAAC;AACxC,OAAO,EAAC,SAAS,EAAC,MAAM,aAAa,CAAC;AACtC,OAAO,EAAC,UAAU,EAAE,mBAAmB,EAAC,MAAM,cAAc,CAAC;AAC7D,YAAY,EACV,UAAU,EACV,UAAU,EACV,mBAAmB,EACnB,UAAU,GACX,MAAM,cAAc,CAAC;AACtB,OAAO,EAAC,UAAU,EAAE,YAAY,EAAC,MAAM,cAAc,CAAC;AACtD,YAAY,EAAC,SAAS,EAAC,MAAM,cAAc,CAAC;AAC5C,OAAO,EAAC,aAAa,EAAE,eAAe,EAAC,MAAM,wBAAwB,CAAC;AACtE,OAAO,EAAC,YAAY,EAAC,MAAM,gBAAgB,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/utils/index.ts"],"names":[],"mappings":"AAEA;;;;;GAKG;AAEH,YAAY,EAAC,SAAS,EAAC,MAAM,SAAS,CAAC;AAEvC,YAAY,EAAC,aAAa,EAAE,SAAS,EAAE,SAAS,EAAE,SAAS,EAAC,MAAM,aAAa,CAAC;AAEhF,OAAO,EACL,cAAc,EACd,SAAS,EACT,QAAQ,EACR,gBAAgB,GACjB,MAAM,cAAc,CAAC;AAEtB,OAAO,EACL,eAAe,EACf,gBAAgB,EAChB,cAAc,EACd,eAAe,EACf,iBAAiB,EACjB,cAAc,EACd,cAAc,EACd,kBAAkB,EAClB,kBAAkB,EAClB,gBAAgB,EAChB,kBAAkB,EAClB,oBAAoB,EACpB,iBAAiB,EACjB,gBAAgB,EAChB,gBAAgB,EAChB,YAAY,EACZ,YAAY,EACZ,kBAAkB,EAClB,wBAAwB,EACxB,uBAAuB,EACvB,8BAA8B,EAC9B,sBAAsB,EACtB,eAAe,EACf,wBAAwB,EACxB,gBAAgB,EAChB,sBAAsB,EACtB,iBAAiB,EACjB,2BAA2B,GAC5B,MAAM,aAAa,CAAC;AAErB,OAAO,EACL,YAAY,EACZ,aAAa,EACb,oBAAoB,EACpB,oBAAoB,EACpB,cAAc,EACd,WAAW,EACX,aAAa,EACb,SAAS,EACT,UAAU,EACV,mBAAmB,GACpB,MAAM,cAAc,CAAC;AACtB,YAAY,EAAC,aAAa,EAAE,UAAU,EAAC,MAAM,cAAc,CAAC;AAE5D,OAAO,EAAC,aAAa,EAAC,MAAM,iBAAiB,CAAC;AAC9C,OAAO,EAAC,MAAM,EAAE,KAAK,GAAG,EAAE,KAAK,WAAW,EAAC,MAAM,UAAU,CAAC;AAE5D,OAAO,EAAC,UAAU,EAAC,MAAM,cAAc,CAAC;AACxC,OAAO,EAAC,SAAS,EAAC,MAAM,aAAa,CAAC;AACtC,OAAO,EAAC,UAAU,EAAE,YAAY,EAAC,MAAM,cAAc,CAAC;AACtD,YAAY,EAAC,SAAS,EAAC,MAAM,cAAc,CAAC;AAC5C,OAAO,EAAC,aAAa,EAAE,eAAe,EAAC,MAAM,wBAAwB,CAAC;AACtE,OAAO,EAAC,YAAY,EAAC,MAAM,gBAAgB,CAAC"}

package/dist/utils/index.js

@@ -14,7 +14,6 @@ export { parseStyleKey } from "./parseStyleKey.js";
 export { getKey } from "./getKey.js";
 export { mergeProps } from "./mergeProps.js";
 export { mergeRefs } from "./mergeRefs.js";
-export { themeProps, themeDataAttributes } from "./themeProps.js";
 export { groupItems, getItemGroup } from "./groupItems.js";
 export { observeResize, unobserveResize } from "./sharedResizeObserver.js";
 export { isRenderable } from "./isRenderable.js";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@astryxdesign/core",
-  "version": "0.1.2-canary.eeff948",
+  "version": "0.1.2-canary.f03e2cc",
   "displayName": "XDS Core",
   "description": "The component library. Accessible, themeable React components with built-in spacing, dark mode, and StyleX styling.",
   "author": "Meta Open Source",
@@ -635,15 +635,14 @@
     "@stylexjs/babel-plugin": "^0.19.0",
     "@testing-library/dom": "^10.0.0",
     "@testing-library/jest-dom": "^6.6.0",
-    "@testing-library/react": "^16.3.2",
-    "rimraf": "^6.0.1"
+    "@testing-library/react": "^16.3.2"
   },
   "scripts": {
-    "build": "rimraf dist && pnpm build:esm && tsc --project tsconfig.build.json && pnpm build:css && pnpm build:umd",
-    "build:esm": "babel src --out-dir dist --extensions .ts,.tsx --out-file-extension .js --ignore \"**/*.test.ts,**/*.test.tsx,**/__tests__/**,**/*.perf.test.*,**/*.doc.mjs,**/*.d.ts,**/*.css,**/*.css.d.ts\" --config-file ./babel.config.json",
+    "build": "rm -rf dist && pnpm build:esm && tsc --project tsconfig.build.json && pnpm build:css && pnpm build:umd",
+    "build:esm": "babel src --out-dir dist --extensions '.ts,.tsx' --out-file-extension '.js' --ignore '**/*.test.ts,**/*.test.tsx,**/__tests__/**,**/*.perf.test.*,**/*.doc.mjs,**/*.d.ts,**/*.css,**/*.css.d.ts' --config-file ./babel.config.json",
     "build:css": "node ../../scripts/build-css.mjs",
     "build:umd": "node ../../scripts/build-umd.mjs",
-    "dev": "babel src --watch --out-dir dist --extensions .ts,.tsx --out-file-extension .js --ignore \"**/*.test.*,**/*.doc.mjs,**/*.d.ts,**/*.css*\" --config-file ./babel.config.json",
+    "dev": "babel src --watch --out-dir dist --extensions '.ts,.tsx' --out-file-extension '.js' --ignore '**/*.test.*,**/*.doc.mjs,**/*.d.ts,**/*.css*' --config-file ./babel.config.json",
     "test": "vitest run --root ../..",
     "test:watch": "vitest --root ../..",
     "lint": "eslint src",

package/src/Calendar/Calendar.doc.mjs

@@ -147,7 +147,7 @@ export const docsZh = {
     {name: 'hasOutsideDays', type: 'boolean', description: '显示相邻月份的日期。', default: 'true'},
     {name: 'hasWeekNumbers', type: 'boolean', description: '显示 ISO 周数。', default: 'false'},
     {name: 'hasVariableRowCount', type: 'boolean', description: '可变行数与固定 6 行网格。', default: 'false'},
-    {name: 'weekStartsOn', type: "0 | 1 | 2 | 3 | 4 | 5 | 6 | 'sun' | 'mon' | 'tue' | 'wed' | 'thu' | 'fri' | 'sat'", description: '每周起始日。可为数字（0=周日）或三字母星期缩写（如 "mon"）。', default: '0'},
+    {name: 'weekStartsOn', type: "0 | 1 | 2 | 3 | 4 | 5 | 6 | 'sun'…'sat'", description: '每周起始日。可为数字（0=周日）或三字母星期缩写（如 "mon"）。', default: '0'},
   ],
   theming: {
     targets: [

package/src/Field/FieldLabel.tsx

@@ -35,7 +35,6 @@ const styles = stylex.create({
     gap: spacingVars['--spacing-1'],
     fontFamily: typographyVars['--font-family-body'],
     fontSize: typeScaleVars['--text-label-size'],
-    lineHeight: typeScaleVars['--text-label-leading'],
     fontWeight: fontWeightVars['--font-weight-medium'],
     color: colorVars['--color-text-secondary'],
     cursor: 'pointer',
@@ -62,7 +61,6 @@ const styles = stylex.create({
   optionalRequired: {
     fontWeight: fontWeightVars['--font-weight-normal'],
     fontSize: typeScaleVars['--text-supporting-size'],
-    lineHeight: typeScaleVars['--text-supporting-leading'],
     color: colorVars['--color-text-secondary'],
   },
   description: {

package/src/Layer/useLayer.doc.mjs

@@ -144,11 +144,6 @@ export const docsDense = {
         guidance: true,
         description: 'Build on Popover/HoverCard/Tooltip for common overlay patterns.',
       },
-      {
-        guidance: true,
-        description:
-          'Rely on the Popover API top layer to escape clipping/stacking: render inline (no portal) to inherit the trigger theme cascade and natural focus order. Use `as: "span"` when the layer must be valid in inline contexts like a paragraph.',
-      },
       {
         guidance: false,
         description:

package/src/Link/Link.tsx

@@ -106,20 +106,10 @@ const styles = stylex.create({
  */
 const linkColorStyles = stylex.create({
   primary: {
-    color: {
-      default: colorVars['--color-text-primary'],
-      ':hover': {
-        '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-text-primary']}, ${colorVars['--color-tint-hover']} 15%)`,
-      },
-    },
+    color: colorVars['--color-text-primary'],
   },
   secondary: {
-    color: {
-      default: colorVars['--color-text-secondary'],
-      ':hover': {
-        '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-text-secondary']}, ${colorVars['--color-tint-hover']} 15%)`,
-      },
-    },
+    color: colorVars['--color-text-secondary'],
   },
   disabled: {
     color: colorVars['--color-text-disabled'],
@@ -128,12 +118,7 @@ const linkColorStyles = stylex.create({
     color: colorVars['--color-text-secondary'],
   },
   accent: {
-    color: {
-      default: colorVars['--color-text-accent'],
-      ':hover': {
-        '@media (hover: hover)': `color-mix(in srgb, ${colorVars['--color-text-accent']}, ${colorVars['--color-tint-hover']} 15%)`,
-      },
-    },
+    color: colorVars['--color-text-accent'],
   },
   inherit: {
     color: 'inherit',

package/src/MetadataList/MetadataListItem.doc.mjs

@@ -8,10 +8,6 @@ export const docs = {
   displayName: 'Metadata List Item',
   isHiddenFromOverview: true,
   description: 'A single labeled metadata value within an MetadataList.',
-  playground: {
-    defaults: {label: 'Status', children: 'Active'},
-    wrapper: {component: 'MetadataList'},
-  },
   props: [
     {
       name: 'children',

package/src/MultiSelector/MultiSelector.test.tsx

@@ -675,64 +675,4 @@ describe('MultiSelector', () => {
   it('has displayName', () => {
     expect(MultiSelector.displayName).toBe('MultiSelector');
   });
-
-  describe('keyboard accessibility', () => {
-    it('trigger is focusable via Tab when enabled', async () => {
-      const user = userEvent.setup();
-      render(
-        <MultiSelector
-          label="Fruit"
-          options={defaultOptions}
-          value={[]}
-          onChange={() => {}}
-        />,
-      );
-      await user.tab();
-      expect(screen.getByRole('combobox')).toHaveFocus();
-    });
-
-    it('trigger is not focusable when disabled', () => {
-      render(
-        <MultiSelector
-          label="Fruit"
-          options={defaultOptions}
-          value={[]}
-          onChange={() => {}}
-          isDisabled
-        />,
-      );
-      expect(screen.getByRole('combobox')).toHaveAttribute('tabIndex', '-1');
-    });
-
-    it('opens the listbox with ArrowDown from a focused trigger', async () => {
-      const user = userEvent.setup();
-      render(
-        <MultiSelector
-          label="Fruit"
-          options={defaultOptions}
-          value={[]}
-          onChange={() => {}}
-        />,
-      );
-      const trigger = screen.getByRole('combobox');
-      await user.tab();
-      expect(trigger).toHaveFocus();
-      await user.keyboard('{ArrowDown}');
-      expect(trigger).toHaveAttribute('aria-expanded', 'true');
-    });
-
-    it('clear button is reachable by keyboard', () => {
-      render(
-        <MultiSelector
-          label="Fruit"
-          options={defaultOptions}
-          value={['Apple', 'Banana']}
-          onChange={() => {}}
-          hasClear
-        />,
-      );
-      const clear = screen.getByRole('button', {name: 'Clear all Fruit'});
-      expect(clear).not.toHaveAttribute('tabIndex', '-1');
-    });
-  });
 });

package/src/MultiSelector/MultiSelector.tsx

@@ -1159,7 +1159,7 @@ export function MultiSelector<T extends MultiSelectorOptionType>({
           aria-busy={isBusy || undefined}
           disabled={isDisabled}
           onKeyDown={onKeyDown}
-          tabIndex={isDisabled ? -1 : 0}
+          tabIndex={-1}
           {...stylex.props(styles.trigger)}>
           <span {...stylex.props(styles.triggerContent)}>
             {renderTriggerContent()}
@@ -1169,6 +1169,7 @@ export function MultiSelector<T extends MultiSelectorOptionType>({
         {hasClear && value.length > 0 && !isDisabled && (
           <button
             type="button"
+            tabIndex={-1}
             onClick={handleClear}
             aria-label={`Clear all ${label}`}
             {...stylex.props(styles.clearButton)}>

package/src/NavMenu/NavHeadingMenu.test.tsx

@@ -204,51 +204,6 @@ describe('keyboard navigation', () => {
     await user.keyboard('{End}');
     expect(document.activeElement).toBe(items[2]);
   });
-
-  it('activates a focused onClick-only item with Enter', async () => {
-    const user = userEvent.setup();
-    const onClick = vi.fn();
-    render(
-      <NavHeadingMenu>
-        <NavHeadingMenuItem label="Action" onClick={onClick} />
-      </NavHeadingMenu>,
-    );
-    const item = screen.getByRole('menuitem');
-    item.focus();
-
-    await user.keyboard('{Enter}');
-    expect(onClick).toHaveBeenCalledOnce();
-  });
-
-  it('activates a focused onClick-only item with Space', async () => {
-    const user = userEvent.setup();
-    const onClick = vi.fn();
-    render(
-      <NavHeadingMenu>
-        <NavHeadingMenuItem label="Action" onClick={onClick} />
-      </NavHeadingMenu>,
-    );
-    const item = screen.getByRole('menuitem');
-    item.focus();
-
-    await user.keyboard('{ }');
-    expect(onClick).toHaveBeenCalledOnce();
-  });
-
-  it('does not activate a disabled item with Enter', async () => {
-    const user = userEvent.setup();
-    const onClick = vi.fn();
-    render(
-      <NavHeadingMenu>
-        <NavHeadingMenuItem label="Action" onClick={onClick} isDisabled />
-      </NavHeadingMenu>,
-    );
-    const item = screen.getByRole('menuitem');
-    item.focus();
-
-    await user.keyboard('{Enter}');
-    expect(onClick).not.toHaveBeenCalled();
-  });
 });
 
 describe('context forwarding', () => {

package/src/NavMenu/NavHeadingMenu.tsx

@@ -12,7 +12,7 @@
  * - /packages/core/src/NavMenu/index.ts
  */
 
-import React, {useCallback, useMemo, type ReactNode} from 'react';
+import React, {useMemo, type ReactNode} from 'react';
 import * as stylex from '@stylexjs/stylex';
 import {spacingVars} from '../theme/tokens.stylex';
 import {mergeProps, mergeRefs} from '../utils';
@@ -102,25 +102,6 @@ export function NavHeadingMenu({
     onEscape: closeMenu,
   });
 
-  // Extend useListFocus with Enter/Space activation. Items rendered without an
-  // `href` are `<div role="menuitem">` elements, which have no native keyboard
-  // activation — without this, Enter/Space on a focused onClick-only item does
-  // nothing. Anchor items (with `href`) already activate on Enter natively.
-  const listKeyDown = useCallback(
-    (e: React.KeyboardEvent) => {
-      if (e.key === 'Enter' || e.key === ' ') {
-        const focused = document.activeElement as HTMLElement | null;
-        if (focused?.getAttribute('role') === 'menuitem') {
-          e.preventDefault();
-          focused.click();
-          return;
-        }
-      }
-      handleKeyDown(e);
-    },
-    [handleKeyDown],
-  );
-
   const ctx = useMemo(
     () => ({
       closeMenu: closeMenu ?? (() => {}),
@@ -136,7 +117,7 @@ export function NavHeadingMenu({
       <div
         ref={mergeRefs(ref, listRef)}
         role="menu"
-        onKeyDown={listKeyDown}
+        onKeyDown={handleKeyDown}
         data-testid={testId}
         {...mergeProps(
           themeProps('nav-heading-menu', {size}),

package/src/Pagination/Pagination.doc.mjs

@@ -47,7 +47,7 @@ export const docs = {
     {
       name: 'pageSize',
       type: 'number',
-      description: 'Number of items per page. Coerced to a positive integer; non-finite values fall back to the default.',
+      description: 'Number of items per page.',
       default: '10',
     },
     {
@@ -175,7 +175,7 @@ export const docsZh = {
     {
       name: 'pageSize',
       type: 'number',
-      description: '每页项目数。强制转换为正整数；非有限值回退到默认值。',
+      description: '每页项目数。',
       default: '10',
     },
     {
@@ -277,7 +277,7 @@ export const docsDense = {
     totalItems: 'Total items. Calculates page count. Precedence over totalPages.',
     totalPages: 'Total pages. Use when page count known but not item count.',
     hasMore: 'More pages exist after current. For cursor-based pagination.',
-    pageSize: 'Items per page; coerced to positive integer, non-finite falls back to default',
+    pageSize: 'Items per page.',
     pageSizeOptions: 'Page size options. Shows selector dropdown when provided.',
     onPageSizeChange: 'Called on page size change. Auto resets to page 1.',
     variant: 'Display between prev/next buttons.',

package/src/Pagination/Pagination.test.tsx

@@ -239,65 +239,6 @@ describe('Pagination', () => {
     });
   });
 
-  // ---------------------------------------------------------------------------
-  // pageSize guarding
-  // ---------------------------------------------------------------------------
-
-  describe('pageSize guarding', () => {
-    it('does not crash the dots variant when pageSize is 0', () => {
-      render(
-        <Pagination
-          page={1}
-          onChange={() => {}}
-          totalItems={5}
-          pageSize={0}
-          variant="dots"
-        />,
-      );
-      const group = screen.getByRole('group', {name: 'Page indicators'});
-      expect(within(group).getAllByRole('button')).toHaveLength(5);
-    });
-
-    it('treats NaN pageSize as the default', () => {
-      render(
-        <Pagination
-          page={1}
-          onChange={() => {}}
-          totalItems={50}
-          pageSize={NaN}
-          variant="compact"
-        />,
-      );
-      expect(screen.getByText('Page 1 of 5')).toBeInTheDocument();
-    });
-
-    it('clamps negative pageSize to 1', () => {
-      render(
-        <Pagination
-          page={1}
-          onChange={() => {}}
-          totalItems={5}
-          pageSize={-10}
-          variant="compact"
-        />,
-      );
-      expect(screen.getByText('Page 1 of 5')).toBeInTheDocument();
-    });
-
-    it('floors fractional pageSize', () => {
-      render(
-        <Pagination
-          page={1}
-          onChange={() => {}}
-          totalItems={50}
-          pageSize={2.5}
-          variant="compact"
-        />,
-      );
-      expect(screen.getByText('Page 1 of 25')).toBeInTheDocument();
-    });
-  });
-
   // ---------------------------------------------------------------------------
   // Variant: dots
   // ---------------------------------------------------------------------------

package/src/Pagination/Pagination.tsx

@@ -335,7 +335,7 @@ export function Pagination({
   totalItems,
   totalPages: totalPagesProp,
   hasMore,
-  pageSize: pageSizeProp = 10,
+  pageSize = 10,
   pageSizeOptions,
   onPageSizeChange,
   variant = 'pages',
@@ -351,14 +351,6 @@ export function Pagination({
 }: PaginationProps) {
   const [, startTransition] = useTransition();
 
-  // pageSize is typed as number, so 0, NaN, and negatives are valid at the
-  // type level but yield Infinity/NaN page counts, and
-  // Array.from({length: Infinity}) crashes the dots variant. Coerce to a
-  // positive integer; non-finite values fall back to the default.
-  const pageSize = Number.isFinite(pageSizeProp)
-    ? Math.max(1, Math.floor(pageSizeProp))
-    : 10;
-
   // Track the page optimistically so rapid prev/next clicks advance from the
   // in-flight target instead of stalling on the last committed page.
   const [optimisticPage, setOptimisticPage] = useOptimistic(page);

package/src/SelectableCard/SelectableCard.doc.mjs

@@ -46,7 +46,7 @@ export const docs = {
         props: {gap: 1},
         children: [
           {__element: 'XDSHeading', props: {level: 3}, children: 'Pro plan'},
-          {__element: 'XDSText', props: {type: 'body'}, children: '$29/month, unlimited projects and priority support.'},
+          {__element: 'XDSText', props: {type: 'body'}, children: '$29/month — unlimited projects and priority support.'},
         ],
       },
     },

package/src/Selector/Selector.test.tsx

@@ -467,60 +467,4 @@ describe('Selector', () => {
       ).toBeInTheDocument();
     });
   });
-
-  describe('keyboard accessibility', () => {
-    it('trigger is focusable via Tab when enabled', async () => {
-      const user = userEvent.setup();
-      render(<Selector label="Fruit" options={OPTIONS} />);
-
-      await user.tab();
-      expect(screen.getByRole('combobox')).toHaveFocus();
-    });
-
-    it('trigger is not focusable when disabled', () => {
-      render(<Selector label="Fruit" options={OPTIONS} isDisabled />);
-      expect(screen.getByRole('combobox')).toHaveAttribute('tabIndex', '-1');
-    });
-
-    it('opens the listbox with ArrowDown from a focused trigger', async () => {
-      const user = userEvent.setup();
-      render(<Selector label="Fruit" options={OPTIONS} />);
-
-      const trigger = screen.getByRole('combobox');
-      await user.tab();
-      expect(trigger).toHaveFocus();
-
-      await user.keyboard('{ArrowDown}');
-      expect(trigger).toHaveAttribute('aria-expanded', 'true');
-    });
-
-    it('opens and selects an option with Enter (no mouse)', async () => {
-      const user = userEvent.setup();
-      const onChange = vi.fn();
-      render(
-        <Selector label="Fruit" options={OPTIONS} onChange={onChange} />,
-      );
-
-      await user.tab();
-      await user.keyboard('{Enter}'); // open
-      await user.keyboard('{ArrowDown}'); // move highlight
-      await user.keyboard('{Enter}'); // select
-
-      expect(onChange).toHaveBeenCalled();
-    });
-
-    it('clear button is reachable by keyboard', () => {
-      render(
-        <Selector
-          label="Fruit"
-          options={OPTIONS}
-          value="Apple"
-          onChange={() => {}}
-          hasClear
-        />,
-      );
-      const clear = screen.getByRole('button', {name: 'Clear Fruit'});
-      expect(clear).not.toHaveAttribute('tabIndex', '-1');
-    });
-  });
 });

package/src/Selector/Selector.tsx

@@ -908,7 +908,7 @@ export function Selector<T extends SelectorOptionType>(
           aria-busy={isBusy || undefined}
           disabled={isDisabled}
           onKeyDown={onKeyDown}
-          tabIndex={isDisabled ? -1 : 0}
+          tabIndex={-1}
           {...stylex.props(styles.trigger)}>
           <span {...stylex.props(styles.triggerLabel)}>
             {selectedItem?.label ?? placeholder}
@@ -918,6 +918,7 @@ export function Selector<T extends SelectorOptionType>(
         {hasClear && value != null && !isDisabled && (
           <button
             type="button"
+            tabIndex={-1}
             onClick={handleClear}
             aria-label={`Clear ${label}`}
             {...stylex.props(styles.clearButton)}>

package/src/Table/plugins/pagination/paginateData.ts

@@ -15,8 +15,7 @@
  *
  * @param data - Full data array
  * @param page - Current page number (1-based)
- * @param pageSize - Number of items per page; coerced to a positive integer,
- *   non-finite values fall back to 10
+ * @param pageSize - Number of items per page
  * @returns Slice of data for the current page
  *
  * @example
@@ -32,12 +31,6 @@ export function paginateData<T>(
   page: number,
   pageSize: number,
 ): T[] {
-  // Same coercion as Pagination and useTablePagination: a 0/NaN/negative
-  // pageSize would slice every page empty while the pagination chrome still
-  // renders page buttons.
-  const size = Number.isFinite(pageSize)
-    ? Math.max(1, Math.floor(pageSize))
-    : 10;
-  const start = (page - 1) * size;
-  return data.slice(start, start + size);
+  const start = (page - 1) * pageSize;
+  return data.slice(start, start + pageSize);
 }

package/src/Table/plugins/pagination/useTablePagination.test.tsx

@@ -184,22 +184,6 @@ describe('useTablePagination', () => {
       ).toBeTruthy();
     });
 
-    it('guards pageSize 0 against Infinity page counts', () => {
-      render(<PaginatedTable data={generateItems(5)} pageSize={0} />);
-      expect(
-        screen.getByRole('navigation', {name: 'Table pagination'}),
-      ).toBeInTheDocument();
-      // pageSize is coerced to 1, so 5 items produce 5 pages, not Infinity,
-      // and page 1 shows the first item instead of an empty slice
-      expect(
-        screen.queryByRole('button', {name: 'Go to page Infinity'}),
-      ).toBeNull();
-      expect(
-        screen.getByRole('button', {name: 'Go to page 5'}),
-      ).toBeInTheDocument();
-      expect(screen.getByText('Item 1')).toBeInTheDocument();
-    });
-
     it('transformTableContext renders Pagination above table', () => {
       render(
         <PaginatedTable

package/src/Table/plugins/pagination/useTablePagination.tsx

@@ -199,7 +199,7 @@ export function useTablePagination<T extends Record<string, unknown>>(
     totalItems,
     totalPages: totalPagesProp,
     hasMore,
-    pageSize: pageSizeConfig = 10,
+    pageSize = 10,
     onPageSizeChange,
     pageSizeOptions,
     variant = 'pages',
@@ -209,13 +209,6 @@ export function useTablePagination<T extends Record<string, unknown>>(
     label = 'Table pagination',
   } = config;
 
-  // Same guard as Pagination itself: 0/NaN/negative pageSize would produce an
-  // Infinity/NaN totalPages here, which bypasses Pagination's own coercion
-  // because it is passed down as the explicit totalPages prop.
-  const pageSize = Number.isFinite(pageSizeConfig)
-    ? Math.max(1, Math.floor(pageSizeConfig))
-    : 10;
-
   const computedTotalPages =
     totalPagesProp ??
     (totalItems != null ? Math.ceil(totalItems / pageSize) : undefined);

package/src/utils/index.ts

@@ -68,13 +68,6 @@ export {getKey, type Key, type KeyFallback} from './getKey';
 
 export {mergeProps} from './mergeProps';
 export {mergeRefs} from './mergeRefs';
-export {themeProps, themeDataAttributes} from './themeProps';
-export type {
-  ClassValue,
-  ClassProps,
-  ThemeDataAttributes,
-  ThemeProps,
-} from './themeProps';
 export {groupItems, getItemGroup} from './groupItems';
 export type {ItemGroup} from './groupItems';
 export {observeResize, unobserveResize} from './sharedResizeObserver';