@astryxdesign/cli 0.6.3-canary.df1837b → 0.6.3-canary.e59d786

package/assets/codemods/transforms/next/__tests__/migrate-theme-catalog-to-descriptors.test.mjs

@@ -81,7 +81,6 @@ describe('migrate-theme-catalog-to-descriptors', () => {
   it('is staged for the next release as a project codemod', () => {
     expect(manifest.map(t => [t.name, t.meta.codemodType])).toEqual([
       ['migrate-theme-catalog-to-descriptors', 'project'],
-      ['migrate-native-picker-to-presentation', undefined],
     ]);
   });
 
@@ -136,9 +135,6 @@ describe('migrate-theme-catalog-to-descriptors', () => {
 
   it('previews without writing, even with no source folder', async () => {
     writeKit([entry('ocean')]);
-    // A staged code codemod (migrate-native-picker-to-presentation) requires
-    // the source folder to exist; an empty one exercises the same preview.
-    fs.mkdirSync(path.join(root, 'src'), {recursive: true});
 
     const result = await run(false, path.join(root, 'src'));
 

package/assets/codemods/transforms/next/index.mjs

@@ -10,9 +10,6 @@
 import migrateThemeCatalogToDescriptors, {
   meta as migrateThemeCatalogToDescriptorsMeta,
 } from './migrate-theme-catalog-to-descriptors.mjs';
-import migrateNativePickerToPresentation, {
-  meta as migrateNativePickerToPresentationMeta,
-} from './migrate-native-picker-to-presentation.mjs';
 
 export default [
   {
@@ -20,9 +17,4 @@ export default [
     transform: migrateThemeCatalogToDescriptors,
     meta: migrateThemeCatalogToDescriptorsMeta,
   },
-  {
-    name: 'migrate-native-picker-to-presentation',
-    transform: migrateNativePickerToPresentation,
-    meta: migrateNativePickerToPresentationMeta,
-  },
 ];

package/assets/templates/blocks/components/DateInput/DateInputDateRange.tsx

@@ -41,7 +41,7 @@ export default function DateInputDateRange() {
         max={max}
         description={description}
         placeholder="Select a booking date"
-        presentation="adaptive-bottom-sheet"
+        nativePicker="never"
         value={value}
         onChange={setValue}
       />

package/assets/templates/blocks/components/TimeInput/TimeInputConstrained.tsx

@@ -17,7 +17,6 @@ export default function TimeInputConstrained() {
         max={'22:00' as never}
         description="Evening seating: 5 PM – 10 PM"
         placeholder="Select reservation time"
-        presentation="adaptive-bottom-sheet"
         value={evening as never}
         onChange={setEvening as never}
         hasClear

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@astryxdesign/cli",
-  "version": "0.6.3-canary.df1837b",
+  "version": "0.6.3-canary.e59d786",
   "displayName": "CLI",
   "description": "Scaffold projects, browse templates, generate themes, and get agent-ready docs from the command line.",
   "author": "Meta Open Source",
@@ -101,10 +101,10 @@
     "zod": "^4.4.3"
   },
   "peerDependencies": {
-    "@astryxdesign/charts": "0.6.3-canary.df1837b",
-    "@astryxdesign/core": "0.6.3-canary.df1837b",
-    "@astryxdesign/lab": "0.6.3-canary.df1837b",
-    "@astryxdesign/theme-neutral": "0.6.3-canary.df1837b"
+    "@astryxdesign/charts": "0.6.3-canary.e59d786",
+    "@astryxdesign/core": "0.6.3-canary.e59d786",
+    "@astryxdesign/lab": "0.6.3-canary.e59d786",
+    "@astryxdesign/theme-neutral": "0.6.3-canary.e59d786"
   },
   "peerDependenciesMeta": {
     "@astryxdesign/charts": {
@@ -121,10 +121,10 @@
     }
   },
   "devDependencies": {
-    "@astryxdesign/charts": "0.6.3-canary.df1837b",
-    "@astryxdesign/core": "0.6.3-canary.df1837b",
-    "@astryxdesign/lab": "0.6.3-canary.df1837b",
-    "@astryxdesign/theme-neutral": "0.6.3-canary.df1837b",
+    "@astryxdesign/charts": "0.6.3-canary.e59d786",
+    "@astryxdesign/core": "0.6.3-canary.e59d786",
+    "@astryxdesign/lab": "0.6.3-canary.e59d786",
+    "@astryxdesign/theme-neutral": "0.6.3-canary.e59d786",
     "@heroicons/react": "^2.2.0",
     "@stylexjs/stylex": "^0.19.0",
     "@types/babel__core": "^7.20.5",

package/assets/codemods/transforms/next/__tests__/migrate-native-picker-to-presentation.test.mjs

@@ -1,63 +0,0 @@
-// Copyright (c) Meta Platforms, Inc. and affiliates.
-
-import {describe, expect, it} from 'vitest';
-import transform from '../migrate-native-picker-to-presentation.mjs';
-
-async function applyTransform(source) {
-  const jscodeshift = (await import('jscodeshift')).default;
-  const j = jscodeshift.withParser('tsx');
-  const api = {jscodeshift: j, stats: () => {}, report: () => {}};
-  return transform({source, path: 'test.tsx'}, api) ?? source;
-}
-
-describe('migrate-native-picker-to-presentation', () => {
-  it('maps DateInput and DateTimeInput values (FR3)', async () => {
-    const output =
-      await applyTransform(`import {DateInput, DateTimeInput} from '@astryxdesign/core';
-const a = <DateInput label="d" nativePicker="touch" />;
-const b = <DateInput label="d" nativePicker="always" />;
-const c = <DateTimeInput label="dt" nativePicker="never" />;`);
-
-    expect(output).toContain("presentation='adaptive-native'");
-    expect(output).toContain("presentation='native'");
-    expect(output).toContain("presentation='adaptive-bottom-sheet'");
-    expect(output).not.toContain('nativePicker');
-  });
-
-  it('maps TimeInput never to text-input (FR3)', async () => {
-    const output =
-      await applyTransform(`import {TimeInput} from '@astryxdesign/core';
-const a = <TimeInput label="t" nativePicker="never" />;
-const b = <TimeInput label="t" nativePicker={'touch'} />;`);
-
-    expect(output).toContain("presentation='text-input'");
-    expect(output).toContain("presentation={'adaptive-native'}");
-  });
-
-  it('drops nativePicker when presentation is already set (FR4)', async () => {
-    const output =
-      await applyTransform(`import {DateInput} from '@astryxdesign/core';
-const a = <DateInput label="d" presentation="popover" nativePicker="always" />;`);
-
-    expect(output).toContain('presentation="popover"');
-    expect(output).not.toContain('nativePicker');
-  });
-
-  it('leaves dynamic values and unrelated components unchanged', async () => {
-    const source = `import {DateInput, Selector} from '@astryxdesign/core';
-const a = <DateInput label="d" nativePicker={mode} />;
-const b = <Selector nativePicker="never" />;`;
-    expect(await applyTransform(source)).toBe(source);
-  });
-
-  it('leaves a mixed static/dynamic conditional byte-identical when a sibling migrates', async () => {
-    const output =
-      await applyTransform(`import {TimeInput} from '@astryxdesign/core';
-const a = <TimeInput label="t" nativePicker="touch" />;
-const b = <TimeInput label="t" nativePicker={flag ? 'always' : mode} />;`);
-
-    expect(output).toContain("presentation='adaptive-native'");
-    expect(output).toContain("nativePicker={flag ? 'always' : mode}");
-    expect(output).not.toContain("'native'");
-  });
-});

package/assets/codemods/transforms/next/migrate-native-picker-to-presentation.mjs

@@ -1,148 +0,0 @@
-// Copyright (c) Meta Platforms, Inc. and affiliates.
-
-/**
- * @file Codemod: migrate nativePicker to presentation on date/time inputs
- *
- * `spec:AST-043` FR3 mapping, applied only to static literals written
- * directly on imported `DateInput`, `DateTimeInput`, and `TimeInput`
- * elements: the prop is renamed to `presentation` and its value mapped.
- * When the element already sets `presentation`, the deprecated prop is
- * removed (presentation wins, FR4). Dynamic values are left unchanged —
- * the deprecated prop keeps working, so an unmigrated callsite is still
- * correct, and guessing at an expression's values would not be.
- */
-
-import {transformProp} from '../../transform-prop.mjs';
-
-export const meta = {
-  title: 'Migrate nativePicker to presentation',
-  description:
-    'Renames `nativePicker` to `presentation` on DateInput, DateTimeInput, ' +
-    'and TimeInput, mapping touch→adaptive-native, always→native, and ' +
-    'never→adaptive-bottom-sheet (text-input for TimeInput). Dynamic ' +
-    'values are left for manual migration; the deprecated prop still works.',
-};
-
-const CORE_IMPORT_RE = /^@(astryxdesign|xds)\/core(?:\/|$)/;
-
-const COMPONENT_PROPS = new Map([
-  ['DateInput', new Set(['nativePicker'])],
-  ['DateTimeInput', new Set(['nativePicker'])],
-  ['TimeInput', new Set(['nativePicker'])],
-]);
-
-/** @param {string} component @param {string} value */
-function mapValue(component, value) {
-  switch (value) {
-    case 'touch':
-      return 'adaptive-native';
-    case 'always':
-      return 'native';
-    case 'never':
-      return component === 'TimeInput' ? 'text-input' : 'adaptive-bottom-sheet';
-    default:
-      return undefined;
-  }
-}
-
-/**
- * Collect the string-literal leaves of a value expression without mutating
- * anything. Returns false for any dynamic or non-string node.
- * @param {any} node
- * @param {any[]} leaves
- * @returns {boolean}
- */
-function collectStaticLeaves(node, leaves) {
-  if (!node) return false;
-  if (
-    node.type === 'TSAsExpression' ||
-    node.type === 'TSSatisfiesExpression' ||
-    node.type === 'TypeCastExpression' ||
-    node.type === 'ParenthesizedExpression'
-  ) {
-    return collectStaticLeaves(node.expression, leaves);
-  }
-  if (node.type === 'ConditionalExpression') {
-    return (
-      collectStaticLeaves(node.consequent, leaves) &&
-      collectStaticLeaves(node.alternate, leaves)
-    );
-  }
-  if (
-    (node.type !== 'StringLiteral' && node.type !== 'Literal') ||
-    typeof node.value !== 'string'
-  ) {
-    return false;
-  }
-  leaves.push(node);
-  return true;
-}
-
-/**
- * Map every leaf, or none of them: a mixed static/dynamic conditional must
- * stay byte-identical, never half-migrated.
- * @param {any} node
- * @param {string} component
- */
-function mapStaticValue(node, component) {
-  /** @type {any[]} */
-  const leaves = [];
-  if (!collectStaticLeaves(node, leaves)) return false;
-  if (leaves.some(leaf => mapValue(component, leaf.value) === undefined)) {
-    return false;
-  }
-  for (const leaf of leaves) {
-    leaf.value = mapValue(component, leaf.value);
-    if (leaf.raw) leaf.raw = undefined;
-  }
-  return true;
-}
-
-/**
- * @param {import('../../../../authoring/codemod/type').AstryxCodemodFile} file
- * @param {import('../../../../authoring/codemod/type').CodemodTransformApi} api
- * @returns {string | null | undefined}
- */
-export default function transformer(file, api) {
-  if (!file.source.includes('nativePicker')) return undefined;
-  const j = api.jscodeshift;
-  const root = j(file.source);
-  let hasChanges = false;
-
-  transformProp(
-    root,
-    j,
-    {
-      matchesImport: source => CORE_IMPORT_RE.test(source),
-      components: COMPONENT_PROPS,
-    },
-    (propPath, {component}) => {
-      const opening = propPath.parent?.node;
-      const attributes = opening?.attributes ?? [];
-      const hasPresentation = attributes.some(
-        (/** @type {any} */ attribute) =>
-          attribute.type === 'JSXAttribute' &&
-          attribute.name?.name === 'presentation',
-      );
-      const prop = propPath.node;
-      if (hasPresentation) {
-        // FR4: presentation wins; drop the deprecated prop.
-        opening.attributes = attributes.filter(
-          (/** @type {any} */ attribute) => attribute !== prop,
-        );
-        hasChanges = true;
-        return;
-      }
-      const value =
-        prop.value?.type === 'JSXExpressionContainer'
-          ? prop.value.expression
-          : prop.value;
-      if (!mapStaticValue(value, component)) return;
-      prop.name.name = 'presentation';
-      hasChanges = true;
-    },
-  );
-
-  if (!hasChanges) return undefined;
-  return root.toSource({quote: 'single'});
-}