@astryxdesign/build 0.3.0 → 0.4.0-canary.3112e99

package/dist/vite.mjs

@@ -1,14 +1,9 @@
 // Built from src/vite.ts — do not edit directly
-var __require = /* @__PURE__ */ ((x) => typeof require !== "undefined" ? require : typeof Proxy !== "undefined" ? new Proxy(x, {
-  get: (a, b) => (typeof require !== "undefined" ? require : a)[b]
-}) : x)(function(x) {
-  if (typeof require !== "undefined") return require.apply(this, arguments);
-  throw Error('Dynamic require of "' + x + '" is not supported');
-});
 
 // src/vite.ts
 import stylexBabelPlugin from "@stylexjs/babel-plugin";
 import stylex from "@stylexjs/unplugin";
+import fs from "node:fs";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
 var __dirname = path.dirname(fileURLToPath(import.meta.url));
@@ -82,7 +77,6 @@ function astryxStylex(options = {}) {
     config() {
       let xdsPackages = ["@astryxdesign/core"];
       try {
-        const fs = __require("node:fs");
         const xdsDir = path.resolve(rootDir, "node_modules/@astryxdesign");
         if (fs.existsSync(xdsDir)) {
           xdsPackages = fs.readdirSync(xdsDir).filter((name) => !name.startsWith(".")).map((name) => `@astryxdesign/${name}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@astryxdesign/build",
-  "version": "0.3.0",
+  "version": "0.4.0-canary.3112e99",
   "description": "Build plugins for XDS source builds — babel, PostCSS, and Vite integrations",
   "author": "Meta Open Source",
   "license": "MIT",

package/src/vite.test.ts

@@ -7,13 +7,22 @@
  *   theme layer name is fixed at `astryx-theme`.
  */
 
-import {describe, it, expect} from 'vitest';
+import {describe, it, expect, beforeAll, afterAll} from 'vitest';
+import {mkdtempSync, mkdirSync, rmSync} from 'node:fs';
+import {tmpdir} from 'node:os';
+import path from 'node:path';
+import {fileURLToPath, pathToFileURL} from 'node:url';
 import {astryxStylex} from './vite';
 
+const __dirname = path.dirname(fileURLToPath(import.meta.url));
+
 /** Pull the injected `@layer ...;` order statement out of the plugin set. */
 function getLayerOrder(plugins: ReturnType<typeof astryxStylex>): string {
   const layerPlugin = plugins.find(p => p.name === 'astryx-css-layer-order');
-  expect(layerPlugin, 'astryx-css-layer-order plugin should exist').toBeTruthy();
+  expect(
+    layerPlugin,
+    'astryx-css-layer-order plugin should exist',
+  ).toBeTruthy();
   const transform = (layerPlugin as any).transformIndexHtml;
   const tags =
     typeof transform === 'function' ? transform() : transform.handler();
@@ -43,3 +52,98 @@ describe('astryxStylex layer order (legacy API)', () => {
     expect(order).toBe('@layer reset, astryx-base, astryx-theme, product;');
   });
 });
+
+describe('astryxStylex optimizeDeps package discovery', () => {
+  let rootDir: string;
+
+  beforeAll(() => {
+    rootDir = mkdtempSync(path.join(tmpdir(), 'astryx-vite-'));
+    for (const pkg of ['core', 'icons', 'charts']) {
+      mkdirSync(path.join(rootDir, 'node_modules', '@astryxdesign', pkg), {
+        recursive: true,
+      });
+    }
+    mkdirSync(path.join(rootDir, 'node_modules', '@astryxdesign', '.cache'), {
+      recursive: true,
+    });
+  });
+
+  afterAll(() => {
+    rmSync(rootDir, {recursive: true, force: true});
+  });
+
+  function getExclude(rootDirOption: string): string[] {
+    const plugins = astryxStylex({rootDir: rootDirOption});
+    const configPlugin = plugins.find(p => p.name === 'astryx-config');
+    expect(configPlugin, 'astryx-config plugin should exist').toBeTruthy();
+    const config = (configPlugin as any).config;
+    const result = typeof config === 'function' ? config() : config.handler();
+    return result.optimizeDeps.exclude;
+  }
+
+  it('excludes every installed @astryxdesign/* package, not just core', () => {
+    expect(getExclude(rootDir).sort()).toEqual([
+      '@astryxdesign/charts',
+      '@astryxdesign/core',
+      '@astryxdesign/icons',
+    ]);
+  });
+
+  it('falls back to @astryxdesign/core when no packages are installed', () => {
+    expect(getExclude(path.join(rootDir, 'does-not-exist'))).toEqual([
+      '@astryxdesign/core',
+    ]);
+  });
+
+  // Vitest's module transform provides a working `require` even for dynamic
+  // file-URL imports, so an in-process test cannot catch CJS-isms that only
+  // break in the shipped ESM bundle. This test compiles vite.ts exactly like
+  // build.mjs does, then runs the discovery in a child `node` process under
+  // real ESM semantics (where `require` is undefined).
+  it('still discovers packages in the compiled ESM bundle (dist contract)', async () => {
+    const {buildSync} = await import('esbuild');
+    const {execFileSync} = await import('node:child_process');
+    // Emit next to src/ so the bundle's externals (vite, @stylexjs/*)
+    // resolve against this package's node_modules; dist/ is gitignored.
+    const outfile = path.join(__dirname, '..', 'dist', 'vite.test-esm.mjs');
+    try {
+      buildSync({
+        entryPoints: [path.join(__dirname, 'vite.ts')],
+        bundle: true,
+        platform: 'node',
+        format: 'esm',
+        outfile,
+        // SYNC: keep aligned with the external list in build.mjs
+        external: [
+          'vite',
+          '@stylexjs/babel-plugin',
+          '@stylexjs/unplugin',
+          'path',
+          'url',
+          'node:fs',
+          'node:path',
+          'node:url',
+        ],
+      });
+      const script = [
+        `const {astryxStylex} = await import(${JSON.stringify(pathToFileURL(outfile).href)});`,
+        `const plugin = astryxStylex({rootDir: ${JSON.stringify(rootDir)}})`,
+        `  .find(p => p.name === 'astryx-config');`,
+        `console.log(JSON.stringify(plugin.config().optimizeDeps.exclude));`,
+      ].join('\n');
+      const stdout = execFileSync(
+        process.execPath,
+        ['--input-type=module', '-e', script],
+        {encoding: 'utf8'},
+      );
+      const exclude: string[] = JSON.parse(stdout.trim());
+      expect(exclude.sort()).toEqual([
+        '@astryxdesign/charts',
+        '@astryxdesign/core',
+        '@astryxdesign/icons',
+      ]);
+    } finally {
+      rmSync(outfile, {force: true});
+    }
+  });
+});

package/src/vite.ts

@@ -3,6 +3,7 @@
 import type {Plugin, UserConfig} from 'vite';
 import stylexBabelPlugin from '@stylexjs/babel-plugin';
 import stylex from '@stylexjs/unplugin';
+import fs from 'node:fs';
 import path from 'node:path';
 import {fileURLToPath} from 'node:url';
 
@@ -189,13 +190,12 @@ export function astryxStylex(
       // strips stylex.create/defineVars calls and causes runtime errors.
       let xdsPackages: string[] = ['@astryxdesign/core'];
       try {
-        const fs = require('node:fs');
         const xdsDir = path.resolve(rootDir, 'node_modules/@astryxdesign');
         if (fs.existsSync(xdsDir)) {
           xdsPackages = fs
             .readdirSync(xdsDir)
-            .filter((name: string) => !name.startsWith('.'))
-            .map((name: string) => `@astryxdesign/${name}`);
+            .filter(name => !name.startsWith('.'))
+            .map(name => `@astryxdesign/${name}`);
         }
       } catch {
         // Fallback to just @astryxdesign/core if discovery fails