@astroscope/eslint-plugin-i18n 0.1.1 → 0.1.3

package/dist/index.js

@@ -41,14 +41,21 @@ var DEFAULT_IGNORE_PATTERNS = [
   // numbers
   /^\s*\|\s*$/,
   // pipe separators
-  /^\s*[•·–—]\s*$/
+  /^\s*[•·–—]\s*$/,
   // bullets / dashes
+  /^[\s\p{P}\p{S}]+$/u,
+  // punctuation / symbols only (e.g. "(", ",", "/ —")
+  /^#[0-9a-fA-F]{3,8}$/,
+  // hex colors (e.g. "#003366", "#fff")
+  /^\d+x\d+$/
+  // dimensions (e.g. "180x180")
 ];
 var DEFAULT_IGNORE_ATTRIBUTES = [
-  "className",
-  "class",
+  // html attributes
   "id",
-  "key",
+  "class",
+  "className",
+  "style",
   "href",
   "src",
   "type",
@@ -60,9 +67,93 @@ var DEFAULT_IGNORE_ATTRIBUTES = [
   "rel",
   "method",
   "action",
+  "loading",
+  "decoding",
+  "autoComplete",
+  "allow",
+  "as",
+  "sizes",
+  "color",
+  "crossorigin",
+  "fetchPriority",
+  "fetchpriority",
+  "referrerpolicy",
+  "charset",
+  "lang",
+  "property",
+  "itemprop",
+  "itemtype",
+  "form",
+  "key",
+  "slot",
+  // common component props
+  "variant",
+  "size",
+  "mode",
+  "orientation",
+  "align",
+  "icon",
+  "tag",
+  "tagName",
+  // html aria attributes (non-text)
+  "aria-hidden",
+  "aria-live",
+  "aria-atomic",
+  // astro attributes
+  "class:list",
+  // testing attributes
   "data-testid",
   "data-cy",
-  "slot"
+  // svg attributes
+  "d",
+  "viewBox",
+  "xmlns",
+  "fill",
+  "stroke",
+  "strokeWidth",
+  "strokeLinecap",
+  "strokeLinejoin",
+  "clipPath",
+  "transform",
+  "points",
+  "pathLength",
+  "filter",
+  "filterUnits",
+  "colorInterpolationFilters",
+  "floodOpacity",
+  "in",
+  "in2",
+  "result",
+  "stroke-linecap",
+  "stroke-linejoin",
+  "clip-rule",
+  "fill-rule",
+  "path",
+  "values",
+  "operator",
+  "mode",
+  "stdDeviation",
+  "dy",
+  "dx",
+  "x",
+  "y",
+  "x1",
+  "x2",
+  "y1",
+  "y2",
+  "cx",
+  "cy",
+  "r",
+  "rx",
+  "ry",
+  "width",
+  "height"
+];
+var DEFAULT_IGNORE_ATTRIBUTE_PATTERNS = [
+  /classNames?$/i,
+  // *ClassName, *classNames, *classname (e.g. labelClassName, classNames)
+  /^data-/
+  // data-* attributes
 ];
 var noRawStringsInJsx = {
   meta: {
@@ -92,21 +183,30 @@ var noRawStringsInJsx = {
   },
   create(context) {
     const options = context.options[0] ?? {};
-    const userPatterns = (options.ignorePatterns ?? []).map((p) => new RegExp(p));
-    const allPatterns = [...DEFAULT_IGNORE_PATTERNS, ...userPatterns];
-    const ignoreAttributes = /* @__PURE__ */ new Set([...DEFAULT_IGNORE_ATTRIBUTES, ...options.ignoreAttributes ?? []]);
+    const allPatterns = options.ignorePatterns ? options.ignorePatterns.map((p) => new RegExp(p)) : DEFAULT_IGNORE_PATTERNS;
+    const ignoreAttributes = new Set(options.ignoreAttributes ?? DEFAULT_IGNORE_ATTRIBUTES);
     function shouldIgnore(text) {
       return allPatterns.some((p) => p.test(text));
     }
-    function isInsideIgnoredAttribute(node) {
-      const parent = node.parent;
-      if (parent?.type === "JSXAttribute") {
-        const attrName = parent.name?.type === "JSXIdentifier" ? parent.name.name : parent.name?.type === "JSXNamespacedName" ? `${parent.name.namespace.name}:${parent.name.name.name}` : null;
-        if (attrName && ignoreAttributes.has(attrName)) return true;
+    function shouldIgnoreAttribute(name) {
+      if (ignoreAttributes.has(name)) return true;
+      return DEFAULT_IGNORE_ATTRIBUTE_PATTERNS.some((p) => p.test(name));
+    }
+    function getAttributeName(node) {
+      if (node.name?.type === "JSXIdentifier") return node.name.name;
+      if (node.name?.type === "JSXNamespacedName") {
+        return `${node.name.namespace.name}:${node.name.name.name}`;
       }
-      if (parent?.type === "JSXExpressionContainer" && parent.parent?.type === "JSXAttribute") {
-        const attrName = parent.parent.name?.type === "JSXIdentifier" ? parent.parent.name.name : null;
-        if (attrName && ignoreAttributes.has(attrName)) return true;
+      return null;
+    }
+    function isInsideIgnoredAttribute(node) {
+      let current = node.parent;
+      while (current) {
+        if (current.type === "JSXAttribute") {
+          const attrName = getAttributeName(current);
+          return attrName ? shouldIgnoreAttribute(attrName) : false;
+        }
+        current = current.parent;
       }
       return false;
     }
@@ -130,12 +230,30 @@ var noRawStringsInJsx = {
         if (shouldIgnore(text)) return;
         if (isInsideIgnoredAttribute(node)) return;
         const attrName = node.name?.type === "JSXIdentifier" ? node.name.name : node.name?.type === "JSXNamespacedName" ? `${node.name.namespace.name}:${node.name.name.name}` : null;
-        if (attrName && ignoreAttributes.has(attrName)) return;
+        if (attrName && shouldIgnoreAttribute(attrName)) return;
         context.report({
           node: node.value,
           messageId: "rawString",
           data: { text: text.length > 40 ? `${text.slice(0, 40)}...` : text }
         });
+      },
+      // string literals inside JSX expressions: <div title={value ?? 'fallback'} /> or <div>{'text'}</div>
+      Literal(node) {
+        if (typeof node.value !== "string") return;
+        const ancestors = context.sourceCode.getAncestors(node);
+        const inJsxExpression = ancestors.some((a) => a.type === "JSXExpressionContainer");
+        if (!inJsxExpression) return;
+        if (ancestors.some((a) => a.type === "CallExpression")) return;
+        if (node.parent?.type === "BinaryExpression") return;
+        if (node.parent?.type === "TSAsExpression") return;
+        const text = node.value;
+        if (shouldIgnore(text)) return;
+        if (isInsideIgnoredAttribute(node)) return;
+        context.report({
+          node,
+          messageId: "rawString",
+          data: { text: text.length > 40 ? `${text.slice(0, 40)}...` : text }
+        });
       }
     };
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@astroscope/eslint-plugin-i18n",
-  "version": "0.1.1",
+  "version": "0.1.3",
   "description": "ESLint rules for @astroscope/i18n",
   "type": "module",
   "main": "./dist/index.js",