@astrojs/mdx 0.11.2 → 0.11.4

package/.turbo/turbo-build.log

@@ -1,5 +1,5 @@
-@astrojs/mdx:build: cache hit, replaying output efbc0a3c2d5779f7
-@astrojs/mdx:build: 
-@astrojs/mdx:build: > @astrojs/mdx@0.11.2 build /home/runner/work/astro/astro/packages/integrations/mdx
-@astrojs/mdx:build: > astro-scripts build "src/**/*.ts" && tsc
-@astrojs/mdx:build: 
+@astrojs/mdx:build: cache hit, replaying output f5624f774ddb4884
+@astrojs/mdx:build: 
+@astrojs/mdx:build: > @astrojs/mdx@0.11.4 build /home/runner/work/astro/astro/packages/integrations/mdx
+@astrojs/mdx:build: > astro-scripts build "src/**/*.ts" && tsc
+@astrojs/mdx:build: 

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @astrojs/mdx
 
+## 0.11.4
+
+### Patch Changes
+
+- [#4953](https://github.com/withastro/astro/pull/4953) [`a59731995`](https://github.com/withastro/astro/commit/a59731995b93ae69c21dc3adc5c8b482b466d12e) Thanks [@bluwy](https://github.com/bluwy)! - Log markdown hints with console.info
+
+## 0.11.3
+
+### Patch Changes
+
+- [#4842](https://github.com/withastro/astro/pull/4842) [`812658ad2`](https://github.com/withastro/astro/commit/812658ad2ab3732a99e35c4fd903e302e723db46) Thanks [@bluwy](https://github.com/bluwy)! - Add missing dependencies, support strict dependency installation (e.g. pnpm)
+
 ## 0.11.2
 
 ### Patch Changes

package/dist/index.js

@@ -24,15 +24,15 @@ function mdx(mdxOptions = {}) {
         handleExtendsNotSupported(mdxOptions.remarkPlugins);
         handleExtendsNotSupported(mdxOptions.rehypePlugins);
         if (mdxOptions.extendPlugins === "markdown" && (((_a = config.markdown.rehypePlugins) == null ? void 0 : _a.length) || ((_b = config.markdown.remarkPlugins) == null ? void 0 : _b.length))) {
-          console.log(
+          console.info(
             blue(`[MDX] Now inheriting remark and rehype plugins from "markdown" config.`)
           );
-          console.log(
+          console.info(
             `If you applied a plugin to both your Markdown and MDX configs, we suggest ${bold(
               "removing the duplicate MDX entry."
             )}`
           );
-          console.log(`See "extendPlugins" option to configure this behavior.`);
+          console.info(`See "extendPlugins" option to configure this behavior.`);
         }
         const mdxPluginOpts = {
           remarkPlugins: await getRemarkPlugins(mdxOptions, config),

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@astrojs/mdx",
   "description": "Use MDX within Astro",
-  "version": "0.11.2",
+  "version": "0.11.4",
   "type": "module",
   "types": "./dist/index.d.ts",
   "author": "withastro",
@@ -43,17 +43,21 @@
   "devDependencies": {
     "@types/chai": "^4.3.1",
     "@types/estree": "^1.0.0",
+    "@types/github-slugger": "^1.3.0",
     "@types/mocha": "^9.1.1",
     "@types/yargs-parser": "^21.0.0",
-    "astro": "1.3.1",
+    "astro": "1.4.3",
     "astro-scripts": "0.0.8",
     "chai": "^4.3.6",
+    "cheerio": "^1.0.0-rc.11",
     "linkedom": "^0.14.12",
+    "mdast-util-mdx": "^2.0.0",
     "mdast-util-to-string": "^3.1.0",
     "mocha": "^9.2.2",
     "reading-time": "^1.5.0",
     "remark-shiki-twoslash": "^3.1.0",
-    "remark-toc": "^8.0.1"
+    "remark-toc": "^8.0.1",
+    "vite": "^3.0.0"
   },
   "engines": {
     "node": "^14.18.0 || >=16.12.0"

package/src/index.ts

@@ -50,15 +50,15 @@ export default function mdx(mdxOptions: MdxOptions = {}): AstroIntegration {
 					mdxOptions.extendPlugins === 'markdown' &&
 					(config.markdown.rehypePlugins?.length || config.markdown.remarkPlugins?.length)
 				) {
-					console.log(
+					console.info(
 						blue(`[MDX] Now inheriting remark and rehype plugins from "markdown" config.`)
 					);
-					console.log(
+					console.info(
 						`If you applied a plugin to both your Markdown and MDX configs, we suggest ${bold(
 							'removing the duplicate MDX entry.'
 						)}`
 					);
-					console.log(`See "extendPlugins" option to configure this behavior.`);
+					console.info(`See "extendPlugins" option to configure this behavior.`);
 				}
 
 				const mdxPluginOpts: MdxRollupPluginOptions = {

package/test/fixtures/mdx-infinite-loop/astro.config.ts

@@ -0,0 +1,6 @@
+import mdx from '@astrojs/mdx';
+import preact from '@astrojs/preact';
+
+export default {
+	integrations: [mdx(), preact()]
+}

package/test/fixtures/mdx-infinite-loop/node_modules/.bin/astro

@@ -0,0 +1,17 @@
+#!/bin/sh
+basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
+
+case `uname` in
+    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
+esac
+
+if [ -z "$NODE_PATH" ]; then
+  export NODE_PATH="/home/runner/work/astro/astro/node_modules/.pnpm/node_modules"
+else
+  export NODE_PATH="$NODE_PATH:/home/runner/work/astro/astro/node_modules/.pnpm/node_modules"
+fi
+if [ -x "$basedir/node" ]; then
+  exec "$basedir/node"  "$basedir/../../../../../../../astro/astro.js" "$@"
+else
+  exec node  "$basedir/../../../../../../../astro/astro.js" "$@"
+fi

package/test/fixtures/mdx-infinite-loop/package.json

@@ -0,0 +1,10 @@
+{
+  "name": "@test/mdx-infinite-loop",
+  "type": "module",
+  "dependencies": {
+    "@astrojs/mdx": "workspace:*",
+    "@astrojs/preact": "workspace:*",
+    "preact": "^10.7.3",
+    "astro": "workspace:*"
+  }
+}

package/test/fixtures/mdx-infinite-loop/src/components/Test.js

@@ -0,0 +1,3 @@
+export default function () {
+	return 'Hello world'
+}

package/test/fixtures/mdx-infinite-loop/src/pages/doc.mdx

@@ -0,0 +1,6 @@
+import Test, { Missing } from '../components/Test';
+
+# Hello page!
+
+<Test />
+<Missing />

package/test/fixtures/mdx-infinite-loop/src/pages/index.astro

@@ -0,0 +1,5 @@
+---
+const files = await Astro.glob('./**/*.mdx')
+---
+
+{files.map((file: any) => <file.Content />)}

package/test/fixtures/mdx-namespace/package.json

@@ -1,8 +1,10 @@
 {
   "name": "@test/mdx-namespace",
   "dependencies": {
-    "astro": "workspace:*",
     "@astrojs/mdx": "workspace:*",
-    "@astrojs/react": "workspace:*"
+    "@astrojs/react": "workspace:*",
+    "astro": "workspace:*",
+    "react": "^18.2.0",
+    "react-dom": "^18.1.0"
   }
 }

package/test/fixtures/mdx-page/package.json

@@ -1,7 +1,9 @@
 {
   "name": "@test/mdx-page",
   "dependencies": {
+    "@astrojs/mdx": "workspace:*",
     "astro": "workspace:*",
-    "@astrojs/mdx": "workspace:*"
+    "react": "^18.2.0",
+    "react-dom": "^18.2.0"
   }
 }

package/test/fixtures/mdx-plus-react/package.json

@@ -1,8 +1,10 @@
 {
   "name": "@test/mdx-plus-react",
   "dependencies": {
-    "astro": "workspace:*",
     "@astrojs/mdx": "workspace:*",
-    "@astrojs/react": "workspace:*"
+    "@astrojs/react": "workspace:*",
+    "astro": "workspace:*",
+    "react": "^18.2.0",
+    "react-dom": "^18.2.0"
   }
 }

package/test/mdx-infinite-loop.test.js

@@ -0,0 +1,30 @@
+import mdx from '@astrojs/mdx';
+
+import { expect } from 'chai';
+import { loadFixture } from '../../../astro/test/test-utils.js';
+
+describe('MDX Infinite Loop', () => {
+	let fixture;
+
+	before(async () => {
+		fixture = await loadFixture({
+			root: new URL('./fixtures/mdx-infinite-loop/', import.meta.url),
+			integrations: [mdx()],
+		});
+	});
+
+	describe('build', () => {
+		let err;
+		before(async () => {
+			try {
+				await fixture.build();
+			} catch (e) {
+				err = e;
+			}
+		});
+
+		it('does not hang forever if an error is thrown', async () => {
+			expect(!!err).to.be.true;
+		});
+	});
+});