@astrojs/language-server 0.22.0 → 0.23.2

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # @astrojs/language-server
 
+## 0.23.2
+
+### Patch Changes
+
+- b13fb51: Don't use `workspace/configuration` on clients that don't support it
+
+## 0.23.1
+
+### Patch Changes
+
+- 422376e: Load settings from the Prettier VS Code extension when available
+
+## 0.23.0
+
+### Minor Changes
+
+- 1dcef68: Automatically type `Astro.props` using the Props interface when available
+
+### Patch Changes
+
+- b6c95f2: Fix completions for HTML attributes not working anymore since 0.20.3
+
 ## 0.22.0
 
 ### Minor Changes

package/dist/core/config/ConfigManager.d.ts

@@ -13,16 +13,18 @@ declare type DeepPartial<T> = T extends Record<string, unknown> ? {
  * For more info on this, see the [internal docs](../../../../../docs/internal/language-server/config.md)
  */
 export declare class ConfigManager {
+    private connection?;
+    private hasConfigurationCapability?;
     private globalConfig;
     private documentSettings;
     shouldRefreshTSServices: boolean;
     private isTrusted;
-    private connection;
-    constructor(connection?: Connection);
+    constructor(connection?: Connection | undefined, hasConfigurationCapability?: boolean | undefined);
     updateConfig(): void;
     removeDocument(scopeUri: string): void;
     getConfig<T>(section: string, scopeUri: string): Promise<T | Record<string, any>>;
     getEmmetConfig(document: TextDocument): Promise<VSCodeEmmetConfig>;
+    getPrettierVSConfig(document: TextDocument): Promise<Record<string, any>>;
     getTSFormatConfig(document: TextDocument, vscodeOptions?: FormattingOptions): Promise<FormatCodeSettings>;
     getTSPreferences(document: TextDocument): Promise<UserPreferences>;
     getTSInlayHintsPreferences(document: TextDocument): Promise<InlayHintsOptions>;

package/dist/core/config/ConfigManager.js

@@ -46,13 +46,14 @@ exports.defaultLSConfig = {
  * For more info on this, see the [internal docs](../../../../../docs/internal/language-server/config.md)
  */
 class ConfigManager {
-    constructor(connection) {
+    constructor(connection, hasConfigurationCapability) {
+        this.connection = connection;
+        this.hasConfigurationCapability = hasConfigurationCapability;
         this.globalConfig = { astro: exports.defaultLSConfig };
         this.documentSettings = {};
         // If set to true, the next time we need a TypeScript language service, we'll rebuild it so it gets the new config
         this.shouldRefreshTSServices = false;
         this.isTrusted = true;
-        this.connection = connection;
     }
     updateConfig() {
         // Reset all cached document settings
@@ -63,7 +64,7 @@ class ConfigManager {
         delete this.documentSettings[scopeUri];
     }
     async getConfig(section, scopeUri) {
-        if (!this.connection) {
+        if (!this.connection || !this.hasConfigurationCapability) {
             return (0, utils_1.get)(this.globalConfig, section) ?? {};
         }
         if (!this.documentSettings[scopeUri]) {
@@ -90,6 +91,10 @@ class ConfigManager {
             showSuggestionsAsSnippets: emmetConfig.showSuggestionsAsSnippets ?? false,
         };
     }
+    async getPrettierVSConfig(document) {
+        const prettierVSConfig = (await this.getConfig('prettier', document.uri)) ?? {};
+        return prettierVSConfig;
+    }
     async getTSFormatConfig(document, vscodeOptions) {
         const formatConfig = (await this.getConfig('typescript.format', document.uri)) ?? {};
         return {

package/dist/plugins/astro/AstroPlugin.js

@@ -3,7 +3,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.AstroPlugin = void 0;
 const vscode_languageserver_1 = require("vscode-languageserver");
 const importPackage_1 = require("../../importPackage");
-const utils_1 = require("../../utils");
 const CompletionsProvider_1 = require("./features/CompletionsProvider");
 class AstroPlugin {
     constructor(configManager, languageServiceManager) {
@@ -22,14 +21,19 @@ class AstroPlugin {
             return [];
         }
         const prettier = (0, importPackage_1.importPrettier)(filePath);
-        const prettierConfig = await prettier.resolveConfig(filePath, { editorconfig: true, useCache: false });
-        const editorFormatConfig = options !== undefined
+        const prettierConfig = (await prettier.resolveConfig(filePath, { editorconfig: true, useCache: false })) ?? {};
+        const prettierVSConfig = await this.configManager.getPrettierVSConfig(document);
+        const editorFormatConfig = options !== undefined // We need to check for options existing here because some editors might not have it
             ? {
-                tabWidth: prettierConfig?.tabWidth ?? options.tabSize,
-                useTabs: prettierConfig?.useTabs ?? !options.insertSpaces,
+                tabWidth: options.tabSize,
+                useTabs: !options.insertSpaces,
             }
             : {};
-        const resultConfig = (0, utils_1.mergeDeep)(prettierConfig ?? {}, editorFormatConfig);
+        // Return a config with the following cascade:
+        // - Prettier config file should always win if it exists, if it doesn't:
+        // - Prettier config from the VS Code extension is used, if it doesn't exist:
+        // - Use the editor's basic configuration settings
+        const resultConfig = returnObjectIfHasKeys(prettierConfig) || returnObjectIfHasKeys(prettierVSConfig) || editorFormatConfig;
         const fileInfo = await prettier.getFileInfo(filePath, { ignorePath: '.prettierignore' });
         if (fileInfo.ignored) {
             return [];
@@ -74,3 +78,8 @@ class AstroPlugin {
     }
 }
 exports.AstroPlugin = AstroPlugin;
+function returnObjectIfHasKeys(obj) {
+    if (Object.keys(obj || {}).length > 0) {
+        return obj;
+    }
+}

package/dist/plugins/html/HTMLPlugin.js

@@ -76,12 +76,16 @@ class HTMLPlugin {
         const inTagName = (0, utils_1.isInTagName)(html, offset);
         const results = inComponentTag && !inTagName
             ? (0, utils_2.removeDataAttrCompletion)(this.attributeOnlyLang.doComplete(document, position, html).items)
-            : // We filter items with no documentation to prevent duplicates with our own defined script and style tags
-                this.lang.doComplete(document, position, html).items.filter((item) => item.documentation !== undefined);
+            : this.lang.doComplete(document, position, html).items.filter(isNoAddedTagWithNoDocumentation);
         const langCompletions = inComponentTag ? [] : this.getLangCompletions(results);
         return vscode_languageserver_1.CompletionList.create([...results, ...langCompletions, ...emmetResults.items], 
         // Emmet completions change on every keystroke, so they are never complete
         emmetResults.items.length > 0);
+        // Filter script and style completions with no documentation to prevent duplicates
+        // due to our added definitions for those tags
+        function isNoAddedTagWithNoDocumentation(item) {
+            return !(['script', 'style'].includes(item.label) && item.documentation === undefined);
+        }
     }
     getFoldingRanges(document) {
         const html = document.html;

package/dist/plugins/typescript/astro2tsx.js

@@ -4,10 +4,24 @@ const os_1 = require("os");
 const parseAstro_1 = require("../../core/documents/parseAstro");
 function addProps(content, className) {
     let defaultExportType = 'Record<string, any>';
+    let shouldAddGlobal = false;
+    let astroGlobal = "type AstroGlobal = import('astro').AstroGlobal";
+    const astroGlobalConstDef = `
+	/**
+	 * Astro global available in all contexts in .astro files
+	 *
+	 * [Astro documentation](https://docs.astro.build/reference/api-reference/#astro-global)
+	 */
+	declare const Astro: Readonly<AstroGlobal>;
+	`;
     if (/(interface|type) Props/.test(content)) {
         defaultExportType = 'Props';
+        shouldAddGlobal = true;
+        astroGlobal += ' & { props: Props }';
     }
-    return os_1.EOL + `export default function ${className}__AstroComponent_(_props: ${defaultExportType}): any {}`;
+    return (os_1.EOL +
+        (shouldAddGlobal ? astroGlobal + os_1.EOL + astroGlobalConstDef : '') +
+        `export default function ${className}__AstroComponent_(_props: ${defaultExportType}): any {}`);
 }
 function escapeTemplateLiteralContent(content) {
     return content.replace(/`/g, '\\`');

package/dist/server.js

@@ -44,7 +44,7 @@ function startLanguageServer(connection) {
     // Create our managers
     const documentManager = new DocumentManager_1.DocumentManager();
     const pluginHost = new PluginHost_1.PluginHost(documentManager);
-    const configManager = new ConfigManager_1.ConfigManager(connection);
+    let configManager;
     let typescriptPlugin = undefined;
     let hasConfigurationCapability = false;
     connection.onInitialize((params) => {
@@ -66,6 +66,7 @@ function startLanguageServer(connection) {
             }
         });
         hasConfigurationCapability = !!(params.capabilities.workspace && !!params.capabilities.workspace.configuration);
+        configManager = new ConfigManager_1.ConfigManager(connection, hasConfigurationCapability);
         pluginHost.initialize({
             filterIncompleteCompletions: !params.initializationOptions?.dontFilterIncompleteCompletions,
             definitionLinkSupport: !!params.capabilities.textDocument?.definition?.linkSupport,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@astrojs/language-server",
-  "version": "0.22.0",
+  "version": "0.23.2",
   "author": "withastro",
   "license": "MIT",
   "type": "commonjs",
@@ -21,7 +21,7 @@
   "dependencies": {
     "@vscode/emmet-helper": "^2.8.4",
     "prettier": "^2.7.1",
-    "prettier-plugin-astro": "^0.5.0",
+    "prettier-plugin-astro": "^0.5.3",
     "source-map": "^0.7.3",
     "typescript": "~4.6.4",
     "vscode-css-languageservice": "^6.0.1",