@astrojs/language-server 0.20.0 → 0.20.1

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @astrojs/language-server
 
+## 0.20.1
+
+### Patch Changes
+
+- e6996f5: Fixed many situations where the language server would warn abusively about not being able to find Astro
+- 4589c2b: Fix the language server not warning properly when a package is implicitely any due to missing types
+
 ## 0.20.0
 
 ### Minor Changes

package/dist/plugins/typescript/features/DiagnosticsProvider.d.ts

@@ -12,7 +12,6 @@ export declare enum DiagnosticCodes {
     ISOLATED_MODULE_COMPILE_ERR = 1208,
     TYPE_NOT_ASSIGNABLE = 2322,
     JSX_NO_CLOSING_TAG = 17008,
-    NO_DECL_IMPLICIT_ANY_TYPE = 7016,
     JSX_ELEMENT_NO_CALL = 2604
 }
 export declare class DiagnosticsProviderImpl implements DiagnosticsProvider {

package/dist/plugins/typescript/features/DiagnosticsProvider.js

@@ -20,7 +20,6 @@ var DiagnosticCodes;
     DiagnosticCodes[DiagnosticCodes["ISOLATED_MODULE_COMPILE_ERR"] = 1208] = "ISOLATED_MODULE_COMPILE_ERR";
     DiagnosticCodes[DiagnosticCodes["TYPE_NOT_ASSIGNABLE"] = 2322] = "TYPE_NOT_ASSIGNABLE";
     DiagnosticCodes[DiagnosticCodes["JSX_NO_CLOSING_TAG"] = 17008] = "JSX_NO_CLOSING_TAG";
-    DiagnosticCodes[DiagnosticCodes["NO_DECL_IMPLICIT_ANY_TYPE"] = 7016] = "NO_DECL_IMPLICIT_ANY_TYPE";
     DiagnosticCodes[DiagnosticCodes["JSX_ELEMENT_NO_CALL"] = 2604] = "JSX_ELEMENT_NO_CALL";
 })(DiagnosticCodes = exports.DiagnosticCodes || (exports.DiagnosticCodes = {}));
 class DiagnosticsProviderImpl {
@@ -87,7 +86,6 @@ class DiagnosticsProviderImpl {
                 isNoSpreadExpected(diag, document) &&
                 isNoCantReturnOutsideFunction(diag) &&
                 isNoIsolatedModuleError(diag) &&
-                isNoImportImplicitAnyType(diag) &&
                 isNoJsxCannotHaveMultipleAttrsError(diag));
         })
             .map(enhanceIfNecessary);
@@ -173,9 +171,6 @@ function isNoJsxCannotHaveMultipleAttrsError(diagnostic) {
 function isNoJSXMustHaveOneParent(diagnostic) {
     return diagnostic.code !== DiagnosticCodes.MUST_HAVE_PARENT_ELEMENT;
 }
-function isNoImportImplicitAnyType(diagnostic) {
-    return diagnostic.code !== DiagnosticCodes.NO_DECL_IMPLICIT_ANY_TYPE;
-}
 /**
  * When using the shorthand syntax for props TSX expects you to use the spread operator
  * Since the shorthand syntax works differently in Astro and this is not required, hide this message
@@ -191,7 +186,7 @@ function isNoSpreadExpected(diagnostic, document) {
 }
 /**
  * Ignore "Can't return outside of function body"
- * Since the frontmatter is at the top level, users trying to return a Response  for SSR mode run into this
+ * Since the frontmatter is at the top level, users trying to return a Response for SSR mode run into this
  */
 function isNoCantReturnOutsideFunction(diagnostic) {
     return diagnostic.code !== DiagnosticCodes.CANT_RETURN_OUTSIDE_FUNC;
@@ -218,6 +213,7 @@ function enhanceIfNecessary(diagnostic) {
             diagnostic.message +=
                 '\n\nIs the `@astrojs/vue` package installed? You can add it to your project by running the following command: `astro add vue`. If already installed, restarting the language server might be necessary in order for the change to take effect';
         }
+        return diagnostic;
     }
     // JSX element has no closing tag. JSX -> HTML
     if (diagnostic.code === DiagnosticCodes.JSX_NO_CLOSING_TAG) {
@@ -237,7 +233,7 @@ function enhanceIfNecessary(diagnostic) {
     }
     // For the rare case where an user might try to put a client directive on something that is not a component
     if (diagnostic.code === DiagnosticCodes.TYPE_NOT_ASSIGNABLE) {
-        if (diagnostic.message.includes("Property 'client:") && diagnostic.message.includes("to type 'HTMLProps")) {
+        if (diagnostic.message.includes("Property 'client:") && diagnostic.message.includes("to type 'HTMLAttributes")) {
             return {
                 ...diagnostic,
                 message: 'Client directives are only available on framework components',

package/dist/plugins/typescript/language-service.js

@@ -90,7 +90,9 @@ async function createLanguageService(tsconfigPath, docContext, workspaceUris) {
     const scriptFileNames = [];
     // Before Astro 1.0, JSX definitions were inside of the language-server instead of inside Astro
     // TODO: Remove this and astro-jsx.d.ts in types when we consider having support for Astro < 1.0 unnecessary
-    if (astroVersion.major === 0 || astroVersion.full === '1.0.0-beta.0') {
+    if ((astroVersion.major === 0 || astroVersion.full === '1.0.0-beta.0') &&
+        !astroVersion.full.startsWith('0.0.0-rc-') // 1.0.0's RC is considered to be 0.0.0, so we have to check for it
+    ) {
         const astroTSXFile = typescript_1.default.sys.resolvePath((0, path_1.resolve)(languageServerDirectory, '../types/astro-jsx.d.ts'));
         scriptFileNames.push(astroTSXFile);
         console.warn("Version lower than 1.0 detected, using internal types instead of Astro's");
@@ -219,19 +221,23 @@ async function createLanguageService(tsconfigPath, docContext, workspaceUris) {
         });
     }
     function getParsedTSConfig() {
-        let configJson = (tsconfigPath && typescript_1.default.readConfigFile(tsconfigPath, typescript_1.default.sys.readFile).config) || {};
+        let configJson = (tsconfigPath && typescript_1.default.readConfigFile(tsconfigPath, typescript_1.default.sys.readFile).config) || {
+            compilerOptions: getDefaultCompilerOptions(astroVersion),
+        };
         // If our user has types in their config but it doesn't include the types needed for Astro, add them to the config
         if (configJson.compilerOptions?.types) {
             if (!configJson.compilerOptions?.types.includes('astro/env')) {
                 configJson.compilerOptions.types.push('astro/env');
             }
-            if (astroVersion.major >= 1 &&
+            if ((astroVersion.major >= 1 || astroVersion.full.startsWith('0.0.0-rc-')) &&
                 astroVersion.full !== '1.0.0-beta.0' &&
                 !configJson.compilerOptions?.types.includes('astro/astro-jsx')) {
                 configJson.compilerOptions.types.push('astro/astro-jsx');
             }
         }
-        configJson.compilerOptions = Object.assign(getDefaultCompilerOptions(astroVersion), configJson.compilerOptions);
+        else {
+            configJson.compilerOptions = Object.assign(getDefaultCompilerOptions(astroVersion), configJson.compilerOptions);
+        }
         // Delete include so that .astro files don't get mistakenly excluded by the user
         delete configJson.include;
         // If the user supplied exclude, let's use theirs otherwise, use ours
@@ -241,6 +247,7 @@ async function createLanguageService(tsconfigPath, docContext, workspaceUris) {
             noEmit: true,
             declaration: false,
             resolveJsonModule: true,
+            allowSyntheticDefaultImports: true,
             allowNonTsExtensions: true,
             allowJs: true,
             jsx: typescript_1.default.JsxEmit.Preserve,
@@ -267,16 +274,14 @@ async function createLanguageService(tsconfigPath, docContext, workspaceUris) {
     }
 }
 /**
- * Default configuration used as a base and when the user doesn't have any
+ * Default compiler configuration used when the user doesn't have any
  */
 function getDefaultCompilerOptions(astroVersion) {
     const types = ['astro/env'];
-    if (astroVersion.major >= 1 && astroVersion.full !== '1.0.0-beta.0') {
+    if ((astroVersion.major >= 1 && astroVersion.full !== '1.0.0-beta.0') || astroVersion.full.startsWith('0.0.0-rc-')) {
         types.push('astro/astro-jsx');
     }
     return {
-        maxNodeModuleJsDepth: 2,
-        allowSyntheticDefaultImports: true,
         types: types,
     };
 }

package/dist/server.js

@@ -49,6 +49,11 @@ function startLanguageServer(connection) {
         const workspaceUris = params.workspaceFolders?.map((folder) => folder.uri.toString()) ?? [params.rootUri ?? ''];
         workspaceUris.forEach((uri) => {
             uri = (0, utils_1.urlToPath)(uri);
+            // If the workspace is not an Astro project, we shouldn't warn about not finding Astro
+            // Unless the extension enabled itself in an untitled workspace, in which case the warning is valid
+            if (!(0, utils_1.isAstroWorkspace)(uri) && uri !== '/' && uri !== '') {
+                return;
+            }
             const astroVersion = (0, utils_1.getUserAstroVersion)(uri);
             if (astroVersion.exist === false) {
                 connection.sendNotification(vscode_languageserver_1.ShowMessageNotification.type, {
@@ -56,12 +61,6 @@ function startLanguageServer(connection) {
                     type: vscode_languageserver_1.MessageType.Warning,
                 });
             }
-            if (astroVersion.exist && astroVersion.major === 0 && astroVersion.minor < 24 && astroVersion.patch < 5) {
-                connection.sendNotification(vscode_languageserver_1.ShowMessageNotification.type, {
-                    message: `The version of Astro you're using (${astroVersion.full}) is not supported by this version of the Astro language server. Please upgrade Astro to any version higher than 0.23.4 or if using the VS Code extension, downgrade the extension to 0.8.10`,
-                    type: vscode_languageserver_1.MessageType.Error,
-                });
-            }
         });
         hasConfigurationCapability = !!(params.capabilities.workspace && !!params.capabilities.workspace.configuration);
         pluginHost.initialize({

package/dist/utils.d.ts

@@ -65,6 +65,10 @@ export declare function debounceSameArg<T>(fn: (arg: T) => void, shouldCancelPre
  * @param milliseconds Number of milliseconds to debounce/throttle
  */
 export declare function debounceThrottle<T extends (...args: any) => void>(fn: T, milliseconds: number): T;
+/**
+ * Try to determine if a workspace could be an Astro project based on the content of `package.json`
+ */
+export declare function isAstroWorkspace(workspacePath: string): boolean;
 export interface AstroVersion {
     full: string;
     major: number;

package/dist/utils.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getUserAstroVersion = exports.debounceThrottle = exports.debounceSameArg = exports.getRegExpMatches = exports.regexLastIndexOf = exports.isBeforeOrEqualToPosition = exports.isInRange = exports.isNotNullOrUndefined = exports.clamp = exports.modifyLines = exports.toPascalCase = exports.mergeDeep = exports.get = exports.getLastPartOfPath = exports.pathToUrl = exports.urlToPath = exports.normalizePath = exports.normalizeUri = void 0;
+exports.getUserAstroVersion = exports.isAstroWorkspace = exports.debounceThrottle = exports.debounceSameArg = exports.getRegExpMatches = exports.regexLastIndexOf = exports.isBeforeOrEqualToPosition = exports.isInRange = exports.isNotNullOrUndefined = exports.clamp = exports.modifyLines = exports.toPascalCase = exports.mergeDeep = exports.get = exports.getLastPartOfPath = exports.pathToUrl = exports.urlToPath = exports.normalizePath = exports.normalizeUri = void 0;
 const vscode_uri_1 = require("vscode-uri");
 /** Normalizes a document URI */
 function normalizeUri(uri) {
@@ -197,6 +197,23 @@ function debounceThrottle(fn, milliseconds) {
     return maybeCall;
 }
 exports.debounceThrottle = debounceThrottle;
+/**
+ * Try to determine if a workspace could be an Astro project based on the content of `package.json`
+ */
+function isAstroWorkspace(workspacePath) {
+    try {
+        const astroPackageJson = require.resolve('./package.json', { paths: [workspacePath] });
+        const deps = Object.assign(require(astroPackageJson).dependencies ?? {}, require(astroPackageJson).devDependencies ?? {});
+        if (Object.keys(deps).includes('astro')) {
+            return true;
+        }
+    }
+    catch (e) {
+        return false;
+    }
+    return false;
+}
+exports.isAstroWorkspace = isAstroWorkspace;
 function getUserAstroVersion(basePath) {
     let version = '0.0.0';
     let exist = true;
@@ -213,7 +230,7 @@ function getUserAstroVersion(basePath) {
         catch (e) {
             // If we still couldn't find it, it probably just doesn't exist
             exist = false;
-            console.error(e);
+            console.error(`${basePath} seems to be an Astro project, but we couldn't find Astro or Astro is not installed`);
         }
     }
     let [major, minor, patch] = version.split('.');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@astrojs/language-server",
-  "version": "0.20.0",
+  "version": "0.20.1",
   "author": "withastro",
   "license": "MIT",
   "type": "commonjs",
@@ -36,7 +36,7 @@
     "@types/chai": "^4.3.0",
     "@types/mocha": "^9.1.0",
     "@types/sinon": "^10.0.11",
-    "astro": "^1.0.0-beta.1",
+    "astro": "^1.0.0-beta.72",
     "astro-scripts": "0.0.1",
     "chai": "^4.3.6",
     "cross-env": "^7.0.3",