@astrale-os/cli 1.0.0-beta.9 → 1.0.0-npm-deprecated.0

package/studio/server/state/comments.test.ts

@@ -1,94 +0,0 @@
-import { afterEach, expect, test } from 'bun:test'
-import { mkdtempSync, rmSync } from 'node:fs'
-import { tmpdir } from 'node:os'
-import { join } from 'node:path'
-
-import { mergeReply, readComments, upsertComment } from './comments'
-import { writeJson } from './store'
-
-const roots: string[] = []
-
-afterEach(() => {
-  while (roots.length) rmSync(roots.pop()!, { recursive: true, force: true })
-})
-
-test('missing comment stores do not share entries across domains', () => {
-  const rootA = mkdtempSync(join(tmpdir(), 'studio-comments-a-'))
-  const rootB = mkdtempSync(join(tmpdir(), 'studio-comments-b-'))
-  roots.push(rootA, rootB)
-
-  upsertComment(rootA, {
-    anchors: ['A'],
-    anchorRefs: [{ ref: 'class.A', kind: 'schema' }],
-    text: 'only in A',
-  })
-
-  expect(readComments(rootA).comments.map((comment) => comment.thread[0]!.text)).toEqual([
-    'only in A',
-  ])
-  expect(readComments(rootB).comments).toEqual([])
-})
-
-test('normalizes malformed nested comment data and ignores future fields', () => {
-  const root = mkdtempSync(join(tmpdir(), 'studio-comments-corrupt-'))
-  roots.push(root)
-  writeJson(root, 'comments.json', {
-    schemaVersion: 'render-fingerprint',
-    futureStoreField: { version: 2 },
-    comments: [
-      {
-        id: 'kept',
-        anchors: ['Thing'],
-        anchorRefs: [
-          { ref: 'class.Thing', kind: 'schema', futureAnchorField: true },
-          { ref: 42, kind: 'schema' },
-        ],
-        status: 'open',
-        thread: [
-          {
-            id: 'entry',
-            role: 'author',
-            type: 'text',
-            text: 'A valid question',
-            futureEntryField: true,
-          },
-          { id: 'broken', role: 'nobody', type: 'text', text: 'ignored' },
-        ],
-        createdAt: '2026-08-20T00:00:00.000Z',
-        futureCommentField: true,
-      },
-      { id: 42, thread: [] },
-    ],
-  })
-
-  expect(readComments(root)).toEqual({
-    schemaVersion: 'render-fingerprint',
-    comments: [
-      {
-        id: 'kept',
-        anchors: ['Thing'],
-        anchorRefs: [{ ref: 'class.Thing', kind: 'schema' }],
-        status: 'open',
-        thread: [
-          {
-            id: 'entry',
-            role: 'author',
-            type: 'text',
-            text: 'A valid question',
-          },
-        ],
-        createdAt: '2026-08-20T00:00:00.000Z',
-        kind: 'question',
-      },
-    ],
-  })
-})
-
-test('rejects a syntactically valid machine-state block with the wrong root shape', () => {
-  const root = mkdtempSync(join(tmpdir(), 'studio-comments-paste-'))
-  roots.push(root)
-
-  expect(() => mergeReply(root, 'render-fingerprint', '```json\n[]\n```')).toThrow(
-    'invalid machine-state json block',
-  )
-})

package/studio/server/state/comments.ts

@@ -1,484 +0,0 @@
-/**
- * comments.ts — the comments / open-questions store. ALL persistence goes through
- * store.ts (writes are allow-listed to <domain>/.domain-studio/). The on-disk file
- * is `comments.json`, shaped { schemaVersion, comments: Comment[] }.
- * `schemaVersion` is the historical annotate wire key for Studio's render
- * fingerprint; it is not a canonical DSL schema revision.
- *
- * Comments are annotate-compatible: each thread entry is
- *   { id, role:'user'|'author', type:'text'|'choice', text, options?, answer? }
- * and `kind` is derived from the FIRST thread entry's role
- * (author-seeded ⇒ 'question', else 'comment').
- */
-import type { AnchorRef, Comment, CommentStore, ThreadEntry } from '../../shared/types'
-
-import {
-  asBoolean,
-  asFiniteNumber,
-  asJsonRecord,
-  asString,
-  asStringArray,
-  parseJson,
-} from '../json'
-import { readJson, writeJson } from './store'
-
-const FILE = 'comments.json'
-
-function decodeAnchorRef(value: unknown): AnchorRef | undefined {
-  const record = asJsonRecord(value)
-  const ref = asString(record?.ref)
-  const kind = record?.kind
-  if (!ref || !['schema', 'section', 'file', 'free'].includes(String(kind))) return undefined
-  const file = asString(record?.file)
-  const startLine = asFiniteNumber(record?.startLine)
-  const endLine = asFiniteNumber(record?.endLine)
-  const label = asString(record?.label)
-  const x = asFiniteNumber(record?.x)
-  const y = asFiniteNumber(record?.y)
-  return {
-    ref,
-    kind: kind as AnchorRef['kind'],
-    ...(file === undefined ? {} : { file }),
-    ...(startLine === undefined ? {} : { startLine }),
-    ...(endLine === undefined ? {} : { endLine }),
-    ...(label === undefined ? {} : { label }),
-    ...(x === undefined ? {} : { x }),
-    ...(y === undefined ? {} : { y }),
-  }
-}
-
-function decodeThreadEntry(value: unknown): ThreadEntry | undefined {
-  const record = asJsonRecord(value)
-  if (!record) return undefined
-  const id = asString(record.id)
-  const role = record.role
-  const type = record.type
-  const text = asString(record.text)
-  if (
-    !id ||
-    (role !== 'user' && role !== 'author') ||
-    (type !== 'text' && type !== 'choice') ||
-    text === undefined
-  ) {
-    return undefined
-  }
-  const options = asStringArray(record.options)
-  const answer = record.answer === null ? null : asString(record.answer)
-  return {
-    id,
-    role,
-    type,
-    text,
-    ...(options === undefined ? {} : { options }),
-    ...(answer === undefined ? {} : { answer }),
-  }
-}
-
-function decodeComment(value: unknown): Comment | undefined {
-  const record = asJsonRecord(value)
-  if (!record) return undefined
-  const id = asString(record.id)
-  if (!id) return undefined
-  const anchors = asStringArray(record.anchors) ?? []
-  const anchorRefs = Array.isArray(record.anchorRefs)
-    ? record.anchorRefs.flatMap((anchor) => {
-        const decoded = decodeAnchorRef(anchor)
-        return decoded ? [decoded] : []
-      })
-    : []
-  const thread = Array.isArray(record.thread)
-    ? record.thread.flatMap((entry) => {
-        const decoded = decodeThreadEntry(entry)
-        return decoded ? [decoded] : []
-      })
-    : []
-  const status = record.status === 'closed' ? 'closed' : 'open'
-  const closeNote = asString(record.closeNote)
-  const createdAt = asString(record.createdAt) ?? ''
-  const orphaned = asBoolean(record.orphaned)
-  return {
-    id,
-    anchors,
-    anchorRefs,
-    status,
-    thread,
-    createdAt,
-    kind: deriveKind(thread),
-    ...(closeNote === undefined ? {} : { closeNote }),
-    ...(orphaned === undefined ? {} : { orphaned }),
-  }
-}
-
-function decodeCommentStore(value: unknown): CommentStore | undefined {
-  const record = asJsonRecord(value)
-  if (!record) return undefined
-  const comments = Array.isArray(record.comments)
-    ? record.comments.flatMap((comment) => {
-        const decoded = decodeComment(comment)
-        return decoded ? [decoded] : []
-      })
-    : []
-  return { schemaVersion: asString(record.schemaVersion) ?? '', comments }
-}
-
-export function readComments(root: string): CommentStore {
-  // Allocate a fresh array for every missing store. A module-level EMPTY object
-  // would share its nested `comments` array across domains until each persisted.
-  return readJson(root, FILE, decodeCommentStore, { schemaVersion: '', comments: [] })
-}
-
-function persist(root: string, store: CommentStore): void {
-  writeJson(root, FILE, store)
-}
-
-/** Derive `kind` from the first thread entry's role. */
-function deriveKind(thread: ThreadEntry[]): Comment['kind'] {
-  return thread[0]?.role === 'author' ? 'question' : 'comment'
-}
-
-function makeEntry(input: {
-  role: ThreadEntry['role']
-  type?: ThreadEntry['type']
-  text: string
-  options?: string[]
-  answer?: string | null
-}): ThreadEntry {
-  const entry: ThreadEntry = {
-    id: crypto.randomUUID(),
-    role: input.role,
-    type: input.type ?? 'text',
-    text: input.text,
-  }
-  if (input.options !== undefined) entry.options = input.options
-  if (input.answer !== undefined) entry.answer = input.answer
-  return entry
-}
-
-export function upsertComment(
-  root: string,
-  input: {
-    id?: string
-    anchors: string[]
-    anchorRefs: import('../../shared/types').AnchorRef[]
-    text?: string
-    firstRole?: 'user' | 'author'
-    type?: 'text' | 'choice'
-    options?: string[]
-    schemaVersion?: string
-  },
-): Comment {
-  const store = readComments(root)
-  if (input.schemaVersion !== undefined) store.schemaVersion = input.schemaVersion
-
-  // If id provided and exists → append a thread entry instead of creating.
-  if (input.id) {
-    const existing = store.comments.find((c) => c.id === input.id)
-    if (existing) {
-      const entry = makeEntry({
-        role: input.firstRole ?? 'user',
-        type: input.type,
-        text: input.text ?? '',
-        options: input.options,
-      })
-      existing.thread.push(entry)
-      existing.kind = deriveKind(existing.thread)
-      persist(root, store)
-      return existing
-    }
-  }
-
-  const role = input.firstRole ?? 'user'
-  const firstEntry = makeEntry({
-    role,
-    type: input.type,
-    text: input.text ?? '',
-    options: input.options,
-  })
-  const comment: Comment = {
-    id: input.id ?? crypto.randomUUID(),
-    anchors: input.anchors,
-    anchorRefs: input.anchorRefs,
-    status: 'open',
-    thread: [firstEntry],
-    createdAt: new Date().toISOString(),
-    kind: role === 'author' ? 'question' : 'comment',
-  }
-  store.comments.push(comment)
-  persist(root, store)
-  return comment
-}
-
-export function addThreadEntry(
-  root: string,
-  id: string,
-  entry: {
-    role: 'user' | 'author'
-    type?: 'text' | 'choice'
-    text: string
-    options?: string[]
-    answer?: string | null
-  },
-): Comment | null {
-  const store = readComments(root)
-  const comment = store.comments.find((c) => c.id === id)
-  if (!comment) return null
-  comment.thread.push(makeEntry(entry))
-  comment.kind = deriveKind(comment.thread)
-  persist(root, store)
-  return comment
-}
-
-/** Edit the text of a single thread entry in place (the studio is single-user). */
-export function editThreadEntry(
-  root: string,
-  id: string,
-  entryId: string,
-  text: string,
-): Comment | null {
-  const store = readComments(root)
-  const comment = store.comments.find((c) => c.id === id)
-  if (!comment) return null
-  const entry = comment.thread.find((e) => e.id === entryId)
-  if (!entry) return null
-  entry.text = text
-  persist(root, store)
-  return comment
-}
-
-export function setStatus(
-  root: string,
-  id: string,
-  status: 'open' | 'closed',
-  closeNote?: string,
-): Comment | null {
-  const store = readComments(root)
-  const comment = store.comments.find((c) => c.id === id)
-  if (!comment) return null
-  comment.status = status
-  if (closeNote !== undefined) comment.closeNote = closeNote
-  comment.kind = deriveKind(comment.thread)
-  persist(root, store)
-  return comment
-}
-
-export function deleteComment(root: string, id: string): boolean {
-  const store = readComments(root)
-  const idx = store.comments.findIndex((c) => c.id === id)
-  if (idx === -1) return false
-  store.comments.splice(idx, 1)
-  persist(root, store)
-  return true
-}
-
-/**
- * Mark a comment orphaned when NONE of its anchorRefs[].ref is present in
- * `validRefs`; clear the flag otherwise. Persists and returns the store.
- */
-export function markOrphans(root: string, validRefs: string[]): CommentStore {
-  const valid = new Set(validRefs)
-  const store = readComments(root)
-  for (const comment of store.comments) {
-    const refs = comment.anchorRefs ?? []
-    const anyValid = refs.some((r) => valid.has(r.ref))
-    comment.orphaned = refs.length > 0 ? !anyValid : true
-    comment.kind = deriveKind(comment.thread)
-  }
-  persist(root, store)
-  return store
-}
-
-interface PastedThreadEntry {
-  id?: string
-  role?: 'user' | 'author'
-  type?: 'text' | 'choice'
-  text?: string
-  options?: string[]
-  answer?: string | null
-}
-
-interface PastedComment {
-  id?: string
-  anchors?: string[]
-  status?: 'open' | 'closed'
-  closeNote?: string
-  thread?: PastedThreadEntry[]
-}
-
-interface PastedStore {
-  schemaVersion?: string
-  comments?: PastedComment[]
-}
-
-function decodePastedEntry(value: unknown): PastedThreadEntry | undefined {
-  const record = asJsonRecord(value)
-  if (!record) return undefined
-  const role = record.role === 'user' || record.role === 'author' ? record.role : undefined
-  const type = record.type === 'text' || record.type === 'choice' ? record.type : undefined
-  const id = asString(record.id)
-  const text = asString(record.text)
-  const options = asStringArray(record.options)
-  const answer = record.answer === null ? null : asString(record.answer)
-  return {
-    ...(id === undefined ? {} : { id }),
-    ...(role === undefined ? {} : { role }),
-    ...(type === undefined ? {} : { type }),
-    ...(text === undefined ? {} : { text }),
-    ...(options === undefined ? {} : { options }),
-    ...(answer === undefined ? {} : { answer }),
-  }
-}
-
-function decodePastedComment(value: unknown): PastedComment | undefined {
-  const record = asJsonRecord(value)
-  if (!record) return undefined
-  const id = asString(record.id)
-  const anchors = asStringArray(record.anchors)
-  const status = record.status === 'open' || record.status === 'closed' ? record.status : undefined
-  const closeNote = asString(record.closeNote)
-  const thread = Array.isArray(record.thread)
-    ? record.thread.flatMap((entry) => {
-        const decoded = decodePastedEntry(entry)
-        return decoded ? [decoded] : []
-      })
-    : undefined
-  return {
-    ...(id === undefined ? {} : { id }),
-    ...(anchors === undefined ? {} : { anchors }),
-    ...(status === undefined ? {} : { status }),
-    ...(closeNote === undefined ? {} : { closeNote }),
-    ...(thread === undefined ? {} : { thread }),
-  }
-}
-
-function decodePastedStore(value: unknown): PastedStore | undefined {
-  const record = asJsonRecord(value)
-  if (!record) return undefined
-  const schemaVersion = asString(record.schemaVersion)
-  const comments = Array.isArray(record.comments)
-    ? record.comments.flatMap((comment) => {
-        const decoded = decodePastedComment(comment)
-        return decoded ? [decoded] : []
-      })
-    : undefined
-  return {
-    ...(schemaVersion === undefined ? {} : { schemaVersion }),
-    ...(comments === undefined ? {} : { comments }),
-  }
-}
-
-/** Extract the LAST fenced ```json … ``` block from arbitrary prose. */
-function extractLastJsonBlock(text: string): string | null {
-  const fence = /```json\s*\n?([\s\S]*?)```/gi
-  let match: RegExpExecArray | null
-  let last: string | null = null
-  while ((match = fence.exec(text)) !== null) {
-    last = match[1]
-  }
-  return last == null ? null : last.trim()
-}
-
-function normalizePastedEntry(e: PastedThreadEntry): ThreadEntry {
-  const entry: ThreadEntry = {
-    id: e.id && e.id.length > 0 ? e.id : crypto.randomUUID(),
-    role: e.role === 'author' ? 'author' : 'user',
-    type: e.type === 'choice' ? 'choice' : 'text',
-    text: e.text ?? '',
-  }
-  if (e.options !== undefined) entry.options = e.options
-  if (e.answer !== undefined) entry.answer = e.answer
-  return entry
-}
-
-/**
- * Merge an agent-pasted machine-state reply (annotate shape) into the store.
- * - LAST ```json``` block is parsed.
- * - For each pasted comment by id: if known locally, append NEW thread entries
- *   (dedupe by entry id) and apply status/closeNote; if unknown → unknownIds.
- * - schemaMismatch when parsed.schemaVersion differs from the current render fingerprint.
- */
-export function mergeReply(
-  root: string,
-  currentRenderFingerprint: string,
-  pastedText: string,
-  opts?: {
-    /** live loop: skip ONLY the texts already applied live this run, per comment id */
-    skipByComment?: Map<string, Set<string>>
-    /** manual paste: dedupe author replies against the whole thread (a re-paste with
-     *  regenerated ids would otherwise duplicate) — there are no live replies to scope to */
-    dedupeAuthorText?: boolean
-  },
-): import('../../shared/types').MergeResult {
-  const block = extractLastJsonBlock(pastedText)
-  if (block == null) {
-    throw new Error('no machine-state json block found in pasted text')
-  }
-  const parsed = decodePastedStore(parseJson(block))
-  if (!parsed) throw new Error('invalid machine-state json block')
-  const pastedComments = Array.isArray(parsed.comments) ? parsed.comments : []
-
-  const store = readComments(root)
-  let merged = 0
-  let closed = 0
-  const unknownIds: string[] = []
-
-  for (const pc of pastedComments) {
-    if (!pc.id) {
-      unknownIds.push('')
-      continue
-    }
-    const local = store.comments.find((c) => c.id === pc.id)
-    if (!local) {
-      unknownIds.push(pc.id)
-      continue
-    }
-
-    const seen = new Set(local.thread.map((t) => t.id))
-    // Skip ONLY the author texts already applied LIVE this run (the agent regenerates
-    // ids, so id-dedupe alone wouldn't catch a bridge reply echoed in the block). Scope
-    // it to this run — NOT the whole thread history — so a legitimately-repeated reply
-    // across turns ("Done." twice) is never dropped.
-    const liveTexts = opts?.skipByComment?.get(pc.id)
-    const authorTexts = opts?.dedupeAuthorText
-      ? new Set(local.thread.filter((t) => t.role === 'author').map((t) => t.text.trim()))
-      : null
-    let appended = 0
-    for (const pe of pc.thread ?? []) {
-      const entry = normalizePastedEntry(pe)
-      if (seen.has(entry.id)) continue
-      if (
-        entry.role === 'author' &&
-        (liveTexts?.has(entry.text.trim()) || authorTexts?.has(entry.text.trim()))
-      )
-        continue
-      seen.add(entry.id)
-      if (entry.role === 'author') authorTexts?.add(entry.text.trim())
-      local.thread.push(entry)
-      appended += 1
-    }
-    if (appended > 0) merged += 1
-
-    // Only ever close from a merge — never REOPEN a thread the user closed mid-run.
-    if (pc.status === 'closed' && local.status !== 'closed') {
-      local.status = 'closed'
-      closed += 1
-    }
-    if (pc.closeNote !== undefined) local.closeNote = pc.closeNote
-
-    local.kind = deriveKind(local.thread)
-  }
-
-  persist(root, store)
-
-  const pastedSchemaVersion = parsed.schemaVersion
-  const schemaMismatch = Boolean(
-    pastedSchemaVersion && pastedSchemaVersion !== currentRenderFingerprint,
-  )
-
-  return {
-    merged,
-    closed,
-    unknownIds,
-    schemaMismatch,
-    pastedSchemaVersion,
-  }
-}