@asterxsk/kiln 0.1.0

package/agent/extensions/pi-web-access/test/github-issue-pr.test.mjs

@@ -0,0 +1,565 @@
+import assert from "node:assert/strict";
+import { spawnSync } from "node:child_process";
+import { mkdir, mkdtemp, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { delimiter, join } from "node:path";
+import { test } from "node:test";
+
+const moduleUrl = new URL("../github-issue-pr.ts", import.meta.url).href;
+const extractUrl = new URL("../extract.ts", import.meta.url).href;
+const publicLookup = async () => [{ address: "140.82.112.6", family: 4 }];
+
+// Fake shebang `gh` executables cannot run on Windows: extensionless scripts are
+// not resolvable/spawnable via CreateProcess, and `.cmd` shims are refused by
+// child_process without `shell: true` (post CVE-2024-27980 hardening). Tests
+// below that depend on the fake gh's canned JSON skip there; they still run on
+// POSIX CI. Tests that only need gh to fail (fallback/abort paths) keep
+// running, since a spawn error exercises the same fallback.
+
+async function writeFakeExecutable(binDir, name, source) {
+	const executable = join(binDir, name);
+	await writeFile(executable, `#!/usr/bin/env node\n${source}\n`, { mode: 0o755 });
+	if (process.platform === "win32") {
+		// Windows CreateProcess resolves executables via PATHEXT, so the
+		// extensionless shebang script above is invisible to spawn/execFile.
+		await writeFile(join(binDir, `${name}.cmd`), `@echo off\r\nnode "%~dp0${name}" %*\r\n`);
+	}
+	return executable;
+}
+
+const SKIP_FAKE_GH = process.platform === "win32"
+	? "requires a runnable fake gh executable (unavailable on Windows)"
+	: false;
+
+test("parseGitHubIssuePrUrl accepts PR and issue variants without changing repo parsing", async () => {
+	const { parseGitHubIssuePrUrl } = await import(moduleUrl);
+	assert.deepEqual(parseGitHubIssuePrUrl("https://github.com/owner/repo/pull/123/files#discussion_r42"), {
+		owner: "owner", repo: "repo", kind: "pull", number: 123, anchor: "discussion_r42",
+	});
+	assert.deepEqual(parseGitHubIssuePrUrl("https://www.github.com/owner/repo/issues/5#issuecomment-99"), {
+		owner: "owner", repo: "repo", kind: "issue", number: 5, anchor: "issuecomment-99",
+	});
+	assert.deepEqual(parseGitHubIssuePrUrl("https://www.github.com/owner/repo/issues/5#discussion_r99"), {
+		owner: "owner", repo: "repo", kind: "issue", number: 5,
+	});
+	assert.equal(parseGitHubIssuePrUrl("https://github.com/owner/repo/pulls"), null);
+	assert.equal(parseGitHubIssuePrUrl("https://github.com/owner/repo/issues/new"), null);
+	assert.equal(parseGitHubIssuePrUrl("https://github.com/owner/repo/pull/123/unknown"), null);
+	assert.equal(parseGitHubIssuePrUrl("https://github.com/owner/repo/issues/5/edit"), null);
+	assert.equal(parseGitHubIssuePrUrl("https://github.com/owner%2Frepo/repo/issues/1"), null);
+});
+
+test("renderer orders sections, marks truncation, and forces anchored comments inline", async () => {
+	const { renderGitHubPrIssue } = await import(moduleUrl);
+	const comments = Array.from({ length: 20 }, (_, index) => ({
+		id: index + 1,
+		user: { login: `user${index + 1}` },
+		created_at: "2026-01-01T00:00:00Z",
+		body: index === 18 ? "anchored comment body" : `comment ${index + 1}`,
+	}));
+	const result = renderGitHubPrIssue({
+		url: "https://github.com/owner/repo/pull/7#issuecomment-19",
+		owner: "owner",
+		repo: "repo",
+		kind: "pull",
+		number: 7,
+		anchor: "issuecomment-19",
+		reviewThreads: [],
+		fallbackNotes: [],
+		view: {
+			number: 7,
+			title: "Improve fetch",
+			state: "OPEN",
+			isDraft: false,
+			author: { login: "alice" },
+			baseRefName: "main",
+			headRefName: "feature",
+			headRepositoryOwner: { login: "fork" },
+			createdAt: "2026-01-01T00:00:00Z",
+			labels: [{ name: "bug" }],
+			additions: 5,
+			deletions: 1,
+			changedFiles: 1,
+			body: "x".repeat(4100),
+			files: [{ path: "a.ts", additions: 5, deletions: 1 }],
+			commits: [{ oid: "abcdef123456", messageHeadline: "commit subject" }],
+			comments,
+			statusCheckRollup: [{ name: "test", conclusion: "SUCCESS" }],
+		},
+	});
+
+	assert.equal(result.error, null);
+	assert.match(result.content, /#7 Improve fetch/);
+	assert.ok(result.content.indexOf("## Body") < result.content.indexOf("## Checks"));
+	assert.match(result.content, /\[body truncated; use get_search_content/);
+	assert.match(result.content, /user19.*\[anchored\]/s);
+	assert.match(result.content, /15 of 20 comments shown|16 of 20 comments shown/);
+	assert.match(result.content, /gh pr diff 7 --repo owner\/repo/);
+});
+
+test("renderer marks truncated review verdicts", async () => {
+	const { renderGitHubPrIssue } = await import(moduleUrl);
+	const reviews = Array.from({ length: 11 }, (_, index) => ({
+		author: { login: `reviewer${index}` },
+		state: "COMMENTED",
+		body: `review ${index}`,
+	}));
+	const result = renderGitHubPrIssue({
+		url: "https://github.com/owner/repo/pull/7",
+		owner: "owner",
+		repo: "repo",
+		kind: "pull",
+		number: 7,
+		reviewThreads: [],
+		fallbackNotes: [],
+		view: { number: 7, title: "Reviews", state: "OPEN", author: { login: "alice" }, body: "body", reviews },
+	});
+
+	assert.match(result.content, /10 of 11 review verdicts shown/);
+});
+
+test("extractGitHubIssuePr retries gh view with core fields on unknown --json field", { skip: SKIP_FAKE_GH }, async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-pr-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `
+		const args = process.argv.slice(2);
+		if (args[0] === "--version") { console.log("gh version 2.0.0"); process.exit(0); }
+		if (args[0] === "pr" && args[1] === "view") {
+			const fields = args[args.indexOf("--json") + 1] || "";
+			if (fields.includes("statusCheckRollup")) { console.error("Unknown JSON field: statusCheckRollup"); process.exit(1); }
+			console.log(JSON.stringify({ number: 12, title: "Fallback fields", state: "OPEN", author: { login: "alice" }, body: "body", comments: [] }));
+			process.exit(0);
+		}
+		if (args[0] === "api") { console.log("[]"); process.exit(0); }
+		process.exit(1);
+	`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			const { extractGitHubIssuePr } = await import(${JSON.stringify(moduleUrl)});
+			const result = await extractGitHubIssuePr("https://github.com/owner/repo/pull/12");
+			console.log(JSON.stringify(result));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const result = JSON.parse(child.stdout);
+	assert.match(result.content, /Fallback fields/);
+	assert.match(result.content, /retried with the core field set/);
+	assert.match(result.content, /Linked references\nUnavailable in this GitHub fetch path/);
+});
+
+test("gh path fetches an anchored review comment beyond fetched pages", { skip: SKIP_FAKE_GH }, async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-deep-review-anchor-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `
+		const args = process.argv.slice(2);
+		if (args[0] === "--version") { console.log("gh version 2.0.0"); process.exit(0); }
+		if (args[0] === "pr" && args[1] === "view") {
+			console.log(JSON.stringify({ number: 7, title: "Deep anchor", state: "OPEN", author: { login: "alice" }, body: "body", comments: [] }));
+			process.exit(0);
+		}
+		if (args[0] === "api" && args[1].includes("/pulls/7/comments?")) {
+			const comments = Array.from({ length: 100 }, (_, index) => ({ id: index + 1, user: { login: "page" }, path: "a.ts", line: 1, body: "paged" }));
+			console.log(JSON.stringify(comments));
+			process.exit(0);
+		}
+		if (args[0] === "api" && args[1].endsWith("/pulls/comments/999")) {
+			console.log(JSON.stringify({ id: 999, pull_request_url: "https://api.github.com/repos/owner/repo/pulls/7", user: { login: "reviewer" }, path: "deep.ts", line: 44, body: "deep anchor" }));
+			process.exit(0);
+		}
+		process.exit(1);
+	`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			const { extractGitHubIssuePr } = await import(${JSON.stringify(moduleUrl)});
+			const result = await extractGitHubIssuePr("https://github.com/owner/repo/pull/7#discussion_r999");
+			console.log(JSON.stringify(result));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const result = JSON.parse(child.stdout);
+	assert.match(result.content, /reviewer.*\[anchored\]/s);
+	assert.match(result.content, /deep anchor/);
+	assert.match(result.content, /review threads: at least 301/);
+	assert.match(result.content, /review thread comments shown from at least 301/);
+});
+
+test("gh path rejects anchored review comments from another pull request", { skip: SKIP_FAKE_GH }, async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-cross-review-anchor-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `
+		const args = process.argv.slice(2);
+		if (args[0] === "--version") { console.log("gh version 2.0.0"); process.exit(0); }
+		if (args[0] === "pr" && args[1] === "view") {
+			console.log(JSON.stringify({ number: 7, title: "Cross anchor", state: "OPEN", author: { login: "alice" }, body: "body", comments: [] }));
+			process.exit(0);
+		}
+		if (args[0] === "api" && args[1].includes("/pulls/7/comments?")) { console.log(JSON.stringify([])); process.exit(0); }
+		if (args[0] === "api" && args[1].endsWith("/pulls/comments/999")) {
+			console.log(JSON.stringify({ id: 999, pull_request_url: "https://api.github.com/repos/other/repo/pulls/7", user: { login: "wrong" }, path: "wrong.ts", line: 1, body: "wrong pull" }));
+			process.exit(0);
+		}
+		process.exit(1);
+	`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			const { extractGitHubIssuePr } = await import(${JSON.stringify(moduleUrl)});
+			const result = await extractGitHubIssuePr("https://github.com/owner/repo/pull/7#discussion_r999");
+			console.log(JSON.stringify(result));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const result = JSON.parse(child.stdout);
+	assert.doesNotMatch(result.content, /wrong pull/);
+	assert.match(result.content, /anchored review thread comment unavailable for this pull request/);
+});
+
+test("gh path still attempts an anchored review comment after page failure", { skip: SKIP_FAKE_GH }, async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-page-fail-anchor-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `
+		const args = process.argv.slice(2);
+		if (args[0] === "--version") { console.log("gh version 2.0.0"); process.exit(0); }
+		if (args[0] === "pr" && args[1] === "view") {
+			console.log(JSON.stringify({ number: 7, title: "Page fail anchor", state: "OPEN", author: { login: "alice" }, body: "body", comments: [] }));
+			process.exit(0);
+		}
+		if (args[0] === "api" && args[1].includes("/pulls/7/comments?")) { process.exit(1); }
+		if (args[0] === "api" && args[1].endsWith("/pulls/comments/999")) {
+			console.log(JSON.stringify({ id: 999, pull_request_url: "https://api.github.com/repos/owner/repo/pulls/7", user: { login: "reviewer" }, path: "deep.ts", line: 44, body: "deep after page failure" }));
+			process.exit(0);
+		}
+		process.exit(1);
+	`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			const { extractGitHubIssuePr } = await import(${JSON.stringify(moduleUrl)});
+			const result = await extractGitHubIssuePr("https://github.com/owner/repo/pull/7#discussion_r999");
+			console.log(JSON.stringify(result));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const result = JSON.parse(child.stdout);
+	assert.match(result.content, /reviewer.*\[anchored\]/s);
+	assert.match(result.content, /deep after page failure/);
+});
+
+test("gh review thread page failure renders unavailable instead of none", { skip: SKIP_FAKE_GH }, async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-review-unavailable-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `
+		const args = process.argv.slice(2);
+		if (args[0] === "--version") { console.log("gh version 2.0.0"); process.exit(0); }
+		if (args[0] === "pr" && args[1] === "view") {
+			console.log(JSON.stringify({ number: 7, title: "Unavailable reviews", state: "OPEN", author: { login: "alice" }, body: "body", comments: [] }));
+			process.exit(0);
+		}
+		if (args[0] === "api" && args[1].includes("/pulls/7/comments?")) { process.exit(1); }
+		process.exit(1);
+	`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			const { extractGitHubIssuePr } = await import(${JSON.stringify(moduleUrl)});
+			const result = await extractGitHubIssuePr("https://github.com/owner/repo/pull/7");
+			console.log(JSON.stringify(result));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const result = JSON.parse(child.stdout);
+	assert.match(result.content, /review threads: unavailable/);
+	assert.match(result.content, /Review thread comments\nUnavailable in this GitHub fetch path/);
+});
+
+test("extractGitHubIssuePr aborts active gh work with the caller signal", async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-abort-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `
+		const args = process.argv.slice(2);
+		if (args[0] === "--version") { console.log("gh version 2.0.0"); process.exit(0); }
+		setTimeout(() => {}, 30000);
+	`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			globalThis.fetch = async (_input, init = {}) => {
+				if (!init.signal?.aborted) throw new Error("fallback fetch did not receive aborted signal");
+				throw new Error("aborted fallback fetch");
+			};
+			const { extractGitHubIssuePr } = await import(${JSON.stringify(moduleUrl)});
+			const controller = new AbortController();
+			setTimeout(() => controller.abort(), 50);
+			const started = Date.now();
+			const result = await extractGitHubIssuePr("https://github.com/owner/repo/pull/7", controller.signal, { lookup: async () => [{ address: "140.82.112.6", family: 4 }] });
+			console.log(JSON.stringify({ elapsed: Date.now() - started, result }));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const output = JSON.parse(child.stdout);
+	assert.equal(output.result.error, "Aborted");
+	assert.ok(output.elapsed < 1000, `expected abort before gh timeout, got ${output.elapsed}ms`);
+});
+
+test("extractGitHubIssuePr aborts a hung gh availability probe", async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-probe-abort-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `setTimeout(() => {}, 30000);`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			const { extractGitHubIssuePr } = await import(${JSON.stringify(moduleUrl)});
+			const controller = new AbortController();
+			setTimeout(() => controller.abort(), 50);
+			const started = Date.now();
+			const result = await extractGitHubIssuePr("https://github.com/owner/repo/pull/7", controller.signal);
+			console.log(JSON.stringify({ elapsed: Date.now() - started, result }));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const output = JSON.parse(child.stdout);
+	assert.equal(output.result.error, "Aborted");
+	assert.ok(output.elapsed < 1000, `expected abort before gh probe timeout, got ${output.elapsed}ms`);
+});
+
+test("REST fallback preserves caller cancellation", async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-rest-abort-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `process.exit(1);`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			const controller = new AbortController();
+			globalThis.fetch = async (_input, init = {}) => {
+				setTimeout(() => controller.abort(), 10);
+				await new Promise((resolve, reject) => init.signal.addEventListener("abort", () => reject(new Error("Aborted REST fetch")), { once: true }));
+			};
+			const { extractContent } = await import(${JSON.stringify(extractUrl)});
+			const lookup = ${publicLookup.toString()};
+			const started = Date.now();
+			const result = await extractContent("https://github.com/owner/repo/issues/12", controller.signal, { lookup });
+			console.log(JSON.stringify({ elapsed: Date.now() - started, result }));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const output = JSON.parse(child.stdout.split("\n").at(-2));
+	assert.equal(output.result.error, "Aborted");
+	assert.ok(output.elapsed < 1000, `expected REST abort before generic fallback, got ${output.elapsed}ms`);
+});
+
+test("extractContent returns an actionable GitHub rate-limit result instead of HTML fall-through", async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-rate-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `process.exit(1);`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			globalThis.fetch = async () => new Response("rate limited", { status: 403, headers: { "x-ratelimit-remaining": "0", "x-ratelimit-reset": "1800000000" } });
+			const { extractContent } = await import(${JSON.stringify(extractUrl)});
+			const lookup = ${publicLookup.toString()};
+			const result = await extractContent("https://github.com/owner/repo/issues/12", undefined, { lookup });
+			console.log(JSON.stringify(result));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const result = JSON.parse(child.stdout.split("\n").at(-2));
+	assert.equal(result.status, 403);
+	assert.match(result.error, /rate limit/i);
+	assert.match(result.content, /gh auth login/);
+});
+
+test("REST fallback fetches an anchored issue comment outside the first page", async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-issue-anchor-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `process.exit(1);`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			globalThis.fetch = async (input) => {
+				const url = String(input);
+				if (url.endsWith("/issues/12")) return new Response(JSON.stringify({ number: 12, title: "Issue", state: "open", user: { login: "owner" }, body: "body", comments: 75 }), { status: 200 });
+				if (url.endsWith("/issues/12/comments?per_page=50")) return new Response(JSON.stringify([{ id: 1, user: { login: "first" }, created_at: "2026-01-01T00:00:00Z", body: "first page" }]), { status: 200 });
+				if (url.endsWith("/issues/comments/99")) return new Response(JSON.stringify({ id: 99, issue_url: "https://api.github.com/repos/owner/repo/issues/12", user: { login: "anchored" }, created_at: "2026-01-02T00:00:00Z", body: "outside first page" }), { status: 200 });
+				throw new Error("unexpected URL " + url);
+			};
+			const { extractContent } = await import(${JSON.stringify(extractUrl)});
+			const lookup = ${publicLookup.toString()};
+			const result = await extractContent("https://github.com/owner/repo/issues/12#issuecomment-99", undefined, { lookup });
+			console.log(JSON.stringify(result));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const result = JSON.parse(child.stdout.split("\n").at(-2));
+	assert.match(result.content, /anchored.*\[anchored\]/s);
+	assert.match(result.content, /outside first page/);
+	assert.match(result.content, /comments: at least 75/);
+	assert.match(result.content, /comments shown from at least 75/);
+});
+
+test("REST fallback rejects anchored issue comments from another work item", async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-cross-issue-anchor-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `process.exit(1);`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			globalThis.fetch = async (input) => {
+				const url = String(input);
+				if (url.endsWith("/issues/12")) return new Response(JSON.stringify({ number: 12, title: "Issue", state: "open", user: { login: "owner" }, body: "body", comments: 1 }), { status: 200 });
+				if (url.endsWith("/issues/12/comments?per_page=50")) return new Response(JSON.stringify([]), { status: 200 });
+				if (url.endsWith("/issues/comments/99")) return new Response(JSON.stringify({ id: 98, issue_url: "https://api.github.com/repos/other/repo/issues/12", user: { login: "wrong" }, created_at: "2026-01-02T00:00:00Z", body: "wrong issue" }), { status: 200 });
+				throw new Error("unexpected URL " + url);
+			};
+			const { extractContent } = await import(${JSON.stringify(extractUrl)});
+			const lookup = ${publicLookup.toString()};
+			const result = await extractContent("https://github.com/owner/repo/issues/12#issuecomment-99", undefined, { lookup });
+			console.log(JSON.stringify(result));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const result = JSON.parse(child.stdout.split("\n").at(-2));
+	assert.doesNotMatch(result.content, /wrong issue/);
+	assert.match(result.content, /anchored comment unavailable for this issue or pull request/);
+});
+
+test("REST fallback fetches an anchored PR review comment outside the first page", async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-review-anchor-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `process.exit(1);`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			globalThis.fetch = async (input) => {
+				const url = String(input);
+				if (url.endsWith("/pulls/7")) return new Response(JSON.stringify({ number: 7, title: "PR", state: "open", user: { login: "owner" }, body: "body", draft: false, base: { ref: "main" }, head: { ref: "feature", repo: { owner: { login: "owner" } } }, additions: 1, deletions: 0, changed_files: 75, review_comments: 12 }), { status: 200 });
+				if (url.endsWith("/issues/7/comments?per_page=50")) return new Response(JSON.stringify([]), { status: 200 });
+				if (url.endsWith("/pulls/7/files?per_page=50")) return new Response(JSON.stringify(Array.from({ length: 50 }, (_, index) => ({ filename: "file" + index + ".ts", additions: 1, deletions: 0 }))), { status: 200 });
+				if (url.endsWith("/pulls/7/comments?per_page=50")) return new Response(JSON.stringify([{ id: 1, user: { login: "first" }, path: "a.ts", line: 1, body: "first review" }]), { status: 200 });
+				if (url.endsWith("/pulls/comments/42")) return new Response(JSON.stringify({ id: 42, pull_request_url: "https://api.github.com/repos/owner/repo/pulls/7", user: { login: "reviewer" }, path: "b.ts", line: 9, body: "outside review page" }), { status: 200 });
+				throw new Error("unexpected URL " + url);
+			};
+			const { extractContent } = await import(${JSON.stringify(extractUrl)});
+			const lookup = ${publicLookup.toString()};
+			const result = await extractContent("https://github.com/owner/repo/pull/7#discussion_r42", undefined, { lookup });
+			console.log(JSON.stringify(result));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const result = JSON.parse(child.stdout.split("\n").at(-2));
+	assert.match(result.content, /reviewer.*\[anchored\]/s);
+	assert.match(result.content, /outside review page/);
+	assert.match(result.content, /commits unavailable/);
+	assert.match(result.content, /Review verdicts\nUnavailable in this GitHub fetch path/);
+	assert.match(result.content, /50 files shown from at least 75/);
+	assert.match(result.content, /Commits\nUnavailable in this GitHub fetch path/);
+	assert.match(result.content, /review threads: at least 12/);
+	assert.match(result.content, /review thread comments shown from at least 12/);
+	assert.match(result.content, /Linked references\nUnavailable in this GitHub fetch path/);
+});
+
+test("REST fallback does not render positive changedFiles as none when files are missing", async () => {
+	const root = await mkdtemp(join(tmpdir(), "pi-web-access-gh-files-unavailable-"));
+	const binDir = join(root, "bin");
+	const agentDir = join(root, "agent");
+	await mkdir(binDir, { recursive: true });
+	await mkdir(agentDir, { recursive: true });
+	await writeFakeExecutable(binDir, "gh", `process.exit(1);`);
+
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			globalThis.fetch = async (input) => {
+				const url = String(input);
+				if (url.endsWith("/pulls/7")) return new Response(JSON.stringify({ number: 7, title: "PR", state: "open", user: { login: "owner" }, body: "body", draft: false, base: { ref: "main" }, head: { ref: "feature", repo: { owner: { login: "owner" } } }, additions: 1, deletions: 0, changed_files: 3 }), { status: 200 });
+				if (url.endsWith("/issues/7/comments?per_page=50")) return new Response(JSON.stringify([]), { status: 200 });
+				if (url.endsWith("/pulls/7/files?per_page=50")) return new Response(JSON.stringify([]), { status: 200 });
+				if (url.endsWith("/pulls/7/comments?per_page=50")) return new Response(JSON.stringify([]), { status: 200 });
+				throw new Error("unexpected URL " + url);
+			};
+			const { extractContent } = await import(${JSON.stringify(extractUrl)});
+			const lookup = ${publicLookup.toString()};
+			const result = await extractContent("https://github.com/owner/repo/pull/7", undefined, { lookup });
+			console.log(JSON.stringify(result));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PATH: `${binDir}${delimiter}${process.env.PATH || ""}`, PI_CODING_AGENT_DIR: agentDir },
+	});
+
+	assert.equal(child.status, 0, child.stderr);
+	const result = JSON.parse(child.stdout.split("\n").at(-2));
+	assert.match(result.content, /0 files shown from at least 3/);
+	assert.doesNotMatch(result.content, /Files\nnone/);
+});

package/agent/extensions/pi-web-access/test/inline-content-config.test.mjs

@@ -0,0 +1,99 @@
+import assert from "node:assert/strict";
+import { spawnSync } from "node:child_process";
+import { mkdtemp, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { test } from "node:test";
+
+const indexUrl = new URL("../index.ts", import.meta.url).href;
+const storageUrl = new URL("../storage.ts", import.meta.url).href;
+
+async function runScenario(maxInlineContentChars) {
+	const agentDir = await mkdtemp(join(tmpdir(), "pi-web-access-inline-content-"));
+	if (maxInlineContentChars !== undefined) {
+		await writeFile(join(agentDir, "web-search.json"), JSON.stringify({ maxInlineContentChars }) + "\n", "utf8");
+	}
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			import initializeExtension from ${JSON.stringify(indexUrl)};
+			import { clearResults } from ${JSON.stringify(storageUrl)};
+			clearResults();
+			globalThis.fetch = async () => new Response("A".repeat(40000) + "TAIL", {
+				status: 200,
+				headers: { "content-type": "text/plain" },
+			});
+			const tools = [];
+			initializeExtension({ registerTool(tool) { tools.push(tool); }, registerCommand() {}, registerShortcut() {}, on() {}, appendEntry() {} });
+			const fetchTool = tools.find(tool => tool.name === "fetch_content");
+			const contentTool = tools.find(tool => tool.name === "get_search_content");
+			const fetched = await fetchTool.execute("call", { url: "https://93.184.216.34/page" });
+			const retrieved = await contentTool.execute("call", { responseId: fetched.details.responseId, urlIndex: 0 });
+			const tail = await contentTool.execute("call", { responseId: fetched.details.responseId, urlIndex: 0, offset: 40000, limit: 4 });
+			const rejected = await contentTool.execute("call", { responseId: fetched.details.responseId, urlIndex: 0, limit: ${maxInlineContentChars === undefined ? 30_001 : maxInlineContentChars + 1} });
+			console.log(JSON.stringify({
+				schemaMax: contentTool.parameters.properties.limit.maximum,
+				fetchTruncated: fetched.details.truncated,
+				fetchEndOffset: fetched.content.find(item => item.type === "text").text.indexOf("\\n\\n---"),
+				retrievedChars: retrieved.details.returnedChars,
+				retrievedNextOffset: retrieved.details.nextOffset,
+				tail: tail.content[0].text.includes("TAIL"),
+				rejectedMax: rejected.details.maxLimit,
+			}));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PI_CODING_AGENT_DIR: agentDir, XDG_CONFIG_HOME: undefined },
+	});
+	assert.equal(child.status, 0, child.stderr);
+	return JSON.parse(child.stdout);
+}
+
+test("inline content defaults to 30,000 characters", async () => {
+	const result = await runScenario();
+	assert.deepEqual(result, {
+		schemaMax: 30_000,
+		fetchTruncated: true,
+		fetchEndOffset: 30_000,
+		retrievedChars: 30_000,
+		retrievedNextOffset: 30_000,
+		tail: true,
+		rejectedMax: 30_000,
+	});
+});
+
+test("maxInlineContentChars applies to direct and stored content slices", async () => {
+	const result = await runScenario(40_000);
+	assert.deepEqual(result, {
+		schemaMax: 40_000,
+		fetchTruncated: true,
+		fetchEndOffset: 40_000,
+		retrievedChars: 40_000,
+		retrievedNextOffset: 40_000,
+		tail: true,
+		rejectedMax: 40_000,
+	});
+});
+
+test("stored content schema and execution keep one registered limit", async () => {
+	const agentDir = await mkdtemp(join(tmpdir(), "pi-web-access-inline-content-"));
+	await writeFile(join(agentDir, "web-search.json"), JSON.stringify({ maxInlineContentChars: 40_000 }) + "\n", "utf8");
+	const child = spawnSync(process.execPath, ["--input-type=module"], {
+		input: `
+			import initializeExtension from ${JSON.stringify(indexUrl)};
+			import { storeResult, clearResults } from ${JSON.stringify(storageUrl)};
+			import { writeFile } from "node:fs/promises";
+			import { join } from "node:path";
+			clearResults();
+			const tools = [];
+			initializeExtension({ registerTool(tool) { tools.push(tool); }, registerCommand() {}, registerShortcut() {}, on() {}, appendEntry() {} });
+			await writeFile(join(process.env.PI_CODING_AGENT_DIR, "web-search.json"), JSON.stringify({ maxInlineContentChars: 20_000 }) + "\\n", "utf8");
+			storeResult("stored", { id: "stored", type: "fetch", timestamp: Date.now(), urls: [{ url: "https://example.test", title: "Stored", content: "A".repeat(50_000), error: null }] });
+			const contentTool = tools.find(tool => tool.name === "get_search_content");
+			const rejected = await contentTool.execute("call", { responseId: "stored", urlIndex: 0, limit: 40_001 });
+			console.log(JSON.stringify({ schemaMax: contentTool.parameters.properties.limit.maximum, rejectedMax: rejected.details.maxLimit }));
+		`,
+		encoding: "utf8",
+		env: { ...process.env, PI_CODING_AGENT_DIR: agentDir, XDG_CONFIG_HOME: undefined },
+	});
+	assert.equal(child.status, 0, child.stderr);
+	assert.deepEqual(JSON.parse(child.stdout), { schemaMax: 40_000, rejectedMax: 40_000 });
+});