@asteby/metacore-runtime-react 49.2.0 → 49.3.0

package/dist/dynamic-form-schema.js

@@ -3,7 +3,11 @@
 // metacore-ui primitives.
 import { z } from 'zod';
 import { fieldValidationOf } from './validator';
+import { applyOptionWhen, getDependsOn } from './option-when';
 import { resolveValidatorToken } from './use-org-config-bridge';
+// Viven en option-when.ts (el validador también los usa); se re-exportan aquí
+// para no romper a quien los importaba de este módulo.
+export { applyOptionWhen, getDependsOn };
 /**
  * Built-in validators the SDK knows how to apply by symbolic name. Apps
  * that wire `OrgConfigProvider` map `$org.<key>` references to one of
@@ -364,19 +368,6 @@ export function getFieldRef(field) {
 export function fieldHasRef(field) {
     return getFieldRef(field) !== undefined;
 }
-/**
- * Resolves a field's cascade dependency — the key of another form field whose
- * current value scopes this picker's options (`filter_value`). Tolerates the
- * camelCase `dependsOn` (authored SDK shape) and the snake_case `depends_on`
- * the kernel manifest serves. Returns the trimmed field key, or `undefined`
- * when the field declares no dependency.
- */
-export function getDependsOn(field) {
-    const dep = field.dependsOn ?? field.depends_on;
-    if (typeof dep === 'string' && dep.trim() !== '')
-        return dep.trim();
-    return undefined;
-}
 /**
  * Resolves the cascade `filter_value` for a field from the surrounding form
  * context. The depended-on key is matched against the current row first (a
@@ -395,49 +386,6 @@ export function resolveDependsValue(field, formValues, rowValues) {
         return '';
     return String(raw);
 }
-/**
- * Filters a STATIC enum's `options[]` by each option's `when` gate against the
- * current form values. Pure — no React, no side effects.
- *
- * Rule per option:
- * - No `when` → always included (retrocompat; existing enums untouched).
- * - With `when`: the gating field is `when.field ?? dependsOn`. If neither is
- *   present the option is included (nothing to gate on). Otherwise the form's
- *   value for that field is compared AS STRING: included when (no `in`, or
- *   value ∈ `in`) AND (no `not_in`, or value ∉ `not_in`). Tolerates the
- *   snake_case `not_in` the kernel serves alongside camelCase `notIn`.
- *
- * `formValues` is the flat map of the surrounding form/row values the gating
- * field is read from; `dependsOn` is the containing field's declared dependency
- * used as the default gating field.
- */
-export function applyOptionWhen(options, formValues, dependsOn) {
-    if (!Array.isArray(options))
-        return [];
-    return options.filter((opt) => {
-        const when = opt?.when;
-        if (!when)
-            return true;
-        const gate = (typeof when.field === 'string' && when.field.trim() !== '')
-            ? when.field.trim()
-            : dependsOn;
-        if (!gate)
-            return true;
-        const raw = formValues ? formValues[gate] : undefined;
-        const current = raw == null ? '' : String(raw);
-        const inList = when.in;
-        const notIn = when.notIn ?? when.not_in;
-        if (Array.isArray(inList) && inList.length > 0) {
-            if (!inList.some((v) => String(v) === current))
-                return false;
-        }
-        if (Array.isArray(notIn) && notIn.length > 0) {
-            if (notIn.some((v) => String(v) === current))
-                return false;
-        }
-        return true;
-    });
-}
 /**
  * Reads a field's `visible_when` predicate, tolerating the camelCase alias
  * (`visibleWhen`) an app may author and the snake_case (`visible_when`) the

package/dist/dynamic-row-actions.d.ts

@@ -4,6 +4,12 @@ import type { TableMetadata } from './types';
  * metida en `to` el router la tomaba como parte del path y la ruta no casaba.
  */
 export declare function linkNavigation(url: string): {
+    to: '/m/$model';
+    params: {
+        model: string;
+    };
+    search?: Record<string, string>;
+} | {
     to: string;
     search?: Record<string, string>;
 };

package/dist/dynamic-row-actions.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"dynamic-row-actions.d.ts","sourceRoot":"","sources":["../src/dynamic-row-actions.tsx"],"names":[],"mappings":"AAwCA,OAAO,KAAK,EAAE,aAAa,EAAiC,MAAM,SAAS,CAAA;AAE3E;;;GAGG;AACH,wBAAgB,cAAc,CAAC,GAAG,EAAE,MAAM,GAAG;IAAE,EAAE,EAAE,MAAM,CAAC;IAAC,MAAM,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;CAAE,CAI3F;AAED,MAAM,WAAW,0BAA0B;IACvC,6DAA6D;IAC7D,KAAK,EAAE,MAAM,CAAA;IACb;;;;OAIG;IACH,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB;;;;;OAKG;IACH,gBAAgB,CAAC,EAAE,MAAM,CAAA;IACzB,2EAA2E;IAC3E,QAAQ,EAAE,aAAa,GAAG,IAAI,CAAA;IAC9B;;;;OAIG;IACH,QAAQ,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,KAAK,IAAI,CAAA;IAC7C,4EAA4E;IAC5E,SAAS,EAAE,MAAM,IAAI,CAAA;CACxB;AAED,MAAM,WAAW,iBAAiB;IAC9B,+CAA+C;IAC/C,oBAAoB,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,KAAK,OAAO,CAAC,IAAI,CAAC,CAAA;IACjE;;;OAGG;IACH,OAAO,EAAE,KAAK,CAAC,YAAY,CAAA;CAC9B;AAED;;;GAGG;AACH,wBAAgB,oBAAoB,CAAC,EACjC,KAAK,EACL,QAAQ,EACR,gBAAgB,EAChB,QAAQ,EACR,QAAQ,EACR,SAAS,GACZ,EAAE,0BAA0B,GAAG,iBAAiB,CA6IhD"}
+{"version":3,"file":"dynamic-row-actions.d.ts","sourceRoot":"","sources":["../src/dynamic-row-actions.tsx"],"names":[],"mappings":"AAwCA,OAAO,KAAK,EAAE,aAAa,EAAiC,MAAM,SAAS,CAAA;AAE3E;;;GAGG;AACH,wBAAgB,cAAc,CAC1B,GAAG,EAAE,MAAM,GACZ;IAAE,EAAE,EAAE,WAAW,CAAC;IAAC,MAAM,EAAE;QAAE,KAAK,EAAE,MAAM,CAAA;KAAE,CAAC;IAAC,MAAM,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;CAAE,GAAG;IAAE,EAAE,EAAE,MAAM,CAAC;IAAC,MAAM,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;CAAE,CASnI;AAGD,MAAM,WAAW,0BAA0B;IACvC,6DAA6D;IAC7D,KAAK,EAAE,MAAM,CAAA;IACb;;;;OAIG;IACH,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB;;;;;OAKG;IACH,gBAAgB,CAAC,EAAE,MAAM,CAAA;IACzB,2EAA2E;IAC3E,QAAQ,EAAE,aAAa,GAAG,IAAI,CAAA;IAC9B;;;;OAIG;IACH,QAAQ,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,KAAK,IAAI,CAAA;IAC7C,4EAA4E;IAC5E,SAAS,EAAE,MAAM,IAAI,CAAA;CACxB;AAED,MAAM,WAAW,iBAAiB;IAC9B,+CAA+C;IAC/C,oBAAoB,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,KAAK,OAAO,CAAC,IAAI,CAAC,CAAA;IACjE;;;OAGG;IACH,OAAO,EAAE,KAAK,CAAC,YAAY,CAAA;CAC9B;AAED;;;GAGG;AACH,wBAAgB,oBAAoB,CAAC,EACjC,KAAK,EACL,QAAQ,EACR,gBAAgB,EAChB,QAAQ,EACR,QAAQ,EACR,SAAS,GACZ,EAAE,0BAA0B,GAAG,iBAAiB,CA6IhD"}

package/dist/dynamic-row-actions.js

@@ -36,9 +36,14 @@ import { RequiresAddonDialog, resolveRequiresAddon } from './requires-addon';
  */
 export function linkNavigation(url) {
     const i = url.indexOf('?');
-    if (i < 0)
-        return { to: url };
-    return { to: url.slice(0, i), search: Object.fromEntries(new URLSearchParams(url.slice(i + 1))) };
+    const path = i < 0 ? url : url.slice(0, i);
+    const search = i < 0 ? undefined : Object.fromEntries(new URLSearchParams(url.slice(i + 1)));
+    // /m/<tabla>?create=&from=&from_id= → ruta parametrizada (retest r6b: el menú
+    // «Nota de crédito» de la factura aterrizaba en la lista sin abrir el editor).
+    const m = path.match(/^\/m\/([^/?#]+)\/?$/);
+    if (m)
+        return { to: '/m/$model', params: { model: m[1] }, search };
+    return search ? { to: path, search } : { to: path };
 }
 /**
  * Owns the state + dialogs + dispatch logic for per-row actions, shared by
@@ -78,7 +83,7 @@ export function useDynamicRowActions({ model, endpoint, mutationEndpoint, metada
         }
         const linkDef = metadata?.actions?.find((a) => a.key === action && a.type === 'link');
         if (linkDef?.linkUrl) {
-            const url = linkDef.linkUrl.replace(/\{(\w+)\}/g, (_, field) => encodeURIComponent(String(row[field] ?? '')));
+            const url = linkDef.linkUrl.replace(/\{(\w+)\}/g, (_, field) => String(row[field] ?? ''));
             navigate(linkNavigation(url));
             return;
         }

package/dist/option-when.d.ts

@@ -0,0 +1,27 @@
+import type { ActionFieldDef, OptionDef } from './types';
+/**
+ * Resolves a field's cascade dependency — the key of another form field whose
+ * current value scopes this picker's options (`filter_value`). Tolerates the
+ * camelCase `dependsOn` (authored SDK shape) and the snake_case `depends_on`
+ * the kernel manifest serves. Returns the trimmed field key, or `undefined`
+ * when the field declares no dependency.
+ */
+export declare function getDependsOn(field: ActionFieldDef): string | undefined;
+/**
+ * Filters a STATIC enum's `options[]` by each option's `when` gate against the
+ * current form values. Pure — no React, no side effects.
+ *
+ * Rule per option:
+ * - No `when` → always included (retrocompat; existing enums untouched).
+ * - With `when`: the gating field is `when.field ?? dependsOn`. If neither is
+ *   present the option is included (nothing to gate on). Otherwise the form's
+ *   value for that field is compared AS STRING: included when (no `in`, or
+ *   value ∈ `in`) AND (no `not_in`, or value ∉ `not_in`). Tolerates the
+ *   snake_case `not_in` the kernel serves alongside camelCase `notIn`.
+ *
+ * `formValues` is the flat map of the surrounding form/row values the gating
+ * field is read from; `dependsOn` is the containing field's declared dependency
+ * used as the default gating field.
+ */
+export declare function applyOptionWhen(options: OptionDef[] | undefined, formValues: Record<string, any> | null | undefined, dependsOn?: string): OptionDef[];
+//# sourceMappingURL=option-when.d.ts.map

package/dist/option-when.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"option-when.d.ts","sourceRoot":"","sources":["../src/option-when.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,SAAS,CAAA;AAExD;;;;;;GAMG;AACH,wBAAgB,YAAY,CAAC,KAAK,EAAE,cAAc,GAAG,MAAM,GAAG,SAAS,CAItE;AAED;;;;;;;;;;;;;;;GAeG;AACH,wBAAgB,eAAe,CAC3B,OAAO,EAAE,SAAS,EAAE,GAAG,SAAS,EAChC,UAAU,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,GAAG,IAAI,GAAG,SAAS,EAClD,SAAS,CAAC,EAAE,MAAM,GACnB,SAAS,EAAE,CAqBb"}

package/dist/option-when.js

@@ -0,0 +1,56 @@
+/**
+ * Resolves a field's cascade dependency — the key of another form field whose
+ * current value scopes this picker's options (`filter_value`). Tolerates the
+ * camelCase `dependsOn` (authored SDK shape) and the snake_case `depends_on`
+ * the kernel manifest serves. Returns the trimmed field key, or `undefined`
+ * when the field declares no dependency.
+ */
+export function getDependsOn(field) {
+    const dep = field.dependsOn ?? field.depends_on;
+    if (typeof dep === 'string' && dep.trim() !== '')
+        return dep.trim();
+    return undefined;
+}
+/**
+ * Filters a STATIC enum's `options[]` by each option's `when` gate against the
+ * current form values. Pure — no React, no side effects.
+ *
+ * Rule per option:
+ * - No `when` → always included (retrocompat; existing enums untouched).
+ * - With `when`: the gating field is `when.field ?? dependsOn`. If neither is
+ *   present the option is included (nothing to gate on). Otherwise the form's
+ *   value for that field is compared AS STRING: included when (no `in`, or
+ *   value ∈ `in`) AND (no `not_in`, or value ∉ `not_in`). Tolerates the
+ *   snake_case `not_in` the kernel serves alongside camelCase `notIn`.
+ *
+ * `formValues` is the flat map of the surrounding form/row values the gating
+ * field is read from; `dependsOn` is the containing field's declared dependency
+ * used as the default gating field.
+ */
+export function applyOptionWhen(options, formValues, dependsOn) {
+    if (!Array.isArray(options))
+        return [];
+    return options.filter((opt) => {
+        const when = opt?.when;
+        if (!when)
+            return true;
+        const gate = (typeof when.field === 'string' && when.field.trim() !== '')
+            ? when.field.trim()
+            : dependsOn;
+        if (!gate)
+            return true;
+        const raw = formValues ? formValues[gate] : undefined;
+        const current = raw == null ? '' : String(raw);
+        const inList = when.in;
+        const notIn = when.notIn ?? when.not_in;
+        if (Array.isArray(inList) && inList.length > 0) {
+            if (!inList.some((v) => String(v) === current))
+                return false;
+        }
+        if (Array.isArray(notIn) && notIn.length > 0) {
+            if (notIn.some((v) => String(v) === current))
+                return false;
+        }
+        return true;
+    });
+}

package/dist/validator.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"validator.d.ts","sourceRoot":"","sources":["../src/validator.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAE,cAAc,EAAE,eAAe,EAAE,MAAM,SAAS,CAAA;AAC9D,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAA;AAKhD,MAAM,WAAW,cAAc;IAC3B,QAAQ,CAAC,EAAE,OAAO,CAAA;IAClB,IAAI,CAAC,EAAE,MAAM,CAAA;IACb,KAAK,CAAC,EAAE,MAAM,CAAA;IACd,GAAG,CAAC,EAAE,MAAM,CAAA;IACZ,GAAG,CAAC,EAAE,MAAM,CAAA;IACZ,MAAM,CAAC,EAAE,MAAM,CAAA;IACf,OAAO,CAAC,EAAE,MAAM,EAAE,CAAA;CACrB;AAQD,iFAAiF;AACjF,wBAAgB,eAAe,CAAC,CAAC,EAAE,MAAM,GAAG,cAAc,CAyCzD;AAqCD,gFAAgF;AAChF,wBAAgB,iBAAiB,CAAC,KAAK,EAAE,cAAc,GAAG,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,eAAe,CAUlG;AAiCD,4EAA4E;AAC5E,wBAAgB,UAAU,CAAC,KAAK,EAAE,OAAO,EAAE,IAAI,EAAE,cAAc,GAAG,UAAU,EAAE,CAmC7E;AAgDD;+DAC+D;AAC/D,wBAAgB,cAAc,CAC1B,MAAM,EAAE,SAAS,cAAc,EAAE,EACjC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAChC,MAAM,CAAC,MAAM,EAAE,UAAU,EAAE,CAAC,CAI9B;AA8BD,wBAAgB,YAAY,CAAC,GAAG,EAAE,MAAM,CAAC,MAAM,EAAE,UAAU,EAAE,CAAC,GAAG,OAAO,CAEvE;AAYD;;;;;;;GAOG;AACH,wBAAgB,yBAAyB,CACrC,GAAG,EAAE,MAAM,CAAC,MAAM,EAAE,UAAU,EAAE,CAAC,EACjC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAC/B,SAAS,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,IAAI,GAAG,SAAS,GACtD,MAAM,CAAC,MAAM,EAAE,UAAU,EAAE,CAAC,CAY9B"}
+{"version":3,"file":"validator.d.ts","sourceRoot":"","sources":["../src/validator.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAE,cAAc,EAAE,eAAe,EAAE,MAAM,SAAS,CAAA;AAC9D,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAA;AAMhD,MAAM,WAAW,cAAc;IAC3B,QAAQ,CAAC,EAAE,OAAO,CAAA;IAClB,IAAI,CAAC,EAAE,MAAM,CAAA;IACb,KAAK,CAAC,EAAE,MAAM,CAAA;IACd,GAAG,CAAC,EAAE,MAAM,CAAA;IACZ,GAAG,CAAC,EAAE,MAAM,CAAA;IACZ,MAAM,CAAC,EAAE,MAAM,CAAA;IACf,OAAO,CAAC,EAAE,MAAM,EAAE,CAAA;CACrB;AAQD,iFAAiF;AACjF,wBAAgB,eAAe,CAAC,CAAC,EAAE,MAAM,GAAG,cAAc,CAyCzD;AAqCD,gFAAgF;AAChF,wBAAgB,iBAAiB,CAAC,KAAK,EAAE,cAAc,GAAG,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,eAAe,CAUlG;AAiCD,4EAA4E;AAC5E,wBAAgB,UAAU,CAAC,KAAK,EAAE,OAAO,EAAE,IAAI,EAAE,cAAc,GAAG,UAAU,EAAE,CAmC7E;AAyDD;+DAC+D;AAC/D,wBAAgB,cAAc,CAC1B,MAAM,EAAE,SAAS,cAAc,EAAE,EACjC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAChC,MAAM,CAAC,MAAM,EAAE,UAAU,EAAE,CAAC,CAI9B;AAgCD,wBAAgB,YAAY,CAAC,GAAG,EAAE,MAAM,CAAC,MAAM,EAAE,UAAU,EAAE,CAAC,GAAG,OAAO,CAEvE;AAYD;;;;;;;GAOG;AACH,wBAAgB,yBAAyB,CACrC,GAAG,EAAE,MAAM,CAAC,MAAM,EAAE,UAAU,EAAE,CAAC,EACjC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAC/B,SAAS,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,IAAI,GAAG,SAAS,GACtD,MAAM,CAAC,MAAM,EAAE,UAAU,EAAE,CAAC,CAY9B"}

package/dist/validator.js

@@ -1,3 +1,4 @@
+import { applyOptionWhen, getDependsOn } from './option-when';
 const NIL_UUID = '00000000-0000-0000-0000-000000000000';
 const NUMERIC_TYPES = new Set(['int', 'integer', 'bigint', 'decimal', 'numeric', 'number', 'float', 'double']);
 const RULE_NAMES = new Set([
@@ -203,7 +204,13 @@ function checkBuiltin(slug, value) {
             return undefined;
     }
 }
-function specFromField(field) {
+/**
+ * `context` son los valores hermanos contra los que se evalúa el `when` de
+ * cada opción: una opción que su `when` descarta con el valor actual (forma de
+ * pago «99» con método PUE) es `invalid_option`, igual que una fuera de catálogo
+ * — y como la rechaza el kernel al guardar.
+ */
+function specFromField(field, context) {
     const v = fieldValidationOf(field);
     const spec = {
         required: !!field.required,
@@ -213,8 +220,10 @@ function specFromField(field) {
         max: v.max,
         custom: v.custom,
     };
-    if (field.options?.length)
-        spec.options = field.options.map(o => String(o.value));
+    if (field.options?.length) {
+        const applicable = context ? applyOptionWhen(field.options, context, getDependsOn(field)) : field.options;
+        spec.options = applicable.map(o => String(o.value));
+    }
     return spec;
 }
 function isLineItems(field) {
@@ -229,10 +238,10 @@ function itemFieldsOf(field) {
  *  field issue, dotted keys for line-items (`items.0.qty`). */
 export function validateValues(fields, values) {
     const bag = {};
-    walk(fields, values ?? {}, '', bag);
+    walk(fields, values ?? {}, '', bag, values ?? {});
     return bag;
 }
-function walk(fields, values, prefix, bag) {
+function walk(fields, values, prefix, bag, context) {
     for (const field of fields) {
         const key = field.key;
         if (!key)
@@ -247,11 +256,12 @@ function walk(fields, values, prefix, bag) {
             }
             rows.forEach((row, i) => {
                 const obj = row && typeof row === 'object' ? row : {};
-                walk(itemFieldsOf(field), obj, `${path}.${i}`, bag);
+                // Una celda puede depender de otra del renglón o del encabezado.
+                walk(itemFieldsOf(field), obj, `${path}.${i}`, bag, { ...context, ...obj });
             });
             continue;
         }
-        const issues = checkValue(raw, specFromField(field));
+        const issues = checkValue(raw, specFromField(field, context));
         if (issues.length)
             bag[path] = issues;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@asteby/metacore-runtime-react",
-  "version": "49.2.0",
+  "version": "49.3.0",
   "description": "React runtime for metacore hosts — renders addon contributions dynamically",
   "repository": {
     "type": "git",

package/src/__tests__/document-editor-model.test.ts

@@ -17,7 +17,7 @@ import {
     splitEditorFields,
     toOpenDocuments,
 } from '../business/document-editor-model'
-import { makeLine, serializeLineItems } from '../business/line-items'
+import { makeLine, serializeLineItems, validateLineItems } from '../business/line-items'
 import { allocatePayment, validateAllocation } from '../primitives/allocation'
 import type { ActionFieldDef, DocumentFormOpenDocuments } from '../types'
 
@@ -100,6 +100,19 @@ describe('linesFromSource', () => {
         expect(l.discount).toBe(10)
         expect(l.tax_rate).toBe(0.16)
     })
+    it('carga parcial: el descuento en importe se prorratea a lo pendiente (no supera el importe)', () => {
+        // Cotización 4 llantas × $1,000 con $400 de descuento; 3 ya facturadas.
+        const rows = [{ id: 'q1', description: 'Llanta', quantity: 4, unit_price: 1000, discount_amount: 400, tax_rate: 16, source_quantity: 4, remaining_quantity: 1 }]
+        const [l] = linesFromSource(rows, { discount: 'discount_amount' }, { discountMode: 'amount' })
+        expect(l).toMatchObject({ quantity: 1, max_quantity: 1, discount: 100, discount_kind: 'amount' })
+        expect(validateLineItems([l]).errors).toEqual({})
+        // Sin lo pendiente servido (o completo) el importe queda intacto.
+        const [full] = linesFromSource([{ ...rows[0], remaining_quantity: 4 }], { discount: 'discount_amount' }, { discountMode: 'amount' })
+        expect(full.discount).toBe(400)
+        // Un porcentaje no depende de la cantidad.
+        const [pct] = linesFromSource([{ ...rows[0], discount_pct: 10 }], { discount: 'discount_pct' })
+        expect(pct.discount).toBe(10)
+    })
     it('NC (credit): la cantidad queda topada en lo facturado', () => {
         const [l] = linesFromSource([{ description: 'Llanta', quantity: 4, unit_price: 1500, tax_rate: 0.16 }], {}, { kind: 'credit' })
         expect(l.max_quantity).toBe(4)

package/src/__tests__/document-editor.test.tsx

@@ -224,6 +224,28 @@ describe('DocumentEditor — cobro / REP (lines.kind: allocation)', () => {
         expect(body.type).toBeUndefined()
     })
 
+    it('«crear desde» una factura: toma su cliente y lista sus facturas abiertas con saldo', async () => {
+        const fromInvoice: DocumentFormType = {
+            ...payment,
+            fields: payment.fields.map((f) => ({ ...f, default_from_record: undefined }) as any),
+            sources: [{ key: 'invoice', label: 'Factura', model: 'customers.Invoice', lines: 'items', header: { customer_id: 'customer_id' } }],
+        }
+        const api = makeApi({
+            ...routes,
+            '/data/customers.Invoice': (_url: string, cfg?: { params?: Record<string, unknown> }) =>
+                cfg?.params?.f_id
+                    ? { data: [{ id: 'inv-new', number: 'A-2', customer_id: 'c1', amount_due: 1000 }] }
+                    : (routes['/data/customers.Invoice'] as unknown),
+        })
+        renderEditor(fromInvoice, api, { initialSource: { key: 'invoice', id: 'inv-new' } })
+        await screen.findByText('A-1')
+        expect(screen.getByText('A-2')).toBeTruthy()
+        expect(api.get).toHaveBeenCalledWith('/data/customers.Invoice', expect.objectContaining({ params: expect.objectContaining({ f_id: 'eq:inv-new' }) }))
+        expect(api.get).toHaveBeenCalledWith('/data/customers.Invoice', expect.objectContaining({ params: expect.objectContaining({ f_customer_id: 'eq:c1' }) }))
+        // Sin renglones que copiar: no pide source-lines ni la relación.
+        expect(api.get.mock.calls.some(([u]) => String(u).includes('source-lines'))).toBe(false)
+    })
+
     it('editar un monto pasa a reparto manual; «Autoaplicar» regresa al automático', async () => {
         const api = makeApi(routes)
         renderEditor(payment, api, { record: { customer_id: 'c1' } })
@@ -298,7 +320,7 @@ describe('DocumentEditor — «crear desde» con lo pendiente del servidor', ()
         await screen.findByDisplayValue('Llanta 205/55R16')
         expect(screen.queryByDisplayValue('Balanceo')).toBeNull()
         expect(api.get).toHaveBeenCalledWith('/dynamic/customers.Invoice/source-lines', { params: { source: 'sales_order', id: 'so-1' } })
-        expect(await screen.findByText('1 renglones con lo pendiente · 1 ya cubiertos se omitieron')).toBeTruthy()
+        expect(await screen.findByText('1 renglones con lo que falta · 1 ya completos (omitidos)')).toBeTruthy()
     })
 
     it('si el host aún no sirve source-lines (404) cae a la relación del origen', async () => {

package/src/__tests__/invoice-document-editor.test.tsx

@@ -164,7 +164,7 @@ describe('Factura con layout editor — pantalla única', () => {
 
     it('«Cargar desde» ofrece venta, OT y cotización como opciones', () => {
         renderInvoice(makeApi())
-        const group = screen.getByRole('radiogroup', { name: 'Tipo de documento origen' })
+        const group = screen.getByRole('radiogroup', { name: 'Documento de origen' })
         expect(within(group).getAllByRole('radio').map((r) => r.textContent)).toEqual(['Venta', 'Orden de trabajo', 'Cotización'])
         fireEvent.click(within(group).getByRole('radio', { name: 'Orden de trabajo' }))
         expect(within(group).getByRole('radio', { name: 'Orden de trabajo' }).getAttribute('aria-checked')).toBe('true')
@@ -180,7 +180,7 @@ describe('Factura — «Cargar desde» OT y cotización con lo restante', () =>
         expect(screen.getByDisplayValue('Alineación eje direccional')).toBeTruthy()
         expect(screen.queryByDisplayValue('Montaje y balanceo')).toBeNull()
         expect(api.get).toHaveBeenCalledWith('/dynamic/customers.Invoice/source-lines', { params: { source: 'work_order', id: 'wo-1' } })
-        expect(await screen.findByText('2 renglones con lo pendiente · 1 ya cubiertos se omitieron')).toBeTruthy()
+        expect(await screen.findByText('2 renglones con lo que falta · 1 ya completos (omitidos)')).toBeTruthy()
 
         // La tarjeta del cliente: datos fiscales con etiquetas del modelo.
         await waitFor(() => expect(slot('party-card')).toBeTruthy())
@@ -214,8 +214,9 @@ describe('Factura — «Cargar desde» OT y cotización con lo restante', () =>
         const [, body] = api.post.mock.calls[0] as [string, any]
         expect(body.quote_id).toBe('q-1')
         expect(body.currency_code).toBe('MXN')
+        // El descuento ($1,200 de las 6 piezas) se prorratea a las 4 pendientes.
         expect(body.items).toEqual([
-            expect.objectContaining({ product_id: 'p-llanta', quantity: 4, unit_price: 5890, discount: 1200, tax_rate: 0.16, quote_item_id: 'qi-1' }),
+            expect.objectContaining({ product_id: 'p-llanta', quantity: 4, unit_price: 5890, discount: 800, tax_rate: 0.16, quote_item_id: 'qi-1' }),
         ])
         expect(body.items[0]).not.toHaveProperty('work_order_item_id')
     })

package/src/__tests__/option-when-validation.test.tsx

@@ -0,0 +1,87 @@
+// @vitest-environment happy-dom
+// Forma de pago «99 · Por definir» solo con método PPD, y con PPD solo «99»:
+// la regla viaja en el `when` de las opciones del manifest. El validador y el
+// render compartido de campos (renderField, que usan el DocumentEditor, el
+// diálogo de document_forms y los modales de acción) la respetan.
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { cleanup, render } from '@testing-library/react'
+
+vi.mock('react-i18next', () => ({
+    useTranslation: () => ({ t: (k: string, o?: { defaultValue?: string }) => o?.defaultValue ?? k, i18n: { language: 'es' } }),
+}))
+
+import { validateValues } from '../validator'
+import { renderField } from '../action-modal-dispatcher'
+import type { ActionFieldDef } from '../types'
+
+const notPPD = { field: 'fiscal_data.metodo_pago', not_in: ['PPD'] }
+const ppd = { field: 'fiscal_data.metodo_pago', in: ['PPD'] }
+const fields: ActionFieldDef[] = [
+    {
+        key: 'fiscal_data.metodo_pago',
+        label: 'Método',
+        type: 'select',
+        options: [
+            { value: 'PUE', label: 'PUE' },
+            { value: 'PPD', label: 'PPD' },
+        ],
+    },
+    {
+        key: 'fiscal_data.forma_pago',
+        label: 'Forma',
+        type: 'select',
+        options: [
+            { value: '01', label: 'Efectivo', when: notPPD },
+            { value: '03', label: 'Transferencia', when: notPPD },
+            { value: '99', label: 'Por definir', when: ppd },
+        ],
+    },
+]
+
+const header = (metodo: string, forma: string) => ({ 'fiscal_data.metodo_pago': metodo, 'fiscal_data.forma_pago': forma })
+
+afterEach(cleanup)
+
+describe('validateValues con options[].when', () => {
+    it('99 con PUE es invalid_option', () => {
+        const bag = validateValues(fields, header('PUE', '99'))
+        expect(bag['fiscal_data.forma_pago']?.[0]?.code).toBe('invalid_option')
+        expect(bag['fiscal_data.forma_pago']?.[0]?.params).toEqual({ allowed: ['01', '03'] })
+    })
+    it('PPD exige 99', () => {
+        const bag = validateValues(fields, header('PPD', '01'))
+        expect(bag['fiscal_data.forma_pago']?.[0]).toEqual({ code: 'invalid_option', params: { allowed: ['99'] } })
+    })
+    it('PPD + 99 y PUE + 01 pasan', () => {
+        expect(validateValues(fields, header('PPD', '99'))).toEqual({})
+        expect(validateValues(fields, header('PUE', '01'))).toEqual({})
+    })
+    it('una celda de renglón se evalúa contra su renglón y el encabezado', () => {
+        const lines: ActionFieldDef = {
+            key: 'items',
+            label: 'Renglones',
+            type: 'array',
+            itemFields: [{ ...fields[1]!, key: 'forma' }],
+        }
+        const bag = validateValues([fields[0]!, lines], { 'fiscal_data.metodo_pago': 'PPD', items: [{ forma: '03' }, { forma: '99' }] })
+        expect(bag['items.0.forma']?.[0]?.code).toBe('invalid_option')
+        expect(bag['items.1.forma']).toBeUndefined()
+    })
+})
+
+describe('renderField con options[].when', () => {
+    const trigger = (metodo: string, forma: string) => {
+        const { container } = render(<>{renderField(fields[1]!, forma, () => {}, header(metodo, forma))}</>)
+        return container.querySelector('[aria-invalid], button, [role="combobox"]') as HTMLElement
+    }
+    it('marca en el acto una forma que el método ya no permite', () => {
+        const el = trigger('PUE', '99')
+        expect(el.getAttribute('aria-invalid')).toBe('true')
+        expect(el.getAttribute('data-stale-option')).toBe('true')
+    })
+    it('una combinación válida no se marca', () => {
+        const el = trigger('PPD', '99')
+        expect(el.getAttribute('aria-invalid')).toBeNull()
+        expect(el.getAttribute('data-stale-option')).toBeNull()
+    })
+})

package/src/__tests__/r6-editor-option-when.test.tsx

@@ -0,0 +1,104 @@
+// @vitest-environment happy-dom
+// Retest Pitsline r6 (P0 UX): en el editor de la factura, método PPD exige
+// forma de pago 99 (`options[].when` del manifest). Elegir PPD fija 99 solo y
+// el alta lleva los dos valores, no solo el diálogo de Timbrar.
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
+
+vi.mock('@tanstack/react-router', () => ({ useNavigate: () => () => {} }))
+vi.mock('react-i18next', () => {
+    const value = { t: (k: string, o?: Record<string, any>) => o?.defaultValue ?? k, i18n: { language: 'es' } }
+    return { useTranslation: () => value }
+})
+
+import { DocumentFormDialog } from '../document-form-dialog'
+import { ApiProvider, type ApiClient } from '../api-context'
+import { TaxRateContext } from '../org-runtime-context'
+import { gatedOptionFixes } from '../business/document-editor-model'
+import type { ActionFieldDef, DocumentFormsManifest, DocumentFormType } from '../types'
+
+afterEach(cleanup)
+
+const notPPD = { field: 'fiscal_data.metodo_pago', not_in: ['PPD'] }
+const formaPago: ActionFieldDef = {
+    key: 'fiscal_data.forma_pago',
+    label: 'Forma de pago',
+    type: 'select',
+    required: true,
+    defaultValue: '01',
+    options: [
+        { value: '01', label: 'Efectivo · 01', when: notPPD },
+        { value: '03', label: 'Transferencia · 03', when: notPPD },
+        { value: '99', label: 'Por definir · 99', when: { field: 'fiscal_data.metodo_pago', in: ['PPD'] } },
+    ],
+} as ActionFieldDef
+const metodoPago: ActionFieldDef = {
+    key: 'fiscal_data.metodo_pago',
+    label: 'Método de pago',
+    type: 'select',
+    required: true,
+    defaultValue: 'PUE',
+    options: [
+        { value: 'PUE', label: 'Una sola exhibición · PUE' },
+        { value: 'PPD', label: 'Parcialidades o diferido · PPD' },
+    ],
+}
+
+const invoice: DocumentFormType = {
+    key: 'invoice',
+    label: 'Factura',
+    layout: 'editor',
+    fields: [{ key: 'customer_id', label: 'Cliente', type: 'text', required: true }, metodoPago, formaPago],
+    defaults: { 'fiscal_data.metodo_pago': 'PUE', 'fiscal_data.forma_pago': '01' },
+    lines: { title: 'Renglones', required: false },
+    submit_label: 'Crear factura',
+}
+
+function renderInvoice(post: ReturnType<typeof vi.fn>) {
+    const client = { get: vi.fn(async () => ({ data: { data: [] } })), post, put: vi.fn(), delete: vi.fn() } as unknown as ApiClient
+    const forms: DocumentFormsManifest = { lines_field: 'items', types: [invoice] }
+    return render(
+        <ApiProvider client={client}>
+            <TaxRateContext.Provider value={0.16}>
+                <DocumentFormDialog open onOpenChange={() => {}} model="customers.Invoice" forms={forms} initialType="invoice" currency="MXN" />
+            </TaxRateContext.Provider>
+        </ApiProvider>,
+    )
+}
+
+async function pick(fieldLabel: RegExp, option: RegExp) {
+    const trigger = screen.getAllByRole('combobox').find((el) => fieldLabel.test(el.closest('[data-slot="field-cell"], div')?.textContent ?? '')) as HTMLElement
+    fireEvent.pointerDown(trigger, { button: 0, ctrlKey: false, pointerType: 'mouse' })
+    fireEvent.click(await screen.findByRole('option', { name: option }))
+}
+
+describe('factura: método PPD ⇒ forma de pago 99', () => {
+    it('elegir PPD fija la forma 99 y el alta la lleva', async () => {
+        const post = vi.fn().mockResolvedValue({ data: { success: true, data: { id: 'inv-1' } } })
+        renderInvoice(post)
+        fireEvent.change(document.getElementById('customer_id')!, { target: { value: 'c-1' } })
+
+        await pick(/Método de pago/, /PPD/)
+        await waitFor(() => expect(screen.getAllByText('Por definir · 99').length).toBeGreaterThan(0))
+        fireEvent.click(screen.getByRole('button', { name: 'Crear factura' }))
+        await waitFor(() => expect(post).toHaveBeenCalled())
+        const body = post.mock.calls[0][1] as Record<string, unknown>
+        expect(body['fiscal_data.metodo_pago']).toBe('PPD')
+        expect(body['fiscal_data.forma_pago']).toBe('99')
+    })
+})
+
+describe('gatedOptionFixes', () => {
+    const fields = [metodoPago, formaPago]
+    it('PPD con forma 01 → 99 (la única que aplica)', () => {
+        expect(gatedOptionFixes(fields, { 'fiscal_data.metodo_pago': 'PPD', 'fiscal_data.forma_pago': '01' })).toEqual({ 'fiscal_data.forma_pago': '99' })
+    })
+    it('PUE con forma 99 → el default del campo', () => {
+        expect(gatedOptionFixes(fields, { 'fiscal_data.metodo_pago': 'PUE', 'fiscal_data.forma_pago': '99' })).toEqual({ 'fiscal_data.forma_pago': '01' })
+    })
+    it('valor válido o vacío con varias opciones: sin cambios (converge)', () => {
+        expect(gatedOptionFixes(fields, { 'fiscal_data.metodo_pago': 'PUE', 'fiscal_data.forma_pago': '03' })).toEqual({})
+        expect(gatedOptionFixes(fields, { 'fiscal_data.metodo_pago': 'PUE', 'fiscal_data.forma_pago': '' })).toEqual({})
+        expect(gatedOptionFixes(fields, { 'fiscal_data.metodo_pago': 'PPD', 'fiscal_data.forma_pago': '99' })).toEqual({})
+    })
+})