@asteby/metacore-runtime-react 46.4.0 → 47.1.0

package/src/__tests__/option-filter.test.tsx

@@ -0,0 +1,115 @@
+// @vitest-environment happy-dom
+//
+// `option_filter` / `optionFilter` on a relation picker hides options client-side
+// (PIT-059: cancelled invoices must not show up in the payments selector).
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { act, cleanup, render, screen, waitFor, within } from '@testing-library/react'
+import { applyOptionFilter, getOptionFilter, optionPassesRule } from '../option-filter'
+import { projectOption } from '../use-options-resolver'
+import { DynamicSelectField } from '../dynamic-select-field'
+import { ApiProvider, type ApiClient } from '../api-context'
+import type { ActionFieldDef } from '../types'
+
+vi.mock('react-i18next', () => ({
+    useTranslation: () => ({ t: (k: string, o?: any) => o?.defaultValue ?? k, i18n: { language: 'es' } }),
+}))
+
+afterEach(cleanup)
+
+const invoices = [
+    { id: 'i1', label: 'FAC-1', status: 'timbrada', total: 100 },
+    { id: 'i2', label: 'FAC-2', status: 'Cancelada', total: 50 },
+    { id: 'i3', label: 'FAC-3', status: 'pendiente', total: 70 },
+    { id: 'i4', label: 'FAC-4' },
+].map(projectOption)
+
+describe('getOptionFilter', () => {
+    it('is empty when the field declares none (retrocompat)', () => {
+        expect(getOptionFilter({ key: 'x' })).toEqual([])
+        expect(getOptionFilter(undefined)).toEqual([])
+    })
+    it('reads camelCase and snake_case, one rule or a list', () => {
+        const rule = { field: 'status', not_in: ['cancelada'] }
+        expect(getOptionFilter({ optionFilter: rule })).toEqual([rule])
+        expect(getOptionFilter({ option_filter: [rule] })).toEqual([rule])
+    })
+    it('ignores malformed rules', () => {
+        expect(getOptionFilter({ option_filter: [{ nope: 1 }, null, { field: '' }] })).toEqual([])
+    })
+})
+
+describe('applyOptionFilter', () => {
+    it('returns the same array with no rules', () => {
+        expect(applyOptionFilter(invoices, [])).toBe(invoices)
+    })
+    it('not_in hides cancelled invoices (case-insensitive) and keeps options without the column', () => {
+        const out = applyOptionFilter(invoices, [{ field: 'status', not_in: ['cancelada'] }])
+        expect(out.map((o) => o.id)).toEqual(['i1', 'i3', 'i4'])
+    })
+    it('notEquals alias and equals / in need the column to exist', () => {
+        expect(applyOptionFilter(invoices, [{ field: 'status', notEquals: 'cancelada' }]).map((o) => o.id)).toEqual(['i1', 'i3', 'i4'])
+        expect(applyOptionFilter(invoices, [{ field: 'status', equals: 'timbrada' }]).map((o) => o.id)).toEqual(['i1'])
+        expect(applyOptionFilter(invoices, [{ field: 'status', in: ['timbrada', 'pendiente'] }]).map((o) => o.id)).toEqual(['i1', 'i3'])
+    })
+    it('combines rules with AND', () => {
+        const out = applyOptionFilter(invoices, [
+            { field: 'status', not_in: ['cancelada'] },
+            { field: 'status', not_equals: 'pendiente' },
+        ])
+        expect(out.map((o) => o.id)).toEqual(['i1', 'i4'])
+    })
+    it('never hides the current selection', () => {
+        const out = applyOptionFilter(invoices, [{ field: 'status', not_in: ['cancelada'] }], 'i2')
+        expect(out.map((o) => o.id)).toEqual(['i1', 'i2', 'i3', 'i4'])
+    })
+    it('tests standard keys too (label)', () => {
+        expect(optionPassesRule(invoices[0], { field: 'label', equals: 'fac-1' })).toBe(true)
+    })
+})
+
+describe('DynamicSelectField with option_filter', () => {
+    const field = (extra: Partial<ActionFieldDef> = {}): ActionFieldDef => ({
+        key: 'invoice_id',
+        label: 'Factura',
+        type: 'dynamic_select',
+        ref: 'invoices.Invoice',
+        ...extra,
+    })
+    const api = () => {
+        const get = vi.fn(async () => ({
+            data: {
+                success: true,
+                data: [
+                    { id: 'i1', label: 'FAC-1', status: 'timbrada' },
+                    { id: 'i2', label: 'FAC-2', status: 'cancelada' },
+                ],
+                meta: { type: 'dynamic', count: 2 },
+            },
+        }))
+        const post = vi.fn(async () => ({ data: { success: false } }))
+        return { get, post } as unknown as ApiClient
+    }
+    const open = async (f: ActionFieldDef) => {
+        render(
+            <ApiProvider client={api()}>
+                <DynamicSelectField field={f} value="" onChange={() => {}} />
+            </ApiProvider>,
+        )
+        await act(async () => {
+            screen.getByRole('combobox').click()
+        })
+    }
+
+    it('lists every option without a filter', async () => {
+        await open(field())
+        await waitFor(() => expect(screen.getByText('FAC-2')).toBeTruthy())
+        expect(screen.getByText('FAC-1')).toBeTruthy()
+    })
+
+    it('hides the cancelled invoice when the manifest declares option_filter', async () => {
+        await open(field({ option_filter: { field: 'status', not_in: ['cancelada'] } }))
+        await waitFor(() => expect(screen.getByText('FAC-1')).toBeTruthy())
+        expect(screen.queryByText('FAC-2')).toBeNull()
+        expect(within(document.body).queryAllByText('FAC-2')).toHaveLength(0)
+    })
+})

package/src/__tests__/permissions-manager.test.tsx

@@ -249,9 +249,25 @@ describe('PermissionsManager (módulo como combobox agrupado)', () => {
         expect(screen.getByRole('option', { name: /Pedidos POS/ })).toBeTruthy()
         expect(screen.getByRole('option', { name: /Terminal/ })).toBeTruthy()
 
-        // Generales presentes con descripción.
-        expect(screen.getByText('Permisos Generales')).toBeTruthy()
-        expect(screen.getByText('Trabajar fuera de horario')).toBeTruthy()
+        // Los generales son un grupo sintético del combobox (#1021), no cards
+        // sueltas junto a la tarjeta del rol.
+        expect(screen.getByRole('option', { name: /Permisos generales/ })).toBeTruthy()
+        expect(screen.queryByText('Trabajar fuera de horario')).toBeNull()
+    })
+
+    it('«Permisos generales» se edita en la misma grilla de dos columnas y cuenta en el total', async () => {
+        const props = makeProps()
+        render(<PermissionsManager {...props} />)
+        await waitFor(() => expect(moduleTrigger().textContent).toMatch(/Usuarios/))
+
+        await selectModule(/Permisos generales/)
+        expect(await screen.findByText('Trabajar fuera de horario')).toBeTruthy()
+        expect(screen.getByText('0/1')).toBeTruthy()
+        const box = screen.getByRole('checkbox', { name: /Trabajar fuera de horario/ })
+        // Misma grilla que las acciones de un módulo.
+        expect(box.closest('div.grid')?.className).toContain('sm:grid-cols-2')
+        fireEvent.click(box)
+        expect(screen.getByText('1/1')).toBeTruthy()
     })
 
     it('CERO acordeones: el módulo es un combobox, no un folder colapsable', async () => {
@@ -304,7 +320,8 @@ describe('PermissionsManager (módulo como combobox agrupado)', () => {
         await selectModule(/Pedidos POS/)
         await screen.findByText('Pagar')
         fireEvent.click(screen.getByRole('checkbox', { name: /Pagar/ }))
-        fireEvent.click(screen.getByRole('checkbox', { name: /Trabajar fuera de horario/ }))
+        await selectModule(/Permisos generales/)
+        fireEvent.click(await screen.findByRole('checkbox', { name: /Trabajar fuera de horario/ }))
 
         expect(screen.getByText('Cambios sin guardar')).toBeTruthy()
         fireEvent.click(screen.getByRole('button', { name: /Guardar permisos/ }))

package/src/__tests__/structured-view-value.test.tsx

@@ -82,7 +82,11 @@ describe('detail-view jsonb line-items (ViewValue → inline CollectionCell)', (
                 record={{}}
             />
         )
-        expect(screen.getByText('Precio:')).toBeTruthy()
+        // Keys are humanized (the addon-declared label is the localized source);
+        // each pair renders as a <dt>/<dd>, never "[object Object]".
+        expect(screen.getByText('Price').tagName).toBe('DT')
+        expect(screen.getByText('10').tagName).toBe('DD')
+        expect(screen.getByText('Quantity')).toBeTruthy()
         expect(container.textContent).not.toContain('[object Object]')
     })
 

package/src/__tests__/use-print-document-feedback.test.tsx

@@ -0,0 +1,58 @@
+// @vitest-environment happy-dom
+// «Descargar Factura CFDI» no daba señal alguna: ahora hay progreso, éxito y
+// el motivo del servidor si falla (la promesa sigue rechazando).
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { cleanup, renderHook } from '@testing-library/react'
+import type { ReactNode } from 'react'
+
+const toast = vi.hoisted(() => ({
+    loading: vi.fn(() => 'tid'),
+    success: vi.fn(),
+    error: vi.fn(),
+    dismiss: vi.fn(),
+}))
+vi.mock('sonner', () => ({ toast }))
+
+import { usePrintDocument, documentErrorMessage } from '../use-print-document'
+import { ApiProvider, type ApiClient } from '../api-context'
+
+afterEach(() => {
+    cleanup()
+    vi.clearAllMocks()
+})
+
+const wrap = (client: ApiClient) => ({ children }: { children: ReactNode }) => <ApiProvider client={client}>{children}</ApiProvider>
+
+describe('usePrintDocument feedback', () => {
+    it('descarga: toast de progreso y de éxito', async () => {
+        URL.createObjectURL = vi.fn(() => 'blob:x')
+        const client = { get: vi.fn().mockResolvedValue({ data: new Blob(['x']), headers: {} }) } as unknown as ApiClient
+        const { result } = renderHook(() => usePrintDocument(), { wrapper: wrap(client) })
+        await result.current({ model: 'Invoice', id: '1', key: 'cfdi', mode: 'download' })
+        expect(toast.loading).toHaveBeenCalled()
+        expect(toast.success).toHaveBeenCalledWith('Documento descargado')
+        expect(toast.dismiss).toHaveBeenCalled()
+        expect(toast.error).not.toHaveBeenCalled()
+    })
+
+    it('fallo: muestra el motivo del servidor (cuerpo Blob) y rechaza', async () => {
+        const body = new Blob([JSON.stringify({ message: 'La factura aún no está timbrada' })], { type: 'application/json' })
+        const client = { get: vi.fn().mockRejectedValue({ response: { status: 409, data: body } }) } as unknown as ApiClient
+        const { result } = renderHook(() => usePrintDocument(), { wrapper: wrap(client) })
+        await expect(result.current({ model: 'Invoice', id: '1', key: 'cfdi', mode: 'download' })).rejects.toBeTruthy()
+        expect(toast.error).toHaveBeenCalledWith('La factura aún no está timbrada')
+    })
+
+    it('feedback:false no muestra nada; error:false deja el error al llamador', async () => {
+        const client = { get: vi.fn().mockRejectedValue({ response: { status: 500, data: null } }) } as unknown as ApiClient
+        const { result } = renderHook(() => usePrintDocument(), { wrapper: wrap(client) })
+        await expect(result.current({ model: 'I', id: '1', key: 'k', mode: 'open', feedback: false })).rejects.toBeTruthy()
+        await expect(result.current({ model: 'I', id: '1', key: 'k', mode: 'open', feedback: { progress: true, error: false } })).rejects.toBeTruthy()
+        expect(toast.error).not.toHaveBeenCalled()
+    })
+
+    it('documentErrorMessage cae a un mensaje genérico', async () => {
+        expect(await documentErrorMessage(new Error('x'))).toMatch(/No se pudo generar/)
+        expect(await documentErrorMessage({ response: { status: 404 } })).toMatch(/no está disponible/)
+    })
+})

package/src/__tests__/wizard-action-modal.test.tsx

@@ -14,7 +14,7 @@ import { afterEach, describe, expect, it, vi } from 'vitest'
 import { cleanup, render, screen, fireEvent, waitFor } from '@testing-library/react'
 
 vi.mock('react-i18next', () => ({
-    useTranslation: () => ({ t: (k: string, o?: any) => o?.defaultValue ?? k }),
+    useTranslation: () => ({ t: (k: string, o?: any) => o?.defaultValue ?? k, i18n: { language: 'es' } }),
 }))
 
 import { ActionModalDispatcher } from '../action-modal-dispatcher'

package/src/action-modal-dispatcher.tsx

@@ -14,7 +14,8 @@
 //
 // The host injects its axios-like client via <ApiProvider>; we no longer
 // depend on a bundler alias to `@/lib/api`.
-import { useState, useEffect, useMemo, useRef, useSyncExternalStore } from 'react'
+import { emitRecordMutation } from './record-mutation-events'
+import { useState, useCallback, useEffect, useMemo, useRef, useSyncExternalStore } from 'react'
 import { useTranslation } from 'react-i18next'
 import {
     Dialog,
@@ -44,7 +45,9 @@ import {
 import { Loader2 } from 'lucide-react'
 import { ProcessStepper } from '@asteby/metacore-ui/wizard'
 import { toast } from 'sonner'
-import { toastServerError, toastServerSuccess, extractFieldErrors, localizeFieldErrorMap } from './server-error'
+import { toastServerError, toastServerSuccess, extractFieldErrors, extractServerError, localizeFieldErrorMap } from './server-error'
+import { FormErrorBanner } from './business/feedback'
+import { CfdiStampResultDialog, extractStampResult, type CfdiStampResult } from './cfdi-stamp-panel'
 import { useBranchCreateGate } from './branch-create-gate'
 import type { Translate } from './server-error'
 import { validateValues, bagHasErrors } from './validator'
@@ -358,8 +361,15 @@ export function ActionModalDispatcher({
     model,
     record,
     endpoint,
-    onSuccess,
+    onSuccess: onSuccessProp,
 }: ActionModalProps) {
+    // Every successful action may have created/updated/deleted a record of
+    // `model` (federated component, wizard, generic form or confirmation), so
+    // announce it: mounted lists of the model reload on their own (#1020).
+    const onSuccess = useCallback(() => {
+        emitRecordMutation(model, 'update')
+        onSuccessProp?.()
+    }, [model, onSuccessProp])
     // Reactive read: a federated remote usually registers AFTER the first
     // render, and a memoized lookup would pin the fallback forever.
     const readComponent = () => getActionComponent(model, action.key)
@@ -794,10 +804,34 @@ function toastActionError(
     toastServerError(err, { t, language })
 }
 
+/** Text for the in-dialog error banner of a failed action (PIT-046, #1023): a
+ *  422 with per-field `errors` -> "Revisa los campos" + each localized line; any
+ *  other failure (500, network) -> the server's own message and cause. Unlike
+ *  the toast it stays on screen until the next attempt. */
+export function actionErrorBannerMessage(
+    err: unknown,
+    fields: readonly ActionFieldDef[] | undefined,
+    t: Translate,
+    language?: string,
+): string {
+    const localized = localizeActionFieldErrors(err, fields, t, language)
+    if (localized) {
+        const head = t('validation.failed', { defaultValue: validationCatalog(language).failed })
+        const lines = Object.values(localized).filter(Boolean)
+        return lines.length ? `${head}: ${lines.join(' · ')}` : head
+    }
+    const fallback = t('common.error', { defaultValue: 'Algo salió mal. Intenta de nuevo.' })
+    const ex = extractServerError(err, fallback)
+    const title = t(ex.title, { defaultValue: ex.title })
+    return ex.description && ex.description !== title ? `${title} — ${ex.description}` : title
+}
+
 function ConfirmActionDialog({ open, onOpenChange, action, model, record, endpoint, onSuccess }: ActionModalProps) {
     const { t, i18n } = useTranslation()
     const api = useApi()
     const [executing, setExecuting] = useState(false)
+    const [formError, setFormError] = useState<string | undefined>()
+    const [stamp, setStamp] = useState<CfdiStampResult | undefined>()
     // Actions listed in the model's `reason_required.actions` (cancel, void…)
     // answer 422 errors.reason without a motive; the prompt asks and retries.
     const reasonPrompt = useReasonPrompt()
@@ -809,6 +843,7 @@ function ConfirmActionDialog({ open, onOpenChange, action, model, record, endpoi
 
     const execute = async () => {
         setExecuting(true)
+        setFormError(undefined)
         try {
             const url = buildActionUrl(endpoint, model, record.id, action.key)
             // Supervisor PIN first (action.supervisorPolicy); null = cancelled.
@@ -823,18 +858,41 @@ function ConfirmActionDialog({ open, onOpenChange, action, model, record, endpoi
             if (!res) return
             if (res.data.success) {
                 toastServerSuccess(res.data, { t })
+                const result = extractStampResult(res.data)
+                if (result) {
+                    setStamp(result)
+                    return
+                }
                 onOpenChange(false)
                 onSuccess()
             } else {
+                setFormError(actionErrorBannerMessage({ response: { data: res.data } }, action.fields, t, i18n.language))
                 toastActionError({ response: { data: res.data } }, action.fields, t, i18n.language)
             }
         } catch (err: any) {
+            setFormError(actionErrorBannerMessage(err, action.fields, t, i18n.language))
             toastActionError(err, action.fields, t, i18n.language)
         } finally {
             setExecuting(false)
         }
     }
 
+    if (stamp) {
+        return (
+            <CfdiStampResultDialog
+                open={open}
+                result={stamp}
+                title={label}
+                onOpenChange={(o) => {
+                    if (o) return
+                    setStamp(undefined)
+                    onOpenChange(false)
+                    onSuccess()
+                }}
+            />
+        )
+    }
+
     return (
         <>
         {reasonPrompt.dialog}
@@ -850,6 +908,7 @@ function ConfirmActionDialog({ open, onOpenChange, action, model, record, endpoi
                     </AlertDialogDescription>
                 </AlertDialogHeader>
                 {record ? <RecordPreview model={model} record={record} /> : null}
+                <FormErrorBanner message={formError} />
                 <AlertDialogFooter>
                     <AlertDialogCancel disabled={executing}>{t('common.cancel')}</AlertDialogCancel>
                     <AlertDialogAction
@@ -881,6 +940,10 @@ function GenericActionModal({ open, onOpenChange, action, model, record, endpoin
     const [executing, setExecuting] = useState(false)
     // Per-field validation errors (localized), shown inline under each input.
     const [fieldErrors, setFieldErrors] = useState<Record<string, string>>({})
+    // Persistent in-dialog banner for a failed submit (422 / 500) — the toast
+    // alone vanished and, for some failures, only the console had the cause.
+    const [formError, setFormError] = useState<string | undefined>()
+    const [stamp, setStamp] = useState<CfdiStampResult | undefined>()
     // Related records to surface BELOW the form, as read-only context for the
     // record being acted on — e.g. the reception history of a transfer while
     // receiving against it. Sourced from the model's metadata.relations (the
@@ -912,6 +975,7 @@ function GenericActionModal({ open, onOpenChange, action, model, record, endpoin
         if (open && action.fields) {
             setFormData(buildFieldDefaults(action.fields, record))
             setFieldErrors({})
+            setFormError(undefined)
         }
     }, [open, action.fields, record])
 
@@ -999,6 +1063,7 @@ function GenericActionModal({ open, onOpenChange, action, model, record, endpoin
 
     const lang = i18n.language
     const handleActionError = (err: unknown) => {
+        setFormError(actionErrorBannerMessage(err, action.fields, t, lang))
         const labels = labelsForValidationFields(action.fields, t)
         const localized = localizeActionFieldErrors(err, action.fields, t, lang)
         if (localized) {
@@ -1035,6 +1100,7 @@ function GenericActionModal({ open, onOpenChange, action, model, record, endpoin
             }
         }
         setFieldErrors({})
+        setFormError(undefined)
         setExecuting(true)
         try {
             let payload: Record<string, any> = { ...formData }
@@ -1069,6 +1135,11 @@ function GenericActionModal({ open, onOpenChange, action, model, record, endpoin
             if (!res) return
             if (res.data.success) {
                 toastServerSuccess(res.data, { t })
+                const result = extractStampResult(res.data)
+                if (result) {
+                    setStamp(result)
+                    return
+                }
                 onOpenChange(false)
                 onSuccess()
             } else {
@@ -1102,6 +1173,22 @@ function GenericActionModal({ open, onOpenChange, action, model, record, endpoin
               ? '820px'
               : undefined
 
+    if (stamp) {
+        return (
+            <CfdiStampResultDialog
+                open={open}
+                result={stamp}
+                title={tl(action.label)}
+                onOpenChange={(o) => {
+                    if (o) return
+                    setStamp(undefined)
+                    onOpenChange(false)
+                    onSuccess()
+                }}
+            />
+        )
+    }
+
     return (
         <Dialog open={open} onOpenChange={onOpenChange}>
             {/* Sticky header + footer, scrollable body: the form can grow tall
@@ -1127,6 +1214,7 @@ function GenericActionModal({ open, onOpenChange, action, model, record, endpoin
                     (in FieldCell) keeps a long select/input value from blowing the
                     grid past the dialog and spawning a horizontal scrollbar. */}
                 <div className="-mx-1 min-h-0 flex-1 overflow-y-auto px-1 py-4">
+                    <FormErrorBanner message={formError} className="mb-3" />
                     <FieldGrid>
                         {action.fields?.map((field) => {
                             const fullWidth =
@@ -1183,7 +1271,7 @@ function GenericActionModal({ open, onOpenChange, action, model, record, endpoin
 // buildFieldDefaults seeds formData for a set of action fields, honoring the
 // same line-items prefill spec + boolean/empty rules GenericActionModal uses, so
 // wizard steps and single-page forms initialize identically.
-function buildFieldDefaults(fields: ActionFieldDef[], record: any): Record<string, any> {
+export function buildFieldDefaults(fields: ActionFieldDef[], record: any): Record<string, any> {
     const defaults: Record<string, any> = {}
     for (const field of fields) {
         if (isLineItemsField(field)) {
@@ -1235,6 +1323,8 @@ function WizardActionModal({ open, onOpenChange, action, model, record, endpoint
     const [stepIndex, setStepIndex] = useState(0)
     const [formData, setFormData] = useState<Record<string, any>>({})
     const [executing, setExecuting] = useState(false)
+    const [formError, setFormError] = useState<string | undefined>()
+    const [stamp, setStamp] = useState<CfdiStampResult | undefined>()
 
     // Reset to the first step and seed defaults for EVERY step's fields whenever
     // the modal (re)opens, so accumulated values from a prior run don't leak.
@@ -1243,6 +1333,7 @@ function WizardActionModal({ open, onOpenChange, action, model, record, endpoint
         const allFields = steps.flatMap((s) => s.fields ?? [])
         setFormData(buildFieldDefaults(allFields, record))
         setStepIndex(0)
+        setFormError(undefined)
     }, [open, action.steps, record])
 
     const updateField = (key: string, value: any) =>
@@ -1284,6 +1375,7 @@ function WizardActionModal({ open, onOpenChange, action, model, record, endpoint
             }
         }
         setExecuting(true)
+        setFormError(undefined)
         try {
             const url = buildActionUrl(endpoint, model, record?.id, action.key)
             const auth = await supervisor.authorize(
@@ -1297,14 +1389,22 @@ function WizardActionModal({ open, onOpenChange, action, model, record, endpoint
                 request: (reason) => api.post(url, withApproval(reason ? { ...formData, reason } : formData, auth)),
             })
             if (!res) return
+            const allFields = steps.flatMap(s => s.fields ?? [])
             if (res.data.success) {
                 toastServerSuccess(res.data, { t })
+                const result = extractStampResult(res.data)
+                if (result) {
+                    setStamp(result)
+                    return
+                }
                 onOpenChange(false)
                 onSuccess()
             } else {
-                toastActionError({ response: { data: res.data } }, steps.flatMap(s => s.fields ?? []), t, i18n.language)
+                setFormError(actionErrorBannerMessage({ response: { data: res.data } }, allFields, t, i18n.language))
+                toastActionError({ response: { data: res.data } }, allFields, t, i18n.language)
             }
         } catch (err: any) {
+            setFormError(actionErrorBannerMessage(err, steps.flatMap(s => s.fields ?? []), t, i18n.language))
             toastActionError(err, steps.flatMap(s => s.fields ?? []), t, i18n.language)
         } finally {
             setExecuting(false)
@@ -1313,6 +1413,22 @@ function WizardActionModal({ open, onOpenChange, action, model, record, endpoint
 
     if (steps.length === 0) return null
 
+    if (stamp) {
+        return (
+            <CfdiStampResultDialog
+                open={open}
+                result={stamp}
+                title={tl(action.label)}
+                onOpenChange={(o) => {
+                    if (o) return
+                    setStamp(undefined)
+                    onOpenChange(false)
+                    onSuccess()
+                }}
+            />
+        )
+    }
+
     return (
         <Dialog open={open} onOpenChange={onOpenChange}>
             <DialogContent
@@ -1347,6 +1463,7 @@ function WizardActionModal({ open, onOpenChange, action, model, record, endpoint
                     persist in the one formData object, so navigating back and
                     forth keeps entries intact. */}
                 <div className="-mx-1 min-h-0 flex-1 overflow-y-auto px-1 py-4">
+                    <FormErrorBanner message={formError} className="mb-3" />
                     <FieldGrid>
                         {stepFields.map((field) => {
                             const fullWidth =
@@ -1423,7 +1540,8 @@ function seedOptionFromRecord(
     }
 }
 
-function renderField(
+/** Renders one action field (same widgets as the action modals). Shared with DocumentFormDialog. */
+export function renderField(
     field: ActionFieldDef,
     value: any,
     onChange: (value: any) => void,