@asteby/metacore-runtime-react 39.2.3 → 39.2.4

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @asteby/metacore-runtime-react
 
+## 39.2.4
+
+### Patch Changes
+
+- c759e48: Los modales de acción que precargan renglones desde el registro (`$prefillFromRecord`, p. ej. "Recibir" de una orden de compra) ahora cargan las líneas desde la relación declarada del modelo cuando la fila de la lista no las trae. Antes el modal abría con "Sin renglones".
+
 ## 39.2.3
 
 ### Patch Changes

package/dist/action-modal-dispatcher.d.ts

@@ -20,6 +20,19 @@ export interface PrefillSpec {
 export declare function isPrefillSpec(v: unknown): v is PrefillSpec;
 export declare function applyPrefillLock(field: ActionFieldDef): ActionFieldDef;
 export declare function buildPrefillRows(spec: PrefillSpec, record: any): Array<Record<string, any>>;
+export interface PrefillRelationRequest {
+    fieldKey: string;
+    spec: PrefillSpec;
+    endpoint: string;
+    params: Record<string, string | number>;
+}
+export declare function prefillRelationRequests(fields: ActionFieldDef[] | undefined, record: any, relations: Array<{
+    name?: string;
+    kind?: string;
+    through?: string;
+    foreign_key?: string;
+    scope?: Record<string, unknown>;
+}>): PrefillRelationRequest[];
 export declare function unwrapRecordScalar(value: unknown): unknown;
 export declare function readRecordPath(record: any, path: string): unknown;
 /** Scalar seed for one action field from the row being acted on. */

package/dist/action-modal-dispatcher.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"action-modal-dispatcher.d.ts","sourceRoot":"","sources":["../src/action-modal-dispatcher.tsx"],"names":[],"mappings":"AAuEA,OAAO,KAAK,EAAE,cAAc,EAAmC,MAAM,SAAS,CAAA;AAE9E,OAAO,EACH,KAAK,cAAc,EACnB,KAAK,gBAAgB,EAExB,MAAM,sBAAsB,CAAA;AAE7B,YAAY,EAAE,cAAc,EAAE,gBAAgB,EAAE,CAAA;AAiBhD,MAAM,WAAW,WAAW;IACxB,kBAAkB,EAAE,MAAM,CAAA;IAC1B,GAAG,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;IAC5B,SAAS,CAAC,EAAE;QAAE,MAAM,EAAE,MAAM,CAAC;QAAC,EAAE,EAAE,MAAM,CAAC;QAAC,KAAK,CAAC,EAAE,MAAM,CAAA;KAAE,CAAA;IAC1D;;;;;OAKG;IACH,IAAI,CAAC,EAAE,MAAM,EAAE,CAAA;CAClB;AAED,wBAAgB,aAAa,CAAC,CAAC,EAAE,OAAO,GAAG,CAAC,IAAI,WAAW,CAM1D;AAsBD,wBAAgB,gBAAgB,CAAC,KAAK,EAAE,cAAc,GAAG,cAAc,CAStE;AAGD,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,WAAW,EAAE,MAAM,EAAE,GAAG,GAAG,KAAK,CAAC,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC,CAkB3F;AASD,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,OAAO,GAAG,OAAO,CAY1D;AAED,wBAAgB,cAAc,CAAC,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,MAAM,GAAG,OAAO,CASjE;AAUD,oEAAoE;AACpE,wBAAgB,uBAAuB,CAAC,KAAK,EAAE,cAAc,EAAE,MAAM,EAAE,GAAG,GAAG,OAAO,CAgBnF;AAED,wBAAgB,qBAAqB,CAAC,EAClC,IAAI,EACJ,YAAY,EACZ,MAAM,EACN,KAAK,EACL,MAAM,EACN,QAAQ,EACR,SAAS,GACZ,EAAE,gBAAgB,sCAkFlB"}
+{"version":3,"file":"action-modal-dispatcher.d.ts","sourceRoot":"","sources":["../src/action-modal-dispatcher.tsx"],"names":[],"mappings":"AAwEA,OAAO,KAAK,EAAE,cAAc,EAAmC,MAAM,SAAS,CAAA;AAE9E,OAAO,EACH,KAAK,cAAc,EACnB,KAAK,gBAAgB,EAExB,MAAM,sBAAsB,CAAA;AAE7B,YAAY,EAAE,cAAc,EAAE,gBAAgB,EAAE,CAAA;AAiBhD,MAAM,WAAW,WAAW;IACxB,kBAAkB,EAAE,MAAM,CAAA;IAC1B,GAAG,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;IAC5B,SAAS,CAAC,EAAE;QAAE,MAAM,EAAE,MAAM,CAAC;QAAC,EAAE,EAAE,MAAM,CAAC;QAAC,KAAK,CAAC,EAAE,MAAM,CAAA;KAAE,CAAA;IAC1D;;;;;OAKG;IACH,IAAI,CAAC,EAAE,MAAM,EAAE,CAAA;CAClB;AAED,wBAAgB,aAAa,CAAC,CAAC,EAAE,OAAO,GAAG,CAAC,IAAI,WAAW,CAM1D;AAsBD,wBAAgB,gBAAgB,CAAC,KAAK,EAAE,cAAc,GAAG,cAAc,CAStE;AAGD,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,WAAW,EAAE,MAAM,EAAE,GAAG,GAAG,KAAK,CAAC,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC,CAkB3F;AAYD,MAAM,WAAW,sBAAsB;IACnC,QAAQ,EAAE,MAAM,CAAA;IAChB,IAAI,EAAE,WAAW,CAAA;IACjB,QAAQ,EAAE,MAAM,CAAA;IAChB,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,MAAM,CAAC,CAAA;CAC1C;AAED,wBAAgB,uBAAuB,CACnC,MAAM,EAAE,cAAc,EAAE,GAAG,SAAS,EACpC,MAAM,EAAE,GAAG,EACX,SAAS,EAAE,KAAK,CAAC;IAAE,IAAI,CAAC,EAAE,MAAM,CAAC;IAAC,IAAI,CAAC,EAAE,MAAM,CAAC;IAAC,OAAO,CAAC,EAAE,MAAM,CAAC;IAAC,WAAW,CAAC,EAAE,MAAM,CAAC;IAAC,KAAK,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAA;CAAE,CAAC,GAC5H,sBAAsB,EAAE,CAyB1B;AASD,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,OAAO,GAAG,OAAO,CAY1D;AAED,wBAAgB,cAAc,CAAC,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,MAAM,GAAG,OAAO,CASjE;AAUD,oEAAoE;AACpE,wBAAgB,uBAAuB,CAAC,KAAK,EAAE,cAAc,EAAE,MAAM,EAAE,GAAG,GAAG,OAAO,CAgBnF;AAED,wBAAgB,qBAAqB,CAAC,EAClC,IAAI,EACJ,YAAY,EACZ,MAAM,EACN,KAAK,EACL,MAAM,EACN,QAAQ,EACR,SAAS,GACZ,EAAE,gBAAgB,sCAkFlB"}

package/dist/action-modal-dispatcher.js

@@ -23,6 +23,7 @@ import { validateValues, bagHasErrors } from './validator';
 import { clearFieldErrorTree, formatFieldErrorsDescription, labelsForValidationFields, labelForValidationPath, lineItemErrorsFor, } from './field-validation-ui';
 import { validationCatalog } from './validation-catalog';
 import { useApi } from './api-context';
+import { buildRelationFilterParams } from './dynamic-relation-helpers';
 import { DynamicIcon } from './dynamic-icon';
 import { DynamicLineItems } from './dynamic-line-items';
 import { DynamicRelations } from './dynamic-relations';
@@ -94,6 +95,36 @@ export function buildPrefillRows(spec, record) {
     }
     return rows;
 }
+export function prefillRelationRequests(fields, record, relations) {
+    const out = [];
+    const recordId = record?.id;
+    if (!fields || recordId === undefined || recordId === null || recordId === '')
+        return out;
+    for (const field of fields) {
+        if (!isLineItemsField(field))
+            continue;
+        const spec = lineItemsDefault(field);
+        if (!isPrefillSpec(spec))
+            continue;
+        if (Array.isArray(record?.[spec.$prefillFromRecord]))
+            continue; // already embedded
+        const rel = (relations || []).find((r) => r?.name === spec.$prefillFromRecord && (r.kind ?? 'one_to_many') === 'one_to_many');
+        if (!rel?.through || !rel.foreign_key)
+            continue;
+        const scope = {};
+        for (const [k, v] of Object.entries(rel.scope ?? {})) {
+            if (v !== undefined && v !== null)
+                scope[k] = String(v);
+        }
+        out.push({
+            fieldKey: field.key,
+            spec,
+            endpoint: `/data/${rel.through}`,
+            params: { ...buildRelationFilterParams(rel.foreign_key, recordId, scope), per_page: 200 },
+        });
+    }
+    return out;
+}
 // ---- scalar prefill from the acted-on record --------------------------------
 //
 // Row actions (stamp / refactura / cancel-with-reason) should open with the
@@ -457,6 +488,32 @@ function GenericActionModal({ open, onOpenChange, action, model, record, endpoin
             setFieldErrors({});
         }
     }, [open, action.fields, record]);
+    // Lines the list row does not carry: load them from the declared relation
+    // (see prefillRelationRequests) and seed the line-items grid.
+    useEffect(() => {
+        if (!open || relations.length === 0)
+            return;
+        const reqs = prefillRelationRequests(action.fields, record, relations);
+        if (reqs.length === 0)
+            return;
+        let cancelled = false;
+        for (const req of reqs) {
+            api.get(req.endpoint, { params: req.params })
+                .then((res) => {
+                if (cancelled)
+                    return;
+                const rows = res?.data?.data ?? res?.data ?? [];
+                if (!Array.isArray(rows))
+                    return;
+                const built = buildPrefillRows(req.spec, { [req.spec.$prefillFromRecord]: rows });
+                setFormData((prev) => ({ ...prev, [req.fieldKey]: built }));
+            })
+                .catch(() => { });
+        }
+        return () => {
+            cancelled = true;
+        };
+    }, [open, action.fields, record, relations, api]);
     const updateField = (key, value) => {
         setFormData((prev) => ({ ...prev, [key]: value }));
         setFieldErrors((prev) => clearFieldErrorTree(prev, key));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@asteby/metacore-runtime-react",
-  "version": "39.2.3",
+  "version": "39.2.4",
   "description": "React runtime for metacore hosts — renders addon contributions dynamically",
   "repository": {
     "type": "git",

package/src/__tests__/prefill-from-relation.test.ts

@@ -0,0 +1,42 @@
+import { describe, it, expect } from 'vitest'
+import { prefillRelationRequests } from '../action-modal-dispatcher'
+import type { ActionFieldDef } from '../types'
+
+// QA 7Leguas: the purchase-order receive modal opened from the LIST showed
+// "Sin renglones" — the list row carries no `items`, so the
+// $prefillFromRecord grid had nothing to project. The modal must load the
+// lines from the model's declared one_to_many relation.
+const itemsField: ActionFieldDef = {
+    key: 'items',
+    label: 'Renglones',
+    type: 'array',
+    itemFields: [
+        { key: 'product_id', label: 'Producto', type: 'dynamic_select', ref: 'Product' },
+        { key: 'qty_received', label: 'Recibido', type: 'number' },
+    ],
+    default: { $prefillFromRecord: 'items', map: { product_id: 'product_variant_id' } },
+} as unknown as ActionFieldDef
+
+const relations = [
+    { name: 'items', kind: 'one_to_many', through: 'PurchaseOrderItem', foreign_key: 'purchase_order_id' },
+    { name: 'goods_receipts', kind: 'one_to_many', through: 'GoodsReceipt', foreign_key: 'purchase_order_id' },
+]
+
+describe('prefillRelationRequests', () => {
+    it('pide las líneas por la relación declarada cuando el registro no las trae', () => {
+        const reqs = prefillRelationRequests([itemsField], { id: 'po-1' }, relations)
+        expect(reqs).toHaveLength(1)
+        expect(reqs[0].fieldKey).toBe('items')
+        expect(reqs[0].endpoint).toBe('/data/PurchaseOrderItem')
+        expect(reqs[0].params).toMatchObject({ f_purchase_order_id: 'eq:po-1' })
+    })
+
+    it('no pide nada si el registro ya trae las líneas embebidas', () => {
+        expect(prefillRelationRequests([itemsField], { id: 'po-1', items: [] }, relations)).toHaveLength(0)
+    })
+
+    it('no pide nada sin id (acción de creación) o sin relación con ese nombre', () => {
+        expect(prefillRelationRequests([itemsField], {}, relations)).toHaveLength(0)
+        expect(prefillRelationRequests([itemsField], { id: 'po-1' }, [relations[1]])).toHaveLength(0)
+    })
+})

package/src/action-modal-dispatcher.tsx

@@ -53,6 +53,7 @@ import {
 } from './field-validation-ui'
 import { validationCatalog } from './validation-catalog'
 import { useApi } from './api-context'
+import { buildRelationFilterParams } from './dynamic-relation-helpers'
 import { DynamicIcon } from './dynamic-icon'
 import { DynamicLineItems } from './dynamic-line-items'
 import { DynamicRelations } from './dynamic-relations'
@@ -167,6 +168,54 @@ export function buildPrefillRows(spec: PrefillSpec, record: any): Array<Record<s
     return rows
 }
 
+// ---- prefill lines from the record's declared relation ----------------------
+//
+// A row action opened from a LIST gets the list row, which does not carry the
+// document's lines: `record.items` is undefined and a receive modal opened
+// with "Sin renglones" (QA 7Leguas: OC receive modal empty, the user could not
+// see what was being received). When the prefill source key is missing from
+// the record but the model declares a one_to_many relation with that name, the
+// modal fetches the child rows the same way the relation panel does
+// (`/data/<through>?f_<fk>=eq:<id>`) and builds the rows from them.
+
+export interface PrefillRelationRequest {
+    fieldKey: string
+    spec: PrefillSpec
+    endpoint: string
+    params: Record<string, string | number>
+}
+
+export function prefillRelationRequests(
+    fields: ActionFieldDef[] | undefined,
+    record: any,
+    relations: Array<{ name?: string; kind?: string; through?: string; foreign_key?: string; scope?: Record<string, unknown> }>,
+): PrefillRelationRequest[] {
+    const out: PrefillRelationRequest[] = []
+    const recordId = record?.id
+    if (!fields || recordId === undefined || recordId === null || recordId === '') return out
+    for (const field of fields) {
+        if (!isLineItemsField(field)) continue
+        const spec = lineItemsDefault(field)
+        if (!isPrefillSpec(spec)) continue
+        if (Array.isArray(record?.[spec.$prefillFromRecord])) continue // already embedded
+        const rel = (relations || []).find(
+            (r) => r?.name === spec.$prefillFromRecord && (r.kind ?? 'one_to_many') === 'one_to_many',
+        )
+        if (!rel?.through || !rel.foreign_key) continue
+        const scope: Record<string, string> = {}
+        for (const [k, v] of Object.entries(rel.scope ?? {})) {
+            if (v !== undefined && v !== null) scope[k] = String(v)
+        }
+        out.push({
+            fieldKey: field.key,
+            spec,
+            endpoint: `/data/${rel.through}`,
+            params: { ...buildRelationFilterParams(rel.foreign_key, recordId, scope), per_page: 200 },
+        })
+    }
+    return out
+}
+
 // ---- scalar prefill from the acted-on record --------------------------------
 //
 // Row actions (stamp / refactura / cancel-with-reason) should open with the
@@ -686,6 +735,29 @@ function GenericActionModal({ open, onOpenChange, action, model, record, endpoin
         }
     }, [open, action.fields, record])
 
+    // Lines the list row does not carry: load them from the declared relation
+    // (see prefillRelationRequests) and seed the line-items grid.
+    useEffect(() => {
+        if (!open || relations.length === 0) return
+        const reqs = prefillRelationRequests(action.fields, record, relations)
+        if (reqs.length === 0) return
+        let cancelled = false
+        for (const req of reqs) {
+            api.get(req.endpoint, { params: req.params })
+                .then((res: any) => {
+                    if (cancelled) return
+                    const rows = res?.data?.data ?? res?.data ?? []
+                    if (!Array.isArray(rows)) return
+                    const built = buildPrefillRows(req.spec, { [req.spec.$prefillFromRecord]: rows })
+                    setFormData((prev: Record<string, any>) => ({ ...prev, [req.fieldKey]: built }))
+                })
+                .catch(() => {})
+        }
+        return () => {
+            cancelled = true
+        }
+    }, [open, action.fields, record, relations, api])
+
     const updateField = (key: string, value: any) => {
         setFormData((prev: Record<string, any>) => ({ ...prev, [key]: value }))
         setFieldErrors((prev) => clearFieldErrorTree(prev, key))