@asteby/metacore-runtime-react 37.1.1 → 37.1.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @asteby/metacore-runtime-react
 
+## 37.1.2
+
+### Patch Changes
+
+- 2d4e1d8: Fail closed when an action declares `modal` but no federated component is registered — never fall back to the generic confirm dialog.
+
 ## 37.1.1
 
 ### Patch Changes

package/dist/action-modal-dispatcher.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"action-modal-dispatcher.d.ts","sourceRoot":"","sources":["../src/action-modal-dispatcher.tsx"],"names":[],"mappings":"AAoEA,OAAO,KAAK,EAAE,cAAc,EAAmC,MAAM,SAAS,CAAA;AAE9E,OAAO,EACH,KAAK,cAAc,EACnB,KAAK,gBAAgB,EAExB,MAAM,sBAAsB,CAAA;AAE7B,YAAY,EAAE,cAAc,EAAE,gBAAgB,EAAE,CAAA;AAiBhD,MAAM,WAAW,WAAW;IACxB,kBAAkB,EAAE,MAAM,CAAA;IAC1B,GAAG,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;IAC5B,SAAS,CAAC,EAAE;QAAE,MAAM,EAAE,MAAM,CAAC;QAAC,EAAE,EAAE,MAAM,CAAC;QAAC,KAAK,CAAC,EAAE,MAAM,CAAA;KAAE,CAAA;IAC1D;;;;;OAKG;IACH,IAAI,CAAC,EAAE,MAAM,EAAE,CAAA;CAClB;AAED,wBAAgB,aAAa,CAAC,CAAC,EAAE,OAAO,GAAG,CAAC,IAAI,WAAW,CAM1D;AAsBD,wBAAgB,gBAAgB,CAAC,KAAK,EAAE,cAAc,GAAG,cAAc,CAStE;AAGD,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,WAAW,EAAE,MAAM,EAAE,GAAG,GAAG,KAAK,CAAC,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC,CAkB3F;AASD,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,OAAO,GAAG,OAAO,CAY1D;AAED,wBAAgB,cAAc,CAAC,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,MAAM,GAAG,OAAO,CASjE;AAUD,oEAAoE;AACpE,wBAAgB,uBAAuB,CAAC,KAAK,EAAE,cAAc,EAAE,MAAM,EAAE,GAAG,GAAG,OAAO,CAgBnF;AAED,wBAAgB,qBAAqB,CAAC,EAClC,IAAI,EACJ,YAAY,EACZ,MAAM,EACN,KAAK,EACL,MAAM,EACN,QAAQ,EACR,SAAS,GACZ,EAAE,gBAAgB,sCAoElB"}
+{"version":3,"file":"action-modal-dispatcher.d.ts","sourceRoot":"","sources":["../src/action-modal-dispatcher.tsx"],"names":[],"mappings":"AAsEA,OAAO,KAAK,EAAE,cAAc,EAAmC,MAAM,SAAS,CAAA;AAE9E,OAAO,EACH,KAAK,cAAc,EACnB,KAAK,gBAAgB,EAExB,MAAM,sBAAsB,CAAA;AAE7B,YAAY,EAAE,cAAc,EAAE,gBAAgB,EAAE,CAAA;AAiBhD,MAAM,WAAW,WAAW;IACxB,kBAAkB,EAAE,MAAM,CAAA;IAC1B,GAAG,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;IAC5B,SAAS,CAAC,EAAE;QAAE,MAAM,EAAE,MAAM,CAAC;QAAC,EAAE,EAAE,MAAM,CAAC;QAAC,KAAK,CAAC,EAAE,MAAM,CAAA;KAAE,CAAA;IAC1D;;;;;OAKG;IACH,IAAI,CAAC,EAAE,MAAM,EAAE,CAAA;CAClB;AAED,wBAAgB,aAAa,CAAC,CAAC,EAAE,OAAO,GAAG,CAAC,IAAI,WAAW,CAM1D;AAsBD,wBAAgB,gBAAgB,CAAC,KAAK,EAAE,cAAc,GAAG,cAAc,CAStE;AAGD,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,WAAW,EAAE,MAAM,EAAE,GAAG,GAAG,KAAK,CAAC,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC,CAkB3F;AASD,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,OAAO,GAAG,OAAO,CAY1D;AAED,wBAAgB,cAAc,CAAC,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,MAAM,GAAG,OAAO,CASjE;AAUD,oEAAoE;AACpE,wBAAgB,uBAAuB,CAAC,KAAK,EAAE,cAAc,EAAE,MAAM,EAAE,GAAG,GAAG,OAAO,CAgBnF;AAED,wBAAgB,qBAAqB,CAAC,EAClC,IAAI,EACJ,YAAY,EACZ,MAAM,EACN,KAAK,EACL,MAAM,EACN,QAAQ,EACR,SAAS,GACZ,EAAE,gBAAgB,sCAkFlB"}

package/dist/action-modal-dispatcher.js

@@ -1,11 +1,13 @@
 import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
 // ActionModalDispatcher — renders the right modal for a custom action:
 // 1) Custom component from the SDK registry → use it
-// 2) action.fields[] / action.steps[] → GenericActionModal / WizardActionModal
-// 3) action.confirm OR action.confirmMessage → ConfirmActionDialog
-// 4) action.executable (host opened the modal; federated UI missing) →
+// 2) action.modal set but no registered component → MissingCustomActionModal
+//    (NEVER fall back to confirm/fields — that hides a broken federated UI)
+// 3) action.fields[] / action.steps[] → GenericActionModal / WizardActionModal
+// 4) action.confirm OR action.confirmMessage → ConfirmActionDialog
+// 5) action.executable (host opened the modal; no modal/fields/confirm) →
 //    ConfirmActionDialog so a click never silently no-ops
-// 5) otherwise → null (caller should execute immediately without opening us)
+// 6) otherwise → null (caller should execute immediately without opening us)
 //
 // The host injects its axios-like client via <ApiProvider>; we no longer
 // depend on a bundler alias to `@/lib/api`.
@@ -158,6 +160,11 @@ export function ActionModalDispatcher({ open, onOpenChange, action, model, recor
     if (CustomComponent) {
         return (_jsx(CustomComponent, { open: open, onOpenChange: onOpenChange, action: action, model: model, record: record, endpoint: endpoint, onSuccess: onSuccess }));
     }
+    // Declarative custom slot (`modal: "addon.action"`). Prefer a hard error
+    // over confirm/fields generics — those look "fine" and hide a missing remote.
+    if (action.modal) {
+        return (_jsx(MissingCustomActionModal, { open: open, onOpenChange: onOpenChange, action: action, model: model }));
+    }
     if (action.steps && action.steps.length > 0) {
         return (_jsx(WizardActionModal, { open: open, onOpenChange: onOpenChange, action: action, model: model, record: record, endpoint: endpoint, onSuccess: onSuccess }));
     }
@@ -168,12 +175,28 @@ export function ActionModalDispatcher({ open, onOpenChange, action, model, recor
     // boolean). Hosts also mark every wasm action `executable` and open THIS
     // dispatcher; without a confirm/fields/custom UI we used to return null and
     // the row click did nothing. Treat message-only + executable-open as confirm.
+    // Never reached when action.modal is set (handled above).
     const wantsConfirm = !!(action.confirm || action.confirmMessage);
     if (wantsConfirm || (open && action.executable)) {
         return (_jsx(ConfirmActionDialog, { open: open, onOpenChange: onOpenChange, action: action, model: model, record: record, endpoint: endpoint, onSuccess: onSuccess }));
     }
     return null;
 }
+/** Shown when the action declares `modal` but no federated component registered. */
+function MissingCustomActionModal({ open, onOpenChange, action, model, }) {
+    const { t } = useTranslation();
+    const slug = action.modal || '';
+    const title = t('dynamic.action_modal_missing_title', {
+        defaultValue: 'No se pudo cargar el formulario',
+    });
+    const description = t('dynamic.action_modal_missing_description', {
+        defaultValue: 'Esta acción requiere una interfaz personalizada ({{slug}}) que no está registrada. Recarga la página o reinstala el módulo; no se abre un confirmatorio genérico para no confundir el flujo.',
+        slug: slug || `${model}.${action.key}`,
+        action: action.key,
+        model,
+    });
+    return (_jsx(AlertDialog, { open: open, onOpenChange: onOpenChange, children: _jsxs(AlertDialogContent, { children: [_jsxs(AlertDialogHeader, { children: [_jsx(AlertDialogTitle, { children: title }), _jsx(AlertDialogDescription, { children: description })] }), _jsx(AlertDialogFooter, { children: _jsx(AlertDialogAction, { onClick: () => onOpenChange(false), children: t('common.close', { defaultValue: 'Cerrar' }) }) })] }) }));
+}
 function buildActionUrl(endpoint, model, recordId, actionKey) {
     // A create-placement (collection) action has no record yet, so `recordId`
     // is undefined. Omit the `/{id}` segment so the request hits the collection

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@asteby/metacore-runtime-react",
-  "version": "37.1.1",
+  "version": "37.1.2",
   "description": "React runtime for metacore hosts — renders addon contributions dynamically",
   "repository": {
     "type": "git",
@@ -67,8 +67,8 @@
     "typescript": "^6.0.0",
     "vitest": "^4.0.0",
     "zustand": "^5.0.0",
-    "@asteby/metacore-sdk": "3.7.0",
-    "@asteby/metacore-ui": "2.17.3"
+    "@asteby/metacore-ui": "2.17.3",
+    "@asteby/metacore-sdk": "3.7.0"
   },
   "scripts": {
     "build": "tsc -p tsconfig.json",

package/src/__tests__/action-modal-missing-custom.test.tsx

@@ -0,0 +1,76 @@
+// @vitest-environment happy-dom
+//
+// When an action declares `modal: "<slug>"` and no federated component is
+// registered, ActionModalDispatcher must surface an error — never the generic
+// ConfirmActionDialog (even if confirm/confirmMessage are also set).
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { cleanup, render, screen } from '@testing-library/react'
+
+vi.mock('react-i18next', () => ({
+    useTranslation: () => ({
+        t: (_k: string, opts?: { defaultValue?: string }) => opts?.defaultValue ?? _k,
+    }),
+}))
+
+import { ActionModalDispatcher } from '../action-modal-dispatcher'
+import { ApiProvider, type ApiClient } from '../api-context'
+import {
+    registerActionComponent,
+    unregisterActionComponent,
+    type ActionMetadata,
+} from '@asteby/metacore-sdk'
+
+afterEach(() => {
+    cleanup()
+    unregisterActionComponent('SalesOrder', 'authorize_credit')
+})
+
+const noopApi: ApiClient = {
+    get: vi.fn().mockResolvedValue({ data: {} }),
+    post: vi.fn().mockResolvedValue({ data: { success: true } }),
+} as unknown as ApiClient
+
+const creditAction: ActionMetadata = {
+    key: 'authorize_credit',
+    label: 'Autorizar a crédito',
+    icon: 'Landmark',
+    modal: 'credit_approval.authorize_credit',
+    confirm: true,
+    confirmMessage: 'customers.action.authorize_credit_confirm_message',
+    executable: true,
+}
+
+function renderDispatcher(action: ActionMetadata = creditAction) {
+    return render(
+        <ApiProvider client={noopApi}>
+            <ActionModalDispatcher
+                open
+                onOpenChange={() => {}}
+                action={action}
+                model="SalesOrder"
+                record={{ id: '1', folio: 'SO-1' } as any}
+                endpoint="/data/SalesOrder"
+                onSuccess={() => {}}
+            />
+        </ApiProvider>,
+    )
+}
+
+describe('ActionModalDispatcher custom modal contract', () => {
+    it('errors when modal is declared but no component is registered (no generic confirm)', () => {
+        renderDispatcher()
+        expect(screen.getByText('No se pudo cargar el formulario')).toBeTruthy()
+        expect(screen.queryByText('customers.action.authorize_credit_confirm_message')).toBeNull()
+        expect(screen.queryByRole('button', { name: /autorizar a crédito/i })).toBeNull()
+    })
+
+    it('renders the registered custom component when present', () => {
+        function CustomModal() {
+            return <div data-testid="credit-dossier">dossier</div>
+        }
+        registerActionComponent('SalesOrder', 'authorize_credit', CustomModal as never)
+        renderDispatcher()
+        expect(screen.getByTestId('credit-dossier')).toBeTruthy()
+        expect(screen.queryByText('No se pudo cargar el formulario')).toBeNull()
+    })
+})

package/src/action-modal-dispatcher.tsx

@@ -1,10 +1,12 @@
 // ActionModalDispatcher — renders the right modal for a custom action:
 // 1) Custom component from the SDK registry → use it
-// 2) action.fields[] / action.steps[] → GenericActionModal / WizardActionModal
-// 3) action.confirm OR action.confirmMessage → ConfirmActionDialog
-// 4) action.executable (host opened the modal; federated UI missing) →
+// 2) action.modal set but no registered component → MissingCustomActionModal
+//    (NEVER fall back to confirm/fields — that hides a broken federated UI)
+// 3) action.fields[] / action.steps[] → GenericActionModal / WizardActionModal
+// 4) action.confirm OR action.confirmMessage → ConfirmActionDialog
+// 5) action.executable (host opened the modal; no modal/fields/confirm) →
 //    ConfirmActionDialog so a click never silently no-ops
-// 5) otherwise → null (caller should execute immediately without opening us)
+// 6) otherwise → null (caller should execute immediately without opening us)
 //
 // The host injects its axios-like client via <ApiProvider>; we no longer
 // depend on a bundler alias to `@/lib/api`.
@@ -251,6 +253,19 @@ export function ActionModalDispatcher({
         )
     }
 
+    // Declarative custom slot (`modal: "addon.action"`). Prefer a hard error
+    // over confirm/fields generics — those look "fine" and hide a missing remote.
+    if (action.modal) {
+        return (
+            <MissingCustomActionModal
+                open={open}
+                onOpenChange={onOpenChange}
+                action={action}
+                model={model}
+            />
+        )
+    }
+
     if (action.steps && action.steps.length > 0) {
         return (
             <WizardActionModal
@@ -283,6 +298,7 @@ export function ActionModalDispatcher({
     // boolean). Hosts also mark every wasm action `executable` and open THIS
     // dispatcher; without a confirm/fields/custom UI we used to return null and
     // the row click did nothing. Treat message-only + executable-open as confirm.
+    // Never reached when action.modal is set (handled above).
     const wantsConfirm = !!(action.confirm || action.confirmMessage)
     if (wantsConfirm || (open && action.executable)) {
         return (
@@ -301,6 +317,47 @@ export function ActionModalDispatcher({
     return null
 }
 
+/** Shown when the action declares `modal` but no federated component registered. */
+function MissingCustomActionModal({
+    open,
+    onOpenChange,
+    action,
+    model,
+}: {
+    open: boolean
+    onOpenChange: (open: boolean) => void
+    action: ActionMetadata
+    model: string
+}) {
+    const { t } = useTranslation()
+    const slug = action.modal || ''
+    const title = t('dynamic.action_modal_missing_title', {
+        defaultValue: 'No se pudo cargar el formulario',
+    })
+    const description = t('dynamic.action_modal_missing_description', {
+        defaultValue:
+            'Esta acción requiere una interfaz personalizada ({{slug}}) que no está registrada. Recarga la página o reinstala el módulo; no se abre un confirmatorio genérico para no confundir el flujo.',
+        slug: slug || `${model}.${action.key}`,
+        action: action.key,
+        model,
+    })
+    return (
+        <AlertDialog open={open} onOpenChange={onOpenChange}>
+            <AlertDialogContent>
+                <AlertDialogHeader>
+                    <AlertDialogTitle>{title}</AlertDialogTitle>
+                    <AlertDialogDescription>{description}</AlertDialogDescription>
+                </AlertDialogHeader>
+                <AlertDialogFooter>
+                    <AlertDialogAction onClick={() => onOpenChange(false)}>
+                        {t('common.close', { defaultValue: 'Cerrar' })}
+                    </AlertDialogAction>
+                </AlertDialogFooter>
+            </AlertDialogContent>
+        </AlertDialog>
+    )
+}
+
 function buildActionUrl(endpoint: string | undefined, model: string, recordId: string | undefined, actionKey: string) {
     // A create-placement (collection) action has no record yet, so `recordId`
     // is undefined. Omit the `/{id}` segment so the request hits the collection