@asteby/metacore-runtime-react 34.1.0 → 35.0.0

package/src/dynamic-select-field.tsx

@@ -22,6 +22,7 @@
 // value). A dedicated `?ids=` lookup is a follow-up; create flows — the common
 // case — start empty and never hit this.
 import { useEffect, useRef, useState } from 'react'
+import { useTranslation } from 'react-i18next'
 import {
     Badge,
     Button,
@@ -205,6 +206,9 @@ export function DynamicSelectField({
     descriptionAsBadge = false,
     hideCreate = false,
 }: DynamicSelectFieldProps) {
+    const { t } = useTranslation()
+    const ph = (fallback: string) =>
+        field.placeholder ? t(field.placeholder, { defaultValue: field.placeholder }) : fallback
     const [open, setOpen] = useState(false)
     const [search, setSearch] = useState('')
     const [scanOpen, setScanOpen] = useState(false)
@@ -353,7 +357,7 @@ export function DynamicSelectField({
                     <span className={'min-w-0 flex-1 truncate ' + (selectedOption ? '' : 'text-muted-foreground')}>
                         {/* Never flash the raw id: until the eager fetch resolves the
                             option, show a loading hint instead of String(value). */}
-                        {selectedOption?.label ?? (loading ? 'Cargando…' : field.placeholder || '—')}
+                        {selectedOption?.label ?? (loading ? 'Cargando…' : ph('—'))}
                     </span>
                 </span>
             </Button>
@@ -386,7 +390,7 @@ export function DynamicSelectField({
                         <span className={'min-w-0 flex-1 truncate ' + (selectedLabel ? '' : 'text-muted-foreground')}>
                             {blockedByDependency
                                 ? (dependsHint || DEFAULT_DEPENDS_HINT)
-                                : selectedLabel || field.placeholder || 'Buscar…'}
+                                : selectedLabel || ph('Buscar…')}
                         </span>
                         {descriptionAsBadge && selectedOption?.description ? (
                             <Badge variant="secondary" className="shrink-0 font-normal tabular-nums">
@@ -406,7 +410,7 @@ export function DynamicSelectField({
             >
                 <Command shouldFilter={false}>
                     <CommandInput
-                        placeholder={field.placeholder || 'Buscar…'}
+                        placeholder={ph('Buscar…')}
                         value={search}
                         onValueChange={setSearch}
                     />

package/src/use-print-document.ts

@@ -33,10 +33,36 @@ export interface PrintDocumentArgs {
      * open   → open the PDF in a new tab (user prints from the viewer).
      */
     mode?: 'print' | 'download' | 'open'
-    /** Filename for the download mode (defaults to "<key>.pdf"). */
+    /**
+     * Hint filename for download mode. Prefer leaving this unset: the server
+     * expands `{{record.*}}` into Content-Disposition. A raw template string
+     * (e.g. "cfdi-{{record.number}}.pdf") must NOT be used as a.download —
+     * that is how downloads end up literally named with mustache braces.
+     */
     filename?: string
 }
 
+/** Parse filename from Content-Disposition (RFC 5987 / quoted). */
+export function filenameFromContentDisposition(header: string | undefined | null): string | undefined {
+    if (!header) return undefined
+    const star = /filename\*\s*=\s*UTF-8''([^;]+)/i.exec(header)
+    if (star?.[1]) {
+        try {
+            return decodeURIComponent(star[1].trim().replace(/^"|"$/g, ''))
+        } catch {
+            return star[1].trim().replace(/^"|"$/g, '')
+        }
+    }
+    const plain = /filename\s*=\s*"([^"]+)"|filename\s*=\s*([^;]+)/i.exec(header)
+    const raw = (plain?.[1] ?? plain?.[2] ?? '').trim()
+    return raw || undefined
+}
+
+/** True when a caller passed an unexpanded mustache template as filename. */
+export function looksLikeFilenameTemplate(name: string | undefined): boolean {
+    return !!name && /\{\{/.test(name)
+}
+
 /**
  * Returns a `printDocument(args)` callback. Resolves once the PDF has been
  * fetched and the browser action (print/download/open) has been kicked off;
@@ -65,9 +91,19 @@ export function usePrintDocument() {
             const cleanup = () => setTimeout(() => URL.revokeObjectURL(blobUrl), 60_000)
 
             if (mode === 'download') {
+                const headers = (res as { headers?: Record<string, string> }).headers || {}
+                const fromHeader =
+                    filenameFromContentDisposition(
+                        headers['content-disposition'] || headers['Content-Disposition'],
+                    ) || undefined
+                // Prefer server-expanded name; never use a raw {{record.*}} template.
+                const downloadName =
+                    fromHeader ||
+                    (!looksLikeFilenameTemplate(filename) ? filename : undefined) ||
+                    `${key}.pdf`
                 const a = document.createElement('a')
                 a.href = blobUrl
-                a.download = filename || `${key}.pdf`
+                a.download = downloadName
                 document.body.appendChild(a)
                 a.click()
                 a.remove()